- 13 Sep, 2017 40 commits
-
-
sczs authored
This is CL 1 of 2 for removing BrowsingDataRemovalControllerDelegate. Bug: 648940 Change-Id: I18d43e008388138d303ad165a313110d2c3b940c Reviewed-on: https://chromium-review.googlesource.com/654377 Commit-Queue: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#501630}
-
Olga Sharonova authored
Connection to mojo audio system interface is bound to a thread. If we limit AudioSystem clients to use AudioSystem on a specific thread, it would mean we are introducing extra thread hops. So, instead of having a global AudioSystem instance bound to a specific thread, we are introducing one AudioSystem instance per client, and they are free to use that instance on any (one) thread they want. ---------One AudioSystem per client: 1) Extentions: *** ChromeVirtualKeyboardDelegate *** WebRtcAudioPrivate function (one AudioSystem instance for each function instance) 2) BrowserMainLoop: Owns AudioSystem instance and passes its pointer to *** SpeechRecognitionManager *** MediaStreamManager (AudioSystem instance is passed around a scary "manager" cluster: in AudioInputDeviceManager and MediaDevicesmanager members of MediaStreamManager and also in MediaDevicesDispatcherHost) *** AudioOutputAuthorizationHandler ----------AudioSystem::GetInstance factory method is introduced. It creates AudioSystemImpl instance and passes global AudioManager instance to it. Later we can make a finch-based decision to create AudioSysteToMojoAdapter there instead; or just switch to Mojo entirely. Bug: 740943 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I26a98376fb9edc33aba7c039e392849a460132e4 Reviewed-on: https://chromium-review.googlesource.com/655437 Commit-Queue: Olga Sharonova <olka@chromium.org> Reviewed-by:
Patrik Höglund <phoglund@chromium.org> Reviewed-by:
Max Morin <maxmorin@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#501629}
-
Mohamad Ahmadi authored
Bug:764473 before: https://drive.google.com/open?id=0B-GXJsF3pXyjUGVnaTFfTVBtamc after: https://drive.google.com/open?id=0B-GXJsF3pXyjRzVBenpfYy1OZjg Change-Id: I1df52d623da2b197f4385863fae4c16ddd16a240 Reviewed-on: https://chromium-review.googlesource.com/663839 Commit-Queue: Marc-Antoine Courteau <macourteau@chromium.org> Reviewed-by:
Marc-Antoine Courteau <macourteau@chromium.org> Cr-Commit-Position: refs/heads/master@{#501628}
-
galinap authored
Before sending a fetch request for suggestions for the current context to the native side, we want to check if the current URL is valid. If there is no active tab (which is the case when all tabs are dismissed), we clear the suggestions. If the URL is not a HTTP or a HTTP URL, we clear the suggestions. We also want to make sure that we don't initiate a fetch when the carousel already has suggestions for the current context. To do this, we compare if the new URL and the old URL are the same excluding the fragments. In all these cases we don't send a request to the native side. Otherwise, if the URL is a new network URL, we send a request to the backend. Bug: 745660 Change-Id: Iab7680e8e704f3de6fb4ed88be9e26c0fda3deca Reviewed-on: https://chromium-review.googlesource.com/646326 Commit-Queue: Galia Peycheva <galinap@google.com> Reviewed-by:
Andre Gaschler <gaschler@chromium.org> Reviewed-by:
Nicolas Dossou-Gbété <dgn@chromium.org> Cr-Commit-Position: refs/heads/master@{#501627}
-
Ondrej Skopek authored
Substitutes a string-based check in |startListeningMessageAnimation_| for a proper check of the current state in the speech module. Adjusts tests (and adds new ones) accordingly. Removes last TODO from voice.js. Bug: 583291 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Ica08d32233eb69ae5b1930aeb00f34e879eadddf Reviewed-on: https://chromium-review.googlesource.com/663731 Commit-Queue: Ondrej Škopek <oskopek@google.com> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#501626}
-
Aaron Leventhal authored
After this should be better for Braille output, easier to predict for speech, and more accurately represents the format. For example 2 links on separate lines of HTML source will have a whitespace node between them -- this is rendered on the screen but until this CL did not show up in the a11y tree. It also corrects the word boundary algorithm so that the start of a word does not occur in a whitespace-only node. ChromeVox's move-by-word algorithm was adjusted to be able to find the next node when the current one did not have a word stop. Bug: None Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I4f7aa1624a2b5f7efb3d957656ec0b11fcc2a9af Reviewed-on: https://chromium-review.googlesource.com/657561Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#501625}
-
skia-deps-roller@chromium.org authored
https://skia.googlesource.com/skia.git/+log/adf17dc52ff4..489bef054ee9 $ git log adf17dc52..489bef054 --date=short --no-merges --format='%ad %ae %s' 2017-09-13 rmistry Use Chrome-GPU pool for CT GPU runs Created with: roll-dep src/third_party/skia Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Ie23b066da2f73cbb9b39be7003182aa0b73d2289 Reviewed-on: https://chromium-review.googlesource.com/664917Reviewed-by:
Skia Deps Roller <skia-deps-roller@chromium.org> Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501624}
-
Mohamad Ahmadi authored
Bug:763499 after: https://drive.google.com/file/d/0B-GXJsF3pXyjRm4zbHVsaTFfSGs/view?usp=sharing before: https://drive.google.com/file/d/0B-GXJsF3pXyjWUx5MG81QWFKNnM/view?usp=sharing Change-Id: Iba3625cf83a626b38c4cf338650d0c98f06f674d Reviewed-on: https://chromium-review.googlesource.com/664217Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 4560fda0. Build: https://build.chromium.org/p/chromium.infra.cron/builders/wpt-importer/builds/1675 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: alexander.shalamov@intel.com, mikhail.pozdnyakov@intel.com, rijubrata.bhaumik@intel.com, timvolodine@chromium.org: external/wpt/generic-sensor bajones@chromium.org: external/wpt/gamepad drott@chromium.org: external/wpt/css-fonts hta@chromium.org: external/wpt/webrtc TBR=qyearsley@chromium.org No-Export: true Change-Id: I84eab53cd30d672d25fe2af3d5e9747b51445d70 Reviewed-on: https://chromium-review.googlesource.com/664100 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501622}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/fd1dd40d..bbfd15c4 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: If6e6e89b8eda7f2bedd77dd43b35168b43cfcd14 Reviewed-on: https://chromium-review.googlesource.com/664838Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#501621}
-
Yaron Friedman authored
This isn't the best solution but it means that we should get less random native stacks by not causing JNI abort. Basically, the OutputStream.toString call is known to allocate a java buffer of long enough size to fit the full exception stack trace which is bad if we're close to OOM threshhold. Since we didn't check for errors, we can end up using a local java stale reference that isn't actually valid. To avoid this, just drop the error, and allocate a small amount of native heap which based on crashes seems fine. Evidence of this happening in practice is its some amount of the: 1648 attempt to use stale local reference mentioned in the bug. And concrete example: https://crash.corp.google.com/browse?q=product.name%3D%27Chrome_Android%27%20AND%20custom_data.ChromeCrashProto.ptype%3D%27browser%27%20AND%20custom_data.ChromeCrashProto.magic_signature_1.name%3D%27da39a3ee_5e6b4b0d_3255bfef_95601890_afd80709%27%20OMIT%20RECORD%20IF%20SUM(special_protos.android_info.logcat_errors%20LIKE%20%27%25JNI%20ERROR%25%27)%20%3D%200&sql_dialect=dremelsql&ignore_case=false&enable_rewrite=false&omit_field_name=&omit_field_value=&omit_field_opt=&unnest=&stbtiq=&reportid=25304dba4c9bd9f9&index=2#7 The hope is that by not clobbering the original bug (in this case OOM from restoring tabstate in persistent store) these can be easier to triage. That's the hope anyway :/ BUG=726426 Change-Id: I3b40f432a2cb32c8b7a0777cdc1c5f1f7c9f100f Reviewed-on: https://chromium-review.googlesource.com/658067Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#501620}
-
Gabriel Charette authored
R=rdevlin.cronin@chromium.org Bug: 667892 Change-Id: I56f8529830ea5ec8e0684088448b99bc5b29a31d Reviewed-on: https://chromium-review.googlesource.com/664300 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Christian Dullweber authored
This reverts commit 714aff4e. Reason for revert: Revert to see if "WebKit Linux Trusty MSAN" creates a v8_context_snapshot.bin again. Original change's description: > bindings: Disable V8 context snapshot feature on cross compile environment > > This change can disable the feature on some environments which are > going well, but this is a simple fix to fix the build error on > "32-bit ASAN V8 ARM Builders" bots. > > > Bug: 760120 > Change-Id: I09dc29b61118409baf7f7b538ce376574df175be > Reviewed-on: https://chromium-review.googlesource.com/662962 > Reviewed-by: Kentaro Hara <haraken@chromium.org> > Reviewed-by: Yuki Shiino <yukishiino@chromium.org> > Commit-Queue: Hitoshi Yoshida <peria@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501533} TBR=peria@chromium.org,yukishiino@chromium.org,haraken@chromium.org NOTRY=true Change-Id: I613de5108c3a64b24c20f4c16349ab5aeeca8cc4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 760120 Reviewed-on: https://chromium-review.googlesource.com/665137Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#501618}
-
Alex Clarke authored
Bug: Change-Id: I493efd4d2daf9c9d905ad883bf29494b5182c85b Reviewed-on: https://chromium-review.googlesource.com/664808 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#501617}
-
Helen Li authored
SDCH has been disabled in Chrome since M59. For more details please see Issue 690070 and blink-dev@ thread linked below. The code in storage_partition_http_cache_data_remover.cc is no-op since M59. This CL removes it. Bug: 762686 Change-Id: I283aa34c5c2c1ef13744414aa7bda275b60c7d47 Reviewed-on: https://chromium-review.googlesource.com/663632Reviewed-by:
Bernhard Bauer <bauerb@chromium.org> Commit-Queue: Helen Li <xunjieli@chromium.org> Cr-Commit-Position: refs/heads/master@{#501616}
-
Biao She authored
Bug: 764441 Change-Id: I846ad56161e378ac64af677666f37c535e4f2b2f Reviewed-on: https://chromium-review.googlesource.com/664017Reviewed-by:
Brandon Jones <bajones@chromium.org> Commit-Queue: Biao She <bshe@chromium.org> Cr-Commit-Position: refs/heads/master@{#501615}
-
Sylvain Defresne authored
Disable sending kTabModelNewTabWillOpenNotification notification when the TabModel is restoring a session as this breaks the BVC state that does not expect the notification to be sent when a tab is added due to session restoration. Bug: 763964 Change-Id: I404487b5a561e43fe4d23303c004e4d3e8701dfe Reviewed-on: https://chromium-review.googlesource.com/664557Reviewed-by:
Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#501614}
-
Ira Burak authored
Bug: 753485 Change-Id: I157bdfbdfeb29ff00df39cc220f1cbf4f10475a0 Reviewed-on: https://chromium-review.googlesource.com/615664 Commit-Queue: Ira Burak <iburak@google.com> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#501613}
-
Peter K. Lee authored
This is adding another variable of a string that can be used for the mailto: handler prompt. Bug: 764324 Change-Id: Ifd982e71b99d46b27bcfc8a99ceaed5713a8c2e4 Reviewed-on: https://chromium-review.googlesource.com/664315Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#501612}
-
Mark Cogan authored
This test, disabled because it fails in iOS 11b3 and b4, works correctly under beta 6. This CL can be landed when beta 6 is on the trybots. Bug: 748738 Change-Id: I514eaa8dc104bff6f38b13bff2f541e18edbddbf Reviewed-on: https://chromium-review.googlesource.com/647746Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#501611}
-
David Tseng authored
Bug: Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I403f6a8d408a068860f1baa06a7e2b6a78300399 Reviewed-on: https://chromium-review.googlesource.com/654140 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
-
Rohit Rao authored
This test is failing flakily on the bots. BUG=764691 Change-Id: Ief33f7d5613a12610d6734db0ce798ac7564644c Reviewed-on: https://chromium-review.googlesource.com/664957Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#501609}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/49fbcfa16b5d..596aa47eec50 $ git log 49fbcfa16..596aa47ee --date=short --no-merges --format='%ad %ae %s' 2017-09-13 perezju [experimental/qbot] Python module to interact with Buildbot Created with: roll-dep src/third_party/catapult Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, see: http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ie1ccfa618f24fd437c95ea119e918fdc09b545fe Reviewed-on: https://chromium-review.googlesource.com/664597 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#501608}
-
Gabriel Charette authored
R=rdevlin.cronin@chromium.org Bug: 667892 Change-Id: I21df3c5a2eac7d6a5d2b1a3bc0322d752baca286 Reviewed-on: https://chromium-review.googlesource.com/663767 Commit-Queue: Gabriel Charette <gab@chromium.org> Reviewed-by:
-
Gabriel Charette authored
ios/ equivalent to https://codereview.chromium.org/2841593003 R=sdefresne@chromium.org Bug: 689520 Change-Id: I6aa6a0042f26177f9db38053f9c05bb1402aaf75 Reviewed-on: https://chromium-review.googlesource.com/664064Reviewed-by:
-
Chris Pickel authored
I renamed the class, but forgot to change the manifest, and the class became incapable of receiving intents. Bug: 764646 Change-Id: Ie6128bd2ea07c0b0d0eb8eefc1d17b1354911c30 Reviewed-on: https://chromium-review.googlesource.com/663730Reviewed-by:
-
Rohit Rao authored
This test was already disabled on iOS 11 iPad, but it has started failing on iPhone as well in the iOS 11 GM build. BUG=753098 Change-Id: I7abf2cf6bc0a4547abfbcd5e0193903dd3f55d83 Reviewed-on: https://chromium-review.googlesource.com/664837 Commit-Queue: Rohit Rao (ping after 24h) <rohitrao@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Reviewed-by:
-
Yuki Shiino authored
Creates a new header TraceWrapperBase.h and makes ScriptWrappable.h and TraceWrapperMember.h include TraceWrapperBase.h that defines TraceWrapperBase class. Bug: Change-Id: I9135b9394ef4a116322d6f9fc1ac97969e4735f3 Reviewed-on: https://chromium-review.googlesource.com/664503Reviewed-by:
-
Walter Korman authored
Change-Id: Iba7b4793e70ab7cda182b0fba47beef117119e20 Reviewed-on: https://chromium-review.googlesource.com/664385Reviewed-by:
Ned Nguyen <nednguyen@google.com> Commit-Queue: Ned Nguyen <nednguyen@google.com> Cr-Commit-Position: refs/heads/master@{#501602}
-
Marti Wong authored
Demo: https://drive.google.com/open?id=0B1O0Z7eoZMuGbjM3TnJ3eVRoYmM Bug: 695749 Change-Id: Id1cf2cb9877ccedf12a2f76dffa671bc3ae88439 Reviewed-on: https://chromium-review.googlesource.com/658164 Commit-Queue: Marti Wong <martiw@chromium.org> Reviewed-by:
Ramya Sharma <ramyasharma@chromium.org> Cr-Commit-Position: refs/heads/master@{#501601}
-
Ondrej Skopek authored
Fixes the issue of showing an error message for a short time before restarting Voice Search after click on the Try Again link (the microphone icon retrying worked correctly). As a result, removed the |speech.restart| function and associated test. Now, the display of the "Try Again" message is tested in text module tests, and the actual click handling is tested in the view module. Renamed the |text.cancelListeningTimeout| function to |text.clearListeningTimeout| for consistency. Bug: 583291 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Id5815f9857b90264340ebb37b9ef603bbae404ea Reviewed-on: https://chromium-review.googlesource.com/663547Reviewed-by:
-
ericwilligers authored
The :focus-within pseudo-class shipped in Chrome 60. The runtime flag is no longer needed. BUG=617371 Change-Id: I12db298d40df458c24987e7928d85aea179e6046 Reviewed-on: https://chromium-review.googlesource.com/662984Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#501599}
-
Max Morin authored
AudioInputController unconditionally calls UserInputMonitor::DisableKeyPressMonitoring when closing, but only calls EnableKeyPressMonitoring when Record is called. This leads to a messed-up reference count in UserInputMonitor if we close a stream without first starting it. Bug: 764656 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: Id85c5c2d26d2745588d8c6cc7c4555adddb9c2f2 Reviewed-on: https://chromium-review.googlesource.com/664577Reviewed-by:
Olga Sharonova <olka@chromium.org> Commit-Queue: Max Morin <maxmorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#501598}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6442dfd5..fd1dd40d Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org Change-Id: Ifde3bf1e13d4116896defa1d8447bd7a88ba0b60 Reviewed-on: https://chromium-review.googlesource.com/663680Reviewed-by:
-
Gyuyoung Kim authored
Bug: None Change-Id: I4f7fb1e3a682cfddd951a08266d8239efc4f1970 Reviewed-on: https://chromium-review.googlesource.com/663536Reviewed-by:
Rune Lillesveen <rune@opera.com> Commit-Queue: Gyuyoung Kim <gyuyoung.kim@chromium.org> Cr-Commit-Position: refs/heads/master@{#501596}
-
Takashi Toyoshima authored
Provide TimestampToTimeDeltaDelay as a static helper method of MidiService, and use it to calculate a delay time for a timestamp to post a delayed task. Bug: 672793 Change-Id: I7307bb816c262073ceae557ad9345c451051d414 Reviewed-on: https://chromium-review.googlesource.com/656924 Commit-Queue: Takashi Toyoshima <toyoshim@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#501595}
-
galinap authored
This CL adds an offline icon when the user downloads a suggestion from the context menu. This is done by registering an OfflineModelObserver in the SuggestionsCarouselAdapter. Bug: 763390 Change-Id: I8cf9adf54706927b5f11628c7e330b42eb4f2e94 Reviewed-on: https://chromium-review.googlesource.com/660538Reviewed-by:
-
John Mellor authored
This reverts commit 793d799b. Reason for revert - made TabsTest very flaky on the following bots: https://build.chromium.org/p/chromium.android/builders/Lollipop%20Phone%20Tester/builds/15045 https://build.chromium.org/p/chromium.linux/builders/Android%20Tests%20(dbg)/builds/45549 Original change's description: > Convert TabsTests and IncognitoNotificationServiceTest to JUnit4 > > For more on JUnit4 migration, please check src/testing/android/docs/junit4.md > > Bug: 640116 > Change-Id: I508ee1b6512a4a96175d1747a0f8ebe1764f11e6 > Reviewed-on: https://chromium-review.googlesource.com/662241 > Commit-Queue: Yoland Yan <yolandyan@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#501446} TBR=tedchoc@chromium.org,yolandyan@chromium.org Change-Id: I86ba1b7776b734a9150a09a3b6994c46732ac1e4 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 640116 Reviewed-on: https://chromium-review.googlesource.com/664717Reviewed-by:
John Mellor <johnme@chromium.org> Commit-Queue: John Mellor <johnme@chromium.org> Cr-Commit-Position: refs/heads/master@{#501593}
-
Ramin Halavati authored
Traffic annotation auditor would need to accept its clang tool from arbitrary (non-default) path and is updated to accept a switch for this. Bug: 656607 Bug: 690323 Change-Id: I071718f0410ecc636d71cbfc4fa9f18f9fcf1d19 Reviewed-on: https://chromium-review.googlesource.com/634908 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#501592}
-
Raphael Kubo da Costa authored
Follow-up to https://chromium-review.googlesource.com/576183 ("bindings: Return the right property descriptors for legacy platform objects"), which introduced the indexed descriptor callbacks for bindings. Even if a given IDL (such as Storage.idl) only supports named properties, our bindings layer installs a handler for indexed properties that, in this case, mostly just ends up falling back to the named property handlers. However, we were not defining a descriptor callback for indexed properties when the IDL only supports named properties. Consequently, we were not setting the right property descriptor values for a given numeric property, leading to bizarre cases where, e.g. if Storage only had numeric keys, Object.values() and Object.keys() would return arrays of diffferent lengths (the latter would be an empty one, actually). This change is a bit complicated because we install our indexed and named property handlers differently: the former is created with descriptor and definer callbacks, whereas the latter uses the query callback signature instead. This means the indexed property descriptor callback for named properties needs to call the query callback and translate its return value into a format suitable for descriptor callbacks, which is not very efficient. Ideally, both named and indexed properties should converge in terms of how their handlers are declared. Despite the fact that this is a follow-up commit, the original CL did not introduce a regression; interfaces that only support named properties were just behaving like they did in the past, with an indexed descriptor callback not being set. Bug: 719703, 764633 Change-Id: I1ebaabe61f5f8b6cadb0cfa8b41664a64e49e51b Reviewed-on: https://chromium-review.googlesource.com/660497 Commit-Queue: Raphael Kubo da Costa (rakuco) <raphael.kubo.da.costa@intel.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Reviewed-by:
-
