- 25 Nov, 2019 40 commits
-
-
Mathias Carlen authored
Before this patch android specific build targets were not gated by the is_android build flag. In preparation of the autofill assistant extension api we need to be able to add autofill_assistant as deps to non android targets. This patch gates what's needed and exposes strings in the AA component so that it can properly build on non android platforms. R=arbesser@google.com Bug: b/143736397 Change-Id: Ic1c962fa795bd8cff3d043430fb2bf1f49165745 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929223Reviewed-by:
Clemens Arbesser <arbesser@google.com> Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718595}
-
Ross McIlroy authored
BUG=chromium:1028072 Change-Id: Ic71c6d0ad1d764a6b10619d641a4c42e90e8c448 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932780 Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org> Auto-Submit: Ross McIlroy <rmcilroy@chromium.org> Reviewed-by:
Juan Antonio Navarro Pérez <perezju@chromium.org> Cr-Commit-Position: refs/heads/master@{#718594}
-
Renato Silva authored
Changes the direction of arrows on Chrome OS OOBE for RTL languages. OOBE Back and Next buttons now show the expected direction. Tested locally. Bug: 1016376 Change-Id: I8a00e900f9b3c02c9bca69a8f98d9c8a72244dbc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929829Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Commit-Queue: Renato Silva <rrsilva@google.com> Cr-Commit-Position: refs/heads/master@{#718593}
-
Tanja Gornak authored
Bug: 1023813 Change-Id: I45edd98889dc82693ad3ea0cb16f2bf2d2e95db0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911746Reviewed-by:
Marc Treib <treib@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#718592}
-
Olya Kalitova authored
Adds additional build deps to policy_fuzzer target so it would pass check on includes. Initial description: Initializes DBusThreadManager and CommandLine needed as a part of a policy_fuzzer setup. Test: gn gen out/libfuzzer --check Bug: 1015318 Change-Id: Iac41303e096b7a5f9ad664f228f58c336a64eaf0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930809Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Olya Kalitova <okalitova@chromium.org> Cr-Commit-Position: refs/heads/master@{#718591}
-
Morten Stenshorne authored
We currently don't let a break before a float affect the appeal of breaking inside their container. This is possible and fairly straight-forward to implement, at least for floats that don't participate in an inline formatting context. Also, since we're not hooking the floats up to the break appeal system at all yet, we won't see class A breakpoints between floats, or between a float and an in-flow block, which the spec actually requires. Will get back to this when inline formatting context float fragmentation is supported. Being as consistent as possible regardless of a float belonging to an inline formatting context or not seems like a good idea. Let's figure out what's feasible for inline formatting context floats first. Bug: 829028 Change-Id: Iccb22d91865ca6aad464c2ee12462843281643a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929825Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#718590}
-
David Roger authored
Change-Id: I4ca19ca4996dc7caab44d75125040a20ae8e6649 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930818 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#718589}
-
Ilia Samsonov authored
googletest will no longer support empty prefix for parameterized INSTANTIATE_TEST_SUITE_P. Adding "All" prefix to existing empty prefix test suites. This CL was uploaded by git cl split. R=skyostil@chromium.org Bug: 1023677 Change-Id: Id0eb2d63bf765a6f0b4a4e6add2a41964a8e4b4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926870 Auto-Submit: Ilia Samsonov <isamsonov@google.com> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#718588}
-
Anton Bikineev authored
This speeds up stack scanning by ~2x (VisitStackRoots scope). Change-Id: Ic3eab8091f48950b7ebdfbaeffe348e8a7e537ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929054 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718587}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: Ibdc5739609f3507fe28753b7603d375f735b20a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929821Reviewed-by:
Ahmed Fakhry <afakhry@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718586}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I0f1dfb9fafe99d71dd45485d9f822acfaee489a9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930897Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718585}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/2cab5168..8f2a89dc Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7f436726e11c4ba2f99d9c1dbc1d076ce94d2a28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933479Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718584}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/4706026ed847..56b1f53bcd83 git log 4706026ed847..56b1f53bcd83 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 eseckler@chromium.org telemetry: Fix a TODO. Created with: gclient setdep -r src/third_party/catapult@56b1f53bcd83 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: skyostil@google.com Change-Id: I485516ec76cd558f154a2dcef747727054908317 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934090Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718583}
-
Alice Wang authored
This CL simplifis the class AnimationLooper and fixes the bug that the current version of AnimationLooper cannot be stopped when the user disables the animators on device. Bug: 1026602 Change-Id: I722cb8d41f47028aef4ae4cf9b5dcc5ee8b5791a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926469 Commit-Queue: Alice Wang <aliceywang@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Cr-Commit-Position: refs/heads/master@{#718582}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/2ad66eccb5d5..31b01c053492 git log 2ad66eccb5d5..31b01c053492 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 saza@webrtc.org Fuzz APM float interface with up to 8 channels Created with: gclient setdep -r src/third_party/webrtc@31b01c053492 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I5f8c4d1910f752aebf0531997593b4a16da64078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934091Reviewed-by:
-
Mikel Astiz authored
Prior to this patch, the two existing functions to build GUID-keyed maps were heavily coupled and there were fragile underlying assumptions that made it work (e.g. there were potentially entries in |guid_to_remote_node_map_| that didn't actually match any local GUID). Instead, let's centralize the matching logic into one single function, and adopt a unified map to represent the matches. This simplifies the code and enforces more strict invariants without the need for DCHECKs. Bug: 978430 Change-Id: Ieea0db8d43376e204b793dcc64b2dc84d521b289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929216 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#718580}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: Ibb7dafa9011c83fb40a268b7484984fe121cc934 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929824Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718579}
-
Sylvain Defresne authored
set_sources_assignment_filter() is considered as a mis-feature of gn (as it makes it difficult to reason about the BUILD.gn files individually). Convert BUILD.gn files below //ui to instead use conditional to include source files only on the platformn where they are used. The conversion was done by using a modified version of gn that display all files filtered by set_sources_assignment_filter() and updating the BUILD.gn files manually to explicitly add the source files only on the platform that used them. This CL was uploaded by git cl split. Bug: 1018739 Change-Id: I6300c4e09253c6d28cb48fcf05ac3697a5877516 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930570Reviewed-by:
enne <enne@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#718578}
-
Aya ElAttar authored
Moved the browsertests of safe browsing policies and content settings policies and all related stuff from policy_browsertests to separate files. Bug: 1002483 Change-Id: If7a659bb7256ef3593802bb12cc89735bd636cfe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929225 Commit-Queue: Aya Elsayed <ayaelattar@google.com> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#718577}
-
Alex Danilo authored
Setting overflow-x:scroll forces a scroll bar to be shown. On the sub-menu, use overflow-x:auto always so the browser handles deciding when a scroll bar should be drawn. No new tests, covered by existing unit tests. Bug: 1001481 Change-Id: Icf84c0ea9a40b65383bcb7be23be84d2f0ee3a6d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933858Reviewed-by:
Noel Gordon <noel@chromium.org> Commit-Queue: Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718576}
-
David Roger authored
Dice migration is complete now. Bug: 777774 Change-Id: I3637199e6607db5a0f30e1760c66367e7a31eb9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928704 Commit-Queue: David Roger <droger@chromium.org> Auto-Submit: David Roger <droger@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
-
Marc Treib authored
Bug: 975956 Change-Id: Ice65c1cabd5dab3ea8764a81dff137cb816b492b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919141 Auto-Submit: Marc Treib <treib@chromium.org> Reviewed-by:
Nik Bhagat <nikunjb@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#718574}
-
Noel Gordon authored
The icon are currently drawn cut-off in the 16px item-icon box. Assume they have a 0 0 20 20 viewBox. Add that to their SVG and scale down to 16px x 16px (width x height) to center them in the .item-icon box. Bug: 1028050, 955920 hange-Id: I8da467fd33d5c526f73772b26480b9dd46ec9bf6 Change-Id: I8da467fd33d5c526f73772b26480b9dd46ec9bf6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934129Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
-
Simon Zünd authored
This CL temporarliy disables web tests that will be impacted by the upcoming top-level await implementation in V8's REPL mode. There are two changes that require layout tests to be disabled: V8's implementation of top-level await: https://crrev.com/c/1900464. Removal of manual wrapping of async/await code in the DevTools fronted: https://crrev.com/c/1928927. Some of the web tests are disabled because V8 REPL mode *always* returns a promise, resulting in slightly different stack traces. These need to be rebaselined but are included in this CL to make reverts easier. Bug: chromium:1021921 Change-Id: If262b66b51168265f1582c9b5f5d85dcd92525ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930656Reviewed-by:
Peter Marshall <petermarshall@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#718572}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d493dead. With Chromium commits locally applied on WPT: e83dd93c "Limit backtracking on regexp called from blink." 500a74f5 "Add a runtime flag to enforce strict MIME type checks for workers." 38d64f34 "Make DecompressionStream error checking stricter" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/trusted-types NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: If771aac5a5706595aed87ef1085497a22b6bfe53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933476Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718571}
-
Henrique Ferreiro authored
WebSandboxSupport::GetFallbackFontForCharacter() and MatchFontByPostscriptNameOrFullFontName(), FontCache::GetFontForCharacter(), gfx::GetFallbackFontForChar(), and CachedFont::GetFallbackFontForChar() were relying on returning an empty filename inside their FallbackFontData out parameter or return value in the case of failure. This CL changes them to explicitly return a boolean value. Change-Id: I4d81caa9bd3a173d7c37cd871c6a9373c56bc157 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926136 Commit-Queue: Henrique Ferreiro <hferreiro@igalia.com> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718570}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e9b68f332a30..b1393d70e91a git log e9b68f332a30..b1393d70e91a --date=short --no-merges --format='%ad %ae %s' 2019-11-25 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/spirv-tools/src 45dde9ad6dde..85f3e93d13f3 (1 commits) Created with: gclient setdep -r src/third_party/angle@b1393d70e91a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:None Tbr: courtneygo@google.com Change-Id: Idddbb0876afe9fe564a3d3050dde5705ae69b049 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934088Reviewed-by:
-
Michael Ershov authored
The test was marked as flaky more then a year ago. The bug from the TODO is fixed and closed. And I was not able to reproduce the problem localy and via several runs on test servers. Bug: 877416, 787602 Change-Id: Iae0d816c94dedbfb0db779a7b492e7619eba1939 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1926480Reviewed-by:
Matt Mueller <mattm@chromium.org> Commit-Queue: Michael Ershov <miersh@google.com> Cr-Commit-Position: refs/heads/master@{#718568}
-
Amy Huang authored
The warning was fixed upstream in d9957c7405b so we no longer need to disable the warning in top of tree clang. Change-Id: I27e8e7f13b28a27df6df7d6aae6e76c54be26100 Bug: 1026283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929866Reviewed-by:
Hans Wennborg <hans@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#718567}
-
Rune Lillesveen authored
Test relied on html parsing continuing before sheet in head was loaded. That is not the case with BlockHTMLParserOnStyleSheets enabled. Bug: 891767 Change-Id: Iec83d26fd55cd8e667ba7b321e7f89cca16597fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928784Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#718566}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/45dde9ad6dde..85f3e93d13f3 git log 45dde9ad6dde..85f3e93d13f3 --date=short --no-merges --format='%ad %ae %s' 2019-11-22 mattst88@gmail.com Respect CMAKE_INSTALL_LIBDIR in installed CMake files (#3054) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@85f3e93d13f3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 Bug: None Tbr: radial-bots+chrome-roll@google.com,courtneygo@google.com Change-Id: I6dfbef591b840beaf0f80fde58ee16096a175edb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934087Reviewed-by:
-
Hiroki Nakagawa authored
This is a part of the effort to split ServiceWorkerProviderHost into ServiceWorkerHost and ServiceWorkerContainerHost. This CL moves |client_uuid_| from ServiceWorkerProviderHost to ServiceWorkerContainerHost. Design doc: https://docs.google.com/document/d/1epWIgelE-7uwxJHrYPKlbwqMRP9in2xLUR6mpiU_afY/edit?usp=sharing Bug: 931087 Change-Id: I992c0edb537d5e76b5f0c1b499c68491f7bfd231 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933843 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#718564}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/4584a9c2ccb9..afc52b0b26d7 git log 4584a9c2ccb9..afc52b0b26d7 --date=short --no-merges --format='%ad %ae %s' 2019-11-25 bclayton@google.com Fix build: Do not return stack temporary. 2019-11-25 bclayton@google.com Fix chrome build: Use spaces (not tabs) in .gn files (2/2) 2019-11-25 bclayton@google.com Fix chrome build: Use spaces (not tabs) in .gn files 2019-11-22 chrisforbes@google.com Fix vkGetDescriptorSetLayoutSupport implementation 2019-11-22 srisser@google.com Log unsupported extensions used in pNext structs Created with: gclient setdep -r src/third_party/swiftshader@afc52b0b26d7 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:b/139528538,chromium:b/139528538,chromium:b/139528538,chromium:b/145007346,chromium:b/139528538 Tbr: swiftshader-team+autoroll@google.com Change-Id: I9666a01bb3e8a4d7ceac42e2b6854753e30f083e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932034Reviewed-by:
-
Sergio Villar Senin authored
We can get rid of NaN by replacing the return value (double) with an Optional<double>. This allows us to remove several IsNull() or ValueOrUnresolved() calls as we can just use the Optional as a boolean. Last but not least, the NullValue() added in crrev.com/c/1928781 are no longer needed and thus were removed. Bug: 737867 Change-Id: I5aa530f58ab648d6dc486122d9a8f8c121f2d057 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929218Reviewed-by:
Kevin Ellis <kevers@chromium.org> Commit-Queue: Sergio Villar <svillar@igalia.com> Cr-Commit-Position: refs/heads/master@{#718562}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/e1b0b37898a3..cbc3e409299b Created with: gclient setdep -r src-internal@cbc3e409299b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None Tbr: jbudorick@google.com Change-Id: If806b4ad0d459532f29514adb7e3ed6a3e370682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934089Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718561}
-
Yao Xiao authored
Intent to Implement: https://groups.google.com/a/chromium.org/d/msg/blink-dev/JdAQ6HNoZvk/xvDKF3GyDgAJ whatwg/html issue: https://github.com/whatwg/html/issues/3236 Bug: 539938 Change-Id: I0abeb1bb462806a65468b25cb30e5cb82f68cafb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872306 Commit-Queue: Yao Xiao <yaoxia@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
-
Eric Willigers authored
When using minimal-ui on Windows 10, the icons are now consistent with the native Windows 10 Back and Reload icon style. The main browser toolbar is unchanged. TBR=antrim@chromium.org Bug: 1026069 Change-Id: Ic243e22f08f4ce7467db1058e2fff948a0be854e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1924180 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Reviewed-by:
Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#718559}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I460a9d7fa5f9f0e0c25eee3a75b0813524ec937a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932148 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#718558}
-
Yuki Shiino authored
Bug: 839389 Change-Id: I41642b09c0fe8a24c9d32eb29b82f9c4a58fd698 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932147 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Ian Struiksma authored
For each input element, we grab the autofill information from the html element and log it. FormCache writes to 2 elements, and sometimes title is used on the page, so switching to use "autofill-information" instead Also, making the lack of this element a simple log line instead of a failure as it doesn't affect validation or execution of test. Bug: 984664 Change-Id: I934db1eb8d787a8fe799525bda14a33ee0cfa72d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931656 Auto-Submit: Ian Struiksma <ianstruiksma@google.com> Reviewed-by:
Dominic Battré <battre@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#718556}
-
