GitLab

Previously the WebRTC.AecDelayBasedQuality histogram was populated even when the call to fetch the metrics from WebRTC failed. This CL makes sure we only populate upon success.

BUG=450193

Review URL: https://codereview.chromium.org/999203003

Cr-Commit-Position: refs/heads/master@{#322556}

BUG=

Review URL: https://codereview.chromium.org/1040653002

Cr-Commit-Position: refs/heads/master@{#322555}

Part of components/sessions.gypi has ended up indented with tabs;
replace with spaces before refactoring.

BUG=
NOTRY=true

Review URL: https://codereview.chromium.org/1038013002

Cr-Commit-Position: refs/heads/master@{#322554}

BUG=None
TEST=Install an extension with printerProvider permission;
install dialog should contain a warning for the permission

Review URL: https://codereview.chromium.org/1021763003

Cr-Commit-Position: refs/heads/master@{#322553}

This test checks that if a new navigation does not commit after the
current renderer has run its unload handler this does not leave the WebContents
in a stuck state. However, following
https://codereview.chromium.org/464593003/, the current renderer will only run
its unload handler after teh new navigation has committed. Therefore, this test
is no longer applicable.

BUG=402020

Review URL: https://codereview.chromium.org/1035963003

Cr-Commit-Position: refs/heads/master@{#322552}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/14b52ee..cac3e40

TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/1039633002

Cr-Commit-Position: refs/heads/master@{#322551}

BUG=469773
TEST=Bring up History page and verify Learn more link goes to the right page. Check different UI languages as well.
TBR=cpu@chromium.org

Review URL: https://codereview.chromium.org/1036183002

Cr-Commit-Position: refs/heads/master@{#322550}

BUG=467552

Review URL: https://codereview.chromium.org/1032353004

Cr-Commit-Position: refs/heads/master@{#322549}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/1d24b8d..daee7ea

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1035103002

Cr-Commit-Position: refs/heads/master@{#322548}

BUG=470517

Review URL: https://codereview.chromium.org/1032893002

Cr-Commit-Position: refs/heads/master@{#322547}

BUG=470959

Review URL: https://codereview.chromium.org/1032323003

Cr-Commit-Position: refs/heads/master@{#322546}

This only affects the PlzNavigate FYI bots. The filtering will be
removed before we should consider moving this test out of FYI.

BUG=439423

Review URL: https://codereview.chromium.org/1035573004

Cr-Commit-Position: refs/heads/master@{#322545}

Following roles has been mapped for win,mac & android platform.
1. switch role
2. searchbox role

Also some cleanups are done in this CL.

BUG=468667

Review URL: https://codereview.chromium.org/1030333002

Cr-Commit-Position: refs/heads/master@{#322544}

This CL makes it so that NavigatorImpl::Navigate will call
DidStartNavigatingToPendingEntry after creating the NaviagtionRequest when
PlzNavigate is enabled. This makes the test
NavigationControllerTest.ReloadOriginalRequestURL pass with PlzNavigate
enabled.

BUG=439423

Review URL: https://codereview.chromium.org/1035953002

Cr-Commit-Position: refs/heads/master@{#322543}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/a5c5be5..14b52ee

TBR=pkasting@chromium.org

Review URL: https://codereview.chromium.org/1033183002

Cr-Commit-Position: refs/heads/master@{#322542}

The current clamping is not enough to avoid bleeding issues. This is
exposed when changing the background color in CreateEdgeBleedPass from
black to gray. The reason it works now is because interpolating U/V
textures from black (YUV = 0, 0, 0) to green (YUV = 149, 43, 21) will
still result in saturated green pixels (RGB = 0, 255, 0). All YUV values
in the range (149, 0-43, 0-21) will end up as RGB = (0, 255, 0).

The current clamping is not enough, because the calculation
'0.5f / quad->tex_size.width()' is using the Y texture size, the highest
resolution plane, but the U/V texture size is only half of that. This CL
adds individual sizes for the Y/A and U/V textures.

BUG=429640,467283

Committed: https://crrev.com/4be817dd606efdba1614d32608ddd6e16bfa687d
Cr-Commit-Position: refs/heads/master@{#320567}

Review URL: https://codereview.chromium.org/1008493002

Cr-Commit-Position: refs/heads/master@{#322541}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/41f88f0..1d24b8d

CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel
TBR=hcm@google.com

Review URL: https://codereview.chromium.org/1035003005

Cr-Commit-Position: refs/heads/master@{#322540}

Federated credentials have identity provider information (IDP) associated with them. IDP for each of federated credential should be shown in account chooser infobar.

BUG=454815

Review URL: https://codereview.chromium.org/1007403003

Cr-Commit-Position: refs/heads/master@{#322539}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/ba77b71..a5c5be5

TBR=loislo@chromium.org,pkasting@chromium.org

Review URL: https://codereview.chromium.org/1041603002

Cr-Commit-Position: refs/heads/master@{#322538}

Cr-Commit-Position: refs/heads/master@{#322537}

Summary of changes available at:
https://chromium.googlesource.com/chromium/blink/+log/1bb46ea..ba77b71

TBR=loislo@chromium.org,pkasting@chromium.org

Review URL: https://codereview.chromium.org/1041583002

Cr-Commit-Position: refs/heads/master@{#322536}

PrefService's dtor is responsible to call CommitPendingWrite() so there is no need to call it here.

BUG=470501

Review URL: https://codereview.chromium.org/1036593005

Cr-Commit-Position: refs/heads/master@{#322535}

Revert of Update V8 to version 4.3.58. (patchset #1 id:1 of https://codereview.chromium.org/1037143002/)

Reason for revert:
multiple crashes in devtools tests

Original issue's description:
> Update V8 to version 4.3.58.
>
> Summary of changes available at:
> https://chromium.googlesource.com/v8/v8/+log/e4dfe3b9..b08c7327
>
> Please follow these instructions for assigning/CC'ing issues:
> https://code.google.com/p/v8-wiki/wiki/TriagingIssues
>
> TBR=hablich@chromium.org,machenbach@chromium.org,yangguo@chromium.org,vogelheim@chromium.org
>
> Committed: https://crrev.com/4c27bf72e93e2649165e0d6a5d7e3e90efe9dc23
> Cr-Commit-Position: refs/heads/master@{#322511}

TBR=hablich@chromium.org,machenbach@chromium.org,vogelheim@chromium.org,yangguo@chromium.org,v8-autoroll@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true

Review URL: https://codereview.chromium.org/1040613002

Cr-Commit-Position: refs/heads/master@{#322534}

This patch reverts https://codereview.chromium.org/940373002, and adds
back in the ~2 lines and tests that are still relevant.

BUG=459154

Review URL: https://codereview.chromium.org/1032063002

Cr-Commit-Position: refs/heads/master@{#322533}

Hide "Keep this card locally" checkbox and tooltip while verifying card.
Space in the dialog is still reserved for the footer; it's just empty.

BUG=448572

Review URL: https://codereview.chromium.org/1040493003

Cr-Commit-Position: refs/heads/master@{#322532}

Grit's execution depends on the resource ID file, but this was not listed as a dependency in grit targets. This means that changing the resource ID file wouldn't re-run grit.

Review URL: https://codereview.chromium.org/1038213002

Cr-Commit-Position: refs/heads/master@{#322531}

If file browser handlers are specified in the manifest, and the permission is
missing, then they will be ignored. This CL adds a warning so users are aware
of it.

TEST=unit_tests: *FileBrowserHandlerManifestTest.InvalidFileBrowserHandlers*
BUG=470494

Review URL: https://codereview.chromium.org/1017163003

Cr-Commit-Position: refs/heads/master@{#322530}

TBR=tommi
BUG=471132

Review URL: https://codereview.chromium.org/1039103002

Cr-Commit-Position: refs/heads/master@{#322529}

In particular, make HistoryURL provider scoring
basically the same within regular mode and
prevent-inline-autocomplete mode (under the constraint
that we always need a valid default match first).
For what it's worth, the current code demotes (from
~1410) all non-URL-what-you-typed URLs (non-UWYT)
to 900 in prevent-inline-autocomplete mode.  If
there is a UWYT, though, these results will be
clustered / given a free ride to appear right
below it, scoring ~1200.  After this change, all
non-UWYT results will score the same in
prevent-inline-autocomplete and normal modes.
We instead rely on the allowed_to_be_default_match
bit to reorder results as necessary.

To implement this feature, we need knowledge of
whether the what-you-typed match is reasonable.
This change re-adds a variable
have_what_you_typed_match to HistoryURLParams.  This
variable was previously added in
https://codereview.chromium.org/347963002 for
a field trial and then later removed in
https://codereview.chromium.org/879053002

With this variable, the change is straightforward.
Don't change the scoring in prevent-inline-autocomplete
mode.  Instead, simply make sure the what-you-type
match gets added to the list in prevent-inline-mode.
We add it early on the list (using the Promote()
mechanism) so that it'll always appear in the final
set of suggestions.

Tested using about:omnibox

BUG=421772

Review URL: https://codereview.chromium.org/1022643002

Cr-Commit-Position: refs/heads/master@{#322528}

The initial reason for the blacklist was a bug that is now fixed.
A workaround was first developed in Chromium and then later
Nvidia actually fixed the root of the problem in their driver.
This patch removes the blacklist for 331.38 and newer drivers.

BUG=469979

Review URL: https://codereview.chromium.org/1032483002

Cr-Commit-Position: refs/heads/master@{#322527}

Fixes for iOS compile.

BUG=None

Review URL: https://codereview.chromium.org/1037573003

Cr-Commit-Position: refs/heads/master@{#322526}

Review URL: https://codereview.chromium.org/1037173003

Cr-Commit-Position: refs/heads/master@{#322525}

Review URL: https://codereview.chromium.org/1034283002

Cr-Commit-Position: refs/heads/master@{#322524}

Do not create or show the "Keep this card locally" checkbox footer
when !CanStoreLocally().

BUG=448572

Review URL: https://codereview.chromium.org/1040513002

Cr-Commit-Position: refs/heads/master@{#322523}

Error codes which CopyInForeignFile(CopyFileFromLocal) returns are defined in the definition of async_file_util.h.

BUG=413541
TEST=manually tested.

Review URL: https://codereview.chromium.org/1025553006

Cr-Commit-Position: refs/heads/master@{#322522}

This CL adds comments and DHCECKs clarifying the thread safety aspects of
VideoFrameProviderClientImpl.

BUG=336733

Review URL: https://codereview.chromium.org/1033563002

Cr-Commit-Position: refs/heads/master@{#322521}

OnPaint() is not part of the recursion, it won't have access to the
neccessary pieces to do recursion.

If you need to do painting while inside the recursion, this should
happen in PaintChildren(). So move the contents of OnPaint() to
PaintChildren().

R=pkasting
BUG=466426

Review URL: https://codereview.chromium.org/1016033011

Cr-Commit-Position: refs/heads/master@{#322520}

DocumentTabModelImpl now fires didSelectTab to its observers. This is done in
setLastShownId() instead of setIndex() for a few reasons:

* setIndex() has the side effect of bringing Tabs forward, which you may not
  want.

* setLastShownId() hopefully more faithfully tracks what Tab was last shown in
  the foreground, and is called by DocumentActivity.onResume().  This might
  still be incorrect (e.g. when opening a Tab in the background), but this is
  one of those weird cases where Android has two Activities in the foreground
  simultaneously.

* It's really difficult to actually indicate what brings a Tab back to the
  foreground.  Slap a TODO on there to actually fix it when an Observer actually
  needs to know the type.

BUG=443772

Review URL: https://codereview.chromium.org/1039513003

Cr-Commit-Position: refs/heads/master@{#322519}

R=brettw@chromium.org, jamesr@chromium.org
TBR=jamesr@chromium.org
BUG=none
TEST=none

Review URL: https://codereview.chromium.org/1035933002

Cr-Commit-Position: refs/heads/master@{#322518}

This patch adds the woff2 library [1] which is used to decode WOFF 2.0
web font file format. It's going to replace the old version of WOFF 2.0
decoder included in third_party/ots.

[1] https://github.com/google/woff2 (revision 445f5419)

BUG=434596
TEST=trybots

Review URL: https://codereview.chromium.org/954163002

Cr-Commit-Position: refs/heads/master@{#322517}