- 13 Mar, 2018 40 commits
-
-
Mark Cogan authored
This CL implements an imperfect but serviceable-for-now transition animator used when entering the tab grid. Most of the logic for building and running the animation is in the animator class. However, to set the animation up, the tab grid needs to vend some information. This is done through the TabGridTransitionStateProvider protocol, which the TabGridViewController implements. Most of this information is handled by the -transitionGridLayout method, which returns an array of dictionaries with predefined keys. Some of the values are collection cells, which GridCell provides (a grid cell can now provide a "proxy" version of itself for this purpose). These are then used to build the animation. Because the grid animation really needs to happen *behind* the grid toolbars to look right, the state provider protocol includes two somewhat janky methods to expose views to make this possible -- a view to add the transition cells to, and a view in that view to put them above. The implementations of these methods return the TabGridViewController's view, and it's scroll view, respectively. This means the animator is adding and removing stuff from the view hierarchy of a view controller, which isn't ideal. The alternative is to also proxy the tab grid toolbars in the transition animation, which will require a bit more plumbing. There are a number of fit-and-finish cleanups that need to happen; a separate task bug has been created for them. Bug: 804538 Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs Change-Id: Ifde8bb27b70ce350e40eeb1e1b14675579f84d7d Reviewed-on: https://chromium-review.googlesource.com/957039 Commit-Queue: Mark Cogan <marq@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Cr-Commit-Position: refs/heads/master@{#542757}
-
Rob Wu authored
BUG=813541 Change-Id: Ia73c5201d874ab2a52ecd30476e09d9a1b6d56db Reviewed-on: https://chromium-review.googlesource.com/924702Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Commit-Queue: Rob Wu <rob@robwu.nl> Cr-Commit-Position: refs/heads/master@{#542756}
-
Christian Dullweber authored
This reverts commit a77029c4. Reason for revert: Build failed because it is missing java during closure compilation step on windows bot: https://ci.chromium.org/buildbot/chromium/Win/64904 Original change's description: > [Closure GN] Convert MD Bookmarks Closure Compilation to GN > > Bug: 632206 > Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation > Change-Id: I05b1348c408965811a2b557bc2a1cb2ee7850096 > Reviewed-on: https://chromium-review.googlesource.com/954822 > Commit-Queue: calamity <calamity@chromium.org> > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542749} TBR=calamity@chromium.org,dpranke@chromium.org,dpapad@chromium.org Change-Id: I9f52c5010125781f35a08d3fa0743362c788706a No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Reviewed-on: https://chromium-review.googlesource.com/960141Reviewed-by:
Christian Dullweber <dullweber@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#542755}
-
Yutaka Hirano authored
We need to disable the feature to test referrer policy. Bug: 732923 Change-Id: I4fab8a187b9947be05bac52d61391732dccd4a8d Reviewed-on: https://chromium-review.googlesource.com/959412 Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#542754}
-
Kim Paulhamus authored
Instead of custom building each set of options per test, deep copy the options and remove select properties. Both reduces code and makes it more clear what is being tested. Also adds a helper to set up a successful response from the mock authenticator. Bug: 664630 Change-Id: If5986e21b56e1093835866283f0e69134f265390 Reviewed-on: https://chromium-review.googlesource.com/957831Reviewed-by:
Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#542753}
-
Rune Lillesveen authored
SVG elements like <g> do not generate a box when styled as display:contents in an SVG context. However, when they are children of HTML elements, they should not generate boxes, and not act as display:contents. If treated as display:contents, text child nodes would have SVG text boxes generated for them causing crashes. Bug: 820779, 820834 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I1ec7e3af158daa9d56160123cc3c25f6ee3eda62 Reviewed-on: https://chromium-review.googlesource.com/958912Reviewed-by:
Fredrik Söderquist <fs@opera.com> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#542752}
-
Colin Blundell authored
Moves this service into the canonical location for services within //components. The existing code causes several presubmit warnings. This CL does not attempt to fix them. NOPRESUBMIT=true TBR=dcheng@chromium.org Change-Id: I32ead19d70370b20d7aff19dff2be56058f8e963 Reviewed-on: https://chromium-review.googlesource.com/949162 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#542751}
-
Han Leon authored
All JavaScript Client objects seen in a service worker execution context must be matching origin with the service worker (See the bellowing explanation in details), so, if the browser-side received a Client#{postMessage,focus,navigate} call from a cross-origin Client object, it should be treated as a bad message. A detailed explanation: Once a JavaScript Client object has been gotten by the ServiceWorkerGlobalScope (via ServiceWorkerGlobalScope#{Clients,Client} APIs), the corresponding window client navigation (including page redirects) must have already completed and its origin should be matching with the service worker. And, for a window client, once the initial navigation done, its document url won't be changed any more, so its origin should keep matching with the service worker through its lifetime. Even in case that the window starts to navigate to another url, a new ServiceWorkerProviderHost with a new client uuid will be created for that, without any changes to document url of the original ServiceWorkerProviderHost. As above, we're sure a Client#{*} request received in browser-side must be for a client matching origin with the sender service worker. BUG=772793 Change-Id: I821c8cced03288596988d583637157e8f1839b2b Reviewed-on: https://chromium-review.googlesource.com/956111 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#542750}
-
Christopher Lam authored
Bug: 632206 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I05b1348c408965811a2b557bc2a1cb2ee7850096 Reviewed-on: https://chromium-review.googlesource.com/954822 Commit-Queue: calamity <calamity@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#542749}
-
Istiaque Ahmed authored
For better or worse, there are lots of subtleties around content hash fetching code and how computed hashes are handled. This CL aims to document those with tests. The intention is to make sure that these don't regress unknowingly while code is refactored in the future. Bug: 796395 Change-Id: Iecc106a992596955497a1d02b6610c85c1d64364 Reviewed-on: https://chromium-review.googlesource.com/947712 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#542748}
-
Adam Rice authored
tyoshino@ has left the project. Remove him as an owner from histograms. Change-Id: Iad391ed7fbdaeacea1738c5ea9c1b10f2294a84d Reviewed-on: https://chromium-review.googlesource.com/958789Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#542747}
-
Xiaohan Wang authored
Pepper CDM is being deprecated. This should not be needed anywhere now. Bug: 772160 Change-Id: I1809ff64c4f02166218d6378a37f8698044f9ad2 Reviewed-on: https://chromium-review.googlesource.com/956415Reviewed-by:
John Rummell <jrummell@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#542746}
-
Dominic Mazzoni authored
Even though the spec is changing, this is an important piece of Phase 3 that will be needed either way. Refactors the AXObject event handling code slightly to support event listeners on virtual nodes, not just on AccessibleNodes that correspond to DOM elements. Adds a browser test for this, because I think it's good to have some complete integration tests for AOM and not just layout tests. Bug: 761901 Change-Id: I904916e1e930dadeb602ed679b4b422b4180d179 Reviewed-on: https://chromium-review.googlesource.com/958141 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#542745}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/f4c2703a6ded..68de9f34db44 $ git log f4c2703a6..68de9f34d --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I2d614f84968c17111e8554b724a65907c797534b Reviewed-on: https://chromium-review.googlesource.com/959696 Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542744}
-
tzik authored
This updates callers of base::LaunchUnitTests in several directory to use base::OnceCallback instead of legacy base::Callback. No intended functional change is included. This reduces the number of 'base::Bind' in //gin, //notification_helper, //pdf, //sql, //url, and //chrome_elf from 7 to 0 as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: Ie1bf3ad1ca90f732356d4612cfd8e3e8eca8afda Reviewed-on: https://chromium-review.googlesource.com/954882 Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#542743}
-
Tarun Bansal authored
This experiment throttles low priority requests based on the count of high priority requests and the current network quality. The experiment changes the scheduling behavior only when the current effective connection type is Slow2G or 2G. The code to adapt the scheduling behavior based on ECT is still there in the ResourceScheduler in case we need to revert it or update the params using finch. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I77ba950344e6ff8e05a83ebb0dc5b48cec6ff3c8 Bug: 746640 Reviewed-on: https://chromium-review.googlesource.com/955703Reviewed-by:
Mark Pearson <mpearson@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542742}
-
Han Leon authored
PostMessage is a macro in Windows and depending on whether Windows headers have been included or not, PostMessage will either be treated as PostMessage or PostMessageW. However, our previous CL https://chromium-review.googlesource.com/c/chromium/src/+/933867 introduced a method just named as 'PostMessage', this caused some compile/link errors on Windows platform. This CL renames the method to 'PostMessageToServiceWorker' to fix this. BUG=772713,813749 TBR=kinuko@chromium.org for mechanical renaming in the mojom file Change-Id: I16241052e3deb8ba4a5fbb777037eca9904c6279 Reviewed-on: https://chromium-review.googlesource.com/959688 Commit-Queue: Han Leon <leon.han@intel.com> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#542741}
-
https://skia.googlesource.com/skia.git/+log/c25e2693ab00..cc59c278ab0d $ git log c25e2693a..cc59c278a --date=short --no-merges --format='%ad %ae %s' 2018-03-13 angle-skia-autoroll Roll skia/third_party/externals/angle2/ e98b1b5d4..64e5ed2ab (7 commits) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: Icd054e805e632c40139bdea4c6bbabd113484253 Reviewed-on: https://chromium-review.googlesource.com/959397 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542740}
-
Wez authored
This is a reland of e9605182 The original CL added a unit-test which created a single-byte Channel::Message, without actually initializing that single-byte. This caused the MSAN bots to (correctly) spot that uninitialized data was being read during serialization. Original change's description: > Delay Channel::OnError() in case of kDisconnected during Write(). > > Write() operations to a Channel can fail due to the peer having closed > it, while there are still messages waiting to be read from it. We must > therefore defer notifying the caller of the Channel::Error until we > observe end-of-stream via a readable notification, otherwise those > messages may be dropped (depending on whether the posted OnError task > is processed before or after a pending Channel-readable event). > > Bug: 816620 > Change-Id: I75bd34a48edf4022809d27ce49f9cfba7a5d4daf > Reviewed-on: https://chromium-review.googlesource.com/956932 > Commit-Queue: Wez <wez@chromium.org> > Reviewed-by: Ken Rockot <rockot@chromium.org> > Cr-Commit-Position: refs/heads/master@{#542634} TBR: rockot Bug: 816620 Change-Id: I1a1d6eb7fa712e50b3d9c86591878900f0aeb388 Reviewed-on: https://chromium-review.googlesource.com/959762Reviewed-by:
Wez <wez@chromium.org> Commit-Queue: Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542739}
-
David Tseng authored
The compare requirement in STL states that equiv(a, b) = !comp(a, b) && !comp(b, a). Thus, in AXTreeSourceArc, we must return false when all other criteria are used up and we want to consider the two items equal. Not doing so leads to std::sort attempting to access beyond the bounds of |out_children|. Change-Id: Ifdccf35a0a507e2bae56656c3742c8d3881841e5 Reviewed-on: https://chromium-review.googlesource.com/959742 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Reviewed-by:
Luis Hector Chavez <lhchavez@chromium.org> Cr-Commit-Position: refs/heads/master@{#542738}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/be58a3b3..21cb7e30 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I238ab2263e99c10d200d788f1c673c320530b8a5 Reviewed-on: https://chromium-review.googlesource.com/959580Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#542737}
-
Siddhartha authored
The extract_unwind_tables script dumps the breakpad symbol file and extracts cfi unwind table from it. The output format is discussed in this doc: https://docs.google.com/document/d/1TLuUZ1HaMO6Rv0Q9Y1-w4a-9wcyia1VygQbs4Osb7Oo This is just a basic format and will be changed in subsequent cl for size efficiency and performance. BUG=819888 Change-Id: I987aa2e4ef37f86b6553410d7ee73c15f655495b Reviewed-on: https://chromium-review.googlesource.com/956971 Commit-Queue: Siddhartha S <ssid@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#542736}
-
Jay Civelli authored
Removing UtilityProcessMojoClient now that it is not used anymore. As a result UtilityProcessHost::SetExposedDir() is removed as well as its actual implementation in the sandbox code. Tbr: bradnelson@chromium.org Bug: 775677 Change-Id: I4147a2482c51132afa7a43927d6351e63169cb06 Reviewed-on: https://chromium-review.googlesource.com/937962 Commit-Queue: Jay Civelli <jcivelli@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#542735}
-
Daniel Cheng authored
Bug: 676224 Change-Id: I9b0c8266d1b45fa0371cea4fc0cd94e9909b6534 Reviewed-on: https://chromium-review.googlesource.com/957863 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#542734}
-
Erik Luo authored
DevTools prints console System-type Info-level messages only in 2 cases - MainFrame navigations "Navigated to ..." - Dumping size of large Common.Settings that failed to save This CL sets text color to blue in these cases, and also sets dark-theme violation text to original warning colors. Screenshot: https://imgur.com/a/yaIbr Bug: 817429 Change-Id: Id3f2c7ad16a3f02b40b4aafe93f5ca3dcf04f4b1 Reviewed-on: https://chromium-review.googlesource.com/955893Reviewed-by:
Pavel Feldman <pfeldman@chromium.org> Commit-Queue: Erik Luo <luoe@chromium.org> Cr-Commit-Position: refs/heads/master@{#542733}
-
Hiroki Nakagawa authored
Bug: n/a Change-Id: I26db9c9ffbbfc55245f6ddc29c1e8088047e91c2 Reviewed-on: https://chromium-review.googlesource.com/959463Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#542732}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 32c4f747. With Chromium commits locally applied on WPT: 072aa316 "[css-typed-om] Fix DCHECK when creating a CSSUnitValue an empty unit." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13794 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md TBR=foolip No-Export: true Change-Id: Ibb89c6568c271c3f356df0a1c857d2cccfcb84bb Reviewed-on: https://chromium-review.googlesource.com/959680 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#542731}
-
https://chromium.googlesource.com/catapult.git/+log/548a5bc4b828..c6434b02c577 $ git log 548a5bc4b..c6434b02c --date=short --no-merges --format='%ad %ae %s' 2018-03-12 simonhatch Pinpoint - Upload results2 to bucket with more open permissions Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ia333862276c80fdb7e801d267fd67de6cdc4627a Reviewed-on: https://chromium-review.googlesource.com/959579Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542730}
-
https://webrtc.googlesource.com/src.git/+log/5b9c6840b1d9..207a75d8f3fa $ git log 5b9c6840b..207a75d8f --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I3298ff426f0d6f5d609ed3f669a03a393d1d9bff Reviewed-on: https://chromium-review.googlesource.com/959749 Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#542729}
-
Tien-Ren Chen authored
This CL fixes a combination of two bugs that resulted in crash due to internal inconsistencies. The first bug is that we forgot to clear ClipPath node when an element lost all of its effect nodes. The second bug is that the paint property nodes were not invalidated when a SVG clipPath element was removed. BUG=818821 Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I3e7ba8507c60c4a09f4e88417c76c7e33f1bd1c1 Reviewed-on: https://chromium-review.googlesource.com/959595 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Cr-Commit-Position: refs/heads/master@{#542728}
-
tzik authored
This CL applies //tools/clang/base_bind_rewriters to //chrome/browser/extensions. It rewrites base::Bind to base::BindOnce where the resulting base::Callback is immediately converted to base::OnceCallback, which is considered safe to use base::BindOnce. E.g.: base::PostTask(FROM_HERE, base::Bind([]{})); base::OnceClosure cb = base::Bind([]{}); are converted to: base::PostTask(FROM_HERE, base::BindOnce([]{})); base::OnceClosure cb = base::BindOnce([]{}); This reduces the number of 'base::Bind' in //device from from 648 to 612 as tracked at http://goo.gl/LUVhDj Bug: 714018 Change-Id: I1a92511d1fa36f9fb2ed048c8e44ca4247b46e78 Reviewed-on: https://chromium-review.googlesource.com/952404Reviewed-by:
Ken Rockot <rockot@chromium.org> Commit-Queue: Taiju Tsuiki <tzik@chromium.org> Cr-Commit-Position: refs/heads/master@{#542727}
-
Kouhei Ueno authored
Bug: None Change-Id: I034500f7ac6f551ddcb6b53a728796e9d55dd8a5 Reviewed-on: https://chromium-review.googlesource.com/958890Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#542726}
-
Alexey Kozyatinskiy authored
.. and prepared V8PrivateProperty::V8PrivateProperty for terminate execution. R=haraken@chromium.org Bug: chromium:820640 Change-Id: I1d31466f2a4c8f7dcb4eaf225c082bededddb768 Reviewed-on: https://chromium-review.googlesource.com/959148Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Aleksey Kozyatinskiy <kozyatinskiy@chromium.org> Cr-Commit-Position: refs/heads/master@{#542725}
-
Tarun Bansal authored
This CL includes the test for "Accept-CH" header. If the origin includes "Accept-CH" in the response header, then the browser should include the specified client hints in the HTTP request headers for the resources contained in that page. Bug: 817049 Change-Id: Id74193ab7a1cc3c4b03d66e080c43c64a6fcfbb2 Reviewed-on: https://chromium-review.googlesource.com/951867Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#542724}
-
Mike Reed authored
needed for https://skia-review.googlesource.com/c/skia/+/113940 Change-Id: I4db6feb9e518cdacbaba10fcbd3e790927f3d4a3 Reviewed-on: https://chromium-review.googlesource.com/959531Reviewed-by:
Florin Malita <fmalita@chromium.org> Commit-Queue: Florin Malita <fmalita@chromium.org> Cr-Commit-Position: refs/heads/master@{#542723}
-
Trent Apted authored
Flaky. TBR=scottmg@chromium.org Bug: 819924 Change-Id: Id6a337392ec94bbc1b3ae2f83a914bc4d2565996 Reviewed-on: https://chromium-review.googlesource.com/958666Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#542722}
-
Nicolás Peña authored
This CL renames the classes as follows: * UserActivityLogger -> UserActivityManager * UserActivityLoggerDelegate -> UserActivityUkmLogger * UserActivityLoggerDelegateUkm -> UserActivityUkmLoggerImpl * UserActivityLoggingController -> UserActivityController Design doc: https://docs.google.com/document/d/1QXXnRFKiRDvXaxwNTc6djMDC-5e7SXk4i2FI3fpxMdA/edit?usp=sharing Change-Id: Id8a1b2e35c3bfde9e07ee47613510da5415f038a Reviewed-on: https://chromium-review.googlesource.com/956164 Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542721}
-
Manu Cornet authored
Change-Id: I4578a80f4c49c381109efaddf326934b834978ec Reviewed-on: https://chromium-review.googlesource.com/953646 Commit-Queue: Manu Cornet <manucornet@google.com> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#542720}
-
chaopeng authored
In this patch, we covert the scale factor from Direct Manipulation to GesturePinch event. The ctrl+wheel will create by WebViewImpl:: HandleSyntheticWheelFromTouchpadPinchEvent. Bug: 647140 Change-Id: Ib041d7805daac7e71b2f43872c818a9f36b14abd Reviewed-on: https://chromium-review.googlesource.com/786348Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Commit-Queue: Jianpeng Chao <chaopeng@chromium.org> Cr-Commit-Position: refs/heads/master@{#542719}
-
Koji Ishii authored
This patch cleans up an unused variable I happened to find while debugging. Bug: 591099 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I4498954e510e0a64362b688fe20ea46014906f0e Reviewed-on: https://chromium-review.googlesource.com/958649Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#542718}
-