- 17 Jun, 2020 40 commits
-
-
Maksim Sisov authored
Extends OzonePlatform and adds pre and early initialize steps that are used to set error handlers from ChromeBrowserMainExtraPartsOzone (used to be CBMEPX11). At the moment, there is only X11 that uses that, but Wayland will also use that in the follow up CL. Bug: 1093008 Change-Id: I32c56d0ed888c6e965068776c37529aade81fc10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2238071 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Cr-Commit-Position: refs/heads/master@{#779219}
-
Fergal Daly authored
Change-Id: I75299d96f0418c56eb50c9a9f93c45d15097aee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227929 Commit-Queue: Fergal Daly <fergal@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sreeja Kamishetty <sreejakshetty@chromium.org> Cr-Commit-Position: refs/heads/master@{#779218}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/f1e7813be659..caa519ca532a 2020-06-17 rharrison@google.com Add support for different default/trunks in roll-deps (#1086) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: Ia292e905ead2751c86a67ab08e904a2865661f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249521Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779217}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/a071cce7fd70..70c2cfd61548 2020-06-17 yyanagisawa@chromium.org Roll out new goma client binary VERSION=202 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I1708fc071e7d57092923ba2ddf8fbe518d88ee00 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249519Reviewed-by:
-
Maggie Cai authored
If we only want to show the intent picker icon, there is no need to defer the navigation. This CL fixes this issue. BUG=853604 Change-Id: I866ab67399393b634856f8e28ac0b4a17820a95b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247946Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#779215}
-
Side Yilmaz authored
This CL adds getter functions for identity manager, sign-in manager and account tracker service with profile parameter, instead of using functions with always regular profile. After this CL, the caller classes of IdentityServicesProvider will be able to get services for the given profile. Bug: 1041781 Change-Id: I324466c3b0700775434d2e2c6a8eaeffcc4b84c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241973Reviewed-by:
Boris Sazonov <bsazonov@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Commit-Queue: Side YILMAZ <sideyilmaz@chromium.org> Cr-Commit-Position: refs/heads/master@{#779214}
-
Maksim Sisov authored
When use_x11 && use_ozone are set to true at the same time, compiler throws an error about multiple definitions of the CreateDesktopScreen. Thus, to fix that, create a separate source file for is_linux case that will choose what DesktopScreen to use based on the IsUsingOzonePlatform feature flag. Please note that this is a temp solution and it will be removed once use_x11 goes away. Please note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. Bug: 1085700 Change-Id: I8710809572cc82d514ee64af1fe9a6a1eff73cd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247719Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Alexey Baskakov authored
Background: In our backward compatibility sync model InstallWebAppsAfterSync and InstallBookmarkAppFromSync calls may happen in any order for each given app. SyncRace_InstallWebAppFull_ThenBookmarkApp unit test checks the following logical sync race scenario: If InstallWebAppsAfterSync happens first, it reserves a stub WebApp in-sync-install object. So next InstallBookmarkAppFromSync for this WebApp gets declined. Drive-by: Remove preparations for double install in both SyncRace_InstallBookmarkApp*_ThenWebApp unit tests. Bug: 1020037 Change-Id: I33e3caf8c0b5fce9ff7421d6de29f3e3b1a73612 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247985Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Alexey Baskakov <loyso@chromium.org> Cr-Commit-Position: refs/heads/master@{#779212}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/3244745c3d4b..4c47d0ddea16 2020-06-17 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go Deps 2020-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from c5b7f210 to 5af39e89 (524 revisions) 2020-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from 8cbee4107cf1 to 763957e6b4fc (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: If4f246c88830cfdac65e90090a29c950a50c8bb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249558Reviewed-by:
-
Maksim Sisov authored
When use_x11 && use_ozone are set to true at the same time, the compiler throws an error about multiple definitions of the Create() method for Clipboard. Thus, to fix that, create a separate source file for is_linux case that will choose what Clipboard impl to use based on the IsUsingOzonePlatform feature flag. Please note that this is a temp solution and it will be removed once use_x11 goes away. Please note that it's impossible to build use_x11 && use_ozone without some hacks in PlatformCursor code. The changes to that are on their way to upstream. Bug: 1085700 Change-Id: I3a32b261ec01fd2a751127b5abda1147575b8e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247760 Commit-Queue: Maksim Sisov <msisov@igalia.com> Reviewed-by:
-
Guido Urdaneta authored
This reverts commit cec8e864. Reason for revert: Potential fix landed. Re-enabling to evaluate effectiveness. Change-Id: I06dec0e531c673f29577b87827f905ab27b1641e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246692Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Henrik Boström <hbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#779209}
-
Caitlin Fischer authored
Also, remove the corresponding Java tests. Bug: 1049736 Change-Id: I397d2ba2e78048d37d0ca3625eab69f05160f2b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247706Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Auto-Submit: Caitlin Fischer <caitlinfischer@google.com> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#779208}
-
Sigurd Schneider authored
Bug: chromium:1064873 Change-Id: Idec30007f93430397c03eb8cb2b18828df6f63cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247783 Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#779207}
-
Makoto Shimazu authored
This CL starts to use storage::mojom::ServiceWorkerResourceReader in ServiceWorkerCacheWriter. Previously we used ServiceWorkerResponseReader, whose interface is to pass an IO buffer and get the response asynchronously. However, the new interface is using Mojo's data pipe to read the body, whose interface is to ask to read and get the buffer. DataPipeReader is introduced as a convenient class to encapsulate the difference. Bug: 1055677 Change-Id: I1c077143fd155098fb997ddb3b44417f07dfbbda Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2195944 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779206}
-
Peter Kasting authored
* Remove using declarations that don't save space. * Remove unnecessary getters and overrides. * Make member variables private. * Use in-declaration initializers where possible. Bug: none Change-Id: Ia03228c5dee831ebd50cbaf636fdb0af671214f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249174Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Auto-Submit: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#779205}
-
Kim-Anh Tran authored
This reverts commit 9e308c32. Reason for revert: reverting a DevTools change required for the test to pass: https://chromium-review.googlesource.com/c/devtools/devtools-frontend/+/2248193 TBR: soxia@microsoft.com,Rob.Paveza@microsoft.com Bug: chromium:1095582, chromium:1066595 Change-Id: Ie7c122fa524dd992b30ee3a12345b97104720728 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248760 Commit-Queue: Kim-Anh Tran <kimanh@chromium.org> Commit-Queue: Benedikt Meurer <bmeurer@chromium.org> Reviewed-by:
Benedikt Meurer <bmeurer@chromium.org> Cr-Commit-Position: refs/heads/master@{#779204}
-
Yutaka Hirano authored
Call QuicStream::Reset when an outgoing stream is aborted. Bug: 1086371 Change-Id: I694fc03961d15c250f3412af30d1c387a4a5e67b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249198Reviewed-by:
Victor Vasiliev <vasilvv@chromium.org> Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Auto-Submit: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#779203}
-
Istiaque Ahmed authored
This CL makes lazy variant of service worker listener drop its service worker version id (akin to dropping worker thread id) by setting version id to kInvalidServiceWorkerVersionId. This CL also loads service worker listener's filters correctly from prefs. Note that these listeners (already) start with dropped worker version id. This CL expands unit tests that can now be run for service workers, namely EventRouterFilterTest and AddLazyListenersFromPreferences. Bug: 1094697, 1095568 Change-Id: I9ea04aa5439e001d1cb92ad774fb94067929a466 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245513 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#779202}
-
Youkichi Hosoi authored
The availabilities of binary translation libraries for ARC++ are determined by Chrome OS build-time USE flags houdini, houdini64, ndk_translation, and ndk_translation64. The information of these flags is used by Chrome to properly set up the binary translation related properties for ARCVM. Previously, the information on the ndk_translation64 USE flag was not available for Chrome. However, by crrev.com/c/2219757 and crrev.com/c/2222062, Chrome OS now puts --enable-ndk-translation64 in Chrome's command line arguments iff the ndk_translation64 USE flag is set at build time. This CL makes Chrome properly handle this new information in the same way as that of the other USE flags. BUG=b:139480143 TEST=components_unittests TEST=Write/delete ndk_translation64 to/from DUT's /etc/ui_use_flags.txt. TEST=Restart UI and log in. TEST=Run getprop and confirm that the edit is properly reflected upon TEST=the property ro.boot.native_bridge. Change-Id: I74e180edbb128bd1410f2951eaaa6a52328c4f9c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222240Reviewed-by:
Ryo Hashimoto <hashimoto@chromium.org> Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Commit-Queue: Youkichi Hosoi <youkichihosoi@chromium.org> Auto-Submit: Youkichi Hosoi <youkichihosoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#779201}
-
Glen Robertson authored
It now matches WebAppInstallSource enum in installable_metrics.h and will show the label in the UKM dashboard. The "sync" value wasn't recorded before but now is used in WebApp.DailyInteraction UKM. Change-Id: I050ae705e17070de21eeabbe130c7d560d29b1b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2245989Reviewed-by:
Glen Robertson <glenrob@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Glen Robertson <glenrob@chromium.org> Commit-Queue: Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#779200}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/de980231f62c..3244745c3d4b 2020-06-17 skia-autoroll@skia-public.iam.gserviceaccount.com Roll dawn from 984493d0ac07 to 3f4f35661151 (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC djsollen@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: djsollen@google.com Change-Id: I122ace7cd44c889b7419db636e5303c623e38995 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249386Reviewed-by:
-
sczs authored
When the InfobarManager will change dismiss the current Banner being presented in order to avoid the banner to be dismissed when the manager has already changed leading to some crashes. Bug: 1054024 Change-Id: Ia85b09b0bff300887a896b1a1c0e5887735edaa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248859 Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#779198}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/68fcfea37140..51487e1e3084 2020-06-17 syoussefi@chromium.org Add mipmap generation perftest If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC courtneygo@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: courtneygo@google.com Change-Id: If57d1b0930d25232968607b6eecfa69c9463761d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249383Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 911f84fc. With Chromium commits locally applied on WPT: 9c24e63c "Check for first frame in CreateImageBitmap" 458dc853 "WPT: Migrate content-visibility tests to wpt." 84f61c81 "Exclude non relevants reports from the COOP-opener-breakage tests." 90a6fd96 "Origin isolation: refactor and deduplicate web platform tests" 2d3ccbfc "Fixes empty alt text on broken images overriding css dimensions." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I9dc80afde2d32eb99397beadca7980aaa8e7dc8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248831Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#779196}
-
Istiaque Ahmed authored
This CL primarily expands EventListenerMap tests to account for service workers. It does so by parameterizing EventListenerMapTest with service worker / non-service worker param. Bug: None Change-Id: I11a657d1b5d9293d73c1c6546e81bede36319ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247548 Commit-Queue: Istiaque Ahmed <lazyboy@chromium.org> Reviewed-by:
-
Yoshifumi Inoue authored
This patch changes "fast/forms/caret-rtl.html" to utilize w3c test harness instead of pixel dump for ease of maintenance and help to enable EditingNG. Bug: 707656 Change-Id: I98e9d889dd843c4802d29997934d0d845cf24d70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249398 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#779194}
-
Rachel Wong authored
After some discussion, we have decided that if the suggested content toggle is not present, then playstore recommendations will still be enabled. This change modifies the logic so that we disable playstore search only if both the following conditions are met: (a) The suggested content toggle feature is enabled, (b) The suggested content pref is disabled. Bug: 1079169 Change-Id: I15d542bec594b6ce3bdc8449fc09db1da43e9472 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249280Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#779193}
-
Fergal Daly authored
This reverts commit 52e71572. Reason for revert: Test fixed in https://crrev.com/c/2248380 Change-Id: I6dc322d18627fd0a9638ec8d5c5073f1be4459ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248381Reviewed-by:
Fergal Daly <fergal@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Fergal Daly <fergal@chromium.org> Cr-Commit-Position: refs/heads/master@{#779192}
-
Yoshifumi Inoue authored
This patch gets rid of a space before <br> from "drag-in-iframe.html" to pass this test in both legacy layout and EditingNG for ease of enabling EditingNG. Space before <br> should be collapsed this test[1], but legacy layout does so and EditingNG does to follow the spec[1]. This differences isn't part of these test file to drag in <iframe>. [1] https://drafts.csswg.org/css-text-3/#white-space-property Bug: 707656 Change-Id: I42cc0f7b9cdc1c93dc64472669fc46c08b1a7c1f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2248384 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Bartek Nowierski authored
Having make_unique (which calls malloc) won't work well once malloc starts using PartitionAlloc, due to reentrancy. Bug: 1086388 Change-Id: I037420ae3fa41f6340da38682c6a210b2b1ce33b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246368Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Takashi Sakamoto <tasak@google.com> Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#779190}
-
Peter Wen authored
Since cmdline-tools is now 2.0, it can be updated with DEPS changes according to the bot output: https://luci-scheduler.appspot.com/jobs/chromium/android-sdk-packager Fix NewApi issue in BackgroundTaskSchedulerJobService that was blocking this roll. Ignore two new lint errors: Instantiatable and MissingClass. Both of these checks require passing the transitive classpath, which we do not currently pass. Although we can consider turning these on, they do not seem to provide much value since if classes were missing then our compiles would already have failed (not to mention we have our bytecode checks). Thus ignore these two checks in favour of not slowing down lint any further. Bug: 1093896, 1069201 Change-Id: I14b59b18bb14de346a5cde5609caaad6c28826cd Fixed: 1093896, 1069201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246187 Auto-Submit: Peter Wen <wnwen@chromium.org> Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#779189}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/fbbd9ca81f96..a286a8469b97 2020-06-17 dberris@chromium.org operations: Add timestamps for extents If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC eseckler@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: eseckler@google.com Change-Id: Iea458b30ac04b5764e23c416aa18892c41fbbe62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249381Reviewed-by:
-
Yoshifumi Inoue authored
Get rid of a space before <br> in editing/selection/modify_move/move_{left,right}_word_05_{ltr,rtl}_multi_line.html This patch gets rid of a space before <br> from "move_{left,right}_word_05_{ltr,rtl}_multi_line.html" to pass these tests are both legacy layout and EditingNG for ease of enabling EditingNG. Space before <br> should be collapsed these tests[1], but legacy layout does so and EditingNG does to follow the spec[1]. This differences isn't part of these test files verifying Ctrl+Left/Right arrow key behavior. [1] https://drafts.csswg.org/css-text-3/#white-space-property Bug: 707656 Change-Id: If5f2224366d8e0832b3aa19ef1ba10c7ee232433 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247945 Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by: -
tby authored
The Drive QuickAccess provider makes API calls to the backend, and each API call should first cancel any in-flight calls. Currently we do that by binding the call to a weak pointer, and invalidating all weak pointers before making the next API call. But this causes a bug: other parts of the provider rely on the same weak pointer factory for unrelated callbacks, which then get erroneously cancelled. This CL adds a second weak pointer factory, and splits the work between the two. This lets the API calls be cancelled independent of all other calls. Note I can only find one place in the codebase using two factories [1], but I can't think of an better fix here. [1] https://cs.chromium.org/chromium/src/chrome/browser/ui/browser.h?l=1209 Bug: 1034842 Change-Id: I034c0fdaff580801bb147cbd1cba24d499bf0002 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2246002Reviewed-by:
Rachel Wong <wrong@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#779186}
-
Yoshifumi Inoue authored
This patch introuces |NGInluneCursor::PositionForPointInChild()| as replacement of existing verion with following differences: - It takes only one parameter |point_in_container|, because |child_item| is reduntant and as same as current cursor position. - It works both |NGPaintFragment| and |NGFragmentItem|. for preparation of the CL[1]. [1] http://crrev.com/2249278 [EditingNG] Make SelectionModifier:: {Next,Previous}LinePosition() to move editable to editalbe correctly Bug: 707656 Change-Id: If5605edd02bec664c331cecebc70c4723094ab56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2247943 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Eric Willigers authored
We add a unit test for ShelfContextMenu involving a web app. Bug: 1086833 Change-Id: Ia853b273d8140d6ba2ca47bd98bc31b06d7d0b10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249241 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Dominick Ng <dominickn@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
Francois Beaufort authored
This CL changes CameraHalDelegate::GetDeviceDescriptors on ChromeOS to advertise pan, tilt, or zoom support or no support depending on device capabilities. Test: https://ptz.glitch.me/ w/ Experimental Web Platform Features flag on a Krane device should prompt user with "Use and move camera". Bug: 934063 Change-Id: Ifb63658d3d2d79d89b432f13473ad0f0e95aae6c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2241542 Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Shik Chen <shik@chromium.org> Cr-Commit-Position: refs/heads/master@{#779183}
-
Chris Hall authored
AX-Relnotes: N/A Bug: 1093651 Change-Id: Iabc78cb0eb2ca3f583cf5eeaf8c07502d50da280 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2239142Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Commit-Queue: Chris Hall <chrishall@chromium.org> Cr-Commit-Position: refs/heads/master@{#779182}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/3eb899a1e52d..a071cce7fd70 2020-06-17 nodir@chromium.org Roll lucicfg to 1.15.1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I0d5d31a96e009c4d56100065016992cb90c123fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249176Reviewed-by:
-
Jason Lin authored
This gives the buttons correct styling. Bug: 1094946 Test: manually install Change-Id: I537cc055d6d08f21ead400af5cedbfedc9398ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2249239 Auto-Submit: Jason Lin <lxj@google.com> Reviewed-by:
Timothy Loh <timloh@chromium.org> Commit-Queue: Timothy Loh <timloh@chromium.org> Cr-Commit-Position: refs/heads/master@{#779180}
-
