GitLab

Since V8 now supports internal fields for the global proxy objects,
let's change the mappings among global proxy object / global object /
C++ instance in Blink.

With this CL, a global proxy object and C++ instance point to each
other, and a global object points to the C++ instance (without
reverse pointer).

BUG=675872

Review-Url: https://codereview.chromium.org/2620493002
Cr-Commit-Position: refs/heads/master@{#443515}

Now that we've shipped a per-thread heap, a Dead state should not happen.
This CL adds an assert to check the fact.

BUG=

Review-Url: https://codereview.chromium.org/2629853002
Cr-Commit-Position: refs/heads/master@{#443514}

For pages where there was a FrameOwnerElement with a null
ContentDocument CSS.getLayoutTreeAndStyles would crash.  This patch
fixes that.

BUG=680497, 546953

Review-Url: https://codereview.chromium.org/2623273006
Cr-Commit-Position: refs/heads/master@{#443513}

This change is a small refactor that pushes the details of whether
custom property values are stored in StyleInheritedVariables or
StyleNonInheritedVariables down into ComputedStyle. This is in preparation
for animations on registered custom properties and avoids duplicated
logic.

BUG=671904

Review-Url: https://codereview.chromium.org/2630683002
Cr-Commit-Position: refs/heads/master@{#443512}

These objects should be a per-DOMWindow thing instead of a per-ExecutionContext thing.
They should DOMWindowClient instead of ContextClient.

BUG=610176

Review-Url: https://codereview.chromium.org/2626423003
Cr-Commit-Position: refs/heads/master@{#443511}

Currently only shares to a demo Share Target App hosted at
https://wicg.github.io/web-share-target/demos/sharetarget.html;
follow-up CL will have more share options.

BUG=668389

Review-Url: https://codereview.chromium.org/2564483003
Cr-Commit-Position: refs/heads/master@{#443510}

ScrollbarTestSuite registers Platform::current()->compositorSupport() to
TestingPlatformSupportWithMockScheduler, but
TestingPlatformSupportWithMockScheduler does the same thing internally.

So we can just remove ScrollbarTestSuite without any behavior change.

BUG=n/a
TEST=blink_platform_unittests

Review-Url: https://codereview.chromium.org/2621393003
Cr-Commit-Position: refs/heads/master@{#443509}

https://chromium.googlesource.com/external/github.com/catapult-project/catapult.git/+log/fe8a3c8a5cdb..4bd198f6a85c

$ git log fe8a3c8a5..4bd198f6a --date=short --no-merges --format='%ad %ae %s'
2017-01-12 bpastene devil: Push devil onto the path when running reset_usb.py manually.
2017-01-12 rnephew [BattOr] Update BattOr Agent binary in cloud storage.

BUG=679375

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=catapult-sheriff@chromium.org

Review-Url: https://codereview.chromium.org/2631643002
Cr-Commit-Position: refs/heads/master@{#443508}

mStarted is set on UI thread, so we shouldn't check it on other threads.
And there is no point to check it at the beginning of the test since it is always false.

BUG=680533

Review-Url: https://codereview.chromium.org/2629703002
Cr-Commit-Position: refs/heads/master@{#443507}

A ThreadableLoader must be completed before it's destructed. We need to forbid
to create ThreadableLoader multiple times in some classes to ensure that.
This CL adds CHECKs to make sure that.

BUG=667254

Review-Url: https://codereview.chromium.org/2629823002
Cr-Commit-Position: refs/heads/master@{#443506}

Review-Url: https://codereview.chromium.org/2623423004
Cr-Commit-Position: refs/heads/master@{#443505}

BUG=629223

Review-Url: https://codereview.chromium.org/2614663005
Cr-Commit-Position: refs/heads/master@{#443504}

Now move first paint notification code from GraphicsLayer
CompositedLayerMapping into FrameView.

BUG=657825
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2623043002
Cr-Commit-Position: refs/heads/master@{#443503}

Review-Url: https://codereview.chromium.org/2626313002
Cr-Commit-Position: refs/heads/master@{#443502}

BUG=none

Review-Url: https://codereview.chromium.org/2626403002
Cr-Commit-Position: refs/heads/master@{#443501}

These tests are flaky because there is a delay between infobars being
removed in the native InfobarManager, and this flowing through the the
Java side of things. This change introduces a polling loop whenever
an infobar is removed to account for this.

BUG=678210

Review-Url: https://codereview.chromium.org/2621983003
Cr-Commit-Position: refs/heads/master@{#443500}

This CL implements search by sending a query to the existing backend
search and then updating the ui to reflect the search result. The
bookmarks list will now either display the contents of a folder or the
search results.

BUG=658980
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2614703003
Cr-Commit-Position: refs/heads/master@{#443499}

Presumably this was used in the past, but it isn't used anymore except
in the ScriptContextSet classifier. However, the classifier can use the
world ID to accomplish the same thing, so just remove this and clean up
a bunch of dead code.

BUG=481699
R=haraken@chromium.org,peria@chromium.org,yukishiino@chromium.org
TBR=jochen@chromium.org,rdevlin.cronin@chromium.org

Review-Url: https://codereview.chromium.org/2628053003
Cr-Commit-Position: refs/heads/master@{#443498}

Data reduction proxy is always allowed with primary and fallback
mechanism.

BUG=654438

Review-Url: https://codereview.chromium.org/2626963003
Cr-Commit-Position: refs/heads/master@{#443497}

Some content embedders (such as WebView) may not have a ContentSubresourceFilterDriverFactory
created. Do not enforce it.

BUG=680791

Review-Url: https://codereview.chromium.org/2633593002
Cr-Commit-Position: refs/heads/master@{#443496}

device::mojom::TimeZoneMonitor has been changed to be hosted by Device Service,
so this CL removes it from content_browser manifest, and also removes
some unnecessary dependencies from content/.

BUG=612341

Review-Url: https://codereview.chromium.org/2630463003
Cr-Commit-Position: refs/heads/master@{#443495}

This originated from my CL to extract files from modules:
crrev.com/442706

Main sometimes calls _createAppUI which instantiates ExecutionContextSelector
before ExecutionContextSelector.js is loaded.

I also made runOnWindowLoad async to be consistently async

BUG=none

Review-Url: https://codereview.chromium.org/2624383005
Cr-Commit-Position: refs/heads/master@{#443494}

Uses ICU. This change also enables using it on the Desktop implementation. A followup will enable it on Android.

BUG=679797
TEST=CurrencyFormatterTest, LANGUAGE=fr_CA ./out/Default/chrome

Review-Url: https://codereview.chromium.org/2621033003
Cr-Commit-Position: refs/heads/master@{#443493}

R=dschuyler@chromium.org
BUG=673953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626993003
Cr-Commit-Position: refs/heads/master@{#443492}

Geometry: Common -> UI
CSSShadowModel: Common -> InlineEditor

I namespaced three global variables in Geometry:
'Size', 'Insets', 'Constraints'

BUG=none

Review-Url: https://codereview.chromium.org/2626143004
Cr-Commit-Position: refs/heads/master@{#443491}

In order to be suitable for use from within CertVerifyProc, this CL makes
CertNetFetcher shareable between the network and worker threads. The
worker thread will start and wait for fetch requests, but the network
thread needs to be able to create and shutdown the fetcher. Shutdown is
needed to be able to destroy the URLRequestContext cleanly: since the
CertNetFetcher will have a reference to the URLRequestContext, the network
thread needs to be able to shut down the fetcher and cancel outstanding
requests before destroying the URLRequestContext.

Thus this CL makes CertNetFetcher refcounted (replacing its refcounted
bridge class CertNetFetcherCore) and gives it a Shutdown method to cancel
its outstanding requests and prevent new ones from starting.

Note that there is still a race where a worker thread could issue a fetch
request while the network thread is shutting down. In this case,
the fetch task would never run on the network thread and WaitForResult would
hang indefinitely. I'm not sure what to do about this except give
WaitForResult() a timeout like nss_ocsp does.

BUG=657549

Review-Url: https://codereview.chromium.org/2595723002
Cr-Commit-Position: refs/heads/master@{#443490}

The EarlGrey tests were not using the apps Info.plist file,
which resulted in UIFileSharingEnabled not being set for tests.

BUG=676735

Review-Url: https://codereview.chromium.org/2622403005
Cr-Commit-Position: refs/heads/master@{#443489}

This is part of an effort to remove all business logic from SBHI.

BUG=669967

Review-Url: https://codereview.chromium.org/2624943002
Cr-Commit-Position: refs/heads/master@{#443488}

BUG=none

Review-Url: https://codereview.chromium.org/2609363002
Cr-Commit-Position: refs/heads/master@{#443487}

The previous code had a bug that it would never start observing newly
added windows (Changing is sent for old parent, and Changed for new
parent, so DisconnectedAppHandler really need to override both
Changing and Changed). In fixing that I figured it was easier to
reason about if it's associated with a single top level window.

This bug was causing the shelf to never remove items when the window closed.

BUG=none
TEST=none
R=sadrul@chromium.org

Review-Url: https://codereview.chromium.org/2629523006
Cr-Commit-Position: refs/heads/master@{#443486}

Adds several additional WebVR layout tests.

Refactors the WebVR Mojo mocking to more closely emulate the actual
actual implementation.

Fixes several issues in the WebVR source code that were encountered by these
tests.

BUG=679952,679288

Review-Url: https://codereview.chromium.org/2624263003
Cr-Commit-Position: refs/heads/master@{#443485}

R=dpapad@chromium.org
BUG=680012,680084
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2626173004
Cr-Commit-Position: refs/heads/master@{#443484}

Cr-Commit-Position: refs/heads/master@{#443483}

Updated independent-inheritance-fast-path.html to test all keywords
instead of just testing a single keyword. Updated the independent
properties table to include all keywords for the independent properties.

BUG=628043

Review-Url: https://codereview.chromium.org/2620383008
Cr-Commit-Position: refs/heads/master@{#443482}

Previously the host telemetry logger doesn't report these information. This
CL fixes this problem so that we can use host info to filter stats.

BUG=680644

Review-Url: https://codereview.chromium.org/2629593003
Cr-Commit-Position: refs/heads/master@{#443481}

This is a follow-up fix to http://crrev.com/2630493002.

In that CL, I changed the path to the manifest command but
used the wrong path, resulting in the latest import failing:
https://build.chromium.org/p/chromium.infra.cron/builders/w3c-test-autoroller/builds/7868

The manifest script is actually checked into:
https://chromium.googlesource.com/chromium/src/+/master/third_party/WebKit/Tools/Scripts/webkitpy/thirdparty/wpt/wpt/manifest

BUG=678077

Review-Url: https://codereview.chromium.org/2626183004
Cr-Commit-Position: refs/heads/master@{#443480}

The new test harness has been deployed; let's see whether it's more
reliable.

BUG=603329
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
NOTRY=true

Review-Url: https://codereview.chromium.org/2629763002
Cr-Commit-Position: refs/heads/master@{#443479}

Gtk3.20 changed the selector for menu separators.  This CL adds a
version check to use the appropriate selector.

BUG=132847
R=erg@chromium.org

Review-Url: https://codereview.chromium.org/2627153003
Cr-Commit-Position: refs/heads/master@{#443478}

BUG=460102,679417

Review-Url: https://codereview.chromium.org/2619863002
Cr-Commit-Position: refs/heads/master@{#443477}

Currently even there is no custom search engine to show (such as clean
start), "Recently visited" header will still be displayed. This
is confusing for users.

To fix this, there is no custom search engine to show, remove the "Recently
visited" header.

BUG=679608

Review-Url: https://codereview.chromium.org/2623113002
Cr-Commit-Position: refs/heads/master@{#443476}