- 04 Mar, 2020 40 commits
-
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/05f974d7..18eac1a4 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I61106dd2413678c4a4224997dc5466a51b009fa0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086158Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746652}
-
Akihiro Ota authored
Due to changes in relative file paths, ChromeVox doesn't correctly display images in the panel. Fix the relative file paths so they get rendered correctly. Also ensures the options button in the panel opens the options page. Change-Id: I74f6e36086458f458b6725b8b5fad0ef08d5d99d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086291 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746651}
-
Khushal authored
The Xiaomi Mibox 4 device doesn't support anything more than 1. Internally SurfaceTexture also uses 1 here so update the ImageReader implementation to use the same. R=dalecurtis@chromium.org, liberato@chromium.org Bug: 1051705 Change-Id: I8fb1e88fbca9b1d0acb932cb4e1ac851a7c05762 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086313 Commit-Queue: Khushal <khushalsagar@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#746650}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a54af923929b..20ed48e8e963 git log a54af923929b..20ed48e8e963 --date=short --first-parent --format='%ad %ae %s' 2020-03-04 rmistry@google.com Create flutter checkouts from scratch Created with: gclient setdep -r src/third_party/skia@20ed48e8e963 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: I96c3285d6c74ecb7ade759749d0828337f6035b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086178Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746649}
-
Kei Nakashima authored
Implemented RemoveFirst, pop_back, AppendOrMoveToLast, PrependOrMoveToFi rst and InsertBefore to NewLinkedHashSet. Also, added tests for those fu nctions. Added DCHECK for checking if each node in a vector is used. Change-Id: I9da2dd77db203f68b9d4312890cbc748c594d004 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081726 Commit-Queue: Kei Nakashima <keinakashima@google.com> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#746648}
-
Luciano Pacheco authored
Change icons for files without thumbnails to show the file's icon as thumbnail. See crbug.com/992822#c14 for some screenshots. Change generic icons SVG to have fill color --google-grey-700 to use them background-image instead of -webkit-mask-image to simplify the CSS logic to overwrite the generic icon to specific icons. For specific icons we want to use their SVG color, which isn't possible when using -webkit-mask-image. Force the grey color for ".detail-icon" to have icons used as -webkit-mask-image have the correct color. This in turn requires to force the blue color for ".detail-checkmark" because this element is child of ".detail-icon" causing it to inherit the color. Change the JS logic to add CSS classes to make easier to style: 1. Initialize the ".img-container" with CSS class "no-thumbnail". 2. Remove "no-thumbnail" class once a thumbnail is loaded. 3. For FilesNg don't add the ".shield" div at all. 4. For FilesNg don't add the 2 divs ".checkmark.active" and ".checkmark.inactive". Instead add ".detail-checkmark" in the same place it adds for folders, which is the same as File List. 5. Change setGenericThumbnail_() (for FilesNg) to set the attribute "generic-thumbnail" as the mime type icon instead of media type, media type is limited to: image, video, audio, raw, documents, etc, which is too coarse to be able to customize icon per mime type/file type. This is the same logic used for the File List and the smaller icon near the file name. Bug: 992822 Change-Id: Idf4cd25381bf5a12767c4bc970f73f2e418dad7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082660 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Noel Gordon <noel@chromium.org> Cr-Commit-Position: refs/heads/master@{#746647}
-
Kazuki Takise authored
We adjust PIP initial bounds in exo as Android isn't aware of some Chrome OS System UI We should apply this logic only to the PIP initial bounds. Otherwise, the obsolete bounds might be applied incorrectly for display rotation, PIP fling, etc. Whether it's entering PIP or not can be checked by whether the snap fraction is set or not as the snap fraction is set when the initial bounds is actually applied to the window in ClientControlledState. BUG=b:149889040 BUG=b:149875362 TEST=Manually confirmed PIP fling and screen rotation put PIP to the correct position. Change-Id: I0f988b1ed6467c6d7a005bb1b0abc6e220277c5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081650 Commit-Queue: Kazuki Takise <takise@chromium.org> Auto-Submit: Kazuki Takise <takise@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Cr-Commit-Position: refs/heads/master@{#746646}
-
Evan Stade authored
Before this patch, when the history stack was empty and the user pressed the system back button, the tab would be closed (usually --- depending on how the tab was opened). The beforeunload handler, if any, would be skipped, even though navigating in a different manner *would* trigger beforeunload. In comparison, desktop Chrome does run beforeunload when closing a tab (via the tab close button, for example). So this discrepancy seems unintended. This fix *only* affects system back and not other ways of closing tabs. So, for example, closing from the tab switcher UI will still immediately close, but offer an undo notification bar. This should not have any effect if a page does not have a beforeunload handler (or the handler is not active due to the lack of a user gesture), except that closing will be asynchronous. The same sequence happens in TabModelImpl, as TabModel#closeTab is called with the same arguments by way of TabWebContentsDelegateAndroid#closeContents. Bug: 1055540 Change-Id: Ie9e45692b920db54fd3d00f06466edee01771d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2071491 Commit-Queue: Evan Stade <estade@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#746645}
-
Xing Liu authored
NavigationEntryTest.NavigationEntryContentUri is failing on Android builders. This CL disables it. TBR=arthursonzogni@chromium.org Bug: 1050906 Change-Id: Ie43860ae550b11662087e7f1ffee5ebca85d1827 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086265Reviewed-by:
Xing Liu <xingliu@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746644}
-
Kaustubha Govind authored
Improve DNS configuration checking to handle additional cases where we must defer to platform DNS, such as checking for DNS proxies and VPN configurations, and an additional policy that could be used to configure NRPT rules. Bug: 1052139 Change-Id: I4884f76b576964e976114169113259e28fc78801 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2055761Reviewed-by:
Eric Orth <ericorth@chromium.org> Commit-Queue: Kaustubha Govind <kaustubhag@chromium.org> Cr-Commit-Position: refs/heads/master@{#746643}
-
Nnamdi Theodore Johnson-Kanu authored
This CL moves chromeOS strings for settings Date/Time page from settings_strings.grdp to os_settings_strings.grdp. It continues the process of moving all chromeOS specific strings. Bug: 967883 Change-Id: Ie0f1edeea54b8399f205ca2facc0b8b2c2f5d55e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2069968 Commit-Queue: Nnamdi Theodore Johnson-kanu <tjohnsonkanu@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#746642}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/7f746ebe3585..eedab7912f7c Created with: gclient setdep -r src-internal@eedab7912f7c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ia376e7d402a090b1ddb1d346eb6b9868bf83610f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086175Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#746641}
-
Daniel Rubery authored
This CL replaces AdvancedProtectionDeepScanningEnabled with a new policy AdvancedProtectionEnhancedSecurityAllowed. This new policy is meant to cover all Advanced Protection security features in Chrome, rather than covering each on a case-by-case basis. Note that deep scanning of downloads for Advanced Protection users didn't launch in M81, so this new policy will be covering the feature from launch. Bug: 1056358 Change-Id: I9e262009e4dd48d73a28ca4c8f0e104202bb9817 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079301 Commit-Queue: Daniel Rubery <drubery@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Cr-Commit-Position: refs/heads/master@{#746640}
-
Yusuf Sengul authored
Bug: 1055977 Change-Id: I1756855b25371b9bbf0da02a63cb1c754790f697 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086256 Commit-Queue: Yusuf Sengul <yusufsn@google.com> Reviewed-by:
Rakesh Soma <rakeshsoma@google.com> Cr-Commit-Position: refs/heads/master@{#746639}
-
Evan Stade authored
If we wanted to support fractional scales well we'd need to switch to using some smaller unit, such as milliseconds, but that doesn't seem to be the purpose of scaleTimeout (the example given in the documentation is scale == 20), and it would require touching many files. Bug: none Change-Id: I97b625d10b3be5ddbd305694ab78714a43677f08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084717Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#746638}
-
Pavel Feldman authored
This allows associating navigation events with the input, the way it was supposed to be at the first place. By default, inspector events are coalesced and only flushed upon either protocol command ack or blink task end. It is essential to not compromise runtime performance. It is also essential to push notify in-time for selected navigations and we already did that for many events, just not the navigation ones. Fixing this. Change-Id: I0b765bd634b3c03b64249150734e1368327b5b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083562 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#746637}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 127 histograms that show frequent access in the past 90 days. These are the 90% most frequently used histograms over that time that do not already have a date later than or within 60 days of 2020-08-30. Change-Id: Ibe0539b849ff6de9bd7eb7ae75bef38afd2c27c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085232 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#746636}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/90019cea5ec9..54bd00057324 git log 90019cea5ec9..54bd00057324 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 cnorthrop@google.com Capture/Replay: Add Query Object support to mid-execution capture 2020-03-03 cnorthrop@google.com Capture/Replay: Update getTexImage for depth/stencil and 3D Created with: gclient setdep -r src/third_party/angle@54bd00057324 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ianelliott@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: ianelliott@google.com Change-Id: Iab597fe1f4bc37bc413e3ba63c14835669332d97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086113Reviewed-by:
-
Tibor Goldschwendt authored
This includes adding title navigation to the customize dialog to switch between collections and images. NOTE: This does not embed actual images. Will do this in a follow up CL. Bug: 1032328 Change-Id: I3f9931aca673590dcd05dd4e4fa6dcf046aee3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076554 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#746634}
-
Brian Osman authored
Bug: chromium:1045995 Change-Id: If8d5873d355c12587bc231091145b0312726b667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085293Reviewed-by:
Mike Klein <mtklein@google.com> Reviewed-by:
ccameron <ccameron@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Brian Osman <brianosman@google.com> Cr-Commit-Position: refs/heads/master@{#746633}
-
Lukasz Anforowicz authored
Fixed: 1054974 Change-Id: Ica1b44284e99f9b56f49bcbb602bfd0cdb6de648 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081263Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#746632}
-
Dan Harrington authored
StreamModel ingests DataOperations and provides the set of content to be rendered by the UI. Also supports ephemeral changes which can be undone later. We'll add some additional features to this class soon, as it is only a subset of what we need. Bug: 1044139 Change-Id: I1b8d6c6196c9102c0cd6696033b3083ccf350c47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083433 Commit-Queue: Dan H <harringtond@chromium.org> Reviewed-by:
Ian Wells <iwells@chromium.org> Cr-Commit-Position: refs/heads/master@{#746631}
-
Robert Liao authored
This test helps ensure that color values do not change when the Color Provider feature is enabled. BUG=1057754 TBR=sky@chromium.org ui/base Feature Addition for the Color Provider. Change-Id: Ifd115ee7d4b6f73e337e5e74269d521960de7250 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086191 Commit-Queue: Robert Liao <robliao@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#746630}
-
Nicholas Hollingum authored
When the user is back up their container in-advance of an upgrade the user is shown a file-chooser. If they cancel, currently they will be shown a "backup successful" window for 2 seconds. We track this now by removing the 2 second timeout when the user cancels. Technically the "backup successful" screen still flashes up while the pre-checks run, but this is practically instant so i don't think its worth making a more involved change. Bug: 1052719 Change-Id: If99e5e6775ac81b6dede0c8e2a2f35b77e26fe2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079776Reviewed-by:
Nicholas Verne <nverne@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Commit-Queue: Nic Hollingum <hollingum@google.com> Cr-Commit-Position: refs/heads/master@{#746629}
-
Brandon Wylie authored
Bug: 1049829 Change-Id: Ia262b370239816d02c58f2066e20c907169865f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2080818 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Patrick Noland <pnoland@chromium.org> Cr-Commit-Position: refs/heads/master@{#746628}
-
Evan Stade authored
This improves on CountDownLatch by adding a default timeout and turning the InterruptedException into an assertion failure. The biggest advantage of a timeout is that the test will fail with a stack trace, as opposed to failing with no trace or logs. Bug: 1052802 Change-Id: I236a996b4da1870644fddfa6da28c7d9e51191e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079909Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/83af90cf49de..024aa8877850 git log 83af90cf49de..024aa8877850 --date=short --first-parent --format='%ad %ae %s' 2020-03-03 hjd@google.com Merge "Disable ftrace_procfs_integrationtest" Created with: gclient setdep -r src/third_party/perfetto@024aa8877850 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ia098908a329bdb116e7328c5996708e7141889ff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086172Reviewed-by:
-
Anastasia Helfinstein authored
This is a step towards incorporating Rose and Sophie's code (see links below) for text navigation and selection from last summer into the new navigation paradigm. Ex: https://chromium-review.googlesource.com/c/chromium/src/+/1772301 https://chromium-review.googlesource.com/c/chromium/src/+/1727242 Bug: 982004 Change-Id: I9a3c9e86dfdf15c3cdaea0086f64273192c06491 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2076445 Commit-Queue: Anastasia Helfinstein <anastasi@google.com> Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#746625}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/e1318818e6ab..fe6f75240a8c git log e1318818e6ab..fe6f75240a8c --date=short --first-parent --format='%ad %ae %s' 2020-03-03 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (nontrivial). Created with: gclient setdep -r src/third_party/depot_tools@fe6f75240a8c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I3f884b2c182c5d8bbf21f7963c7619dda3b15efe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086174Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I498dc4650403679f81766867cd67fe58c63a1f28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086177Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/4036cb1f0b6e..a54af923929b git log 4036cb1f0b6e..a54af923929b --date=short --first-parent --format='%ad %ae %s' 2020-03-03 bsalomon@google.com Make AHWBuffer generator responsible for MIP maps. Created with: gclient setdep -r src/third_party/skia@a54af923929b If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC herb@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: herb@google.com Change-Id: Iaa77263c14e8e1525d8ea13821b6550ae2fd827e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086173Reviewed-by:
-
Azeem Arshad authored
This reverts commit f4914fbf. Reason for revert: The paper-tooltip overflows outside of modal dialog boxes and results in unwanted horizontal scrollbars. see https://crbug.com/1055266. This fix should implement the tooltip in such a way that fits correctly inside the container. Original change's description: > Network settings: Add tooltip to eye icon-button > > > Bug: 873114 > Change-Id: I05cef0d2a7e53c1bc965764e2b83aefd502753cf > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1993828 > Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> > Commit-Queue: Roman Aleksandrov <raleksandrov@google.com> > Cr-Commit-Position: refs/heads/master@{#732662} TBR=dpapad@chromium.org,raleksandrov@google.com,johntlee@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 873114, 1055266 Change-Id: I0b7561abaf41a597556cc2e0e8d0481101eeab10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086351 Commit-Queue: Azeem Arshad <azeemarshad@chromium.org> Reviewed-by:
Azeem Arshad <azeemarshad@chromium.org> Cr-Commit-Position: refs/heads/master@{#746621}
-
Andrew Grieve authored
This is a reland of 91ac1e45 TBR=agrieve@chromium.org Original change's description: > Android: Speculative crash fix for DelayedScreenLockIntentHandler > > Stack is: > Caused by: android.util.AndroidRuntimeException: Calling startActivity() from outside of an Activity context requires the FLAG_ACTIVITY_NEW_TASK flag. Is this really what you want? > at android.app.ContextImpl.startActivity (ContextImpl.java: 952) > at android.content.ContextWrapper.startActivity (ContextWrapper.java: 405) > at org.chromium.chrome.browser.ChromeApplication.startActivity (ChromeApplication.java: 206) > at org.chromium.chrome.browser.ChromeApplication.startActivity (ChromeApplication.java: 199) > at org.chromium.chrome.browser.DelayedScreenLockIntentHandler.onReceive (DelayedScreenLockIntentHandler.java: 40) > at android.app.LoadedApk$ReceiverDispatcher$Args.lambda$getRunnable$0$LoadedApk$ReceiverDispatcher$Args (LoadedApk.java: 1550) > ... > > From history on DelayedScreenLockIntentHandler, repro steps involve > launching a page via NFC while locked. > > This restriction is listed as a new one in Android P: > https://developer.android.com/about/versions/pie/android-9.0-changes-all#fant-required > > Bug: 1034440 > Change-Id: Ibe13fb99a34d36a15e266d9369393dd6060a1e93 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1972135 > Commit-Queue: Andrew Grieve <agrieve@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#746442} Bug: 1034440 Change-Id: Ie7be9554e9ab2818894ef67e543f9c7249c6665f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086251 Commit-Queue: Xing Liu <xingliu@chromium.org> Reviewed-by:
-
Darwin Huang authored
https://crrev.com/c/2080256 disabled these tests on all platforms. This CL re-enables these tests when not on Android, so that bots can continue to verify correct behavior on other platforms. Bug: 1056650 Change-Id: Id057bd3fe5c0dfbcdc405d60c9a6d58133999aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086252 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#746619}
-
dalyk authored
During the DoH auto-upgrade experiment we disabled OCSP/CRL fetches for connections to DoH servers. This change takes a different approach to breaking the potential deadlock and instead disables DoH for all OCSP/CRL/AIA fetches. Bug: 990827 Change-Id: I9885cac230aafaa41ba183b5799e771ba7c524e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1843334 Commit-Queue: Katharine Daly <dalyk@google.com> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#746618}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/f796ed84..05f974d7 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I093ac585504e289eb6ff2e8aeafb8990c798319a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085512Reviewed-by:
-
Zain Afzal authored
Addresses some of the final comments on message_pipe.js from crrev/c/2049404. Namely adds a assertCast for better safety when casting our targetWindow reference, and removes some unnecessary type casts. Bug: 996088 Change-Id: I91f9af2329feafcaab45395e8290631697afb7a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2084271 Commit-Queue: Zain Afzal <zafzal@google.com> Reviewed-by:
Trent Apted <tapted@chromium.org> Cr-Commit-Position: refs/heads/master@{#746616}
-
Xinghui Lu authored
The token is obtained from safe_browsing_token_fetcher and set in the request header. After the request is sent, the token is also set in the RTLookupRequest proto, which is used for displaying in chrome://safe-browsing. Bug: 1041912 Change-Id: Ic4a6c9e9eb1370e8fa90ff0b0292d1f3a206bd1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2079809Reviewed-by:
Daniel Rubery <drubery@chromium.org> Commit-Queue: Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#746615}
-
Wan-Teh Chang authored
https://chromium.googlesource.com/codecs/libgav1.git/+log/8e8c13b9e821..fa1c3c4e673c $ git log 8e8c13b9e..fa1c3c4e6 --date=short --no-merges --format='%ad %ae %s' 2020-02-19 wtc Change libgav1's frame buffer callback API. 2020-02-18 vigneshv Move tile_scratch_buffer_pool_ to FrameScratchBuffer 2020-02-18 jzern film_grain.h: remove unused fn decls 2020-02-18 jzern libgav1_decoder.cmake: rm commented out header 2020-02-18 vigneshv trivial: Rename EncodedFrame to TemporalUnit 2020-02-18 johannkoenig blend: remove stride from average blend 2020-02-18 johannkoenig prediction: remove prediction_stride 2020-02-18 vigneshv trivial: Refactor ApplyFilmGrain parameters 2020-02-17 wtc Rename YuvBuffer::displayed_width+displayed_height 2020-02-17 vigneshv trivial: Fix ApplyFilmGrain return status on success Created with: roll-dep src/third_party/libgav1/src Update the libgav1 frame buffer callbacks in media/filters/gav1_video_decoder.cc to the final prototypes. In particular, omit the OnFrameBufferSizeChangedImpl callback. Tested: $ gn args out/Default # In the editor, add the following build argument: # enable_libgav1_decoder = true $ autoninja -C out/Default media_unittests $ out/Default/media_unittests $ out/Default/media_unittests --enable-features=Gav1VideoDecoder R=tomfinegan@chromium.org,johannkoenig@google.com,jzern@google.com Bug: 1026522 Change-Id: I8f316131b74bdd1242ab7394346c043c355736e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2085593 Commit-Queue: Wan-Teh Chang <wtc@google.com> Reviewed-by:
James Zern <jzern@google.com> Cr-Commit-Position: refs/heads/master@{#746614}
-
Hongchan Choi authored
In cross-thread messaging, the associated execution context can be already gone when a posted task is performed sometime later in the task runner's queue. By using WeakPtr, the task runner will not perform a scheduled task in the queue when the target object is invalid. Test: Locally confirmed that the repro does not crash. Bug: 1057627 Change-Id: I51737594c918f6a4924c9a7ffe30db3e8de9a683 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2082897 Commit-Queue: Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#746613}
-
