- 24 Oct, 2018 40 commits
-
-
Marc Treib authored
The test was previously marked as timing out on Windows. However: - It does occasionally pass. - It doesn't actually time out on Windows Release. - It does time out in Debug builds on other platforms though. TBR=pdr@chromium.org Bug: 666993, 898456 Change-Id: I5071af34d4fdb8bed911e864b28ce81eb954fff0 Reviewed-on: https://chromium-review.googlesource.com/c/1297146Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#602339}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7b6a59fda6b6..00455e014868 git log 7b6a59fda6b6..00455e014868 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 perezju@chromium.org [soundwave] Add "health" study for branch review reports Created with: gclient setdep -r src/third_party/catapult@00455e014868 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:879526 TBR=sullivan@chromium.org Change-Id: I79e49cf3fe0661bacacd96ff7b4632629cb2ea49 Reviewed-on: https://chromium-review.googlesource.com/c/1297346Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602338}
-
Jérôme Lebel authored
Implementing unified consent rollback. Related with: crrev.com/c/1165226 Bug: 883089 Change-Id: Id54379e57d79bfd7666f48fba2174ffb18627dc5 Reviewed-on: https://chromium-review.googlesource.com/c/1297970Reviewed-by:
Thomas Tangl <tangltom@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#602337}
-
Rijubrata Bhaumik authored
The runtime flag GetUserMedia is no longer needed as navigator.getUserMedia shipped in M53 BUG=607439 Change-Id: Id58babefdb6611e27021d0b2b1af2119d785bf8a Reviewed-on: https://chromium-review.googlesource.com/c/1296594Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> Cr-Commit-Position: refs/heads/master@{#602336}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fbcd8762f2cc..cbe27839a04c Created with: gclient setdep -r src-internal@cbe27839a04c The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: Ie5ed34cf8fc22a49646752a0a524d01ab1bac13f Reviewed-on: https://chromium-review.googlesource.com/c/1297342Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602335}
-
Roger Tawa authored
Bug: 898157 Change-Id: I4c372530cc7a0b6098239a80eeae81e881888de2 Reviewed-on: https://chromium-review.googlesource.com/c/1296320Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Commit-Queue: Roger Tawa <rogerta@chromium.org> Cr-Commit-Position: refs/heads/master@{#602334}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/e068ad62628f..8e6749e0dd3f git log e068ad62628f..8e6749e0dd3f --date=short --no-merges --format='%ad %ae %s' 2018-10-24 titovartem@google.com Improve fileutils_override implementation internal API. Created with: gclient setdep -r src/third_party/webrtc@8e6749e0dd3f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: I6b31ae277952bceb1ed7eee1829f9d1304ee7a34 Reviewed-on: https://chromium-review.googlesource.com/c/1297341Reviewed-by:
-
Alex Clarke authored
There's no need for ThreadControllerWithMessagePumpImpl::DoWork to call ScheduleWork. Typically it's called in a for loop, or something equivalent. Redundant calls to ScheduleWork are not free and show up on profiles of SequenceManagerPerfTest. Bug: 897751 Change-Id: Iafebf0b574d991ea3b89dfc101aa7326cd35b3c1 Reviewed-on: https://chromium-review.googlesource.com/c/1297137Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#602332}
-
David 'Digit' Turner authored
Tiny refactor of the C source generating Python functions. No bugfix / feature at all. But the result of calling 'updated_auto_generated_sources.sh' doesn't need to be fixed by 'git cl format' anymore. - Prevent trailing whitespace on commented lines produced by CSourceForComments(). - More consistent output from CSourceForIntegerHexArray() and CSourceForConstCharArray() by using a common CSourceForArrayData() function that takes a lambda to format individual values. R=pasko@chromium.org, agrieve@chromium.org BUG=NONE Change-Id: Ifc9c5c175a3432acb5ce3d7918259c4ee294dd04 Reviewed-on: https://chromium-review.googlesource.com/c/1297423Reviewed-by:
David Turner <digit@chromium.org> Reviewed-by:
Egor Pasko <pasko@chromium.org> Commit-Queue: David Turner <digit@chromium.org> Cr-Commit-Position: refs/heads/master@{#602331}
-
Asanka Herath authored
While AsyncDNS resolver is perfectly capable of following a CNAME chain, it doesn't return the owner name for an address record. This field is important for callers of the resolver who expected the returned AddressList to contain the correct canonical name. This CL fixes the issue by plumbing the name into the AddressList. I.e. assume we have the following RRs: www.foo.example. 1000 IN CNAME host.foo.example. host.foo.example. 1000 IN A 10.10.10.10 The canonical name for www.foo.example is host.foo.example since that's the owner name for the A record. Prior to this CL the AsyncDNS resolver would return www.foo.example. After the CL it returns host.foo.example. Bug: 883969 Change-Id: I8a44f68e2dbbb1726467fde0c65c1d4e9ee304d4 Reviewed-on: https://chromium-review.googlesource.com/c/1292435Reviewed-by:
Matt Menke <mmenke@chromium.org> Commit-Queue: Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#602330}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/07d0f9dff3d2..18fe6d59e5e8 git log 07d0f9dff3d2..18fe6d59e5e8 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 stevenperron@google.com Fix dead branch elim infinite loop. (#2009) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@18fe6d59e5e8 The AutoRoll server is located here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I4b114ccc5e6c40cce1c2bcc9fe40340fc9af68ab Reviewed-on: https://chromium-review.googlesource.com/c/1297344Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 7d89b5e7. With Chromium commits locally applied on WPT: f79c6fe7 "Reimplementing getDatabaseNames() as databases() for indexeddb." 89bcea96 "[run_web_tests] Remove extra baselines after crrev.com/c/1277654" 36e64bc7 "Updating tests for Window onerror is not triggered bug fix." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/26638 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: bjonesbe@adobe.com: external/wpt/css/css-shapes NOAUTOREVERT=true TBR=kyleju No-Export: true Change-Id: Ibc02f5e4324d2346f72ebd4a8cd8be3e7a3e7eed Reviewed-on: https://chromium-review.googlesource.com/c/1297725 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#602328}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/78f4835a7135..c365e36901fe git log 78f4835a7135..c365e36901fe --date=short --no-merges --format='%ad %ae %s' 2018-10-24 fmayer@google.com profiling: Add fuzzer for unwinding. 2018-10-24 treehugger-gerrit@google.com Merge "profiling: Fix register size calculation." 2018-10-24 treehugger-gerrit@google.com Merge "perfetto: Add ASAN container size annotations to PagedMemory" Created with: gclient setdep -r src/third_party/perfetto@c365e36901fe The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I3b9ef13668609404211f3779a56f9be144b2c761 Reviewed-on: https://chromium-review.googlesource.com/c/1297340Reviewed-by:
-
Jonathan Backer authored
One of the hazards of using the ContextGL and RasterInterface from RasterContextProvider is that the texture bindings could become inconsistent between the 2. This CL makes RasterImplementationGLES2 check the bindings in GLES2Implementation, which should help reduce inconsistencies. Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I84394fe279cca0f02c6d41c9f5b5a3319772f33b Bug: 897724 Reviewed-on: https://chromium-review.googlesource.com/c/1289513Reviewed-by:
Victor Miura <vmiura@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#602326}
-
François Beaufort authored
Change-Id: Ic0ab988927938f42234895d68e65779b9fbb4c5e Reviewed-on: https://chromium-review.googlesource.com/c/1288430Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#602325}
-
Fernando Serboncini authored
adding fserb to: - imagebitmap - core Change-Id: I1598799a8e4837685880ac09dcbf4afb2f6091c3 Reviewed-on: https://chromium-review.googlesource.com/c/1297395Reviewed-by:
Stephen Chenney <schenney@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Cr-Commit-Position: refs/heads/master@{#602324}
-
Christian Biesinger authored
This does a few things: - Mark break tokens final, to hopefully avoid some virtual call overhead - Use inline capacity for the break token vectors on the fragment builder - Store the child break tokens inline in the parent break token, as a flexible array (this saves some memory because we do not have unused vector space, and also avoids a memory allocation for the vector buffer) R=ikilpatrick@chromium.org, mstensho@chromium.org Change-Id: Ie4d6a3f5ffbdff226105482b01e96e52a4d2abd0 Reviewed-on: https://chromium-review.googlesource.com/c/1296491 Commit-Queue: Christian Biesinger <cbiesinger@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#602323}
-
Sadrul Habib Chowdhury authored
The ParentLocalSurfaceIdAllocator already checks to see if allocation is suppressed when it attempts to generate a new LocalSurfaceId [1]. So checking for suppression again in content (which only aura was doing) is not necessary. Remove the associated code from content and aura. pinpoint: https://pinpoint-dot-chromeperf.appspot.com/job/16ae52cee40000 [1] https://cs.chromium.org/chromium/src/components/viz/common/surfaces/parent_local_surface_id_allocator.cc?l=52 Bug: None Change-Id: Ie566567e68548dd7f6b1e6ce77b955089e3acac6 Reviewed-on: https://chromium-review.googlesource.com/c/1296992Reviewed-by:
Fady Samuel <fsamuel@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#602322}
-
Nico Weber authored
noparent in OWNERS files are discouraged. Bug: none Change-Id: If51c8918d012be9298711b10ce1982b2a7881373 Reviewed-on: https://chromium-review.googlesource.com/c/1297263Reviewed-by:
Asanka Herath <asanka@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#602321}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/38b827049c96..7b6a59fda6b6 git log 38b827049c96..7b6a59fda6b6 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 perezju@chromium.org [soundwave] Move ListTestPaths to services.dashboard Created with: gclient setdep -r src/third_party/catapult@7b6a59fda6b6 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:890691 TBR=sullivan@chromium.org Change-Id: I5a3be93243967dd0c9429b07cfeee80e790afbb1 Reviewed-on: https://chromium-review.googlesource.com/c/1297343Reviewed-by:
-
Alex Clarke authored
The task scheduler is usable before native is loaded although only a subset the full native task prioritisation will be available. After native libraries are loaded, all remaining tasks will be migrated to native queues. Design Doc: https://docs.google.com/document/d/1ZRXRypVluu7YvnB9MC73J3Z9NTsYDDxkhUDK4O-siJg/edit?ts=5bb5f398#heading=h.8n30tv8r1tun And https://docs.google.com/document/d/1z1BDq9vzcEpkhN9LSPF5XMnZ0kLJ8mWWkNAi4OI7cos/edit#heading=h.7nki9mck5t64 Bug: 863341, 872372 Change-Id: I1c71a670662065d1d84cb23493f4cde53db9ae7c Reviewed-on: https://chromium-review.googlesource.com/c/1268021 Commit-Queue: Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
agrieve <agrieve@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Sam Maier <smaier@chromium.org> Reviewed-by:
François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#602319}
-
Marc Treib authored
TBR=wangxianzhu@chromium.org Bug: 898485 Change-Id: Ib0adea0db6371d32aaab5e8714246efaaca15ed4 Reviewed-on: https://chromium-review.googlesource.com/c/1297428Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/a6bda76c..96e1e621 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I1eb7d9692ea4eb8b5259d8ed146516f034fe04e4 Reviewed-on: https://chromium-review.googlesource.com/c/1297741Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#602317}
-
Gauthier Ambard authored
This CL creates the SettingsSwitchItem, replacing the old item for the collection view. Bug: 894791 Change-Id: Ie78e6bf3f5d358ae41a4d2bf407a2cadf7252d96 Reviewed-on: https://chromium-review.googlesource.com/c/1296597 Commit-Queue: Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#602316}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/70bd0b72f3f8..b11ab578ad63 git log 70bd0b72f3f8..b11ab578ad63 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 mtklein@google.com remove src/jumper Created with: gclient setdep -r src/third_party/skia@b11ab578ad63 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=brianosman@chromium.org Change-Id: Ia686967b0e0282980e8ddfdf31247c63ad07ee15 Reviewed-on: https://chromium-review.googlesource.com/c/1297338Reviewed-by:
-
Marc Treib authored
This reverts commit 0c3cbcc1. Reason for revert: Looks like this was a false positive; the test has failed again after the revert. Original change's description: > Revert "[CI] Combine GetBackgroundPaintLocation of PaintLayer and LayoutBoxModelObject" > > This reverts commit af460e9a. > > Reason for revert: > Seems to have broken paint/invalidation/table/cached-69296.html from webkit_layout_tests on Mac 10.11 - currently failed 7/7 times after this landed: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests > First failing build: > https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/30030 > > Original change's description: > > [CI] Combine GetBackgroundPaintLocation of PaintLayer and LayoutBoxModelObject > > > > For fixing SlimmingPaintV2 scrolling background painting and > > invalidation, we need a single place to get the accurate value > > of the background paint location. > > > > Bug: 732611 > > > > Change-Id: I0ad696395d73c9c19078e13e9a32cf9dbd0c628f > > Reviewed-on: https://chromium-review.googlesource.com/c/1297586 > > Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> > > Reviewed-by: Robert Flack <flackr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#602250} > > TBR=flackr@chromium.org,wangxianzhu@chromium.org > > Change-Id: I279520fc9deafd9891dd3a5457e42d6fa0b201aa > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 732611 > Reviewed-on: https://chromium-review.googlesource.com/c/1297362 > Reviewed-by: Marc Treib <treib@chromium.org> > Commit-Queue: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602289} TBR=flackr@chromium.org,wangxianzhu@chromium.org,treib@chromium.org Change-Id: Ic728b318732d88d37686c938f32ed3a27ee95588 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 732611 Reviewed-on: https://chromium-review.googlesource.com/c/1297142Reviewed-by:
-
Gauthier Ambard authored
When the app is launched after a cold start, the size of the collection view is 0, even if the size of the wrapper view isn't 0. This CL fixes it by setting the frame of the collectionView if it is 0. This only seems to happen when the NTP is contained in a native view. Bug: 896234 Change-Id: I4309bf35c0a3d82e2a5c6c78265f8293ff65a43c Reviewed-on: https://chromium-review.googlesource.com/c/1297360Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#602313}
-
Jordan Demeulenaere authored
Before this patch, we were instantiating a date using the java.util.Date constructor, which is deprecated and required us to decrement the year by 1900. This patch is using the recommended Calendar class instead. Bug: 806868 Change-Id: Id723c3ee8a1abc602f179c0924782c17d123c06b Reviewed-on: https://chromium-review.googlesource.com/c/1297136 Commit-Queue: Jordan Demeulenaere <jdemeulenaere@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#602312}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/624fe7f9b061..fbcd8762f2cc Created with: gclient setdep -r src-internal@fbcd8762f2cc The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=mmoss@chromium.org Change-Id: I34486037af806a9f843b0e89433f606abba55ab7 Reviewed-on: https://chromium-review.googlesource.com/c/1297339Reviewed-by:
-
Leszek Swirski authored
This reverts commit dd9df78c. Reason for revert: Makes VR tests flaky (https://crbug.com/894796) Original change's description: > Reland "[blink] Control ScriptStreamer with ScriptResource" > > This is a reland of 7bd91635 > > No changes from the original, revert reason is fixed with > https://chromium-review.googlesource.com/c/1283037 > > Original change's description: > > [blink] Control ScriptStreamer with ScriptResource > > > > Move the ScriptStreamer control logic from ClassicPendingScript to > > ScriptResource. In the future, this will allow us to start streaming > > a ScriptResource before the ClassicPendingScript is available, e.g on > > preload. > > > > The ClassicPendingScript now only sends one "finished" callback, from > > ScriptResource. This callback is either when the streaming completes, > > or when there is no streaming and the ClassicPendingScript has told > > the ScriptResource that it doesn't intend to start streaming. In the > > long run, we want all scripts to go through the streaming interface, > > and we want ScriptResource to control when streaming starts, so the > > "no more streaming" call will disappear -- however it is necessary to > > maintain the current behaviour, and be able to control it with a > > runtime flag. > > > > Bug: chromium:865098 > > Change-Id: I2c4cc16635a6538b7ff24a24463fe6f34efd8a2e > > Reviewed-on: https://chromium-review.googlesource.com/c/1181430 > > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > > Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> > > Reviewed-by: Kouhei Ueno <kouhei@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#599148} > > TBR=kouhei@chromium.org,kinuko@chromium.org > > Bug: chromium:865098 > Change-Id: I0df324ef8e284f4d3d55a1721d71be5a66a3285c > Reviewed-on: https://chromium-review.googlesource.com/c/1286450 > Commit-Queue: Leszek Swirski <leszeks@chromium.org> > Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org> > Cr-Commit-Position: refs/heads/master@{#601143} TBR=kinuko@chromium.org,rmcilroy@chromium.org,haraken@chromium.org,hiroshige@chromium.org,kouhei@chromium.org,vogelheim@chromium.org,leszeks@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: chromium:865098 Change-Id: Ibdbd7e80d0fcfacc84a73e83d165581c7f1d02d2 Reviewed-on: https://chromium-review.googlesource.com/c/1297138 Commit-Queue: Leszek Swirski <leszeks@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#602310}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/700b4a4e65c2..e068ad62628f git log 700b4a4e65c2..e068ad62628f --date=short --no-merges --format='%ad %ae %s' 2018-10-24 jonasolsson@webrtc.org Use a sufficiently large bitmask. 2018-10-24 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 5e500373..869181c2 (602066:602275) 2018-10-24 kron@webrtc.org Increase the UDP receive buffer for video 2018-10-24 peah@webrtc.org APM: Correct includes required for the data dumping functionality Created with: gclient setdep -r src/third_party/webrtc@e068ad62628f The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_chromium_archive_rel_ng;luci.chromium.try:mac_chromium_archive_rel_ng BUG=chromium:898373,chromium:None,chromium:b/115713113 TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Ic8bbee1f85f9c0855a438de32e18e7bdd45df687 Reviewed-on: https://chromium-review.googlesource.com/c/1297337Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/a1e7b1c440e1..78f4835a7135 git log a1e7b1c440e1..78f4835a7135 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 hjd@google.com Merge "protozero: Update hash unittest" 2018-10-24 hjd@google.com Merge "traced_probes: Common pids trigger process scanning" Created with: gclient setdep -r src/third_party/perfetto@78f4835a7135 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Change-Id: I7cca52e2dee3490988d5296135f8c15d6a6c92a8 Reviewed-on: https://chromium-review.googlesource.com/c/1297336Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/685b5de1133a..38b827049c96 git log 685b5de1133a..38b827049c96 --date=short --no-merges --format='%ad %ae %s' 2018-10-24 titovartem@chromium.org Add support for metric abbreviation for physics units. Created with: gclient setdep -r src/third_party/catapult@38b827049c96 The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: Ib0f2c9baeacba4fcbb2064a7d36bef5b9b8a9a15 Reviewed-on: https://chromium-review.googlesource.com/c/1297334Reviewed-by:
-
Christian Dullweber authored
Dynamically update the cookie notice on the advanced tab when sync state changes. Bug: 894848 Change-Id: I62d507d41a1bd91d37738f2d68d00427bd2bb386 Reviewed-on: https://chromium-review.googlesource.com/c/1293451Reviewed-by:
Martin Šrámek <msramek@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#602306}
-
yoshiki iguchi authored
Previously, the swipe controls are closed before the button click is processed. This CL moves the code to close them after the button click handlers. Also this CL removes the unnecessary CloseSwipeControl(s), because we had some redundant calls. Bug: 897653 Test: manual Change-Id: I2dd728c7e2069278c5f7a09ea66c79e31e28ab59 Reviewed-on: https://chromium-review.googlesource.com/c/1295756Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#602305}
-
Morten Stenshorne authored
We only need break tokens when doing block fragmentation. Long-term, even when we do have block fragmentation, we might not need to create break tokens when we're finished with a node, but that will require some more work, in any case. We currently use break tokens to figure out how much block space has been used in total by all previous fragments generated for a node, for instance. We now have to stop cheating in the paged overflow layout algorithm. If height was auto, we used to just disable block fragmentation, but since block fragmentation is what now triggers creation of break tokens, and we still have a flow thread to feed, we need to always enable block fragmentation for paged overflow (this is the correct solution long-term, anyway). We'll now fail all tests that have paged overflow and auto height, but only when LayoutNGBlockFragmentation is enabled, so no big deal. This should give both performance improvements and memory usage reduction. Some tests started to pass and some started to fail. Three new failures: Two of them are an obvious result of no longer supporting auto-height paged overflow containers. The last one (wpt/css/css-multicol/filter-with-abspos.html for the LayoutNGBlockFragmentation virtual test suite) I'm not quite sure about, but it probably has something to do with us no longer creating break tokens where we previously used to do it, and that upsets someone. Nothing to worry about for now, since it only affects NG block fragmentation, which isn't shipping in this phase. Some new tests also start to pass. Didn't do a thorough analysis, but we now only create break tokens from fragments generated by NGBlockLayoutAlgorithm, so e.g. nodes laid out by the legacy engine and nested column algorithms will no longer create break tokens. Which apparently is a good thing in some cases. Or it could be bugs canceling out other bugs. Anyway, since all the tests in question are also only for the LayoutNGBlockFragmentation virtual test suite, we don't have to worry about it yet. Finally, one unit test had to be updated, because orthogonal flow roots disable block fragmentation, and that suddenly means that there'll be no break tokens generated. Change-Id: Ief3d354e7ae0741ee239f530811ac9d9b3576ce3 Reviewed-on: https://chromium-review.googlesource.com/c/1296535Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#602304}
-
Nico Weber authored
This is a reland of 538e9529 It was reverted at https://chromium-review.googlesource.com/c/1297139 but the problem has already been fixed in https://chromium-review.googlesource.com/c/1297262. Original change's description: > Move 'Windows deterministic' from FYI to the main waterfall. > > Bug: 897980,330260 > Change-Id: I71bb304c6398484d5af5a981fdbc09314d69dd22 > Reviewed-on: https://chromium-review.googlesource.com/c/1295272 > Reviewed-by: Dirk Pranke <dpranke@chromium.org> > Commit-Queue: Nico Weber <thakis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#602198} TBR=thakis@chromium.org,dpranke@chromium.org,martiniss@chromium.org No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 897980, 330260 Change-Id: I03a1784ea48bcaa6567d4ec2dd482d218d0f4740 Reviewed-on: https://chromium-review.googlesource.com/c/1297426Reviewed-by:
-
Vivek Galatage authored
Post rename, there are certain links within README.md file which are pointing to the old directory structure. Correct these links to point to the correct ones! REVIEWER=mstensho@chromium.org R=mstensho@chromium.org Signed-off-by:
Vivek Galatage <vivekg@chromium.org> Change-Id: Ib1148cb4339823081ef96f2e24a87f2f21f57c15 Reviewed-on: https://chromium-review.googlesource.com/c/1293431Reviewed-by:
-
yoshiki iguchi authored
This method is declared in the header but not defined anywhere. Bug: none Test: build passes Change-Id: I6db055a785a549d1b1f24b5cb5b22400937ca241 Reviewed-on: https://chromium-review.googlesource.com/c/1295749Reviewed-by:
-
Mikel Astiz authored
DataTypeManager is allowed to call Stop() while a datatype is NOT_RUNNING or FAILED. In both cases, the function should be a no-op, but the completion callback should be called. Prior to this patch, the completion callback would NOT be run and hence future sync reconfigurations may never complete, leading to weird behavior including UI implications (missing updates), UMA metric biases (error-related scenarios may be underrepresented) and issues related custom passphrase encryption (which may never start or never complete, observed in tests and the reason why this bug got surfaced). Bug: 898453,870624 Change-Id: I47a9c04ab34ac48e0fdf000df2acb70bbf3e4446 Reviewed-on: https://chromium-review.googlesource.com/c/1297419Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#602300}
-
