GitLab

This CL:
* Adds some debug logging to the keyboard code (DVLOG).
* Cleans up ChromeKeyboardBoundsObserver and refactors
  ShouldWindowOverscroll to not be dependent on Ash.
* Removes Ash and KeyboardController dependencies from browser tests.

These changes are in preparation for enabling the virtual keyboard in
SingleProcessMash and should have no impact on existing tests or
behavior.

Bug: 843332
Change-Id: I8954b4640c39e670350adae776fe14b079e37f36
Reviewed-on: https://chromium-review.googlesource.com/c/1343557
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609895}

Test that attribute selectors are effective when attributes, ids and
class lists change.

https://drafts.csswg.org/selectors-4/#attribute-selectors

Test adjacent and universal sibling selectors when classes change.

https://drafts.csswg.org/selectors-4/#adjacent-sibling-combinators
https://drafts.csswg.org/selectors-4/#general-sibling-combinators

Based on
fast/css/invalidation/class-sibling-universal.html
(which Blink still needs as it uses internals to count style recalcs).

Change-Id: Ia62516e4ab596ef095d4c26a08f90f8f19e5069b
Reviewed-on: https://chromium-review.googlesource.com/c/1345371Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Eric Willigers <ericwilligers@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609894}

This patch Introduces |NGPaintFragment::RareData()| to reduce memory usage
of |NGPaintFragment|.

Change-Id: I4b74f1b0cddcbb432b84847173f93bb4c897d08d
Reviewed-on: https://chromium-review.googlesource.com/c/1343810Reviewed-by: Koji Ishii <kojii@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609893}

Revert "[TaskScheduler]: Migrate off of ScopedAllowWait in /base/profiler/stack_sampling_profiler.cc"

This reverts commit 50b50793.

Reason for revert: Thread restriction is not valid for sampling profier

Bug: 907177

Original change's description:
> [TaskScheduler]: Migrate off of ScopedAllowWait in /base/profiler/stack_sampling_profiler.cc
> 
> base::ThreadRestrictions::ScopedAllowWait is deprecated in favor of its more
> explicit counterpart.
> 
> It should have been replaced by :
>  * base::ScopedAllowBaseSyncPrimitivesForTesting in test files.
>  * base::ScopedAllowSyncPrimitives in non-test files
>  * base::ScopedAllowSyncPrimitivesOutsideBlockingScope when it's used on threads
>    that don't allow blocking
> The last one is strongly frowned upon but this CL aims to document existing
> behavior rather than address it. Owners are encouraged to follow-up by fixing
> unnecessary waits and more particularly unnecessary waits
> outside-blocking-scope.
> 
> Note: The non-for-testing versions require friend'ing in thread_restrictions.h
> but care was taken to add these friends ahead of git cl split (since it wasn't
> possible to do a line-by-line associated CL split).
> Refer to the top-level CL if necessary :
> https://chromium-review.googlesource.com/c/chromium/src/+/1288533
> 
> Please CQ if LGTY!
> 
> This CL was uploaded by git cl split.
> 
> R=​wittman@chromium.org
> 
> Bug: 766678
> Change-Id: I2c45612b77a49ca5720da95093b0cdd8845b6f03
> Reviewed-on: https://chromium-review.googlesource.com/c/1325191
> Reviewed-by: Mike Wittman <wittman@chromium.org>
> Commit-Queue: Mike Wittman <wittman@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#606478}

TBR=wittman@chromium.org,etiennep@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 766678
Change-Id: Iba9e69ad0923da8d6b6dcc2f89b9e323a30894d6
Reviewed-on: https://chromium-review.googlesource.com/c/1344577
Commit-Queue: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Reviewed-by: Mike Wittman <wittman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609892}

The only behavior change here is that |managed_by_user| is now
consistent. It is the source == USER && CanSetNarrowestContentSetting.

Some UIs (like plugins), were only looking at the setting source.

Bug: None
Change-Id: Ibf55f3f9fea3576745a0be95fa25a1b18a5c3c92
Reviewed-on: https://chromium-review.googlesource.com/c/1344192Reviewed-by: Raymes Khoury <raymes@chromium.org>
Commit-Queue: Charlie Harrison <csharrison@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609891}

Bug: 907256
Change-Id: If223956a330497b4b0318f91e4ea6c941d94b5aa
Reviewed-on: https://chromium-review.googlesource.com/c/1345377
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609890}

This patch makes |TextIteratorTest| to run on both legacy and ng layout tree
to catch ng failure earlier for helping layout ng release.

Change-Id: I10e98c10d29082fc7de4afd040cb9d93b370e854
Reviewed-on: https://chromium-review.googlesource.com/c/1343872Reviewed-by: Yoichi Osato <yoichio@chromium.org>
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609889}

We follow the behavior of linux shell:
(1) Whenever there is a new query, the iterator is reset to the new
    query.
(2) Prev of the iterator moves till the first query and stick there.
(3) Next of the iterator can move beyond last query and get an empty
    query.


Bug: b:119504796
Change-Id: Iee1247359df78b8e2189fa86c3bd1b8b6ebfe612
Reviewed-on: https://chromium-review.googlesource.com/c/1334271
Commit-Queue: Yilei Li <yileili@google.com>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609888}

New StrikeDatabase class for the StrikeDatabase v2. It shares the
same existing ProtoDatabase as legacy_strike_database.h/cc which
is used as persistent storage, as well as an in-memory cache.
Virtual functions are also introduced, which are to be implemented
per project.

Bug: 884817
Change-Id: I48c38b17274ec440afd593dc48223b97c2b2d90e
Reviewed-on: https://chromium-review.googlesource.com/c/1334832Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Jared Saul <jsaul@google.com>
Commit-Queue: Anne Lim <annelim@google.com>
Cr-Commit-Position: refs/heads/master@{#609887}

When renderer navigates, all worker agent hosts will be eventually
disposed. In order to keep protocol determenistic, this patch proactively
detaches all worker sessions on renderer navigation.

R=dgozman

Change-Id: Ief0fe3db90eade9e12baa3cbe4f6b78785c60e4f
Reviewed-on: https://chromium-review.googlesource.com/c/1345529
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609886}

Currently we can see AUTO_HIDE_SHOWN shelf can be hidden when tap inside
some of the apps, e.g, chrome browser. That is because of the window
hierarchy, stacking changes or set bounds for the child windows. Tap
inside of some the apps like "Files" or Wallpaper can't hide the
AUTO_HIDE_SHOWN shelf since we don't have the related logic for TAP
event. This cl adds the logic that tap outside of the AUTO_HIDE_SHOWN
shelf to hide it.


Bug: 882059, b/119322652
Change-Id: I8fc5b6d06a885a7b77280cbf86de4d830c04a296
Reviewed-on: https://chromium-review.googlesource.com/c/1343511
Commit-Queue: Min Chen <minch@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609885}

When images are loaded async, it was updating the existing
list of property models.  The property model for the list
was doing an equality check for the list.  Two separate list
instances with the same contents (in this case, the exact
same objects), then the equality check will pass.

To overcome this, we allow skipping the equality checks
for object properties.

BUG=898522

Change-Id: I60483d3365217b5da5d0a2cf052ac888bac1a522
Reviewed-on: https://chromium-review.googlesource.com/c/1345510Reviewed-by: Matthew Jones <mdjones@chromium.org>
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609884}

Call CloudPolicyService::RefreshPolicy instead of
CloudPolicyClient::FetchPolicy in CloudPolicyRefreshScheduler, so there
is a common path for in session policy fetches.
It allows to add additional logic for policy fetch to CloudPolicyService.
It is a part of larger change: passing credentials with child user policy
fetch.

Bug: 839025
Test: CloudPolicyRefreshSchedulerTest + manually
Change-Id: I3f5b497ef28179d3d181d45b30bf11b4a4f3fcac
Reviewed-on: https://chromium-review.googlesource.com/c/1339099
Commit-Queue: Aga Wronska <agawronska@chromium.org>
Reviewed-by: Pavol Marko <pmarko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609883}

Since increasing to 20% on 2018-11-16, there is still no saturation of
bots: https://screenshot.googleplex.com/VRSaKSXnSvs.png

Bug: 855319
Change-Id: I417a8a3ac573c8b728eaca322186eda9b0b8602b
Reviewed-on: https://chromium-review.googlesource.com/c/1341442
Commit-Queue: Simon Que <sque@chromium.org>
Reviewed-by: smut <smut@google.com>
Cr-Commit-Position: refs/heads/master@{#609882}

This CL moves the methods handling InProductHelp UI in Tab to
ToolbarButtonInProductHelpController using ActivityLifecycleDispatcher and
Tab page load observing mechanism. Now the methods are handled by
ChromeTabbedActivity only.

Bug: 889682
Change-Id: Idce805f60f32ad90418c0f6e3ded80df6d18f9b1
Reviewed-on: https://chromium-review.googlesource.com/c/1272779
Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609881}

The internal settings still exist, and we haven't really needed to
adjust these from flags for some time.

Change-Id: I74823663e497832f8accb5c0d922cf9ed017e997
Reviewed-on: https://chromium-review.googlesource.com/c/1342937Reviewed-by: Victor Miura <vmiura@chromium.org>
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609880}

No change in test behavior, no new tests.

Bug: 905934, 847729
No-try: true
Change-Id: Ic1a9b352260670b643bb60cae6cfb5483f80ea70
Reviewed-on: https://chromium-review.googlesource.com/c/1345374
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609879}

//ios/web_view clients would like to know if a suggestion is for a
password form or not.

Change-Id: I557857494d3e7889713f2fe8462a37a215111fbc
Reviewed-on: https://chromium-review.googlesource.com/c/1345423
Commit-Queue: John Wu <jzw@chromium.org>
Reviewed-by: Hiroshi Ichikawa <ichikawa@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609878}

+ Use PropertyModel for all modal dialogs
+ Remove ModalDialogView.Params
+ Fix cancel on touch outside not being able to cancel on some area
  for app modal dialogs

Bug: 899318
Change-Id: Ib3f9160d57483ade1aa54f1522aa7fe73eaa4212
Reviewed-on: https://chromium-review.googlesource.com/c/1344435
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609877}

Test Case '-[FullscreenTestCase testLongPDFScroll]' started.
  ../../ios/chrome/test/earl_grey/chrome_earl_grey_ui.mm:207: error: -[FullscreenTestCase testLongPDFScroll] : Exception: AssertionFailedException
  Exception Name: AssertionFailedException
  Exception Reason: ((base::test::ios::WaitUntilConditionOrTimeout( kWaitForToolbarAnimationTimeout, condition)) is true) failed
  Exception Details: Toolbar was visible
  Bundle ID: org.chromium.gtest.generic-unit-test
  Stack Trace: (
  	0   EarlGrey                            0x0000000124b14446 -[GREYDefaultFailureHandler handleException:details:] + 1302
  	1   ios_chrome_ui_egtests               0x000000010e983a30 +[ChromeEarlGreyUI waitForToolbarVisible:] + 1952
  	2   ios_chrome_ui_egtests               0x000000010ea3cc9c -[FullscreenTestCase testLongPDFScroll] + 780

TBR=gambard@chromium.org, kkhorimoto@chromium.org, justincohen@chromium.org

Change-Id: Id9d1a6e9c3a3a047e9241cf5a1838721899a4fb6
Reviewed-on: https://chromium-review.googlesource.com/c/1345420Reviewed-by: edchin <edchin@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609876}

This connects the cache settings from AwSettings to the network service
code path, which fixes 2 related tests.

This creates the net_helpers file to share common logic between both the
network service and legacy code paths. Right now, this only contains
WebView's logic to translate WebView cache settings into net layer
load_flags.

Bug: 904890
Bug: 893573
Bug: 893574
Test: run_webview_instrumentation_test_apk \
Test: --enable-features=NetworkService,NetworkServiceInProcess \
Test: -f=ClientOnReceivedError*Test#test*CacheMiss
Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Change-Id: Ic2d62dfedd5f0c1ddfa04469454aea7d43df9373
Reviewed-on: https://chromium-review.googlesource.com/c/1339720Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Reviewed-by: Tim Volodine <timvolodine@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609875}

Replace '<' with '<=', this was not found until recently because it
required that the result was being copied into the exact last element of
a much larger buffer.

BUG=874402
TBR=piman@chromium.org

Change-Id: Ib35552f331f0d9f1f1d19aa4914d1d14ec75ee2d
Reviewed-on: https://chromium-review.googlesource.com/c/1344214
Commit-Queue: Geoff Lang <geofflang@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Geoff Lang <geofflang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609874}

Call CoInitiliazeEx once before fuzzing so that CoCreateInstance
succeeds.

Change-Id: I6e6c1fed60da7967a2294b3d781c2d1bd468bbbb
Bug: 904877
Reviewed-on: https://chromium-review.googlesource.com/c/1342620Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Commit-Queue: Jonathan Metzman <metzman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609873}

Bug: 902957
Change-Id: Ie0ddf3d189bcedd7a7e6f40a4b5db919b8554878
Reviewed-on: https://chromium-review.googlesource.com/c/1332427Reviewed-by: Weidong Guo <weidongg@chromium.org>
Commit-Queue: Kevin Strohbehn <ginko@google.com>
Cr-Commit-Position: refs/heads/master@{#609872}

When checking for updated tiles, wait for the tiles to reload instead of
opening another NTP.

Also fix the incorrect removeEventListener in local_ntp_test_utils.

Bug: 903265
Change-Id: If48fac6eced637721c6b199492db2edee06370c4
Reviewed-on: https://chromium-review.googlesource.com/c/1334807
Commit-Queue: Kristi Park <kristipark@chromium.org>
Reviewed-by: Ramya Nagarajan <ramyan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609871}

Before this CL, after RemoteFrame is detached, it would be kept alive
by FocusController::focused_frame_.

Before this CL, LocalFrame::DetachImpl would clear
FocusController::focused_frame_ if needed.  After this CL this is done
from Frame::Detach (and so covers both LocalFrame and RemoteFrame).

Before and after this CL, FocusController::focused_frame_ stores
either a LocalFrame or RemoteFrame, but FocusController::FocusedFrame
only exposes LocalFrame.  This CL preserves this approach of handling
RemoteFrame internally within FocusController, by introducing
FocusController::FrameDetached(Frame* detached_frame) method
which can directly compare |detached_frame| with |focused_frame_|
(without going through local-vs-remote considerations and/or casts).

Bug: 906809
Change-Id: I47f3a725db87f3a887ad96c7a4739b4fc02496ed
Reviewed-on: https://chromium-review.googlesource.com/c/1344254
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609870}

Change-Id: I0e9a96d8129aee20610eb3dcd7c82a75e854f40a
Reviewed-on: https://chromium-review.googlesource.com/c/1345530Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Mohammad Refaat <mrefaat@chromium.org>
Commit-Queue: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609869}

Remove DisplayScheduler.ShouldNotDraw.* UMA metrics, since it is no
longer needed anymore. The collected metrics shows that almost ~100%
of the time, the reason for not drawing is DrawNotNeeded, and almost
never any of the others.

BUG=899956

Change-Id: Ibe775a26936de910ad33745dad0e7e1e4369d429
Reviewed-on: https://chromium-review.googlesource.com/c/1343566Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609868}

unittest_util is a js_library: it is not js_unittest, best I can tell.
No change in behavior, no new tests.

Bug: 905934
No-try: true
Change-Id: Ib508c7380ca7babf970895ce7d69545d219daaa6
Reviewed-on: https://chromium-review.googlesource.com/c/1345370
Commit-Queue: Noel Gordon <noel@chromium.org>
Reviewed-by: Stuart Langley <slangley@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609867}

No change to production logic.

This adds a newly added test to the network service test filter:
LoadDataWithBaseUrlTest#testXhrForHttpSchemeUrl. This was added during
http://crrev/c/1340999.

R=jam@chromium.org

Bug: 898589, 900528, 896059
Test: CQ
Change-Id: I6e83bc3da5389c27761cf2c80620c8990bb6a850
Cq-Include-Trybots: master.tryserver.chromium.android:android_mojo
Reviewed-on: https://chromium-review.googlesource.com/c/1345246Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Nate Fischer <ntfschr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609866}

Bug: 891460
Change-Id: Idf387481e050593788a6f2e5139f81bb0d19b641
Reviewed-on: https://chromium-review.googlesource.com/c/1341024Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: Zachary Kuznia <zork@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609865}

Bug: 905669
Change-Id: Id22625bd314b2affe80aff481dd305bbaae20c03
Reviewed-on: https://chromium-review.googlesource.com/c/1342397
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Friedrich Horschig [CET] <fhorschig@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609864}

instead of empty FileChooserResult.

Receivers of the message, Blink and Pepper, still assume the null
FileChooserResult and the empty FileChooserResult have same meaning.
However this CL makes it possible to fix crbug.com/2508.

This CL doesn't have user-visible behavior changes.

Bug: 2508
Change-Id: I14b17e68116d475d6fd49f4a965d8a6c49418b32
Reviewed-on: https://chromium-review.googlesource.com/c/1343815Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609863}

Tbr: martiniss@chromium.org,thakis@chromium.org
Bug: 868024
Change-Id: I4a21b8b2c42fa46752bea47c04b0ea501fc13981
Reviewed-on: https://chromium-review.googlesource.com/c/1345073Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609862}

This reverts commit a061c829.

Reason for revert: Suspect in crbug.com/906242

Original change's description:
> Flatten UpdateMetricsUsagePrefs - skip Metrics and Reporting service.
> 
> UpdateMetricsUsagePrefs() is a chain of calls:
> - ChromeDataUseMeasurement::UpdateDataUseToMetricsService()
>   -> UpdateMetricsUsagePrefs()
>   -> MetricsService::UpdateMetricsUsagePrefs()
>   -> ReportingService::UpdateMetricsUsagePrefs()
>   -> DataUseTracker::UpdateMetricsUsagePrefs()
> 
> It can be reduced to:
> - ChromeDataUseMeasurement::UpdateDataUseToMetricsService()
>   -> UpdateMetricsUsagePrefs()
>   -> DataUseTracker::UpdateMetricsUsagePrefs()
> 
> This removes the dependency from ChromeDataUseMeasurement to
> MetricsService and ReportingService.
> 
> Bug: 902791
> Change-Id: I38a6d22d1ff823134c79bc342ea32be0f89cda77
> Reviewed-on: https://chromium-review.googlesource.com/c/1334267
> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
> Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
> Reviewed-by: rajendrant <rajendrant@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608567}

TBR=asvitkine@chromium.org,bcwhite@chromium.org,rajendrant@chromium.org,hnakashima@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 902791
Change-Id: Iad1f49a8bae42e60ae5a9c68509d4cb38db683ef
Reviewed-on: https://chromium-review.googlesource.com/c/1344817Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: Henrique Nakashima <hnakashima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609861}

When a signature request is received from Cryptotoken,
proxy that request to WebAuthn.

Bug: 904527
Change-Id: If44e39cb1a9032306b21beed69ce3a06fe1df5be
Reviewed-on: https://chromium-review.googlesource.com/c/1331951
Commit-Queue: Casey Piper <piperc@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609860}

Details:
Flag name: kChromeCleanupExtensionsFeature
When ON, extensions are included when prompting the user for UwS cleanup.
When OFF, extensions are NOT included when prompting the user for UwS cleanup.

Bug: 904958
Change-Id: Ie483ddb64de11de015429557343f0ee5c4676ff5
Reviewed-on: https://chromium-review.googlesource.com/c/1337790
Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org>
Reviewed-by: Joe Mason <joenotcharles@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609859}

This change exposes text location data for a node, by calling refreshWithExtraData on Android side.
This is exposed to s2s on chrome side to allow spoken words to be highlighted respectively.

go/s2s-arc for design document detailing change, and summarizing design iterations

Android side change: https://googleplex-android-review.git.corp.google.com/c/platform/vendor/google_arc/+/5361958

Bug: b/72793987
Test: Manual
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I3cd01b80d12b21bd77c0133b0d78a2a44516b670
Reviewed-on: https://chromium-review.googlesource.com/c/1212442Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Yusuke Sato <yusukes@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: David Tseng <dtseng@chromium.org>
Reviewed-by: Yuki Awano <yawano@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Reviewed-by: Ryo Hashimoto <hashimoto@chromium.org>
Commit-Queue: Sara Kato <sarakato@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609858}

BLINK_PLATFORM_EXPORT can't be safely removed without causing a linker
error on Windows and this fact isn't going away.

Bug: 691714
Change-Id: Ie2399c50877e16fa80f9cb3ebe455c56493e6cce
Reviewed-on: https://chromium-review.googlesource.com/c/1343291
Commit-Queue: Charlie Andrews <charliea@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Hans Wennborg <hans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609857}

This matches old behavior. Note that fragment navigation is strict
subset of in-page navigations. in-page navigations also include
history.replaceState and history.pushState

Bug: 902722, 896022
Change-Id: I002fab4982620e7e13b84a7d96547e105c7338bb
Reviewed-on: https://chromium-review.googlesource.com/c/1345229Reviewed-by: Richard Coles <torne@chromium.org>
Reviewed-by: Shimi Zhang <ctzsm@chromium.org>
Commit-Queue: Bo <boliu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#609856}