- 11 Jul, 2020 35 commits
-
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/8e404a7e4992..0be4724e2f4f 2020-07-11 ayui@chromium.org CodeInclusion: Rename whitelist/blacklist -> allowlist/blocklist If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1097674 Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: Iffd19b13082b6ca677693c83d73aafcd14281294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293539Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787478}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dc805d4963d4..aff115d380c2 2020-07-11 John.Emau@microsoft.com [Lighthouse] Expect long-tasks audit to flake If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I7ff72408c88aae7717f157179038ae23fb112db7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293064Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium 50e3d81a. With Chromium commits locally applied on WPT: fdd6b499 "Report device pixel content box for SVG elements correctly" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: foolip@chromium.org, lpz@chromium.org, robertma@chromium.org: external/wpt/tools NOAUTOREVERT=true TBR=robertma@google.com No-Export: true Change-Id: I51c46449c98ccce1c2f17e11b2cc58cadcd5b316 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293435Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787476}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c71e15242e07..b95939265b04 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC msw@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1044139,chromium:1060280,chromium:1093065,chromium:1103661,chromium:1103821,chromium:812428 Tbr: msw@google.com Change-Id: I952f5460354dce7dc796de5ee4bbb4677ec99a13 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293053Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787475}
-
Alex Newcomer authored
Rename Multipaste -> ClipboardHistory, since Multipaste is temporary name of the project, and ClipboardHistory is more descriptive. Bug: 1104323 Change-Id: I71e375bd25b766ca77ddda3da5e35cada8e0fe41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293274 Commit-Queue: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#787474}
-
Toni Barzic authored
BUG=1102648 Change-Id: I0cb455c90f5ee79da2bec11d83a047b75e003029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292832Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#787473}
-
Richard Stotz authored
Bug: 914488 Change-Id: Iff733bbc24ff8ecf9079bbb2ac37267fa1e488c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2257913 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#787472}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/d82ef86b795d..0b43a803bfb9 2020-07-10 yunchao.he@intel.com Remove a unnecessary validation test in bind group 2020-07-10 brandon1.jones@intel.com Implement Validation For DepthStencilAttachment ReadOnly 2020-07-10 bryan.bernhart@intel.com Add GPU detection for WARP 2020-07-10 kainino@chromium.org Autoformat all tests and examples 2020-07-10 kainino@chromium.org lint_clang_format.sh: Un-skip tests and examples 2020-07-10 kainino@chromium.org Autoformat everything except tests/examples If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: Ie0d6a6afda4a46d56da0479217b0f55ce71f5fd7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293462Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1594403996-947c6fab63ea1736d4ccc9d20d3d089df2178fc5.profdata to chrome-mac-master-1594425209-cc260c29b3e13890aac0357f0e9b674b4cffe951.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: sebmarchand@google.com,jeffyoon@google.com,liaoyuke@google.com Change-Id: Ib566cb0540a6bc979f58df7a90ae3323a764b294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293466Reviewed-by:
-
John Abd-El-Malek authored
Increase sharding of storage_service content_browsertest on CrOS debug to match content_browsertests. Bug: 1103313 Change-Id: I02f8f41337d4af3510eaa42124eb3a8a68a4af63 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293277 Auto-Submit: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Will Harris authored
This is needed to support CFG on Windows. BUG=584575 Change-Id: I0ddcf0c1f7d9faf02f5462541a3fb9f08e6c7bbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290542Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Patrick Monette <pmonette@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Commit-Queue: Will Harris <wfh@chromium.org> Cr-Commit-Position: refs/heads/master@{#787468}
-
Gavin Williams authored
This change will make the error printer statuses stand out more for users. Bug: 1059607 Change-Id: I3f519b07473e1fd34c4de18700024bd3b5796042 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289209Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#787467}
-
Gang Wu authored
This CL to make sure that we request Urlbar focus after onWindowFocusChanged, then UrlBar can receive clipboard suggestions. Bug: 1104055 Change-Id: I3d0d7cccead1c348105dab50337e4575a46865bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291321 Commit-Queue: Gang Wu <gangwu@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Cr-Commit-Position: refs/heads/master@{#787466}
-
Kenneth Russell authored
This code predates the command buffer's support for validating all of ES 3.0. It causes a synchronous round-trip call which is very slow. Move the check to the validating command decoder. ANGLE, via passthrough, already handles this correctly. Bug: 1103473 Change-Id: I253ddac05abb3145adfc2170da4515458e79dcbb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289057 Commit-Queue: Kenneth Russell <kbr@chromium.org> Reviewed-by:
Shrek Shao <shrekshao@google.com> Reviewed-by:
James Darpinian <jdarpinian@chromium.org> Cr-Commit-Position: refs/heads/master@{#787465}
-
Justin Donnelly authored
Three changes: - The answers in suggest histograms are of long-term interest, so extend them to 2021-06-30 to match https://crrev.com/c/2276218. - Obsolete Omnibox.ZeroSuggest.MostVisitedResultsCounterfactual. - Assign primary ownership of Omnibox.ZeroSuggestRequests to ender@ to match the similar histograms updated in https://crrev.com/c/2225520. Bug: 1089196, 1089166 Change-Id: Iff8eb82b2f5cc427e28c885ed720d59b94e6ecbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288207Reviewed-by:
Ender <ender@google.com> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#787464}
-
Chris Lu authored
The TextBadgeView need to be explicitly accessible. In addition, it is better to use an identifier instead of label to validate. Bug: 1100811 Change-Id: I5e4a58d177d62a0f69fb85d84d16bad60f444cc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283900 Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
edchin <edchin@chromium.org> Cr-Commit-Position: refs/heads/master@{#787463}
-
Kai Ninomiya authored
Needed for https://dawn-review.googlesource.com/c/dawn/+/24622 and https://dawn-review.googlesource.com/c/dawn/+/24620 Bug: none, dawn:22 Change-Id: I22e6dd8d695060f01e29d9c9c51e03233c0a6ef7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292833Reviewed-by:
Austin Eng <enga@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#787462}
-
Chris Harrelson authored
This patch changes UsesCompositedScrolling to NeedsCompositedScrolling for determining whether an object will composited-scroll in PaintPropertyTreBuilder. This removes a dependency on the compositing step. Bug: 1100711 Change-Id: Ia9f4a6e5e8cbb39608dc5e1c73af377be983d9cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290071Reviewed-by:
Philip Rogers <pdr@chromium.org> Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#787461}
-
Gavin Williams authored
Add a ".focus()" line to ensure the dropdown retains focus after a printer is selected and after a keyboard press changes the highlighted destination. Screenshot: http://screen/pH2aHL8cW1B Bug: 1059607 Change-Id: Id28b1c3e5fe40af94e4d4f35a5fd1b2b90c95da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288505 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
-
Pete Williamson authored
Bug: 1104370 Change-Id: Idde77daab418a163a6360289dc579ee125bebe6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293002Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#787459}
-
Gavin Williams authored
When dropdown is in a disabled state, remove the tabindex from the dropdown to prevent it from being focusable. Bug: 1059607 Change-Id: I5a91884996ca0404e6baa9f6d44ecd8565540533 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291236 Commit-Queue: Gavin Williams <gavinwill@chromium.org> Reviewed-by:
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6e90ebc7..7e476030 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I45ca48a58759bc04654bf1817d751a22bb730555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292693Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#787457}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/66ccc2b65ae8..dc805d4963d4 2020-07-10 brgoddar@microsoft.com Elements: Fix bug where first search result does not highlight If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1103316 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ib7792e95d16c102b54ae19dcfe9f0c73c99515d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293060Reviewed-by:
-
Ilia Samsonov authored
Baselines were generated in the following build: https://ci.chromium.org/p/chromium/builders/try/linux-blink-optional-highdpi-rel/5 Bug: 1068400 Change-Id: Icf66a0345e92f08423cc603c561a60cd815c7ffe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293314Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Commit-Queue: Ilia Samsonov <isamsonov@google.com> Cr-Commit-Position: refs/heads/master@{#787455}
-
Collin Baker authored
Bug: 1102655 Change-Id: I1a250eb518a00245fcf648c96895a8beceb3f22d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2290696 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Dana Fried <dfried@chromium.org> Cr-Commit-Position: refs/heads/master@{#787454}
-
Adam Langley authored
I tried this in c6728c24 but forgot that credential information is optional in assertion responses where the allow-list has exactly one entry. It was reverted in 3eae9ec8. Now that we have machinery to fill in the credential ID, use it to solve this problem. Change-Id: I54ec3e740465d08f8a16d83695506338c3310d25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293416 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#787453}
-
Mark Mentovai authored
Apple CPUs since A9 use a 16kB physical page size, which is a change for macOS on arm64 relative to the 4kB pages used on x86_64. PartitionAlloc operates on pages directly, and must be aware of the larger pages on the new platform. If this same change were effective for macOS on x86_64, it would allow x86_64 Chrome to run under binary translation (Rosetta) on arm64. Doing so has potential observable impacts, including memory footprint and performance. Run-time page size detection could be used to overcome this, and would also provide insulation against future page size changes, but that’s a larger and more invasive change. It’s likely that we will adopt one of these strategies soon, but for now, this arm64-only change is sufficient to run Chrome on arm64 Macs. Bug: 1098899 Change-Id: I50b48728350b87a319433188306daad747741e54 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2292831 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Mark Mentovai <mark@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#787452}
-
Nico Weber authored
Ran `./tools/clang/scripts/upload_revision.py 04b9a46c842f793a2baedcad64de35fcbd3e93b7`. TBR=hans Bug: 1101237 Change-Id: I39243368a5c578fb392814e0fbe654faf0615e6a Cq-Include-Trybots: chromium/try:mac_chromium_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_cfi_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_asan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_msan_rel_ng Cq-Include-Trybots: chromium/try:linux_chromium_chromeos_msan_rel_ng Cq-Include-Trybots: chromium/try:linux-chromeos-dbg,win-asan Cq-Include-Trybots: chromium/try:chromeos-amd64-generic-cfi-thin-lto-rel Cq-Include-Trybots: chromium/try:linux_chromium_compile_dbg_32_ng Cq-Include-Trybots: chromium/try:win7-rel,win-angle-deqp-rel-32 Cq-Include-Trybots: chromium/try:linux_angle_deqp_rel_ng Cq-Include-Trybots: chromium/try:win-angle-deqp-rel-64 Cq-Include-Trybots: chromium/try:dawn-win10-x86-deps-rel Cq-Include-Trybots: chrome/try:iphone-device,ipad-device Cq-Include-Trybots: chrome/try:linux-chromeos-chrome Cq-Include-Trybots: chrome/try:win-chrome,win64-chrome,mac-chrome Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2291352Reviewed-by:
-
Dmitry Torokhov authored
Even though GenerateGUID() is supposed to return cryptographically strong data, it is better to use a dedicated implementation for the token that is not supposed to be guessed by a 3rd party. Note that we still use strings to exchange tokens, as we are using DBus and not mojo (which would ensure type safety and would not expose implementation details such as the fact that token is 2 64-bit numbers). Bug: 1071872 Change-Id: I3014864201ee0af5e1d402dcf7ecb6c2e360f513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2289213Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Daniel Ng <danielng@google.com> Commit-Queue: Dmitry Torokhov <dtor@chromium.org> Cr-Commit-Position: refs/heads/master@{#787450}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Ide9f8fb36d50dd224aaed1849d24197f2ecbdca4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293059Reviewed-by:
-
Chris Lu authored
This change fixes OverlayPresentationContextImplTest.ContainedOverlayUI since OverlayUIDidFinishDismissal will trigger another stop call synchronously. Since self.started isn't NO yet, then another dismiss is attempted, even though the presentation state has been removed. Bug: 1100811 Change-Id: Idb3443fa1b0b4e49132de801fe5a6aa6b81c361b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2285919Reviewed-by:
Mike Dougherty <michaeldo@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#787448}
-
ssid authored
Change-Id: I305074648b3265c34ec5a52e625e772991363398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293228 Commit-Queue: ssid <ssid@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Auto-Submit: ssid <ssid@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#787447}
-
Adam Langley authored
By inspection, FilterAndBatchCredentialDescriptors always returns a non-empty list of batches, but GetAssertion assumes that the case where all credentials are filtered results in an empty list. When all credentials were filtered, Chromium started sending empty allow-list requests. There was a test for this! But it didn't work: it tried to detect the empty allow-list case by checking that account selection wasn't triggered, but the request handler doesn't accept a response with |num_credentials| > 1 if it wasn't supposed to be an empty allow-list request. Thus the response is rejected which turns into NOT_ALLOWED_ERROR, as the test was expecting. Instead, have the virtual authenticator record the allow-list sizes and check that no empty allow-list requests were sent. Change-Id: I7fa1f8325b8ad06934183436916043926043fa99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293415 Commit-Queue: Adam Langley <agl@chromium.org> Reviewed-by:
-
Brandon Wylie authored
When reparenting from theme changes, tabs wil be reparented during the restore phase. In this case, there's no tabs that are waiting and init should continue as normal. Bug: 1101955 Change-Id: I3f62cf7c3dda55384397b0389ab13c8edc30442b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293015Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I929306a7186d112a28365080dc7a90bb4c76c57d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293322Reviewed-by:
-
- 10 Jul, 2020 5 commits
-
-
Alexander Cooper authored
XRInputSourceArray_Iterable was failing on chromium, since as a ".html" and not a ".https.html" file, it was not loaded in a secure context, and thus WebXr wasn't exposed (and the test API doesn't attempt to polyfill itself in if navigator.xr doesn't exist). However, on closer inspection, this is a redundant test case that is already covered by the idlharness. Fixed: 1104347 Change-Id: Ica4d52578571627e18b9a007e5bb461cf3e34ceb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293227 Commit-Queue: Alexander Cooper <alcooper@chromium.org> Commit-Queue: Brandon Jones <bajones@chromium.org> Auto-Submit: Alexander Cooper <alcooper@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#787443}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/2b54e8352a1d..4a1f5fc94295 2020-07-10 herb@google.com move makeAtlasTextOp to SubRun 2020-07-10 mtklein@google.com remove intermediate lambdas in skvm interpreter 2020-07-10 johnstiles@google.com Convert GLHighContrastFilterEffect to an .fp file. 2020-07-10 herb@google.com move GrAtlasTextOp creation to GrRenderTargetContext 2020-07-10 brianosman@google.com Make GrFP::registerChild just return -1 for null children If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC mtklein@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: mtklein@google.com Change-Id: I4149fb92fd5b83f251fe037c9c8e1a3baf3be087 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293337Reviewed-by:
-
Adam Langley authored
Authenticators may omit specifying the chosen credential when responding to an assertion if only a single credential was specified in the allow list of the request. However, this logic was being implemented in the request handler, which considers the allow list prior to authenticator-specific filtering. If filtering reduced the allow list from several entries to one, the authenticator could omit the credential in the response, but then the request handler wouldn't know which it picked and would fail the request. Thus this logic must live in the task, which is the level that also handles filtering. By making the virtual authenticator omit the credential in the response whenever possible, plenty of existing tests sudden start failing without this fix. BUG=1102756 Change-Id: Icd1a7dc3ee3d75d118b509d4d0d1807654554f0d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2288189 Commit-Queue: Adam Langley <agl@chromium.org> Auto-Submit: Adam Langley <agl@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Ieb6e926232b8da3e4f5ef779699d6d3a248fa93c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293225Reviewed-by:
-
Jamie Walch authored
Among other things, https://chromiumcodereview.appspot.com/13983010 removed ScreenResolution::IsValid(), but missed a required negation when replacing one caller with IsEmpty(). Since that CL, we have added support for using an empty ScreenResolution to restore the previous desktop size (although it is currently disabled client-side), so the check is no longer required and this CL removes it. It also fixes an out-of-date comment referring to the same API. Change-Id: I12cc223c2b8f9579e50dbcd3dab0c0e0476416eb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2293420 Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Joe Downing <joedow@chromium.org> Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Joe Downing <joedow@chromium.org> Cr-Commit-Position: refs/heads/master@{#787439}
-
