- 11 Aug, 2020 40 commits
-
-
Nektarios Paisios authored
This is the first step in the process of merging BrowserAccessibilityPosition and AXNodePosition into one class. We need to adopt the same definition of an embedded object in both places. This is the definition used by IA2 and ATK hypertext, which makes all non-textual nodes that are exposed to the platform APIs into embedded objects. Additionally, we include the definition used by UIA, which makes all empty leaf objects (objects with ignored descendants) as embedded objects. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I19bbc26f40d37a07b7dd6436fb0025505a0cfd89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346653Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#796893}
-
Dave Tapuska authored
This test was disabled due to flakiness. Flakiness was fixed in https://chromium-review.googlesource.com/c/chromium/src/+/2347392 BUG=1110429,1112931 Change-Id: Ia3eaa8c85d13761bc3934768e85a0faab6bc039c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347403Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#796892}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/01e0ccdc9b8b..21e5b4554a5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I5968ddcb8ea65eee86e30f71501716fbfb17f7f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347227Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796891}
-
Joey Arhar authored
Bug: 1113521 Change-Id: I2eb4e2dfbe5de5d6b46ec1d22815cf014e90ec15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347979 Commit-Queue: Joey Arhar <jarhar@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#796890}
-
Scott Violet authored
This crash happens under the following circumstances: 1. on android. 2. request manifest from WebContents. 3. ~WebContentsImpl As part of WebContentsImpl deletion any outstanding requests for manifests are run. The callback scheduled at 2 may trigger running code in ContentFaviconDriver that attempts to use web_contents(). Problem is at this time WebContentsImpl has already set the web_contents() of ContentFaviconDriver to null, and we crash. Fix is to route the callback to ContentFaviconDriver and have ContentFaviconDriver do nothing if web_contents() is null. BUG=1114237 TEST=ContentFaviconDriverTest.WebContentsDeletedWithInProgressManifestRequest Change-Id: I0e88884c1ea7a8ffacb443b65ba09786cf4f54c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343718Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796889}
-
Yuly Novikov authored
Also flaky in Release and on Win10. TBR=kbr Bug: 772037 Change-Id: I6108376212d131c9972a47f3232614674b94beac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348696Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#796888}
-
George Steel authored
Add case for setting localTime to null after having it set to a number. Port to WPT infrastructure (testharness + reftest). Bug: 870711 Change-Id: Iae22083f63004153666f4e119cf350f86c65eb55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348008 Commit-Queue: George Steel <gtsteel@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#796887}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/ad052807cdc7..0b969adbdff1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC ellyjones@google.com,apotapchuk@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: ellyjones@google.com,apotapchuk@google.com Change-Id: I109a39a9ec28e79bb7e1c9fb34ec698d68eb1727 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349318Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#796886}
-
Rushan Suleymanov authored
This CL adds a unit test for the case from CL https://crrev.com/c/2027407. There is also a fix of use-after-free bug in client tag based remote update handler. Bug: 1046309 Change-Id: I00302c5772aa960b1af5064d768bcd5e0f8dd45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346431 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Cr-Commit-Position: refs/heads/master@{#796885}
-
Meilin Wang authored
Please see demo screenshot in the linked bug. Bug: b/161481969 Test: covered by unittests. Change-Id: I8e3d867220ff7e23e79ac807ce6929fd04a246ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342784 Commit-Queue: Meilin Wang <meilinw@chromium.org> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#796884}
-
Ewann authored
Adding: - Open in New Tab - Open in New Incognito Tab - Open in New Window (if Multi-Window is supported and iPad) - Open all tabs for section header - Hide for now Bug: 1093302 Change-Id: I1c1e79e34b73ab7b03082bc7ff40764dc7f33b28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2333827 Commit-Queue: Ewann Pellé <ewannpv@chromium.org> Reviewed-by:
Mark Cogan <marq@chromium.org> Reviewed-by:
Sebastien Lalancette <seblalancette@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#796883}
-
Marc Treib authored
This was meant to be done in crrev.com/c/2220048, but a part of it was overlooked there (that CL added only a DEFINE_VARIATION_PARAM(..) but failed to also add the corresponding VARIATION_ENTRY(..) in the list). Bug: 1044038 Change-Id: I54d11b14073f4908c634ba8539b870a0f5c6ec8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346433 Auto-Submit: Marc Treib <treib@chromium.org> Commit-Queue: Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#796882}
-
Joshua Pawlicki authored
There needs to be some thought devoted to how we are sharing prefs with update_client (and how and whether we should share code as well). This change is very limited in scope, specifically to fix issue 1092503 and unblock other changes, allowing the test app to function correctly. Bug: 1092503 Change-Id: I0500d3ae210a2a60e2991826432417a49ce88166 Fixed: 1092503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348537 Commit-Queue: Joshua Pawlicki <waffles@chromium.org> Commit-Queue: Sorin Jianu <sorin@chromium.org> Auto-Submit: Joshua Pawlicki <waffles@chromium.org> Reviewed-by:
Sorin Jianu <sorin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796881}
-
Kent Tamura authored
Bug: 875235 Change-Id: Id85c0c5ad52bef9309e201416f9d47c30468efff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348231 Commit-Queue: Kent Tamura <tkent@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#796880}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008110800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/qm8oRNi8gU7naD1qdw0-8dq2k2YWuPswsrYsoz6u_n8C If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/159394333,b/162906760 Tbr: help-app@grotations.appspotmail.com Change-Id: I1beff4b08702c8c390417f5062aef2aed2802628 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349320Reviewed-by:
-
Muyao Xu authored
A new |error_msg| data member is added to LaunchSessionResponse struct to provide more descriptive error messages. Bug: 687380, b/154273698 Change-Id: If334dbfb0499cddcf3cfe36b3423ebf7005efb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335879 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
mark a. foltz <mfoltz@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#796878}
-
Nick Diego Yamane authored
Mechanical change renaming platform window's handlers subdir so making it more consistent with the other sub-directories. R=sky@chromium.org Bug: None Change-Id: I5a355b4ed70a30ae803ce96c6ffee60cbfdd0bbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347401 Auto-Submit: Nick Yamane <nickdiego@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#796877}
-
Hirokazu Honda authored
media/gpu/video_encode_accelerator_tests: Settle target bitrate by the video resolution and framerate Originally video_encode_accelerator_tests tests a fixed bitrate with any video. This enables to settle a good bitrate for testing by determining it by the resolution and frame rate of a test video. Bug: 1045825 Test: video_encode_accelerator_tests on atlas Change-Id: I129158cf0e877a0d06ce304f201c01969abd3be0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2325671 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
David Staessens <dstaessens@chromium.org> Cr-Commit-Position: refs/heads/master@{#796876}
-
Jeffrey Young authored
BUG=none TEST=browser_tests --gtest_filter="OSSettingsAmbientModePageV3Test.All" Change-Id: Ia097fb823b0e5f828444befe64b50b8e677c71cb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347344Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: Jeffrey Young <cowmoo@chromium.org> Cr-Commit-Position: refs/heads/master@{#796875}
-
Antonio Gomes authored
if (bleh) { (...) } else if (!bleh) { (...) } BUG=None R=sky@chromium.org Change-Id: I7e303732499e1cfc77a23e08186a921612cbff27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346608 Auto-Submit: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by: -
Dale Curtis authored
Creates a vpcc box based on the configuration info. Reland now uses a forward declaration for the kCMVideoCodecType_VP9 which is in the 11.0/10.16 SDK. R=avi, sandersd Bug: 1103432, 1105187 Test: Updated unittests. Change-Id: I15158ec3329054981cab4eefc3316283952f2f48 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348330 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#796873}
-
Seokho Song authored
Bug: 1010217 Change-Id: I2ae48bd21aa792b32d2ddf736a567483295219a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2342237Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Cr-Commit-Position: refs/heads/master@{#796872}
-
Victor Hugo Vianna Silva authored
This CL adds a field trial parameter to the passwords account storage feature. It is used to limit the number of times Chrome offers a user that hasn't gone through the opt-in flow yet to move a password to their account. The methods from crrev.com/c/2340966 are used to query the number of times the user has already refused the move. No behavior is actually changed however, since the refusal counter is not yet incremented (future CLs). TBR=vasilii@chromium.org Bug: 1082152 Change-Id: I248f0964e1b406026016288d5e41fb64b2a6e10d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345309 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#796871}
-
Jesse Schettler authored
The scanning UI is still under development. Extend the flag's expiration to M90. Bug: 1059779 Change-Id: I19bb927b02dbe916e74425a2f1b2b0b93139d1ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346829 Commit-Queue: Jesse Schettler <jschettler@chromium.org> Reviewed-by:
Bailey Berro <baileyberro@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Auto-Submit: Jesse Schettler <jschettler@chromium.org> Cr-Commit-Position: refs/heads/master@{#796870}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/21e5b4554a5f..0376edf14e58 2020-08-11 lalitm@google.com Merge "trace_processor: Make GetColumnsForTable report errors" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4548f77e6b03dc19db2bc9119ea731b50aa5ac46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349317Reviewed-by:
-
HyunJun Shin authored
Bug: 1010217 Change-Id: Iccba7f237dee5ea57a0ea77eedd1ac56a58f2fa1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344106 Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#796868}
-
Dirk Pranke authored
This reverts commit 06578271. Reason for revert: Getting reports of the version check not working from various users; see crbug.com/1115140 Original change's description: > Rewrote PRESUBMIT.py > > Rewrote PRESUBMIT.py (and associated tests) to new format. Runs > REQUIRE_PRESUBMIT_VERSION at the top so that depot_tools can be > made aware of the change and can time/rdb wrap each of the Check... > functions separately, while also ensuring that they have the new > version of depot_tools. > > Requires the newer version of presubmit_support.py in depot_tools, > which is described in crrev.com/c/2341828 > > Change-Id: I102e8c75834aff1eccdf4a27ffe6f0953b76ee57 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2341362 > Reviewed-by: Dirk Pranke <dpranke@google.com> > Commit-Queue: Saagar Sanghavi <saagarsanghavi@google.com> > Cr-Commit-Position: refs/heads/master@{#796595} TBR=dpranke@google.com,estaab@chromium.org,saagarsanghavi@google.com Change-Id: Ib3295d141e997fc6792c381fea10e8892204bcdb No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349428Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Dirk Pranke <dpranke@google.com> Cr-Commit-Position: refs/heads/master@{#796867}
-
David Roger authored
The enterprise icon is changed into a badge on top of the gaia avatar. The various texts are also updated to match the mocks in various cases, depending whether the accounts are managed or not. Screenshots: Normal/Normal: https://drive.google.com/file/d/1mE22Ro44l3IxstpFDNEz3oGMqxxfeYa4/view?usp=sharing https://drive.google.com/file/d/1bVrkJ_vC-NTjE5hXh69Gf4FSEqemQkdp/view?usp=sharing Managed/Normal: https://drive.google.com/file/d/1VipZs_BjEtzWtBc_P-pjkR3HdYZB6C-H/view?usp=sharing https://drive.google.com/file/d/1J9Io65diEFqwZq9kZbWnYixKLayKHJZn/view?usp=sharing Normal/Managed: https://drive.google.com/file/d/14R8iadPPOy5zYGdS7GsaCU8hlLQDL3CE/view?usp=sharing Bug: 1076880 Change-Id: Ib66872356ed06d840a956e7d7b18686d29564a12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2339337 Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#796866}
-
spdonghao authored
Bug: 1112874 Change-Id: Ibba008295747a9ac834309dad09771b7d0ff37c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2344946Reviewed-by:
Xi Han <hanxi@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#796865}
-
adamta authored
Adds enough height to the CS collection view to allow for scroll position to be maintained in Discover feed. Added height is calculated from the cached NTP offset. Bug: 1085419, 1108403 Change-Id: Ia9c2ed7dd7d5d3d8aa3413266404f956ae524cbf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2317811 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#796864}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a1d5ae72b241..5245bcfaf6a9 2020-08-11 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-11 erikchen@chromium.org Two small updates to deploy_chrome.py for --lacros. 2020-08-11 gbiv@google.com toolchain_util: fix bug 2020-08-10 erikchen@chromium.org Update README to reflect manual testing instructions. 2020-08-10 chrome-bot@chromium.org Update config settings by config-updater. 2020-08-10 denik@google.com chromite: Pass config_lib useflags to cros_setup_toolchains 2020-08-10 zhuohao@chromium.org Revert "kukui-tablet: Adds new builder and signer type" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:chromeos-betty-pi-arc-chrome;luci.chromium.try:chromeos-kevin-rel Tbr: chrome-os-gardeners@google.com Change-Id: Ia7724f34613933ad964649fde76af0af0478aac0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347179Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/de914d018068..9385eb35f507 2020-08-11 lehoangq@gmail.com Metal: Generate default shaders to separate files. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: ynovikov@google.com Change-Id: If6c9d4328eda0e315d8e84f885fe16188413ef83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347176Reviewed-by:
-
Jérôme Lebel authored
The goal of those 5 patches is to remove const on the following methods: * IsValidIdentity() * GetIdentityWithEmail() * GetIdentityWithGaiaID() * GetCanonicalizeEmailsForAllIdentities() * HasIdentities() * GetAllIdentities() * GetAllIdentitiesSortedForDisplay() This is required for crrev.com/i/3208484, to not start async identity fetch in ChromeIdentityServiceImpl instance when the cache is not populated. * crrev.com/c/2345305 Add temporary methods * crrev.com/i/3201649 Switch to the temporary methods => crrev.com/c/2345146 Remove const in the methods * crrev.com/i/3201650 Switch back the original methods * crrev.com/c/2344467 Remove temporary methods Bug: 897470 Change-Id: Id1f2c88442b835472e54a5bc74516780460e3b89 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345146 Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#796861}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/64a60835a190..f867ba8b5d48 2020-08-11 nisse@webrtc.org Delete deprecated variant of RtpVideoStreamReceiver::AddReceiveCodec If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I7c572c1e9a7646c67a701af00ee7e972f15b6707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347178Reviewed-by:
-
Morten Stenshorne authored
These fragmentainers are created naturally by the block layout algorithm. CL:1766070 added code to ignore them (just drop them on the floor), but it seems that it's less cumbersome to just keep them. We kept them anyway, if there were unhandled OOFs inside (and manually propagating such OOFs sounds messy). In addition, we end up with empty fragmentainers if the first child of a multicol container is a spanner. Even if we discarded the actual fragmentainer, we'd still keep the break token generated (to resume at column content after the spanner(s)), and this in turn would cause trouble when calucalting the fragmentainer index in NGBlockNode::AddColumnResult() (we'd essentially never add a fragment at index 0, but jump straight to 1). We may need to revisit this again in the future, though. Overflow calculation comes to mind. We'll now create a 1px tall fragmentainer even inside 0px tall multicol containers. But we can either just prevent fragmentainers from contributing to overflow (this is not what other browsers do, though), or actually make such fragmentainers 0px tall (they become 1px because the spec says that fragmentainers may not be shorter than that, but we might get away with it anyway). Add a DCHECK in LayoutBox::AddLayoutResult() to assert that we don't mess up the index (like we used to, which in turn made us keep fragments associated with deleted layout objects). Quite a few unit tests had to be updated because of this. I changed some of them slightly, to give the new empty fragmentainers a nicer width that they'd otherwise get. Bug: 1105758 Change-Id: I44e1b93dea4cd5e0c5f7944798e2336530a6d1a4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346389 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#796859}
-
Yue Ru Sun authored
UKM enums are used by `UKM.Entries.Recorded.ByEntryHash` and `UKM.Entries.Dropped.ByEntryHash` when displaying a breakdown of event counts by name. Some events were incorrectly displayed as "obsolete" in the histogram table here https://screenshot.googleplex.com/CRmtGDOcAwQ.png compared to the the event definition https://source.chromium.org/chromium/chromium/src/+/master:tools/metrics/ukm/ukm.xml;l=4254;drc=ec5f934779d00e3bf817be19297f72ef5bd98e9c This patch fixes the logic to consider an event as obsolete iff - the event itself is marked as obsolete, or - all the metrics under this event are marked as obsolete. Tested locally with chromium/src/tools/metrics/histograms$ ./merge_xml.py --output output.xml ../ukm/ukm.xml enums.xml Bug: b/163387426 Change-Id: I06ae60edb4e025cf693ad37063a45dc3bf6edd31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347386 Commit-Queue: Yue Ru Sun <yrsun@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#796858}
-
Richard Knoll authored
Attachment ids are transferred via wire_format.proto and need to be serialized/deserialized to int64. Also removes virtual methods from the base Attachment class and adds |text_title| to TextAttachment. Bug: 1085067 Change-Id: I39f0820f6682718c88e6b92947ad5a156c0ab294 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346807Reviewed-by:
Himanshu Jaju <himanshujaju@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#796857}
-
Shu-yu Guo authored
Bug: v8:7883 Change-Id: Ic91546ea953d66d3742e599ad0a8da778b6363b6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2346942Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Shu-yu Guo <syg@chromium.org> Cr-Commit-Position: refs/heads/master@{#796856}
-
Elly Fong-Jones authored
Bug: 1115106 Change-Id: I82a797d19e6c70e7983221128f769ffb5596bc71 Tbr: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348695Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#796855}
-
Friedrich Horschig authored
This CL ensures that the referrer is considered in the decision to run the password check. When coming from safety check: use last status, don't run check When coming from anywhere else: run the check when possible. The initial status is not relevant for the decision to run. If it's RUNNING, the call is a noop. If it's IDLE or cancelled, it makes sense to run a new check. If it's any error state, rerunning might show the error was fixed since the last attempt. Reaching a new failure won't take long. Bug: 1109691, 1092444 Change-Id: I573a5f9f0a8861e598541fa38faa2d8bd42adba3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2348773Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#796854}
-
