- 29 Oct, 2019 40 commits
-
-
Julie Jeongeun Kim authored
This CL converts ProxyResolvingSocketFactoryRequest to new Mojo types using PendingReceiver, Receiver, and UniqueReceiverSet. Bug: 955171 Change-Id: Ief7194cf589fae12f331ab30f0faeff04efeaefa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1863409Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#710275}
-
sandromaggi authored
Previously, when autofill actively failed - as opposed to just being unable to fill the fields -, the action was completely terminated. New the required fields fallback will be triggered. Bug: b/143266929 Change-Id: I40ce9ae9d73f1d592d74a6aae3cdac9c25542434 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879893 Commit-Queue: Sandro Maggi <sandromaggi@google.com> Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#710274}
-
Sylvain Defresne authored
As documented in //components/README.md, code in components must not depend on higher-level layers of the Chromium codebase, including //ios/chrome. Move ukm_url_recorder.* and tests from ios/chrome/browser/metrics to components/ukm/ios (to parallel the version in content that is found in components/ukm/content). Fix UkmUrlRecorderTest to use WebTestWithWebState instead of the unavailable (due to layering violation) ChromeWebTest. Bug: 754895 Change-Id: I829486037063f16fe5fca5b7617017c0530a1859 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878649 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#710273}
-
chrome://weblayerKamila Hasanbega authored
This reverts commit 90c5851b. Reason for revert: This introduces tests that constantly fail, https://ci.chromium.org/p/chromium/builders/ci/win-asan/8177. Original change's description: > [WebLayer] Add tests for chrome://weblayer page > > This page recently broke (fix in http://crrev.com/c/1880171), so tests > seem like a good idea. > > This also adds a test helper for executing javascript, and makes the > NavigateAndWaitForCompletion function work more similarly to the one in > the instrumentation tests by waiting until the page is finished loading. > > Bug: 1017924 > Change-Id: I8ca048f9a9a92808abf6cfa5d0e091550cc3d9a6 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880173 > Commit-Queue: Clark DuVall <cduvall@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709552} TBR=sky@chromium.org,cduvall@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1017924 Change-Id: Ifc5689dc8bb0ec9fdc793bdbb79f44c5388b2266 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886413Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Commit-Queue: Kamila Hasanbega <hkamila@chromium.org> Cr-Commit-Position: refs/heads/master@{#710272}
-
Mikel Astiz authored
GUID-related tests have been flaky since introduction and recent investigations suggest that the underlying issue is FakeServer's lack of sending sync invalidations for certain APIs like InjectEntity(). This patch modifies FakeServer to actually issue invalidations and removes some now redundant (and undesired) calls to TriggerSyncForModelTypes(). Assumes this fixes the flakiness, all tests are reenabled. Bug: 1014086 Change-Id: Ie0f597c024646586b9ec6c3dfbb761a86dadaad2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879293Reviewed-by:
Maksim Moskvitin <mmoskvitin@google.com> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710271}
-
Christian Dullweber authored
Test that web features like SharedWorker and WebLocks that allow to communicate between tabs are blocked when third-party cookies are blocked. The WebLock test is disabled until WebLock works correctly Bug: 989926, 1016355 Change-Id: Ifd885b4e22338d211b35635ad0d85f0981c8e518 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883632Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Commit-Queue: Christian Dullweber <dullweber@chromium.org> Cr-Commit-Position: refs/heads/master@{#710270}
-
Mathias Carlen authored
Before this patch perform_assistant_action was used to trigger Autofill Assistant layer scripts. For an external DirectAction caller it is expected to get a flattened list of direct actions instead of this indirection. The indirection got removed in a previous patch and the perform_assistant_action can now be removed too. Bug: b/138833619 Change-Id: Ib41fe034dc1cdeaae38582c7f5389ed8d1b3946a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879453 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#710269}
-
Arthur Hemery authored
Removing the unusued feature. Bug: 784904 Change-Id: I9d5bed00c0c95b634ce2be7cc1d251be691b2417 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883074Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Commit-Queue: Arthur Hemery <ahemery@chromium.org> Cr-Commit-Position: refs/heads/master@{#710268}
-
Mikel Astiz authored
No behavioral changes: many concepts and member fields, in particular class Connection itself, are specific to one of the implementations, SyncServerConnectionManager. Other production implementations (LoopbackConnectionManager) as well as tests do not use any of those concepts, and use hacks to plumb in data as well as logic that is actually never used. Instead, let's move the subclass-specific logic to SyncServerConnectionManager and let the base interface be simpler. Bug: 951350 Change-Id: I74dcbbaf55676a7c1c9f8c38aca76288591048f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1625999 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#710267}
-
Arthur Hemery authored
Removed a bunch of remaining DCHECKs and clarified future removal with comments. Bug: 784904 Change-Id: I439aa220af91b96c3b74a9b79868c5ca91fcbb7b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883073Reviewed-by:
-
Fredrik Söderquist authored
This changes from using essentially a linear-scan for the "update intervals" step to using a priority queue with the next interval time as the key/priority. Besides providing a dramatic reduction in the amount of actual interval update steps being performed, this also shifts the responsibility for the timing updates away from the sandwich structure and into the time container. This will in turn allow future simplification of the setup for animation value application/sandwich management. To aid the switch to the priority queue scheduling mechanism, the update of the "next interval time" is sunk out of and now performed as a separate step after UpdateInterval(). Some code is consolidated around the new "reschedule" operation (the SMILTimeContainer::Reschedule(...) method) which greatly simplifies some code. Bug: 998526 Change-Id: I1e22625eac022155607a3ccc66dd2d21f52cc7ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1876031Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Fredrik Söderquist <fs@opera.com> Cr-Commit-Position: refs/heads/master@{#710265}
-
Yang Guo authored
https://chromium.googlesource.com/devtools/devtools-frontend/+log/70f122128c..8bb84e5801 TBR=aerotwist@chromium.org Change-Id: Id2370e489efc7024b916b328f7e8f46e9f314bec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886410Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Yang Guo <yangguo@chromium.org> Cr-Commit-Position: refs/heads/master@{#710264}
-
Mathias Carlen authored
For testing purposes we want to already expose an argument for a specific action. The correct way to address this is to use the action specs given in the proto and properly report the args configured therein. R=szermatt@chromium.org Bug: b/138833619 Change-Id: I4d5d0795e6a1249879b2675428e9418264251ca0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883076 Commit-Queue: Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
-
Michael Lippautz authored
During marking, (a) marking an object and (b) processing it currently happen on the main thread. In future, concurrent marking will move both steps to helper tasks. Even with concurrent marking, the write barrier remains on the main thread and will require at least (a) to be executed right away. It is thus beneficial to increment live bytes counters in (b) which can be offloaded to helper tasks. Output on Z840 (down from ~13.1x): [ RUN ] WriteBarrierPerfTest.MemberWritePerformance *RESULT WriteBarrierPerfTest writes during GC: = 46497.21016738996 writes/ms *RESULT WriteBarrierPerfTest writes outside GC: = 541516.2454873646 writes/ms *RESULT WriteBarrierPerfTest relative speed difference: = 11.646209386281587 times [ OK ] WriteBarrierPerfTest.MemberWritePerformance (67 ms) Bug: 1014414 Change-Id: I5295e4738fce9410fbfbed51829c04b2e25f2d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883719 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#710262}
-
Hitoshi Yoshida authored
Adds a support for callback interfaces in Web IDL database. Bug: 839389 Change-Id: Ic4911a18fa7abf0b0891f53bc3dc8de38dd48730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886073 Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#710261}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/e78527989c4c..dca568a3575f git log e78527989c4c..dca568a3575f --date=short --no-merges --format='%ad %ae %s' 2019-10-29 angle-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/SwiftShader 1737a30e3e34..f8f6103eb89f (2 commits) Created with: gclient setdep -r src/third_party/angle@dca568a3575f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=ynovikov@google.com Bug: None Change-Id: I9050e3f66566507ef3c815c61bcb042a2536a315 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886511Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710260}
-
Mihai Sardarescu authored
This CL removes unifiedConsentEnabled variable from all settings resources that were still referencing it. Bug: 1015805 Change-Id: I8c12a9558a4cfab236d423c037f92e24bea99975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878195Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#710259}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Tools.git/+log/ec12de913124..42f885238114 git log ec12de913124..42f885238114 --date=short --no-merges --format='%ad %ae %s' 2019-10-28 bclayton@google.com utils: Add a vscode extension for SPIR-V disassembly files (#2987) 2019-10-28 greg@lunarg.com Add two new simplifications. (#2984) 2019-10-28 afdx@google.com spirv-fuzz: Transformation to extract from a composite object (#2991) Created with: gclient setdep -r src/third_party/SPIRV-Tools/src@42f885238114 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/spirv-tools-chromium-autoroll Please CC radial-bots+chrome-roll@google.com,ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_angle_vk32_deqp_rel_ng;luci.chromium.try:android_angle_vk32_rel_ng;luci.chromium.try:android_angle_vk64_deqp_rel_ng;luci.chromium.try:android_angle_vk64_rel_ng;luci.chromium.try:linux_angle_deqp_rel_ng;luci.chromium.try:linux-angle-rel;luci.chromium.try:win-angle-rel-32;luci.chromium.try:win-angle-rel-64;luci.chromium.try:win-angle-deqp-rel-32;luci.chromium.try:win-angle-deqp-rel-64 TBR=radial-bots+chrome-roll@google.com,ynovikov@google.com Bug: None Change-Id: I275ca1123d678df4b9688c7bfcb5a09ede232114 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886510Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts URLLoaderClientRequest to new Mojo types using PendingReceiver and Receiver. Bug: 955171 Change-Id: Ib359451c4e8286b61e24327dc15a1629d4a6c0ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883457 Commit-Queue: Julie Kim <jkim@igalia.com> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Kevin McNee <mcnee@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
-
Mario Sanchez Prada authored
Convert the remaining bits referencing this mojo interface using the old mojo APIs, to the new mojo types. Bug: 955171 Change-Id: I552ea14b3bcd3700423bc13dc0bf0a9cc1198d0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881233Reviewed-by:
Yuri Wiitala <miu@chromium.org> Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Commit-Queue: Mario Sanchez Prada <mario@igalia.com> Cr-Commit-Position: refs/heads/master@{#710256}
-
Jan Wilken Dörrie authored
This change implements LWG3101 [1], which disables span's Container constructors when the extent is static. This change disables the corresponding constructors appropriately and modifies base::make_span<N> to call the two argument (data, size) constructor instead. [1] https://wg21.link/LWG3101 Bug: 828324, 877931 Change-Id: If3e615ea26f2a051c0c650bed0789c9442ca47b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883569Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#710255}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/a8fe19e0c492..e0d8f948954f git log a8fe19e0c492..e0d8f948954f --date=short --no-merges --format='%ad %ae %s' 2019-10-29 tmrts@chromium.org [vinn] Enable snapshots and update Mac d8 binary to 7.7.299.15 Created with: gclient setdep -r src/third_party/catapult@e0d8f948954f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC zhanliang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=zhanliang@google.com Bug: chromium:1001953 Change-Id: Ib95040bbb81e53ab46fabc338a3f1823f748ad14 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886290Reviewed-by:
-
Kamila Hasanbega authored
This reverts commit 37574271. Reason for revert: It seems to be the reason for https://ci.chromium.org/p/chromium/builders/ci/Mac10.11%20Tests starting to fail. Original change's description: > WebApp: Implement sync-initiated installs for sync-stub apps. > > This code is disabled by default behind kDesktopPWAsWithoutExtensions and > kDesktopPWAsUSS base features. > > A browser end-to-end tests will be added later in a follow up CL. > An MVP implementation of the bridge+sync needed first. > > Bug: 860583 > Change-Id: I461e24fefcbb5d2a0bf819d63a480635e91c732c > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1858025 > Commit-Queue: Alexey Baskakov <loyso@chromium.org> > Reviewed-by: Mark Pearson <mpearson@chromium.org> > Reviewed-by: Alan Cutter <alancutter@chromium.org> > Cr-Commit-Position: refs/heads/master@{#710218} TBR=mpearson@chromium.org,alancutter@chromium.org,loyso@chromium.org Change-Id: I90e076fa6710d06dc118ee57adb0ab454b0e55d9 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 860583 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886411Reviewed-by:
-
Dominik Röttsches authored
Retrieving fallback font information on Windows 8.1 and up using Skia's matchFamilyStyleCharacter() did only pick the family name, but not instantiate the fallback font from the additional SkFontStyle font style information that Skia provides as well. This bug was fixed similarly before for the Windows 8.0 and before fallback code path in issue 1008901. This fixes an issue in which fallback for U+2758 LIGHT VERTICAL BAR produces Segoe UI Semilight as fallback font, but the renderer was unable to instantiate that font correctly and displayed a .notdef glyph for this character. Bug: 1018375 Change-Id: I18a37f8f432ff1c392dedbc868b8f882254b12d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883515Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#710252}
-
Kamila Hasanbega authored
This reverts commit ba5c7d6f. Reason for revert: It breaks several tests https://ci.chromium.org/p/chromium/builders/ci/Win7%20Tests%20%28dbg%29%281%29 https://ci.chromium.org/p/chromium/builders/ci/Linux%20Tests%20%28dbg%29%281%29 Original change's description: > [Paint Preview] Compositing Service > > Adds a paint preview compositor service for compositing collections of > SkPictures representing frames into bitmaps. This is very similar > in principle to the PDF compositor service, but produces tileable > bitmaps rather than a PDF. > > A client to this service should start the compositing collection > portion of the service in a utility process. The client can then > create and delete dedicated compositor instances for each group of > SkPictures. Realistically only one compositor will be actively > communicating at a time. However, multiple compositors can be > "warm" (data is deserialized and in memory for fast switching). > > Bug: 1011430 > Change-Id: I21cb594cd94982f8d4fc5800d9ae4d74b5d9973b > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1842273 > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Colin Blundell <blundell@chromium.org> > Reviewed-by: Ken Buchanan <kenrb@chromium.org> > Reviewed-by: Ian Vollick <vollick@chromium.org> > Reviewed-by: Mehran Mahmoudi <mahmoudi@chromium.org> > Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> > Cr-Commit-Position: refs/heads/master@{#709946} TBR=vollick@chromium.org,sky@chromium.org,kenrb@chromium.org,blundell@chromium.org,jochen@chromium.org,blundell@google.com,mahmoudi@chromium.org,ckitagawa@chromium.org Change-Id: Idbeb4bb3989d803f1efcde86f1066b791731b08b No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1011430 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886610Reviewed-by:
-
Nathan Zabriskie authored
This CL allows the shared main thread context to use the GLES-backed RasterImplementationGLES raster interface. This will be a transitional change used during the OOP-R Canvas2D project: https://docs.google.com/document/d/1NwKi0Z-c1kQWAdKjj41283YWfLBQFegAIWnvgCvq95k Using RasterImplementationGLES will allow us to incrementally remove references to GLES2Interface in Canvas2D until we can use RasterImplementation directly. Change-Id: I189f26db8d70175908edb72050dba652d7f3df3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1872932Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
-
Wanming Lin authored
This CL adds a few tests to cover various checkpoints: - Read/write data from/to an unformatted NDEF tag, as well as interaction with NDEFPushOptions.overwrite attribute. - Read/write data from/to a non-NDEF tag, throws error. Relevant discussion in spec: https://github.com/w3c/web-nfc/issues/367 Bug: 520391, 1012463 Change-Id: I87cb7dc4611f8575b5616ecd98cc64249d79c4db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880537 Commit-Queue: Wanming Lin <wanming.lin@intel.com> Reviewed-by:
François Beaufort <beaufort.francois@gmail.com> Reviewed-by:
Leon Han <leon.han@intel.com> Cr-Commit-Position: refs/heads/master@{#710249}
-
Leo Zhang authored
Bug: 888885 Change-Id: Ifa248fed62148cae3d3d8c5f1d2a382dcf48d3bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886082Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Leo Zhang <googleo@chromium.org> Cr-Commit-Position: refs/heads/master@{#710248}
-
Michał Pichliński authored
After: https://chromium-review.googlesource.com/c/chromium/src/+/1853045 CollectedCookiesViews OK button label was "OK" instead of "Done", because set_button_label was called after ShowWebModalDialogViews. Change-Id: I3e53e4a5c1a663b49f960a8292998d26773d66c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1878071 Commit-Queue: Michal Pichlinski <mpichlinski@opera.com> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#710247}
-
Marina Sakai authored
A class which is not trivially constructible might bloat out code size. The member variable |desc_| of class V8PrivateProperty::SymbolKey is used for just a description of a private property, so we can remove the variable. This CL guarantees that V8PrivateProperty::SymbolKey is is_trivially_constructible. Bug: 715418 Change-Id: I7f44e4e70430b66275b001c99974326556d38477 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880778 Commit-Queue: Marina Sakai <marinasakai@google.com> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#710246}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d1e5d320. With Chromium commits locally applied on WPT: 1d5b803f "Add WebVTT support for inline styling - Web Platform Tests" e6454210 "Fix default tabIndex IDL attribute values" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=raphael.kubo.da.costa No-Export: true Change-Id: I7e1c66793fcc3e118ee57cc30ec1a26f56695fff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884772Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710245}
-
Alex Moshchuk authored
Currently, SiteInstance selection is done in two steps: 1. Decide whether a frame is allowed to navigate cross-process. 2. If so, determine the appropriate SiteInstance for the navigation. Historically, step 1 prevented OOPIFs in cases where site isolation was off, or when we weren't sure we would pick the right process later. This relies on checking IsRendererTransferNeededForNavigation() and CanSubframeSwapProcess(). In practice, that meant that to fix a corner case that was supposed to swap processes, we had to ensure that it both was allowed to swap processes by step 1 *and* picked an appropriate SiteInstance and process in step 2, resulting in quite a few duplicated checks. Step 1 was also used in the process transfer logic in pre-PlzNavigate days, which no longer exists (hence "transfer" in the IsRendererTransferNeededForNavigation). Now that OOPIFs are widespread on both desktop and Android, and the concept of transfers is gone, step 1 has become outdated and unnecessary. Step 2 (which mostly consists of DetermineSiteInstanceForURL()) always follows step 1 now, and it should already handle all the cases with the navigation either staying in the old SiteInstance or transferring to a new one. This CL removes the logic involved in step 1, including implementations of IsRendererTransferNeededForNavigation() and CanSubframeSwapProcess(). No tests are affected, and no behavior change is expected. Change-Id: I1786f240c23e93a47bd8423bab04d9c8cdbece30 Bug: 1015882 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1867031 Commit-Queue: Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Reviewed-by:
Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#710244}
-
Anupam Snigdha authored
Ctrl+Break on Windows was busted. The algorithm in |NextWordPositionInternal| never considered punctuation as a word break character. According to the Unicode spec for word break boundaries, punctuation should be considered as word breaking characters. Added this additional condition in both previous and next word movement. Also changed many spellchecking tests to match this behavior. Insert a space after the misspelled word so it is spellchecked properly. This is done to trigger spellchecking as the punctuation after the misspelled word doesn't trigger spellchecking until the user has pressed space bar or changed the selection. This is how it should be done in real sites anyways so inserting the space after misspelled word to trigger spellcheck makes sense. Test: third_party\blink\renderer\core\editing\visible_units_word_test.cc Bug: 122304, 1004414 Change-Id: I88694d3cd2e275f06e3939e7e42181de0bd1b9c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880602 Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#710243}
-
Glen Robertson authored
Removes the assumption that InstallableManager currently has: that it will continue to exist after calling the callback. This makes sense if considering the callback as a return-like statement for the async GetData call. In prep for refactoring in http://crrev.com/c/1873817 Bug: 1007860 Change-Id: I18f751b32c88a9d3cc9d6c3f3a083fd3952ebe9f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1884409 Commit-Queue: Glen Robertson <glenrob@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#710242}
-
Gyuyoung Kim authored
This CL converts old Mojo types to new Mojo types in CdmFoo classes except for CdmService::LoadCdm. - Convert FooRequest to mojo::PendingReceiver. - Convert FooPtr to mojo::PendingRemote or mojo::Remote. - Convert the second parameter to mojo::PendingRemote in service_manager::GetInterface Bug: 955171 Change-Id: I9ff169c17829f5ce69ede8c6b3ab991350491047 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1883347 Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Reviewed-by: -
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/b5aaf6416b08..c3dc1efee35a Created with: gclient setdep -r src-internal@c3dc1efee35a If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None,chromium:None Change-Id: Ifbb2a5660bb4fd7c816d1c00d54b243b13f317bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1885954Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#710240}
-
Yoshifumi Inoue authored
This patch gets rid of unused function |GetForInlineContainer()| in |NGPaintFragment| for improving code health. Note: The CL[1] gets rid of the last caller of this. [1] http://crrev.com/c/1877505 Utilize NGInlineCursor ComputeNGLocal{Caret,Selection}Rect() Change-Id: I0f191f711a4d55b5a67e92068a7cb4522dcb19f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1881001 Commit-Queue: Yoshifumi Inoue <yosin@chromium.org> Auto-Submit: Yoshifumi Inoue <yosin@chromium.org> Reviewed-by:
-
Austin Tankiang authored
Bug: 1003238 Change-Id: Icc3227b44ba58fcab17bd8eab959f0346a8a906d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1886133Reviewed-by:
-
Makoto Shimazu authored
This changes the test to use the useful utility functions. Bug: 1017861 Change-Id: Idc399d439b803d52ca44ede417890e0a8a4ae550 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880245 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Auto-Submit: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Cr-Commit-Position: refs/heads/master@{#710237}
-
Wei Li authored
Since HaTS library uses async google iframeIO call to post the survey answer through a form to the server. The form's target is an iframe in the same doc. If we close the window too quick, the request might not go through yet. So, in this CL, we wait until the iframe is loaded, which means the form is already posted, to close the window. BUG=1018063 Change-Id: Ifcc3120addecf540a6a45430bba3ea545d65d078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1880694 Commit-Queue: Wei Li <weili@chromium.org> Reviewed-by:
Dan Beam <dbeam@chromium.org> Cr-Commit-Position: refs/heads/master@{#710236}
-
