- 14 Jan, 2021 40 commits
-
-
Mark Pearson authored
Because it's flaky. BUG=1163917 Change-Id: I18a3f815bb3111051500a2048bdbb9a9ac191979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625940 Auto-Submit: Mark Pearson <mpearson@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#843489}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d9ed69807418..9e71e6a50f6b 2021-01-14 jacktfranklin@chromium.org ESLint rule to ban interpolation within <style> tags 2021-01-14 jec@google.com Fix typo in What's New update If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1166108 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Iaab49cfe2d6ed3bc2da180cc1ff2492916fd79d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628462Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843488}
-
Andy Paicu authored
No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1166602 Change-Id: I319bd450947624388df6e3c2539edc0bfdca59d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628292Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Auto-Submit: Andy Paicu <andypaicu@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#843487}
-
Rakina Zata Amni authored
Logging this metrics allows us to add a slow report trigger, so that we can analyze what happened on these navigations by seeing the traces. Bug: 1131832 Change-Id: I66ffecc05b0cfb16d59ae1652648bc87a4affb58 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592281 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843486}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c0dfd5b48e14..1ac263e38879 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: I88d16b2cf9af89d56b388239c0b70e49e7c14013 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628460Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843485}
-
David Jean authored
And menu api, and one remaining status bar orientation related issue. Bug: 1131852 Change-Id: I74747b488608a6156d5f1ef15b8d6e52c1aa4741 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621307 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#843484}
-
Jan Krcal authored
This CL adds logic for SAML sign-in flows. Whenever the gaia domain is left in the sign-in flow, it is treated as a SAML sign-in flow, the profile creation is finalized and the SAML signin continues in a new browser window. Bug: 1126913 Change-Id: I48cac367d45567ba7186eb7d4cfa05dc90a0f97f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627426 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Cr-Commit-Position: refs/heads/master@{#843483}
-
Delan Azabani authored
This patch updates four web platform tests involving CSS highlight painting order, which should help us rework our highlight paint code to comply with css-pseudo. • css/css-pseudo/selection-overlay-and-{grammar,spelling}-001.html • two manual tests, checking the relative painting order of ::selection and ::{grammar,spelling}-error overlays • added @contenteditable/@spellcheck/@lang to test element • added Selection#removeAllRanges call to work around API change • replaced the grammar test sentence with a more obvious example • rewrote most of the comments for clarity • css/css-pseudo/highlight-painting-order.html • new reftest, checking relative painting order of text, original shadows, ::selection background, and ::selection shadows • based on <https://bucket.daz.cat/work/igalia/0/3.html> • css/css-pseudo/selection-text-shadow-{006-manual,016{,-ref}}.html • one manual test, one reftest, checking that text-shadow:none in ::selection suppresses all original shadows (even if multiple) • dropped because they are no longer compliant (highlight overlays have their own shadows, independent of the content’s shadows) Bug: 1147859 Change-Id: I29bab589e3924778d555d96537d010dc33ed003f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624328 Commit-Queue: Delan Azabani <dazabani@igalia.com> Reviewed-by:Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843482}
-
Hiroki Nakagawa authored
In addition, this CL renames PrerenderHelper::IsPrerendering() to NoStatePrefetchHelper::IsPrefetching(). Bug: 1144577 Change-Id: I1e875f651c50f401c54c7cc8d60d0b508b8e9ff7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626671 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#843481}
-
Takuto Ikuta authored
This is for https://crrev.com/c/2628816 Bug: 1157476 Change-Id: I764bbc39c7a607e483d025ad32eb1e8d41897ab7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628641Reviewed-by:
Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Yoshisato Yanagisawa <yyanagisawa@google.com> Commit-Queue: Takuto Ikuta <tikuta@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#843480}
-
Ulan Degenbaev authored
The global detached bytes include memory of unrelated frames and extensions. We need to track per-frame detached bytes and only report those in the same browsing context group. Bug: 1085129 Change-Id: I3a562f0b3d898abe7508c46046cbd574db43173a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628987Reviewed-by:
Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Ulan Degenbaev <ulan@chromium.org> Cr-Commit-Position: refs/heads/master@{#843479}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I0a1a981c032a0a6a91af2ce32bd4fd0c8d57d452 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627879Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843478}
-
Vidhan authored
AlternativeStateNameMap can only be accessed on the UI thread. In the current implementation, the logic to determine state votes using AlternativeStateNameMap does not run on the UI thread resulting in the crash. With this CL, the state votes are preprocessed before |DeterminePossibleFieldTypesForUpload| is called. Bug: 1111960 Change-Id: I470b7db684916c4c7fef35d2018af876992c0c27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617792 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#843477}
-
Colin Blundell authored
This CL completes the abstraction of signin & sync deps from //components/safe_browsing/core/realtime by abstracting the usage of SyncService to determine whether history sync is enabled. As with the other abstracted dependencies, this information is now obtained via a callback that is passed in from the embedder. With this CL, WebLayer can now use this component without needing to reference signin or sync at all. There is no behavioral change in this CL. Bug: 1080748 Change-Id: I320e7f225fb65258862768e411dd85c51dfac9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624211 Commit-Queue: Colin Blundell <blundell@chromium.org> Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Cr-Commit-Position: refs/heads/master@{#843476}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/e5adc63d7ca2..d9ed69807418 2021-01-14 jec@google.com Update What's New UI for Chrome 89 2021-01-14 soxia@microsoft.com [DevTools Frontend] Resync debugger id after navigation If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibaa9372cd2b020f4cf9908c7c690515f412b1689 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628053Reviewed-by:
-
Vidhan authored
AutofillDataModel::ShouldSkipFillingOrSuggesting always returns false for the CreditCard whereas AutofillProfile::ShouldSkipFillingOrSuggesting overrides it. With this CL, ShouldSkipFillingOrSuggesting is now a member of only AutofillProfile and never called for CreditCard. Change-Id: Ie86f5cac7eb7f46f2eb8a9193208783484dd0aa6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627487 Commit-Queue: Vidhan Jain <vidhanj@google.com> Reviewed-by:
Christoph Schwering <schwering@google.com> Cr-Commit-Position: refs/heads/master@{#843474}
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - file_tasks.js - file_tasks_unittest.m.js Bug: 1133186 Change-Id: I9bfc94f7987e52df8135a19ae06355baa1dd8564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627201Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Cr-Commit-Position: refs/heads/master@{#843473}
-
Hiroki Nakagawa authored
NoStatePrefetch now disables prefetching triggered by <link rel=next> (see https://crbug.com/1161545). To be aligned with that, this CL makes Prerender2 abort prerendering triggered by <link rel=next> as well. Bug: 1155925 Change-Id: I3986e9520154adf380da50bcf5e261d2fdcfca4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626609 Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
-
Olivier Robin authored
incognitoContentVisible is persisted in NSUserDefaults in some configurations. This means that unittests must not assume any initial value and the value to false (default) if possible. Change-Id: I4331afe28a60ba1e592d33ca4505af890cb22dc7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627853 Auto-Submit: Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
-
evliu authored
This CL allows the live captioning of muted audio streams that are not initiated by autoplay. Bug: 1164066 Change-Id: I2ec217aaf243ec633e79bf60ea11b3cc22159c72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616879Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Evan Liu <evliu@google.com> Cr-Commit-Position: refs/heads/master@{#843470}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/703f21e21747..c603339365fb 2021-01-14 tikuta@chromium.org autoninja: use pure python for ninjalog_uploader_wrapper.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ajp@google.com,apolito@google.com,ehmaldonado@google.com,sokcevic@google.com Change-Id: I270831aeeaaa375d1fceca847ff249ff22ef70ef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626026Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/8a42f3312f5e..c0dfd5b48e14 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC andypaicu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: andypaicu@google.com Change-Id: Ieed082557dda81b75a0ae1b31649540b6ed30382 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625943Reviewed-by:
-
Daniel Hosseinian authored
Document properties isn't ready to ship since some property values are still missing. Placing behind a feature flag for now that can be enabled on chrome://flags. Bug: 93619 Change-Id: I064ac07972d58d244a84905bf4a21896978c7f95 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628038 Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#843467}
-
Anton Bikineev authored
In case giga-cage is enabled, for 64bit we can use a bitmap of super-pages to quickly validate during scanning if a super-page is valid. The bitmap must consist of only super-pages that correspond to the roots that have PCScan enabled. The CL also makes sure that the IsGigaCageEnabled() check is not performed for each word/scan-range/super-page. To achieve that, it templatizes scanning routines based on giga-cage presence. Having the functions parameterized by policies makes sure that there are no hidden performance costs (e.g. indirect calls). This improves scanning time on cnn:2020 by ~20%. Bug: 11297512 Change-Id: I15226e0bfdf3f6d48c39421f4f54cf1aa5bafb4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624677 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
-
Keishi Hattori authored
When we use BackupRefPtr for AudioOutputDevice::callback_, it detects a dangling pointer being assigned to it. This is because, RenderCallback can be destroyed by the time InitializeOnIOThread gets called on the io thread. This CL adds a check for stopping_hack_ so we won't assign, when Stop() has already been called. Bug: 1154812, 1080832 Change-Id: Icb02ed9661ebcd2c0ee8c81888bc68c3d1af83a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575481 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Olga Sharonova <olka@chromium.org> Reviewed-by:
-
Michael Lippautz authored
Bug: 1056170 Change-Id: I2382ff5f7489346e591e3f5466352ff6190e16c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626445Reviewed-by:
-
Irem Uguz authored
Add Observer to net::CertDatabase in certificate_manager_model CertsSourcePlatformNSS to observe the changes in the CertDatabase and Refresh whenever there is a change in the database to solve the bug. Update the tests accordingly. Bug: 1146607 Change-Id: I3b9ba7f64cf47333cb79430c6a060620290e8f30 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2601748Reviewed-by:
Matt Mueller <mattm@chromium.org> Reviewed-by:
Pavol Marko <pmarko@chromium.org> Commit-Queue: Irem Uğuz <iremuguz@google.com> Cr-Commit-Position: refs/heads/master@{#843463}
-
Eric Seckler authored
Change-Id: I4cfb20bd12e93c84bddb0ff7920e718c0fc03fc4 No-Try: True Tbr: wenbinzhang@google.com Bug: 1166558 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626299Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Eric Seckler <eseckler@chromium.org> Cr-Commit-Position: refs/heads/master@{#843462}
-
Andy Paicu authored
This reverts commit 6e03dcb5. Reason for revert: crbug.com/1166565 Original change's description: > CCA: Use calculated default window size > > The calculation of default window size is based on fixing width to 764px > in all preview aspect ratio cases(3:4, 4:3, 9:16, 16:9) and deriving > height from that fixed width so that after preserve space for left, > right, bottom icons(--xxx-line*2), the |#preview-box| can fit in preview > aspect ratio as close as possible. After these, the new default window > size under different preview aspect ratio will be: 3:4 -> 764x888; 4:3 > -> 764x552; 9:16 -> 764x1144; 16:9 -> 764x444. Also change the minimal > window width x height to 486 x 444 accordingly. > > Bug: b/175324385 > Test: Manually verify default window size under 3:4, 4:3, 9:16, 16:9 > preview. > > Change-Id: Ic4c569819f29b813029f478e6920f66453ab4792 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615730 > Reviewed-by: Shik Chen <shik@chromium.org> > Commit-Queue: Inker Kuo <inker@chromium.org> > Auto-Submit: Inker Kuo <inker@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843399} TBR=shik@chromium.org,inker@chromium.org,wtlee@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: Ia46d3467a098d2682113795d5ddde2df1b016722 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: b/175324385,1166565 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626666 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Viktor Semeniuk authored
This change syncs local Compromised credentials. Bug: 1137775 Change-Id: Icb137b171d8caa3e8c2988b60a201b581140e067 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593618 Commit-Queue: Viktor Semeniuk <vsemeniuk@google.com> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#843460}
-
Dominic Mazzoni authored
Originally landed: crrev.com/c/2602697 Reverted: crrev.com/c/2618674 Reverted due to new test SnapshotAXTreeBrowserTest.Timeout being flaky. Re-landing with the test disabled, then I'll upload a change to try to re-enable and fix the flakiness. WebContents::RequestAXTreeSnapshot is used for several things, including supporting Assistant on Android and Chrome OS, generating tagged PDFs, speaking the text of a page on macOS, and determining the page language for Translate. On Android, requests are timing out on large pages; Assistant wants results in 3 seconds. This change adds additional parameters to RequestAXTreeSnapshot to enable it to run faster, by limiting the number of nodes, excluding offscreen nodes, and returning partial results after a timeout elapses. This change adds test coverage but does not change any code to use these new parameters, so there shouldn't be any side effects of landing this patch. A follow-up will change the Android callers to pass different parameters. Bug: 1161541 Change-Id: Ie8de84d11b05b297b3c8b7869a76dbd0b07ce5f6 AX-Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622002Reviewed-by:
Emily Stark <estark@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Mark Schillaci <mschillaci@google.com> Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#843459}
-
Gyuyoung Kim authored
As a pre-work to convert the context menu IPC messages, this CL renames context_menu_data.mojom to context_menu.mojom. The converted IPC messages will be added to the renamed Mojo file. Bug: 1093904 Change-Id: Ic5bfbc0a637cd3b01b2e576cfcca9e239d881732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626819Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Commit-Queue: Gyuyoung Kim <gyuyoung@igalia.com> Cr-Commit-Position: refs/heads/master@{#843458}
-
Swapnil authored
This change gives ExtensionManagement control over update URL used when updating extensions. Previously only first install was affected, all later updates used update URL from the extension manifest. Now update URL from the policy can be used if extension management said so. This change is split into multiple CLs. Update URL from policy is handled in https://chromium-review.googlesource.com/c/chromium/src/+/2593260. Bug: b/175786074 Change-Id: I73580416d039a14abe7b91ecad50f4f8cecc8682 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2596259Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#843457}
-
Andy Paicu authored
This reverts commit 1c92b3fd. Reason for revert: crbug.com/1166551 Original change's description: > Add custom message related fields to content analysis dialog > > Bug: 1166369 > Change-Id: I32459ec22d8a4a6bd57d8ae0a17a3850a365fc57 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625914 > Commit-Queue: anthonyvd <anthonyvd@chromium.org> > Reviewed-by: Dominique Fauteux-Chapleau <domfc@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843330} TBR=anthonyvd@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,domfc@chromium.org Change-Id: Ibdb66dfcb4e267c61eefaaa48ac5a2aefdd8ba16 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1166369,1166551 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628949 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
Wojciech Bielawski authored
Python3 map, filter returns generator object. In some places generators must be wrapped with list to allow reuse of result. In other to allow concatenation. Bug: 1164344 Change-Id: I00813ff95c73f3e25f18d7bab08e2704af948664 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2617846Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
-
Swapnil authored
This change gives ExtensionManagement control over update URL used when updating extensions. Previously only first install was affected, all later updates used update URL from the extension manifest. Now update URL from the policy can be used if extension management said so. Update URL from policy is handled in https://chromium-review.googlesource.com/c/chromium/src/+/2593260. This is a follow up CL that allows usage of policy enforced update URL in management_api.cc Bug: b/175768136 Change-Id: Iae334e3a50b9398664c1ac23fb7f65ee1833a289 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2592803Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Commit-Queue: Swapnil Gupta <swapnilgupta@google.com> Cr-Commit-Position: refs/heads/master@{#843454}
-
Andy Paicu authored
This reverts commit 50ba4848. Reason for revert: crbug.com/1166548 Original change's description: > [Extensions] Clean up use of kFlagEnableFileAccess. > > Prior to this CL, the default was that test extensions were loaded > with file access enabled. This is not necessary, and doesn't reflect > the real world, where most APIs work without needing file access. > > With this CL, the default is that a test must explicitly request > file access for the extension. To reflect this, some member functions > have been renamed and their behavior modified so that it's clear > that the test is requesting file access. > > This also fixes the PermissionsApiTest.OptionalPermissionsFileAccess > test, which had incorrect embedded extension IDs. > > Bug: 1163548 > Change-Id: Ib0f80b0448f49628488074082bfd54486dde3aef > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613306 > Reviewed-by: Devlin <rdevlin.cronin@chromium.org> > Reviewed-by: Istiaque Ahmed <lazyboy@chromium.org> > Commit-Queue: David Bertoni <dbertoni@chromium.org> > Cr-Commit-Position: refs/heads/master@{#843401} TBR=lazyboy@chromium.org,rdevlin.cronin@chromium.org,dbertoni@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I7250d8a4f8903c296d25471e8518b34167d8a192 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1163548,1166548 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2628988 Commit-Queue: Andy Paicu <andypaicu@chromium.org> Reviewed-by:
-
David Jean authored
UIApplicationDidChangeStatusBarOrientationNotification is deprecated in iOS 13. Instead the BVC method viewWillTransitionToSize:withTransitionCoordinator: Set the orientation for crash_keys and notifies the CrwWebController of orientation/size change. Bug: 1131852 Change-Id: Ia2b26e8aa9b8e58d0e5a4401f2a4049b221f599b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620263Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
John Wu <jzw@chromium.org> Commit-Queue: David Jean <djean@chromium.org> Cr-Commit-Position: refs/heads/master@{#843452}
-
Hassan Talat authored
This CL moves the ShareError enum def to its own file so the macOS impl (upcoming CLs) can import it in components//remote_cocoa without having to import the other definitions Bug: 1144920 Change-Id: I1f60916facdc34ce67aeb7ecec03e3795278d6f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626463Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Commit-Queue: Hassan Talat <hatalat@microsoft.com> Cr-Commit-Position: refs/heads/master@{#843451}
-
Antonio Sartori authored
This is a small refactoring of the code in blink::CSPDirectiveList. Instead of storing the source list directives as separate members, we put them in a map. This is part of a project to harmonize the CSP code in Blink and in services/network, and will make it easier to synchronize Content Security Policies between the two. Bug: 1021462,1149272 Change-Id: I5936d73aa0cb83530565c88341395a51a092cfba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2593641 Commit-Queue: Antonio Sartori <antoniosartori@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#843450}
-
