GitLab

This change is part of topic change.
the change helps eliminate apparent rewrite of the
AutocompleteCoordinator.java file in subsequent patch.

Bug: 966424
Change-Id: Iff92f7c70cd4a7d631abb83bf9c780839dac29ef
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508800Reviewed-by: Filip Gorski <fgorski@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823350}

This is mechanical rename other than changes in OWNERS and
flag-metadata.json.

Change-Id: I9020d87a81ccad25aaa1ac5881f8cfdb52cce25f
Bug: 1144577
Tbr: fgorski@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512486
Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Robert Ogden <robertogden@chromium.org>
Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823349}

Nulling out the permissions delegate would cause a crash if the user
started scanning a QR code, abandoned, and then tried again.

BUG=1002262

Change-Id: I5cd3345d312dc80588e5e8a7df67d613fca83318
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511972
Auto-Submit: Adam Langley <agl@chromium.org>
Commit-Queue: Martin Kreichgauer <martinkr@google.com>
Reviewed-by: Martin Kreichgauer <martinkr@google.com>
Cr-Commit-Position: refs/heads/master@{#823348}

As of
https://chromium-review.googlesource.com/c/chromium/src/+/2510736

the tts service, which runs a prebuilt containing tensorFlow, now asks for
sysinfo.

R=mpdenton@chromium.org

Test: patch the above change and makes sure the tts works.
Change-Id: If578d0bb6617390a5919ac33b4b04970a33da317
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514759Reviewed-by: Matthew Denton <mpdenton@chromium.org>
Commit-Queue: David Tseng <dtseng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823347}

- Removes mobile provider label.
- Fixes spacing inconsistency.
- Hides sparator if there's no preceding content, i.e. in interstitial
  views.

Screenshots:
https://screenshot.googleplex.com/4ZSfevJhMoUZbZE.png
https://screenshot.googleplex.com/8oncKmfXsKrJRfp.png

BUG=1144232,1142885,1106937

Change-Id: I01e761c1507675a6d674481615c480348c76583c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511756
Commit-Queue: Meilin Wang <meilinw@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Reviewed-by: Andre Le <leandre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823346}

Skips the reposition if the window is not dropped into overview on
drag end.

Test: added test, manual
Change-Id: I80635aa657e8a2017b72b06992a1f98181754bed
Fixed: 1049206
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2496192
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823345}

Remove redundant ! from {!string} on string properties as primitives are
non-nullable by default.

Remove ? from {?string} on string properties as we do not need nullable
strings since we do not explicitly set strings to null or check for null
strings in Scanning.

Bug: 1059779
Change-Id: I9e0f9e1d1c08822319d00867a449318c8f59f0d3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511789Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Commit-Queue: Gavin Williams <gavinwill@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823344}

Currently it will navigate to a non-existent page, resulting in a 404
error page.

Bug: 1144680
Change-Id: I3921423ae8bed51b893aa62fc36f20a82b232d66
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513850Reviewed-by: Becca Hughes <beccahughes@chromium.org>
Commit-Queue: Rakina Zata Amni <rakina@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823343}

If there is no current connection, request a new connection when the UI is opened.


Bug: 1106937,1126208
Fixed: 1141600

Change-Id: I20563f0c6d1ef3f191be38d3e4cfa20e6ab2bdd7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2504069
Commit-Queue: Andre Le <leandre@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823342}

This CL updates the constant values of accessibility actions
adding in Android R SDK.

To support the SDK initially, we fetched the constant values of
the actions from the Resources during runtime. This was a
temporary solution until the constant values were defined.

This CL replaces the Resources calls with the constant values.


AX-Relnotes: N/A
Change-Id: I9022f632bfe7da3cebe255e5cc19917de95af2d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511249Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Mark Schillaci <mschillaci@google.com>
Commit-Queue: Mark Schillaci <mschillaci@google.com>
Cr-Commit-Position: refs/heads/master@{#823341}

Add a function to change sub label's text color in QuickActionItem,
which is used in enable hotspot to change the color to green when
connected.

Bug: 1106937,1126208
Change-Id: Ia892551bd7d60ea1131b6d5c84f60cd6951b8e83
Fixed: 1144843
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512547Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Reviewed-by: Tim Song <tengs@chromium.org>
Commit-Queue: Andre Le <leandre@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823340}

This change introduces the SystemRoutineController Mojo interface
which will be used by the Diagnostics SWA to run various diagnostic
routines. The first such routine is the CPU Stress Test.

An example of the CPU routines being called from the app can be seen
enumerated here[1] and executed here[2]

1- https://source.chromium.org/chromium/chromium/src/+/master:chromeos/components/diagnostics_ui/resources/cpu_card.js;drc=28198c08d1153532dbf1375412fc6fa42de320d7;l=37
2 -https://source.chromium.org/chromium/chromium/src/+/master:chromeos/components/diagnostics_ui/resources/routine_list_executor.js;l=88-118


Bug: 1128204
Change-Id: I3662f91d72e86b03e3b40436bbf7a0a9204351ea
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2457926
Commit-Queue: Bailey Berro <baileyberro@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Reviewed-by: Zentaro Kavanagh <zentaro@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823339}

FamilyUserMetricsProviderTest.UserCategory/* browser tests are causing
flaky failures. Disable the tests while looking for a fix.

Bug: 1144651
Change-Id: I92153b1b85db8970e5fa73c1d57fb9cc78b9ebb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514622
Commit-Queue: Toby Huang <tobyhuang@chromium.org>
Commit-Queue: Alexei Svitkine <asvitkine@chromium.org>
Auto-Submit: Toby Huang <tobyhuang@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823338}

Bug: 1139046
Change-Id: Ib3cb0164c2003b69e8b70c07fb427de5a0a35f40
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512292Reviewed-by: Owen Min <zmin@chromium.org>
Commit-Queue: Chris Sharp <csharp@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823337}

The XR.WebXR.ReferenceSpace.Requested histogram was set to expire in
December. This change updates it's expiry to that of it's somewhat
paired histogram, XR.WebXR.ReferenceSpace.Succeeded.

Fixed: 1144802
Change-Id: I49f4847f0893eaa0441e805ef3d626c0e7e6bc5f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514183
Auto-Submit: Alexander Cooper <alcooper@chromium.org>
Commit-Queue: Steven Holte <holte@chromium.org>
Reviewed-by: Steven Holte <holte@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823336}

https://chromium.googlesource.com/chromium/src/third_party/freetype2.git/+log/6fca2e5b1b5d..b049cadeb140

2020-11-02 apodtele@gmail.com Mention external modules.

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/freetype-chromium
Please CC drott@google.com,thestig@google.com,bungeman@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:win10-blink-rel;luci.chromium.try:win7-blink-rel
Tbr: drott@google.com,thestig@google.com,bungeman@google.com
Change-Id: Ief4a67e353d3da7fb8b23913660f1fa273c1539a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514511Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Reviewed-by: Ben Wagner <bungeman@chromium.org>
Commit-Queue: Ben Wagner <bungeman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823335}

Bug: b/149758492
Test: Manual Test
Change-Id: Ibcb69b07c79cbb365d81f5ce1f2ba34861eb6dcd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512522Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Commit-Queue: Yue Li <updowndota@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823334}

This is part of a migration that replaces the old
<histogram-suffixes> syntax that was used to denote groups
of histogram to the new patterned histogram syntax.

Bug: 758782
Change-Id: Ie2ee45f2b0493b3a4784c348d1561db3460d7b59
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511851Reviewed-by: Weilun Shi <sweilun@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Karthika Pai <karthikapai@google.com>
Cr-Commit-Position: refs/heads/master@{#823333}

Verify that the user agent returns click/auxclick/contextmenu as pointerevents.

Bug: 989958
Change-Id: I02757ef704b605471614829177cba24a73b6c8db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513801
Commit-Queue: Liviu Tinta <liviutinta@chromium.org>
Reviewed-by: Mustaq Ahmed <mustaq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823332}

R=oshima@chromium.org

Bug: 1099418
Change-Id: Ib3753a2dbc80995b69e4da6b0ef1221934f99310
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511717
Auto-Submit: Nick Yamane <nickdiego@igalia.com>
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823331}

Implement conversion from PNG to JPG image format when requested by user
on scanning UI. Add unit tests to verify functionality.

Bug: b:161237869
Change-Id: I8d21a0d7ddff0ddb3635b45b133f3869ec3e61cf
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2507574
Commit-Queue: Kyra Moed <kmoed@google.com>
Reviewed-by: Jesse Schettler <jschettler@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823330}

BUG=1140235

Change-Id: Id1bd1ac23529ebb871fa7eeeccea3bee1ab3a74f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2506369Reviewed-by: Greg Kerr <kerrnel@chromium.org>
Reviewed-by: Achuith Bhandarkar <achuith@chromium.org>
Commit-Queue: Hardik Goyal <hardikgoyal@chromium.org>
Auto-Submit: Hardik Goyal <hardikgoyal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823329}

This CL renames two AppCacheQuotaClient methods, NotifyAppCacheReady ->
NotifyStorageReady, and NotifyAppCacheDestroyed ->
NotifyServiceDestroyed, to clarify when the methods will get called.

This CL does not introduce any functional changes.

Bug: 1016065
Change-Id: I52238c731bcf805212d24bf744519adaf7a78374
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514666
Auto-Submit: Victor Costan <pwnall@chromium.org>
Commit-Queue: enne <enne@chromium.org>
Reviewed-by: enne <enne@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823328}

This will be used when translating paths for drag and drop.

Bug: 1144138
Change-Id: Ib6be0c4c219d5b9fe63ed205a22edb2675e7318c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2513957
Commit-Queue: Jason Lin <lxj@google.com>
Reviewed-by: Jason Lin <lxj@google.com>
Auto-Submit: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823327}

The issue has been fixed in V8.

Bug: 1137143
Change-Id: I513cb3e606586d694f094b46d326e09c75235a90
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514803
Commit-Queue: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Andrey Kosyakov <caseq@chromium.org>
Reviewed-by: Andrey Kosyakov <caseq@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823326}

TBR=govind@chromium.org

Change-Id: I1cefeef1741b2d518cdf66db1e3151e2e6271b86
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512807Reviewed-by: Ben Mason <benmason@chromium.org>
Reviewed-by: Krishna Govind <govind@chromium.org>
Commit-Queue: Ben Mason <benmason@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823325}

More builder macro cleanup.

Bug: 1130078
Change-Id: Idf4127c8ebb3c71b1bc7a9710e58d629899710d8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510738
Commit-Queue: Allen Bauer <kylixrd@chromium.org>
Auto-Submit: Allen Bauer <kylixrd@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823324}

Previously we recorded pod click events but we actually want to record
and differentiate show events vs close events. Show events will be used
to derive an approximation of feature DAU/WAU/MAU.

Bug: 1131266
Change-Id: I8e1104141626692131037d7396f20f7c2fe8121e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514671Reviewed-by: Toni Baržić <tbarzic@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#823323}

- -Wfinal-dtor-non-final-class warns on classes with final dtors but
  not final classes.
- Error messages are better when the class is marked final.
- Fix existing issues in code base and a follow up will remove warning
  exemption.

Bug: 999886
Test: no errors building
Change-Id: I54b64f21213b7d02138ab67fcc68607f6fca9dc1
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508199
Auto-Submit: Zentaro Kavanagh <zentaro@chromium.org>
Commit-Queue: Dale Curtis <dalecurtis@chromium.org>
Reviewed-by: Dale Curtis <dalecurtis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823322}

Reorder the initializaton of dispather and mediator so that
mediator can receive a correctly initialized dispatcher

Bug: 1144644
Change-Id: I8bc63b2444c32a4e9e8f3459a4a3ea15fe506ca8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514772
Auto-Submit: Lijin Shen <lazzzis@google.com>
Reviewed-by: Theresa  <twellington@chromium.org>
Commit-Queue: Theresa  <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823321}

After the gtest sharding bug is fixed, now we can see the correct runtime of the gtests and update it for better sharding.

Bug: chromium:1130157
Change-Id: Iafd46041207c0160350dbd39b2cd5bc5d20d0cce
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514799
Auto-Submit: Wenbin Zhang <wenbinzhang@google.com>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: John Chen <johnchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823320}

Change-Id: I0e1ccb72d54caacec495f003e0a61c974354e4c8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514801Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823319}

Round x,y coordinates in sendMouseClick so that the caller doesn't need
to take care of rounding.
Signed-off-by: Shannon Chen <shannc@chromium.org>
Bug: None
Change-Id: I0523c6bdb8dea7c77e33285feae4375ea4abd845
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514741
Commit-Queue: Shannon Chen <shannc@google.com>
Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823318}

Add "Login.ArcContinueBootImpulseTime" metric to track the
time taken to execute continue-arc-boot impulse.

See https://crrev.com/c/2512710 for code that emits the metric

BUG=b:165173640
TEST=deploy to dut and verify the new metric is present in

chrome: //histograms
Change-Id: I6dee096fc1665f402f4adfb898fd1dc56ddc86d2
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2512724
Commit-Queue: Muhammad Hasan Khan <mhasank@chromium.org>
Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823317}

Before this patch, a closed frame could return a null origin, but the
payment operation continued and eventually triggered an assert that
checked for non-null origin.

This patch checks for null origin and aborts payment if that's detected.
The origin and URL of the render frame host is marked nullable for
clarity.

After this patch, if a closed frame returns a null origin, then payment
is aborted, so the assert is not triggered.

Bug: 1129578
Change-Id: I0d6404a6f425ce2e814d8d6fa177609a52d14641
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511710
Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Reviewed-by: Yaron Friedman <yfriedman@chromium.org>
Reviewed-by: Liquan (Max) Gu <maxlg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823316}

Add rule for conformance/rendering/draw-arrays-out-of-bounds.html in
webgl2_conformance_gles_passthrough_tests to suppress failures.

Bug: 1143323
Change-Id: I190079d0c307e0dff987769ebb6e7b57e507dc7d
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514508
Commit-Queue: kylechar <kylechar@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Auto-Submit: kylechar <kylechar@chromium.org>
Reviewed-by: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823315}

Fixed: 1089866, 1089865, 1089864, 1046191, 972892
Bug: 1089866, 1089865, 1089864, 1046191, 972892
Change-Id: I60e2ad08e3f0ea5dd676a00d61338aa47c2d4aca
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2510770Reviewed-by: Alexander Timin <altimin@chromium.org>
Reviewed-by: Etienne Pierre-Doray <etiennep@chromium.org>
Commit-Queue: François Doray <fdoray@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823314}

https://swiftshader.googlesource.com/SwiftShader.git/+log/b0e426fcf955..eaf1c53544a7

2020-11-02 sugoi@google.com Merge changes If776b87d,I27098964
2020-11-02 capn@google.com Consistently remove double colon from llvm namespace
2020-11-02 capn@google.com Emulate gather/scatter for MSan builds
2020-11-02 capn@google.com Prevent 'most vexing parse' issue

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/swiftshader-chromium-autoroll
Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86
Bug: None
Tbr: swiftshader-team+autoroll@google.com
Change-Id: I17d6d9b14f99d8d2ab717b811d90db4e6f6c75f6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514510Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#823313}

When a native click accessibility operation is performed on an option
element that is part of a select popup, we mark the option as selected,
then do a native click on the parent select to dismiss it. This
sequence of operations ends up not firing `input` and `change` events,
which normally happens as part of the popup being dismissed by the
click in the normal case.

However, the AccessKeyAction for option takes care of this, so we
perform that operation instead of directly setting the option as
selected.


Bug: 1143990
Change-Id: Ied6023b4b2aee759575eebf75a32b7f2720f3068
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2508884Reviewed-by: Dominic Mazzoni <dmazzoni@chromium.org>
Reviewed-by: Victor Fei <vicfei@microsoft.com>
Commit-Queue: Daniel Libby <dlibby@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#823312}

crrev.com/c/2505739 makes the promos hidden by default until it is
decided whether the promo can be shown or not. Promos now remain hidden
until the promo loaded event or a window resize event is fired where
visibility of the promo is recalculated externally based on whether or
not it overlaps with the most-visited tiles.

This change coordinates these two steps by firing the promo loaded event
after the promo's visibility is determined internally. It also uses a
consistent mechanism for controlling the promo's visibility internally
and externally, i.e., 'hidden' attr aka 'display: none;'

Fixed: 1144624, 1143366
Change-Id: I3b2d2d86e56e0baba3f8042077a07aa0b6ce20a8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2514667Reviewed-by: Esmael Elmoslimany <aee@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#823311}