- 14 Nov, 2019 40 commits
-
-
yilkal authored
This CL attaches the WebTimeLimitEnforcer to AppTimeController. Bug: 1015661 Change-Id: Ic9bd0d3ed349a5300fa59fa873c94c45d24128f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914940 Commit-Queue: Yilkal Abe <yilkal@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Cr-Commit-Position: refs/heads/master@{#715402}
-
Sidney San Martín authored
Bug: 1024914 Change-Id: I3ff68438b028fe38ad7270d7f90772b595f4f46e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917603Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Sidney San Martín <sdy@chromium.org> Cr-Commit-Position: refs/heads/master@{#715401}
-
Wei-Yin Chen (陳威尹) authored
We have assertions in @After, which is a bad idea in general. When a test fails, and the assertions in @After also fails, the error message in @After could be misleading that it's the main reason the test fails. Bug: 1023833, 983170 Change-Id: Iae6f3e194559dad7fb9ab4e3aa1ee7835e4b3223 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916260 Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Cr-Commit-Position: refs/heads/master@{#715400}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ccb4439237a9..5c144f39feb1 git log ccb4439237a9..5c144f39feb1 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 hjd@google.com Merge "Add lsb/msb UUID in trace proto" Created with: gclient setdep -r src/third_party/perfetto@5c144f39feb1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md TBR=perfetto-bugs@google.com Bug: None Change-Id: Ibb00b8a0fcb7a6a26836f5d73c8dd5166c307b38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916968Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715399}
-
Yue Li authored
Bug: b/144383302 Test: Manual Test Change-Id: I54dee29269111170716376762f94eef1a63e2a9d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915105Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Commit-Queue: Yue Li <updowndota@chromium.org> Cr-Commit-Position: refs/heads/master@{#715398}
-
Luke Zielinski authored
Skipping the webdriver directory still caused timeouts. Instead, omit the `wdspec` test type. Bug: 1023835 Change-Id: Ied3971bf844f9ea9fb89f4f5c39cb2aeca01f904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917690 Commit-Queue: Luke Z <lpz@chromium.org> Commit-Queue: Robert Ma <robertma@chromium.org> Auto-Submit: Luke Z <lpz@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#715397}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/5f43d8c3..8fccd236 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I8f07f962651f88665acb00df42f354fc15822136 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917081Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#715396}
-
Morten Stenshorne authored
Introducing NGPhysicalFragment::IsCSSBox(), to distinguish between fragments generated from CSS boxes [1] and those generated by the layout engine to hold CSS box fragments. We have a lot of checks for fragments not being line boxes before working on the associated LayoutObject, but we need to do the same for column boxes. This CL only changes HasLayer(), to fix outline painting, but we could do the same for many of the other methods here. Column boxes don't establish layers, so return false. The layout object that a column box is associated with does establish a layer (for legacy reasons). The outline code [2] has special-code for layers, but shouldn't treat each column as establishing a layer. While we wait for NG column painting to be implemented, we now need to guard against entering columns when painting a box fragment, and instead let the paint layer established by the multicol container and the flow thread drive the painting (like before). [1] https://www.w3.org/TR/css-display-3/#box-tree [2] NGPhysicalContainerFragment::AddOutlineRectsForDescendant() Change-Id: I6fcd753cbed2e5f19560eddf45e903dd58bf4bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912713Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#715395}
-
Sven Zheng authored
This reverts commit 01bf58b0. Reason for revert: Disable again until we fix it. Original change's description: > Reenable CleanerSandboxInterface.DeleteService_HandleHeld for debugging > > We currently do not have sufficient tools to repro failure on bot without > enable the test. > > Bug: 956016 > Change-Id: I89a97d78310fbae96016909196e56cd33ead9230 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914295 > Reviewed-by: Joe Mason <joenotcharles@chromium.org> > Commit-Queue: Sven Zheng <svenzheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#715017} TBR=joenotcharles@chromium.org,svenzheng@chromium.org Change-Id: Icadd13e899c5413bee0a059902a1a2af00c0cfd3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 956016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917541 Commit-Queue: Sven Zheng <svenzheng@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#715394}
-
John Lee authored
This CL also prevents a use case in which the slideOut animation begins while the tab strip is open but will not end until the tab strip is in a closed state. Fixed: 1024620 Change-Id: Id9c7c8dac533bcdff530b1073a0a086a25efde28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914836Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#715393}
-
Wei-Yin Chen (陳威尹) authored
TabSwitcherCoordinator#getSoftCleanupDelayForTesting wrongly returned the value of getCleanupDelayForTesting. Bug: 983170 Change-Id: I5747b7e9bd8feee743de9268cc090820f5ec4ec8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916259Reviewed-by:
-
W. James MacLean authored
This test sometimes fails because it calls WaitForLoadStop() before the WebContents has even started to load ... making it return false since there is no previous navigation entry. This CL makes sure we don't call WaitForLoadStop until we know the guest has started to load. Bug: 1024672 Change-Id: Ia6babfa739adbc000093184bee71b445db4189ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917740Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: James MacLean <wjmaclean@chromium.org> Cr-Commit-Position: refs/heads/master@{#715391}
-
Sammie Quon authored
Old logic: windows that are not fully onscreen are not animated. Does not quite work when the window is partially offscreen and we fade in windows, in this case the partially offscreen windows should still animate. New logic: window that are partially offscreen will be clipped to their onscreen bounds and treated normally. Fully offscreen windows are never animated. Test: added test Bug: 1024665 Change-Id: I097364fa23e37872fdd3714dfb3c76229aeb68d2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917292Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#715390}
-
Yue Zhang authored
TabListContainerViewBinderTest#testShowWithAnimation is failing on Android CFI bot. This CL disables this test on Nexus 5X to skip this bot. Bug: 954145, 1023530 Change-Id: I386ada2bee2959568e4b9dc09913ee6fa8c3db10 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913171Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715389}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/1dbf452d7ecb..f34a9d2df428 git log 1dbf452d7ecb..f34a9d2df428 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 khokhlov@google.com Add --results-label command line option to run_metric Created with: gclient setdep -r src/third_party/catapult@f34a9d2df428 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC sadrul@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:945713 Change-Id: I75c136798a7ef98d41f08fb6d348d7deccdcbbe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917303Reviewed-by:
-
Mugdha Lakhani authored
to add a list of expected objects. Bug: 996664 Change-Id: I8b13a849a82687ae2d2c9f41856569391c02a35d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912206 Commit-Queue: Mike West <mkwst@chromium.org> Auto-Submit: Mugdha Lakhani <nator@chromium.org> Reviewed-by:
Mike West <mkwst@chromium.org> Cr-Commit-Position: refs/heads/master@{#715387}
-
Xianzhu Wang authored
Some that don't seem to be flaky are rebaselined if needed, and the [ Skip ] expectations are removed. For the rest that we don't know if they are flaky, the failure expectations are changed from [ Skip ] to the best guess of possible results. Should monitor these tests for some time and update the expectations and baselines according to the flakiness dashboard. Change-Id: Iaca86efb9d1490b7f6b07785a9ff4adb22aacec7 Bug: 680635, 377696, 769885, 591500, 722943, 922951 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915461 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Cr-Commit-Position: refs/heads/master@{#715386}
-
Joshua Peraza authored
The upload list is capped at 50 crashes. Previously, the already completed uploads were listed before the pending uploads. This patch places the pending uploads first so that it is possible for the user to see them and manually* trigger an upload. *The "send now" button does not actually send the report now. It schedules the dump for upload at a later time of the Job Scheduler's choosing. Bug: 1023836 Change-Id: Ided52abc451f4ac167dc9eb0db93d4ea32bdc090 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917689Reviewed-by:
Mark Mentovai <mark@chromium.org> Commit-Queue: Joshua Peraza <jperaza@chromium.org> Cr-Commit-Position: refs/heads/master@{#715385}
-
Joshua Peraza authored
0208c1a175e1 fuchsia: Don't capture incorrect/unreasonably large stacks 2291bfa32ef1 android, gyp: fix the build 74490f00a47b linux: roll lss and use sys_sigtimedwait/sys_sigprocmask Change-Id: I220c774c372f59303e62f1da5a1946549ce47cb8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1914901 Commit-Queue: Mark Mentovai <mark@chromium.org> Auto-Submit: Joshua Peraza <jperaza@chromium.org> Reviewed-by:
-
Matt Menke authored
Make the ProxyService API take a NetworkIsolationKey and pass it down to the ProxyResolver. Also make the main consumer actually pass in requests' NIK. Some other callsites still need to be updated to pass in NIKs. Also introduce new pattern of using NetworkIsolationKey::Todo() to create empty NetworkIsolationKeys() in places that should be modified to pass in populated NetworkIsolationKeys. Bug: 1021661 Change-Id: I4cd2a54fb68dea74cb9a3660b2b2d38f1a35f6f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1908922 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Cr-Commit-Position: refs/heads/master@{#715383}
-
Peter Kotwicz authored
BUG=None TBR=dominickn Change-Id: Ibf4ea006bacaae543bc1d3641d6e850ae35ad582 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917745Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Cr-Commit-Position: refs/heads/master@{#715382}
-
Reilly Grant authored
Bug: 1007782 Change-Id: I5bc515340e1836297565fa54f9b30124917126f9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916963 Auto-Submit: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#715381}
-
Vasiliy Telezhnikov authored
This CL fixes GLRenderer::RestoreGLState to DisableVertexAttribArray that Skia might enabled and not used in GLRenderer. Bug: 1021361 Change-Id: Ic7fab80058ebdea902dadc64edce647ede16517a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917680Reviewed-by:
Jonathan Backer <backer@chromium.org> Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Cr-Commit-Position: refs/heads/master@{#715380}
-
Rayan Kanso authored
Make sure the displayName is not null, which might cause crashes. Change-Id: Id98c778bba1354dd3e1a1def36f12082b49e5a07 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916969 Auto-Submit: Rayan Kanso <rayankans@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#715379}
-
Long Cheng authored
1. Show default ARC system app in launcher on tablet form factor devices when ARC is disabled by admin. 2. Show Chrome dialog when user tries to launch default ARC app. Dialog text lists in the bug. Bug: 1019519 Change-Id: I2fd2d98656880355d50daabd55ee300de772ee22 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1900249Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Commit-Queue: Long Cheng <lgcheng@google.com> Cr-Commit-Position: refs/heads/master@{#715378}
-
Ken Rockot authored
This migrates all Mojo interfaces exposed to the browser (by renderers) off of Service Manager APIs like ConnectionFilter. Instead RenderThreadImpl populates a BinderMap during initialization and passes it along to ChildThreadImpl::ExposeInterfacesToBrowser. NOPRESUBMIT=true Bug: 977637 Change-Id: If51249c2215046ce641151e486a034903e0878ae Tbr: boliu@chromium.org Tbr: groby@chromium.org Tbr: sky@chromium.org Tbr: xhwang@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907273 Commit-Queue: Ken Rockot <rockot@google.com> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#715377}
-
Mikel Astiz authored
The test suite already instantiates a FieldTrialList as per https://chromium-review.googlesource.com/c/chromium/src/+/1883567 so it's no longer necessary to do so explicitly in tests. This patch addresses unit tests under: /chrome/browser/ui/app_list This CL was uploaded by git cl split. R=khmel@chromium.org Bug: 1018667 Change-Id: Ie15d91cf04bff703c332ad2ee74d81cda8ec7457 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916472 Commit-Queue: Mikel Astiz <mastiz@chromium.org> Auto-Submit: Mikel Astiz <mastiz@chromium.org> Reviewed-by:
-
Jasper Chapman-Black authored
Since padding can change somewhat arbitrarily, SuperSize diff doesn't surface every individual symbol's padding shift - it aggregates padding changes by section, and gives them a name marking them as an overhead symbol. Unfortunately these symbols weren't being given a full_name, so they showed up in the Tiger viewer with no name or record of where they're from. Change-Id: I9c3056c4358ef487df4411047c98440d38bbeca6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1916687Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Jasper Chapman-Black <jaspercb@chromium.org> Auto-Submit: Jasper Chapman-Black <jaspercb@chromium.org> Cr-Commit-Position: refs/heads/master@{#715375}
-
Tommy Li authored
We can compute this on-demand rather than storing another piece of state we have to keep track of. I don't think this has a negative performance impact overall, as we rarely use the alternate nav URL (only on navigation basically). It does simplify the bookkeeping though, after removing this. Bug: 1016845, 363656 Change-Id: Ia32efb0b9bd83f591cc78f3304ad7521475402c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913241 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#715374}
-
Tommy Li authored
For file:// URLs on POSIX, we currently discard the host portion of the URL, and treat all file:// URLs as local. On Windows, we use the host portion as the SAMBA share, so this bug is inapplicable to Windows. This allows us to have URLs like: file://accounts.google.com/home/tommycli/Downloads/evil.html This is a low severity bug, since it's quite hard to exploit, but we should fix it anyways. RFC 8089 doesn't actually prohibit our previous behavior, but it does frown on it. This CL *could* break file:// links that relied on the old behavior, but those file:// links should probably be rightfully-broken, since they didn't work on Windows anyways. Bug: 881675 Change-Id: Ie9c90ac6285b698089205e73f46f0af13867e806 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1907071Reviewed-by:
Adam Langley <agl@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Reviewed-by:
Mohammad Refaat <mrefaat@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#715373}
-
Aran Gilman authored
This CL addresses the straightforward fixes surfaced by the CSS presubmit check. The less straightforward ones (discussed in https://crbug.com/1024894) should be addressed in future CLs. Bug: 1011485, 1024894 Change-Id: Id2fdd0fa4bebdfb9dc8b402ad177e8c33a6a9a21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1915039Reviewed-by:
-
Eldar Rello authored
Spec: https://w3c.github.io/webrtc-pc/#dom-peerconnection-setremotedescription Intent: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/OqPfCpC5RYU Bug: chromium:980875 Change-Id: I57afbb241adf4dbb08268e27b44f12d69c4fc39e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790443Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Henrik Boström <hbos@chromium.org> Commit-Queue: Eldar Rello <elrello@microsoft.com> Cr-Commit-Position: refs/heads/master@{#715371}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/4d4332ed66fa..d347d8903a96 git log 4d4332ed66fa..d347d8903a96 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 philipchen@google.com hatch: Add firmware builder 2019-11-14 mmortensen@google.com Add unit tests and mock responses for Binhost.GetBinhosts. Created with: gclient setdep -r src/third_party/chromite@d347d8903a96 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: I86d53a3e61fbaba09c1a7fd17ba0d1bdb2aa503f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917302Reviewed-by:
-
Garrett Beaty authored
This is expected to break the builders, but due to a cloud outage we don't have logs from the previous attempt. Change-Id: I8b726cf5ce43cde0feec83ee6c7c6c540a9e5253 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913199 Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Cr-Commit-Position: refs/heads/master@{#715369}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/6e687af2649d..968df09eed92 git log 6e687af2649d..968df09eed92 --date=short --no-merges --format='%ad %ae %s' 2019-11-14 timvp@google.com Treat VK_TIMEOUT as an error 2019-11-14 courtneygo@google.com Vulkan: Enable 3.0 as default context version 2019-11-14 courtneygo@google.com Vulkan: Add 565 and validate pixel formats: Windows Created with: gclient setdep -r src/third_party/angle@968df09eed92 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cnorthrop@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=cnorthrop@google.com Bug: None Change-Id: I223aa5208dc8dbef36d6e5aa60a1b12219de176b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917305Reviewed-by:
-
Ken Rockot authored
These are now exposed to the ChildProcess BindReceiver API on the UtilityProcessHost, via ChildThreadImpl::ExposeInterfacesToBrowser. Bug: 977637 Change-Id: Ib214f80d9ec3ae1e54fb63a04f06be77fa6fb7c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903594Reviewed-by:
-
Hitoshi Yoshida authored
Makes FunctionDefinitionNode render an initializer list. In case of rendering constructors, we may need an ininitializer list. This CL supports it. Bug: 839389 Change-Id: I65d5d47ac98803ce911d4dedc21d3d1207a40bca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1911883Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#715366}
-
Gang Wu authored
Value set to 44 in https://chromium-review.googlesource.com/c/chromium/src/+/1894050 But https://chromium-review.googlesource.com/c/chromium/src/+/1903844 used old value. Bug: 1011061 Change-Id: Ib01f0b5db05ae80c130486e043856b5c35d3867f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1917290Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#715365}
-
David Tseng authored
- makes the ChromeVox api only available to Docs, Sheets, and Slides. They use speak, stop, in braille mode off, and isChormeVoxActive in all modes. - removes the bulk of the classic background script, including dead command handlers. - remove dead classic earcons. - removes any other content script paths including prefs propagation. - refresh manifest with what's actually used. Test: manual. Change-Id: I5043657da78122cea106816335611bc6ffc108bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913170 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#715364}
-
David Black authored
Symptom: In tablet mode, clicking into the embedded web content that hosts Assistant Settings would cause a change in window focus. This change in window focus resulted in a change in AppList state back to kStateApps, making Assistant Settings unusable. The call to modify AppList state originated here: https://cs.chromium.org/chromium/src/ash/app_list/app_list_presenter_impl.cc?type=cs&q=applistpresenterimp&g=0&l=454 Solution: Resetting of AppList state occurred because AppList visibility incorrectly thought it was not visibility when showing Assistant. Now, visibility is updated when changing AppList states such that when Assistant is visible, AppList is rightly considered visible as well. Bug: b:144056527 Change-Id: I2613758d131c6621df5f61bdd66106399b8d7d9a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1903901 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
-
