GitLab

Behavior changes described here:
http://developer.android.com/about/versions/android-5.0.html

BUG=424680

TBR=aa@chromium.org

Review URL: https://codereview.chromium.org/664163003

Cr-Commit-Position: refs/heads/master@{#300506}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/9fbc3f3..dd5a1e0

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/665333002

Cr-Commit-Position: refs/heads/master@{#300505}

BUG=391005

Review URL: https://codereview.chromium.org/669733008

Cr-Commit-Position: refs/heads/master@{#300504}

BUG=424679
TEST=-

Review URL: https://codereview.chromium.org/665033003

Cr-Commit-Position: refs/heads/master@{#300503}

This was mostly done in https://codereview.chromium.org/668663006/, but:
* it missed things deriving from testing::Test for some reason;
* it didn't touch Windows-only files (for more obvious reasons).

R=sky@chromium.org
BUG=417463

Review URL: https://codereview.chromium.org/670743002

Cr-Commit-Position: refs/heads/master@{#300502}

This CL fixes a crash that occurs when ExtractPerHostZoomLevels is
called with a legacy per-host zoom level dictionary. In this case the
sanitization code will fail to find a partition key and subsequently
dereference a null pointer.

Since the legacy dictionary will be deleted immediately after the
function exits, we just skip the sanitization in this case.

BUG=424540

Review URL: https://codereview.chromium.org/665283002

Cr-Commit-Position: refs/heads/master@{#300501}

Chrome Actions are designed to be actions that live on the
toolbar, like extension actions, but are actually components
of Chrome. Examples of this can be ChromeCast, Translate,
Password Manager, etc. This change partially implements the basic
infrastructure for these actions.

(The main goal of this patch is to provide a shell that
the chromecast team can expand upon and use to prototype.)

* Create a generic ToolbarActionViewController, which can
  be implemented by a specific chrome action or to handle
  the general extensions case.
* (Mostly) abstract the concept of extensions out of the
  BrowserActionView, so it can be used for either extension
  actions or chrome actions.
* Create a simple ChromeActionsRegistry.
* Display chrome actions in the overflow menu of the browser
  actions container.

Known limitations:
* Chrome actions cannot be reordered, dragged, or shown in
  the main action toolbar (we need to consolidate chrome
  actions with the extension toolbar in the model somehow).

BUG=422976

Review URL: https://codereview.chromium.org/661493004

Cr-Commit-Position: refs/heads/master@{#300500}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=maniscalco@chromium.org

Review URL: https://codereview.chromium.org/642023004

Cr-Commit-Position: refs/heads/master@{#300499}

This reverts commit 8e84bfcc.

Original CL: https://codereview.chromium.org/637413003
Reason for Revert:
New test SyncBackendRegistrarShutdownTest.BlockingShutdown fails repeatedly
on android and causes other tests to hang.
Also fails on other bots.
http://chromium-build-logs.appspot.com/gtest_query?gtest_query=SyncBackendRegistrarShutdownTest.BlockingShutdown
Failures are timeouts, and don't have any useful logs or stack traces (sorry).

Reason for hand-revert: Conflict with crrev.com/0cd9ff92

NOTRY=true
TBR=stanisc@chromium.org
TBR=zea@chromium.org

-- Original CL Description --

Sync: Avoid deadlock in SyncBackendRegistrar / ModelSafeWorker on sync backend shutdown.

This deadlock involves SyncBackendRegistrar running on the sync thread and at least two
workers - one of them (worker A) running on UI thread and
another (worker B) running on some other background thread.
In this particular case it was a password worker running on Password model thread.

The deadlock occurs when the SyncBackendRegistrar shutdown
code running in the sync thread blocks on a waitable event
set by worker B, at the same time the worker B's thread is
blocked for whatever reason waiting to make a synchronous
call into the UI thread, and at the same time the worker A
is blocked on a lock owned by the sync thread while it attempts
to unregister itself with SyncBackendRegistrar.

I think the main issue here is that the sync thread might
block on a worker. This is possible in only one situation -
when that worker hasn't have a chance to run any tasks because
its own thread was blocked doing something else.

The fix removes this dependency. The only reason this
blocking occurs is because ModelSafeWorker has a mechanism
for subscribing / unsubscribing to the MessageLoop descruction
which has to be done in the right thread context.
In order to unsubscribe the worker needs to remember the message loop it runs on which is done
in SetWorkingLoopToCurrent callback, which is called from a task
posted on the worker's thread. There is also a waitable
event which is signalled at that time. The even is used to
block ModelSafeWorker::UnregisterForLoopDestruction from
delegating the call on an uninitialized message loop which
is possible only when SetWorkingLoopToCurrent has never been called.

There is no need to block in UnregisterForLoopDestruction.
If the registration for even loop destruction hasn't been
been done yet (because the thread is blocked) then there
really no reason to wait for that and then immediately
unsubscribe. We can skip both subscription to the even loop
notification altogether and let the registrar know that
it is OK to remove the worker. That's essentially what the
fix does.

I added a test that verifies that SyncBackendRegistrar::Shutdown
doesn't block on a blocked model type thread anymore.

BUG=423078
Committed: https://crrev.com/8e84bfcc1c33fc0b63392d48ee8288d73f4a7675
Cr-Commit-Position: refs/heads/master@{#300350}

Review URL: https://codereview.chromium.org/667573007

Cr-Commit-Position: refs/heads/master@{#300498}

BUG=422729
TEST=Manual, see bug

Review URL: https://codereview.chromium.org/635233008

Cr-Commit-Position: refs/heads/master@{#300497}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

The generator for the GLES2 command buffers has also been updated.

BUG=417463
TBR=piman@chromium.org

Review URL: https://codereview.chromium.org/663363002

Cr-Commit-Position: refs/heads/master@{#300496}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=rogerta@chromium.org

Review URL: https://codereview.chromium.org/649283003

Cr-Commit-Position: refs/heads/master@{#300495}

Revert of [chromedriver] Set mobile=true when calling setDeviceMetricsOverride (patchset #1 id:1 of https://codereview.chromium.org/668783002/)

Reason for revert:
This is breaking mobile emulation tests (testDeviceMetrics and testDeviceName). For some reason, window.innerHeight/innerWidth get reported incorrectly when this patch is applied.

Original issue's description:
> [chromedriver] Set mobile=true when calling setDeviceMetricsOverride
>
> BUG=chromedriver:944
> TBR=stgao@chromium.org
>
> Committed: https://crrev.com/02d008b0ee86ef7037833d27cf92b45f9125f097
> Cr-Commit-Position: refs/heads/master@{#300390}

TBR=srawlins@google.com,stgao@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=chromedriver:944

Review URL: https://codereview.chromium.org/666173002

Cr-Commit-Position: refs/heads/master@{#300494}

BUG=425570
TBR=bradnelson@chromium.org
NOTRY=true

Review URL: https://codereview.chromium.org/647793003

Cr-Commit-Position: refs/heads/master@{#300493}

$ git log a57d7db40..021963987 --date=short --format='%ad %ae %s' | sed 's/@chromium\.org//'
2014-10-17 maruel Add --idempotent support now that the server supports it.
2014-10-17 maruel Fix a client side failure when a task completely blows up.

TBR=vadimsh@chromium.org
BUG=

Review URL: https://codereview.chromium.org/666673008

Cr-Commit-Position: refs/heads/master@{#300492}

Initializaing chromeos::Network triggers a whole bunch of things that are
not necessary or useful in tests. So avoid initializing this subsystem, since
none of the tests depend on it. Tests that do depend on this in the future
should explicitly initialize this from SetUp().

This change brings down the runtime of athena_unittests significantly.

BUG=412535
R=oshima@chromium.org

Review URL: https://codereview.chromium.org/653853004

Cr-Commit-Position: refs/heads/master@{#300491}

Summary of changes available at:
https://chromium.googlesource.com/skia/+log/b0e89dc..9fbc3f3

CQ_EXTRA_TRYBOTS=tryserver.blink:linux_blink_rel,linux_blink_dbg
TBR=mtklein@google.com

Review URL: https://codereview.chromium.org/645793004

Cr-Commit-Position: refs/heads/master@{#300490}

BUG=387613
R=nkostylev@chromium.org

Review URL: https://codereview.chromium.org/614973002

Cr-Commit-Position: refs/heads/master@{#300489}

This limits the amount of code that must be reentrant in the case of
nested message loops. In particular libgestures is not reentrant; this
fixes getting some modifiers stuck down with a context menu open.

BUG=418787
TEST=manual on link_freon

Review URL: https://codereview.chromium.org/661353006

Cr-Commit-Position: refs/heads/master@{#300488}

Revert of [Base] Use variadic template in callback_list.h (wave 1) (patchset #1 id:1 of https://codereview.chromium.org/618573002/)

Reason for revert:
Breaking compilation on windows with MSVC Express.

Original issue's description:
> [Base] Use variadic template in callback_list.h
>
> Replace pump.py generated base/callback_list.h with variadic template version.
>
> BUG=None
>
> Committed: https://crrev.com/a28756fae426023c53542f08c1bf80397a28f677
> Cr-Commit-Position: refs/heads/master@{#298529}

TBR=ajwong@chromium.org,tzik@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=None

Review URL: https://codereview.chromium.org/663083005

Cr-Commit-Position: refs/heads/master@{#300487}

When running android instrumentation tests through test_runner, the
exclude_annotations rules will now take precedence over the test
filters, instead of being ignored.

BUG=425297

Review URL: https://codereview.chromium.org/668793002

Cr-Commit-Position: refs/heads/master@{#300486}

TBR=machenbach@chromium.org

Review URL: https://codereview.chromium.org/653633006

Cr-Commit-Position: refs/heads/master@{#300485}

Also fixes a couple issues with the shortcutting of
RenderFrameHostImpl::OnBeforeUnloadACK in case there's no actual IPC call. The main issue was that when there was no active renderer these calls inside RenderFrameHostImpl::OnBeforeUnloadACK would be executed without the prior due mirror calls:
  render_view_host_->decrement_in_flight_event_count();
  render_view_host_->StopHangMonitorTimeout();

BUG=416877

Review URL: https://codereview.chromium.org/659773002

Cr-Commit-Position: refs/heads/master@{#300484}

This unblocks rolling WebRTC, since it depends on
libyuv and cannot use the dependency to ppapi, which
was removed in https://code.google.com/p/libyuv/source/detail?r=1130.

BUG=libyuv:374

Review URL: https://codereview.chromium.org/666103002

Cr-Commit-Position: refs/heads/master@{#300483}

After landing of https://codereview.chromium.org/600263002,
RendererAccessibilityFocusOnly class is no longer necessary.
So we can remove it and related codes.

BUG=417758

Review URL: https://codereview.chromium.org/651593002

Cr-Commit-Position: refs/heads/master@{#300482}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=agl@chromium.org

Review URL: https://codereview.chromium.org/645623006

Cr-Commit-Position: refs/heads/master@{#300481}

Review URL: https://codereview.chromium.org/670713002

Cr-Commit-Position: refs/heads/master@{#300480}

> Added incident report for variations seed signature mismatch.
>
> - Keep record of a bad signature in VariationsSeedStore::LoadSeed.
> - Register VerifyVariationsSeedSignature in SafeBrowsingService::RegisterAllDelayedAnalysis to send an incident report, if a bad signature is encountered.
>
> BUG=423467
>
> Review URL: https://codereview.chromium.org/646733002
>
> Cr-Commit-Position: refs/heads/master@{#299964}

This reverts commit 37907039 because it
accesses g_browser_process->variations_service() off of the main thread,
leading to a DCHECK.

BUG=423467
TBR=grt@chromium.org

Review URL: https://codereview.chromium.org/664333002

Cr-Commit-Position: refs/heads/master@{#300479}

Cr-Commit-Position: refs/heads/master@{#300478}

BUG=405566
TBR=pfeldman

Review URL: https://codereview.chromium.org/663373002

Cr-Commit-Position: refs/heads/master@{#300477}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=msw@chromium.org

Review URL: https://codereview.chromium.org/671653002

Cr-Commit-Position: refs/heads/master@{#300476}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=yoz@chromium.org

Review URL: https://codereview.chromium.org/664933004

Cr-Commit-Position: refs/heads/master@{#300475}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=mek@chromium.org

Review URL: https://codereview.chromium.org/666153002

Cr-Commit-Position: refs/heads/master@{#300474}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=jamesr@chromium.org

Review URL: https://codereview.chromium.org/670683003

Cr-Commit-Position: refs/heads/master@{#300473}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=jamiewalch@chromium.org

Review URL: https://codereview.chromium.org/667123002

Cr-Commit-Position: refs/heads/master@{#300472}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=ddorwin@chromium.org

Review URL: https://codereview.chromium.org/655713003

Cr-Commit-Position: refs/heads/master@{#300471}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=mpcomplete@chromium.org

Review URL: https://codereview.chromium.org/668663006

Cr-Commit-Position: refs/heads/master@{#300470}

This patch was automatically generated by applying clang fixit hints
generated by the plugin to the source tree.

BUG=417463
TBR=sky@chromium.org

Review URL: https://codereview.chromium.org/667943003

Cr-Commit-Position: refs/heads/master@{#300469}

BUG=404694
R=earthdok@chromium.org

Review URL: https://codereview.chromium.org/637953005

Cr-Commit-Position: refs/heads/master@{#300468}

BUG=417463
TBR=asanka@chromium.org

Review URL: https://codereview.chromium.org/665253002

Cr-Commit-Position: refs/heads/master@{#300467}