- 27 Mar, 2015 40 commits
-
-
simonhong authored
This cl is last partial cl from https://codereview.chromium.org/775143003/ for easy review. Until now, BeginFrame is initiated by each renderer process. With this cl, BeginFrame is scheduled from parent(browser) cc scheduler to child(renderer) cc scheduler. For more detailed information, please see this (http://goo.gl/D1Qxrr) Also, --enable-begin-frame-scheduling is no longer needed because all platform except Mac uses it as a default. R=brianderson@chromium.org, danakj@chromium.org, mithro@mithis.com BUG=372086 Review URL: https://codereview.chromium.org/1016033006 Cr-Commit-Position: refs/heads/master@{#322622}
-
vitalybuka authored
base::TerminateBecauseOutOfMemory will call base::::OnNoMemory which is classified by breakpad server as OOM crash. We have a lot of variations of crashes which are expected OOM crashes. Combining them into one class of crashes helps to discard them triaging crashes. BUG=429763,460995 Review URL: https://codereview.chromium.org/1039043002 Cr-Commit-Position: refs/heads/master@{#322621}
-
pcc authored
On OS X the declaration of the close function looks like this: int close(int) __asm("_close" optional extra stuff); If we do not include unistd.h the close_nocancel.cc translation unit does not see the asm label. This is technically an ODR violation, but not normally a significant one, because close will get mangled to _close by the compiler anyway. However under LLVM LTO the mangled symbol is internally given a different name to the unmangled symbol, and the linker gets confused by the multiple declarations with the same mangled name. This also lets us simplify this code by defining the close function itself (which will receive its name from the asm label in the declaration) rather than trying to guess what the extra stuff is and naming the function we define after that. BUG=471146 R=thakis@chromium.org,mark@chromium.org Review URL: https://codereview.chromium.org/1036123003 Cr-Commit-Position: refs/heads/master@{#322620}
-
eroman authored
BUG=470704 Review URL: https://codereview.chromium.org/1037043002 Cr-Commit-Position: refs/heads/master@{#322619}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/5c3405c..bb055b9 TBR=pkasting@chromium.org,yutak@chromium.org Review URL: https://codereview.chromium.org/1042493002 Cr-Commit-Position: refs/heads/master@{#322618}
-
tandrii authored
BUG=470741 R=iannucci@chromium.org Review URL: https://codereview.chromium.org/1015633005 Cr-Commit-Position: refs/heads/master@{#322617}
-
rtenneti authored
A number of fixes to please clang_tidy. There should be no functional changes. Putting the construction of a "null" SerializedPacket into a function rather than constructing one into a local variable everywhere one is needed. Renaming class members to end with "_". Taking the initial "k" off local variables. Merge internal change: 89397417 https://codereview.chromium.org/1039473003/ Move test for incoming packets with incorrect connection ID from QuicConnection::OnPacketHeader to ::OnUnauthenticatedPublicHeader so it works. Add tests to verify code handles incoming packets with invalid connection IDs. Add DCHECKs to verify that QuicConnection::OnPublicResetPacket and ::OnVersionNegotiationPacket don't get packets with invalid connection IDs. Add comment to QuicConnection::ProcessUdpPacket to note packet may have incorrect connection ID. Fix b/19710533. Merge internal change: 89336249 https://codereview.chromium.org/1038293002/ Fix a flaky QUIC end to end test by supplying the correct buffer size as the initial default. Merge internal change: 89220759 https://codereview.chromium.org/1038223002/ Initialize slowstart_packets_sent. Avoid uninitialized memory. Merge internal change: 89126237 https://codereview.chromium.org/1036123002/ QUIC - minor cleanup while merging the following change. In Chromium's AddToCache function, we use "www.google.com" instead of empty path as it was done in the internal CL. All other changes were already merged by rch. Make some changes to the QuicInMemory server to clarify the interface. Specifically that the cache is indexed by host and path, not by method nor scheme, nor full URL, nor request headers, etc. In preparation for making the chrome version more similar. Merge internal change: 89092881 https://codereview.chromium.org/1038203002/ R=rch@chromium.org Review URL: https://codereview.chromium.org/1041853002 Cr-Commit-Position: refs/heads/master@{#322616}
-
ericrk authored
This change removes SetDrawViewport, instead tracking the current window viewport in DirectRenderer. Review URL: https://codereview.chromium.org/1035863002 Cr-Commit-Position: refs/heads/master@{#322615}
-
rtenneti authored
Merge internal change: 89221001 R=rch@chromium.org Review URL: https://codereview.chromium.org/1037133002 Cr-Commit-Position: refs/heads/master@{#322614}
-
slamm authored
Update tests so they check for formatted exceptions (so they will catch a bug such as this one). BUG=444240 Review URL: https://codereview.chromium.org/1041843002 Cr-Commit-Position: refs/heads/master@{#322613}
-
skia-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/skia/+log/1e37d17..939253e CQ_INCLUDE_TRYBOTS=tryserver.blink:linux_blink_rel TBR=hcm@google.com Review URL: https://codereview.chromium.org/1043493002 Cr-Commit-Position: refs/heads/master@{#322612}
-
enne authored
You can't assume that there's a root layer always during layout, even if there's a composite and readback. WebTestProxyBase::CapturePixelsAsync iterates through popups (which may get closed between that call and Layout). If it's closed, then its root layer goes away. BUG=470817 Review URL: https://codereview.chromium.org/1038133003 Cr-Commit-Position: refs/heads/master@{#322611}
-
dalecurtis authored
Fixes hitting the maximum connection limit of 6 per domain when a media tag is used with preload=metadata. Deferred network connections will be cancelled once reaching the HAVE_ENOUGH_DATA state for preload=metadata, non-streaming resources that have not started playback. A soft cancel is introduced which allows us to preserve the data cached thus far in the BufferedResourceLoader. Once this cache is exhausted the loader will fulfill subsequent reads with a cache miss and continue on as normal. preload=metadata intentionally does not cache enough data for a smooth playback experience on slow connections, so the cache miss here does not increase jank relative to the current status quo. For similar reasons, since preload=auto does load enough data for an uninterrupted playback, we can't use this method there or we'll introduce jank during the cache miss and subsequent catch up. Note: This does not resolve hung connections if multiple media elements are actually playing back or if they are served from a server without range requests. Note 2: This also fixes a broken media_blink_unittests, which was missing some Gin dependency. BUG=162627 TEST=new unittest, passes layout tests. Review URL: https://codereview.chromium.org/1029763002 Cr-Commit-Position: refs/heads/master@{#322610}
-
robliao authored
Local profiling suggests that converting std::set to std::vector will save around 10% of the overall startup time, likely due to the reduced allocs involved with std::vector. This change also reduces lookups by traversing the incoming dictionary and iterating on the available values instead of looking through all values for all features. Finally, cleaned up and enforced the testing accessors via code and friend declarations BUG=460987 Review URL: https://codereview.chromium.org/1010973013 Cr-Commit-Position: refs/heads/master@{#322609}
-
erikchen authored
The extension profile generator and its subclasses have been in various states of broken for quite some time. Removing them entirely. BUG=444230 Review URL: https://codereview.chromium.org/1036373002 Cr-Commit-Position: refs/heads/master@{#322608}
-
spang authored
Use the captured description of the touchscreen for Chromebook Pixel to initialize the mock touchscreen, instead of just faking a couple of the members and leaving the rest uninitialized. The press, release, & move tests are merged into one test using real captured data from the Pixel touchscreen. The other tests just got their "pressure" values rescaled to the new axis. Now we can add a test that pases in a non-MT device description. BUG=461518 TEST=events_unittests Review URL: https://codereview.chromium.org/1019803006 Cr-Commit-Position: refs/heads/master@{#322607}
-
qiangchen authored
Test= FakeVideoCaptureDeviceTest in media_unittests Review URL: https://codereview.chromium.org/1033733009 Cr-Commit-Position: refs/heads/master@{#322606}
-
sadrul authored
The CL was previously reverted in crrev.com/322355 because it broke downstream android builds. This is a straight-forward reland of the original issue. A fix will be landed for downstream once this CL lands. Original issue's description: > > precache: Move the java files into //components/precache/android > > > > This moves code out of //java/apps/chrome/.../precache into: > > . //components/precache/android/: classes that provide information about > > device-state, network connectivity etc. > > . //chrome/android/.../precache/: precache service and service launchers. > > > > BUG=401552 TBR=bengr@chromium.org,yfriedman@chromium.org,thestig@chromium.org,alexclarke@chromium.org NOPRESUBMIT=true BUG=401552 Review URL: https://codereview.chromium.org/1036363002 Cr-Commit-Position: refs/heads/master@{#322605}
-
tengs authored
This tool is based on telemetry and exercises the Smart Lock setup flow. This CL also introduces the framework that will allow implementing other end-to-end tests. BUG=chromium:442728 NOTRY=true Review URL: https://codereview.chromium.org/1004283002 Cr-Commit-Position: refs/heads/master@{#322604}
-
ianwen authored
Upper case letters for all words is not Android style. BUG=NONE Review URL: https://codereview.chromium.org/1029423011 Cr-Commit-Position: refs/heads/master@{#322603}
-
xdai authored
Reland of "Decrease the lag when switching between different categories in the Cros wallpaper selector". The original one (https://codereview.chromium.org/1028513003) caused failures in the cros_trunk official builder (see http://master.chrome.corp.google.com:8011/builders/cros%20trunk/builds/31816 for detail). The issue should fix the broken tests. BUG=454932 Review URL: https://codereview.chromium.org/1038543002 Cr-Commit-Position: refs/heads/master@{#322602}
-
dgozman authored
BUG=470453 Review URL: https://codereview.chromium.org/1039543003 Cr-Commit-Position: refs/heads/master@{#322601}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/7bc68ec..5c3405c TBR=pkasting@chromium.org,yutak@chromium.org Review URL: https://codereview.chromium.org/1039233003 Cr-Commit-Position: refs/heads/master@{#322600}
-
spang authored
These are currently DLOG() but we really shouldn't be hiding them. Also use PLOG() when we know errno will be set. BUG=none TEST=build Review URL: https://codereview.chromium.org/1032233002 Cr-Commit-Position: refs/heads/master@{#322599}
-
timvolodine authored
The test appears to be flaky on https://uberchromegw.corp.google.com/i/clank/builders/instrumentation-hammerhead-clankium-hera BUG=471211 TBR=peter@chromium.org Review URL: https://codereview.chromium.org/1036353003 Cr-Commit-Position: refs/heads/master@{#322598}
-
vabr authored
This changes the code for enabling password manager in chrome://settings. Currently, it only changes the .checked property of the associated checkbox. That does not trigger the update in preferences, one has to .click() the checkbox. BUG=369521 Review URL: https://codereview.chromium.org/1043453002 Cr-Commit-Position: refs/heads/master@{#322597}
-
knn authored
BUG=470877 Review URL: https://codereview.chromium.org/1038903002 Cr-Commit-Position: refs/heads/master@{#322596}
-
halliwell authored
This is a refactoring of our existing Ozone implementations to extract the common parts: implementing the single-full-screen-window assumption, stubbing out the bits of Ozone we don't use, and the GPU resource relinquish logic. Implementing Ozone for new hardware is now a lot simpler - just implement the ChromecastEglPlatform interface. For now, each platform still has to define the Ozone constructor function themselves, supplying an instance of the ChromecastEglPlatform subclass. BUG= Review URL: https://codereview.chromium.org/1025453002 Cr-Commit-Position: refs/heads/master@{#322595}
-
torne authored
We no longer build with the Android.mk build system, and so we don't need the special case to handle it not renaming resources when the APK package name is renamed. BUG=447666 Review URL: https://codereview.chromium.org/1040743002 Cr-Commit-Position: refs/heads/master@{#322594}
-
gayane authored
Added a histogram to log the network connection type for each successful metrics log upload. Will be used to monitor cellular uploads on Chrome on Android. BUG=455847 Review URL: https://codereview.chromium.org/1033493002 Cr-Commit-Position: refs/heads/master@{#322593}
-
earthdok authored
Make the list of libraries which are built from source match the list of pre-built libraries which are downloaded from GCS. BUG=none TBR=glider@chromium.org Review URL: https://codereview.chromium.org/1039723002 Cr-Commit-Position: refs/heads/master@{#322592}
-
lionel.g.landwerlin authored
BUG=470517 Review URL: https://codereview.chromium.org/1041803002 Cr-Commit-Position: refs/heads/master@{#322591}
-
torne authored
We no longer support building WebView with the Android build system; delete the makefiles and makefile generation scripts used for this. BUG=440793 TBR=brettw@chromium.org Review URL: https://codereview.chromium.org/1033263002 Cr-Commit-Position: refs/heads/master@{#322590}
-
knn authored
This was broken on M42 as it was being called before JNI registration. However that code has been moved since then and it should and is working fine post M42. BUG=467938 Review URL: https://codereview.chromium.org/1034403003 Cr-Commit-Position: refs/heads/master@{#322589}
-
lazyboy authored
This was done previously accessing array by index, which is brittle b/c this depends on the ordering of the events in web_view_internal.json. BUG=None Test=None, internal only cleanup. Review URL: https://codereview.chromium.org/1039043003 Cr-Commit-Position: refs/heads/master@{#322588}
-
blink-deps-roller authored
Summary of changes available at: https://chromium.googlesource.com/chromium/blink/+log/6b1db99..7bc68ec TBR=pkasting@chromium.org,yutak@chromium.org Review URL: https://codereview.chromium.org/1034413002 Cr-Commit-Position: refs/heads/master@{#322587}
-
knn authored
BUG=471229 Review URL: https://codereview.chromium.org/1039233002 Cr-Commit-Position: refs/heads/master@{#322586}
-
timvolodine authored
Revert of Remove Qualcomm MSAA from blacklist for versions >= Lollipop. (patchset #2 id:20001 of https://codereview.chromium.org/1034933002/) Reason for revert: speculative revert, this probably broke the instrumentation-hammerhead-clankium-lmp bot: https://uberchromegw.corp.google.com/i/clank/builders/instrumentation-hammerhead-clankium-lmp also see crbug.com/471200. Original issue's description: > Remove Qualcomm MSAA from blacklist for versions >= Lollipop. > > BUG=449116 > > Committed: https://crrev.com/1e8ac18cbd0e503335e5062a677609c38d75f1be > Cr-Commit-Position: refs/heads/master@{#322472} TBR=kbr@chromium.org,senorblanco@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=449116 Review URL: https://codereview.chromium.org/1037303002 Cr-Commit-Position: refs/heads/master@{#322585}
-
knn authored
This is a cleanup change that removes support for the depfile based on first grit output. BUG=466315 Review URL: https://codereview.chromium.org/1030383003 Cr-Commit-Position: refs/heads/master@{#322584}
-
dmazzoni authored
Depends on: https://codereview.chromium.org/1020473004 BUG=323462 Review URL: https://codereview.chromium.org/1015403002 Cr-Commit-Position: refs/heads/master@{#322583}
-