- 29 Jul, 2019 40 commits
-
-
Andrew Grieve authored
This reverts commit 8f06819d. Reason for revert: Fixed missing file.close() The new script makes it easy to measure a set of archived .apks. Add to resource_sizes.py the ability to output to stdout and fixes up some warning messages it was showing. Bug: 988127 Change-Id: Ifed112d594ba53073167627e01a446f85b6233c2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724444Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#681852}
-
Mia Bergeron authored
This CL creates a MediaControlsProgressView class and adds an instance to the CrOS lock screen media controls UI. LockScreenMediaControlsView uses MediaSessionPositionChanged to pass the playback/position info to MediaControlsProgressView. The progress view then continually updates the progress bar/time as time progresses. The placement of this view on the UI isn't critical right now as it will be changing in the near future. Bug: 965573 Change-Id: I2da5e864130ec371a58c623006ab7773f9bbe09c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721321Reviewed-by:
Becca Hughes <beccahughes@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Mia Bergeron <miaber@google.com> Cr-Commit-Position: refs/heads/master@{#681851}
-
Rayan Kanso authored
The feature is currently Android only. Restricting the Runtime flag on Android would make it easier to feature detect. Bug: 986296 Change-Id: Ie2ccda494cbdedf62cfd18bf105db97c522eaa55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722965Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Rayan Kanso <rayankans@chromium.org> Cr-Commit-Position: refs/heads/master@{#681850}
-
Scott Violet authored
gfx::Rect holder_bounds(bounds().size()); holder_bounds.Inset(GetInsets()); is equivalent to GetContentsBounds(). BUG=none TEST=none Change-Id: I1d49e0e8c3d1b421d44802001ec8a123e26fd7d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724789Reviewed-by:
Peter Boström <pbos@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#681849}
-
gogerald authored
Bug: 982018 Change-Id: I04d91296f3115848e75e6e6af80a03c5cb826a44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719167 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Auto-Submit: Ganggui Tang <gogerald@chromium.org> Cr-Commit-Position: refs/heads/master@{#681848}
-
Omer Katz authored
One existing remaining usage of ObjectResurrectionForbiddenScope was replaced with NoAllocationScope. Bug: 981414 Change-Id: Ie5bf7ba2c92206a397482040c47e8840b624f5b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722844Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Omer Katz <omerkatz@chromium.org> Cr-Commit-Position: refs/heads/master@{#681847}
-
Peter Kotwicz authored
- This CL changes the back button when a user is in a WebAPK from using Activity#finish() to using Activity#finishAndRemoveTask() - Activity#finishAndRemoveTask() is still used if the user pressed back while the splash screen is up because WebApkActivity is still translucent at this point and Activity#finish() causes an ugly transition when WebApkActivity is translucent. BUG=982956 Change-Id: Ie39b2c6902bef2d22e6052a47013f15975fbb611 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717556 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Pavel Shmakov <pshmakov@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Cr-Commit-Position: refs/heads/master@{#681846}
-
Raymond Toy authored
Thsi method is defined but never used anywhere. Remove it. Bug: 987776 Change-Id: I2a4cd6fb3e9f15f1fc8c65cccef0bcb6aef51359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1719002Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#681845}
-
Leonard Grey authored
Bug: 982477 Change-Id: I679756c46806d98f2348f33618b4737c36d8083a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724690Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#681844}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/bac9d6cd..db2b6ca2 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: If049698f87e148974523fd45766a09abbcd347f4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724653Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681843}
-
Andrew Grieve authored
Identified as unused by Android's ResourceShrinker tool. Code Search seems to agree. Bug: 988047 Change-Id: I46153fe72089491a50b71d0b503af2e9719851c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721323 Commit-Queue: Matthew Jones <mdjones@chromium.org> Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#681842}
-
Mohamed Amir Yosef authored
This is a reland of 806315e6 It was reverted due to crbug.com/988010 The underlying issue was unrelated to that patch and has been fixed in https://chromium-review.googlesource.com/c/chromium/src/+/1722841 No changes are introduced and hence TBR'ing original reviewers. Original change's description: > [Sync::USS] Allow Sync USS Passwords for Linux > > Sync USS Password on Linux has been unblocked by recent migrations > in the PasswordManager team that are concluded in the parent CL. > This CL is enabling the about flags for Linux and it enables it by > default for all linux bots. > > Change-Id: Ic94267ab0e9e4cce2ac2b02f1dfa9a0a9046e902 > Bug: 902349 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718332 > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Reviewed-by: Brian White <bcwhite@chromium.org> > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Reviewed-by: Marc Treib <treib@chromium.org> > Cr-Commit-Position: refs/heads/master@{#681044} TBR=bcwhite@chromium.org,mastiz@chromium.org,treib@chromium.org Bug: 902349 Change-Id: Ife0d61a4d2cd85be464e62b3653be1cfb69f3aa3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722842Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#681841}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/630443aba2b4..96ea8c00e70c git log 630443aba2b4..96ea8c00e70c --date=short --no-merges --format='%ad %ae %s' 2019-07-29 mbonadei@webrtc.org Roll chromium_revision 67eba1f6..3c3851d3 (681379:681486) + JNI fix Created with: gclient setdep -r src/third_party/webrtc@96ea8c00e70c The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: Iec08a348552d474be4c0517f3292b9349b00b072 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723573Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681840}
-
Miguel Casas authored
crrev.com/c/1588933 added P010 to viz::ResourceFormat [1] but forgot to add it to the mojom version of that enum [2]. This CL does that -- I stumbled upon it on deserialization. [1] https://cs.chromium.org/chromium/src/components/viz/common/resources/resource_format.h?type=cs&sq=package:chromium&g=0&l=33 [2] https://cs.chromium.org/chromium/src/services/viz/public/mojom/compositing/transferable_resource.mojom?q=transferable_resource.mojom&sq=package:chromium&dr&l=34 Bug: 911754 Change-Id: I465d3bc02b8c46339b1554350490fc4c0208ff2b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724651Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#681839}
-
Mustaq Ahmed authored
Bug: 959850, 161068 Change-Id: I189a31fe0f9a75ef10f6ff10479c23aba48a9327 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716966 Commit-Queue: Mustaq Ahmed <mustaq@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#681838}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/ecd71dad4bd5..23018617a031 git log ecd71dad4bd5..23018617a031 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 treehugger-gerrit@google.com Merge "Ignore Bazel build artifacts" Created with: gclient setdep -r src/third_party/perfetto@23018617a031 The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=perfetto-bugs@google.com Bug: None Change-Id: I900323de8c47a67bd4fed0be5420054ddf32cf62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723574Reviewed-by:
-
Takuto Ikuta authored
android is not used as builder nor test trigger. Change-Id: Icd68ccf2d53a05c34f4df81e13c66098c460f283 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723511Reviewed-by:
Ben Pastene <bpastene@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Auto-Submit: Takuto Ikuta <tikuta@chromium.org> Cr-Commit-Position: refs/heads/master@{#681836}
-
Ben Kirchman authored
To minimize code duplication, code that can be shared between the JavaUrlRequest and the FakeUrlRequest should be moved to a new shared file: JavaUrlRequestUtils. Context:https://chromium-review.googlesource.com/c/chromium/src/+/1703325 Bug: 669707 Change-Id: Id0dda127694090504f26b083bf4c561ee902cef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721771Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Commit-Queue: Benjamin Kirchman <kirchman@google.com> Cr-Commit-Position: refs/heads/master@{#681835}
-
Glenn Hartmann authored
Peter's made a lot of contributions over multiple years. I think he'd be a valuable OWNER for this code. Change-Id: Ia1791868c2bec8aa234b21facd8718080fdfc6d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721831Reviewed-by:
-
Pauline Leitao authored
Node titles are not being shown in Sync Node Browser due to an issue with EntityData field renaming, under the CL in [1]. This CL fixes this issue. [1] https://chromium-review.googlesource.com/c/chromium/src/+/1648168 Bug: 984956 Change-Id: I9b54517cf6d6b1070e98777581db3ab7f7f8100d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706520 Commit-Queue: Pauline Leitao <psivieroleitao@google.com> Reviewed-by:
-
Dominic Battre authored
The LogBuffer distinguishes between two types of node in a tree that is ultimately converted to a DOM: Elements (think of this as HTML tags) and Text Nodes. Before this CL it was possible to do the following: Log() << "Foo" << "Bar"; This would create a text node with content "Foo" and give it a child "Bar". As HTML does not allow a text node to have children, "Bar" would never appear in chrome://autofill-internals. The correct code in this case would be: Log() << Tag{"div"} << "Foo" << "Bar"; To make the code clearer, the term "node" in the code has been replaced with "element": In HTML, Nodes are the super set of Element (tags) and Text Nodes. At some point, we could support HTML Fragments, which would enable use to support the Log() << "Foo" << "Bar" syntax without requiring to explicitly add a Tag{"div"} before the "Foo". Bug: 928595 Change-Id: I778a025c853dc0a39f41675d57a381ba11c13975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722534Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Dominic Battré <battre@chromium.org> Cr-Commit-Position: refs/heads/master@{#681832}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/3575550a711b..8d269bac7c4a git log 3575550a711b..8d269bac7c4a --date=short --no-merges --format='%ad %ae %s' 2019-07-29 bclayton@google.com Fix build of tests/fuzzers. 2019-07-29 bclayton@google.com Reactor: Use std::shared_ptr to ref-count rr::Routines Created with: gclient setdep -r src/third_party/swiftshader@8d269bac7c4a The AutoRoll server is located here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=swiftshader-team+autoroll@google.com Bug: chromium:b/137524292,chromium:b/137649247,chromium:b/137524292,chromium:b/137649247 Change-Id: I3366f9da6034ab7416c1cda411f24c5921fcda38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724116Reviewed-by:
-
Stephane Zermatten authored
http://crrev/c/1715273 introduced fields with tag numbers that conflict with the server's. This change fixes that on the client side. Bug: b/138276952 Change-Id: I7e38f18715ad5fafe5271949495c50156e38562f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1722542Reviewed-by:
Jordan Demeulenaere <jdemeulenaere@chromium.org> Commit-Queue: Stephane Zermatten <szermatt@chromium.org> Cr-Commit-Position: refs/heads/master@{#681830}
-
Etienne Bergeron authored
PlatformFontWin is enforcing a minimal font size. see: https://cs.chromium.org/chromium/src/ui/gfx/platform_font_win.cc?l=292 The PlatformFontSkiaOnWindows experiment is using the PlatformFontSkia on Windows. But this implementation doesn't enfore the minimal font size. This CL is adding the call to win::AdjustFontSize(...) which is responsible to ensure the minimal size is respected. This CL is fixing the unittest |FontTest.DeriveResizesIfSizeTooSmall| when running with the PlatformFontSkiaOnWindows experiment. [ RUN ] FontTest.DeriveResizesIfSizeTooSmall ../../ui/gfx/font_unittest.cc(152): error: Expected equality of these values: 5 derived_font.GetFontSize() Which is: 4 R=robliao@chromium.org, asvitkine@chromium.org Bug: 944227 Change-Id: I99ad1ce651183cd488719b48791f9f056e6471e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710013Reviewed-by:
Dana Fried <dfried@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Cr-Commit-Position: refs/heads/master@{#681829}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/b98f0faa4d0b..10fe83305a04 git log b98f0faa4d0b..10fe83305a04 --date=short --no-merges --format='%ad %ae %s' 2019-07-29 cwallez@chromium.org Metal: Pack vertex buffers just after the pipeline layout Created with: gclient setdep -r src/third_party/dawn@10fe83305a04 The AutoRoll server is located here: https://autoroll.skia.org/r/dawn-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel TBR=cwallez@google.com Bug: None Change-Id: I0285f4c8ca9921ca3f1d104a0768eb4b2d1c798c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724115Reviewed-by:
-
Jérôme Lebel authored
Without Unified Consent, the advanced sign-in settings is opened by the main controller. Before opening the view, -[SigninInteractionCoordinator signinDoneWithSuccess:] is called and then the main controller is called. The issue is the presenting view controller has been removed by |signinDoneWithSuccess:|, and the main controller was called with nil. This bug has been introduced with crrev.com/c/1702264. Bug: 987374 Change-Id: Ibd1c754d92b3676db1a013e6c9c1d4a9c35d265d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724670 Auto-Submit: Jérôme Lebel <jlebel@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#681827}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/33f77d35ca2c..96827b125f3a git log 33f77d35ca2c..96827b125f3a --date=short --no-merges --format='%ad %ae %s' 2019-07-29 jvanverth@google.com Use raw MTLBuffer for texture uploads. 2019-07-29 brianosman@google.com Finish and document particle public API 2019-07-29 robertphillips@google.com Switch BackendAllocationTests from GrPixelConfig to GrColorType Created with: gclient setdep -r src/third_party/skia@96827b125f3a The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=benjaminwagner@google.com Bug: None Change-Id: I185dd357fd6e4588f832db43ba86f48ed46d788d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724114Reviewed-by:
-
Harald Alvestrand authored
This initial proof-of-concept is setting number of temporal layers only. Intent to implement thread link (not containing intent to ship): https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/--ZpYlTo6LE Bug: 986069 Change-Id: I6bd094d6166637a6899b7d2a63a2905accb7857c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1710555Reviewed-by:
Florent Castelli <orphis@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Nina Satragno authored
Shave some bits off the android chrome APK by making sure we don't include the browser side webauthn stack. It isn't used in android. Bug: 987449 Change-Id: I139b28b935816e50ef89b79e2aedd461828b0afe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717913 Commit-Queue: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Martin Kreichgauer <martinkr@google.com> Cr-Commit-Position: refs/heads/master@{#681824}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/3fea07b44639..90836d9a6e45 Created with: gclient setdep -r src-internal@90836d9a6e45 The AutoRoll server is located here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: Ia47cc3c77c47e286994550ec0f8bd617407867d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724113Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#681823}
-
Peng Huang authored
Bug: 985024 Change-Id: Iace7bcf664ca59cadd903a49b181f0e718f7df27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1717998 Auto-Submit: Peng Huang <penghuang@chromium.org> Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Cr-Commit-Position: refs/heads/master@{#681822}
-
Corentin Wallez authored
This rolls SPIRV-Cross to a newer version that implements OpArrayLength for the MSL output. BUG=dawn:195 https://chromium.googlesource.com/external/github.com/KhronosGroup/SPIRV-Cross.git/+log/f07a4e16a60e..ffca8735ff42 $ git log f07a4e16a..ffca8735f --date=short --no-merges --format='%ad %ae %s' 2019-07-26 cdavis MSL: Unify the get_*_address_space() methods. 2019-07-26 post MSL: Cleanup temporary use with emit_uninitialized_temporary. 2019-07-26 post MSL: Deal with Modf/Frexp where output is access chain to scalar. 2019-07-26 post Do not force temporary unless continue-only for loop dominates. 2019-07-25 post Missed case where DoWhile continue block deals with Phi. 2019-07-25 post Vulkan GLSL: Support disabling samplerless texture function EXT. 2019-07-25 post Workaround MSVC 2013 compiler issues. 2019-07-22 cdavis MSL: Adjust BuiltInWorkgroupId for vkCmdDispatchBase(). 2019-07-24 post Fix some typos in comments. 2019-07-24 post Do not attempt to pack types which are already scalar. 2019-07-24 post HLSL query lod cleanups. 2019-07-24 post Do not eagerly invalidate all active variables on a branch. 2019-07-23 post Do not disable temporary forwarding when we suppress usage tracking. 2019-07-23 post Add another test for unpacking without load forwarding. 2019-07-23 post Look at pointee type when unpacking expressions. 2019-07-23 post Fix some warnings when building in MoltenVK. 2019-07-23 post Deal correctly with non-forwarded packed loads. 2019-07-23 post Test CompositeInsert/Extract/VectorShuffle on packed vectors. 2019-07-23 post Add test for array of scalar struct. 2019-07-23 post Recursively pack struct types when we find scalar packed structs. 2019-07-23 post Run format_all.sh. 2019-07-23 post Unpack vector expression in Matrix-Vector multiplies. 2019-07-23 post Test matrix multiplies in more complex scenarios. 2019-07-23 post Test implicit packing of struct members. 2019-07-23 post GLSL/HLSL: Verify member alignment for explicit offset as well. 2019-07-23 post Add tests for struct padding and self-alignment. 2019-07-23 post Use to_unpacked_row_major_expression to unify row-major in MSL/GLSL. 2019-07-23 post Simplify row-major matrix/vector multiplies. 2019-07-23 post Test array of std140 vectors. 2019-07-23 post Add struct size padding tests. 2019-07-22 post Add test for CompositeExtract from row-major loaded vector. 2019-07-22 post Add test for split access chain into row-major matrix. 2019-07-22 post Remove obsolete matrix workaround code. 2019-07-22 post Only transpose unpacked expressions. 2019-07-22 post Deal correctly with complete stores to row_major matrices. 2019-07-22 post Declare correct matrix type when unpacking. 2019-07-22 post Don't forget to register a write to LHS expression in certain case. 2019-07-22 post Deal with swizzled stores to std140 matrices. 2019-07-22 post Fix some row-major column store cases. 2019-07-22 post Fix more stray parens. 2019-07-22 post Fixup stray parent in output. 2019-07-22 post Correctly unpack row-major matrices when storing to LHS. 2019-07-22 post MSL: Add std140 and scalar matrix layouts. 2019-07-22 post MSL: Add std430 matrix access test. 2019-07-22 post MSL: Support storing to row-major column. 2019-07-22 post Tests run clean. 2019-07-19 post Fix unpacking of packed but not remapped types on load. 2019-07-19 post Traverse correct types when checking scalar layout. 2019-07-19 post Deal with scalar layout of entire structs. 2019-07-19 post Pass down row-major state to unpacking functions. (...) 2019-05-28 post Fixup OpLine parsing comments. 2019-05-28 post Support emitting OpLine directive. 2019-05-28 post GLSL: Support std430 in UBOs with scalar layout. 2019-05-27 post Run format_all.sh. 2019-05-27 post MSL: Use correct address space when passing array-of-buffers. 2019-05-27 post OpArrayLength must trigger active variables. 2019-05-27 post MSL: Implement OpArrayLength. 2019-05-24 post Add Git/timestamp --revision support. 2019-05-23 post MSL: Add test case for complex type alias. 2019-05-23 post MSL: Fix struct declaration order with complex type aliases. 2019-05-18 post Fix formatting, update C ABI version. 2019-05-09 post MSL: Support argument buffers and image swizzling. 2019-05-08 stuart.carnie Add get_member_name and active_buffer_ranges to C APIs 2019-05-17 amerkoleci Fix spvc_type_get_vector_size C function. 2019-05-16 cdavis Remove fallback for OpGroupNonUniformElect. 2019-05-15 cdavis MSL: Add support for subgroup operations. 2019-05-14 post Only deploy on new tags. 2019-05-14 post Add setup for Github releases via Travis. 2019-05-14 post Validate that C ABI in CMakeLists.txt matches code. 2019-05-14 post Run format_all.sh. 2019-05-11 laszlo.agocs GLSL: Add option to disable buffer blocks regardless of version 2019-05-13 post Fix nonuniform test for MSL. 2019-05-13 post HLSL/MSL: Deal correctly with nonuniformEXT qualifier. 2019-05-09 post MSL: Add test for passing single swizzled texture arg from array. 2019-05-09 post Fix GCC 4.x warning. 2019-05-09 post MSL: Deal with texture swizzle on arrays of images. 2019-05-09 post GLSL: Support OpBitcast for buffer references. 2019-05-08 rharrison Set env to vulkan1.1 for spirv-as in test_shaders.py 2019-05-07 post GLSL: Return correct sign for OpArrayLength. 2019-05-07 post HLSL: Support OpArrayLength. 2019-05-07 post Accept SPIR-V 1.4 version. 2019-05-02 post GLSL: Support GL_EXT_nonuniform_qualifier. 2019-04-26 cdavis Fix a copy-pasto. 2019-04-26 post GLSL: Support GL_EXT_scalar_block_layout. 2019-04-26 post Fix GCC 4.x warning. 2019-04-24 post GLSL: Implement GL_EXT_buffer_reference. 2019-04-24 post Fix infinite loop when OpAtomic* temporaries are used in other blocks. 2019-04-24 post Work around false positive warning on GCC 8.3. 2019-04-23 post MSL: Cast texture_buffer index to uint. 2019-04-23 post Add texture_buffer_native option to C API. 2019-04-23 post Run format_all.sh. 2019-04-23 post MSL: Support native texture_buffer type, throw error on atomics. 2019-04-16 mikebarriault Correct formatting. 2019-04-16 mikebarriault Only use MSL constant address space for tessellation control shader. 2019-04-12 post Support running {,update_}test_shader.sh with CMake builds. 2019-04-12 ashley.harris Don't apply vertex attribute remapping other non-vertex or non-input interface blocks 2019-04-11 mikebarriault Remove accidentally committed test patch. 2019-04-10 mikebarriault Fix tests for device->constant address space change in MSL tessellation control shader generation. 2019-04-10 post Force complex loop in certain rare access chain scenarios. 2019-04-09 mikebarriault Use constant address space for SPIR-V parameters when generating tessellation control shader. TBR=rharrison@google.com Created with: roll-dep src/third_party/spirv-cross/spirv-cross Change-Id: I5e2929a9b381c1471bccad153d6c412afe3e89fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724081Reviewed-by:
Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#681821}
-
gogerald authored
The screenshot: https://drive.google.com/file/d/1hFwKWKo8fVp9BvxX6i7FClsguEidiXZs/view?usp=sharing Bug: 982018 Change-Id: I4901d1e5dc34540c0d445ec5f73fc1017a1abef4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724652 Auto-Submit: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Works around users have random other versions in their PATH. Bug: 988100 Change-Id: I48111e378b5186e4373fda3927b9cec0922cb391 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724437Reviewed-by:
-
Boris Yusupov authored
https://docs.microsoft.com/en-us/windows/win32/api/processthreadsapi/nf-processthreadsapi-getthreadpriority Change-Id: If2d50f6c0ee4e8da8bbf81cca8cfa37d2272d3ca Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720641Reviewed-by:
Gabriel Charette <gab@chromium.org> Commit-Queue: Boris Yusupov <boriay@yandex-team.ru> Cr-Commit-Position: refs/heads/master@{#681818}
-
Andrei Chulkov authored
This CL implements prompting the client to show the onboarding when a new credential is saved and the right kPasswordManagerOnboardingState is set. Bug: 983445 Change-Id: Idbbd00690ff12a6dd250fc782a0de13bd9b5abbe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706507 Commit-Queue: Andrei Chulkov <achulkov@google.com> Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#681817}
-
Justin Cohen authored
Showcase's protocol_alerter.mm is conflicting with OCMock. Prefixing with crsc_ instead. Bug: 988423 Change-Id: I542b7df1374a285b3a8ecf293b682fa922d10fde Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724654 Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#681816}
-
Dave Tapuska authored
https://chromium.googlesource.com/chromium/src/+/f898f31efa9b13b56985d60b30eddeb068598891 asserted that sandbox flags weren't changing. Doing a document.open across same origin iframes caused this CHECK to fire. BUG=987452 Change-Id: I81a255fd9b6de4af375abab523148349e3108ae0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1720995Reviewed-by:
Andy Paicu <andypaicu@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#681815}
-
Xiyuan Xia authored
ash::KeyboardController is converted from mojo interface. As a mojo interface, it does not need RemoveObserver since closing underlying connection automatically stops observing. As C++ interface, we should have an explicit RemoveObserver to avoid having a dangling pointer in the observer list. Bug: 958203 Change-Id: Ia61a43ff2d6d95b7c3d5264c27632aae277b6a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721230Reviewed-by:
Darren Shen <shend@chromium.org> Commit-Queue: Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#681814}
-
Justin Miron authored
This allows observers to access page load info from the metrics observer delegate directly, instead of being passed the PageLoadExtraInfo struct by the delegate. Previously the entire PageLoadExtraInfo struct was created and passed independent of the data needed by the observers. This also removes the duplication of delegate and PageLoadExtraInfo fields (navigation_start, did commit). Each API function returns the same data as used to populate the PageLoadExtraInfo struct. This API will be followed up with the following sets of CLs: 1. Replace common observer utility functions to use the delegate returned values instead of the PageLoadExtraInfo struct. 2. Group page_load_metrics_observer On* functions that use PageLoadExtraInfo structs and replace them with delegate returned values. This also adds first_background_time and first_foreground_time as members of the page_load_tracker, so as to not compute these with each call to their respective getter function. BUG=939403 Change-Id: I84af9f19fc2d14a727318ea2eb0668229f795cc3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1713153 Commit-Queue: Justin Miron <justinmiron@google.com> Reviewed-by:
Bryan McQuade <bmcquade@chromium.org> Reviewed-by:
John Delaney <johnidel@chromium.org> Cr-Commit-Position: refs/heads/master@{#681813}
-
