- 14 Aug, 2018 40 commits
-
-
Noel Gordon authored
Bug 873915 notes flakey time-outs on the Mash bots for keyboard delete on Drive tests. The test LOG says the tests are in waitAndAcceptDialog waiting for the .cr-dialog-ok button to appear. waitAndAcceptDialog() looks ok-ish (so problem is somewhere else), but while here, write the promise/then chain per ES6 normality. Test: browser_tests --gtest_filter="KeyboardOperations/FilesApp*" Bug: 873915 Change-Id: I5292584a0436e19878eb57730370fd8941c389f6 Reviewed-on: https://chromium-review.googlesource.com/1173942 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#582844}
-
Yuki Shiino authored
Web IDL type Function (= any (any...)) is a sort of "arbitrary function", and used very widely in the web standards. Its return value is often discarded, as if its return type is void. So, this patch supports InvokeAndReportException for type Function. Bug: 871208 Change-Id: Icbe56560585c402271363e7c8294d3b0c96b1562 Reviewed-on: https://chromium-review.googlesource.com/1173931Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#582843}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 59100433. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22698 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: Ia78f28ac1385e24237069f7298c14c93e6279415 Reviewed-on: https://chromium-review.googlesource.com/1173763 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#582842}
-
Rakina Zata Amni authored
We are mojoifying browser<->renderer communication of Find-in-page. In this CL, we are converting the Find function to mojo. Find replies are now separated into two functions, one to update the number of found matches (SetNumberOfMatches) and the other is to update which match is active right now (SetActiveMatch). This is the final function to be mojoified for FindInPage. Mojoifying doc: https://goo.gl/JenyGm Bug: 819919 Change-Id: I990160f973b29d7620214d7d58a16ece033adf3f Reviewed-on: https://chromium-review.googlesource.com/1086950 Commit-Queue: Rakina Zata Amni <rakina@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#582841}
-
sangwoo.ko authored
Replace old API with new API. In order to do this, changed the API a little bit. * Notify before deleting web conents when tabs are closed. * Pass TabStripModel* in OnTabStripModelChanged(). This CL has no intended behavior change. Reordered methods definitions so that they match with declarartion order. Change-Id: I704cfb3418d06a7539096307aefab916338c65e9 Bug: 842194 Reviewed-on: https://chromium-review.googlesource.com/1171963 Commit-Queue: Sang Woo Ko <sangwoo108@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#582840}
-
David Tseng authored
Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I3b6ba12c94c77f969f891485731a0b40e038fdcd Reviewed-on: https://chromium-review.googlesource.com/1173438Reviewed-by:
Nektarios Paisios <nektar@chromium.org> Commit-Queue: David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#582839}
-
Emircan Uysaler authored
This CL handles MEDIA_DISPLAY_VIDEO_CAPTURE cases specifically in browser-side MediaStreamManager and renderer-side UserMediaProcessor. This allows us to link these specific calls from blink to MediaAccessHandler. Bug: 326740 Change-Id: If12f9fe92a8b0ed7b30b0cad4c3c7ab140537566 Reviewed-on: https://chromium-review.googlesource.com/1170344 Commit-Queue: Emircan Uysaler <emircan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Christian Fremerey <chfremer@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#582838}
-
Tarun Bansal authored
It seems that the current minimum timeout value of 10 seconds is too low. UMA shows that on 2G connections, of all succeeded probes, only 88% of them succeed on the first attempt. 9% succeed on second attempt when the timeout is doubled, and 3% on third attempt when timeout is further doubled. This CL experiments with increasing the minimum timeout value to increase the chances of success. Bug: 760294 Change-Id: I79eb5addf2258641032b3a92053228d3f15763eb Reviewed-on: https://chromium-review.googlesource.com/1173157Reviewed-by:
Robert Kaplow (slow) <rkaplow@chromium.org> Commit-Queue: Tarun Bansal <tbansal@chromium.org> Cr-Commit-Position: refs/heads/master@{#582837}
-
tzik authored
After this CL, zero-to-one transition of the ref count causes CHECK failure on subclasses of base::RefCountedThreadSafe that have REQUIRE_ADOPTION_FOR_REFCOUNTED_TYPE(). RefCountedThreadSafe classes with custom deletion traits may keeps alive for awhile after its ref count gets to zero, the custom traits may hop to another thread to delete the instance on it. However, if another reference is created for the instance before the instance is destroyed, that eventually causes UAF. This CL is a mitigation for the UAF by converting it to an early CHECK failure. This CL increases the stripped binary size of chrome on Linux by 36kB, and no measurable size growth on non-x86 arch. Change-Id: I37aefbdac5577f2dc227b55f27330b50ccdec90f Reviewed-on: https://chromium-review.googlesource.com/1166757Reviewed-by:
-
Emircan Uysaler authored
This CL adds a new permission handler for getDisplayMedia(). It uses DesktopMediaPickerFactoryImpl as common implementation to trigger the same picker UI as extensions. It also adds unit test that exercises the new code path. Bug: 326740 Change-Id: I3007124226d2b017ba06877a1bbcc87f3bc2f9a3 Reviewed-on: https://chromium-review.googlesource.com/1163533Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Xiangjun Zhang <xjz@chromium.org> Reviewed-by:
Weiyong Yao <braveyao@chromium.org> Commit-Queue: Emircan Uysaler <emircan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582835}
-
Ramin Halavati authored
To update traffic annotation checker binaries one needs access to chromium-tools-traffic_annotation bucket. To find access owners easier, an OWNERS file is added to the folder. Change-Id: I0f8dbdc6b599b0b5b159855a3e9d3e72cdb95e6f Reviewed-on: https://chromium-review.googlesource.com/1168484Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Georges Khalil <georgesak@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#582834}
-
Xiaocheng Hu authored
FormatBlock command requires valid paragraph range to operate on, but fails to obtain it in some edge scenarios. This patch makes the command abort so that it doesn't crash the renderer. Bug: 873084 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Iccfc83be7bc2db950e9fad00974ab6a5e67f9548 Reviewed-on: https://chromium-review.googlesource.com/1173432Reviewed-by:
-
Ramin Halavati authored
Preferences related to Startup Metrics are removed from incognito persistent storage list. Bug: 861722 Change-Id: Id42fa05d2aabb38d4ec31dd01c012765d9f98d40 Reviewed-on: https://chromium-review.googlesource.com/1166827Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#582832}
-
Xiaohui Chen authored
Bug: b:112331332 Test: manually test on device, minimizes chrome windows but not Test: assistant window. Change-Id: I6d1cd8badabee351536d886271dd26b4f02be94b Reviewed-on: https://chromium-review.googlesource.com/1171254Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Weidong Guo <weidongg@chromium.org> Commit-Queue: Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#582831}
-
Peter K. Lee authored
Rolling both material_components_ios and material_internationalization_ios TBR=javierrobles@chromium.org Bug: 873293 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I2ccf4f69418002585d13261f35c9a28396261478 Reviewed-on: https://chromium-review.googlesource.com/1173719Reviewed-by:
Peter Lee <pkl@chromium.org> Commit-Queue: Peter Lee <pkl@chromium.org> Cr-Commit-Position: refs/heads/master@{#582830}
-
Makoto Shimazu authored
This reverts commit 762a6a7d. Reason for revert: It looks still flaky. https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=viz_browser_tests&tests=ResourceLoadingHintsBrowserTest.ResourceLoadingHintsHttp%0AResourceLoadingHintsBrowserTest Original change's description: > Reenable ResourceLoadingHintsBrowserTest on Linux > > The plan is to keep a close eye on bots, and disable the tests back > if we see flakiness. > > This CL will help us understand which of the tests are failing, > and also get a stack trace (which is now lost). > > Bug: 866212 > Change-Id: I94ff8ffb7278eff1ad3533d7872c1781e1e38b67 > Reviewed-on: https://chromium-review.googlesource.com/1173443 > Reviewed-by: Ryan Sturm <ryansturm@chromium.org> > Commit-Queue: Tarun Bansal <tbansal@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582730} TBR=tbansal@chromium.org,ryansturm@chromium.org Change-Id: Ic7974e852ddb12daadb956d38b54a94bc2f8096d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 866212 Reviewed-on: https://chromium-review.googlesource.com/1173971Reviewed-by:
Makoto Shimazu <shimazu@chromium.org> Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582829}
-
Koji Ishii authored
Following bot results are included. 8799 8803 8807 8810 8812 8814 8817 8822 8823 0 lines were removed and 1 lines were deflaked by consecutive results since 8793. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: I32be0aeabe32e0c5d81f79a05f153ab20ebe415c Reviewed-on: https://chromium-review.googlesource.com/1172174 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#582828}
-
Richard Li authored
This work is part of working of moving //content/common/service_worker/ into blink，which is basis for future Onion Soup work. Change-Id: I5c0b535b8f453ccb5851d59180192deb295d4ebf Reviewed-on: https://chromium-review.googlesource.com/1168741 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This reverts commit cdcdc5ea. Reason for revert: ios_chrome_unittests fails. Original change's description: > Show FindInPage activity only when it is relevant > > The FindInPage activity should only be shown when the FindInPage action > is doing something. > This CL adds a BOOL to know if the page can be searched. It is used to > display the activity or not. > > Bug: 871260 > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I514b67e4b7e0f00258c0c1a8310975394ac3468c > Reviewed-on: https://chromium-review.googlesource.com/1172287 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Peter Lee <pkl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582590} TBR=pkl@chromium.org,gambard@chromium.org Change-Id: Ibc4e514b67ef554a4b0fe49841499b10d638c3c2 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 871260, 873718 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1173871 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
This reverts commit 76c127f6. Reason for revert: This needs to be reverted first to revert crrev.com/c/1172287. Original change's description: > [iOS] ActivityService cleanup > > Cleanup for the ActivityService. > > Bug: none > Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet > Change-Id: I7feb4acc2711172dfb9829c2b223e6f2c724fa33 > Reviewed-on: https://chromium-review.googlesource.com/1172289 > Commit-Queue: Gauthier Ambard <gambard@chromium.org> > Reviewed-by: Peter Lee <pkl@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582599} TBR=pkl@chromium.org,gambard@chromium.org Change-Id: I1a2b122518b7b845274a4d27bc897eb9d195a2dd No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 873718 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Reviewed-on: https://chromium-review.googlesource.com/1173891Reviewed-by:
-
Daniel Cheng authored
The NUM_TYPES sentinel value isn't needed for scoped enumerations. Instead, take advantage of: - automatic clang checking that kMaxValue is appropriately set for scoped enumerations - auto-deduction of the boundary value with the two argument version of UMA_HISTOGRAM_ENUMERATION This allows the sentinel case statements for NUM_TYPES to be removed from several locations as well. Bug: none Change-Id: Ia840915eefc1b8f86eaf0f6929e96bd80fc2774e Reviewed-on: https://chromium-review.googlesource.com/1172208Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#582824}
-
Sergey Ulanov authored
The new PlatformScreen implementation allows to propagate display settings (such as device_pixel_scale) to the renderer. Bug: 850650 Change-Id: I088c1c46ba57596bd55bf57db854f8b3a2367e83 Reviewed-on: https://chromium-review.googlesource.com/1162426 Commit-Queue: Sergey Ulanov <sergeyu@chromium.org> Reviewed-by:
Michael Spang <spang@chromium.org> Cr-Commit-Position: refs/heads/master@{#582823}
-
Bin Wu authored
Update QUIC flag values. Bundle BbrSender and its BandwidthSampler in memory, hopefully reduces cache misses. Not protected. Merge internal change: 208339929 https://chromium-review.googlesource.com/c/1173696/ Move the delegate from PacketTransportInterface to QuartcPacketTransport. This is the first step of getting rid of the three separate interfaces for QuartcPacketWriter, QuartcPacketTransport, and PacketWriterInterface. Threading requirements, debug info (packet number), and the fact that Quartc owns and manages the entire ICE transport make this somewhat unwieldy at the moment. However, it should get better going forward. This change makes quic::QuartcPacketTransport an interface for network I/O. - Write() sends packets to the network - Delegate::OnTransportCanWrite() indicates that writes are unblocked - Delegate::OnTransportReceived() passes incoming packets to QUIC PacketTransportInterface adds on the signaling and config required for ICE. - Connect() allows the caller to specify initial parameters and start ICE - Disconnect() allows the caller to shut down the ICE transport - SetDeliveryMode() and SetIpPrivacyPolicy() modify ICE parameters at runtime - OnTransportMessageReceived() and OutgoingTransportMessages() provide a channel for signaling ICE candidates Going forward, Quartc will share an ICE transport with other components and will not need to manage the signaling aspects of ICE. PacketTransportInterface can go away once that happens. QuartcPacketWriter remains an implementation of QuicPacketWriter. It handles network output through the wrapped QuartcPacketTransport. It adds two pieces of functionality on top of QuicPacketWriter: it adds packet numbers to every outgoing packet and allows the caller to set the packet transport's delegate. Once QuicPacketWriter::WritePacket() includes packet numbers in its interface, it will also be possible to merge QuartcPacketWriter and QuartcPacketTransport into a single network I/O interface for quic/quartc. Finally, QUIC expects the QuartcPacketTransport::Delegate calls to be serialized with other QUIC operations. The way that Quartc does this serialization today becomes slightly more complex. Since QUIC now calls SetDelegate(), Quartc needs a wrapper to intercept the Delegate and perform the thread hop to the QUIC executor. This is necessary pain induced by thread-hopping. The thread-safe wrapper will become thinner when PacketTransportInterface is deleted. It will go away entirely when we replace quartc_thread_safe with a better synchronization mechanism. FIG_CHANGESET=c4301c7fdf0e83b365a939cc233dc7b006f55884 Merge internal change: 208285103 https://chromium-review.googlesource.com/c/1173695/ In QUIC, when session decides what to write, let IsPacketUsefulForRetransmittableData drops packets earlier. Protected by FLAGS_quic_reloadable_flag_quic_fix_is_useful_for_retrans. Merge internal change: 207934023 https://chromium-review.googlesource.com/c/1173333/ Make QuicSession::GetStream slightly faster by skipping the lookup into the static stream map, when possible. Protected by FLAGS_quic_reloadable_flag_quic_session_faster_get_stream. Merge internal change: 207921542 https://chromium-review.googlesource.com/c/1173332/ In QUIC, if a newer WINDOW_UPDATE frame gets acked, consider all older WINDOW_UPDATE gets acked. Protected by FLAGS_quic_reloadable_flag_quic_donot_retransmit_old_window_update2. Merge internal change: 207915791 https://chromium-review.googlesource.com/c/1173331/ In QUIC, only process stateless resets on the client side. Protected by FLAGS_quic_reloadable_flag_quic_process_stateless_reset_at_client_only. When the flag is on, server won't bother to read |header->possible_stateless_reset_token|, thus saving a small amount of cpu. This is a micro optimization. No externally visible behavior change. Merge internal change: 207883948 https://chromium-review.googlesource.com/c/1172928/ In QUIC, try to aggregate acked stream frame. Protected by FLAGS_quic_reloadable_flag_quic_aggregate_acked_stream_frames. Merge internal change: 207746798 https://chromium-review.googlesource.com/c/1172927/ Improve Quartc's responsiveness to changes in congestion control parameters. Issue a callback from QUIC to Quartc whenever congestion control changes. This callback reports three parameters: bandwidth estimate, pacing rate, and latest RTT. The callback fires whenever QuicSendPacketManager calls OnCongestionChange(). This happens after every ack frame with an rtt update, acked packets, or lost packets. Reporting changes in congestion control parameters to Quartc immediately, rather than waiting up to 200 ms for Quartc to scrape them from stats, should improve responsiveness to congestion control changes, especially on low-RTT networks where changes can happen on timescales much shorter than 200 ms. Quartc now uses the minimum of BWE and pacing rate for rate controls in the Brain. This should avoid building long client-side buffers during PROBE_RTT, DRAIN, or low-gain PROBE_BW phases. During these phases, the BWE is higher than the pacing rate. If Quartc continues to produce data at the BWE, it will overproduce and buffer data. Since low-gain phases tend to last on the order of 1 RTT, it does not make sense to adapt to the pacing rate without also getting a callback as soon as it changes. Scraping every 200 ms may easily miss gain transitions (either obtaining a higher pacing rate just before the low-gain phase starts or obtaining a lower pacing rate just before the low-gain phase ends). FIG_CHANGESET=37546b8b8e52bdc4af9a28f394f1387db4bb597f Merge internal change: 207729769 https://chromium-review.googlesource.com/c/1172926/ Refactor quic::PerPacketOptions Turn it from a class into a struct (since it only exists to carry a bunch of values around). Also make Clone() return unique_ptr. Merge internal change: 207625151 https://chromium-review.googlesource.com/c/1172923/ Remove a bogus DCHECK from QuicStream::SetPriority which would be triggered if a server received a PRIORITY frame after having sent any of the response body. Merge internal change: 207619365 https://chromium-review.googlesource.com/c/1172922/ Reorder an OR statement in IsPacketUsefulForRetransmittableData() to avoid calling HasRetransmittableFrames() when it's not necessary. No functional change, not flag protected. Merge internal change: 207585541 https://chromium-review.googlesource.com/c/1172921/ R=rch@chromium.org Change-Id: I144c4346e80b418ddf8a70b60642e9716e902cf7 Reviewed-on: https://chromium-review.googlesource.com/1173701 Commit-Queue: Bin Wu <wub@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Reviewed-by:
Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#582822}
-
pdfium-chromium-autoroll authored
https://pdfium.googlesource.com/pdfium.git/+log/19b70815b4d1..ed176992eb7d git log 19b70815b4d1..ed176992eb7d --date=short --no-merges --format='%ad %ae %s' 2018-08-13 thestig@chromium.org Make CFX_ReadOnlyMemoryStream take a span. 2018-08-13 thestig@chromium.org Change CFDF_Document::ParseMemory() to use pdfium::span. 2018-08-13 thestig@chromium.org Use std::vector in FDFToURLEncodedData(). 2018-08-13 thestig@chromium.org Move FDFToURLEncodedData() into an anonymous namespace. 2018-08-13 thestig@chromium.org Implement CFX_CodecMemory. 2018-08-13 thestig@chromium.org Use CFX_ReadOnlyMemoryStream in more places. 2018-08-13 thestig@chromium.org Mark CPDF_Font::GlyphFromCharCodeExt() and friends Mac only. 2018-08-13 thestig@chromium.org Move CPDFSDK_MemoryAccess to fxcrt. 2018-08-13 thestig@chromium.org Run pdfium_test in only one place in make_expected.sh. Created with: gclient setdep -r src/third_party/pdfium@ed176992eb7d The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: Iec93ed9adbe52be1ed7e6f7a71553c49ed908042 Reviewed-on: https://chromium-review.googlesource.com/1173176Reviewed-by:
pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582821}
-
Weilun Shi authored
[NTP] Allow VoiceOver to select tiles in the custom background dialog and adjust button styling to match GM2 Adding role="button" to each tile allows them to be treated like buttons when using VoiceOver. This includes selection/click with Ctrl+Option+Space. Also, refactored the cancel/done button styling to match GM2 and switched from <div> to <button>. This allows the user to navigate by pressing Ctrl+Option+Left/Right once instead of twice." Bug: 871408, 866056 Change-Id: I5810c20706e2cd178c2129f14a2a1793f45774fd Reviewed-on: https://chromium-review.googlesource.com/1173434 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Kristi Park <kristipark@chromium.org> Cr-Commit-Position: refs/heads/master@{#582820}
-
Yuki Yamada authored
This CL removed some code that clearing TraceWrapperV8Reference object in its destructor. |listener_| is cleared in the destructor of TraceWrapperV8Reference, so we do not have to clear it in blink::V8AbstractEventListener. Bug: 872138 Change-Id: I4f8e8e67074ee8b2081735053b5b0f7604afadff Reviewed-on: https://chromium-review.googlesource.com/1173195 Commit-Queue: Yuki Yamada <yukiy@google.com> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#582819}
-
Ken Rockot authored
Changes ServiceProcessLauncher to join service processes from a background task rather than from the launcher's owning sequence. Updates RenderThreadImplBrowserTest so that it actually has a real IO thread and therefore doesn't run all tasks (including "background" tasks) on the same sequence on which Mojo does IPC. This prevents service process joins from blocking internal IPC routing and thus allows ServiceProcessLauncher to be used safely without deadlocking on shutdown, particularly in aforementioned browser tests. Bug: 844078 Change-Id: Idf75dac40a9b16b49703483f0d010be3f3bc68aa Reviewed-on: https://chromium-review.googlesource.com/1173428Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
TBR=takumif@chromium.org NOTRY=true Bug: 873912 Change-Id: I890f6aa5f3c1238eea0f083b5401ed86d7918df5 Reviewed-on: https://chromium-review.googlesource.com/1173833Reviewed-by:
-
Brandon Wylie authored
This data will be used to monitor the health of the feed image manager and also to compare to the incoming componentized cached image fetcher. Bug: 868604 Change-Id: I2e9ac800bf602db6963f94c0baa487cf74adbc16 Reviewed-on: https://chromium-review.googlesource.com/1155160 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Gang Wu <gangwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#582816}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 09fe42b0. With Chromium commits locally applied on WPT: 7dad0f17 "Added new Sec-Metadata Web Platform Tests." 09fe42b0 "Web Locks API: Convert .html tests to .any.js where applicable" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/22695 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: jsbell@chromium.org: external/wpt/encoding rouslan@chromium.org, mathp@chromium.org: external/wpt/payment-request NOAUTOREVERT=true TBR=lukebjerring No-Export: true Change-Id: I58776b3e57391ab533f6df227764239339f03bdd Reviewed-on: https://chromium-review.googlesource.com/1173716 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
-
Makoto Shimazu authored
TBR=achuith@chromium.org NOTRY=true Bug: 873908 Change-Id: I96073584e422833f3aa16c80945f645dcc5d78c2 Reviewed-on: https://chromium-review.googlesource.com/1173832Reviewed-by:
-
Ken Rockot authored
The issue was raciness between navigation and FrameFocusedObserver setup. Focus can be dispatched to the FrameTreeNode before NavigateToURL* returns, causing the subsequently constructed FrameFocusedObserver to wait forever for an event that has already happened. Because FrameFocusedObserver only monitors the main frame's FrameTreeNode, which is stable, we can construct the observer before NavigateToURL*. That's what all this does. Bug: 872075,867339 Change-Id: I08c68ecb548163ee2097222d549e6985e5c9428a Reviewed-on: https://chromium-review.googlesource.com/1173016Reviewed-by:
-
John Abd-El-Malek authored
Bug: 871542 Cq-Include-Trybots: luci.chromium.try:linux_mojo Change-Id: Iab57f575186577532a7327c3fcf43266f91a1a43 Reviewed-on: https://chromium-review.googlesource.com/1172730 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Minh Nguyen <mxnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#582812}
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=mmoss@chromium.org Change-Id: I203af22a6ab01df8c281cafedf4d934c544f7962 Reviewed-on: https://chromium-review.googlesource.com/1173702Reviewed-by:
chrome-release-bot@chromium.org <chrome-release-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#582811}
-
Chris Blume authored
This reverts commit 2be1f912. Reason for revert: This CL is a suspect in a failure seen on one of the GPU FYI bots. More info here: https://bugs.chromium.org/p/chromium/issues/detail?id=873814 Original change's description: > Enable Windows NV12 overlays on waterfall > > We plan on shipping this via a finch experiment to Canary/Dev soon, and then > enable it by default if we don't encounter major issues. This should only affect > the DirectComposition pixel tests since we force-enable overlays for those > tests. Other tests don't exercise DirectComposition code because those code > paths are disabled unless the hardware supports it. > > Bug: 869677 > Change-Id: I31c1fd96f2c2567c82c19776a57b2fe18a1b1e1a > Reviewed-on: https://chromium-review.googlesource.com/1170385 > Reviewed-by: Steven Holte <holte@chromium.org> > Commit-Queue: Sunny Sachanandani <sunnyps@chromium.org> > Cr-Commit-Position: refs/heads/master@{#582305} TBR=holte@chromium.org,sunnyps@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 869677 Change-Id: Ied108cd594931f2463f21cead4a0dac0ecd8206b Reviewed-on: https://chromium-review.googlesource.com/1173572Reviewed-by:
Chris Blume <cblume@chromium.org> Commit-Queue: Chris Blume <cblume@chromium.org> Cr-Commit-Position: refs/heads/master@{#582810}
-
David Black authored
This CL: - Changes font size. - Changes icon size. - Fixes spacing between icons. Also updated suggestion chip font size per the spec. See bug for screenshots. Bug: b:112313532 Change-Id: I40942e15d17e951a66d334164e5a999169a162ce Reviewed-on: https://chromium-review.googlesource.com/1172146 Commit-Queue: David Black <dmblack@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#582809}
-
skia-chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/1b95ef9f9912..d4322a8630bc git log 1b95ef9f9912..d4322a8630bc --date=short --no-merges --format='%ad %ae %s' 2018-08-13 reed@google.com Change cubicmap to eval directly (no table) Created with: gclient setdep -r src/third_party/skia@d4322a8630bc The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=kjlubick@chromium.org Change-Id: I6ab48d5c9b0d3d16414dc8c5f5ea72df81d28d1a Reviewed-on: https://chromium-review.googlesource.com/1173367Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582808}
-
John Budorick authored
Bug: 868525 Change-Id: I2e10e438ad41c862a434e8181b5754b6d17e53f2 Reviewed-on: https://chromium-review.googlesource.com/1173502 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Nodir Turakulov <nodir@chromium.org> Cr-Commit-Position: refs/heads/master@{#582807}
-
Chromite Chromium Autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/8405a1536d36..b26e129bfd2a git log 8405a1536d36..b26e129bfd2a --date=short --no-merges --format='%ad %ae %s' 2018-08-14 lannm@chromium.org Add repo_util.Repository.StartBranch and .MustFind 2018-08-13 chrome-bot@chromium.org Update config settings by config-updater. 2018-08-13 dgarrett@google.com chromeos_config: Add nocturne-chrome-pfq. Created with: gclient setdep -r src/third_party/chromite@b26e129bfd2a The AutoRoll server is located here: https://chromite-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=chrome-os-gardeners@chromium.org Change-Id: If2d70f4dcc923cb84da79265fb6a36640a43f83c Reviewed-on: https://chromium-review.googlesource.com/1173177Reviewed-by:
Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: Chromite Chromium Autoroll <chromite-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#582806}
-
Yutaka Hirano authored
This is a reland of ffc8179c8a7bca7404f1f9463331c9a8f54b69a5. The original CL was reverted due to an infra issue. Original change's description: > Inline ResourceDispatcherHostImpl::CreateBaseResourceHandler > > Now it always creates a MojoAsyncResourceHandler, so there is no need to > have a separate function. > > Bug: None > Change-Id: Iafadf07f8dd5930d8de600ed87c0d2aa62a91038 > Reviewed-on: https://chromium-review.googlesource.com/1169034 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> Bug: None Change-Id: If915cdf70ae06088b7eea366972472d22b71c28e Tbr: csharrison@chromium.org Reviewed-on: https://chromium-review.googlesource.com/1173591Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#582805}
-
