- 13 Jan, 2021 40 commits
-
-
Maxim Kolosovskiy authored
TBR=caseq@chromium.org Bug: 1164469 Change-Id: I28d850db9a5664ee168906c4d793a4751a670c28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626655Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Commit-Queue: Maxim Kolosovskiy <kolos@chromium.org> Cr-Commit-Position: refs/heads/master@{#842999}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1610517435-75fc59b03a49bc3203d88e1f39423cb5de4c8383.profdata to chrome-linux-master-1610538373-541aee2d8154a147aea334eed2074efc5a2f470f.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7cd93fefd8079129e2b268eb2176326dfdf3e1af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627054Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842998}
-
Nohemi Fernandez authored
Bug: N/A Change-Id: I2ae05f6d5ff8b3518d4a22211b03d386414b6732 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627312Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#842997}
-
Peter McNeeley authored
Recent Finch data has indicated a large percentage of failing overlays. In order to better understand why these overlays might be failing we add a new fail enum that indicates that the overlay candidate failure was a deliberate act by prioritization. Also included in this cl is a minor fix for a specific case with low latency surfaces. Some low latency surfaces (eg Ink) do not change content Ids even when the pixel data changes. We now detect these content changes by testing for a valid surface damage index. If the surface has a damage index we can assume that the content has changed. Change-Id: I00b7015ee78a952105c7107eb4cedaf798f88b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614860Reviewed-by:
Robert Kroeger <rjkroege@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Commit-Queue: Peter McNeeley <petermcneeley@chromium.org> Cr-Commit-Position: refs/heads/master@{#842996}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-linux-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I8e8e8dc6ea6de00580edb42cc6f4ea31126a1f20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627567Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610517435-6cb290631927ae5ce3c51d7b67446e43eb76cc98.profdata to chrome-win32-master-1610528340-b101588b91e5587ca53d6a4d812cdea4439c3876.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ib4c450e8640f605faf893688774c005aa243f331 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627547Reviewed-by:
-
Maxim Kolosovskiy authored
TBR=finnur@chromium.org Bug: 1166152 Change-Id: Ifb502e17cc80718bef3106ffa9da52d5b0343ed1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627151Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/44ba8e1708ab..8fccd82e4e02 2021-01-13 fmayer@google.com Merge "Treat perfetto_config.descriptor.h as binary." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I5fb4554364f2a6270e6578297679b3543f44df67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627570Reviewed-by:
-
Maxim Kolosovskiy authored
TBR=mlamouri@chromium.org Bug: 1157239 Change-Id: I94f5aef90870471863c37003f9cd06988645502c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627271Reviewed-by:
-
Rune Lillesveen authored
Allow traversal into and update pseudo elements affected by container queries. Bug: 1146097 Change-Id: I41916286f20bc038089f2f3420d568259a817f62 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624631 Commit-Queue: Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Cr-Commit-Position: refs/heads/master@{#842990}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/8d62769d7e71..95ab239e91ec 2021-01-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools Chromium DEPS. 2021-01-13 jacktfranklin@chromium.org Fix report view component doc 2021-01-13 tvanderlippe@chromium.org [module.json extensions] changes If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I34d63e713282606e84744bfad9b625032f56f07f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627548Reviewed-by:
-
Monica Basta authored
This CL implements the select avatar dialog for the local profile creation in the profile picker. Change-Id: I6a4fb4e49fbd2e5fc25af5b1c0045a529c416d6c Bug: 1162443 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2606353 Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#842988}
-
Reid Kleckner authored
Example failing build: https://ci.chromium.org/ui/p/chrome/builders/ci/ToTWin64/8096/overview This buildbot is chrome-branded, so it uses the chrome-tester-service-account mixin. I believe this means it uses separate pools of machines. There are no bots in that machine pool that match the precise Windows 10 version specified in the Windows 10 mixin. The ToTWin bot is the 32-bit analogue of this bot, and it does not have the win10 mixin, and it runs successfully. Bug: 1166036 R=jam@chromium.org,jochen@chromium.org Change-Id: Ia99937cc830e4270d37bda309c06e834e0e35676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626827 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#842987}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/0ebc1e8f4c65..fe6147b4a04c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com Change-Id: Ibc405cae141e30a5114ba81f7099cba9647bd75b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627289Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#842986}
-
Tim van der Lippe authored
R=szuend@chromium.org Bug: 1050549 Change-Id: I763f8596ab931c97a5b15dcd2639f59baab2763b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627412 Commit-Queue: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Simon Zünd <szuend@chromium.org> Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Reviewed-by:
Simon Zünd <szuend@chromium.org> Cr-Commit-Position: refs/heads/master@{#842985}
-
Yuta Hijikata authored
This change renames deprecated macro name IS_LACROS and IS_ASH with IS_CHROMEOS_LACROS and IS_CHROMEOS_ASH. Bug: 1052397 Change-Id: I58d95a81555a4915b8e80edc1edd23cc3f7d49bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626685 Commit-Queue: Nico Weber <thakis@chromium.org> Reviewed-by:
-
kylechar authored
SkiaRenderer will use GL by default if not using Vulkan or Dawn. The --use-gl switch isn't required to get into this state. Add a check that we're using GPU compositing first, since if that is false Chrome will use SoftwareRenderer. Also change the skia-renderer-gl tag to be true if 'opengl' feature is enabled but not using Vulkan or Dawn. Bug: 1163586 Change-Id: Ica5ee59d59b8e437faf0aa9c954e3280d1c7d0e7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622237Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#842983}
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610517435-1554e99a291ef2bcb6f5a0139dcc2bec362b747b.profdata to chrome-win64-master-1610528340-1fc68c0c17222e2254fe428312433be61c378c49.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I6f3dd9bfafb1c22961eee183f0874787a34f6880 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627088Reviewed-by:
-
Andrey Zaytsev authored
Mock: https://docs.google.com/presentation/d/1_6jDegg169xJ5qgaABZ_wV3-Csd_OL5bf9H1NeUqS9Y/edit?pli=1#slide=id.gac1f62eb2c_0_23 Screenshot: https://screenshot.googleplex.com/8oc3STHihHMNwaF.png Bug: 1152351 Change-Id: Ib4692d6a540652ab761ab373de619385f76fa08e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2611098 Commit-Queue: Andrey Zaytsev <andzaytsev@google.com> Reviewed-by:
Kamila Hasanbega <hkamila@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Auto-Submit: Andrey Zaytsev <andzaytsev@google.com> Cr-Commit-Position: refs/heads/master@{#842981}
-
Maxim Kolosovskiy authored
This reverts commit 85753b0f. Reason for revert: I suspect this CL caused failures SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite https://ci.chromium.org/ui/p/chromium/builders/ci/linux-lacros-tester-rel/6414/overview Fontconfig error: Cannot load default config file: No such file: (null) BrowserTestBase received signal: Terminated. Backtrace: #0 0x5596f4879789 base::debug::CollectStackTrace() #1 0x5596f47e4163 base::debug::StackTrace::StackTrace() #2 0x5596f4dcc0c6 content::(anonymous namespace)::DumpStackTraceSignalHandler() #3 0x7f128ca544c0 (/lib/x86_64-linux-gnu/libc-2.23.so+0x354bf) #4 0x7f12902ec9ff __libc_send #5 0x5596f2a8598f mojo::core::ChannelPosix::WriteNoLock() #6 0x5596f2a854b2 mojo::core::ChannelPosix::Write() #7 0x5596f2a7370e mojo::core::NodeChannel::SendChannelMessage() #8 0x5596f2a7808a mojo::core::NodeController::SendPeerEvent() #9 0x5596f2a78707 mojo::core::NodeController::ForwardEvent() #10 0x5596f6c728d2 mojo::core::ports::Node::SendUserMessageInternal() #11 0x5596f6c72720 mojo::core::ports::Node::SendUserMessage() #12 0x5596f2a768e1 mojo::core::NodeController::SendUserMessage() #13 0x5596f2a71afe mojo::core::MessagePipeDispatcher::WriteMessage() #14 0x5596f2a6744c mojo::core::Core::WriteMessage() #15 0x5596f579b850 mojo::Connector::Accept() #16 0x5596f579d9db mojo::InterfaceEndpointClient::SendMessageWithResponder() #17 0x5596f579dd5f mojo::InterfaceEndpointClient::AcceptWithResponder() #18 0x5596f26f4662 content::mojom::ChildHistogramFetcherProxy::GetChildNonPersistentHistogramData() #19 0x5596f2d9b2aa content::HistogramController::GetHistogramData() #20 0x5596f2d9c905 content::HistogramSynchronizer::RegisterAndNotifyAllProcesses() #21 0x5596f2d9ca56 content::FetchHistogramsAsynchronously() #22 0x5596f4dd4781 content::FetchHistogramsFromChildProcesses() #23 0x5596f52f70fa subresource_redirect::RetryForHistogramUntilCountReached() #24 0x5596f0f9d3d1 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest_TestCancelBeforeImageLoadForLoggedInSite_Test::RunTestOnMainThread() #25 0x5596f4dcb6e9 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop() #26 0x5596f491e0aa ChromeBrowserMainParts::PreMainMessageLoopRunImpl() #27 0x5596f491cea5 ChromeBrowserMainParts::PreMainMessageLoopRun() #28 0x5596f2c33516 content::BrowserMainLoop::PreMainMessageLoopRun() #29 0x5596f30a1833 content::StartupTaskRunner::RunAllTasksNow() #30 0x5596f2c324f9 content::BrowserMainLoop::CreateStartupTasks() #31 0x5596f2c34e78 content::BrowserMainRunnerImpl::Initialize() #32 0x5596f2c30c28 content::BrowserMain() #33 0x5596f373dc93 content::ContentMainRunnerImpl::RunBrowser() #34 0x5596f373d886 content::ContentMainRunnerImpl::Run() #35 0x5596f373ad84 content::RunContentProcess() #36 0x5596f373b70c content::ContentMain() #37 0x5596f4dcac68 content::BrowserTestBase::SetUp() #38 0x5596f47d0edb InProcessBrowserTest::SetUp() #39 0x5596f0f9e065 subresource_redirect::SubresourceRedirectLoggedInSitesBrowserTest::SetUp() #40 0x5596f1cf66e8 testing::Test::Run() #41 0x5596f1cf757f testing::TestInfo::Run() #42 0x5596f1cf7f57 testing::TestSuite::Run() #43 0x5596f1d05777 testing::internal::UnitTestImpl::RunAllTests() #44 0x5596f1d050df testing::UnitTest::Run() #45 0x5596f48d0724 base::TestSuite::Run() #46 0x5596f47b935f ChromeTestSuiteRunner::RunTestSuite() #47 0x5596f4dfaab7 content::LaunchTests() #48 0x5596f47b9632 LaunchChromeTests() #49 0x5596f47b6df4 main #50 0x7f128ca3f840 __libc_start_main #51 0x5596f008526a _start [ RUN ] SubresourceRedirectLoggedInSitesBrowserTest.TestCancelBeforeImageLoadForLoggedInSite Original change's description: > [Safe Browsing] Abstract signin dep from RealTimeUrlLookupService > > This CL continues with the abstraction of dependencies on signin and > sync from //components/safe_browsing's access token fetching flow in > order to enable reuse by WebLayer. The concrete step taken here is to > abstract the dependencies on > //components/safe_browsing/core/browser/sync from > RealTimeUrlLookupService, passing these dependencies in via the > constructor. There are no behavioral changes in this CL: > - //chrome and //ios/chrome's factories glue the relevant parameters > from //components/safe_browsing/core/browser/sync > - //weblayer's factory passes in values for the parameters such that > access token fetching for URL lookups continues to be disabled in > WebLayer > > Followup work will bring up support for access token fetching in > WebLayer. > > Bug: 1080748 > Change-Id: I69fca4b2d04118088bb48596eb192beab7bafb4f > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2621301 > Reviewed-by: Sylvain Defresne <sdefresne@chromium.org> > Reviewed-by: Xinghui Lu <xinghuilu@chromium.org> > Commit-Queue: Colin Blundell <blundell@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842942} TBR=blundell@chromium.org,sdefresne@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com,xinghuilu@chromium.org Change-Id: I9aa193871848c7e07353bb2bb428a2a39ba5cb00 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1080748 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627391Reviewed-by:
-
David Roger authored
This CL updates the string to: "To access your Chrome stuff across all your devices, sign in, then turn on sync." https://storage.cloud.google.com/chromium-translation-screenshots/d11144bc8bc505baf22f44152b590dc96c796574 Another version of the string is also added, for possible experimentation later: "To access your Chrome stuff across all your devices, sign in so that you can turn on sync." https://storage.cloud.google.com/chromium-translation-screenshots/6cdbd1b209a8657e0a790d1ec671d522e0c54344 Change-Id: I08e74567ef64e0916366992f35a2901d94975fe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626648 Auto-Submit: David Roger <droger@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Reviewed-by:
Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#842979}
-
Adrienne Walker authored
CacheStorageContextImpl implements the new AddReceiver mojo function, but no callers have transitioned from calling C++ to calling mojo yet. This CL is dealing with the churn of changing content::CacheStorageOwner to storage::mojom::CacheStorageOwner. Bug: 1147642 Change-Id: I3b0067767bea4571fd949741780e4a34b18939f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615311Reviewed-by:
Ben Kelly <wanderview@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Auto-Submit: enne <enne@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#842978}
-
Matthias Körber authored
It is currently not the intention to run the subtoken merge strategy but due to an additional or statement, this strategy is executed although it is the intent to only run a token merge strategy when the back of tokens are equivalent. This change removes the wrong application. Bug: 1158810 Change-Id: I08d68818fac1b6a7552f6aa744caca8eed512902 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627315Reviewed-by:
Christoph Schwering <schwering@google.com> Commit-Queue: Matthias Körber <koerber@google.com> Auto-Submit: Matthias Körber <koerber@google.com> Cr-Commit-Position: refs/heads/master@{#842977}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/2ed9671a0ddd..62b8364eafc7 2021-01-13 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 2a7e78c7 to 451c64aa (494 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC timvp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: timvp@google.com Change-Id: I4d9b1028d1cc3a660843431703a0e6728db70117 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627020Reviewed-by:
-
https://crrev.com/c/2599731Yutaka Hirano authored
Bug: None Change-Id: Ic4f42a004df7da9dd39eedbdcc9fd68389108fca Tbr: wutao@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626942Reviewed-by:
-
Tanmoy Mollik authored
Methods OnPrimaryAccountSet/OnPrimaryAccountCleared are deprecated. This cl removes artifacts used by these method overrides in TestIdentityManagerObserver and replaces them with a single callback for OnPrimaryAccountChanged. Bug: 1158855 Change-Id: If0cd666626268c7e21fcde33d26a5c0cfbc298de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2618438 Commit-Queue: Tanmoy Mollik <triploblastic@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#842974}
-
Ossama Mahmoud authored
Merge the privacy disclaimer footer note with the subheader in the fingerprint-setup initial screen. Bug: 1096679 Change-Id: I7f179931e57a6bcdfc8c60c494ddf6dd37a4f7c3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2612972 Commit-Queue: Ossama Mahmoud <osamafathy@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Cr-Commit-Position: refs/heads/master@{#842973}
-
Ramin Halavati authored
Fixes a forgotten value in enums.xml. Bug: 1157764 Change-Id: I4e8f60588f095f31349ad032d89c2cea83fecac8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626653 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Commit-Queue: David Roger <droger@chromium.org> Reviewed-by:
-
Aya ElAttar authored
- Added is_drop parameter tot IsDragDropAllowed. - Changed IsDragDropAllowed logic to notify only if is_drop==true. - Added unittests for IsDragDropAllowed. Bug: 1160656 Change-Id: I6b745aa63756052e58ccd4cea6895ecc34a6c8b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624671 Commit-Queue: Aya Elsayed <ayaelattar@chromium.org> Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#842971}
-
Anton Bikineev authored
This is useful for PCScan since it enables the scanning routine to use a bitmap for super-page lookup. Bug: 11297512 Change-Id: I1634f0a97a1dd85e3407d80da6cd43e362476062 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627147 Commit-Queue: Anton Bikineev <bikineev@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#842970}
-
Stephen McGruer authored
Due to mandatory code review, we need to migrate off of the automatic copy of tools/ in external/wpt, and instead use the manually rolled copy in blinkpy. This change updates run_wpt_tests.py to point at that copy, and updates the include-list as necessary to make wptrunner work. Bug: 1165950 Change-Id: I4c31addbf16fbaba3671048d26399a15c04c0acd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2470462Reviewed-by:
Luke Z <lpz@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#842969}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/cc988a955f26..8d62769d7e71 2021-01-13 sigurds@chromium.org Collect UMA on developer resource loads 2021-01-13 andoli@chromium.org [module.json extensions] Add check for duplicate actions and views 2021-01-13 alcastano@google.com Center vertically popover icon 2021-01-13 tvanderlippe@chromium.org [module.json extensions] animation 2021-01-13 aerotwist@chromium.org Perf panel: fix request finish time 2021-01-13 bmeurer@chromium.org [e2e] Temporarily disable tests to unblock the Chromium roll. 2021-01-13 kimanh@chromium.org Allow live locations even if the debugger is disabled If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1069378,chromium:1132260,chromium:1134103,chromium:1150883,chromium:1157396,chromium:1165304 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ic8f7fb75ff841ad9cb888e14a1bfeb79148d1a0e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627352Reviewed-by:
-
dpapad authored
This ensures that the BUILD.gn file is not unnecessarily evaluated where not applicable. Bug: None Change-Id: I4bc18a19f6fee782ed85df7a2d007465bedced3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626912 Commit-Queue: Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#842967}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/7faa362ea9c2..111ba65a5e3d 2021-01-13 cwallez@chromium.org D3D12: Use Texture::Create pattern for swapchain textures 2021-01-13 dawn-autoroll@skia-public.iam.gserviceaccount.com Roll Tint from 987376cd21a8 to 1c200cffd051 (13 revisions) 2021-01-13 marksibly@gmail.com Reset scissor reset before presenting in opengl 2021-01-13 enga@chromium.org Update DepthStencilStateTests to use WGSL If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC dsinclair@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: dsinclair@google.com Change-Id: Ibb045064f561ef91f34164911d6f000f1d341650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627350Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1610495996-5598384ad8a00037e18a56fd00981ea765e31cd1.profdata to chrome-win32-master-1610517435-6cb290631927ae5ce3c51d7b67446e43eb76cc98.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I3d2c5a161f10c5c42e5b05e6c54a634d712b1adc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627016Reviewed-by:
-
Yutaka Hirano authored
network.mojom.DataElement represents part of a request body. It is a union of several types, and that applies to its typemapped class, network::DataElement. Up until now we had flat members (e.g., offset(), length(), bytes()) with various DCHECKs on network::DataElement. This led to several issues: 1) The code author can be confused. Some members (e.g., length(), bytes()) seems to have a meaning in a wrong context, and that can lead to security issues. See https://crbug.com/1151865 for example. 2) It is hard to maintain the DCHECKs in a consistent way. For example, at this moment we have a DCHECK at chunked_data_pipe_getter(), but we don't have a DCHECK at length(). We have a similar difficulty on mojo deserialization. This CL makes network::DataElement a simple wrapper of absl::variant. network::DataElement has only one member: absl::variant<absl::monostate, DataElementBytes, DataElementDataPipe, DataElementChunkedDataPipe, DataElementFile> variant_; A user needs to check the type and explicitly cast the element to the correct class, to access any information (other than `type`). We rely on checks implemented in absl::variant, so we don't need to have many DCHECKs. This CL also contains the following changes: A) DataElementType.kReadOnceStream is gone, as having two members sharing the same type makes the use of absl::variant difficult. This merges the type to DataElementType.kChunkedDataPipe, and introduced a boolean `read_only_once` in DataElement to distinguish them. B) Removed FetchAPIDataElement, as it seems identical to network.mojom.DataElement. C) Deserialization logic gets more strict. Invalid mojo::pending_remote for kDataPipe and kChunkedDataPipe are now treated as errors. D) Made network.mojom.DataElement a union. E) Added some deserialization tests for network::DataElement. Change-Id: I2c646ead57bc19bee661b711c9c863ce1a5e9c94 Bug: 1156550, 1151865, 1152664 Tbr: koerber@google.com, alexchau@chromium.org, yfriedman@chromium.org, evliu@google.com, ianli@chromium.org, tbansal@chromium.org, karandeepb@chromium.org, alexilin@chromium.org, garykac@chromium.org, charleszhao@chromium.org, inferno@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2599731Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Reviewed-by:
Nathan Parker <nparker@chromium.org> Commit-Queue: Yutaka Hirano <yhirano@chromium.org> Cr-Commit-Position: refs/heads/master@{#842964}
-
Michael Lippautz authored
Bug: 1056170 Change-Id: I467dbaf29f7474550e2fc17b82c6fc7195c4f84e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627149 Commit-Queue: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Michael Lippautz <mlippautz@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#842963}
-
Tanmoy Mollik authored
Method OnPrimaryAccountCleared is deprecated. So this cl changes these calls to OnPrimaryAccountChanged() Bug: 1158855 Change-Id: I56ea44e66fdd91f9cf81eae822233d792e6927c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622532Reviewed-by:
Colin Blundell <blundell@chromium.org> Commit-Queue: Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#842962}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/4ecb2f5fc58f..0ebc1e8f4c65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com Change-Id: Ie0d5c7ad00b0b08cbb6740ee2649a925c5d023db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627327Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Win64 PGO profile from chrome-win64-master-1610505994-ce0c95957b1d27284e834682f26210d976ec22d1.profdata to chrome-win64-master-1610517435-1554e99a291ef2bcb6f5a0139dcc2bec362b747b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win64-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win64-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I7e851c6840f380e74bb2218345f4de1bcc922afc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627069Reviewed-by:
-
