GitLab

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2852243002
Cr-Commit-Position: refs/heads/master@{#468638}

This CL removes some obsolete comments. For example, the class
RecentlyClosedTabsHandler is gone, so the related comments should be
deleted as well.

Other comment updates are according to Google C++ style guide.
https://google.github.io/styleguide/cppguide.html#Comments

BUG=40407, 179576

Review-Url: https://codereview.chromium.org/2849113003
Cr-Commit-Position: refs/heads/master@{#468637}

BUG=629964

Review-Url: https://codereview.chromium.org/2784533002
Cr-Commit-Position: refs/heads/master@{#468636}

BUG=skia:6535

Review-Url: https://codereview.chromium.org/2851253002
Cr-Commit-Position: refs/heads/master@{#468635}

Automatically generated ARCMigrate commit
Notable issues:None
BUG=624363
TEST=None

Review-Url: https://codereview.chromium.org/2810193004
Cr-Commit-Position: refs/heads/master@{#468634}

BUG=583292
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2852293002
Cr-Commit-Position: refs/heads/master@{#468633}

Added command line flag to enable testing of RTL rendering of LTR
languages (and vice versa). Complements "--force-ui-direction".

BUG=716660

Review-Url: https://codereview.chromium.org/2853523002
Cr-Commit-Position: refs/heads/master@{#468632}

https://skia.googlesource.com/skia.git/+log/ab865b088397..687cc6c03350

$ git log ab865b088..687cc6c03 --date=short --no-merges --format='%ad %ae %s'
2017-05-01 msarett colorspaceinfo tool: Add flag to indicate that the input is an icc profile

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: If76514362c10ae8cff7561730e986a0cd474c3fd
Reviewed-on: https://chromium-review.googlesource.com/493366Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468631}

BUG=717322

Review-Url: https://codereview.chromium.org/2853163002
Cr-Commit-Position: refs/heads/master@{#468630}

We're removing some indirect includes from SkCanvas.h; updating clients
to explicitly include required headers.
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

TBR=enne@chromium.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2855863002
Cr-Commit-Position: refs/heads/master@{#468629}

This CL contains:
1.Adding constants for a new preference name (password_manager_pref_names.*)
2.Registring a new preference in a stotic method of password_manager.cc (it's a place where all password related preferences are registered)
3.Adding |prefs| argument to PasswordStore->Init and passing prefs to PasswordReusedDetector in PasswordStore->Init
4.Saving |prefs| to a member variable in PasswordReusedDetector
5.Saving an empty string to the new preference in PasswordReusedDetector->SaveSyncPasswordHash: an empty string is saving because: we can test that saving to a preference works in PasswordReusedDetector and to avoid unused error.
6.Test in password_reuse_detector_unittest.cc that saving to the preference is working.
7.Changes in all others files are just adding prefs argument to all overrides of Init method and passing nullptr in tests to this parameter.

BUG=657041

Review-Url: https://codereview.chromium.org/2846023003
Cr-Commit-Position: refs/heads/master@{#468628}

This CL updates 'Control how this works in Settings' UI strings.

BUG=704639

Review-Url: https://codereview.chromium.org/2849153003
Cr-Commit-Position: refs/heads/master@{#468627}

The variable and its related function is only used in one subclass, so it
shouldn't sit in the base class and possibly mislead folks.

BUG=711576

Review-Url: https://codereview.chromium.org/2842793003
Cr-Commit-Position: refs/heads/master@{#468626}

This handle is always uniquely owned, anyhow. And the indirection through
ScriptController adds very little value.

BUG=None

Review-Url: https://codereview.chromium.org/2855753002
Cr-Commit-Position: refs/heads/master@{#468625}

This is part of a series of CLs to get rid of the notion of
"Instant support" entirely, see
https://bugs.chromium.org/p/chromium/issues/detail?id=627747#c41

BUG=627747

Review-Url: https://codereview.chromium.org/2852693002
Cr-Commit-Position: refs/heads/master@{#468624}

TBR=bccheng@chromium.org, llozano@chromium.org

Bug: 717212
Change-Id: I9c49245e51af14973c3049bf52aa3774bd261341
Reviewed-on: https://chromium-review.googlesource.com/493246
Commit-Queue: Ned Nguyen <nednguyen@google.com>
Reviewed-by: Ned Nguyen <nednguyen@google.com>
Cr-Commit-Position: refs/heads/master@{#468623}

Also remove tests we don't run from being built:
gpu_ipc_service_unittests
media_unittests
midi_unittests

BUG=717488
NOTRY=True

Review-Url: https://codereview.chromium.org/2854823002
Cr-Commit-Position: refs/heads/master@{#468622}

BUG=631966
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2755093002
Cr-Commit-Position: refs/heads/master@{#468621}

https://skia.googlesource.com/skia.git/+log/d271ba268876..ab865b088397

$ git log d271ba268..ab865b088 --date=short --no-merges --format='%ad %ae %s'
2017-05-01 msarett Remove legacy pixelref flag from bzl

Created with:
  roll-dep src/third_party/skia


Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, see:
http://www.chromium.org/developers/tree-sheriffs/sheriff-details-chromium#TOC-Failures-due-to-DEPS-rolls


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=scroggo@chromium.org

Change-Id: I5f16bfb75524c496956ff8aeec8515a87b3533e8
Reviewed-on: https://chromium-review.googlesource.com/492730Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#468620}

Skip need-dircrypto-migration check if ARC is not available
or migration UI is disabled.

BUG=712580

Review-Url: https://codereview.chromium.org/2849333002
Cr-Commit-Position: refs/heads/master@{#468619}

This change introduces a presubmit check ensuring that developers modifying
.fbs files in subresource_filter get reminded to change IndexedRuleset format
version (if that is required).

BUG=609747

Review-Url: https://codereview.chromium.org/2850813003
Cr-Commit-Position: refs/heads/master@{#468618}

BUG=697041

Review-Url: https://codereview.chromium.org/2852703002
Cr-Commit-Position: refs/heads/master@{#468617}

TBR=jif@chromium.org

Review-Url: https://codereview.chromium.org/2845483002
Cr-Commit-Position: refs/heads/master@{#468616}

This CL adapts the defaults in user classification to the values planned
for the M58 Stable rollout.

BUG=none

Review-Url: https://codereview.chromium.org/2845483003
Cr-Commit-Position: refs/heads/master@{#468615}

These have been failing for quite a while.

BUG=717314,717309,717300

Review-Url: https://codereview.chromium.org/2853153002
Cr-Commit-Position: refs/heads/master@{#468614}

The local VM is Windows 10 and the LayoutTests are passing, so force
swarming to also run on Windows 10.

BUG=717344
TBR=dpranke@chromium.com,mcgreevy@chromium.org

Review-Url: https://codereview.chromium.org/2850423002
Cr-Commit-Position: refs/heads/master@{#468613}

BUG=715638

Review-Url: https://codereview.chromium.org/2850493002
Cr-Commit-Position: refs/heads/master@{#468612}

TraceEventMemoryOverhead is a rather simple class which only purpose is
accounting various sources of memory overhead due to tracing itself.
For debugging purposes it keeps track of the actual class causing
overhead, so that they can be inspected distinctly in the tracing UI
The current implementation was using a small_map indexed by
const char* pointer, which has a bunch of problems:
- base::small_map can degenerate into a STL map when exceeding the
  inline capacity, which in turn can cause some extra impredictability,
  see "[chromium-dev] Please avoid std::unordered_map".
- The map implicitly assumes that two identical string literals will have
  identical pointers, which is not true, esepcially in component builds.
- Any sort of map is a really over-engineered solution, given that the
  sources of overheads we care about are known a priori and are a
  manageable number.

Hence, this CL is switching the implementation of
TraceEventMemoryOverhead to be just enum-base, which ditches completely
the map.

BUG=717223

Review-Url: https://codereview.chromium.org/2857543002
Cr-Commit-Position: refs/heads/master@{#468611}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/7641bfdd..54c14a48

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,vogelheim@chromium.org

Review-Url: https://codereview.chromium.org/2853233002
Cr-Commit-Position: refs/heads/master@{#468610}

BUG=703184

Review-Url: https://codereview.chromium.org/2844273002
Cr-Commit-Position: refs/heads/master@{#468609}

ScopedTaskEnvironment allows usage of ThreadTaskRunnerHandle and
base/task_scheduler/post_task.h within its scope. It should be
instantiated in everytest that uses either of these APIs
(i.e. no test should instantiate a MessageLoop directly).

Motivation for ScopedTaskEnvironment can be found in:
https://docs.google.com/document/d/1QabRo8c7D9LsYY3cEcaPQbOCLo8Tu-6VLykYXyl3Pkk/edit

BUG=708584

Review-Url: https://codereview.chromium.org/2851593002
Cr-Commit-Position: refs/heads/master@{#468608}

The RequestFileSystemDialogView class had an unused member contents_view_ which is no longer needed after https://codereview.chromium.org/2816293002/diff/520001.

Removing this should fix the memory leak. Thanks to lazyboy for helping track down this leak.

BUG=717057
TBR=pkasting

Review-Url: https://codereview.chromium.org/2855663002
Cr-Commit-Position: refs/heads/master@{#468607}

This changes the AutofillCounter to indicate that autofill data is synced.

BUG=681523

Review-Url: https://codereview.chromium.org/2828083003
Cr-Commit-Position: refs/heads/master@{#468606}

This CL moves part of deferred initialization tasks from DeferredStartupHandler
to ProcessInitializationHandler to split responsibilities.

BUG=716454

Review-Url: https://codereview.chromium.org/2853513002
Cr-Commit-Position: refs/heads/master@{#468605}

Since the execution order of tasks across task queues is not
guaranteed[1], the task that controls the expiration of the virtual time
budget can run in a random order w.r.t. the tasks virtual time is
actually controlling. This patch makes the ordering deterministic by
using the control task queue (i.e., always the highest priority) to
reset the virtual time policy when the budget expires.

BUG=696001,701223

[1] https://codereview.chromium.org/2786083005/

Review-Url: https://codereview.chromium.org/2841463003
Cr-Commit-Position: refs/heads/master@{#468604}

Needed for reland of https://codereview.webrtc.org/2622263002/

BUG=webrtc:5880

Review-Url: https://codereview.chromium.org/2855783003
Cr-Commit-Position: refs/heads/master@{#468603}

The local VM is Mac-10.12 and the LayoutTests are passing, so force
swarming to also run on Mac-10.12

BUG=717344
TBR=dpranke@chromium.com,mcgreevy@chromium.org

Review-Url: https://codereview.chromium.org/2848253005
Cr-Commit-Position: refs/heads/master@{#468602}

This test should be part of https://codereview.chromium.org/2821303005
but at that time I didn't find the way to focus/unfocus an iframe.
The solution was to use internals.setFocused() for that purpose.

This patch adds a new test pretty similar to the one for windows
(fast/selectors/focus-within-window-inactive.html),
but checking what happens when an iframe loses and regains focus.

BUG=617371
TEST=fast/selectors/focus-within-iframe.html

Review-Url: https://codereview.chromium.org/2847803007
Cr-Commit-Position: refs/heads/master@{#468601}

After the Drive API supports Team Drive, each Team Drive can be queried
for its changes individually, in addition to the files owned by a user.
This is necessary to fetch change of files under Team Drive, especially
those created by another user.

TEST=google_apis_unittests --gtest_filter=DriveApiRequestsTest.*:DriveApiUrlGeneratorTest.*
BUG=715355

Review-Url: https://codereview.chromium.org/2854653004
Cr-Commit-Position: refs/heads/master@{#468600}

crrev.com/2823183003 was the first step towards removing the SizingOperation
enum which was added in the past as a convenient way to modify the track
sizing algorithm behaviour depending on whether the size was
indefinite/definite but also on whether we were computing the grid intrinsic
size or doing a layout. As mentioned in the CL above that was a mistake
because indefinite sizes do not always correspond to preferred widths
computations.

Now that we have the algorithm in a separate class with different strategies
the existence of that enum is no longer required. We can handle the
remaining code path using SizingOperation just by using the algorithm
strategies.

No new tests required as this does not imply a change in the behaviour.

Review-Url: https://codereview.chromium.org/2842413003
Cr-Commit-Position: refs/heads/master@{#468599}