- 26 May, 2020 40 commits
-
-
Leonard Grey authored
On 10.12, the window server is fine initiating a drag without this, so we end up with two drags starting. This actually doesn't fix the teleporting windows bug, but it can't help! Bug: 897274 Change-Id: I2e181659c504c90db0a0928747f5485419728fe8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2207980Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#771854}
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1590494094-23904e540b881376a708d1584e8efd523290bbdf.profdata to chrome-mac-master-1590508570-a99506fab2213a01c13861c108d98c27cee7cc0b.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:mac-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: Iae36f2b55da219314881fe9359e0c11b6c02522f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216363Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771853}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/0638b6b9527b..ba4e2b94289d 2020-05-26 msisov@igalia.com Type cast EGLNativeDisplayType to _XDisplay* in xcb and glx If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC ynovikov@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: chromium:1084458 Tbr: ynovikov@google.com Change-Id: I7fe7d6417459eda95981c6818a318acd9f0bd359 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216168Reviewed-by:
-
Peng Huang authored
Looks like the crash in https://crbug.com/1086428 is because GrContext is not initialized successfully, and then we are accessing the nullptr GrContext, and then segment fault happens. Fix the problem by making GetSharedContextState() return nullptr if GrContext cannot be initialized. Bug: 1086428 Change-Id: I288fc6832d6b0c838e16c119354e50db2ad2af80 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214912 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Jonathan Backer <backer@chromium.org> Auto-Submit: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#771851}
-
jorgegil@google.com authored
Fixes issue where occlusion tracking could start sending updates before the surface state had been committed. In ARC, this meant that occlusion updates were sent before the surface bounds were first set, leading to incorrect "full occlusion (1.0f) updates". Bug: b:149229321 Test: exo_unittests Change-Id: Ia885a44cf38658cc82d87273f70395c8bc2fcf72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212921 Commit-Queue: Jorge Gil <jorgegil@google.com> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Eliot Courtney <edcourtney@chromium.org> Cr-Commit-Position: refs/heads/master@{#771850}
-
Yury Semikhatsky authored
This reverts commit c6d15649. Reason for revert: the problem with gmail offline service workers mentioned in the bug has been fixed by http://crrev.com/c/2213550 and http://crrev.com/c/2213783. Bug: 1085150 Original change's description: > Revert "[DevTools] Properly notify devtools agent host when service worker is destroyed" > > This reverts commit 1537d629. > > Reason for revert: potentially breaks gmail reloading when disabling offline mode with DevTools open. > > Bug: 1085150 > > Original change's description: > > [DevTools] Properly notify devtools agent host when service worker is destroyed > > > > ServiceWorkerDevToolsAgentHost now stores thread-safe reference to > > ServiceWorkerContextWrapper instead of ServiceWorkerContextCore that > > could be deleted asynchronously on the service worker core thread. > > > > WorkerDestroyed notification is now sent to the observers of > > ServiceWorkerDevToolsManager iff the worker version is both stopped > > and doomed. Each worker can be terminated (and restarted) multiple times > > and will result in a sequence of targetCrashed/targetReloadedAfterCrash > > events in the protocol but the instance of its > > ServiceWorkerDevToolsAgentHost will survive restarts and all connected > > sessions will be preserved. > > > > It fixes the events generated in the protocol for service workers from > > targetCreated, (detachedFromTarget, attachedToTarget, targetReloadedAfterCrash)* to > > targetCreated, (targetCrashed/targetReloadedAfterCrash)*, targetDestroyed > > and avoids inadvertent session terminations when workers are stopped and > > also spurious targetReloadedAfterCrash events. > > > > Bug: none > > Change-Id: I1125604d08b7842f7f8d74751091193b9af2cb59 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2099590 > > Commit-Queue: Yury Semikhatsky <yurys@chromium.org> > > Reviewed-by: Tsuyoshi Horo <horo@chromium.org> > > Reviewed-by: Dmitry Gozman <dgozman@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#750975} > > TBR=dgozman@chromium.org,horo@chromium.org,caseq@chromium.org,yurys@chromium.org,einbinder@chromium.org > > # Not skipping CQ checks because original CL landed > 1 day ago. > > Bug: none > Change-Id: Ibba7ce840b8c8b73c32086d141005306591e21cc > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213448 > Reviewed-by: Yury Semikhatsky <yurys@chromium.org> > Commit-Queue: Yury Semikhatsky <yurys@chromium.org> > Cr-Commit-Position: refs/heads/master@{#771365} TBR=dgozman@chromium.org,horo@chromium.org,caseq@chromium.org,yurys@chromium.org,einbinder@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1085150, none Change-Id: I7afbb1f53a4940f931ad0722b52da3b307223663 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213817Reviewed-by:
Yury Semikhatsky <yurys@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Yury Semikhatsky <yurys@chromium.org> Cr-Commit-Position: refs/heads/master@{#771849}
-
manuk authored
Follow up on crrev.com/c/2108780. Bug: 1062446 Change-Id: I742fdc3b8314bb717cde70e2d261b6fdb21b3936 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213125Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#771848}
-
Bo Liu authored
The code is also incorrect as it skips checking other states. Bug: 1084500 Change-Id: I44ef55b2c47fca901e9c6f52e5cc07834aa858d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215405Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771847}
-
Andrew Grieve authored
It was getting the package name from --apk-under-test, but for smoke tests the apk-under-test != targetPackage. Bug: None Change-Id: I39989b3417d3cdc9320d0231c2b78a3dadb19744 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216031 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#771846}
-
Gabriel Charette authored
This is preventing the migration of callers that use BrowserTaskTraits specific traits when invoking GetUIThreadTaskRunner() @ https://chromium-review.googlesource.com/c/chromium/src/+/2211138/8 R=altimin@chromium.org Bug: 1026641 Change-Id: I098daf92d861447049315332f42d2d53fae15d1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212992Reviewed-by:
Alexander Timin <altimin@chromium.org> Commit-Queue: Gabriel Charette <gab@chromium.org> Auto-Submit: Gabriel Charette <gab@chromium.org> Cr-Commit-Position: refs/heads/master@{#771845}
-
Liviu Tinta authored
The tests in pointer_lock_browsertest.cc were flaky for 3 reasons: - requestPointerLock being asynchronous - mouse events being asynchronous - native mouse events interfering with tests during execution All the above were addressed in prior CLs. Bug: 766450 Change-Id: Ic046bce6c81a9bcc8d1f78a5c56506ed959b45ec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213202Reviewed-by:
-
Kush Sinha authored
Add metrics to identify the source of account additions and re-auth on Chrome OS. Bug: 1082780 Test: Manually Change-Id: I1f3df57f5b5ef3c731f75156e61992812c7f78b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214531 Commit-Queue: Kush Sinha <sinhak@chromium.org> Reviewed-by:
Anastasiia N <anastasiian@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Cr-Commit-Position: refs/heads/master@{#771843}
-
chromium-autoroll authored
https://chromium.googlesource.com/external/github.com/google/shaderc/+log/7d2f8c57ee3e..b4a735cc1ada 2020-05-26 rharrison@google.com Rolling 4 dependencies and expectations (#1074) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/shaderc-chromium-autoroll Please CC radial-bots+chrome-roll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: radial-bots+chrome-roll@google.com Change-Id: I3bde52413d9ccaac13bc450cdba02570ed204dc9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216161Reviewed-by:
-
Jan Krcal authored
This CL breaks down previously reported failures per data type into particular call sites of ReportError(). Bug: 1080844 Change-Id: I9f30f6981a772b414926c97a2a5c499061565b27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212276 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Jan Krcal <jkrcal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Reviewed-by:
Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#771841}
-
Raphael Kubo da Costa authored
Follow-up to commit 701cae5d ("Introduce a function to format a DER-encoded SPKI for UI"). That is the format used by other files that include <certt.h>, and the pkg-config configuration already passes -I/path/to/nss to the compiler. This can potentially fix the non-sysroot build, as the NSS headers might be installed in e.g. /usr/include/nss3 rather than /usr/include/nss. Change-Id: I0461a7a7f8c93459f2281ea71c96434a74687ee8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214390 Auto-Submit: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: David Benjamin <davidben@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#771840}
-
Victor Hugo Vianna Silva authored
This CL introduces the functionality for the cancel button in the new PasswordSaveUnsyncedCredentialsLocallyView. Clicking the button clears the unsynced credentials stored in ManagePasswordsState, closes the bubble and moves the password manager UI to the INACTIVE_STATE. Bug: 1060132 Change-Id: Ide4dac9bf653671f43c67ba9fd92d3feead4b2a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216210 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#771839}
-
Tomas Popela authored
The main reason for the flag is so called dialog hell, when you try to share the screen on Wayland through PipeWire. To address it we've created two changes, that are currently under review[0][1]. Once that's done the flag could be removed. [0] - https://webrtc-review.googlesource.com/c/src/+/160649 [1] - https://chromium-review.googlesource.com/c/chromium/src/+/1942327 Bug: 682122 Change-Id: Ida77d4c8c16250201ae2b9f27e687325f4fcdd46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214885 Auto-Submit: Tomáš Popela <tomas.popela@gmail.com> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Sadrul Habib Chowdhury authored
When wheel-events are dispatched to the renderer to perform a scroll, it can start a compositor-driven animation to perform the scroll. The animation can continue even after the event-dispatch completes. As a result, for a synthesized scroll, when the request for WaitForInputProcessed() returns to the browser, not all of the desired scrolls may have taken effect. To fix this, introduce a notification API in LayerTreeHost for when any ongoing scroll animation ends. Use this API to ensure all scroll-animations drive by the compositor are complete before returning from a WaitForInputProcessed() request. BUG=1085891 Change-Id: Ie4d67df69786cd30da7d830fa3f952967f1399be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213401Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#771837}
-
Fredrik Söderqvist authored
With the current setup, SVGEnumerationBase is where the actual enumeration is stored, while SVGEnumeration<Enum> is a layer added to provide some type-safety. With the current implementation of this, we require a Clone() implementation in the "type-safe accessor(s)" to produce a copy of a specific derived class. This is a circular self-dependency though (add a specific vtable so that we can produce instances with that specific vtable) since all the actual data that needs to cloned exists in the SVGEnumerationBase class. Hence we can move the Clone() implementation up the class hierarchy and strip SVGEnumeration of anything that would end producing a specific vtable for it. This essentially leaves SVGEnumeration as thin shim for enumeration <-> (ordinal) value mapping. Because there (after some preparatory CLs) are very few accesses left that are done via the "type-safe accessor", just merge it into SVGEnumerationBase and drop the "Base" suffix. This weakens the type- safety guarantees a little bit in theory, but in practice the majority of all enumeration accesses are done via SVGAnimatedEnumeration - which retains the enumeration type binding. This gets rid of all the virtually (no pun intended) identical Clone() implementations of the various SVGEnumeration<Enum> instantiations. Change-Id: I9790fc153bf819a7c9623ff01e287c3c70ec27ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2204181 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by:
Philip Rogers <pdr@chromium.org> Cr-Commit-Position: refs/heads/master@{#771836}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/4b342721d088..b9e90b03da08 2020-05-26 tvanderlippe@chromium.org Typecheck sdk/LayerTreeBase.js with TypeScript 2020-05-26 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. 2020-05-26 patrick.brosset@microsoft.com DevTools: Introducing a new e2e test for the Changes panel If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1011811,chromium:1079076,chromium:1079233 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I5cfa58abc25d016faaca6e492dfe078cd883a270 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216153Reviewed-by:
-
Timothy Gu authored
They will be used to test the font fallback behavior of emojis. Cq-Include-Trybots: luci.chromium.try:linux-blink-rel;luci.chromium.try:mac10.10-blink-rel;luci.chromium.try:mac10.11-blink-rel;luci.chromium.try:mac10.12-blink-rel;luci.chromium.try:mac10.13-blink-rel;luci.chromium.try:mac10.13_retina-blink-rel;luci.chromium.try:mac10.14-blink-rel;luci.chromium.try:mac10.15-blink-rel;luci.chromium.try:win7-blink-rel;luci.chromium.try:win10-blink-rel Bug: 767754 Change-Id: I8be099e5e73edb364a3e4f6deb4ba1c93991b0b1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2209991Reviewed-by:
Robert Ma <robertma@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Commit-Queue: Timothy Gu <timothygu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771834}
-
Maksim Sisov authored
Bug: 1085806 Change-Id: I23b46e0ba663a9eef7539050ce8c6998fa3fb70c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214898 Auto-Submit: Maksim Sisov <msisov@igalia.com> Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
-
Tina Wang authored
- This CL patches https://chromium-review.googlesource.com/c/experimental/chromium/src/+/2194583 from experimental branch. - Put the change behind a flag. Bug: 1082044 Change-Id: I9a7cb72f529d10558e0bc7cd3da5c2e7877f9676 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2211082 Commit-Queue: Tina Wang <tinazwang@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#771832}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/31001a610da6..c33eeab2ca42 2020-05-26 jianjun.zhu@intel.com Fix an incorrect use of iterator. 2020-05-26 courtneyfe@chromium.org Add INSTANTIATE_TEST_SUITE_P as needed. 2020-05-26 philipp.hancke@googlemail.com build: remove WEBRTC_CODEC_RED If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I9ce0e1b851452b6ddbd0757ae75b2514449b2a94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216160Reviewed-by:
-
Ravjit Singh Uppal authored
Exceptions defined via extensions for plugin content settings, that have wildcard in their patterns will be completely ignored after this CL Bug: 1073883 Change-Id: I47ee2a335101eb6a1660e5d1676cd4827c99809e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214529 Commit-Queue: Ravjit Singh Uppal <ravjit@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#771830}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/42033b2c6a25..ea71aeab0bfb 2020-05-26 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial). If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I2e6a9a0437846b6a9f1cd7c875cb6dc82d2e5d86 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216163Reviewed-by:
-
Gauthier Ambard authored
This CL fixes a crash that happens when we are checking if the last committed item has the same URL as the current/back/forward item and then updates its UserAgent. This fix wasn't fully working. The correct fix is crrev.com/c/2193994. Removing the code allows to cleanup the code for the correct fix, and remove the crash. As it wasn't really fixing the issue in the first place, the regression isn't an issue. Fixed: 1085348 Change-Id: I7c45ab5709e70f31edfc5eb3989f2c235ddbbac1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215846 Auto-Submit: Gauthier Ambard <gambard@chromium.org> Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#771828}
-
Thomas Lukaszewicz authored
Initial commit with OWNERS file and basic TabSearchBubbleView shell to establish project directories. Follow up with bubble improvements. Bug: None Change-Id: I869da0528f9de3fc8b2ddfd715cf29a10adfaa04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2203259 Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#771827}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/55e97987f5f2..61fc1e664eac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC bcwhite@google.com,marinaciocea@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: bcwhite@google.com,marinaciocea@google.com Change-Id: I65b44219b7a2875329467b7f2873b9746e308824 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216158Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771826}
-
Evan Stade authored
This adds the necessary plumbing for WebShare to work on WebLayer. Test site: https://w3c.github.io/web-share/demos/share-files.html Bug: 1066285 Change-Id: I1ce311fa094de0d2222c6834ef73eff8989b1b2f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2182875Reviewed-by:
Mike West <mkwst@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#771825}
-
Adam Rice authored
This commit removes the quota system from renderer to network service data transfer, and moves completely to mojo data pipe. This is a follow-up CL from the following CLs: https://chromium-review.googlesource.com/c/chromium/src/+/2071189 https://chromium-review.googlesource.com/c/chromium/src/+/2206556 Design Doc: https://docs.google.com/document/d/1YWj1z9r8wxemGdod6S2tkchudhp6PvNaH3qSO0oucfY/ This is a rebase of https://chromium-review.googlesource.com/c/chromium/src/+/2120193, originally by Keita Suzuki. Bug: 1056030 Change-Id: Ibc84448e56cad0cc2d8d4ed4a2ef4411b28be104 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2210333Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Eric Roman <eroman@chromium.org> Auto-Submit: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#771824}
-
Allen Bauer authored
Bug: 1044687 Change-Id: I5410bf455b0b7cb2c4977df13fbbe581de2cd62f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2212493 Commit-Queue: Allen Bauer <kylixrd@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#771823}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/19ffa683a1c0..06266f79ede7 2020-05-26 key.draw@gmail.com [canvaskit] add a gm for testing particles 2020-05-26 michaelludwig@google.com Simplify GrRTC::clean APIs If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC westont@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: westont@google.com Change-Id: I5b9df893dbb7dd60dc80d17dd5b96f5b977db00c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216154Reviewed-by:
-
Bo Liu authored
WindowAndroid destroy relies on Activities being destroyed in tests. There is a bug on L where DestroyActivitiesRule does not end up destroying all Activities. Relax LifetimeAssertRule in that case. Bug: 1081250 Change-Id: I21e191b4a3257124ea6e4514f09ae0772f59b048 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2213062Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#771821}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/43b6446650dc..9b5a24e66f12 2020-05-26 dproy@google.com Merge "ui: Introduce analyze page with multiline SQL input box" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: Ie105acd5baea99f47e241272ecdac8ddd72db168 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2216152Reviewed-by:
-
Lukasz Anforowicz authored
Bug: 1069567 Change-Id: I8333f375425024ed83b4ccf23492257c6b773c3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158059 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#771819}
-
Stephan Hartmann authored
GCC complains that explicit specialization in non-namespace scope is happening for GetValue. Move the methods outside the class definition. Bug: 819294 Change-Id: I109472a0b6fa7ddab3529bc92bba680252b40f67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128307Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Camille Lamy <clamy@chromium.org> Cr-Commit-Position: refs/heads/master@{#771818}
-
Victor Hugo Vianna Silva authored
This CL introduces the functionality for the save button in the new PasswordSaveUnsyncedCredentialsLocallyView. The saving logic lives in ManagePasswordsUIController, as is done for the save bubble. The bubble controller now also retrieves the credentials from the UI controller when needed, instead of copying them. In this way, the credentials live in a single place (ManagePasswordsState) and can be easily cleared. Bug: 1060132 Change-Id: Id59f4fd3a4d642aade389d207e3290b049c8d867 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2139653 Commit-Queue: Victor Vianna <victorvianna@google.com> Reviewed-by:
-
David Van Cleve authored
Since M85 will likely be the first stable release with the pending referrer changes fully rolled out, extend the referrer policy histograms, used for measuring this change's effectiveness, to 2020-12-30; this will give plenty of time to analyze a holdback after M85 stable. R=csharrison Fixed: 1084041 Change-Id: I433a7226263440f31e4879d2757aefa247764a5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2214915Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Commit-Queue: David Van Cleve <davidvc@chromium.org> Auto-Submit: David Van Cleve <davidvc@chromium.org> Cr-Commit-Position: refs/heads/master@{#771816}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 290dd0f0. Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: mkwst@chromium.org: external/wpt/cookies NOAUTOREVERT=true TBR=smcgruer No-Export: true Change-Id: I08096e6e3bde44d014d94ef132e2ebc797ea7aba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215907Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#771815}
-
