- 30 Jan, 2020 37 commits
-
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/38fc743463bb..141427882038 Created with: gclient setdep -r src-internal@141427882038 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:1034774 Tbr: jbudorick@google.com Change-Id: I36bc779078d90d73dd1a0b6a6a0a43268d4bca0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028633Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736658}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/184ea66aed43..1cf15bfe55a3 git log 184ea66aed43..1cf15bfe55a3 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 srte@webrtc.org Adds product operator for TimeDelta and Frequency Created with: gclient setdep -r src/third_party/webrtc@1cf15bfe55a3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I124cad6e41a8fa4eb399fcaa6e97df2fde96e681 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029209Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736657}
-
Meredith Lane authored
i2s: https://groups.google.com/a/chromium.org/g/blink-dev/c/882iPcdnNQs Change-Id: If370d04c2a9de6063bf3bd5f653302495285328e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2015862Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Meredith Lane <meredithl@chromium.org> Cr-Commit-Position: refs/heads/master@{#736656}
-
Ahmed Mehfooz authored
Also added new content layer type for sliders to bring slider colors in line with ux specs. Bug: 960118 Change-Id: I5be99cb731ba77c3d32550a34d55bb5c4e8a5e5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024327 Commit-Queue: Ahmed Mehfooz <amehfooz@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#736655}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: I9b5eddbaec07783f7bc2491c5a860b349c1e33a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029167 Commit-Queue: Krishna Govind <govind@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#736654}
-
Ryan Hamilton authored
Change-Id: I215b0a96bef3079df165a62828b0dcdcc3440f53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028256Reviewed-by:
Ryan Hamilton <rch@chromium.org> Reviewed-by:
Zhongyi Shi <zhongyi@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#736653}
-
Lambros Lambrou authored
The Me2Me host process was creating a test capturer, and keeping it alive for the duration of the host process (until SIGTERM). This might prevent unlocking the system using Apple Watch. See for example, https://support.apple.com/en-us/HT206995 "Make sure that your Mac isn't using Internet sharing or screen sharing." This CL destroys the DesktopCapturerChecker immediately after triggering a single frame capture. Testing on Catalina 10.15.2 confirms that this is still sufficient to trigger the MacOS system prompt and add the app to the list of Screen Recording apps in Security & Privacy. This is also consistent with what It2Me host was already doing. Bug: 1047016 Change-Id: I110ada15e5af4b127e2c52cd3c3e3c80872fb9be Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029235 Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Jamie Walch <jamiewalch@chromium.org> Auto-Submit: Lambros Lambrou <lambroslambrou@chromium.org> Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Cr-Commit-Position: refs/heads/master@{#736652}
-
Jamie Walch authored
Enabling relative mouse mode causes trunk Windows host to crash, which I think is caused by the new cursor compositing code (the current release does not crash). Since I don't have a Windows build environment set up, I'm disabling it for Windows for now while I investigate. Change-Id: Ida7d5be7a79f23b2fb52136ffea7911eef01f8d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029451 Auto-Submit: Jamie Walch <jamiewalch@chromium.org> Reviewed-by:
Lambros Lambrou <lambroslambrou@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#736651}
-
Rune Lillesveen authored
Intent to ship thread: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/-_0REgUR-yY Bug: 939811, 925935 Change-Id: I00e1b7ffc162b2b226db1a722391a61a5386cb51 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027328Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#736650}
-
Avery Musbach authored
Test: ash_unittests All/SplitViewOverviewSessionTest.SplitViewWindowReinsertedToOverviewAtCorrectPositionWhen* Bug: None Change-Id: I14d6ae52642af223627559b052dc8dc7ae0f6148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2024148Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Avery Musbach <amusbach@chromium.org> Cr-Commit-Position: refs/heads/master@{#736649}
-
Kouhei Ueno authored
Bug: None Change-Id: Ib3767ed990e74b7b8f82b3784143c370954da874 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027011Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Mason Freed <masonfreed@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Commit-Queue: Kouhei Ueno <kouhei@chromium.org> Cr-Commit-Position: refs/heads/master@{#736648}
-
Carlos IL authored
This fixes the failing test by: -Changing it to wait for two navigations with CI on. -Fixing an issue caused by TestAwWebContentsObserver where it was causing OnPageFinished to fire twice. Bug: 1045549 Change-Id: I609b6beb2bcb6a1426b7dde967b65bc7f104d0d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029270Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#736647}
-
Robbie McElrath authored
We're seeing reports of IVariationsSeedServer.Stub.getSeed throwing a RuntimeException due to being provided an invalid file descriptor. I haven't been able to reproduce the issue locally, so this is a speculative fix that catches the exception to prevent a crash. We believe the crash is caused by the service dying and restarting, in which case onServiceConnected will be called a second time. This CL checks if the file descriptor is still valid before making the getSeed call. Test: Manually verify seeds can still be fetched correctly. Bug: 1028004 Change-Id: I1b11911678e08883c95132eded2702a8b73c8a24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1954352Reviewed-by:
Changwan Ryu <changwan@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#736646}
-
Jarryd authored
Use DCHECK_GT instead of DCHECK where appropriate, add a const modifier for an unmodified parameter, and add missing includes. Change-Id: I7f7d6e8a8b50a8e145b24daed44ac5d25bad76aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028859Reviewed-by:
Ben Kelly <wanderview@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#736645}
-
sczs authored
Failures were fixed by: https://chromium-review.googlesource.com/c/chromium/src/+/2023891 Bug: 1046096, 1045966 Change-Id: I6b1c2223768f9cee5ef20fc25426a889999c5a2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029231 Commit-Queue: Sergio Collazos <sczs@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Sergio Collazos <sczs@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#736644}
-
Joshua Bell authored
Fixed in https://crrev.com/735070 - wpt.fyi shows green since then. Bug: 1045260 Change-Id: I2cbf8e614613309192be47a3da564e8281fcecaa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023192 Commit-Queue: Darwin Huang <huangdarwin@chromium.org> Reviewed-by:
Darwin Huang <huangdarwin@chromium.org> Auto-Submit: Joshua Bell <jsbell@chromium.org> Cr-Commit-Position: refs/heads/master@{#736643}
-
Mohamed Heikal authored
This cl is a setup to allow the android-binary-size trybot recipe to link the metrics listed in the gerrit plugin json with related logs without requiring the logs to be archived to cloud storage. Change-Id: I4a8d8377ef5f5b7670b7fc70e1ec46b2632da2de Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026308 Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#736642}
-
Chris Lu authored
TBR=gambard@chromium.org Bug: 1046998 Change-Id: Iba814af492a4e456e8ec720dcde976165ade7eb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029168Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Chris Lu <thegreenfrog@chromium.org> Auto-Submit: Chris Lu <thegreenfrog@chromium.org> Cr-Commit-Position: refs/heads/master@{#736641}
-
Nate Fischer authored
No change to logic, only docs. This clarifies that WebView requires debuggable Android images for all commandline flags, including netlog. This repeats a code snippet for checking if your device supports commandline flags. Bug: 918221 Test: tools/md_browser/md_browser.py Test: Upload to gerrit > open file > click "gitiles" Change-Id: I03ebc095ee78744e9dfdbf9c113b418c57a53e7e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029190Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#736640}
-
Xiaocheng Hu authored
Font::CanShapeWordByWord() depends on font face specific data, and hence, will be invalidated after a font face is loaded. This patch moves the computation and caching from Font to FontFallbackList, so that we don't need to invalidate Font for the data after loading a font face. This is preparation for crrev.com/c/1952189 that reduces invalidations after font loading. Bug: 441925 Change-Id: I605ffbc3981a56f6653cb32d5415b291b03f3b0c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026594 Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Reviewed-by:
Dominik Röttsches <drott@chromium.org> Cr-Commit-Position: refs/heads/master@{#736639}
-
Carlos IL authored
Tests that involve clicking a link that results in a redirect were failing with committed interstitials enabled. This CL changes the check used to catch that case. Bug: 1046832 Change-Id: Ib57bf24307b58b8441250aa448c271066e8b8ad6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028299Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Commit-Queue: Carlos IL <carlosil@chromium.org> Cr-Commit-Position: refs/heads/master@{#736638}
-
Andrew Moylan authored
Bug: none Change-Id: I4ee105f45fb6f362e1e218e509aff98a6c48b839 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2026912 Auto-Submit: Andrew Moylan <amoylan@chromium.org> Commit-Queue: Tony Yeoman <tby@chromium.org> Reviewed-by:
Tony Yeoman <tby@chromium.org> Cr-Commit-Position: refs/heads/master@{#736637}
-
Ken MacKay authored
Bug: internal b/138682004 Change-Id: Ifcdb6af2ae4f55f723d2c7b793878ba17f7edb9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2029195Reviewed-by:
Yuchen Liu <yucliu@chromium.org> Commit-Queue: Kenneth MacKay <kmackay@chromium.org> Cr-Commit-Position: refs/heads/master@{#736636}
-
Tommy Li authored
The omnibox uses BitmapFetcher to get Entity Suggestion images. For on-focus suggestions, sometimes the images are included inline with the Suggest results as data: URLs. This currently fails to render, because BitmapFetcher cannot handle them. This CL makes BitmapFetcher handle them and includes a test. I implemented this functionality as part of BitmapFetcher instead of further upstream, because there are multiple callers to BitmapFetcher that may also run into this gotcha in the future, and it would be unfortunate if they each had to write their own code to handle data: URLs. Bug: 1015174 Change-Id: Ibb68f0d0efdcaa8107d486dd88e3e3ccb50e2b84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017962Reviewed-by:
Ryan Sleevi <rsleevi@chromium.org> Reviewed-by:
Rachel Blum <groby@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736635}
-
Joshua Bell authored
The manager had only a single owner (StoragePartitionImpl) so there was no reason it needed to be refcounted. Change ownership to be unique_ptr. Change-Id: Iea1895ecc41cb9614ef0f5624a6b0cfbc037e6bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028121 Auto-Submit: Joshua Bell <jsbell@chromium.org> Commit-Queue: Marijn Kruisselbrink <mek@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Cr-Commit-Position: refs/heads/master@{#736634}
-
Regan Hsu authored
AddSharedLocalizedStrings is removed and string providing functions for shared components must be called explicitly from now on. A11y strings that are shared by the top level A11y pages are copied back into browser and os settings. CaptionSubpage strings remain in the shared string provider because the component itself is shared by both browser and os settings. Bug: 967888 Change-Id: I03af35e6577320ab75e1e859fb7ba8243f1cf757 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028730 Auto-Submit: Regan Hsu <hsuregan@chromium.org> Commit-Queue: Regan Hsu <hsuregan@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#736633}
-
Maksym Onufriienko authored
In case of timeouts recipe utils try to kill test-runner process but if timer.timeout is not exceeded, recipe call will be blocked. It may be a cause of missing output folder since test_runner not finished properly. Fixed: 1011979 Change-Id: If0c0760036bb76567fe2ec625b4ee1b5831cae71 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1998998 Commit-Queue: Maksym Onufriienko <monufriienko@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Cr-Commit-Position: refs/heads/master@{#736632}
-
Geoff Lang authored
These objects are not used when the passthrough command decoder is in use. This saves several GPU memory allocations in TextureManager for default and black textures. Saves ~2 MB per context. BUG=1046613 BUG=1030835 Change-Id: I66c6acf28580742bc313d8cf79de80f7f7d98305 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028291 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Dan Sanders <sandersd@chromium.org> Cr-Commit-Position: refs/heads/master@{#736631}
-
Ken Rockot authored
Bad message reporting has generally been allowed in Android WebView crash keys, but the actual "mojo-message-error" key was omitted from the whitelist. That makes it virtually impossible to debug bad Mojo message crashes from WebView crash reports. This whitelists the appropriate key. Bug: 949005 Change-Id: I82ebd831732738385a5212349c04327412b57a40 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028125Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Ken Rockot <rockot@google.com> Cr-Commit-Position: refs/heads/master@{#736630}
-
Dana Fried authored
View information was not being removed from the current layout on view removal, even though the current layout may have been calculated on the most recent animation frame, previous to the view being removed. In the worst case, this could cause a use-after-free if the view is deleted on remove. Now we remove both fade infos and current layout elements if they correspond to the removed view. Bug: 1046393 Change-Id: I364a2c604d0ae122540a170eec133d5d020b76e0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027174 Commit-Queue: Dana Fried <dfried@chromium.org> Reviewed-by:
Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#736629}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/8a46f7664675..d0a0c59c80b0 git log 8a46f7664675..d0a0c59c80b0 --date=short --first-parent --format='%ad %ae %s' 2020-01-29 nifong@google.com Return summaries of all layers for display 2020-01-29 egdaniel@google.com Use views throughout gpu blur code. Created with: gclient setdep -r src/third_party/skia@d0a0c59c80b0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC reed@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: reed@google.com Change-Id: I77ddaa643acbe4e7cbf08433fb9cae83ff8e5c70 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028864Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#736628}
-
James Forshaw authored
This CL changes GPU AC enabling to use a feature. It also removes the flag from chrome://flags. Bug: 807249 Change-Id: Ia0ace7865fbde135a4209b4b2f34ad809bd596cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2025928Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#736627}
-
Alexander Hendrich authored
This CL updates the extension InstallLimiter to continue with deferred or incoming extension installations when all external providers are ready and all file sizes for incoming installations have been determined. This prevents us from waiting the full 5s delay for large (>1MB) extensions from being installed in case there are no other smaller extensions to wait for. Bug: 1046302 Change-Id: If98c6ee1b6ae1843efe884301676066ee15107a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2023830 Commit-Queue: Alexander Hendrich <hendrich@chromium.org> Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#736626}
-
Orin Jaworski authored
This CL partially revives the logic from crrev.com/c/1471251 : [omnibox] Eliminate side-button Pedal suggestion mode Note that only the match handling part is restored and the code for handling the Pedals button is ignored. The is due to the conditional nature of application of this logic. When the button row feature is enabled, we will use the button row on the triggering suggestion to show the pedal on the same suggestion. When disabled, the existing dedicated Pedal suggestion logic will be kept. For now, the button row work is in progress, and until the row is actually presented, enabling both Pedals and the row will effectively hide the pedal in the triggering suggestion. Bug: 1046523 Change-Id: Iacb1e02158ee054b877dd0095f3ddd3a0b533b1a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027900 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#736625}
-
Vadym Doroshenko authored
Metrics are prolong on 4 releases ~1/2 years to M85. Bug: 1037196, 1037195, 1037192, 1037191 Change-Id: I9741549353cec1d7b4e20d6230db36a5db2d3752 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2027808Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Ilya Sherman <isherman@chromium.org> Auto-Submit: Vadym Doroshenko <dvadym@chromium.org> Cr-Commit-Position: refs/heads/master@{#736624}
-
Vadym Doroshenko authored
It will be used in subsequent CL to reset state when the user removes the value in a password field and no credentials to save anymore. Bug:1042196 Change-Id: I9198d7338d66c21f4e97414caf271ae20ad9c1bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2022645 Commit-Queue: Vadym Doroshenko <dvadym@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Reviewed-by:
Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#736623}
-
Manu Cornet authored
Bug: 1044306, 1042491, 1040177, 1042911 Change-Id: I37021bfce8f2d6a9b7bcd39df0a3d23eae0b6707 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028858 Commit-Queue: Manu Cornet <manucornet@chromium.org> Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#736622}
-
- 29 Jan, 2020 3 commits
-
-
Nick Burris authored
In crrev.com/c/1965273 we started setting the CSS :target on the document to the found match. However, this dirties style and may require a lifecycle update, causing the computation of the highlight and scroll rects to DCHECK. This patch adds a call to UpdateStyleAndLayout after setting the target. Bug: 1045117 Change-Id: Ic6648665ef7e7d1e9fba47a6bac0741803257269 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2017562Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#736621}
-
Clark DuVall authored
This applies the Theme.BrowserUI style to WebLayer, which is necessary for things like js alert dialogs to look right. are including styles in //third_party/android_deps:com_android_support_design_java in WebView to support WebLayer UI, the onResourcesLoaded function increased in size to perform the package ID transform needed for WebView on those resources. Binary-Size: Filed bug to track: http://crbug.com/1044234. Now that we Bug: 1025256 Change-Id: If647a3f61e7b9d73ca30cc6dda4d612e392a669b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2005671 Commit-Queue: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#736620}
-
Alex Newcomer authored
Just a rename. It was never really opaque to begin with. Change-Id: Icebf4bcd53f1ee086c0479c912d2943478754c65 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2028862 Auto-Submit: Alex Newcomer <newcomer@chromium.org> Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Alex Newcomer <newcomer@chromium.org> Cr-Commit-Position: refs/heads/master@{#736619}
-