- 14 Mar, 2018 40 commits
-
-
Morten Stenshorne authored
The LayoutBox associated with a block node will *normally* be the containing block (on the legacy side) of its children (on the NG side), but this isn't an invariant. Multicol and list item markers are two examples. Remove the kembo DCHECK, since it seems impossible to come up with a complete list of exceptions to the rule (that the node's box should be the containing block of the child nodes' boxes). Instead always get the right containing block from legacy layout. Don't use that of the node. With the DCHECK removed, a lot of tests stop crashing, and some just start passing instead. One known effect of this change is that floats that are direct children of multicol containers are painted correctly. They used to be added to the float list of the multicol container, rather than that of the flow thread, which caused two problems: paint order (regular blocks got painted on top of them), and that they appeared unfragmented (they just overflowed the multicol container instead). Added a test for that. Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I1ee926c39fbedfd52d87e9cf790996909914efb2 Reviewed-on: https://chromium-review.googlesource.com/960027 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Emil A Eklund <eae@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Aleks Totic <atotic@chromium.org> Cr-Commit-Position: refs/heads/master@{#543065}
-
Helen Li authored
This CL adds TCP socket API to network service. This is partly based on mandoline implementation (https://codereview.chromium.org/1873463003/) Two TCP socket interfaces are added. - TCPConnectedSocket - TCPServerSocket Change in reland: - adds logging to TCPSocketTest.ReadAndWriteMultiple to investigate the test timeout observed in crbug.com/821232 - Modifies TestServer slightly to own all client connections instead of only the latest one. R=mmenke@chromium.org TBR=miu@chromium.org TBR=tsepez@chromium.org Bug: 721401 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I0426a7aeda30cce7a2a1e84afae5208958dc4a10 Reviewed-on: https://chromium-review.googlesource.com/960250 Commit-Queue: Helen Li <xunjieli@chromium.org> Reviewed-by:
Helen Li <xunjieli@chromium.org> Reviewed-by:
Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#543064}
-
Aaron Leventhal authored
The window selector gets names from Aura windows. Propagate titles from app names to the aura window titles, as the web content itself may not have a title. This is split out from the CL to test all widgets and views for nameless focusable objects. See crrev.com/c/951933. Bug: 819350 Change-Id: Id61d9398824b836a644c57813f1521faf1aae70f Reviewed-on: https://chromium-review.googlesource.com/961093Reviewed-by:
Trent Apted <tapted@chromium.org> Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Cr-Commit-Position: refs/heads/master@{#543063}
-
yoshiki iguchi authored
Previously popup bubbles remain with insufficient state after the shelf position is changed. This CL adds the code to explicitly recreate bubbles so that it works correctly even after the shelf position is updated. Bug: 820400 Test: manual test (checked the repro steps in the issue) Change-Id: I7c196614c2a148eda53650cae145b544af9bbded Reviewed-on: https://chromium-review.googlesource.com/960681Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#543062}
-
Thomas Tangl authored
To have the correct behavior when a submenu is opened via a HoverButton, the HoverButton class is transformed into a subclass of MenuButton. HoverButton can now function as both, a normal button and a menu button. Visible changes in the user menu: - When the submenu is opened, the button stays highlighted. - When the submenu closes, the button loses its highlighting. Video from before: https://drive.google.com/file/d/1QONj3SZv-zAwQ2r7WqF4Ww7UKo0wVcJ2/view?usp=sharing Video from after: https://drive.google.com/file/d/1dwh_68A0cjiK2kiPnHwCvSdQX6RByVY5/view?usp=sharing Bug: 814809 Change-Id: I6401cb39d20fca9c3590a67bd0fbeff5a2043b83 Reviewed-on: https://chromium-review.googlesource.com/953623Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Thomas Tangl <tangltom@chromium.org> Cr-Commit-Position: refs/heads/master@{#543061}
-
Elad Alon authored
Having WebRtcEventLogManager in content/ produces some issues: 1. JS hooks leading to it need to go through WebRtcLoggingHandlerHost, which lives in chrome/browser/media/webrtc/, from which there is no access to content/. 2. The code for chrome://webrtc-logs/ is accessible from chrome/, but not from content/. 3. Uploading is easier and more natural from chrome/, where g_browser_process->system_request_context() is available for the URLFetcher. To make this change possible, it was necessary to extend TestingProfileManager to also allow the directory for the profiles to be set by the user of the class, so as to support unit tests relating to handling of files from previous Chrome sessions. Follow-up work to be done by future CLs: * While in content/, the context within which files and tabs lived was the BrowserContext. Having moved to chrome/, Profile (which inherits from BrowserContext) is a more natural entity to focus on. Bug: 775415 Change-Id: I9c9617fbd9cd597223721bb74fbfdb258a846cce Reviewed-on: https://chromium-review.googlesource.com/955653 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Tommi <tommi@chromium.org> Cr-Commit-Position: refs/heads/master@{#543060}
-
v8-autoroll authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/e704dea0..9fe571c9 Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org Change-Id: I4c529faa1db2aa294ba85008fa92a28830efb975 Reviewed-on: https://chromium-review.googlesource.com/961348Reviewed-by:
v8 autoroll <v8-autoroll@chromium.org> Commit-Queue: v8 autoroll <v8-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#543059}
-
Raphael Kubo da Costa authored
The test is still crashing on linux_chromium_rel_ng and blocking WPT imports: * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45486 * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45507 * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45582 * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45602 * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45638 * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45651 * https://ci.chromium.org/p/chromium/builders/luci.chromium.try/linux_chromium_rel_ng/45722 TBR=lukasza,leon.han@intel.com Bug: 801992 Change-Id: Ie51d1c04d9ed23ff7aeea1a4f3e485ab97acd3bc No-Try: true Reviewed-on: https://chromium-review.googlesource.com/962146Reviewed-by:
Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Commit-Queue: Raphael Kubo da Costa <raphael.kubo.da.costa@intel.com> Cr-Commit-Position: refs/heads/master@{#543058}
-
Chromium WPT Sync authored
Using wpt-import in Chromium d8206c55. With Chromium commits locally applied on WPT: ad9cc156 "Add WPT tests for feature policy frame policy" Build: https://ci.chromium.org/buildbot/chromium.infra.cron/wpt-importer/13838 Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: domenic@chromium.org, ricea@chromium.org: external/wpt/streams jsbell@chromium.org: external/wpt/encoding TBR=leon.han@intel.com No-Export: true Change-Id: I8e0d5cc349664f81db088e3f201af475d2811a0e Reviewed-on: https://chromium-review.googlesource.com/961903 Commit-Queue: Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Reviewed-by:
Blink WPT Bot <blink-w3c-test-autoroller@chromium.org> Cr-Commit-Position: refs/heads/master@{#543057}
-
https://chromium.googlesource.com/catapult.git/+log/7b53f088f8e8..f73167a6894a $ git log 7b53f088f..f73167a68 --date=short --no-merges --format='%ad %ae %s' 2018-03-13 mythria Ignore i-frame navigationStart events when computing LoadExpectation Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=sullivan@chromium.org Change-Id: Ia5bf0114b5db0de84b728867560e78c0e6f69e9d Reviewed-on: https://chromium-review.googlesource.com/961284Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543056}
-
Oskar Sundbom authored
Just a simple copy/paste error, I'm afraid. Intent to Experiment: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/3MYKIKqyaNA Bug: chromium:776327 Change-Id: I07191b2c1c4a3c3eff69d9b4a5abd604ee6ba01a Reviewed-on: https://chromium-review.googlesource.com/958906Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Commit-Queue: Oskar Sundbom <ossu@chromium.org> Cr-Commit-Position: refs/heads/master@{#543055}
-
Morten Stenshorne authored
A few tests have started to pass. newmulticol/unresolvable-percent-max-height-2.html because of https://chromium-review.googlesource.com/c/chromium/src/+/960085 The rest because of https://chromium-review.googlesource.com/c/chromium/src/+/960403 TBR=kojii@chromium.org Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng Change-Id: I48694ad07ab78550068950982d40f9e80de60d4a Reviewed-on: https://chromium-review.googlesource.com/962003 Commit-Queue: Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#543054}
-
arthursonzogni authored
See https://crbug.com/820959 for more informations. This CL temporarily disable BrowserSideNavigationBaseBrowserTest.CancelRequestAfterReadyToCommit on Windows with NavigationMojoResponse. Bug: 820959 Change-Id: I2b7f774baf161275834ae969532fa5abef292043 Reviewed-on: https://chromium-review.googlesource.com/958904Reviewed-by:
Camille Lamy <clamy@chromium.org> Commit-Queue: Arthur Sonzogni <arthursonzogni@chromium.org> Cr-Commit-Position: refs/heads/master@{#543053}
-
Eric Seckler authored
Previously, setVirtualTimePolicy was always returning a zero virtual time base when wait_for_navigation was set. This meant, even if virtual time was enabled before, the client's known virtual time base could be overridden with an invalid one. Instead, return the previously initialized virtual time base when it is known, even if wait_for_navigation is set. Change-Id: I391232f7310b81c4fc3b033e7ba4c186b32560d3 Reviewed-on: https://chromium-review.googlesource.com/960761 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#543052}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/2e73d43870dd..1c9c003404cd $ git log 2e73d4387..1c9c00340 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 iannucci [led] Bump to support CIPD Recipes. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I5f15a257ad83d83b8e823253e3a3881c82d2c3aa Reviewed-on: https://chromium-review.googlesource.com/961904Reviewed-by:
depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543051}
-
Alper Cakan authored
Make text-size-adjust animatable, as it is supposed be so according to: drafts.csswg.org/css-size-adjust/#adjustment-control R=nainar@chromium.org, shend@chromium.org, smcgruer@chromium.org Bug: 818526 Change-Id: I0c3b98c4726f6898599aa5626ad2fec876057ec0 Reviewed-on: https://chromium-review.googlesource.com/956462Reviewed-by:
Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Cr-Commit-Position: refs/heads/master@{#543050}
-
Koji Ishii authored
This patch reviewed failures of wpt/css/css-text, grouped and sorted, with following modifications: 1. Skip importing features with no active contributors. When we have plans or contributors, we can unskip them. 2. Following tests were removed because they are based on old versions of Unicode. According to the most recent spec at: https://www.unicode.org/Public/UNIDATA/extracted/DerivedLineBreak.txt css3-text-line-break-opclns-013 U+23B4 is AL, not CL css3-text-line-break-opclns-048 U+FD3E is CL, not OP css3-text-line-break-opclns-118 U+23B5 is AL, not CL css3-text-line-break-opclns-154 U+FD3F is OP, not CL css3-text-line-break-opclns-216 U+30FC is CJ, not NS css3-text-line-break-opclns-224 U+FF70 is CJ, not NS 3. Following tests were removed because they hard code pixel widths, and their cases are covered by other tests. word-break-normal-002 4. Following tests were removed because they are based on JLREQ, a W3C notes that explains traditional Japanese typography, but not defined in the CSS spec nor in Unicode spec. line-break-normal-025 line-break-strict-018a line-break-strict-018b Bug: 817781, 817778, 817776 Change-Id: I92b1abc99fa8019e5d514e485f6c4733075216ba Reviewed-on: https://chromium-review.googlesource.com/960683Reviewed-by:
Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#543049}
-
Tatsuhisa Yamaguchi authored
Make Zip Archiver to forget password when requested to resume, as well as returning error to make VolumeManager remove the persisted provided volume info. Remove all code for persisting zip mount state. Bug: 789073,803752 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icb9a6e9ca04b7ed633480a17973d1dcb126d02e0 Reviewed-on: https://chromium-review.googlesource.com/940742 Commit-Queue: Tatsuhisa Yamaguchi <yamaguchi@chromium.org> Reviewed-by:
Yuki Awano <yawano@chromium.org> Cr-Commit-Position: refs/heads/master@{#543048}
-
Thomas Tangl authored
This CL fixes the highlighting behavior of HoverButton by turning on highlight on focus. Bug: 821354 Change-Id: I3d89aa1febd2dc1cd4e82d2291983eb09e7fbab4 Reviewed-on: https://chromium-review.googlesource.com/960024 Commit-Queue: Thomas Tangl <tangltom@chromium.org> Reviewed-by:
-
Manuel Rego Casasnovas authored
We had a TODO in IndefiniteSizeStrategy::MinLogicalWidthForChild() that was always using 0 as margin of the item. The patch just changes that for a call to GridLayoutUtils::MarginLogicalWidthForChild() (like we do in the DefiniteSizeStrategy version). BUG=816762 TEST=external/wpt/css/css-grid/grid-items/grid-items-minimum-width-001.html TEST=external/wpt/css/css-grid/grid-items/grid-items-minimum-width-002.html Change-Id: I743584aff234625f2d00327c711c0577ffeab457 Reviewed-on: https://chromium-review.googlesource.com/955062 Commit-Queue: Manuel Rego Casasnovas <rego@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#543046}
-
Ramin Halavati authored
A switch is added to clang tool calls from traffic annotation auditor, to ignore constant comparisons. Some tests compare constants to prevent future regressions, but clang sees these as unnecessary comparisons and issues error. Bug: 690323 Change-Id: Iaa194641f2d6a8cd66ae61f514703bccc28967da Reviewed-on: https://chromium-review.googlesource.com/958518 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#543045}
-
Alex Clarke authored
For determinism of animated gifs, set kDisableImageAnimationResync. Change-Id: Ia609396083534935f0c36d9b7328b50bfc164f8d Reviewed-on: https://chromium-review.googlesource.com/962122Reviewed-by:
Eric Seckler <eseckler@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#543044}
-
https://skia.googlesource.com/skia.git/+log/d8853ec0fd01..0bf59e459772 $ git log d8853ec0f..0bf59e459 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 angle-skia-autoroll Roll skia/third_party/externals/angle2/ 690c8eb7f..fccebffe6 (1 commit) Created with: roll-dep src/third_party/skia The AutoRoll server is located here: https://autoroll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=stephana@chromium.org Change-Id: I1b97a460dedd11e249bdae17d8941eae212d8b22 Reviewed-on: https://chromium-review.googlesource.com/961972 Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543043}
-
Victor Costan authored
Bug: 729800 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: Ic81f291fd9ea34647f0260d4d4dd88f3c90504d0 Reviewed-on: https://chromium-review.googlesource.com/881586Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#543042}
-
Tetsui Ohkubo authored
This CL adds a feature pod button for accessibility. By clicking on the button, it will show accessibility detailed view of the existing SystemTray. This behavior is described as Development Stage 1 in the design doc: go/cros-qs-restyling Screenshot: http://screen/scc32RkykN2 TEST=AccessibilityFeaturePodControllerTest BUG=821671 Change-Id: I2c9f91b86c70e5bad3c1eb4261c14e4d167f0473 Reviewed-on: https://chromium-review.googlesource.com/961923 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Cr-Commit-Position: refs/heads/master@{#543041}
-
https://chromium.googlesource.com/angle/angle.git/+log/fccebffe63cf..2bfe9f6b9366 $ git log fccebffe6..2bfe9f6b9 --date=short --no-merges --format='%ad %ae %s' 2018-03-02 oetuaho Use function id to group functions in ParseContext Created with: roll-dep src/third_party/angle The AutoRoll server is located here: https://angle-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel TBR=cwallez@chromium.org Change-Id: I6a86c6be9e9212c269abe41c533065545a0efe88 Reviewed-on: https://chromium-review.googlesource.com/961902 Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Reviewed-by:
angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#543040}
-
Ramin Halavati authored
The bot seems to have no access to gen folder. This is required as some files have includes from gen folder. Disabling it for investigation. TBR=msramek Bug: 690323 Change-Id: I378a0c7f0c1a5fb3571bd66cb49acf2140fc80cc Reviewed-on: https://chromium-review.googlesource.com/962061 Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Reviewed-by:
Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#543039}
-
Christian Dullweber authored
When tabs are serialized by tab_restore_service, only a limited number of entries is written to disk. On restore, these entries are created with their previous index, which is not consistent with actual index. This CL fixes the indices and adds checks to more easily identify other cases with inconsistent indices. Bug: 820910, 821214 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I1fe8f3809cb51a0b5853ccd9294690bc08d71778 Reviewed-on: https://chromium-review.googlesource.com/960026Reviewed-by:
-
Alexandr Ilin authored
Many fields of predictors::URLRequestSummary are not used after the ResourcePrefetchPredictor was deprecated. This CL removes obsolete members from the class. Bug: 816545 Change-Id: I405e4a640a23f587691d7cc0ac7a6fa2341e3dbc Reviewed-on: https://chromium-review.googlesource.com/960665Reviewed-by:
Benoit L <lizeb@chromium.org> Commit-Queue: Alexandr Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#543037}
-
Adam Langley authored
Since |u2f_request_| is assigned to the result of |TryRegistration| / |TrySign|, if the given callback is called immediately then |Cleanup| can have run and completed before |u2f_request_| is assigned. That leaves |AuthenticatorImpl| in an invalid state and it'll no longer process any requests. None of the existing callbacks do this, so this change just adds DCHECKs to help anyone else who might hit this in the future. Change-Id: I139a0825c6231c438dc9e469f9b188eddb6000e0 Reviewed-on: https://chromium-review.googlesource.com/961788 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by:
Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#543036}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/456b0d648f72..2e73d43870dd $ git log 456b0d648..2e73d4387 --date=short --no-merges --format='%ad %ae %s' 2018-03-14 iannucci [git_cl] Remove rietveld CMDland implementation. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I0ead1cdd02ddc6ac5b8c2e347e7d82e9d72ce084 Reviewed-on: https://chromium-review.googlesource.com/961974Reviewed-by:
-
Findit authored
This reverts commit aa57fe6d. Reason for revert: Findit (https://goo.gl/kROfz5) identified CL at revision 543005 as the culprit for failures in the build cycles as shown on: https://findit-for-me.appspot.com/waterfall/culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyRAsSDVdmU3VzcGVjdGVkQ0wiMWNocm9taXVtL2FhNTdmZTZkYzk2YjQwYTU4YWNjMWVkNmMyNjhmNDdhODgxYjU5MGUM Sample Failed Build: https://ci.chromium.org/buildbot/chromium.memory/Linux%20MSan%20Tests/8508 Sample Failed Step: browser_tests Original change's description: > [Media Router] Converts integration tests to run on Chromium waterfall. > > This updates the Media Router integration tests so they run in the > Chromium waterfall with the open source Media Router component > extension and its mock (test) Media Route Provider. > > Additional changes: > > - Removes extension from top level BUILD.gn as it is only used for > browser tests at the moment. > - Splits the targets for Media Router browser tests into integration tests > (part of main browser_tests suite), e2e tests (which require the > external component extension), perf tests, and shared support code. > - Renames the "test" extension to the "telemetry" extension used for perf > tests to avoid confusion. > - Updates README files > - One test is not compatible with the Chromium component and need > to be fixed. Bugs 818767 filed for follow-up. > > Bug: 698796 > Change-Id: I6cc9302ffd72de95630ce33ca3617b3b73b9e722 > Reviewed-on: https://chromium-review.googlesource.com/917214 > Commit-Queue: mark a. foltz <mfoltz@chromium.org> > Reviewed-by: Scott Violet <sky@chromium.org> > Reviewed-by: Derek Cheng <imcheng@chromium.org> > Cr-Commit-Position: refs/heads/master@{#543005} Change-Id: Ifd1f688a7b89397491d849a6766f8d0510425e05 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 698796 Reviewed-on: https://chromium-review.googlesource.com/962101 Cr-Commit-Position: refs/heads/master@{#543034}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 770603 Change-Id: Ifa9abf5b2f979d48dd72477e61c5d8f574250e0d Reviewed-on: https://chromium-review.googlesource.com/961564Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#543033}
-
Kent Tamura authored
This CL has no behavior changes. Bug: 770603 Change-Id: I919b422532b69ab4e25d6915a6b4db7bc8e3022f Reviewed-on: https://chromium-review.googlesource.com/961042Reviewed-by:
-
Tetsui Ohkubo authored
This CL ports unit tests from TrayTilesTest. Also this CL fixes DCHECK failures and crash in logged out state. UnifiedSystemTray design doc: go/cros-qs-restyling TEST=TopShortcutsViewTest(ash_unittests) BUG=none Change-Id: Id32540a3213866aa86b89025f1aa7bc97bae989b Reviewed-on: https://chromium-review.googlesource.com/958304Reviewed-by:
-
chrome://resources/*Daniel Cheng authored
Bug: 821613 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: Icdaab0eb77a72a7b6ad0c491424672614c24a9fa Reviewed-on: https://chromium-review.googlesource.com/961727Reviewed-by:
Raymes Khoury <raymes@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#543030}
-
Kunihiko Sakamoto authored
<link rel=preload> will play an important role in signed-exchange prefetching. This patch makes srcset/imgsizes on <link rel=preload> work with the SignedHTTPExchange flag too (in addition to the Experimental Web Platform features flag), so that people can easily try out it. Bug: 803774,813452 Change-Id: I976d007c73b9cb5459d35e0e178f8d8d90484709 Reviewed-on: https://chromium-review.googlesource.com/961627Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#543029}
-
Kunihiko Sakamoto authored
It takes at least 5 seconds. Marking it as SLOW to ensure that it runs with an increased timeout. NoTry: True Bug: 816026 Change-Id: Ie6923678e945b05def57f93647ae69a97190da86 Reviewed-on: https://chromium-review.googlesource.com/961922 Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org> Reviewed-by:
Takashi Toyoshima <toyoshim@chromium.org> Cr-Commit-Position: refs/heads/master@{#543028}
-
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/064937143390..456b0d648f72 $ git log 064937143..456b0d648 --date=short --no-merges --format='%ad %ae %s' 2018-03-13 iannucci [bot_update] Remove support for rietveld patches. Created with: roll-dep src/third_party/depot_tools The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Change-Id: I37991cf31009daa325d77a055f4a8f569fd86167 Reviewed-on: https://chromium-review.googlesource.com/961820Reviewed-by:
-
Hiroki Nakagawa authored
As a preparation for module loading support for workers, this CL does mainly 2 things: - This renames WorkletModuleScriptFetcher to WorkerOrWorkletModuleScriptFetcher, and WorkletModuleResponsesMapProxy to WorkerOrWorkletModuleFetchCoordinatorProxy. This enables workers can reuse worklets' module loading classes. - This introduces WorkerOrWorkletModuleFetchCoordinator interface. Implementation of the interface is expected to fetch module scripts via DocumentModuleScriptFetcher, to manage inflight requests, and to notify completions of the requests to WorkerOrWorkletModuleScriptFetcher on the worker thread. For worklets, WorkletModuleResponsesMap inherits the interface. For workers, following CLs introduce a new class, WorkerModuleFetchCoordinator, because WorkletModuleResponsesMap have custom fetch logic for caching and it's not reusable for workers. See the design doc for details: https://docs.google.com/document/d/1IMGWAK7Wq37mLehwkbysNRBBnhQBo3z2MbYyMkViEnY/edit#heading=h.637avx8i5qtn Bug: 680046 Change-Id: Iba7916bb9b5aefbc8c695ff9865bcbe756801412 Reviewed-on: https://chromium-review.googlesource.com/958801Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Hiroki Nakagawa <nhiroki@chromium.org> Cr-Commit-Position: refs/heads/master@{#543026}
-
