GitLab

- Integrates ARQuickLookTabHelper in BrowserDownloadService in order to
  handle downloading USDZ format files.

Bug: 908696
Change-Id: I977e1609d02e6f14e7f84d9d2fba5b4cce96e76e
Reviewed-on: https://chromium-review.googlesource.com/c/1352120
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611978}

Refactor overview and cycle list code. The should end up showing the same
windows, so they should share the same codes if possible.

Test: manual
Bug: 844829
Change-Id: Ib5f2800f7b0876afcff10cea3bf37f0156e83467
Reviewed-on: https://chromium-review.googlesource.com/c/1344814
Commit-Queue: Sammie Quon <sammiequon@chromium.org>
Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611977}

Implemented the ability to allow the Presenter API to be used to display fullscreen when running on Fuchsia.

Change-Id: I2b5b32b4a2ea3c1623951f0c7af361fc68592185
Depends-On: https://chromium-review.googlesource.com/c/chromium/src/+/1313873
Reviewed-on: https://chromium-review.googlesource.com/c/1320975
Commit-Queue: Chad Duffin <chadduffin@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Yuchen Liu <yucliu@chromium.org>
Reviewed-by: Luke Halliwell <halliwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611976}

If we have more than one touch monitor and we are expanding chrome
window to all the touch screens, we can only touch on one screen not
the others. We found out the when we searched for targets of the touch
events, we could not find the right target, which should be
"RenderWidgetHostViewAura", because we are checking if the screen
locations of the touch events are in the display's bound, which only
matches to one monitor. We should change to screen's bound, which
can represent the bound of all the screens that are connected.

Bug: 901399
Change-Id: I9c85d6e81d0d1bbaf023f566b1512a5c7b839625
Reviewed-on: https://chromium-review.googlesource.com/c/1354125
Commit-Queue: Lan Wei <lanwei@chromium.org>
Reviewed-by: Michael Wasserman <msw@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611975}

Change-Id: I536145529ece588c4b7b5311fd86979045949a3b
Reviewed-on: https://chromium-review.googlesource.com/c/1354323Reviewed-by: Ben Smith <binji@chromium.org>
Commit-Queue: Derek Schuff <dschuff@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611974}

These ImageLoaderFooBarCallback typedef's were previously
base::Callback, neither explicitly a base::OnceCallback or a
base::RepeatingCallback. Presumably these typedef's were first defined
before there was a base::OnceCB vs base::RepeatingCB distinction.

The general motivation for this commit is that base/callback.h says that
it intends to flip the type alias of base::CB to be base::OnceCB instead
of base::RepeatingCB.

The specific motivation for this commit is to be able to call
ImageLoader::LoadImagesAsync as part of a Mojo IPC call chain. The
mechanism for Mojo method calls to return something is a base::OnceCB.
You can easily use a base::OnceCB to call another base::RepeatingCB
(once), but doing vice versa is trickier, especially if the base::OnceCB
expects to be std::move'd around but base::BindRepeating expects to copy
its arguments.

A very specific motivation is to make the app_icon_factory.h API more
consistent, with its functions all taking the same type of callback, a
base::OnceCB.

Change-Id: Iec560709d97be22e92ccd17a27bad39eab597c6f
Reviewed-on: https://chromium-review.googlesource.com/c/1348875Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Drew Wilson <atwilson@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Commit-Queue: Nigel Tao <nigeltao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611973}

This CHECK is currently occasionally failing in the wild, but the failure
of the CHECK doesn't mean any serious correctness issues. Make it a
DCHECK for now to prevent crashes, and investigate separately.

Bug: 865098
Bug: 899217
Bug: 909858
Change-Id: Ie99a1e79bd239ac01021e1d942724cf3bdfdd510
Reviewed-on: https://chromium-review.googlesource.com/c/1353955
Commit-Queue: Leszek Swirski <leszeks@chromium.org>
Reviewed-by: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611972}

This test was originally created to test "cross-site transfers" that
happened during navigations pre-PlzNavigate. These no longer happen,
so the test is no longer needed.

More background: the test was always flaky because it didn't wait
for service worker activation after trying to register the service
worker. So it was disabled on Linux/Android/CrOS for most of its
life.

Later, r521904 adjusted the test because it removed the
ShouldSwapProcessesForRedirect() method that the test relied on for
forcing cross-site transfer. To try to keep test coverage, it added the
IsolateAllSitesForTesting flag as site isolation apparently has similar
behavior to the swap processes method.  This flag is already run in the
linux_chromium_rel_ng config in the
site_per_process_content_browsertests step, but since this test was
disabled on Linux, it was needed to add this flag explicitly for
Windows.

But it's all moot because cross-site transfers don't happen, so the test
isn't testing anything interesting. We have enough coverage for site
isolation with with site_per_process_content_browsertests running
the normal tests.

Bug: 474976
Change-Id: Icec7c4d5408f8dfb1bb2437036482c184bd2d0a2
Reviewed-on: https://chromium-review.googlesource.com/c/1353053Reviewed-by: Tsuyoshi Horo <horo@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611971}

Setting the offline clock pointer is error-prone, as a test must ensure it
resets the pointer back to null, or a later test will fail. TestScopedOfflineClock
overrides the clock in a more safe way.

Bug: 906903
Change-Id: Idd88c35da90bddcb3b7006c7b33547c5b36b02d2
Reviewed-on: https://chromium-review.googlesource.com/c/1351748
Commit-Queue: Dan H <harringtond@google.com>
Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611970}

Follow up to r1278462.

TBR=stevenjb@chromium.org

Bug: 849995
Change-Id: I35d0e1e64149e5b71b3da409a7ade18995039854
Reviewed-on: https://chromium-review.googlesource.com/c/1353060Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611969}

Bug: 721403

Change-Id: I6f23e6ba1099666be58014efa840829a072b097c
Reviewed-on: https://chromium-review.googlesource.com/c/1347432Reviewed-by: rajendrant <rajendrant@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Reviewed-by: Clark DuVall <cduvall@chromium.org>
Commit-Queue: Eric Roman <eroman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611968}

AutofillController for the most part forwards calls from AutofillClient
and AutofillDriver to AutofillAgent. This complicates understanding and
debugging the logic. It also has some logic (e.g., adding clear form and
gpay logo to the list of suggestions) that has been a source of confusion
in past. This CL gets rid of AutofillController by:
-Removing the middle man for the AutofillClient and AutofillDriver calls.
-Moving the logic to setup AutofillDriver to AutofillTabHelper.
-Merging its tests into AutofillAgent and JSAutofillManager tests.

Change-Id: I207ec8137a8d4b0cfc1c42de8cd06b8f4de33e67
Reviewed-on: https://chromium-review.googlesource.com/c/1310353
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Reviewed-by: Sergio Collazos <sczs@chromium.org>
Reviewed-by: John Wu <jzw@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611967}

Add a browser test that serves a service worker from
chrome://dummyurl/sw.js, and attempts to register it as a service
worker. It of course fails, but for several reasons it's hard to change
Chrome to get the registration to succeed to prove the test would catch
a regression should one occur.

Also add a simple unit test that that ChromeContentClient doesn't
include chrome:// in the whitelisted schemes for service workers.

The browser test crashes locally with a DCHECK in the destructor for
DBus, apparently because it finishes too quickly. Not sure if that
also happens on the bots.

Bug: 823475
Change-Id: I41db993405de219cadaf63cfe43ed0844ba6f1fe
Reviewed-on: https://chromium-review.googlesource.com/c/1351205
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611966}

We're not yet enabling the tests to run on the waterfall due to lack
of hardware, but the tests currently pass with these suppressions.

Bug: 709351, 809233, 830046, 850257, 874620
Bug: 905006, 906735, 906735, 906737, 906739
Bug: 906740, 906742, 906743, 906745, 906752
Change-Id: I7362e52e9df8ae8f591d11a4a1e272fa2b81b0b6
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Reviewed-on: https://chromium-review.googlesource.com/c/1340275Reviewed-by: Kenneth Russell <kbr@chromium.org>
Commit-Queue: James Darpinian <jdarpinian@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611965}

Metadata eviction passes base::OnceClosure() as a dummy callback. When
this is invoked, a segfault occurs. Replacing this with
base::DoNothing() is the proper way to pass a dummy callback.

Bug: 909735
Change-Id: Ib36f2ec473a7082a5b67fe184637faa7a87e0fb9
Reviewed-on: https://chromium-review.googlesource.com/c/1351534Reviewed-by: Sky Malice <skym@chromium.org>
Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Brandon Wylie <wylieb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611964}

Now extensively using HostCache::Entry internally (but only internally
to preserve flexibility of HostCache) as a generalized results
container within HostResolverImpl. Added some needed setter/merge
functionality to Entry for that purpose.  Many methods within the
resolver changed to use Entry for consistency even if they only ever
deal with address results, eg ResolveAsIP().

Slightly modified results port-setting functionality to only set port
to an input port (from |host.port()|) if the port in the results is 0
(where before it would set it whenever it wasn't equal to the input
port).  This will be necessary eg for SRV support where DNS provides a
specific port that needs to be maintained in the results. Also cleaned
up the port setting to consistently only ever happen just before
setting results on the RequestImpl and having 0 or a DNS-provided port
until then.

Bug: 846423
Change-Id: I679c0ac915e0f81b49adb5ee769f250be49c9c90
Reviewed-on: https://chromium-review.googlesource.com/c/1340835Reviewed-by: Matt Menke <mmenke@chromium.org>
Commit-Queue: Eric Orth <ericorth@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611963}

This CL makes EmailHandler use the new country_codes component to determine
what data to send back based on country codes. This CL adds the mechanism,
and there will be follow-up CLs (marked with TODOs) to add the data for more
countries.

Change-Id: I2fc39ae5bd086a1ee8b2871c166a0f4d46e531b8
Reviewed-on: https://chromium-review.googlesource.com/c/1343192
Commit-Queue: Scott Chen <scottchen@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Reviewed-by: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611962}

If this flag is enabled, auto-brightness model will continue to adapt brightness
when ambient value changes, even after user changes brightness.

The flag is meant to remain disabled, and only enabled by developers for
experiments.

Bug: 881215
Change-Id: I8ee71a6f988554e0479f420b77996687fd32685c
Reviewed-on: https://chromium-review.googlesource.com/c/1353059Reviewed-by: Dan Erat <derat@chromium.org>
Commit-Queue: Jia Meng <jiameng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611961}

 - HTMLElement.prototype.attachInternals() should throw InvalidStateErrors
   for customized built-in elements.
 - Form-related operations and attributes of ElementInternals should throw
   InvalidStateErrors for non-form-associated custom elements.

Bug: 905922
Bug: https://github.com/w3c/webcomponents/issues/187
Change-Id: I09e574a843296b236fe4c63eb2cd0912c7a673b1
Reviewed-on: https://chromium-review.googlesource.com/c/1353035Reviewed-by: Hayato Ito <hayato@chromium.org>
Commit-Queue: Kent Tamura <tkent@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611960}

https://pdfium.googlesource.com/pdfium.git/+log/b67698386664..0559d9d48f8b


git log b67698386664..0559d9d48f8b --date=short --no-merges --format='%ad %ae %s'
2018-11-28 thestig@chromium.org Get rid of "exceptions" in CBC_OneDimWriter::AppendPattern().
2018-11-28 tsepez@chromium.org Avoid overflow when rounding 2147483616 to a 32-bit boundary.
2018-11-28 thestig@chromium.org Get rid of "exceptions" in CBC_QRCoderMaskUtil::GetDataMaskBit().
2018-11-28 thestig@chromium.org Get rid of "exceptions" in CBC_QRCoderMode::GetCharacterCountBits().
2018-11-28 tsepez@chromium.org Remove redundant CPDF_PDF417::CODEWORD_TABLE high half-word
2018-11-28 tsepez@chromium.org Bound acess to g_ arrays in BC_PDF417HighLevelEncoder.cpp


Created with:
  gclient setdep -r src/third_party/pdfium@0559d9d48f8b

The AutoRoll server is located here: https://autoroll.skia.org/r/pdfium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:909718,chromium:906465
TBR=dsinclair@chromium.org

Change-Id: Ibceba319de2c5b663eff58cdbf3a50bdeac94a8f
Reviewed-on: https://chromium-review.googlesource.com/c/1354340Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611959}

We are rolling to 1.3.40 for stability. We plan to roll to a newer
version once there are no CQ blocking bugs.

Bug: 872904
Change-Id: If0087a324f1c19ccd697a7071069c41d6e84ee4b
Reviewed-on: https://chromium-review.googlesource.com/c/1352523
Commit-Queue: Sam Maier <smaier@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611958}

    I tested: 1. open pip window, 2. move around, 3. resize, 4. close,
    5. re-open, 6. close tab destroying the window
    off.

Bug: 841886
Test: Chrome PIP works with rounded corners flag both on and off.
Test: Android PIP window works with rounded corners flag both on and
Change-Id: Iec59abde476d56c58e197b9220ac6ba418801395
Reviewed-on: https://chromium-review.googlesource.com/c/1347969Reviewed-by: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Reviewed-by: Tommy Steimel <steimel@chromium.org>
Commit-Queue: Eliot Courtney <edcourtney@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611957}

ChromeContentBrowserClient is already reviewable by all. It seems
the other parts of ChromeContent*Client should also, so do the
same for ChromeContentClient and ChromeContentRendererClient.

Change-Id: I855d7ab540366bd6512b1c1d9e9042975e3456c5
Reviewed-on: https://chromium-review.googlesource.com/c/1352083Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611956}

At onLoad, Preconnect to the origin that has the highest preconnect
score as long as the score is above the specified threshold.
Currently, due to privacy constraints, this is restricted to
only the document origin.

Effectively, this means that we preconnect to the document origin
only if its preconnect score is more than the specified threshold.
If not, no preconnect action is taken.

The preconnect score of an origin is computed from the score
of all the anchor elements on the webpage that point to that
origin.

Change-Id: Ie3178f352cb5106124e13cb6f7e39b9ecf81174c
Bug: 903945
Reviewed-on: https://chromium-review.googlesource.com/c/1349874Reviewed-by: Ryan Sturm <ryansturm@chromium.org>
Commit-Queue: Tarun Bansal <tbansal@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611955}

This patch makes CL:1251142 tests pass. LayoutNG was not setting
the  InlineOutlineWithContinuation flag.

Bug: 835484
Change-Id: If42b64316e71bb3c23ef05284b2c220b6baf4700
Reviewed-on: https://chromium-review.googlesource.com/c/1354319
Commit-Queue: Aleks Totic <atotic@chromium.org>
Reviewed-by: Morten Stenshorne <mstensho@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611954}

Fix two typos and align IntDef definition to definitions from other files.

Change-Id: I034d3cf27ceb745c5584f3449df1827383ebdefd
Reviewed-on: https://chromium-review.googlesource.com/c/1353994Reviewed-by: Ted Choc <tedchoc@chromium.org>
Commit-Queue: Marcin Wiącek <marcin@mwiacek.com>
Cr-Commit-Position: refs/heads/master@{#611953}

This CL may cause a small binary size increase, roughly proportional
to how long it's been since our last AFDO profile roll. For larger
increases (around or exceeding 100KB), please file a bug against
gbiv@chromium.org. Additional context: https://crbug.com/805539

Please note that, despite rolling to chrome/android, this profile is
used for both Linux and Android.

The AutoRoll server is located here: https://autoroll.skia.org/r/afdo-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=gbiv@chromium.org

Change-Id: I37c3a50a0b51a7bdad1162c1d0e1670c55c95f06
Reviewed-on: https://chromium-review.googlesource.com/c/1354336Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611952}

This CL removes macro usage from /ios/chrome/browser/ssl.

This CL was uploaded by git cl split.

R=estark@chromium.org

Bug: 589840
Change-Id: I603edc1c7e8aff2d4aae44722285ed7c0976c613
Reviewed-on: https://chromium-review.googlesource.com/c/1351966Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mike Dougherty <michaeldo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611951}

https://chromium.googlesource.com/angle/angle.git/+log/c4e0a1e511fc..5829c03d383e


git log c4e0a1e511fc..5829c03d383e --date=short --no-merges --format='%ad %ae %s'
2018-11-28 syoussefi@chromium.org Vulkan: fix ProgramVk never releasing uniform buffers
2018-11-28 syoussefi@chromium.org Vulkan: Make DynamicBuffer use BufferHelper
2018-11-28 ynovikov@chromium.org Rearrange Android lib deps


Created with:
  gclient setdep -r src/third_party/angle@5829c03d383e

The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=fjhenigman@chromium.org

Change-Id: I87bb56bc3f997ea442c04b049f9bdd20dcbedce8
Reviewed-on: https://chromium-review.googlesource.com/c/1354306Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#611950}

This is a reland of e45a6ef0

The original CL was reverted because a DCHECK was being hit. The
TrayBluetoothHelperLegacy implementation would sometimes call
OnBluetoothSystemStateChanged without the state actually changing
which would cause the DCHECK to be hit.

A separate CL (https://crrev.com/c/1352123) fixed
TrayBluetoothHelperLegacy so now the DCHECK shouldn't be hit.

Original change's description:
> bluetooth: Query for devices every second in TrayBluetoothHelper
>
> Before TrayBluetoothHelper would get notified of any changes to devices.
> This caused problems in busy environments because TrayBluetoothHelper
> would get notified hundreds or even thousands of times per second of
> devices changes.
>
> This CL changes to a "pull" pattern where TrayBluetootHelper queries
> for devices every second. The devices are then cached so that clients
> of TrayBluetoothHelper can access them synchronously.
>
> TrayBluetoothHelper queries for devices as long as the state is
> kPoweredOn. If the state changes, the device list is cleared.
>
> Bug: 882346
>
> TEST=The following actions should be performed:
>
> 1. Turn bluetooth on and off in system tray.
> 2. Open device list in system menu.
> 3. Connect to a device.
> 4. See that the pod feature button in the system tray indicates a
>    device is connected when connected to a device.
>
> Change-Id: Id9028546a627f260527aa737f51c032f74a447ec
> Reviewed-on: https://chromium-review.googlesource.com/c/1347638
> Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
> Reviewed-by: Tetsui Ohkubo <tetsui@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611069}

TBR=tetsui@chromium.org

Bug: 882346
Change-Id: Ief9ce3d77a317dfde2a5fcc49cb0c598aaa9012d
Reviewed-on: https://chromium-review.googlesource.com/c/1352078Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611949}

This wires the IsUserVerifyingPlatformAuthenticator API call up to its
implementation in the native Windows API, where available.

Bug: 898718
Change-Id: I40307ff39f8dc8e02197debc48041aad62d253ac
Reviewed-on: https://chromium-review.googlesource.com/c/1351900
Commit-Queue: Adam Langley <agl@chromium.org>
Reviewed-by: Adam Langley <agl@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611948}

The package was removed from nacl_list in r607986.

BUG=None
TBR=dpranke

Change-Id: I052e3a0fdc5f58834bfec9b38502b5aa60e2edf0
Reviewed-on: https://chromium-review.googlesource.com/c/1354353Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611947}

This is a reland of afad6853

Original change's description:
> Move device service to new service APIs
>
> Migrates device service code and tests from deprecated service APIs to
> new ones. Namely this phases out its use of ServiceContext and
> ServiceTest in favor of ServiceBinding and plain old unit tests.
>
> Bug: 891780,906239
> Change-Id: I7677134b5d11e7297b162bbb532dfabb810504d2
> Reviewed-on: https://chromium-review.googlesource.com/c/1345124
> Commit-Queue: Ken Rockot <rockot@google.com>
> Reviewed-by: John Abd-El-Malek <jam@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Colin Blundell <blundell@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#611379}

TBR=jam@chromium.org
TBR=blundell@chromium.org
NOPRESUBMIT=true

Bug: 891780, 906239
Change-Id: I3d61c1d0229e04d10adc4bcfe9032a50d5238ced
Reviewed-on: https://chromium-review.googlesource.com/c/1352805Reviewed-by: Ken Rockot <rockot@google.com>
Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611946}

Add support for extensions requesting content script permissions in the
permissions API. This allows extensions to request withheld content
script permissions through chrome.permissions.request().

Add tests to cover the same.

Bug: 889654
Change-Id: I0b77215ec154e42d1152df3277307d0383cda204
Reviewed-on: https://chromium-review.googlesource.com/c/1347061Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611945}

Bug: 827582
Change-Id: I86a4d5cba5901fb7430c554a4fc978789f51fb49
Reviewed-on: https://chromium-review.googlesource.com/c/1354418
Commit-Queue: Clark DuVall <cduvall@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611944}

Tab no longer use the VoiceSearchTabHelper, so ordering is not needed
any more

Bug: 778416
Change-Id: I37a84f76de97be5af8956eb829808f86ac839468
Reviewed-on: https://chromium-review.googlesource.com/c/1353937Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611943}

This was replaced by ScenicGpuHost but not removed.

Bug: 861853
Test: compile
Change-Id: I6c982b87a6f9d64abb975ebfd4ac2d024333d503
Reviewed-on: https://chromium-review.googlesource.com/c/1354480Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611942}

This is a reland of d3708f20

The previous CL did not return the device to the original rotation.

Original change's description:
> [ios] Create UI test for page info (site info)
>
> This CL creates an UI integration test that tests that the
> page info view gets automatically dismissed on device rotation.
>
> Change-Id: I02611cc2fab5a214b74af01d15cd8d12e19eff6e
> Reviewed-on: https://chromium-review.googlesource.com/c/1338561
> Commit-Queue: edchin <edchin@chromium.org>
> Reviewed-by: Gauthier Ambard <gambard@chromium.org>
> Reviewed-by: Rohit Rao <rohitrao@chromium.org>
> Reviewed-by: edchin <edchin@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#608844}

Change-Id: I5c4a8286275b1ab3d411d4e355557d499607437a
Reviewed-on: https://chromium-review.googlesource.com/c/1343517
Commit-Queue: edchin <edchin@chromium.org>
Reviewed-by: Rohit Rao <rohitrao@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Reviewed-by: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611941}

The motivation to do this is to be able to convert in annotation mode
when the plugin is not active.

Fortunately it turns out that there is enough information to do this
without communicating with the plugin -- the dimensions of each page
are available and the translation from points to pixels is straightforward.

This new implementation also deals with the case where the
document has been rotated.

Bug: 902646
Change-Id: Id2814f96f6020c44cee07f725f5170494f1b512b
Reviewed-on: https://chromium-review.googlesource.com/c/1347646Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Reviewed-by: Henrique Nakashima <hnakashima@chromium.org>
Commit-Queue: dstockwell <dstockwell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611940}

When using native GTK frame buttons, we only want the padding returned by
NavButtonProvider::GetTopAreaSpacing() to apply to the side(s) that actually
have frame buttons on them, otherwise the padding on a tab that is adjacent to
the frame edge will depend on which GTK theme is used, rather than being
constant across all themes.

BUG=None
R=pkasting

Change-Id: Ibf5bb40c0d51d6387ca2b21abc54b1adad8f69b0
Reviewed-on: https://chromium-review.googlesource.com/c/1287261
Commit-Queue: Thomas Anderson <thomasanderson@chromium.org>
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#611939}