GitLab

Contributed by Denis Pravdin <denis.pravdin@intel.com>

Review URL: https://codereview.chromium.org/719853003

git-svn-id: svn://svn.chromium.org/blink/trunk@185428 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Animations: Disable compositor when timeline playback rate is set (patchset #2 id:20001 of https://codereview.chromium.org/722203004/)

Reason for revert:
Compilation failed on Mac and Linux:

FAILED: /Volumes/data/b/build/goma/gomacc ../../third_party/llvm-build/Release+Asserts/bin/clang++ -MMD -MF obj/third_party/WebKit/Source/core/animation/webcore_remaining.AnimationTimeline.o.d -DV8_DEPRECATION_WARNINGS -D__ASSERT_MACROS_DEFINE_VERSIONS_WITHOUT_UNDERSCORE=0 -DCHROMIUM_BUILD -DCR_CLANG_REVISION=218707 -DUSE_LIBJPEG_TURBO=1 -DENABLE_ONE_CLICK_SIGNIN -DENABLE_PRE_SYNC_BACKUP -DENABLE_REMOTING=1 -DENABLE_WEBRTC=1 -DENABLE_PEPPER_CDMS -DENABLE_CONFIGURATION_POLICY -DENABLE_NOTIFICATIONS -DENABLE_HIDPI=1 -DDISCARDABLE_MEMORY_ALWAYS_SUPPORTED_NATIVELY -DSYSTEM_NATIVELY_SIGNALS_MEMORY_PRESSURE -DDONT_EMBED_BUILD_METADATA -DENABLE_TASK_MANAGER=1 -DENABLE_EXTENSIONS=1 -DENABLE_PLUGIN_INSTALLATION=1 -DENABLE_PLUGINS=1 -DENABLE_SESSION_SERVICE=1 -DENABLE_THEMES=1 -DENABLE_AUTOFILL_DIALOG=1 -DENABLE_BACKGROUND=1 -DENABLE_GOOGLE_NOW=1 -DCLD_VERSION=2 -DENABLE_PRINTING=1 -DENABLE_BASIC_PRINTING=1 -DENABLE_PRINT_PREVIEW=1 -DENABLE_SPELLCHECK=1 -DENABLE_CAPTIVE_PORTAL_DETECTION=1 -DENABLE_APP_LIST=1 -DENABLE_SETTINGS_APP=1 -DENABLE_MANAGED_USERS=1 -DENABLE_SERVICE_DISCOVERY=1 -DENABLE_WIFI_BOOTSTRAPPING=1 -DENABLE_LOAD_COMPLETION_HACKS=1 -DBLINK_IMPLEMENTATION=1 -DINSIDE_BLINK -DWebCoreTextFieldCell=ChromiumWebCoreObjCWebCoreTextFieldCell -DWebCoreRenderThemeNotificationObserver=ChromiumWebCoreObjCWebCoreRenderThemeNotificationObserver -DENABLE_OPENTYPE_VERTICAL=1 -DENABLE_LAYOUT_UNIT_IN_INLINE_BOXES=0 -DWTF_USE_CONCATENATED_IMPULSE_RESPONSES=1 -DENABLE_INPUT_MULTIPLE_FIELDS_UI=1 -DENABLE_WEB_AUDIO=1 -DENABLE_OILPAN=1 -DU_USING_ICU_NAMESPACE=0 -DU_ENABLE_DYLOAD=0 -DU_STATIC_IMPLEMENTATION -DSK_ENABLE_INST_COUNT=0 -DSK_SUPPORT_GPU=1 '-DGR_GL_CUSTOM_SETUP_HEADER="GrGLConfig_chrome.h"' -DSK_ENABLE_LEGACY_API_ALIASING=1 -DSK_ATTR_DEPRECATED=SK_NOTHING_ARG1 -DGR_GL_IGNORE_ES3_MSAA=0 -DSK_WILL_NEVER_DRAW_PERSPECTIVE_TEXT -DSK_SUPPORT_LEGACY_TEXTRENDERMODE -DSK_IGNORE_GPU_LAYER_HOISTING -DSK_USE_POSIX_THREADS -DCHROME_PNG_WRITE_SUPPORT -DPNG_USER_CONFIG -DLIBXML_STATIC -DLIBXSLT_STATIC -DUSE_LIBPCI=1 -DUSE_OPENSSL=1 -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -DNDEBUG -DNVALGRIND -DDYNAMIC_ANNOTATIONS_ENABLED=0 -D_FORTIFY_SOURCE=2 -Igen -I../../third_party/WebKit/Source -I../.. -I../../skia/config -I../../third_party/khronos -I../../gpu -Igen/blink -I../../third_party/angle/include -I../../third_party/icu/source/i18n -I../../third_party/icu/source/common -I../../third_party/WebKit -I../../third_party/skia/src/core -I../../third_party/skia/include/core -I../../third_party/skia/include/effects -I../../third_party/skia/include/pdf -I../../third_party/skia/include/gpu -I../../third_party/skia/include/lazy -I../../third_party/skia/include/pathops -I../../third_party/skia/include/pipe -I../../third_party/skia/include/ports -I../../third_party/skia/include/utils -I../../third_party/skia/include/utils/mac -I../../skia/ext -I../../third_party/iccjpeg -I../../third_party/libpng -I../../third_party/libwebp -I../../third_party/libxml/mac/include -I../../third_party/libxml/src/include -I../../third_party/libxslt -I../../third_party/npapi -I../../third_party/npapi/bindings -I../../third_party/ots/include -I../../third_party/qcms/src -I../../third_party/sqlite -I../../third_party/zlib -I../../v8/include -isysroot /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.6.sdk -O2 -fvisibility=hidden -Werror -Wnewline-eof -mmacosx-version-min=10.6 -arch i386 -Wall -Wendif-labels -Wextra -Wno-unused-parameter -Wno-missing-field-initializers -Wno-selector-type-mismatch -Wheader-hygiene -Wno-char-subscripts -Wno-unneeded-internal-declaration -Wno-covered-switch-default -Wstring-conversion -Wno-c++11-narrowing -Wno-deprecated-register -Wglobal-constructors -Wexit-time-destructors -std=c++11 -fno-rtti -fno-exceptions -fvisibility-inlines-hidden -fno-threadsafe-statics -Xclang -load -Xclang /Volumes/data/b/build/slave/WebKit_Mac_Oilpan/build/src/third_party/llvm-build/Release+Asserts/lib/libFindBadConstructs.dylib -Xclang -add-plugin -Xclang find-bad-constructs -fcolor-diagnostics -fno-strict-aliasing -Xclang -load -Xclang /Volumes/data/b/build/slave/WebKit_Mac_Oilpan/build/src/third_party/llvm-build/Release+Asserts/lib/libBlinkGCPlugin_12.dylib -Xclang -add-plugin -Xclang blink-gc-plugin -Xclang -plugin-arg-blink-gc-plugin -Xclang enable-oilpan -include ../../third_party/WebKit/Source/build/mac/Prefix.h -c ../../third_party/WebKit/Source/core/animation/AnimationTimeline.cpp -o obj/third_party/WebKit/Source/core/animation/webcore_remaining.AnimationTimeline.o
../../third_party/WebKit/Source/core/animation/AnimationTimeline.cpp:242:16: error: non-const lvalue reference to type 'blink::AnimationPlayer *' cannot bind to a temporary of type 'blink::AnimationPlayer *'
    for (auto& player : m_players) {
               ^      ~
../../third_party/WebKit/Source/wtf/HashSet.h:73:18: note: selected 'begin' function with iterator type 'iterator' (aka 'HashTableConstIteratorAdapter<HashTableType, ValueTraits>')
        iterator begin() const;
                 ^
1 error generated.


Original issue's description:
> Animations: Disable compositor when timeline playback rate is set
> 
> This change invalidates all compositor animations when the animation
> timeline playback rate is modified. If the timeline playback rate is not
> 1, then animations are no longer composited.
> 
> BUG=432368
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185424

TBR=dstockwell@chromium.org,samli@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=432368

Review URL: https://codereview.chromium.org/734003002

git-svn-id: svn://svn.chromium.org/blink/trunk@185427 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=433324
R=yurys, dslomov

Review URL: https://codereview.chromium.org/729513002

git-svn-id: svn://svn.chromium.org/blink/trunk@185426 bbb929c8-8fbe-4397-9dbb-9b2b20218538

For unconditionally garbage collected types, use of RawPtr<> is
unnecessary.

Review URL: https://codereview.chromium.org/727523002

git-svn-id: svn://svn.chromium.org/blink/trunk@185425 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This change invalidates all compositor animations when the animation
timeline playback rate is modified. If the timeline playback rate is not
1, then animations are no longer composited.

BUG=432368

Review URL: https://codereview.chromium.org/722203004

git-svn-id: svn://svn.chromium.org/blink/trunk@185424 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Multiple RecalcStyle events can occur in a single frame and we didn't
have a good test for associating invalidation events in this case. This
patch also does some minor cleanup of the style recalc test.

BUG=410701

Review URL: https://codereview.chromium.org/727253002

git-svn-id: svn://svn.chromium.org/blink/trunk@185423 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=405921

Review URL: https://codereview.chromium.org/721133003

git-svn-id: svn://svn.chromium.org/blink/trunk@185422 bbb929c8-8fbe-4397-9dbb-9b2b20218538

When an element's renderer is being reattached, previously we reattach
whitespace siblings, causing full paint invalidation of the parent.

If the whitespace sibling needed renderer and still needs renderer,
don't reattach.

- Renamed Node::reattachWhitespaceSiblings() to
  Node::reattachWhitespaceSlibingsIfNeeded();
- In the function, test if rendererIsNeeded changed before reattaching;
- Modified Text::textRendererIsNeeded() so that it can return correct
  value when the Text has already renderer.

BUG=428997
TEST=fast/repaint/absolute-display-block-to-none.html
TEST=fast/forms/select-listbox-focus-displaynone.html (Existing test
covering the change in Text.cpp).

Review URL: https://codereview.chromium.org/684633006

git-svn-id: svn://svn.chromium.org/blink/trunk@185421 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This CL adds a SuppressLog argument to MixedContentChecker::shouldBlockFetch to suppress logging for preload requests.
This makes it consistent with content security policy checks which also do not warn on preload requests.

BUG=432771

Review URL: https://codereview.chromium.org/726563004

git-svn-id: svn://svn.chromium.org/blink/trunk@185420 bbb929c8-8fbe-4397-9dbb-9b2b20218538

StyleResolver::m_keyFrameRulesMap is never used and can be deleted.

BUG=none
TEST=compile

Review URL: https://codereview.chromium.org/716403002

git-svn-id: svn://svn.chromium.org/blink/trunk@185419 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=429060
TEST=http/tests/serviceworker/

Review URL: https://codereview.chromium.org/728713003

git-svn-id: svn://svn.chromium.org/blink/trunk@185418 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The problem is that the mouse events aren't fired when there is the element culled inline
like label element that doesn't has any background color or border or self-layer.
We already handle area-based hit-tests for culled inline.
This patch makes hit-test include not only area-based hit-tests but also point-based ones at the place handling culled inline.

BUG=312199
R=rbyers@chromium.org, pdr@chromium.org, leviw@chromium.org
TEST=LayoutTests/fast/events/hit-test-culled_inline.html

Review URL: https://codereview.chromium.org/685963002

git-svn-id: svn://svn.chromium.org/blink/trunk@185417 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The spec of ServiceWorker was changed.
https://github.com/slightlyoff/ServiceWorker/issues/559
https://github.com/slightlyoff/ServiceWorker/commit/fe2cd64e9d84c316fc02b7c29648b0c712402746

BUG=N/A
TEST=http/tests/serviceworker/

Review URL: https://codereview.chromium.org/723963003

git-svn-id: svn://svn.chromium.org/blink/trunk@185416 bbb929c8-8fbe-4397-9dbb-9b2b20218538

It timeouts on not only Mac and Win, but also on Linux.
Flakiness dashboard:
http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=virtual%2Fgpu%2Ffast%2Fcanvas%2Fcanvas-composite-image.html

NOTRY=true
BUG=433711
TBR=yosin@chromium.org

Review URL: https://codereview.chromium.org/733043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185415 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a refactoring and does not change behavior.

BUG=None

Review URL: https://codereview.chromium.org/728453002

git-svn-id: svn://svn.chromium.org/blink/trunk@185413 bbb929c8-8fbe-4397-9dbb-9b2b20218538

http://test-results.appspot.com/dashboards/flakiness_dashboard.html#tests=back-send-referrer.html%2C%20canvas-composite-image.html%C2%A0

BUG=433710, 433711
TBR=dongseong.hwang@intel.com
NOTRY=true

Review URL: https://codereview.chromium.org/729313002

git-svn-id: svn://svn.chromium.org/blink/trunk@185412 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Revert of Disable AcceptEx on Win32 Apache (patchset #1 id:1 of https://codereview.chromium.org/695193006/)

Reason for revert:
It was not the culprit of the serviceworker test flakiness.

Original issue's description:
> Disable AcceptEx on Win32 Apache
> 
> Some layout tests time out since the switch to apache server, with
> AcceptEx failures logged on error log. This may fix the issue.
> 
> BUG=30536, 431172
> 
> Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=185174

TBR=dpranke@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=30536, 431172

Review URL: https://codereview.chromium.org/734553002

git-svn-id: svn://svn.chromium.org/blink/trunk@185411 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The problem is that Selection is not getting cleared 
after tapping of gesture. This was affected by 
https://codereview.chromium.org/507533002, 
because initialization for m_selectionInitiationState was 
skipped in case of gesture. 
This patch makes m_selectionInitiationState be initialized
after dispatching mousedown event for gesture tapping.

BUG=429967
R=rbyers@chromium.org
TEST=LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range.html

Review URL: https://codereview.chromium.org/705733002

git-svn-id: svn://svn.chromium.org/blink/trunk@185410 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=haraken
BUG=420515

Review URL: https://codereview.chromium.org/725293002

git-svn-id: svn://svn.chromium.org/blink/trunk@185409 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Previously RenderTreeBuilder::createRendererForTextIfNeeded()
and RenderTreeBuilder::createRendererForElementIfNeeded() are called
from Element and Text, respectively.

This refactoring separates logics needed for creating renderer
for Element and for Text, reducing isElement and isText checks.

More importantly, this refactoring exposes 
RenderTreeBuilderForText::createRenderer()
so that we can test Text::textRendererIsNeeded() only once when
we reattach whitespace siblings
(for https://codereview.chromium.org/684633006/).

BUG=482997

Review URL: https://codereview.chromium.org/699213003

git-svn-id: svn://svn.chromium.org/blink/trunk@185407 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Review URL: https://codereview.chromium.org/727093002

git-svn-id: svn://svn.chromium.org/blink/trunk@185406 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This is a reland of first letter as a psuedo element after the revert
in r184113.

Currently, first letter renderers are created and destroyed through the
updateFirstLetters() call in RenderBlock. This has, historically, been
problematic as we may miss places where the call was required, leading to
accessing invalid memory.

This CL converts the first letter code to use a PseudoElement for the
first-letter instead of creating classes during layout.

With the PseudoElement implementation the two tests which are currently in
LayoutTests/fast/css/first-letter-removed-added.html work as expected.

BUG=391288

Review URL: https://codereview.chromium.org/672953002

git-svn-id: svn://svn.chromium.org/blink/trunk@185405 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These forward references are not needed anymore. After
this patch, Source/core has no unneeded forward references
any more.

Review URL: https://codereview.chromium.org/732803003

git-svn-id: svn://svn.chromium.org/blink/trunk@185404 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This has been moved into the infra repo at:
https://chromium.googlesource.com/infra/infra/+/master/appengine/sheriff_o_matic/

NOTRY=true
R=dpranke@chromium.org

Review URL: https://codereview.chromium.org/728023004

git-svn-id: svn://svn.chromium.org/blink/trunk@185403 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This allows us to get rid of a related state bit on RenderLayer as well.

Review URL: https://codereview.chromium.org/727633002

git-svn-id: svn://svn.chromium.org/blink/trunk@185402 bbb929c8-8fbe-4397-9dbb-9b2b20218538

(Have not yet checked how many tests pass with slimming paint on, that will be next.)

BUG=423071

Review URL: https://codereview.chromium.org/721773005

git-svn-id: svn://svn.chromium.org/blink/trunk@185401 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=412088

Review URL: https://codereview.chromium.org/729823002

git-svn-id: svn://svn.chromium.org/blink/trunk@185400 bbb929c8-8fbe-4397-9dbb-9b2b20218538

R=chrishtr@chromium.org

Review URL: https://codereview.chromium.org/721363002

git-svn-id: svn://svn.chromium.org/blink/trunk@185399 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These are flaky after https://codereview.chromium.org/467153003, which
made a 0ms setTimeout() no longer be a minimum 1ms delay.

These tests all depend on doing work during or after the load event, but
attempt to do so in ways that aren't strictly guaranteed to meet that
requirement.

BUG=

Review URL: https://codereview.chromium.org/733633003

git-svn-id: svn://svn.chromium.org/blink/trunk@185398 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=406422
TEST=Updated results to fast/loader/create-frame-in-DOMContentLoaded.html

Review URL: https://codereview.chromium.org/725593004

git-svn-id: svn://svn.chromium.org/blink/trunk@185397 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Part of my ultimate goal of de-coupling invalidation and painting of selection
gaps from one function so I can move the painting into BlockFlowPainter.

We don't actually paint selection gaps for non-blockFlow RenderBlocks. Make the
code actually represent that!

Review URL: https://codereview.chromium.org/720313002

git-svn-id: svn://svn.chromium.org/blink/trunk@185396 bbb929c8-8fbe-4397-9dbb-9b2b20218538

RLSA RenderBlock needs layouts excluding the CustomScrollbar thickness.
Set children of RenderBlock width is changed upon CustomScrollbar 
thickness change. This ensures to re-layout RLSA RenderBlock 
considering the CustomScrollbar thickness.

BUG= 431528

Review URL: https://codereview.chromium.org/708283002

git-svn-id: svn://svn.chromium.org/blink/trunk@185395 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Skobes has 60 patches in core/rendering[1] including work deep in layout
for text autosizing, and scrollbar code.

[1] git shortlog --author=skobes Source/core/rendering/ | wc -l

R=dsinclair,pdr

Review URL: https://codereview.chromium.org/725273002

git-svn-id: svn://svn.chromium.org/blink/trunk@185394 bbb929c8-8fbe-4397-9dbb-9b2b20218538

These belong on the KeyboardEvent interface, so add them to
KeyboardEvent.idl and count anything that still falls back to UIEvent.

MouseEvent.which does not appear to be in any spec, but it is supported
by most browsers. Measure its usage to help determine its future.

Review URL: https://codereview.chromium.org/725073003

git-svn-id: svn://svn.chromium.org/blink/trunk@185393 bbb929c8-8fbe-4397-9dbb-9b2b20218538

- implement synthetic FirstPaint markers on front-end (they used to be generated
    on the back-end with old Timeline instrumentation which is an ex-parrot)
- remove brown marks near the frame markers (regressed at r177959)

BUG=

Review URL: https://codereview.chromium.org/732683002

git-svn-id: svn://svn.chromium.org/blink/trunk@185392 bbb929c8-8fbe-4397-9dbb-9b2b20218538

The width variant is actually just a font feature request.
Now that HarfBuzzShaper::setFontFeatures() takes care of setting these
font features based on the FontDescription, there is no longer a need
to plumb these values though FontPlatformData.

Review URL: https://codereview.chromium.org/715363005

git-svn-id: svn://svn.chromium.org/blink/trunk@185391 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Checking the existence of _WIN32_WINNT_WINBLUE is incorrect, rather
we should check that the value of _WIN32_WINNT is the desired value
as that's the level that the headers are exposing.

Also, move #include of windows.h up above check for include of
versionhelpers.h, otherwise the defines are changed mid-file which
causes problems.

Also, fix typo in spelling of "condition".

(Follow up to https://codereview.chromium.org/39693002)

R=yosin@chromium.org, tkent@chromium.org
BUG=311488, 432748

Review URL: https://codereview.chromium.org/732673002

git-svn-id: svn://svn.chromium.org/blink/trunk@185390 bbb929c8-8fbe-4397-9dbb-9b2b20218538

This may have been used for AppKit integration at some point in the
distant past. Two checks for the left mouse button have been moved
up a bit higher and combined, since drags cannot be triggered by
any other button.

BUG=none

Review URL: https://codereview.chromium.org/726703002

git-svn-id: svn://svn.chromium.org/blink/trunk@185389 bbb929c8-8fbe-4397-9dbb-9b2b20218538

Unnecessary GC::scale() alias.

R=schenney@chromium.org,senorblanco@chromium.org
BUG=424655

Review URL: https://codereview.chromium.org/725043002

git-svn-id: svn://svn.chromium.org/blink/trunk@185388 bbb929c8-8fbe-4397-9dbb-9b2b20218538

BUG=409580
TBR=pfeldman

Review URL: https://codereview.chromium.org/720613003

git-svn-id: svn://svn.chromium.org/blink/trunk@185387 bbb929c8-8fbe-4397-9dbb-9b2b20218538