GitLab

Review URL: http://codereview.chromium.org/8341123

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108034 0039d316-1c4b-4281-b951-d872f2087c98

Review URL: http://codereview.chromium.org/8387054

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108033 0039d316-1c4b-4281-b951-d872f2087c98

SyncSetupFlow gets preferred types from PSS::GetPreferredTypes() rather than
looking at the preferences directly.

BUG=92625
TEST=none

Review URL: http://codereview.chromium.org/8400076

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108031 0039d316-1c4b-4281-b951-d872f2087c98

BUG=96722
TEST=none


Review URL: http://codereview.chromium.org/8429021

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108030 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=none
R=ben@chromium.org

Review URL: http://codereview.chromium.org/8416053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108029 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=PhishingDOMFeatureExtractorTest


Review URL: http://codereview.chromium.org/8384023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108028 0039d316-1c4b-4281-b951-d872f2087c98

Modify dialog creation flow to allow an off the record profile to be used in an html dialog.  Fixes issues with cloud print where the signed-in state of the page and dialogs are out of sync.

Adds DCHECKS that fire if a non-modal dialog is created with an off the record profile.

This provides a temporary solution to sign-in issues on most platforms.  A longer term solution is in the works to eliminate our dependency on html dialog.

BUG=99271
TEST=


Review URL: http://codereview.chromium.org/8343043

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108027 0039d316-1c4b-4281-b951-d872f2087c98

This is a reland of accumulated patches including CLs
8414036, 8425010, 8425013, 8424013.

It fully enables tracking of objects, as seen in about:tracking
in teh release build.

The problem this had in its initaial landing centered on
Mac instability in base_unittest.  We were encountering crash
on exit of the tests, with a stack dump involving pthreads.


r=rtenneti
BUG=101856
Review URL: http://codereview.chromium.org/8429009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108026 0039d316-1c4b-4281-b951-d872f2087c98

BUG=76697
Review URL: http://codereview.chromium.org/8432011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108025 0039d316-1c4b-4281-b951-d872f2087c98

TBR:junov
BUG:102428
Review URL: http://codereview.chromium.org/8431013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108024 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101934
TEST=none


Review URL: http://codereview.chromium.org/8341090

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108023 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium:100732
TEST=Launch ChromeOS and go to the System settings page.  Tap or press and hold the brightness buttons to adjust the screen brightness.


Review URL: http://codereview.chromium.org/8340002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108022 0039d316-1c4b-4281-b951-d872f2087c98

Move the Win32X86Generator and Patcher classes to non-windows specific  names since they can be reused untouched for Elf. Move them from one file to files with matching names while at it.

Store the transformation kind on the generator class so that it can be know if it's PE or Elf.

Unified the TransformationId and ExecutableType enums into a single enum used everywhere (defined in courgette.h since it's now part of the external API).

BUG=chromium-os:22149
TEST=Unittests


Review URL: http://codereview.chromium.org/8417045

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108019 0039d316-1c4b-4281-b951-d872f2087c98

Previously the tests were relying on locks internal to the class to prevent race conditions. Instead wait for callbacks to be executed by using a combination of synchronization primitives.

Review URL: http://codereview.chromium.org/8414041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108017 0039d316-1c4b-4281-b951-d872f2087c98

BUG=23581
TEST=None


Review URL: http://codereview.chromium.org/8413022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108016 0039d316-1c4b-4281-b951-d872f2087c98

I broke this in r108008.

BUG=none
TEST=compiles and passes on linux

Review URL: http://codereview.chromium.org/8431012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108015 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102303
TEST=Run views chrome. Go to chrome://settings/personal. Sign in to sync. Click "Advanced". OK button should be on left. In non-views chrome (mac, linux), OK button should be on right.


Review URL: http://codereview.chromium.org/8387033

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108014 0039d316-1c4b-4281-b951-d872f2087c98

BUG=101993
TEST=https://chrome.google.com/webstore/detail/imjhdahelgojehmfmkmdfjcpfbglbfmj should install without error.


Review URL: http://codereview.chromium.org/8424005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108013 0039d316-1c4b-4281-b951-d872f2087c98

Fix valgrind error in new unit test.
Remove valgrind/heapcheck suppressions.
Remove improper reference to a header that does not exist.

BUG=102256
TEST=


Review URL: http://codereview.chromium.org/8429016

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108012 0039d316-1c4b-4281-b951-d872f2087c98

A temp app list window that uses NTP4.

BUG=98308
TEST=Wait till real webui is implemented to verify 98308.


Review URL: http://codereview.chromium.org/8394003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108011 0039d316-1c4b-4281-b951-d872f2087c98

Fix a ChromeFrame crash which occurs in the background worker thread while
dereferencing a NULL automation client.
This crash occurs when the active document is in the process of shutting down
while there are active background
requests still pending.

Fix is to ensure that the background thread has been stopped before returning
from the UrlmonUrlRequestManager::StopAll
function which gets called during CF shutdown.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=102393

BUG=102393
TBR=robertshield
Review URL: http://codereview.chromium.org/8384019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108010 0039d316-1c4b-4281-b951-d872f2087c98

This affects Chrome OS.

1 - If the default path provided isn't managed by the external filesystem
    provider, still keep the base (i.e., file) name.
2 - Fix the JS regex so that it splits the directory/leaf names correctly when
    no path is provided.

BUG=http://code.google.com/p/chromium-os/issues/detail?id=22184
TEST=The main test is that sufficiently-recent Pepper Flash should provide
     correct (Flash) Save As functionality, including the default filename;
     e.g., http://www.everythingflex.com/flex3_fp10/savetodisk/SaveToDisk.html .
     Also, "Save As" for HTML should also provide a default filename on Linux
     chromeos=1 builds.


Review URL: http://codereview.chromium.org/8414006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108009 0039d316-1c4b-4281-b951-d872f2087c98

This also makes aura::DesktopHostLinux avoid generating Char
events when not appropriate, which avoids a problem that I
observed where arrow keys were moving <select> selections two
spaces instead of one.

There still appears to be an issue with the Enter key getting
double-counted in <select> popups, though (but if we avoid
sending a Char event for it, things like <textarea> break),
and fullscreen Flash windows aren't getting updated.

BUG=99757,101899,101848
TEST=manual

Review URL: http://codereview.chromium.org/8417008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108008 0039d316-1c4b-4281-b951-d872f2087c98

My code to suppress the first run search bubble wasn't working. The problem was that we were testing against the entire URL. Fix was to only care about the host.

BUG=102392
TEST=

Review URL: http://codereview.chromium.org/8387036

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108007 0039d316-1c4b-4281-b951-d872f2087c98

parents. This is needed otherwise the worskpace code tries to place
and position bubbles and other transient type windows.

BUG=none
TEST=none
R=ben@chromium.org,oshima@chromium.org

Review URL: http://codereview.chromium.org/8414035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108006 0039d316-1c4b-4281-b951-d872f2087c98

R=flackr@chromium.org
BUG=99970
TEST=browser_tests --gtest_filter=WebUIAssertions*.*


Review URL: http://codereview.chromium.org/8416049

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108005 0039d316-1c4b-4281-b951-d872f2087c98

Move content_restriction.h and main_function_params.h to content/public/common, and put them in the content namespace.

BUG=98716
Review URL: http://codereview.chromium.org/8387039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108004 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/8387037

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108003 0039d316-1c4b-4281-b951-d872f2087c98

BUG=102162
TBR=nsylvain@chromium.org
Review URL: http://codereview.chromium.org/8432007

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108002 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108001 0039d316-1c4b-4281-b951-d872f2087c98

BUG=
TEST=

Review URL: http://codereview.chromium.org/8384013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@108000 0039d316-1c4b-4281-b951-d872f2087c98

1. hide/show titlebar widget when entering/exiting full screen
2. don't show bookmark bar when in fullscreen mode

BUG=97177
TEST=manual -- 1. Open new tab. 2. Full screen. 3. click on a link in the new tab page. 4. You shouldn't see a line at the top.

Review URL: http://codereview.chromium.org/8414014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107999 0039d316-1c4b-4281-b951-d872f2087c98

R=jam@chromium.org
BUG=
TEST=

Review URL: http://codereview.chromium.org/8341129

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107998 0039d316-1c4b-4281-b951-d872f2087c98

Revert 107995 - Fix a ChromeFrame crash which occurs in the background worker thread while dereferencing a NULL automation client.
This crash occurs when the active document is in the process of shutting down while there are active background
requests still pending.

Fix is to ensure that the background thread has been stopped before returning from the UrlmonUrlRequestManager::StopAll
function which gets called during CF shutdown.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=102393

BUG=102393
Review URL: http://codereview.chromium.org/8429011

TBR=ananta@chromium.org
Review URL: http://codereview.chromium.org/8431011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107997 0039d316-1c4b-4281-b951-d872f2087c98

BUG=95573
TEST=no visible change

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=107985

Reverted: http://src.chromium.org/viewvc/chrome?view=rev&revision=107990

Review URL: http://codereview.chromium.org/8429005

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107996 0039d316-1c4b-4281-b951-d872f2087c98

Fix a ChromeFrame crash which occurs in the background worker thread while dereferencing a NULL automation client.
This crash occurs when the active document is in the process of shutting down while there are active background
requests still pending.

Fix is to ensure that the background thread has been stopped before returning from the UrlmonUrlRequestManager::StopAll
function which gets called during CF shutdown.

Fixes bug http://code.google.com/p/chromium/issues/detail?id=102393

BUG=102393
Review URL: http://codereview.chromium.org/8429011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107995 0039d316-1c4b-4281-b951-d872f2087c98

BUG=chromium-os:22290
TEST=Manual: create a new user, sign in, then sign out again. No message 'Chrome didn't shutdown correctly...' should appear beneath the address bar.


Review URL: http://codereview.chromium.org/8429006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107994 0039d316-1c4b-4281-b951-d872f2087c98

Fix some minor "gcl lint" results in these files while I'm at it.

Implementation notes:

1. ScanForHostAndCerts tried to do too much: both search the list for an
HSTS preload and also set one limited criterion (check on required_hashes).
It also returned too little, limiting its usefulness. Replaced it with
GetHSTSPreload which just implements the "return a match; prefer exact
match" semantics and returns the HSTSPreload entry. The caller can then
apply their arbitrary decision criterion (as in IsGooglePinnedProperty) or
use any field from the entry (as in ReportUMAPinFailure). This makes its
interface and implementation simpler, and makes it more useful to more
callers.

2. The IsGooglePinnedProperty unit test still passes, in light of (1).

3. I needed to get from a full hostname to an enum value that I can send in
an UMA_HISTOGRAM_ENUMERATION. Baking the enums into struct HSTSPreload was
the most straightforward and least-bloated way of doing that.

BUG=99782
Review URL: http://codereview.chromium.org/8364023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107993 0039d316-1c4b-4281-b951-d872f2087c98

This should not affect official build since requests with pdf mime type already don't get intercepted when pdf plugin is present.

TEST=Verified pdf can be copied in chromium OS file browser.
     unit_tests:GViewRequestInterceptorTest.*
BUG=chromium-os:21560


Review URL: http://codereview.chromium.org/8357019

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107991 0039d316-1c4b-4281-b951-d872f2087c98

This reverts commit r107985.

BUG=
TEST=

Review URL: http://codereview.chromium.org/8384015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@107990 0039d316-1c4b-4281-b951-d872f2087c98