GitLab

This CL:
* Removes unused / unneeded code from cr-network-select
* Updates cr-network-select and cr-network-list to use flex layout
* Re-factors network_ui.html to use flex

BUG=none
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2627353003
Cr-Commit-Position: refs/heads/master@{#443466}

Adds DeviceDetailsPage to internals page so users can view all the properties
of the DeviceInfo object. No display of service properties is included in this
patch.

Splits action link in Devices table into two separate links: "Inspect"
and "Forget".
Adds functions to add and remove items from the sidebar.
Adds test infrastructure for Device proxy-based tests.
Adds test for DeviceDetailsPage.
Adds unregister function to PageManager.

GIFs: https://goo.gl/photos/zLiv86gyYmQhRn9w8

BUG=651282,663470
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2576603002
Cr-Commit-Position: refs/heads/master@{#443465}

Add an alternative function for combining resource weight with host
visit frequency. This one is a measure of the probability that there
will be a cache hit for the resource, given that resource_weight is the
probability of a cache hit for a single trial and host_visits is the
number of independent trials.

BUG=

Review-Url: https://codereview.chromium.org/2623553003
Cr-Commit-Position: refs/heads/master@{#443464}

 * Adds EnumTraits for TextInputMode and TextInputType.
 * Adds corresponding unittests.
 * Adds missing enum entries in ime.mojom.

BUG=631527

Review-Url: https://codereview.chromium.org/2626383002
Cr-Commit-Position: refs/heads/master@{#443463}

Reland of [ServiceWorker] Mojofy PushEvent of Service Worker. (patchset #1 id:1 of https://codereview.chromium.org/2600863002/ )

Reason for revert:
Fixed the root cause of the crash.
https://crrev.com/64efa56e5bb67106cea0eb4033b866d9217d8324

Original issue's description:
> Revert of [ServiceWorker] Mojofy PushEvent of Service Worker. (patchset #3 id:40001 of https://codereview.chromium.org/2569993002/ )
>
> Reason for revert:
> Causes crashes on canary. See https://crbug.com/676984
>
> 0x5eb4a4fa	(chrome.dll + 0x000fa4fa )	base::Callback<void ,1,1>::Callback<void ,1,1>(base::Callback<void ,1,1> const &)
> 0x6003ec7d	(chrome.dll -service_worker_version.cc:1095 )	content::ServiceWorkerVersion::OnSimpleEventFinished(int,content::ServiceWorkerStatusCode,base::Time)
> 0x5ff64f33	(chrome.dll -bind_internal.h:214 )	base::internal::FunctorTraits<void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),void>::Invoke<scoped_refptr<content::ServiceWorkerVersion> const &,int const &,content::ServiceWorkerStatusCode,base::Time>(void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int const &,content::ServiceWorkerStatusCode &&,base::Time &&)
> 0x5ff50241	(chrome.dll -bind_internal.h:285 )	base::internal::InvokeHelper<0,void>::MakeItSo<void ( content::ServiceWorkerVersion::*const &)(int,blink::WebServiceWorkerEventResult,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int,blink::WebServiceWorkerEventResult,base::Time>(void ( content::ServiceWorkerVersion::*const &)(int,blink::WebServiceWorkerEventResult,base::Time),scoped_refptr<content::ServiceWorkerVersion> const &,int &&,blink::WebServiceWorkerEventResult &&,base::Time &&)
> 0x5ff655a6	(chrome.dll -bind_internal.h:339 )	base::internal::Invoker<base::internal::BindState<void ( content::ServiceWorkerVersion::*)(int,content::ServiceWorkerStatusCode,base::Time),scoped_refptr<content::ServiceWorkerVersion>,int>,void >::Run(base::internal::BindStateBase *,content::ServiceWorkerStatusCode &&,base::Time &&)
> 0x5fbe1b09	(chrome.dll -callback.h:85 )	base::internal::RunMixin<base::Callback<void ,1,1> >::Run(filesystem::mojom::FileError,__int64)
> 0x5fba0984	(chrome.dll -service_worker_event_dispatcher.mojom.cc:225 )	content::mojom::ServiceWorkerEventDispatcher_DispatchPushEvent_ForwardToCallback::Accept(mojo::Message *)
> 0x6037605b	(chrome.dll -interface_endpoint_client.cc:336 )	mojo::InterfaceEndpointClient::HandleValidatedMessage(mojo::Message *)
>
> Original issue's description:
> > [ServiceWorker] Mojofy PushEvent of Service Worker.
> >
> > This CL converts push event IPCs into mojo interface:
> >   ServiceWorkerMsg_PushEvent
> >   ServiceWorkerHostMsg_PushEventFinished
> >
> > BUG=629701
> > TEST=content_unittests
> >
> > Committed: https://crrev.com/35842853527f50a04662a6dfe2c3cd1b10cf5915
> > Cr-Commit-Position: refs/heads/master@{#439739}
>
> TBR=leon.han@intel.com,peter@chromium.org,shimazu@chromium.org,tsepez@chromium.org,xiaofeng.zhang@intel.com
> # Not skipping CQ checks because original CL landed more than 1 days ago.
> BUG=629701
>
> Committed: https://crrev.com/024112aedb31806f7c825e3591f6be1ec7474aa9
> Cr-Commit-Position: refs/heads/master@{#440693}

TBR=leon.han@intel.com,peter@chromium.org,tsepez@chromium.org,xiaofeng.zhang@intel.com,falken@chromium.org
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=629701

Review-Url: https://codereview.chromium.org/2620333003
Cr-Commit-Position: refs/heads/master@{#443462}

Previously we only tested FFTs up to size 2048, but the AnalyserNode
supports up to 32768.  Test all sizes.

BUG=676722
TEST=realtimeanalyser-fft-scaling.html

Review-Url: https://codereview.chromium.org/2629543005
Cr-Commit-Position: refs/heads/master@{#443461}

BUG=303429
TEST=Manual. Check that no black area appears when the virtual
     keyboard moves between displays.

Review-Url: https://codereview.chromium.org/2627963004
Cr-Commit-Position: refs/heads/master@{#443460}

Make APIRequestHandlerUnittest derive APIBindingTest, clean up a few of
the instantions, and remove some unneeded includes.

BUG=653596

Review-Url: https://codereview.chromium.org/2625363003
Cr-Commit-Position: refs/heads/master@{#443459}

This layouttest turns off the WebKitSupportsMultipleWindows property which means that popups
open in the same window. It then initiates a navigation to a data URL by clicking on the
corresponding href. It then compares the window counts and expects the window counts to
remain unchanged.

Without PlzNavigate the data URL navigation creates a provisional loader in blink which
is then cancelled when data is written to the main document, via Document::writeln.

With PlzNavigate the top level navigation for the data URL is sent to the browser. The
provisional loader is created when the navigation is committed via the
FrameMsg_CommitNavigation IPC. This is too late and hence the data written to the page
via the Document::writeln calls never shows up.

Fix is to add a check for whether there is a client side navigation in process for PlzNavigate
and if yes stop ongoing loaders.

BUG=673744, 673742

Review-Url: https://codereview.chromium.org/2628153002
Cr-Commit-Position: refs/heads/master@{#443458}

Move MediaControls hideMediaControlsTimer and panelWidthChangedTimer to
TaskRunnerTimer, which associates it with the documents's timer task
queue.

BUG=624694

Review-Url: https://codereview.chromium.org/2627803002
Cr-Commit-Position: refs/heads/master@{#443457}

Update pref service before showing the interstitial only if it is available. Also
remove an unused method.

BUG=

Review-Url: https://codereview.chromium.org/2627343003
Cr-Commit-Position: refs/heads/master@{#443456}

This adds a new cr-element, 'cr-drawer', which implements a sidebar
drawer. Moving the drawer to cr_elements allows it to be used by History,
removing the need for the app-drawer element.

BUG=629808
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2628123002
Cr-Commit-Position: refs/heads/master@{#443455}

Geolocation access via the geo API and via the X-Geo header has been
made consistent. As part of this project the UI is being updated to show
the geolocation status for the default search engine in more places.

This change updates the page info popup to show allow / block for the
default search engine.

BUG=674398

Review-Url: https://codereview.chromium.org/2633433002
Cr-Commit-Position: refs/heads/master@{#443454}

This patch undoes some of the previous work to add separate x/y
raster scales since we decided that it was too complicated to use, and
decided to go in a different direction.

R=enne@chromium.org
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2629233002
Cr-Commit-Position: refs/heads/master@{#443453}

As discussed on platform-architecture-dev [0], there is interest in
normalizing the methods of WTF classes to better align with std classes.
This CL changes the template file that is used to generate
XPathGrammar.cpp.

There are no functional changes.

[0] https://groups.google.com/a/chromium.org/d/topic/platform-architecture-dev/I7jnz4p1h84/discussion

BUG=662431

Review-Url: https://codereview.chromium.org/2627023004
Cr-Commit-Position: refs/heads/master@{#443452}

BUG=680099

Review-Url: https://codereview.chromium.org/2625013003
Cr-Commit-Position: refs/heads/master@{#443451}

In theory this will reduce memory wasted by std::deque. It may also help diagnose
some puzzling crashes we've seen related to the immediate incomming and work queues.

BUG=674625, 674895
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2579773002
Cr-Commit-Position: refs/heads/master@{#443450}

BUG=680797
TEST=Win Intel HD 530 bot on GPU FYI waterfall
TBR=kbr@chromium.org,yunchao.he@intel.com
NOTRY=true
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2628883007
Cr-Commit-Position: refs/heads/master@{#443449}

The new search geolocation system slightly changes the way geolocation
permission work. This change updates the search engines UI to work with
the new system.

BUG=674398

Review-Url: https://codereview.chromium.org/2629523003
Cr-Commit-Position: refs/heads/master@{#443448}

BUG=661011

Review-Url: https://codereview.chromium.org/2626073006
Cr-Commit-Position: refs/heads/master@{#443447}

Objects implementing the DOMQuad interface represents a quadrilateral.
first, constructor was added in this CL.
and i will add other functions in follow up CL.

spec list:
https://drafts.fxtf.org/geometry/#domquad
https://drafts.fxtf.org/geometry/#dictdef-domquadinit

BUG=678237

Review-Url: https://codereview.chromium.org/2615653003
Cr-Commit-Position: refs/heads/master@{#443446}

fixed encodedBodySize/decodedBodySize/initiatorType for nav timing 2. Report initiatorType as "navigation" instead of an empty string.

BUG=675044,675042

Review-Url: https://codereview.chromium.org/2582863002
Cr-Commit-Position: refs/heads/master@{#443445}

Move the marking mode to VisitorHelper<>, so that
both Visitor and InlinedGlobalMarkingVisitor can access
and reuse it.

In order to do so, hoist out Visitor::MarkingMode as an
enum class.

R=
BUG=

Review-Url: https://codereview.chromium.org/2625363002
Cr-Commit-Position: refs/heads/master@{#443444}

The aim is to delete this code path entirely and the test hasn't been
run for years. Fixing it is not a priority.

BUG=324555
TBR=zmo@chromium.org

Review-Url: https://codereview.chromium.org/2633473003
Cr-Commit-Position: refs/heads/master@{#443443}

It seems Linux and Windows don't have correct expectation files now.

BUG=654999
TBR=keishi@chromiuj.org
NOTRY=true

Review-Url: https://codereview.chromium.org/2630663002
Cr-Commit-Position: refs/heads/master@{#443442}

BUG=678077

Review-Url: https://codereview.chromium.org/2624333004
Cr-Commit-Position: refs/heads/master@{#443441}

The crash key was accidentally left unset when bad message dumps
were moved to the IO thread. This fixes that.

BUG=680542
R=creis@chromium.org

Review-Url: https://codereview.chromium.org/2629773002
Cr-Commit-Position: refs/heads/master@{#443440}

We currently prompt the user to re-enable a disabled hosted app if they
visit the corresponding site. However, this can be really annoying, and
confusing, since we don't offer much context on the choice, and don't
persist the preference.

This is offering relatively little value, and the site (if it wanted)
could detect and inform the user that the app wasn't enabled, and give
them sufficiently more context.

However, we should keep this when the user visits a chrome-extension
url - this is a much stronger signal, and we can't display anything else
anyway (whereas visiting a hosted app's site still shows the site).

This was never tested, so add some tests.

BUG=678631

Review-Url: https://codereview.chromium.org/2621953003
Cr-Commit-Position: refs/heads/master@{#443439}

This was timing out with the Mac renderer backgrounding experiment on
since it was taking too long for the backgrounded tab to wake up and
execute the necessary commands.

BUG=460102

Review-Url: https://codereview.chromium.org/2626293002
Cr-Commit-Position: refs/heads/master@{#443438}

BUG=668389

Review-Url: https://codereview.chromium.org/2628043003
Cr-Commit-Position: refs/heads/master@{#443437}

Rename
mapRectToDestinationSpace to sourceToDestinationRect
mapToVisualRectInDestinationSpace to sourceToDestinationVisualRect
localToVisualRectInAncestorSpace to localToAncestorVisualRect
so that all mapping methods are in the form
  (local|source|ancestor)To(local|source|ancestor)(Rect|VisualRect|Matrix|ClipRect)

Changed parameters to localToAncestorMatrix and getPrecomputedDataForAncestor()
from const PropertyTreeState& to const TransformPaintPropertyNode*
because some later changes will require the new form (
TransformationPaintPropertyNode without a state).

Simplified localToAncestorMatrix and localToAncestorClipRect because
we have early returns when the local node is the same as the ancestor
node and we no longer need to handle that condition in the loop.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2623823002
Cr-Commit-Position: refs/heads/master@{#443436}

This CL ensures chunk size is aligned with the FencedAllocator allocation size.

BUG=680150
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel

Review-Url: https://codereview.chromium.org/2623223002
Cr-Commit-Position: refs/heads/master@{#443435}

We fixed a bug that after changing the primary display, the desktop share
picker will mismatch the screen preview with screen name.

In this CL we fixed the bug.

BUG=680335

Review-Url: https://codereview.chromium.org/2627933003
Cr-Commit-Position: refs/heads/master@{#443434}

The purpose of this CL is to make it easier to edit results.html by
making it clearer which unit tests are failing.

This may make it slightly easier to work on http://crbug.com/664274.

Review-Url: https://codereview.chromium.org/2605103004
Cr-Commit-Position: refs/heads/master@{#443433}

BUG=680343

Review-Url: https://codereview.chromium.org/2625903006
Cr-Commit-Position: refs/heads/master@{#443432}

BUG=670422

Review-Url: https://codereview.chromium.org/2619653002
Cr-Commit-Position: refs/heads/master@{#443431}

R=tommycli@chromium.org
BUG=673953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2629743002
Cr-Commit-Position: refs/heads/master@{#443430}

Showing the menu, resizing the browser window horizontally and then
showing the menu a second time could result in incorrectly positioning
the window, as position values from the first instance would affect
layout of the second instance. This fixes the issue by clearing position
alues before reshowing the menu.

BUG=667198
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2614663011
Cr-Commit-Position: refs/heads/master@{#443429}

Tests Logging In with correct/incorrect credentials and cancelling
authentication.

Also added cancelButton to chrome_matchers.

BUG=577395

Review-Url: https://codereview.chromium.org/2617393003
Cr-Commit-Position: refs/heads/master@{#443428}

A part of Project Ribbon, separating the parsing logic for CSS
properties from the parser into an API. This patch removes
CSSPropertyScrollSnapCoordinate from the switch statement in
parseSingleValue, and calls the API instead.

A function pointer to the parseSingleValue function from the API for the
page property is stored in a CSSPropertyDescriptor, and is called from
CSSPropertyParser.

This patch:
- Adds CSSPropertyAPIScrollSnapCoordinate.cpp to the BUILD.gn file.
- Adds api_class flag to CSSProperties.in, which indicates that
  CSSPropertyAPIScrollSnapCoordinate.h is generated.
- Moves the parsing logic for page from CSSPropertyParser.cpp to
  CSSPropertyAPIScrollSnapCoordinate.cpp, which implements
  CSSPropertyAPI.h.

BUG=668012

Review-Url: https://codereview.chromium.org/2616833002
Cr-Commit-Position: refs/heads/master@{#443427}