Commits · 191b2048b841cc9bb7e46ff540825caccd5b9fd9 · eriksson monteiro / tangled

08 Feb, 2010 24 commits

2010-02-08 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk> · 191b2048

kov@webkit.org authored Feb 08, 2010

        Reviewed by Xan Lopez.

        Bump version to 1.1.21, and adjust library versioning accordingly.

        * configure.ac:

git-svn-id: svn://svn.chromium.org/blink/trunk@54498 bbb929c8-8fbe-4397-9dbb-9b2b20218538

191b2048

Build fix, add needed export · f822238b

bweinstein@apple.com authored Feb 08, 2010

git-svn-id: svn://svn.chromium.org/blink/trunk@54497 bbb929c8-8fbe-4397-9dbb-9b2b20218538

f822238b

[Qt] Set stdout/stderr to binary mode for DRT on Windows · 90614c1e

vestbo@webkit.org authored Feb 08, 2010

Reviewed by Kenneth Rohde Christiansen.

This makes sure we don't end up with lots of CRLFs in the
DRT output, which breaks tons of results. Matches what
the Windows DRT does.

* DumpRenderTree/qt/main.cpp:

git-svn-id: svn://svn.chromium.org/blink/trunk@54496 bbb929c8-8fbe-4397-9dbb-9b2b20218538

90614c1e

2010-02-08 Kwang Yul Seo <skyul@company100.net> · 5225949d

eric@webkit.org authored Feb 08, 2010

        Reviewed by Darin Adler.

        Use fastStrDup instead of strdup
        https://bugs.webkit.org/show_bug.cgi?id=33943

        Replace strdup/free with fastStrDup/fastFree.

        * bridge/IdentifierRep.h:
        (WebCore::IdentifierRep::IdentifierRep):
        * bridge/jni/JNIBridge.cpp:
        (JavaMethod::~JavaMethod):
        (appendClassName):
        (JavaMethod::signature):
        * bridge/jni/jsc/JavaClassJSC.cpp:
        (JavaClass::JavaClass):
        (JavaClass::~JavaClass):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandleInternal::~ResourceHandleInternal):
        * platform/network/curl/ResourceHandleManager.cpp:
        (WebCore::ResourceHandleManager::~ResourceHandleManager):
        (WebCore::ResourceHandleManager::setCookieJarFileName):
        (WebCore::ResourceHandleManager::initializeHandle):
        * plugins/PluginStream.cpp:
        (WebCore::PluginStream::~PluginStream):
        (WebCore::PluginStream::startStream):
        * xml/XSLTProcessorLibxslt.cpp:
        (WebCore::xsltParamArrayFromParameterMap):
        (WebCore::freeXsltParamArray):

git-svn-id: svn://svn.chromium.org/blink/trunk@54495 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5225949d

Include header position in World Transform used for plugin positioning. · aa6f1336

bfulgham@webkit.org authored Feb 08, 2010

https://bugs.webkit.org/show_bug.cgi?id=34709

Reviewed by Adam Roben.

* WebFrame.cpp:
(WebFrame::spoolPage): Correct WinCairo plugin print positioning to
  account for header size.  Existing code ignored this, causing
  plugins to overlay other elements.



git-svn-id: svn://svn.chromium.org/blink/trunk@54494 bbb929c8-8fbe-4397-9dbb-9b2b20218538

aa6f1336

Build fix for Qt on Windows. · 4f779999

vestbo@webkit.org authored Feb 08, 2010

Reviewed by Kenneth Rohde Christiansen.

Don't use noreturn directly since it's a gcc attribute.
Instead use the NO_RETURN macro from AlwaysInline.h

* QtLauncher/QtLauncher.pro:
* QtLauncher/utils.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54493 bbb929c8-8fbe-4397-9dbb-9b2b20218538

4f779999

2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com> · 91cc9650

zimmermann@webkit.org authored Feb 08, 2010

        Not reviewed. Fix last problematic SVG testcase, update coords-trans-01-b.svg win results, marking the end of the baseline regeneration for all platforms.

        * platform/win/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@54492 bbb929c8-8fbe-4397-9dbb-9b2b20218538

91cc9650

2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com> · 2cc908d4

zimmermann@webkit.org authored Feb 08, 2010

        Not reviewed. Should turn Qt slave green again, all platform specific results updated.

        * platform/qt/svg/filters/subRegion-one-effect-expected.txt:
        * platform/qt/svg/filters/subRegion-two-effects-expected.txt:
        * platform/qt/svg/text/selection-background-color-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@54491 bbb929c8-8fbe-4397-9dbb-9b2b20218538

2cc908d4

Fix Qt build on Windows. · c031b2c0

vestbo@webkit.org authored Feb 08, 2010

Reviewed by Simon Hausmann.

nmake fails to pick the right cpp file, so we have to
rename the file to to a unique name.

* WebCore.pro:
* platform/graphics/qt/FontCustomPlatformDataQt.cpp: Renamed from WebCore/platform/graphics/qt/FontCustomPlatformData.cpp.

git-svn-id: svn://svn.chromium.org/blink/trunk@54490 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c031b2c0

2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com> · 431ce9fb

zimmermann@webkit.org authored Feb 08, 2010

        Not reviewed. Hopefully the last set of updates for Gtk/Qt/Win/Mac.

        * platform/gtk/svg/custom/text-zoom-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/animate-elem-82-t-expected.txt:
        * platform/mac/svg/W3C-SVG-1.1/coords-trans-01-b-expected.txt:
        * platform/qt/svg/filters/feComposite-expected.txt:
        * platform/qt/svg/filters/feGaussianBlur-expected.txt:
        * platform/qt/svg/filters/feMerge-expected.txt:
        * platform/qt/svg/filters/feMerge-wrong-input-expected.txt:
        * platform/qt/svg/filters/feOffset-expected.txt:
        * platform/qt/svg/filters/feTile-expected.txt:
        * platform/qt/svg/filters/filter-source-position-expected.txt:
        * platform/qt/svg/filters/shadow-on-filter-expected.txt:
        * platform/qt/svg/filters/shadow-on-rect-with-filter-expected.txt:
        * platform/qt/svg/filters/sourceAlpha-expected.txt:
        * platform/qt/svg/filters/subRegion-in-userSpace-expected.txt:
        * platform/win/svg/custom/inline-svg-in-xhtml-expected.txt:
        * platform/win/svg/hixie/mixed/003-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@54489 bbb929c8-8fbe-4397-9dbb-9b2b20218538

431ce9fb

Notify user that run-webkit-tests has to be run under Cygwin · f02b8ba7

vestbo@webkit.org authored Feb 08, 2010

Reviewed by Simon Hausmann.

The script will bail out if run under Windows shell or Msys.

* Scripts/run-webkit-tests:
* Scripts/webkitdirs.pm:

git-svn-id: svn://svn.chromium.org/blink/trunk@54488 bbb929c8-8fbe-4397-9dbb-9b2b20218538

f02b8ba7

2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com> · dbc7551b

zimmermann@webkit.org authored Feb 08, 2010

        Not reviewed. Attempt to fix all mac/win bots (expect for leopard which already passes)

        * platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
        * platform/mac/svg/custom/junk-data-expected.txt:
        * platform/mac/svg/custom/missing-xlink-expected.txt:
        * platform/mac/svg/hixie/error/012-expected.txt:
        * platform/mac/svg/text/text-intro-05-t-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@54487 bbb929c8-8fbe-4397-9dbb-9b2b20218538

dbc7551b

2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com> · 1bbabb61

zimmermann@webkit.org authored Feb 08, 2010

        Not reviewed. Next set of Qt DRT result updates.

        * platform/qt/svg/custom/js-update-image-and-display-expected.txt:
        * platform/qt/svg/custom/js-update-image-and-display3-expected.txt:
        * platform/qt/svg/custom/marker-opacity-expected.txt:
        * platform/qt/svg/custom/marker-referencePoint-expected.txt:
        * platform/qt/svg/custom/marker-strokeWidth-changes-expected.txt:
        * platform/qt/svg/custom/mask-with-default-value-expected.txt:
        * platform/qt/svg/custom/relative-sized-deep-shadow-tree-content-expected.txt:
        * platform/qt/svg/custom/relative-sized-shadow-tree-content-expected.txt:
        * platform/qt/svg/custom/relative-sized-use-on-symbol-expected.txt:
        * platform/qt/svg/custom/text-xy-updates-SVGList-expected.txt:
        * platform/qt/svg/custom/transformedMaskFails-expected.txt:
        * platform/qt/svg/custom/use-on-symbol-inside-pattern-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@54486 bbb929c8-8fbe-4397-9dbb-9b2b20218538

1bbabb61

2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com> · 99f4e7a5

zimmermann@webkit.org authored Feb 08, 2010

        Not reviewed. Update mac-tiger specific SVG results.

        * platform/mac-tiger/svg/W3C-SVG-1.1/metadata-example-01-b-expected.txt:
        * platform/mac-tiger/svg/hixie/text/003-expected.txt:
        * platform/mac-tiger/svg/hixie/text/003a-expected.txt:
        * platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt:
        * platform/mac-tiger/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@54485 bbb929c8-8fbe-4397-9dbb-9b2b20218538

99f4e7a5

2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com> · 97ec866b

zimmermann@webkit.org authored Feb 08, 2010

        Not reviewed. Fixing first set of platform specific SVG results for the Qt port.
        Unfortunately the bots exit after 20 test failures, so I can't fix the whole set of expected txt files in one go :(

        * platform/qt/svg/css/arrow-with-shadow-expected.txt:
        * platform/qt/svg/css/circle-in-mask-with-shadow-expected.txt:
        * platform/qt/svg/css/clippath-with-shadow-expected.txt:
        * platform/qt/svg/css/mask-with-shadow-expected.txt:
        * platform/qt/svg/css/path-with-shadow-expected.txt:
        * platform/qt/svg/css/shadow-and-opacity-expected.txt: Added.
        * platform/qt/svg/css/shadow-with-large-radius-expected.txt: Added.
        * platform/qt/svg/css/shadow-with-negative-offset-expected.txt: Added.
        * platform/qt/svg/css/stars-with-shadow-expected.txt:
        * platform/qt/svg/custom/createImageElement-expected.txt:
        * platform/qt/svg/custom/createImageElement2-expected.txt:
        * platform/qt/svg/custom/empty-mask-expected.txt:
        * platform/qt/svg/custom/js-repaint-rect-on-path-with-stroke-expected.txt: Added.
        * platform/qt/svg/custom/js-update-image-and-display2-expected.txt:


git-svn-id: svn://svn.chromium.org/blink/trunk@54484 bbb929c8-8fbe-4397-9dbb-9b2b20218538

97ec866b

2010-02-08 Nikolas Zimmermann <nzimmermann@rim.com> · 5c357a10

zimmermann@webkit.org authored Feb 08, 2010

        Reviewed by Dirk Schulze.

        All SVG *-expected.txt files contain wrong results
        https://bugs.webkit.org/show_bug.cgi?id=34703

        Finally dump meaningful information for SVG layout tests.
        Use 'absoluteClippedOverflowRect' which goes through the same code paths used
        to actually calculate repaint rects etc - instead of the legacy CSS-unaware
        code path that mapped 'repaintRectInLocalCoordinates' through 'absoluteTransform'.
        Remove absoluteTransform() - a long standing TODO, finally not needed anymore.

        Despite SVGRenderTreeAsText, SVGPaintServerGradient was also using absoluteTransform().
        Rewrite the code in question, fixing svg/W3C-SVG-1.1/pserver-grad-08-b.svg alignment issues
        when scaling/panning text using gradient on stroke/fill. Affects some other gradient tests as well.

        As we're now dumping clipped overflow rects any problems with repaint rects will become
        immediate visible - it turns out we're not supporting the overflow rules on the outermost <svg>
        element properly (repaint rects and bounding boxes need to take special SVG overflow rules into account).
        Fixing that magically gives pixel-perfect clipped overflow rects for all types of shapes/text/containers.

        Note: This will break any overriden platform-specific SVG results, need to wait for build bots in order to update them.

        * rendering/RenderObject.cpp: Remove absoluteTransform() method, centralize overflow query code in SVGRenderSupport::isOverflowHidden().
        * rendering/RenderObject.h: Remove absoluteTransform() method.
        * rendering/RenderSVGHiddenContainer.h: Ditto.
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::paint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
        (WebCore::RenderSVGRoot::computeRectForRepaint): Respect SVG overflow rules here: clip repaintRect against overflow rect _before_ passing
                                                         along to RenderBox. This is the key issue behind wrong absoluteClippedOverflowRect() values.
        (WebCore::RenderSVGRoot::nodeAtPoint): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
        * rendering/RenderSVGRoot.h: Remove absoluteTransform(). Don't expose viewportSize() anymore.
        * rendering/RenderSVGText.cpp: 
        (WebCore::RenderSVGText::strokeBoundingBox): Fix default stroke width to 1. This was the only wrong place -> fixes repaint rects for stroked text.
        * rendering/RenderSVGViewportContainer.cpp: Remove absoluteTransform() method.
        (WebCore::RenderSVGViewportContainer::pointIsInsideViewportClip): Use SVGRenderSupport::isOverflowHidden() to query SVG overflow mode.
        * rendering/RenderSVGViewportContainer.h: Remove absoluteTransform() method.
        * rendering/SVGRenderSupport.cpp: Refactored overflow queries in one place, centralizing SVG specific assumptions about overflowX/Y.
        (WebCore::SVGRenderBase::isOverflowHidden):
        * rendering/SVGRenderSupport.h:
        * rendering/SVGRenderTreeAsText.cpp: Dump absoluteClippedOverflowRect() instead of absoluteTransform().mapRect(repaintRectInLocalCoordinates()).
        (WebCore::writePositionAndStyle): Affects all layout tests dumping render trees.
        * svg/graphics/SVGPaintServerGradient.cpp: Rewrite Gradient on text fill/stroke support on Cg, to avoid using absoluteTransform().
        (WebCore::absoluteTransformForRenderer):
        (WebCore::createMaskAndSwapContextForTextGradient):
        (WebCore::clipToTextMask):
        (WebCore::SVGPaintServerGradient::setup):


git-svn-id: svn://svn.chromium.org/blink/trunk@54483 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5c357a10

Suppressed check-webkit-style's underscore check in Qt's autotests. · 6ba629a1

cjerdonek@webkit.org authored Feb 08, 2010

Also made the path-specific filter check case-insensitive.

Reviewed by Shinichiro Hamaji.

https://bugs.webkit.org/show_bug.cgi?id=34574

* Scripts/webkitpy/style/checker.py:
  - Added a list element to _PATH_RULES_SPECIFIER for
    directories that should be excluded from the
    "readability/naming" category (the category that relates to
    underscores in identifiers, for example).

* Scripts/webkitpy/style/checker_unittest.py:
  - Added an "end-to-end" test for "WebKit/qt/tests/".

* Scripts/webkitpy/style/filter.py:
  - Altered FilterConfiguration's should_check() method to
    check for path substring matches case-insensitively.

* Scripts/webkitpy/style/filter_unittest.py:
  - Added a test to check case-insensitive path substring matching.

* Scripts/webkitpy/style/processors/cpp.py:
  - Removed the hard-coded "WebKit/gtk/webkit/" path reference
    since this is now taken care of by the _PATH_RULES_SPECIFIER
    configuration variable.

* Scripts/webkitpy/style/processors/cpp_unittest.py:
  - Removed the unit test for the GTK directory since this
    is now taken care of by the checker._PATH_RULES_SPECIFIER
    end-to-end tests.

git-svn-id: svn://svn.chromium.org/blink/trunk@54482 bbb929c8-8fbe-4397-9dbb-9b2b20218538

6ba629a1

Build fix for make distcheck. · 8337d392

kov@webkit.org authored Feb 08, 2010

git-svn-id: svn://svn.chromium.org/blink/trunk@54481 bbb929c8-8fbe-4397-9dbb-9b2b20218538

8337d392

2010-02-08 Xan Lopez <xlopez@igalia.com> · 34391860

xan@webkit.org authored Feb 08, 2010

        Try to do some clean-up in our Skipped list.

        * platform/gtk/Skipped:

git-svn-id: svn://svn.chromium.org/blink/trunk@54480 bbb929c8-8fbe-4397-9dbb-9b2b20218538

34391860

2010-02-08 Xan Lopez <xlopez@igalia.com> · 9292a77f

xan@webkit.org authored Feb 08, 2010

        Reviewed by Gustavo Noronha.

        Generate new results for this test.

        * platform/gtk/editing/execCommand/indent-paragraphs-expected.txt:

git-svn-id: svn://svn.chromium.org/blink/trunk@54479 bbb929c8-8fbe-4397-9dbb-9b2b20218538

9292a77f

2010-02-08 Tony Chang <tony@chromium.org> · 5dbaadd0

eric@webkit.org authored Feb 08, 2010

        Reviewed by Darin Adler.

        Convert editing/execCommand/indent-paragraphs.html to use dumpAsText.
        The test copies HTML to the text output, so it doesn't really need
        to dump the render tree.

        The test was added in r49985, but didn't include pixel results.
        https://bugs.webkit.org/show_bug.cgi?id=34625

        * platform/mac/editing/execCommand/indent-paragraphs-expected.txt: Modified.

git-svn-id: svn://svn.chromium.org/blink/trunk@54478 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5dbaadd0

2010-02-08 Leith Bade <leith@leithalweapon.geek.nz> · 250ab0e0

eric@webkit.org authored Feb 08, 2010

        Reviewed by Darin Adler.

        Fixes: https://bugs.webkit.org/show_bug.cgi?id=34637
        Corrects the newline inserted into WebKitOutputDir, and WebKitLibrariesDir Windows
        environemnt variables when there is a space in the user's /home path.

        * Scripts/webkitdirs.pm:
         - Added missing quotes around $sourceDir in argument list of cygpath in determineWindowsSourceDir().

git-svn-id: svn://svn.chromium.org/blink/trunk@54477 bbb929c8-8fbe-4397-9dbb-9b2b20218538

250ab0e0

Unreviewed RVCT build fix. · 64e724b6

hausmann@webkit.org authored Feb 08, 2010

Similar to r54391, don't import the cmath functions from std:: for RVCT.

* wtf/MathExtras.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54476 bbb929c8-8fbe-4397-9dbb-9b2b20218538

64e724b6

2010-02-07 Tony Chang <tony@chromium.org> · 0c79dbfd

tony@chromium.org authored Feb 08, 2010

        Reviewed by Darin Adler.

        Fix 2 pixel test baselines that are incorrect but passing
        the fuzzy image diff.

        editing/deleting/5390681.html should show a cursor, but doesn't.
        In r42549, whitespace collapsing was changed but
        editing/pasteboard/5387578.html's result wasn't updated to
        reflect the collapsed whitespace.
        https://bugs.webkit.org/show_bug.cgi?id=34632

        * platform/mac/editing/deleting/5390681-2-expected.checksum:
        * platform/mac/editing/deleting/5390681-2-expected.png:
        * platform/mac/editing/pasteboard/5387578-expected.checksum:
        * platform/mac/editing/pasteboard/5387578-expected.png:

git-svn-id: svn://svn.chromium.org/blink/trunk@54475 bbb929c8-8fbe-4397-9dbb-9b2b20218538

0c79dbfd

07 Feb, 2010 7 commits

2010-02-07 Daniel Bates <dbates@webkit.org> · 31123220

dbates@webkit.org authored Feb 07, 2010

        Unreviewed, fix Tiger layout test failure.

        https://bugs.webkit.org/show_bug.cgi?id=34402

        Adds expected layout test results for Tiger build.

        * platform/mac-tiger/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@54474 bbb929c8-8fbe-4397-9dbb-9b2b20218538

31123220

2010-02-07 Daniel Bates <dbates@webkit.org> · dfe18349

dbates@webkit.org authored Feb 07, 2010

        Unreviewed, fix layout test bots.

        https://bugs.webkit.org/show_bug.cgi?id=34402

        Adds expected layout test results for Leopard, Windows, and Qt ports.

        * platform/mac-leopard/fast/lists: Added.
        * platform/mac-leopard/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
        * platform/qt/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.
        * platform/win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@54473 bbb929c8-8fbe-4397-9dbb-9b2b20218538

dfe18349

2010-02-07 Daniel Bates <dbates@webkit.org> · 0189a49e

dbates@webkit.org authored Feb 07, 2010

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=34402

        Implements all of the numeric CSS3 list-style-types as per
        section 4.3 of the CSS3 Lists module <http://www.w3.org/TR/css3-lists/#numeric>.

        Test: fast/lists/w3-css3-list-styles-numeric.html

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        * css/CSSValueKeywords.in:
        * inspector/front-end/SourceCSSTokenizer.re2js:
        * platform/text/CharacterNames.h: Added constant hyphenMinus.
        * rendering/RenderListMarker.cpp:
        (WebCore::): Defined enum SequenceType.
        (WebCore::toAlphabeticOrNumeric): Added.
        (WebCore::toAlphabetic): Modified to call WebCore::toAlphabeticOrNumeric.
        (WebCore::toNumeric): Added.
        (WebCore::listMarkerSuffix):
        (WebCore::listMarkerText):
        (WebCore::RenderListMarker::paint):
        (WebCore::RenderListMarker::calcPrefWidths):
        (WebCore::RenderListMarker::getRelativeMarkerRect):
        * rendering/style/RenderStyle.h:
        (WebCore::):
        * rendering/style/RenderStyleConstants.h: Added numeric list style types
        and fixed indent level for the enum values.
        (WebCore::):
2010-02-07  Daniel Bates  <dbates@webkit.org>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=34402

        Tests that all of the numeric CSS3 list-style-types are supported.

        * fast/lists/w3-css3-list-styles-numeric.html: Added.
        * platform/mac/fast/lists/w3-css3-list-styles-numeric-expected.txt: Added.


git-svn-id: svn://svn.chromium.org/blink/trunk@54472 bbb929c8-8fbe-4397-9dbb-9b2b20218538

0189a49e

2010-02-07 Ismail Donmez <ismail@namtrac.org> · c98bcc40

eric@webkit.org authored Feb 07, 2010

        Reviewed by Darin Adler.

        Include wtf/StringExtras.h for strdup definition, which
        is needed for WinCE.

        * bridge/IdentifierRep.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54471 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c98bcc40

2010-02-07 Pavel Feldman <pfeldman@chromium.org> · fba2e748

eric@webkit.org authored Feb 07, 2010

        Reviewed by Timothy Hatcher.

        Web Inspector: Fragment-held Elements Not Shown in Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=34680

        * inspector/console-dirxml-expected.txt:
        * inspector/console-dirxml.html:
2010-02-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Fragment-held Elements Not Shown in Inspector.

        https://bugs.webkit.org/show_bug.cgi?id=34680

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::pushChildNodesToFrontend):
        (WebCore::InspectorDOMAgent::buildObjectForNode):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._nodeTitleInfo):

git-svn-id: svn://svn.chromium.org/blink/trunk@54470 bbb929c8-8fbe-4397-9dbb-9b2b20218538

fba2e748

2010-02-07 Jian Li <jianli@chromium.org> · 9af533cc

eric@webkit.org authored Feb 07, 2010

        Reviewed by Darin Fisher.

        [chromium] Change chromium interface to handle DownloadURL format.
        https://bugs.webkit.org/show_bug.cgi?id=34655

        * platform/chromium/ChromiumDataObject.cpp:
        (WebCore::ChromiumDataObject::clear):
        (WebCore::ChromiumDataObject::hasData):
        (WebCore::ChromiumDataObject::ChromiumDataObject):
        * platform/chromium/ChromiumDataObject.h:
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::setData):
2010-02-07  Jian Li  <jianli@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Change chromium interface to handle DownloadURL format.
        https://bugs.webkit.org/show_bug.cgi?id=34655

        * public/WebDragData.h:
        * src/WebDragData.cpp:
        (WebKit::WebDragData::downloadMetadata):
        (WebKit::WebDragData::setDownloadMetadata):

git-svn-id: svn://svn.chromium.org/blink/trunk@54469 bbb929c8-8fbe-4397-9dbb-9b2b20218538

9af533cc

Rubber-stamped by Kenneth Rohde Christiansen. · c2ceb33e

ossy@webkit.org authored Feb 07, 2010

[Qt] Missing fast/frames/flattening/resources/frameset-flattening-subframe-resize.html
https://bugs.webkit.org/show_bug.cgi?id=34662

Missing file added from the original bug: https://bugs.webkit.org/show_bug.cgi?id=32717

* fast/frames/flattening/resources: Added.
* fast/frames/flattening/resources/frameset-flattening-subframe-resize.html: Added.
* platform/qt/Skipped: frameset-flattening-subframe-resize.html unskipped.



git-svn-id: svn://svn.chromium.org/blink/trunk@54468 bbb929c8-8fbe-4397-9dbb-9b2b20218538

c2ceb33e

06 Feb, 2010 9 commits

2010-02-06 Dimitri Glazkov <dglazkov@chromium.org> · 88d01648

dglazkov@chromium.org authored Feb 06, 2010

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * accessibility/chromium/AXObjectCacheChromium.cpp:
        (WebCore::AXObjectCache::postPlatformNotification):
        * page/chromium/ChromeClientChromium.h:
2010-02-06  Dimitri Glazkov  <dglazkov@chromium.org>

        No review, rolling out r54364.
        http://trac.webkit.org/changeset/54364
        https://bugs.webkit.org/show_bug.cgi?id=34464

        Introduced asserts in layout tests, needs more testing
        locally.

        * public/WebViewClient.h:
        * src/ChromeClientImpl.cpp:
        * src/ChromeClientImpl.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54466 bbb929c8-8fbe-4397-9dbb-9b2b20218538

88d01648

2010-02-06 Dimitri Glazkov <dglazkov@chromium.org> · 204f7105

dglazkov@chromium.org authored Feb 06, 2010

        Reviewed by Adam Barth.

        Using inlines and function-level statics don't mix, according to gcc.
        https://bugs.webkit.org/show_bug.cgi?id=34663

        De-inline deviceRGBColorSpaceRef to avoid gcc-bug landmines.

        It appears that the initialization check, generated by gcc doesn't account
        for a possibility that the function may be inlined, resulting in lazy
        initialization failure for more than one inlined instance of the function.

        No behavior change, so no new tests.

        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::deviceRGBColorSpaceRef):
        * platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54465 bbb929c8-8fbe-4397-9dbb-9b2b20218538

204f7105

Change UStringImpl::create to CRASH if the string cannot be allocated, · 44fb4f7d

barraclough@apple.com authored Feb 06, 2010

rather than returning a null string (which will behave like a zero-length
string if used).

Reviewed by Geoff Garen.

Also move createRep function from UString to become new overloaded
UStringImpl::create methods.  In doing so, bring their behaviour closer to
being in line with WebCore::StringImpl, in removing the behaviour that they
can be used to produce null UStrings (ASSERT the char* provided is non-null).
This behaviour of converting null C-strings to null UStrings is inefficient
(cmompared to just using UString::null()), incompatible with WebCore::StringImpl's
behaviour, and may generate unexpected behaviour, since in many cases a null
UString can be used like an empty string.

With these changes UStringImpl need not have a concept of null impls, we can
start transitioning this to become an implementation detail of UString, that
internally it chooses to use a null-object rather than an actually zero impl
pointer.

* JavaScriptCore.exp:
* debugger/Debugger.cpp:
(JSC::Debugger::recompileAllJSFunctions):
* debugger/DebuggerCallFrame.cpp:
(JSC::DebuggerCallFrame::calculatedFunctionName):
* parser/Parser.cpp:
(JSC::Parser::parse):
* profiler/Profile.cpp:
(JSC::Profile::Profile):
* profiler/ProfileGenerator.cpp:
(JSC::ProfileGenerator::stopProfiling):
* runtime/Error.cpp:
(JSC::Error::create):
(JSC::throwError):
* runtime/ExceptionHelpers.cpp:
(JSC::createError):
* runtime/Identifier.cpp:
(JSC::Identifier::add):
* runtime/PropertyNameArray.cpp:
(JSC::PropertyNameArray::add):
* runtime/UString.cpp:
(JSC::initializeUString):
(JSC::UString::UString):
(JSC::UString::operator=):
* runtime/UString.h:
(JSC::UString::isNull):
(JSC::UString::null):
(JSC::UString::rep):
(JSC::UString::UString):
* runtime/UStringImpl.cpp:
(JSC::UStringImpl::create):
* runtime/UStringImpl.h:



git-svn-id: svn://svn.chromium.org/blink/trunk@54464 bbb929c8-8fbe-4397-9dbb-9b2b20218538

44fb4f7d

Reviewed by Oliver Hunt. · 5f4ec56c

ap@apple.com authored Feb 06, 2010

        https://bugs.webkit.org/show_bug.cgi?id=34670
        TestNetscapePlugin should work with Firefox

        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp: (NPP_New): Default to Carbon if
        browser doesn't tell what it supports.



git-svn-id: svn://svn.chromium.org/blink/trunk@54463 bbb929c8-8fbe-4397-9dbb-9b2b20218538

5f4ec56c

2010-02-05 Shinichiro Hamaji <hamaji@chromium.org> · b2fe5017

hamaji@chromium.org authored Feb 06, 2010

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * platform/gtk/Skipped:
2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * webkit/webkitprivate.h:
        * webkit/webkitwebframe.cpp:
        (webkit_web_frame_page_number_for_element_by_id):
2010-02-05  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Gustavo Noronha Silva.

        [Gtk] Implement layoutTestController.pageNumberForElementById
        https://bugs.webkit.org/show_bug.cgi?id=34572

        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::pageNumberForElementById):

git-svn-id: svn://svn.chromium.org/blink/trunk@54461 bbb929c8-8fbe-4397-9dbb-9b2b20218538

b2fe5017

Added an ASSERT to catch an implausible but theoretically possible leak. · dd5604e7

ggaren@apple.com authored Feb 06, 2010

        
Reviewed by Dan Bernstein.

In theory, if malloc allocated a UChar buffer directly after a StringImpl,
the StringImpl might incorrecly assume that the UChar buffer was inline,
and fail to delete it.
        
This ASSERT is somewhat academic, since we don't use the same allocator
in debug builds, but oh well.

* platform/text/StringImpl.cpp:
(WebCore::StringImpl::StringImpl):
(WebCore::StringImpl::createUninitialized):
* platform/text/StringImpl.h: Separated the inline buffer StringImpl
constructor from the out-of-line buffer StringImpl constructor. Made
the former ASSERT that its buffer was indeed inline, and the latter ASSERT
that its buffer was indeed not inline.



git-svn-id: svn://svn.chromium.org/blink/trunk@54460 bbb929c8-8fbe-4397-9dbb-9b2b20218538

dd5604e7

Removed these special Windows expected results because they represented · 914d7459

ggaren@apple.com authored Feb 06, 2010

incorrect behavior, fixed by a recent patch of mine.

Reviewed by Beth Dakin.

* platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt: Removed.



git-svn-id: svn://svn.chromium.org/blink/trunk@54459 bbb929c8-8fbe-4397-9dbb-9b2b20218538

914d7459

2010-02-05 James Hawkins <jhawkins@chromium.org> · 056a8496

eric@webkit.org authored Feb 06, 2010

        Reviewed by David Levin.

        [Chromium] Rename autocomplete* to suggestions* to prepare for the
        refactoring of AutocompletePopupMenuClient.

        https://bugs.webkit.org/show_bug.cgi?id=34664

        * public/WebView.h:
        * src/AutocompletePopupMenuClient.cpp:
        (WebKit::AutocompletePopupMenuClient::popupDidHide):
        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::textFieldDidEndEditing):
        (WebKit::EditorClientImpl::doAutofill):
        * src/WebViewImpl.cpp:
        (WebKit::):
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::mouseDown):
        (WebKit::WebViewImpl::autocompleteHandleKeyEvent):
        (WebKit::WebViewImpl::setFocus):
        (WebKit::WebViewImpl::applyAutofillSuggestions):
        (WebKit::WebViewImpl::hideAutofillPopup):
        (WebKit::WebViewImpl::hideSuggestionsPopup):
        (WebKit::WebViewImpl::refreshSuggestionsPopup):
        * src/WebViewImpl.h:
        (WebKit::WebViewImpl::suggestionsPopupDidHide):

git-svn-id: svn://svn.chromium.org/blink/trunk@54458 bbb929c8-8fbe-4397-9dbb-9b2b20218538

056a8496

2010-02-05 Kwang Yul Seo <skyul@company100.net> · e20529b5

eric@webkit.org authored Feb 06, 2010

        Reviewed by Eric Seidel.

        [BREWMP] Define SYSTEM_MALLOC 1
        https://bugs.webkit.org/show_bug.cgi?id=34640

        Make BREWMP use system malloc because FastMalloc is not ported.

        * wtf/Platform.h:

git-svn-id: svn://svn.chromium.org/blink/trunk@54457 bbb929c8-8fbe-4397-9dbb-9b2b20218538

e20529b5