GitLab

Bug: None
Change-Id: Iac3de7f8dcad9692beb58ff991d1f70df8ca5eae
Reviewed-on: https://chromium-review.googlesource.com/738231
Commit-Queue: Anthony Berent <aberent@chromium.org>
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524730}

https://skia.googlesource.com/skia.git/+log/46845d1c3af5..7035a8e797eb

$ git log 46845d1c3..7035a8e79 --date=short --no-merges --format='%ad %ae %s'
2017-12-15 brianosman Fix benches that aren't really timing what we want

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=csmartdalton@chromium.org

Change-Id: I05ee66a40123082be0e5fe0e73c671d4ea772067
Reviewed-on: https://chromium-review.googlesource.com/832368Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524729}

If you patch in https://pastebin.com/k1MTXxYt, this is enough to get poster circle "running" with black tiles.

The magic set of flags to run with this stub are:
--enable-gpu-rasterization --enable-oop-rasterization --enable-gpu-async-worker-context --enable-raster-decoder

Sample LOGs from stub: https://pastebin.com/48sGk6cM

BUG=789238

Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
Change-Id: I5ce826f68acdfb7ca23a2fb7698d156bf1a7505c
Reviewed-on: https://chromium-review.googlesource.com/820150
Commit-Queue: Jonathan Backer <backer@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: Victor Miura <vmiura@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524728}

Small fix to adjust the Omnibox suggestions dropdown for the new
Harmony (kSecondaryUiMd enabled) BubbleBorder.

Bug: 783778
Change-Id: Id0b2a9e962aad098f46d53d1eedffad668639221
Reviewed-on: https://chromium-review.googlesource.com/831046Reviewed-by: Justin Donnelly <jdonnelly@chromium.org>
Commit-Queue: Tommy Li <tommycli@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524727}

When a layout is triggered when the parser is interrupted, an instance
tree can be built for a <use> that references a subtree that contains
the insertion point of the parser. This <use> instance (or instances)
would then not be invalidated when the parsing resumed.

Invalidate instances of an element when its children changes even when
the mutation originates from the parser. (This condition was added in
3c2310f2 without further explanation
"Only invalidate SVGElementInstances when !changedByParser is set.". Due
to the lazyness of the shadow tree/instance rebuilding this will
hopefully not regress performance.)

Bug: 794594
Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2
Change-Id: I58f3a74ef9812503c0111d3564dad8ee3527d27b
Reviewed-on: https://chromium-review.googlesource.com/832386Reviewed-by: Stephen Chenney <schenney@chromium.org>
Commit-Queue: Fredrik Söderquist <fs@opera.com>
Cr-Commit-Position: refs/heads/master@{#524726}

- Now all the integer ids are request ids to avoid confusion with the
string notification ids.

Bug: 595685
Change-Id: Idd8008f59bb4a3db8eadf1455c6185fc7a01b338
Reviewed-on: https://chromium-review.googlesource.com/829553
Commit-Queue: Anita Woodruff <awdf@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524725}

More tests are flaking in viz_browser_tests disabling until we triage.

TBR=kylechar@chromium.org

Bug: 794961
Change-Id: I9eba78c0017a492eaed54826e0aa75f2354ee600
Reviewed-on: https://chromium-review.googlesource.com/832667Reviewed-by: Jonathan Ross <jonross@chromium.org>
Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524724}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/c85ab812..c4318728

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I5becfb65da0c4de8d44627d0c0951e1d2d2224c8
Reviewed-on: https://chromium-review.googlesource.com/832346Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524723}

Upstream the below tests from media/track/ to wpt
1. track-webvtt-tc026-voice.html
2. track-webvtt-tc027-empty-cue.html
3. track-webvtt-tc028-unsupported-markup.html
4. track-webvtt-tc029-timings-whitespace.html
5. track-webvtt-tc030-interspersed-non-cue.html
6. track-webvtt-tc031-cue-recovery.html
7. track-webvtt-tc032-degenerate-cues.html

Bug: 782555
Change-Id: I21d68c80e7606eaf8125c1122107e4b1b79e4972
Reviewed-on: https://chromium-review.googlesource.com/832106Reviewed-by: Fredrik Söderquist <fs@opera.com>
Commit-Queue: srirama chandra sekhar <srirama.m@samsung.com>
Cr-Commit-Position: refs/heads/master@{#524722}

If a form contains multiple fields with the same name, autofill
suggestions often fills only one.
The current resolution process keeps the value of the last element with
a given name (each value overrides the previous value).
This CLs make the resolution process to favor the non-empty value.
The filling will try to fill every fields with the same name with this
value.

Bug: 728374, 732360
Change-Id: I5c5c1635c59679a9823589e914c65bb734b3b505
Reviewed-on: https://chromium-review.googlesource.com/806162Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Peter Lee <pkl@chromium.org>
Reviewed-by: Moe Ahmadi <mahmadi@chromium.org>
Commit-Queue: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524721}

This is timing out for me when I use run_chrome_public_test_apk with a filter,
on a nexus 5 device.

There may be a better place to put the timeout, any suggestions welcome :)

Change-Id: Iac12a7843bfa299471ba7b2522de367a82793b5d
Reviewed-on: https://chromium-review.googlesource.com/805136Reviewed-by: Yoland Yan <yolandyan@chromium.org>
Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: Matthew Cary <mattcary@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524720}

A crash has been reported where apparently it is possible for
a state update to arrive for a stream after the stream has been
removed.

This CL makes AudioStreamMonitor handle this case instead of DCHECKing.

Bug: 795501
Change-Id: Id43c3c4a846af5d8e7d1d387d36ed31e45724ad8
Reviewed-on: https://chromium-review.googlesource.com/832186Reviewed-by: Olga Sharonova <olka@chromium.org>
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524719}

This commit adds plane in-fence support for KMS atomic modesetting. The
in-fence fds are supplied as part of the overlay plane information.

If the used drm device supports atomic modesetting, then any supplied
fence fds are used as plane properties when committing the planes. If
atomic modesetting is not supported, the implementation asynchronously
waits for the fence fds to become ready before executing the page flip.

Bug: 653908
Test: ozone_demo, ozone_unittests
Change-Id: I438b4c9eb97538cb36fdda2fb002f7359f194c0b
Reviewed-on: https://chromium-review.googlesource.com/814294
Commit-Queue: David Reveman <reveman@chromium.org>
Reviewed-by: Daniele Castagna <dcastagna@chromium.org>
Reviewed-by: David Reveman <reveman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524718}

The FrameEvictionManager expects a response from
DelegatedFrameHost::EvictDelegatedFrame() otherwise it will DCHECK and
crash. Implement the correct logic in DelegatedFrameHost. There is no
CompositorFrameSinkSupport to clear, but we clear the SurfaceLayer which
will drop the surface reference to the evicted frame.

Bug: 777881
Change-Id: Id6725d6cdb141c668b8217419535863ecf586a17
Reviewed-on: https://chromium-review.googlesource.com/829618
Commit-Queue: kylechar <kylechar@chromium.org>
Reviewed-by: Fady Samuel <fsamuel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524717}

WPT Import Notification is finally around the corner! And we should of
course fishfood it.

R=foolip

Change-Id: Id05734a4c348b4444c63c4d06aed062d8b60e076
Reviewed-on: https://chromium-review.googlesource.com/830788Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Robert Ma <robertma@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524716}

This CL updates the pageset for leak detection benchmark and update the wpr as well.

Bug: 763280
Change-Id: Ic8d873ecb94c060c10589aa5ce535808e90620ea
Reviewed-on: https://chromium-review.googlesource.com/828422Reviewed-by: Keishi Hattori <keishi@chromium.org>
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524715}

We’ve recently shipped some new regular expression features in V8.
This patch extends the fuzzer dictionary with the new syntax for:

- positive lookbehind assertions
- negative lookbehind assertions
- named capture groups
- Unicode property escapes

More information on these features can be found here:

- https://mathiasbynens.be/notes/es-regexp-proposals
- https://developers.google.com/web/updates/2017/07/upcoming-regexp-features

BUG=v8:7225

Change-Id: Ia506ba2282932fce43b02f1eccf327c8cd869101
Reviewed-on: https://chromium-review.googlesource.com/832526
Commit-Queue: Mathias Bynens <mathias@chromium.org>
Reviewed-by: Abhishek Arya <inferno@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524714}

To support synchronous compositor for Android webview over mojo add
a struct trait for ScrollOffset

BUG=722928
TBR=vollick@chromium.org

Change-Id: I4138ac3ff93fc17e6a123335ac3a82975df48db4
Reviewed-on: https://chromium-review.googlesource.com/830115
Commit-Queue: Dave Tapuska <dtapuska@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524713}

Autofill calls libphonenumber.IsValidNumber for number validation. This method
validates carrier code(among other things) and it's a bit too strict for autofill's
usage.

For example, it would reject 6501231234 as a valida US number because the first
number after area code cannot be 1.

This CL switches to use IsPossibleNumber instead, so autofill will take above number
and parse it as if it is a valid number.

Benefits:
1. metadata of libphonenumber might not be the latest due to chrome's
release cycle, therefore IsValidaNumber might reject valid numbers, while
IsPossibleNumber will not.

2. Might allow libphonenumber to use a lite metadata to save a little of binary
size.

Bug: 792471
Change-Id: I25d3b21b81010b92a69b16f91f7d072e86ac7839
Reviewed-on: https://chromium-review.googlesource.com/827163Reviewed-by: Roger McFarlane <rogerm@chromium.org>
Reviewed-by: Sebastien Seguin-Gagnon <sebsg@chromium.org>
Commit-Queue: Hui Wu <wuandy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524712}

There are two namespaces named testing, there is ::testing
and there is ::blink::testing. Inside blink code you have to
write ::testing to be sure to get the root ::testing namespace.

Depending on how ignorant the compiler is, it might work anyway,
but in jumbo builds the compiler often knows about the
blink::testing namespace.

TBR=leon.han@intel.com

Change-Id: I7617e074dba5cabb813c3a823757e0ba0ce15008
Reviewed-on: https://chromium-review.googlesource.com/832607Reviewed-by: Daniel Bratell <bratell@opera.com>
Commit-Queue: Daniel Bratell <bratell@opera.com>
Cr-Commit-Position: refs/heads/master@{#524711}

This prevents an ErrorProne warning about parameter mismatch.

Change-Id: Ia9b3eae945980b47d92cf6affe042de1875eae3a
Reviewed-on: https://chromium-review.googlesource.com/832427Reviewed-by: Nicolas Dossou-Gbété <dgn@chromium.org>
Commit-Queue: Bernhard Bauer <bauerb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524710}

viz_content_browsertests has exceptions on 3 bots. This is just
because we never manually added them to these bots in the old format of
configuring bots.

TEST=ran the associated trybots for viz_content_browsertests

Bug: 760181
Change-Id: I9c197c4ab906aad35522c49a0f618925d7ca258d
Reviewed-on: https://chromium-review.googlesource.com/829654Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Commit-Queue: Jonathan Ross <jonross@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524709}

This reverts commit e9cc36e4.

Reason for revert: https://crbug.com/795744

Original change's description:
> [Ribbon] Remove CSSProperty groups
> 
> Gist for gen diff here:
> 
> https: //gist.github.com/rjwright/d32835d21f8b313c46ec7a1c6d4d0155/revisions
> Bug: 788554
> Change-Id: Ia19d78686e9742a91455fa044c69c22c94c05552
> Reviewed-on: https://chromium-review.googlesource.com/804645
> Commit-Queue: Renée Wright <rjwright@chromium.org>
> Reviewed-by: meade_UTC10 <meade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524692}

TBR=rjwright@chromium.org,meade@chromium.org

Change-Id: I0c1d41d5ef0f93b4563ad755b3b1743810b8a9b8
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug: 788554
Reviewed-on: https://chromium-review.googlesource.com/832469Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524708}

This reverts commit a6e5ee25.

Reason for revert: https://crbug.com/795744

Original change's description:
> [Ribbon] Remove ID arg from CSSProperty constructor
> 
> Bug: 
> Change-Id: Iec8e0ab541266cbb65e68d257cbdf5b8f326c75f
> Reviewed-on: https://chromium-review.googlesource.com/810505
> Commit-Queue: Renée Wright <rjwright@chromium.org>
> Reviewed-by: meade_UTC10 <meade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524697}

TBR=rjwright@chromium.org,meade@chromium.org

Change-Id: I3960b36737f89160b1dc885fa3a9a0095532948c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/832566Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524707}

This reverts commit b5d56567.

Reason for revert: https://crbug.com/795744

Original change's description:
> [Ribbon] Make unneeded constructors protected & leaf classes final
> 
> Would have been nice to make the leaf constructors protected &
> singleton but they are called by global level declarations
> so too much messing around to be worth it.
> 
> Bug: 
> Change-Id: I2b96460912af5a3ea6b4049ccb49c67b2d394a27
> Reviewed-on: https://chromium-review.googlesource.com/816780
> Commit-Queue: Renée Wright <rjwright@chromium.org>
> Reviewed-by: meade_UTC10 <meade@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#524701}

TBR=rjwright@chromium.org,meade@chromium.org

Change-Id: Idc449e0ec2685d0d30a935155d6d2ced83fc5db6
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Reviewed-on: https://chromium-review.googlesource.com/832468Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524706}

BUG=chromium:624411

Change-Id: Icf3bdf7f004751639f86beb0eb03b2deab902c5d
Reviewed-on: https://chromium-review.googlesource.com/829379Reviewed-by: Ned Nguyen <nednguyen@google.com>
Commit-Queue: Ross McIlroy <rmcilroy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524705}

Local files should always have autoplay.

BUG=794294

Change-Id: I3d2d302dc7e9476f5a694f2211986e6858714d1d
Reviewed-on: https://chromium-review.googlesource.com/831986
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524704}

RecordStoredScoresToHistogram() is currently taking around 53.5ms when
MediaEngagementService is constructed. This uses a task runner to record
the scores asynchronously without blocking startup.

BUG=791779

Change-Id: I8302eea6ab50411471572edb0b12f78f2986f144
Reviewed-on: https://chromium-review.googlesource.com/808484
Commit-Queue: Becca Hughes <beccahughes@chromium.org>
Reviewed-by: Mounir Lamouri <mlamouri@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524703}

Is intended to simulate a video call with one high resolution video
element and several with low resolutions. The srcObject of the high
resolution element is frequently swapped with one of the low resolution
elemements.

This is a port of the ChromeOS Autotest video_WebRtcMainFeedSwitching.

Bug: 777857
Change-Id: I64f522f7141e6f2c7dcdf04d64af9147e884173d
Reviewed-on: https://chromium-review.googlesource.com/819416
Commit-Queue: Kristoffer Erlandsson <kerl@google.com>
Reviewed-by: Patrik Höglund <phoglund@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524702}

Would have been nice to make the leaf constructors protected &
singleton but they are called by global level declarations
so too much messing around to be worth it.

Bug: 
Change-Id: I2b96460912af5a3ea6b4049ccb49c67b2d394a27
Reviewed-on: https://chromium-review.googlesource.com/816780
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524701}

The reference contained display:contents style making this test always
pass. The elements tested here are now covered by:

css/css-display/display-contents-unusual-html-elements-none.html
css/css-display/display-contents-button.html

Bug: 794498
Change-Id: I392c71d09fa8dc32d1b29ef99c0859af50cd75ed
Reviewed-on: https://chromium-review.googlesource.com/832086Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524700}

https://chromium.googlesource.com/catapult.git/+log/6c84ef00005b..8a4ac91dd392

$ git log 6c84ef000..8a4ac91dd --date=short --no-merges --format='%ad %ae %s'
2017-12-18 mlamouri Disable autoplay restrictions on Chrome via command line flag.

Created with:
  roll-dep src/third_party/catapult


The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel
TBR=sullivan@chromium.org

Change-Id: I8255f0ac4d4500f60872cae3660b95c07df9aafb
Reviewed-on: https://chromium-review.googlesource.com/832046
Commit-Queue: <catapult-deps-roller@chromium.org>
Reviewed-by: <catapult-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524699}

Bug: 769629
Change-Id: If9ea16b53f7201a0abe92aebc119e0bc4c6c2e20
Reviewed-on: https://chromium-review.googlesource.com/831383
Commit-Queue: Philip Jägenstedt <foolip@chromium.org>
Reviewed-by: Philip Jägenstedt <foolip@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524698}

Bug: 
Change-Id: Iec8e0ab541266cbb65e68d257cbdf5b8f326c75f
Reviewed-on: https://chromium-review.googlesource.com/810505
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524697}

Summary of changes available at:
https://chromium.googlesource.com/v8/v8/+log/62729327..c85ab812

Please follow these instructions for assigning/CC'ing issues:
https://github.com/v8/v8/wiki/Triaging%20issues

Please close rolling in case of a roll revert:
https://v8-roll.appspot.com/
This only works with a Google account.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel

TBR=hablich@chromium.org,machenbach@chromium.org,kozyatinskiy@chromium.org,sergiyb@chromium.org

Change-Id: I7c9f52b7e264cdc743ee84cf07acf8274329a6bd
Reviewed-on: https://chromium-review.googlesource.com/832006Reviewed-by: v8 autoroll <v8-autoroll@chromium.org>
Commit-Queue: v8 autoroll <v8-autoroll@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524696}

battery_status_service_unittest.cc also has a FakeBatteryManager class,
which collides with this one in jumbo builds.

BUG=794692

Change-Id: I9a62f495470e1128dad931df3ea4a815d6c55cf9
Reviewed-on: https://chromium-review.googlesource.com/827765Reviewed-by: Colin Blundell <blundell@chromium.org>
Commit-Queue: Mostyn Bramley-Moore <mostynb@vewd.com>
Cr-Commit-Position: refs/heads/master@{#524695}

https://skia.googlesource.com/skia.git/+log/ef0384835757..46845d1c3af5

$ git log ef0384835..46845d1c3 --date=short --no-merges --format='%ad %ae %s'
2017-12-18 angle-deps-roller Roll skia/third_party/externals/angle2/ 647dca767..a2d981418 (1 commit)

Created with:
  roll-dep src/third_party/skia


The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel
TBR=csmartdalton@chromium.org

Change-Id: Ie47e5ac5ccb26db58b37203e4a4897fc5c3a5fce
Reviewed-on: https://chromium-review.googlesource.com/831906Reviewed-by: Skia Deps Roller <skia-deps-roller@chromium.org>
Commit-Queue: Skia Deps Roller <skia-deps-roller@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524694}

The previous CL disabled the wrong test.

TBR=shuchen@chromium.org

Bug: 795631
Change-Id: If8dc9a83b0e691f12b5212b79c457af745006279
Reviewed-on: https://chromium-review.googlesource.com/831949
Commit-Queue: Christian Dullweber <dullweber@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Reviewed-by: Shu Chen <shuchen@chromium.org>
Reviewed-by: Christian Dullweber <dullweber@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524693}

Gist for gen diff here:

https: //gist.github.com/rjwright/d32835d21f8b313c46ec7a1c6d4d0155/revisions
Bug: 788554
Change-Id: Ia19d78686e9742a91455fa044c69c22c94c05552
Reviewed-on: https://chromium-review.googlesource.com/804645
Commit-Queue: Renée Wright <rjwright@chromium.org>
Reviewed-by: meade_UTC10 <meade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524692}

The TARGET_NAME should depend on TARGET_NAME_ui, not the other way
around.
TARGET_NAME usually contains the coordinator/mediator, TARGET_NAME_ui
the View/ViewController. The coordinator should know the View layer,
not the other way around.
Here the layer separation hasn't been done yet, but it should still
respect the convention, in particular if we try to add objects
respecting the layer separation.

Bug: none
Cq-Include-Trybots: master.tryserver.chromium.mac:ios-simulator-cronet;master.tryserver.chromium.mac:ios-simulator-full-configs
Change-Id: I1e9d3ee25fb2983a42d0670787a174989f60652e
Reviewed-on: https://chromium-review.googlesource.com/829374
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Eric Noyau <noyau@chromium.org>
Cr-Commit-Position: refs/heads/master@{#524691}