- 13 Jan, 2021 40 commits
-
-
Francois Doray authored
To support blink::Thread::ThreadId(), a synchronous wait is necessary on blink::WorkerThread creation. To make it possible to remove the synchronous wait in an upcoming CL, we remove blink::Thread::ThreadId() in this CL. Usage is replaced by other mechanisms: 1. Change the priority of the compositor thread After creating the compositor thread, we post a task to it to obtain its tid via base::PlatformThread::CurrentId(). We send the obtained tid to the browser process so it can set the desired thread priority. 2. Store the tid in WorkerInspectorController Since the code runs on the worker thread, we can just invoke base::PlatformThread::CurrentId() instead of blink::Thread::ThreadId(). 3. Generate an AgentId for testing Instead of using the tid of the main thread as a unique identifier, we use base::GetCurrentProcId(). Bug: 1080709 Change-Id: If92718a2e28b1d9e8ab9f259c95a5f27aee87e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2580005 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843041}
-
Francois Doray authored
[sheriff] Add failure expectation for fast/forms/suggestion-picker/time-suggestion-picker-appearance.html on Win7. This expectation was mistakenly removed by https://chromium-review.googlesource.com/c/chromium/src/+/2595684 R=masonfreed@chromium.org TBR=masonfreed@chromium.org Bug: 1045510 Change-Id: Id24b804654e9ad84cce0d73b01755b5aba6ccc72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626773Reviewed-by:
François Doray <fdoray@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#843040}
-
James Vecore authored
Payload progress percent logging tends to spam logs and is rarely if ever useful. Change-Id: I4eeb5abcc934cdf8b763e924c4a2ac1d0e5658e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627167 Auto-Submit: James Vecore <vecore@google.com> Commit-Queue: Josh Nohle <nohle@chromium.org> Reviewed-by:
Josh Nohle <nohle@chromium.org> Cr-Commit-Position: refs/heads/master@{#843039}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/44ba8e1708ab..8fccd82e4e02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I6c1a4e7c051ebce47d823b380ee269061e358cc6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627131Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843038}
-
Stephan Hartmann authored
Comparing base::StringPiece("\x11\x11") with base::StringPiece("\x99\x99") wrongly returns that "\x99\x99" is smaller than "\x11\x11". The problem here is that characters are interpreted signed. In previous example 0x99 is therefore interpreted as -104 which of course is smaller than 17 (0x11). Clang is not affected, because it uses __builtin_memcmp or __builtin_wmemcmp. Solution is to use std::char_traits<T>::lt, which is constexpr in C++14 already and handles signed characters correctly. Bug: 941696 Change-Id: I24edfa4f92058faf87bd029b06832ae1e9e3a6d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624670 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#843037}
-
Benoit Lize authored
Make sure we don't forget any sanitizer when deciding to not use our own allocator. HWASAN was missing from an "else" clause, even though it requires its own allocator. Reported by bartekn@. Change-Id: Iecfc14d4a4782ab8c72f8015948afe3cd8485169 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627155Reviewed-by:
Bartek Nowierski <bartekn@chromium.org> Commit-Queue: Benoit L <lizeb@chromium.org> Cr-Commit-Position: refs/heads/master@{#843036}
-
Francois Doray authored
TBR=yoavweiss@chromium.org R=yoavweiss@chromium.org Bug: 1164459 Change-Id: I6d70a3ab12f51b4b777de99693fdb0684ffe65d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627688Reviewed-by:
-
Kyle Horimoto authored
We've seen some intermittent connectivity issues where BLE scans do not pick up advertisements sent by the phone. However, it's hard for us to tell what service data is being scanned so that we can match this logged data up with bug reports on the phone. This CL logs this metadata during BLE scans. Bug: 1164572 Change-Id: Icefbd5624a7c5987db944883d1e77d6530951f31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626316Reviewed-by:
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/8fccd82e4e02..704a1aa4c802 2021-01-13 treehugger-gerrit@google.com Merge "Migrate kTrackEventDescriptor to build time" 2021-01-13 hjd@google.com Merge "upkeep: Use empty() rather than size() == 0" If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: None Tbr: perfetto-bugs@google.com Change-Id: I818943960691d5c413a9dc08ed1d3888c419577e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627061Reviewed-by:
-
Mirko Bonadei authored
Change Log: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+log/a6c17c7e84..322ae2420d Full diff: https://chromium.googlesource.com/external/github.com/abseil/abseil-cpp/+/a6c17c7e84..322ae2420d No changes to .def files. Bug: None Change-Id: I512dc2a70354d72feb8a8af825f27b4037470367 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626438Reviewed-by:
Danil Chapovalov <danilchap@chromium.org> Commit-Queue: Mirko Bonadei <mbonadei@chromium.org> Cr-Commit-Position: refs/heads/master@{#843032}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-mac-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: I400a11265c847f687c49305d58155d7f962fc41c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627555Reviewed-by:
-
Jérémie Boulic authored
In //ui/file_manager/file_manager/foreground/js/: - selection_menu_controller.js - sort_menu_controller.js - webui_command_extender.js In ui/file_manager/file_manager/foreground/js/ui/: - dialog_footer.js Bug: 1133186 Change-Id: Ia143482ddc25ab56cbd5bb10f3704b3c2764c5d9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626990 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#843030}
-
Xi Han authored
The crash is caused by LayoutManagerChrome#showOverview() is called before the LayoutManagerChrome is initialized. More specifically, the TabModelSelector hasn't been set to the LayoutManagerChrome. However, the null check doesn't seem necessary when LayoutManagerImpl#startShowing() is called. Thus we remove this check to avoid crash on the debug build. Bug: 1164884 Change-Id: If5dc74ce39bed62f6ac0fa07a7578fda18ba6bb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622326Reviewed-by:
Matthew Jones <mdjones@chromium.org> Commit-Queue: Xi Han <hanxi@chromium.org> Cr-Commit-Position: refs/heads/master@{#843029}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/44ba8e1708ab..8fccd82e4e02 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-mac-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I51c3d969d8f97cafb203e9b598cbedd6f48a8025 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627134Reviewed-by:
-
Adam Rice authored
Extend the lifetime of histograms Blink.Compression.CompressionStream.Format and Blink.Compression.DecompressionStream.Format. These aren't currently needed, but will be needed again in future when we add more formats. BUG=1158458,1158457 Change-Id: I9aa9ad94eb389a085e626750112ed5d7c319bac7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2624275 Commit-Queue: Adam Rice <ricea@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#843027}
-
Hans Wennborg authored
These flags were removed in crrev.com/824947 but the thinlto flag was accidentally left behind. Bug: 1127713 Change-Id: Iea53c31a0f4a0a7ea09153595646ca6d13a9d45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627316 Commit-Queue: Hans Wennborg <hans@chromium.org> Commit-Queue: Nico Weber <thakis@chromium.org> Auto-Submit: Hans Wennborg <hans@chromium.org> Reviewed-by:
Nico Weber <thakis@chromium.org> Cr-Commit-Position: refs/heads/master@{#843026}
-
Raymond Toy authored
Remove the histogram WebAudio.OfflineAudioContext.SampleRate384kHz. Also removing OAC.ChannelCount, and OAC.Length since they all go with SampleRate384kHz and there's no point in keeping these if one of them is expired. Bug: 1165240 Change-Id: I9dcb3ea66ba4ba7704e0bbf1164a9cf0d5a395da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625378Reviewed-by:
Hongchan Choi <hongchan@chromium.org> Reviewed-by:
Weilun Shi <sweilun@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#843025}
-
chromium-internal-autoroll authored
Release_Notes: http://go/media_app-x20/relnotes/Main/media_app_202101130600_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/media_app/app/+/ze58P0cJwOmw_WVAzh3TDsg4AbgoRTTor2emAc_jh6EC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/media-app-chromium-autoroll Please CC media-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: b/173070498,b/174442020,b/174603791,b/176508429,b/176852796,b/177378673,b/177383478 Tbr: media-app@grotations.appspotmail.com Change-Id: I7bc9678c86833e7befa5bf507dc38618f0449155 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627557Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843024}
-
Tsuyoshi Horo authored
We still want to preserve the following histograms: * PrefetchedSignedExchangeCache.HeadersSizeTotal * Net.NetworkErrorLogging.SignedExchangeRequestOutcome Bug: 1165258, 1165256 Change-Id: If7d302b8298e89a1d2a164b8f81a459725e1431b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626617 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Auto-Submit: Tsuyoshi Horo <horo@chromium.org> Cr-Commit-Position: refs/heads/master@{#843023}
-
Michele Mancina authored
User connection is evaluated based on the roundtrip times to our backend. The website speed is based on the duration of single "active" cycle in the wait for dom operation. Bug: b/175311081 Change-Id: Id7e57b8958af31d3e841b6d728fef16689b5edd6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2614838 Commit-Queue: Michele Mancina <micantox@google.com> Reviewed-by:
Marian Fechete <marianfe@google.com> Reviewed-by:
Luca Hunkeler <hluca@google.com> Cr-Commit-Position: refs/heads/master@{#843022}
-
Geoff Lang authored
ANGLE's libGLESv2.dylib and libEGL.dylib ship with Chrome by default so package so export the symbols for crash reports. Bug: angleproject:5534 Change-Id: Ide0b9be3a41034fc41d80c3de337b3a92dd66888 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625407Reviewed-by:
Robert Sesek <rsesek@chromium.org> Commit-Queue: Geoff Lang <geofflang@chromium.org> Cr-Commit-Position: refs/heads/master@{#843021}
-
Francois Doray authored
R=waffles@chromium.org TBR=waffles@chromium.org Bug: 1166196 Change-Id: Iada0c9d68acf3e7c5a0dc395382a2e1cb62d5fad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626772Reviewed-by:
Joshua Pawlicki <waffles@chromium.org> Commit-Queue: François Doray <fdoray@chromium.org> Cr-Commit-Position: refs/heads/master@{#843020}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/03dbe217..6cbcce5b Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I7ee673f6a4f4156e039eea995a44b159bbe14e37 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627627Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#843019}
-
Illia Klimov authored
WebsiteSettings.Menu.PermissionChanged.SessionOnly Permissions.BatteryLevel.Accepted.LocationSettingsDialog Bug: 1165121, 1165203 Change-Id: Ib644a19f53bfe20df3ba087b79bdf5dbff5d715f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627274Reviewed-by:
Illia Klimov <elklm@chromium.org> Reviewed-by:
-
Sadrul Habib Chowdhury authored
When starting a new vsync/frame, the previous frame should explicitly be marked as 'did not produce frame'. This assertion is failing on webview. So introduce a speculative fix for the crash to unblock the release, while we investigate the underlying issue. BUG=1144353 Change-Id: I436cc0a0115287967f9007a91e40ec41b3b69f84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626770Reviewed-by:
Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#843017}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/goldctl-win-chromium-autoroll Please CC bsheedy@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: bsheedy@chromium.org Change-Id: Icf895d760c44ed8d49b6685c9433aa12a29f4742 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2626021 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
Roll Chrome Mac PGO profile from chrome-mac-master-1610517435-0b7576a8f42d1cf58a978eb4b1fa934cc5ba313f.profdata to chrome-mac-master-1610538373-c4c83fd08459537f19e890c14c2288baf23d3675.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-mac-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:mac-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I104b2965d86e0578389f7a5b61e3b6e870eddf2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627551 Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/95ab239e91ec..bcd6b5c3ff8a 2021-01-13 tvanderlippe@chromium.org Inline and remove isEnterKey 2021-01-13 tvanderlippe@chromium.org [module.json extensions] developer_resources 2021-01-13 devtools-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com Update DevTools DEPS. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1050549,chromium:1134103 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I4e01d89e6ceacd1f43244d4f59ef855e5de8252b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627056Reviewed-by:
-
Tibor Goldschwendt authored
Before, we only tracked NewTabPage.Modules.Loaded, which measures the duration between NTP navigation start and the module load end. This duration can be influenced by several factors other than actually loading the module. For instance, we delay loading the module until after more crucial UI has been rendered. To get a better understanding of how long a module loads for this CL adds NewTabPage.Modules.LoadDuration, which tracks exactly that duration. Bug: 1154008 Change-Id: I55f2cca71bbf6d9d4fee8885f09148e17fd7e975 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623655 Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Cr-Commit-Position: refs/heads/master@{#843013}
-
sczs authored
Bug: 1165271, 1165034 Change-Id: Ie4e2419decac57a32c9ddebce5a7bd237c8c55ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2625828 Auto-Submit: Sergio Collazos <sczs@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
-
Tim Volodine authored
AutofillAssistantBottomsheetTest#testHandleHeader and AutofillAssistantBottomsheetTest#testHandleHeaderCarousels are flaky on android-pie-x86-rel. BUG=1166168 TBR=hluca@google.com Change-Id: Iaa4f51ff18e08063f8058a886608400de3ef25a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627419 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Cr-Commit-Position: refs/heads/master@{#843011}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/fe6147b4a04c..c9846ef0a828 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC kolos@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: kolos@google.com Change-Id: I615868e6db01e31133cf27e663ecfcf6ae13708a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627552Reviewed-by:
-
Josh Karlin authored
This is a reland of a2873758 Original change's description: > [CodeInclusion] Improve terminology in subresource_filter > > Removing all but one case of master/slave/whitelist/blacklist in > subresource_filter directories. The remaining case involves a change to > safe browsing. > > > Bug: 1160252 > Change-Id: I6aba50a767072ef4a9abb0bacf463712a27f7058 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2597012 > Reviewed-by: Charlie Harrison <csharrison@chromium.org> > Reviewed-by: Reilly Grant <reillyg@chromium.org> > Commit-Queue: Josh Karlin <jkarlin@chromium.org> > Cr-Commit-Position: refs/heads/master@{#842231} Bug: 1160252 Change-Id: I63877ddf44cab2605e04a9b6c7f1b5c0c894d9f3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622337Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Josh Karlin <jkarlin@chromium.org> Cr-Commit-Position: refs/heads/master@{#843009}
-
Ali Juma authored
EarlGrey is not compatible with ASan, so in order to adapt CWTChromeDriver for fuzzing, all dependencies on EarlGrey need to be removed. CWTChromeDriver doesn't do any actual EarlGrey UI testing. Instead, it only used EarlGrey as a convenient way of setting up a test process and app process, with EDO communication between processes. This CL removes the EarlGrey dependencies, instead using XCUITest and EDO directly. Bug: 1158540 Change-Id: Iec0534d668413e0630010c7d470bac4e98db43bb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2622239Reviewed-by:
Justin Cohen <justincohen@chromium.org> Commit-Queue: Ali Juma <ajuma@chromium.org> Cr-Commit-Position: refs/heads/master@{#843008}
-
Nohemi Fernandez authored
Uses the current state of identity services to select the mode in which to display the sign-in promo. This prepares the configurator for a third syncing state to be added in a subsequent patch. Bug: 1151289 Change-Id: I9a73ef89c30782ed2e09cbda2f3e3e03e985c978 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2578942 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Jérôme Lebel <jlebel@chromium.org> Cr-Commit-Position: refs/heads/master@{#843007}
-
Lily Chen authored
This histogram was about to expire, and is no longer interesting as SameSite-by-default has launched which makes the samples almost entirely Lax. Bug: 1165039 Change-Id: I19bdb1ed423e198e7ffc22b2d24cfef81d6b9764 Fixed: 1165039 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2623001Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
-
Ben Kelly authored
Previously ReadableStreamByteConsumer assumed that each UInt8Array data chunk was immutable. While its generally true a UInt8Array is immutable it can still be invalidated by transferring it via postMessage(). This will cause any references to the chunk to suddenly become length zero. If this happens to chunks being processed by the consumer then it will get confused and cause a renderer crash. This CL causes the consumer to error out instead. Bug: 1161236 Change-Id: I44c7ad9115b05e321ba7cacaf28863f88ab14492 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615675Reviewed-by:
Yutaka Hirano <yhirano@chromium.org> Commit-Queue: Ben Kelly <wanderview@chromium.org> Cr-Commit-Position: refs/heads/master@{#843005}
-
Bence Béky authored
Implement logic for https://httpwg.org/http-extensions/draft-ietf-httpbis-priority.html#name-disabling-http-2-priorities in SpdySession, adding accessors for HTTP/2 priorities and PRIORITY_UPDATE frame. Add |enable_priority_update| knob to SpdySessionDependencies via SpdySessionPool to SpdySession. Default to current behavior both in tests and production. HttpNetworkSession: :Params and plumb it through from Change-Id: Iada98d7d692b3ce10e37cd9681ba16a99d564237 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2616834Reviewed-by:
Renjie Tang <renjietang@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#843004}
-
Rushan Suleymanov authored
The list can be used by the server to send invalidations to other clients on commit request. The list contains all known FCM tokens from all active devices known to the client via DeviceInfo data type. A device is considered active if it sent DeviceInfo specifics within its pulse time interval (with an additional margin interval). The list might contain the FCM token of the local device to support reflections. There is also a limit of the size of the list to restrict the additional data in a commit request. The empty list means that there is no known information about all other clients and the server should decide itself where to send invalidations. To distinguish the case when there is the only client (which doesn't expect a reflection invalidation), the client should provide the single client flag. Bug: 1164849 Change-Id: I4770091d8e5a577ad9581f899676feeaf381ba97 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2620560Reviewed-by:
Marc Treib <treib@chromium.org> Commit-Queue: Rushan Suleymanov <rushans@google.com> Cr-Commit-Position: refs/heads/master@{#843003}
-
Bence Béky authored
In SpdyStream::OnFrameWriteComplete(), remove early returns for specific, allowed frame types, remove CHECK on frame type, and replace them with an early return for any frame type other than HEADERS and DATA. The CHECK was not particularily useful, since it is okay not to take action when a frame write is complete, but with the CHECK in place one is forced to modify this method when adding a new frame type (that is why the reserved frame type logic got in there at https://crrev.com/c/1207750). This change makes the code easier to extend with potential future frame types like PRIORITY_UPDATE. Removing hardcoded reserved frame types formula is also beneficial, because special treatment of reserved frame types is potentially error-prone, and also goes against the spirit of GREASE. Change-Id: I53efa954411db42af051b4a06c7c3b30b969b0b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2615479Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#843002}
-
