GitLab

BUG=114261
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9514020

TBR=rvargas@google.com
Review URL: https://chromiumcodereview.appspot.com/9582024

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124715 0039d316-1c4b-4281-b951-d872f2087c98

TBR=mpcomplete@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9583023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124714 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Verify 'show/hide' advanced settings responds to click.
Review URL: https://chromiumcodereview.appspot.com/9570053

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124713 0039d316-1c4b-4281-b951-d872f2087c98

Added thumbnail URL, edit URL, and cache attributes.

BUG=chromium-os:27030
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9570031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124712 0039d316-1c4b-4281-b951-d872f2087c98

By the standard, static constants should also have a definition counterpart to
allocate storage space. It's not strictly necessary for ints (but it puts usage
restrictions on them), and for some reason we are having linking failure on
Chrome on Android when building with clang compiler, maybe that's because of
using templates or perhaps it's a clang issue.

Anyway, converting this constant into an enum solves the problem.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9585014

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124711 0039d316-1c4b-4281-b951-d872f2087c98

BUG=98716
R=jam@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9566035

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124710 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
Review URL: https://chromiumcodereview.appspot.com/9569041

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124709 0039d316-1c4b-4281-b951-d872f2087c98

BUG=none
TEST=Verify that the 'add device' button in the bluetooth section works.
Review URL: https://chromiumcodereview.appspot.com/9567031

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124708 0039d316-1c4b-4281-b951-d872f2087c98

i.e., two declared attributes are bound to the same location, then we fail the link.

Many drivers already do this, but not all of them.  For example, mesa does not, and it caused memory corruption actually.  So we do this in chrome command buffer.

BUG=112569
TEST=test case in 112569
R=gman
Review URL: https://chromiumcodereview.appspot.com/9570023

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124707 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113159,116438

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124346

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=124562

Review URL: https://chromiumcodereview.appspot.com/9509001

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124706 0039d316-1c4b-4281-b951-d872f2087c98

TBR=sky@chromium.org
BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9566044

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124705 0039d316-1c4b-4281-b951-d872f2087c98

TBR= elijahtaylor@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9580017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124704 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppression for JsonSchemaCompilerAdditionalPropertiesTest

BUG=116580
TEST=Valgrind turns green
R=calamity@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9572020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124703 0039d316-1c4b-4281-b951-d872f2087c98

BUG=114261
TEST=none
Review URL: https://chromiumcodereview.appspot.com/9514020

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124702 0039d316-1c4b-4281-b951-d872f2087c98

Get rid of chrome dependencies from tab_contents_drag_win.cc. After this I'll move it to content\browser\tab_contents.

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9581003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124701 0039d316-1c4b-4281-b951-d872f2087c98

Added guard to not set scrollTop if it hasn't changed. Surprisingly, this speeds up the list.redraw() method by 19X.


BUG=62854
TEST=manually


Review URL: http://codereview.chromium.org/9568039

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124700 0039d316-1c4b-4281-b951-d872f2087c98

TBR=akalin@chromium.org
BUG=111399

Review URL: https://chromiumcodereview.appspot.com/9585017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124699 0039d316-1c4b-4281-b951-d872f2087c98

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124698 0039d316-1c4b-4281-b951-d872f2087c98

TBR=haraken@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9584018

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124697 0039d316-1c4b-4281-b951-d872f2087c98

The NTP is completely different on Android and doesn't display
user name or offer other sync functionality.

BUG=113487
TEST=


Review URL: http://codereview.chromium.org/9564022

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124696 0039d316-1c4b-4281-b951-d872f2087c98

Move TabContentsViewGtk's delegate to content\public\browser. Also name it a delegate instead of a wrapper to match what Mac (and Win soon) call theirs.

BUG=98716
Review URL: https://chromiumcodereview.appspot.com/9586009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124695 0039d316-1c4b-4281-b951-d872f2087c98

BUG=115603
TEST=existing tests

Review URL: https://chromiumcodereview.appspot.com/9562032

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124694 0039d316-1c4b-4281-b951-d872f2087c98

We were getting an error because |insertBefore| requires the second argument to
be a direct child of its |this| object, and in the sync dialog, that is not the case.

BUG=none
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9562050

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124693 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110130
TEST=none


Review URL: http://codereview.chromium.org/9585004

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124692 0039d316-1c4b-4281-b951-d872f2087c98

Also rename some not-yet-used button assets to have shorter names.

BUG=113075
TEST=none
TBR=davemoore@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9583017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124691 0039d316-1c4b-4281-b951-d872f2087c98

BUG=110130
TEST=none

Review URL: https://chromiumcodereview.appspot.com/9562008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124690 0039d316-1c4b-4281-b951-d872f2087c98

BUG=116207
TEST=set RestoreOnStartupURLs policy, list in dialog is disabled

Review URL: https://chromiumcodereview.appspot.com/9561006

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124689 0039d316-1c4b-4281-b951-d872f2087c98

Suppresses leak in BrowserMainPartsPosix::PostMainMessageLoopStart

BUG=29675
TEST=Run Valgrind on Chrome OS
R=willchan@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9572017

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124688 0039d316-1c4b-4281-b951-d872f2087c98

Blacklist sdhook32.dll that is part of "Spybot - Search & Destroy Live Protection".
We'd seen the cases of crashes caused by that DLL. Looks that it modifies IAT
of kernelbase.dll and then unloaded itself without unpatching IAT, causing
delay load of ffmpeg to crash.

Verified that blacklist really works. Installed version of ""Spybot - Search & Destroy"
with "Live Protection" on my old XP machine, attached the debugger, and saw sdhook32.dll
in all unmodified chrome processes. Copied Chrome with my changes to that machine,
launched, and saw sdhook32.dll only in the browser, not in the renderer.

BUG=110983

Review URL: http://codereview.chromium.org/9568013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124687 0039d316-1c4b-4281-b951-d872f2087c98

BUG= 116383
TEST= none

Review URL: http://codereview.chromium.org/9566008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124686 0039d316-1c4b-4281-b951-d872f2087c98

Remove the duplicated prototypes and typedefs now that we have a NaCl
header file to get them from that can be #included from Chromium
without conflicts.

BUG=http://code.google.com/p/nativeclient/issues/detail?id=2628
TEST=compile

Review URL: https://chromiumcodereview.appspot.com/9565046

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124685 0039d316-1c4b-4281-b951-d872f2087c98

Requires setting background.allow_js_access to false in manifest.

BUG=113444
TEST=Example hosted app has different processes in different tabs.


Review URL: http://codereview.chromium.org/9508008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124684 0039d316-1c4b-4281-b951-d872f2087c98

BUG=113399
TEST=Manual

Review URL: http://codereview.chromium.org/9582011

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124682 0039d316-1c4b-4281-b951-d872f2087c98

Some fixes split off from https://chromiumcodereview.appspot.com/9570064/ to try and make the omnibox_view_browsertest.cc tests less flaky and make it possible to use the HQP in them.

BUG=none
TEST=none
TBR=mrossetti
Review URL: https://chromiumcodereview.appspot.com/9586012

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124681 0039d316-1c4b-4281-b951-d872f2087c98

R=aa@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9582009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124680 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppressions for races in SequencedWorkerPool

BUG=115987
TEST=TSAN Bots go green on Linux
R=akalin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9583015

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124679 0039d316-1c4b-4281-b951-d872f2087c98

BUG=78085
TEST=unit_tests


Review URL: http://codereview.chromium.org/9518008

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124678 0039d316-1c4b-4281-b951-d872f2087c98

The performance hit may be too high.

BUG=116401
TEST=


Review URL: http://codereview.chromium.org/9562009

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124677 0039d316-1c4b-4281-b951-d872f2087c98

Adds suppression for leak in LoggingTest_Dcheck_Test

BUG=116559
TEST=LoggingTest.Dcheck
R=akalin@chromium.org

Review URL: https://chromiumcodereview.appspot.com/9586010

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124676 0039d316-1c4b-4281-b951-d872f2087c98

Added a script to remove comments from the extension api JSON files before
processing for the extension docs. We will now be able to comment in the JSON
files, and they should be much easier to read. Also added the license header
to all the JSON files.

BUG=114233
TEST=Put comments in one of the JSON files and remake the docs. They will make
with no problems.


Review URL: http://codereview.chromium.org/9447090

TBR=cduvall@chromium.org
Review URL: https://chromiumcodereview.appspot.com/9582013

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@124675 0039d316-1c4b-4281-b951-d872f2087c98