- 13 Dec, 2017 40 commits
-
-
Makoto Shimazu authored
This patch implements a part of idle timer's logic. Fetch events coming through mojom::ControllerServiceWorker after the worker has requested termination to the browser should be queued until the worker receives the next event or StopWorker message from the browser. If the worker receives the next event from the browser, the queued events should run before the event from the browser, otherwise the order of the events would be messed up. If the worker receives StopWorker message instead, the worker shouldn't invoke the callback for the fetch event, and silently should disconnect the pipe to the clients. Bug: 774374 Change-Id: I6f3c90405ff037fe07df0310e2234cb81cb2ead9 Reviewed-on: https://chromium-review.googlesource.com/816458 Commit-Queue: Makoto Shimazu <shimazu@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#523677}
-
Alexei Filippov authored
Change-Id: I77f35482e9a4dc6468bab404ba3534a1ca301487 Reviewed-on: https://chromium-review.googlesource.com/823573 Commit-Queue: Alexei Filippov <alph@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#523676}
-
Peter Collingbourne authored
We cannot find library dependencies to add to a target's ordered libraries list by searching the build directory because the build directory may contain libraries that appear to be dependencies but are in fact unrelated libraries that share a name with a system library that the target depends on. For example, we may be building a target that depends on the system's libGLESv2.so, and the build directory may contain a library named libGLESv2.so as a result of building ANGLE. The resulting APK would try to load libGLESv2.so using the crazy linker, which might fail to load the system's library. The solution is to use GN's write_runtime_deps feature to export the runtime dependency list from the build system and create an ordered libraries list from that. Bug: 742655 Change-Id: Ifdbf3de6b78b56af22dbfe0d12d80db5a48fe9db Reviewed-on: https://chromium-review.googlesource.com/821600Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523675}
-
Pavel Feldman authored
This change enables remote users to define and style printing headers and footers. Proposed API exposes following element classes: 'date', 'title', 'url', 'pageNumber', 'totalPages' ...that can be used to tag template elements. Printing subsystem will substitute text content of these elements with the actual values. Header and footer templates will be provided over the remote debugging protocol and injected into the preview later. Change-Id: Ia3d1737d532b7f951007a0260c4936fcac0276fc Reviewed-on: https://chromium-review.googlesource.com/813177 Commit-Queue: Pavel Feldman <pfeldman@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#523674}
-
Peter Boström authored
Copies the strings and string descriptions verbatim but makes the use_titlecase entry In Title Case. The Restore label is the same in both but an additional copy is made to make sure that other languages could title case it if appropriate. Bug: chromium:698785 Change-Id: I923457767c155cdf4c147402a0ca7bc8376319fd Reviewed-on: https://chromium-review.googlesource.com/822136Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Peter Boström <pbos@chromium.org> Cr-Commit-Position: refs/heads/master@{#523673}
-
Tetsui Ohkubo authored
Deprecated Shortcut notification was using cogwheel icon. This CL changes the notification to use more specific keyboard icon. TEST=manual (Press Shift-Esc) BUG=792589 Change-Id: I62ed098ade7f3fd3d03bd140553190fed5293bb4 Reviewed-on: https://chromium-review.googlesource.com/818866 Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Cr-Commit-Position: refs/heads/master@{#523672}
-
Will Chen authored
This is a part-automated / part-manual process to migrate these /startup/ tests to the new integration test framework: 1. extract the precondition activities into an html file for the inspected window. 2. add TestRunner.setupStartupTest(...) as the first line of the js test to navigate to the inspected window before the DevTools session is started. 3. add testRunner.navigateSecondaryWindow(...) once the inspected page is done w/ the precondition activities. Bug: 667560 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I708c0719aa8ccdb38161e558fd535de12e7ccf9f Reviewed-on: https://chromium-review.googlesource.com/821517 Commit-Queue: Will Chen <chenwilliam@chromium.org> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523671}
-
pdfium-deps-roller@chromium.org authored
https://pdfium.googlesource.com/pdfium.git/+log/1228ae247f21..94ed4456bfe6 $ git log 1228ae247..94ed4456b --date=short --no-merges --format='%ad %ae %s' 2017-12-13 dsinclair Move remaining Script_ methods to CJX_Object 2017-12-13 dsinclair Move Script_Som_* methods to CJX_Object Created with: roll-dep src/third_party/pdfium The AutoRoll server is located here: https://pdfium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=dsinclair@chromium.org Change-Id: I133e00c2d76181726aab23e87b4a7bcfee3a2d67 Reviewed-on: https://chromium-review.googlesource.com/822763 Reviewed-by: <pdfium-deps-roller@chromium.org> Commit-Queue: <pdfium-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523670}
-
chromeos-commit-bot@chromium.org authored
TBR=chrome-os-gardeners@google.com Change-Id: I1bde77f69c41fae4e05b65b5be723462f7bb66fd Reviewed-on: https://chromium-review.googlesource.com/823683Reviewed-by:
ChromeOS Commit Bot <chromeos-commit-bot@chromium.org> Cr-Commit-Position: refs/heads/master@{#523669}
-
John Budorick authored
This reshards the suites w/ 90th percentile task times > 10 minutes on linux_chromium_asan_rel_ng. Bug: 793993 Change-Id: Id269a3a2466af43956e11b00e25637e02ba5f410 Reviewed-on: https://chromium-review.googlesource.com/822183 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Cr-Commit-Position: refs/heads/master@{#523668}
-
John Abd-El-Malek authored
Bug: 793432 Change-Id: Ic88a3aeedcb5c3d0f06f0e7da8edb3ef6433b155 Reviewed-on: https://chromium-review.googlesource.com/820672 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Cr-Commit-Position: refs/heads/master@{#523667}
-
Tetsui Ohkubo authored
Previously, if both the title and the message for a progress bar notification is long enough, the implementation showed the full text of the title and elided the message by following Android behavior. However, in Download notification, it elides "n mins left" text (See screenshot in the bug), which is not preferable. This CL changes the behavior to prioritize the message and elide the title if there is not enough space. TEST=manual BUG=789924 Change-Id: I9e8da6c9c53ce1409b6d2d7aa05ae2bd62ca854b Reviewed-on: https://chromium-review.googlesource.com/804982Reviewed-by:
Yoshiki Iguchi <yoshiki@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#523666}
-
Brian White authored
This is debug code to help locate the source of a problem that is causing files to not be processed. Bug: 760317 Change-Id: I53d950204d76dfd34dfee7b1d9db184f70c40a8e Reviewed-on: https://chromium-review.googlesource.com/823099 Commit-Queue: Brian White <bcwhite@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#523665}
-
Eric Karl authored
ClientDiscardableTextureManager and ClientTransferCache are called from special Threadsafe* functions on ContextSupport without the context lock held. We need locking in these cases to prevent data races which are currently possible. Bug: 794293 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I70c5a23dc2bd55cb77fb29c3c9057e8c37211e8c Reviewed-on: https://chromium-review.googlesource.com/823232 Commit-Queue: Eric Karl <ericrk@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523664}
-
Bill Budge authored
- V8 is moving to a read/write read/execute system. We won't need read/write/execute and should remove it from Chrome now. Bug: chromium:756050 Change-Id: Icc8a3ec334535c460e74a413cb265de2872db9f5 Reviewed-on: https://chromium-review.googlesource.com/822514Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Bill Budge <bbudge@chromium.org> Cr-Commit-Position: refs/heads/master@{#523663}
-
Jared Saul authored
Bug: Change-Id: I2f3ba3920dcb92a093359f979a40888f36840b64 Reviewed-on: https://chromium-review.googlesource.com/822184Reviewed-by:
Mathieu Perreault <mathp@chromium.org> Commit-Queue: Mathieu Perreault <mathp@chromium.org> Cr-Commit-Position: refs/heads/master@{#523662}
-
Sam McNally authored
Move registration of the BackgroundFetchService interface from RenderProcessHost to RendererInterfaceBinders so its implementation can receive a browser-tracked origin for its renderer-process client. Add support for move-only types to base::AutoReset. Use it in the BackgroundFetchServiceImpl test to swap in a service instance with a different origin for the part of the test that previously passed a different origin to the mojo interface. Bug: 779444 Change-Id: I68737625cb5cd0a2843eeb46643aad3b4f852d8c Reviewed-on: https://chromium-review.googlesource.com/788641Reviewed-by:
Peter Beverloo <peter@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523661}
-
Tetsui Ohkubo authored
As new style notification is launched in M62, and IsNewStyleNotificationEnabled() returns true by default on Chrome OS, we no longer have to check IsNewStyleNotificaitonEnabled(). This CL makes following changes. - Remove IsNewStyleNotificationEnabled checks under chrome/browser. (*.cc) - Remove icons that are no longer used. (*.png, *.icon) Icons that are not removed are referenced in somewhere. Bug: 757703 Change-Id: Ibfd26747c05d516140026718c093f18bac443cfe Reviewed-on: https://chromium-review.googlesource.com/810348Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Reviewed-by:
Dan Erat <derat@chromium.org> Reviewed-by:
Pavel Yatsuk <pavely@chromium.org> Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org> Cr-Commit-Position: refs/heads/master@{#523660}
-
Stefan Zager authored
This patch makes the rounding in UpdateScrollOrigin match the implementation of MaximumScrollOffsetInt(), by snapping to the box location minus border top/left (which is subtlely different from the client top/left). All of the test expectation changes are cases where a scrollable area is scrolled all the way to the right, but the scrollX is off by one. Bug: 711468 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_root_layer_scrolls;master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ie017c21b12c611e7166de8e828054b875a268955 Reviewed-on: https://chromium-review.googlesource.com/811889 Commit-Queue: Stefan Zager <szager@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#523659}
-
Scott Violet authored
Visible in this case means pixels have been lit on the display for the ChromeOS system UI. This is not completely enabled as the underlying wiring this is using (presentation-token) is not fully implemented yet. There is a test, but it is disabled for this reason as well. BUG=792214 TEST=none Change-Id: I6c3574a7204dda6112af69dc63f246906fa6a58b Reviewed-on: https://chromium-review.googlesource.com/818382 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#523658}
-
Klaus Weidner authored
There's a race condition where the first magic window VSync could arrive before ever getting a pose. Add a check and deferred execution to avoid this. BUG=787196 Change-Id: If804e4d6acc3da7b903ba36108f23c00b1c8fe5b Reviewed-on: https://chromium-review.googlesource.com/783887 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Bill Orr <billorr@chromium.org> Cr-Commit-Position: refs/heads/master@{#523657}
-
Ilya Sherman authored
This CL only covers //chrome. Will migrate the other uses in sibling CLs. R=sky@chromium.org Bug: 773850 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I38a114dab508fb0a0d1212bd64457be0c4619727 Reviewed-on: https://chromium-review.googlesource.com/822033 Commit-Queue: Ilya Sherman <isherman@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523656}
-
Andrew Grieve authored
Change-Id: Ib728cbcbd24fb421f57e15bde05e29a6c6a80b12 Reviewed-on: https://chromium-review.googlesource.com/822810Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Commit-Queue: agrieve <agrieve@chromium.org> Cr-Commit-Position: refs/heads/master@{#523655}
-
Katie Dektar authored
Bug: 789920,778080,789282 Change-Id: Ie4b9d18ffbff48602126f6a4024fdd39f49fe032 Reviewed-on: https://chromium-review.googlesource.com/815878 Commit-Queue: Katie D <katie@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#523654}
-
Xianzhu Wang authored
If the clip change is caused by the object having transform, we should not ignore the clip change because it actually affects descendants. Bug: 790560 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: Ifc05835e406eb265717128129c8095f3e52bb864 Reviewed-on: https://chromium-review.googlesource.com/822919 Commit-Queue: Xianzhu Wang <wangxianzhu@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#523653}
-
Matt Falkenhagen authored
These started passing after r522470: * WPT test: fetch-event-respond-with-stops-propagation.https.html * Chromium test: stop-worker-with-pending-fetch.html Bug: 715640 TBR: kinuko NOTRY: true Cq-Include-Trybots: master.tryserver.chromium.linux:linux_mojo Change-Id: I224eb3b0be0e7c46c93e5a43f400b6bf43c8e62c Reviewed-on: https://chromium-review.googlesource.com/822631Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#523652}
-
Brett Wilson authored
Updates some enums to enum classes, uses class member initializers, add unique_ptr to more cases. Change-Id: Iddca37cfba27a1fe7e2d74d73ced4c360769562f Reviewed-on: https://chromium-review.googlesource.com/822524 Commit-Queue: Brett Wilson <brettw@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#523651}
-
Ken Buchanan authored
This modifies a recent change that prevents accumulation of input events under the wrong local frame root. The original CL only guarded against recursion into frames that were under a different root, whereas crashes can still occur from target elements that are directly under the OOPIF. Bug: 792687 Change-Id: Iabb5ab41ef5bf8dc429c591358d7b169f921f088 Reviewed-on: https://chromium-review.googlesource.com/820070 Commit-Queue: Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#523650}
-
Peter Collingbourne authored
Change the class hierarchy used in this test in order to eliminate two static_casts that are invalid under CFI. While here, change the tests to use std::unique_ptr in order to simplify memory management (and fix a memory leak). Bug: 507755 Change-Id: Ibb077fee1f4286d46c9da3fbe0ce296f30e11c96 Reviewed-on: https://chromium-review.googlesource.com/818531Reviewed-by:
Will Harris <wfh@chromium.org> Commit-Queue: Peter Collingbourne <pcc@chromium.org> Cr-Commit-Position: refs/heads/master@{#523649}
-
catapult-deps-roller@chromium.org authored
https://chromium.googlesource.com/catapult.git/+log/30c927c2b8f3..fbee1329c2da $ git log 30c927c2b..fbee1329c --date=short --no-merges --format='%ad %ae %s' 2017-12-12 rnephew [Telemetry] Fix not importing device_errors in android_browser_backend 2017-12-12 simonhatch Dashboard - /add_histograms_queue stores unescaped_story_name Created with: roll-dep src/third_party/catapult The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.android:android_optional_gpu_tests_rel TBR=sullivan@chromium.org Change-Id: I790ee2b7bcb6f81a461db26c167a403b2f88b227 Reviewed-on: https://chromium-review.googlesource.com/822739 Reviewed-by: <catapult-deps-roller@chromium.org> Commit-Queue: <catapult-deps-roller@chromium.org> Cr-Commit-Position: refs/heads/master@{#523648}
-
Peng Huang authored
Bug: 792479, 793924 Test: Test on device with android apps Cq-Include-Trybots: master.tryserver.blink:linux_trusty_blink_rel;master.tryserver.chromium.android:android_optional_gpu_tests_rel Change-Id: I8c9beb8f835c294b6e2eb1dec4654a8d501c0952 Reviewed-on: https://chromium-review.googlesource.com/806689 Commit-Queue: Peng Huang <penghuang@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#523647}
-
Peng Huang authored
This CL implements GLSurface PresentationCallback for GLX. It uses OpenGL GpuTimer to query the |timestamp| for GPU finishes renderering the back buffer, and use the closest VSync after the |timestamp| to run presentation callback. Bug: 776877 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: I87f40022555b988e9cbe5cd628979c15f6043f0d Reviewed-on: https://chromium-review.googlesource.com/809704Reviewed-by:
danakj <danakj@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Reviewed-by:
Daniel Nicoara <dnicoara@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#523646}
-
webrtc-autoroll@chromium.org authored
https://webrtc.googlesource.com/src.git/+log/650a2e1adeb2..199942f3e6d4 $ git log 650a2e1ad..199942f3e --date=short --no-merges --format='%ad %ae %s' Created with: roll-dep src/third_party/webrtc BUG=None,None,None,None,None,None The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_chromium_archive_rel_ng;master.tryserver.chromium.mac:mac_chromium_archive_rel_ng;master.tryserver.chromium.win:win-msvc-dbg TBR=webrtc-chromium-sheriffs-robots@google.com Change-Id: Idc04b92e74f2604d28b69aab103867e5770d101f Reviewed-on: https://chromium-review.googlesource.com/823277Reviewed-by:
WebRTC Roll Bot <webrtc-autoroll@chromium.org> Commit-Queue: WebRTC Roll Bot <webrtc-autoroll@chromium.org> Cr-Commit-Position: refs/heads/master@{#523645}
-
Juan Jose Lopez Jaimez authored
Bug: 479898 Change-Id: I4c2030c8e38532a7de391360daf758dfcd1bc530 Reviewed-on: https://chromium-review.googlesource.com/820563Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Ryan Hamilton <rch@chromium.org> Cr-Commit-Position: refs/heads/master@{#523644}
-
Thanh Le authored
testLoFi, testLoFiCacheBypass, testLoFiSlowConnection are failing on desktop because DataReductionProxyDecidesTransform is not on. Same issue for testLitePageBTF, testLitePageBTFNano, testLitePageForcedExperiment, and testPreviewProvidedForHeavyPage. testLitePageBTFNano should be marked with AndroidOnly. Bug: 794344 Change-Id: Ia9e6708bfa2e9e3f233b5ac9989089e71dfc829e Reviewed-on: https://chromium-review.googlesource.com/822759 Commit-Queue: Thanh Le <thanhdle@chromium.org> Reviewed-by:
Doug Arnett <dougarnett@chromium.org> Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Cr-Commit-Position: refs/heads/master@{#523643}
-
Reilly Grant authored
This change simplifies setup in these tests as we already create a DataReductionProxyDelegate instance with the appropriate configuration. Bug: 721403 Change-Id: Iae6ae1364872c521f8da1b6ed5273b0af154ab25 Reviewed-on: https://chromium-review.googlesource.com/823179Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#523642}
-
Matt Wolenetz authored
Before this change, an unsorted sequence of buffered ranges could result from complex scenarios (in both ByDts and ByPts API usage). A simple example of such unsorted ranges is [a,b) [c,d), where b > c. This change prevents one known cause of unsorted ranges: when buffering a set of frames emitted from FrameProcessor and those frames change the fudge room, use the new fudge room to try to coalesce any existing buffered ranges before buffering the new frames. This allows the buffering code to correctly identify the (at most one) existing buffered range to which a new buffer or coded frame group start time belongs. Code already exists to ensure that such fudge room changes are only increases. BUG=793247 TEST=SourceBufferStreamTest.RangeCoalescenceOnFudgeRoomIncrease_*, and no more local repro of fuzzer case in crbug 793247 Cq-Include-Trybots: master.tryserver.chromium.android:android_optional_gpu_tests_rel;master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Change-Id: If6f78d56080ecb9bbdaef9df554c07f999d9a0ea Reviewed-on: https://chromium-review.googlesource.com/820656Reviewed-by:
Dan Sanders <sandersd@chromium.org> Commit-Queue: Matthew Wolenetz <wolenetz@chromium.org> Cr-Commit-Position: refs/heads/master@{#523641}
-
Stuart Langley authored
This continues the work to onion soup WebClipboard. - The mojo definition for ClipboardHost is moved from content/common to WebKit/common/clipboard. - The implementation of WebClipboard, content/renderer/webclipboard_impl.* is moved to WebKit/Source/platform/expored/WebClipboardImpl.*. - Fixed the implementation of WebClipboardImpl to use the blink types ( WTF::String etc) directly rather than WebString. - Plagiarized parts of DropDataBuilder and URLToImageMarkup as we need to keep implementations in content for MockWebClipboardImpl. - Removed the interface binding from renderer_blink_platform_impl to WebClipboardImpl and render_frame_impl (for MACOSX only). - Instantiate WebClipboardImpl in Platform.cpp (temporary until we can remove Clipboard() from platform.) We cannot remove Platform::Clipboard yet because it is used by pepper_webplugin_impl, will need see if we can move pepper to use mojo instead. Next steps; - Remove MockWebClipboardImpl and mock out at the mojo level instead of Platform. - Provide typemap for blink::mojo::ClipboardBuffer to ui::Clipboard for browser. - Remove Clipboard() from Platform by fixing pepper. - Delete public/platform/WebClipboard definition. Note: Gerrit is not showing which files are renames + modifications, the list is content/renderer/webclipboard_impl* : Source/platform/exported/WebClipboardImpl* content/common/clipboard.mojom : WebKit/common/clipboard/clipboard.mojom Bug: 775830 Change-Id: Ife7121886fe133cc7577cd1ce8f1d90262d97102 Reviewed-on: https://chromium-review.googlesource.com/809824 Commit-Queue: Stuart Langley <slangley@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#523640}
-
Eve Martin-Jones authored
This change is for files in the path //third_party/WebKit/Source/core/paint/. Added the include for base/macros.h where needed and moved the macro to the end of the class as per the code guidelines enforced by lint. This CL introduces no logic changes. Bug: 565932 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Change-Id: I6578f3d2d9e6bc22e33ef69a7e9fb69297e693a5 Reviewed-on: https://chromium-review.googlesource.com/813458 Commit-Queue: Eve Martin-Jones <evem@chromium.org> Reviewed-by:
Sasha Morrissey <sashab@chromium.org> Reviewed-by:
Chris Watkins <watk@chromium.org> Cr-Commit-Position: refs/heads/master@{#523639}
-
David Tseng authored
Adds a new rule for 'abstractItem'. This formats a node when entered and when focused. Apply this rule for two roles -- article and listItem. These two roles had no previous output rules, so no overriding happens. This completes pos in set and set size support according to Aria 1.1. Bug: 793056 Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation Change-Id: I14f3db2a240ed2cc235122c182a80c88afc99487 Reviewed-on: https://chromium-review.googlesource.com/814974 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#523638}
-