- 21 Apr, 2020 40 commits
-
-
Elly Fong-Jones authored
Bug: 1073157 Change-Id: Id3171b2e58baed0711f873adc1e41783415c30a4 Tbr: mlippautz@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159572Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#761069}
-
Thomas Guilbert authored
This CL turns on the HTMLVideoElement.requestVideoFrameCallback by default. I2S: https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/DcuNrnEQo4k Spec: https://wicg.github.io/video-rvfc/ WPT: https://wpt.fyi/results/video-rvfc Bug: 1012063 Change-Id: Ide74ef5cad0d7a9d77f3f0b64f5d446479136af1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157966 Commit-Queue: Thomas Guilbert <tguilbert@chromium.org> Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Cr-Commit-Position: refs/heads/master@{#761068}
-
spdonghao authored
Bug: 1061906 Change-Id: I6ced07e139c6be9a96ce32d8d1c5e3e2f1e9f74d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153585Reviewed-by:
Cathy Li <chili@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Xi Han <hanxi@chromium.org> Commit-Queue: Hao Dong <spdonghao@chromium.org> Cr-Commit-Position: refs/heads/master@{#761067}
-
chromium-autoroll authored
https://chromium.googlesource.com/openscreen.git/+log/22486ab1cdb8..ec1e828fc196 git log 22486ab1cdb8..ec1e828fc196 --date=short --first-parent --format='%ad %ae %s' 2020-04-21 jophba@chromium.org Revert ARM64 bot to 16.04 due to linker problems Created with: gclient setdep -r src/third_party/openscreen/src@ec1e828fc196 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/openscreen-chromium Please CC jophba@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: jophba@chromium.org Change-Id: Iddef12d3440ba9912f698d06fb91313cc0c1f261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159272Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761066}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/d26075f0c381..d3f79db3fdef git log d26075f0c381..d3f79db3fdef --date=short --first-parent --format='%ad %ae %s' 2020-04-21 livvielin@chromium.org [DevTools] Fix -theme-preserve button color on focus/hover/active 2020-04-21 tvanderlippe@chromium.org Temporarily disable network data grid tests Created with: gclient setdep -r src/third_party/devtools-frontend/src@d3f79db3fdef If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066813,chromium:1071313 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I636f7fea397e7223a76def2b98337ecc901d090b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159270Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#761065}
-
Hans Wennborg authored
This is in preparation for moving those macros out of the expensive logging.h header to check.h. Bug: 1031540 Change-Id: I31d2d5a9e20e4611c1da54a680c3b8cca0b688a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159429Reviewed-by:
Nico Weber <thakis@chromium.org> Commit-Queue: Hans Wennborg <hans@chromium.org> Cr-Commit-Position: refs/heads/master@{#761064}
-
chrome://appsDaniel Murphy authored
A user can drag a link onto the chrome://apps page to install it as a web app. This was previously done through the extensions system. This updates AppLauncherHandler to use the new BMO WebApp system, specifically the AppInstallManager. R=calamity@chromium.org, loyso@chromium.org Fixed: 1070136,1061286 Change-Id: I7d1ae0db4f70515efe73bb28d862dbce0ed939fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2148293Reviewed-by:
calamity <calamity@chromium.org> Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Daniel Murphy <dmurph@chromium.org> Cr-Commit-Position: refs/heads/master@{#761063}
-
Robbie McElrath authored
This CL moves the recently added WebappRegistry usage in Clank's Site Settings UI behind the SiteSettingsClient interface, which removes the //chrome dependency so site_settings can be componentized. Bug: 1058597 Change-Id: Ib9b8b0fc2ca43eaf15cbc86e9b5680745d007b19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158317Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#761062}
-
Hans Wennborg authored
Fix code that was implicitly depending on logging.h or its dependencies. For example, code that uses DISALLOW_COPY_AND_ASSIGN should include base/macros.h, but it currently happens to work if it pulls in logging.h directly or through some dependency. This is part of refactoring the codebase to use check.h/check_op.h for the CHECK and CHECK_op macro instead of logging.h. Bug: 1031540 Change-Id: Ia68258fa0d399fc9445d09a9ee5e510fd1265923 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156985 Auto-Submit: Hans Wennborg <hans@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Reviewed-by:
danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#761061}
-
Ben Mason authored
This reverts commit d6f88739. Reason for revert: Preventing canary release: crbug.com/1073163 Original change's description: > Android: Roll the latest aapt2 prebuilt to android_build_tools > > This rolls the nightly build 637621 of aapt2 to enable the latest fix > for resource name collapsing on bundles. > > Bug: 912804 > Change-Id: I96f239d0a2739b70a82e5f5f29203b7146272528 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2144396 > Commit-Queue: Mohamed Heikal <mheikal@chromium.org> > Reviewed-by: Andrew Grieve <agrieve@chromium.org> > Cr-Commit-Position: refs/heads/master@{#760605} TBR=agrieve@chromium.org,mheikal@chromium.org Change-Id: I6617ed7bfc117063800c348218b1908441eb752f No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 912804 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159144Reviewed-by:
Ben Mason <benmason@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#761060}
-
Xiaohan Wang authored
To enable these metrics on UKM dashboard. Bug: 1068642 Change-Id: I497e6bfe703407a9a6d42f68a546d2117c8f0058 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151335 Commit-Queue: Xiaohan Wang <xhwang@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#761059}
-
Eugene Zemtsov authored
This should unblock Fuchsia build bots. Bug: 1072849 Change-Id: I6947bd09544c7271b2ea6131ee04c8831bdc69d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158406Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Commit-Queue: Eugene Zemtsov <eugene@chromium.org> Cr-Commit-Position: refs/heads/master@{#761058}
-
Ovidio Henriquez authored
This change fixes an error when running the PRESUBMIT script in //third_party/blink/renderer/modules/bluetooth/testing/clusterfuzz. This error was caused by attempting to replace a substring in a UTF-8 encoded string with an ASCII encoded string. The fix converts the ASCII string to UTF-8 prior to this replacement operation. Bug: 1064538 Change-Id: I2c69ed4dc7bb9e47a2b0ed3150c90c6357df626d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149891Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#761057}
-
Aya ElAttar authored
Modified WebApps publisher to publish Chrome OS WebApps as disabled by policy, if they has is_disabled set. Bug: 1069605 Change-Id: Ib30a6d8498ad9e2792aaf6a44b7020c618321c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153157Reviewed-by:
Sergey Poromov <poromov@chromium.org> Reviewed-by:
Nancy Wang <nancylingwang@chromium.org> Commit-Queue: Aya Elsayed <ayaelattar@google.com> Cr-Commit-Position: refs/heads/master@{#761056}
-
Andrew Grieve authored
The package is not available by default on some Googler machines, and it was easy to remove. The only client was //media/tools/constrained_network_server/cns.py, which will now get cherrypy via vpython Bug: None Change-Id: If5dc02601691b68c0b6161cbf904837766a3e9ab Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2159406 Auto-Submit: Andrew Grieve <agrieve@chromium.org> Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Cr-Commit-Position: refs/heads/master@{#761055}
-
Robbie McElrath authored
This CL splits SiteSettingsClient.launchHelpAndFeedbackActivity into launchSettingsHelpAndFeedbackActivity and launchProtectedContentHelpAndFeedbackActivity methods. The method originally took a "helpContext" string, which mapped to one of Chrome's constants defined in //chrome/android/java/res/values/values.xml, which were used to determine which Chrome help page to launch. These constants are specific to Chrome, and shouldn't be part of a //components API. Splitting the method into two allows the embedder to choose which help page to show the user. Bug: 1058595 Change-Id: I193dd6c0767fe53223afaa952f311d0fa045c6c5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158408Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Robbie McElrath <rmcelrath@chromium.org> Cr-Commit-Position: refs/heads/master@{#761054}
-
ckitagawa authored
This CL adds support for plumbing a maximum capture size restriction to the PaintPreviewRecorde returning the size of the output. For now, TabbedPaintPreviewPlayer will use this to cap per SkPicture capture size to 5 MB. In a follow up the returned size information will be used to restrict the total capture size rather than the size per renderer. Bug: 1071446 Change-Id: Ib809d3156c11e6a8ee6144663794fe261f89f635 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152957Reviewed-by:
Mehran Mahmoudi <mahmoudi@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Calder Kitagawa <ckitagawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#761053}
-
Akihiro Ota authored
Bug: N/A Change-Id: Idc2bd9e15811692ba976c60a35c65e248a7aa8ca Relnotes: N/A Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157775 Commit-Queue: Akihiro Ota <akihiroota@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Cr-Commit-Position: refs/heads/master@{#761052}
-
Nate Chapin authored
While migrating ExecutionContext to LocalDOMWindow, several helpers were introduced on Document (From(), DynamicFrom(), ToExecutionContext()). This CL removes usage of these types from this directory. From() and DynamicFrom() are replaced with the standard downcast helpers for LocalDOMWindow. ToExecutionContext() is replaced with a direct path to the LocalDOMWindow, or Node::GetExecutionContext(), or Document::GetExecutionContext(), whichever is most direct from the callsite. Also, make WebAssociatedUrlLoaderImpl per-ExecutionContext, since it's an ExecutionContextLifecycleObserver. Change-Id: I325505bb3e97524636e76a21c6998f92afb3482f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2107611Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Nate Chapin <japhet@chromium.org> Cr-Commit-Position: refs/heads/master@{#761051}
-
Chrome Metrics Logs authored
Updates the expires_after attribute for 42 histograms that have been used to generate alerts in the past 90 days and do not already have a date later than or within 60 days of 2020-10-18. TBR=bcwhite@chromium.org Change-Id: If1fecdced75154299051b8a4a4243980b578a374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157054Reviewed-by:
Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Commit-Queue: Chrome Metrics Logs <chrome-metrics-team+robot@google.com> Cr-Commit-Position: refs/heads/master@{#761050}
-
Hua, Chunbo authored
This is a reland of 2f702ab1 kMediaFoundationAsyncH264Encoding flag is added as switch of the MFTEnumEx usage for asynchronous H.264 hardware MFT encoder. Also a new workaround item of GPU driver bug is added due to a known Nvidia GPU crash. In future, the hierarchy of hardware-accelerated video encoders on Windows is AsyncMFT>LegacyMFT>OpenH264. Original change's description: > Enable H.264 hardware MFT encoder on Windows > > Currently Microsoft H.264 encoder MFT is always used as WebRTC external > encoder without hardware acceleration. This change enables H.264 > hardware MFT encoder on Windows. > > Bug: 982799 > Change-Id: Ia33812508034daa99dd3dc1fb64b83cb1d7c8465 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1777521 > Commit-Queue: Dale Curtis <dalecurtis@chromium.org> > Reviewed-by: Tommi <tommi@chromium.org> > Reviewed-by: Dale Curtis <dalecurtis@chromium.org> > Cr-Commit-Position: refs/heads/master@{#745539} Bug: 982799 Change-Id: I54594322ded6b7434a8fe4d1b59f487b319b51e3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124213 Commit-Queue: Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
Dale Curtis <dalecurtis@chromium.org> Reviewed-by:
vikas soni <vikassoni@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Cr-Commit-Position: refs/heads/master@{#761049}
-
Alex Chau authored
- Clarified sender_guid requirement in SharingMessage Bug: 1044607 Change-Id: I5beb2a923041fdb6c39182a7ecb329e4c5c3872e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2153435Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Commit-Queue: Alex Chau <alexchau@chromium.org> Cr-Commit-Position: refs/heads/master@{#761048}
-
Reilly Grant authored
This change is preparing for a refactor of the BluetoothAdapterFactory internals. Those changes will move the factory state out of globals and into the singleton instance of BluetoothAdapterFactory. As a result it is easier to make methods like GetAdapter() non-static but this requires updating all callers. The return value of BluetoothAdapterFactory::Get() is changed from a reference to a pointer because the style guide recommends pointers for non-constant values. Bug: 1030549 Change-Id: Ie6da74fa5d17c586cbbd306f5a1e444b9d39260e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155465 Commit-Queue: Reilly Grant <reillyg@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Ovidio de Jesús Ruiz-Henríquez <odejesush@chromium.org> Cr-Commit-Position: refs/heads/master@{#761047}
-
Jarryd authored
Updates to the all sites page that were a part of the storage pressure UI project had unintentionally increased the height of origin line items to by using the "two-line" class. This change reverts the height by removing the specified class. Bug: 1071335 Change-Id: I1527c783ff53db5ea6874caafeaaaeaa18857217 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157675Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#761046}
-
Dominique Fauteux-Chapleau authored
The previous implementation would result in the entire extension being used, so atypical ones like "foo.csv.gz" would check if ".csv.gz" had a corresponding mimetype instead of just checking ".gz". Bug: 1069347 Change-Id: Ieefb8f4726d4a268e3bc312592a1c53060007210 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158973Reviewed-by:
Roger Tawa <rogerta@chromium.org> Commit-Queue: Dominique Fauteux-Chapleau <domfc@chromium.org> Cr-Commit-Position: refs/heads/master@{#761045}
-
Nate Chapin authored
Bug: 1029822 Change-Id: Ib8c0c21b0f4f9b10d69c394366021f4d156cf678 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2108798 Commit-Queue: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Hiroki Nakagawa <nhiroki@chromium.org> Reviewed-by:
Hiroshige Hayashizaki <hiroshige@chromium.org> Cr-Commit-Position: refs/heads/master@{#761044}
-
Sahir Vellani authored
This is a reland of 8e795d5b The previous CL was reverted because FlingControllerWithPhysicsBasedFlingTest in fling_controller_unittest.cc was flaky. It was found that occasionally a GestureScrollEnd would be incorrectly processed when a GestureScrollUpdate was expected. This CL addresses the issue by adding a check for a GSE in relevant areas of the test. Original change's description: > FlingBoost with experimental fling animation curve > > Currently, if physics based fling curve is enabled, even if the fling is > boosted, the scroll distance is capped by upper bound which is three > times the size of viewport. Thus it nullify the effect of fling boosting > and travels the same distance as it would if fling is not boosted. > > This CL fixes fling boosting with physics based fling curve. It does > so by increasing the upper bound every time a fling is boosted. > > Bug: 647137 > Change-Id: Ib2dd51b37df91168ae1f1e8d33888e3b5dc43e23 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2118218 > Reviewed-by: Navid Zolghadr <nzolghadr@chromium.org> > Reviewed-by: David Bokan <bokan@chromium.org> > Reviewed-by: Daniel Libby <dlibby@microsoft.com> > Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> > Cr-Commit-Position: refs/heads/master@{#758878} Bug: 647137 Change-Id: Ief4dfc3068018ce5fecf168b7c191db5544b90d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2151054 Commit-Queue: Sahir Vellani <sahir.vellani@microsoft.com> Reviewed-by:
Daniel Libby <dlibby@microsoft.com> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Navid Zolghadr <nzolghadr@chromium.org> Cr-Commit-Position: refs/heads/master@{#761043}
-
Wez authored
Bug: fuchsia:49001 Change-Id: Ib2697acea8da7e0123cee2d5c9d9d21eb427da03 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2145884 Auto-Submit: Wez <wez@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#761042}
-
Jeroen Dhollander authored
Previously this was all done in the |AssistantManagerServiceImpl|, but that class is already huge. To solve this I made the following changes: * split it out in a separate |AssistantDeviceSettingsDelegate| class. * Introduce helper |Setting| classes, 1 for each supported setting. * Add unittests for each of the supported settings. Bug: N/A Change-Id: Ia32aecb15e3200a183c72ad8e5bcfcd3b2b4dfbc Tests: new |chromeos_unittests| with filter |AssistantDeviceSettingsDelegateTest.*| Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2147693 Commit-Queue: Jeroen Dhollander <jeroendh@google.com> Reviewed-by:
Xiaohui Chen <xiaohuic@chromium.org> Cr-Commit-Position: refs/heads/master@{#761041}
-
Mike Wasserman authored
Use placeholder ordinal ids for now (0, 1, 2, ...); update tests. TODO: generate per-origin UUIDs that reset when cookies are deleted Test Screen.id values returned via window.getScreens() with: chrome://flags#enable-experimental-web-platform-features OR $ chrome --enable-blink-features=ScreenEnumeration Try https://michaelwasserman.github.io/window-placement-demo Bug: 994889 Test: Automated, Screen.id placeholder values Change-Id: I0c5b18b92fef251211822f3473ea85472a7ee945 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2155113Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#761040}
-
Haiyang Pan authored
Android devices with full-disk encryption will be encrypted on first boot, and then get decrypted to continue the boot process. Wait for this step to complete otherwise the avd may have "Encryption Unsuccessful" error. Also add debug tag "init" for avd create to print more debug message Need crrev.com/c/2153811 to land first Bug: 922145, 1057811 Change-Id: I2037d8f6a7f8edfa83e276e7ef94b93bebbb83ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2150398 Commit-Queue: Haiyang Pan <hypan@google.com> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#761039}
-
Daniele Castagna authored
crrev.com/c/2069137 added support for visible_rect. Unfortunately it incorrectly computed the UV translation. It had two issues: - It was using right() and bottom() instead of width() and height() when scaling the UV translation part. - It was not scaling the translation part for the input UV. This produced incorrect UVs when a rect was not in the origin and/or the input UV were scaled. This patch fixes the computation using cc::MathUtil::ScaleRectProportional instead. in viz_unittests. Bug: 1059408, 1057953 Test: TextureDrawQuadTranslatedAndVisibleRectInsetTopLeftAndCustomUV Change-Id: Id852f3c43167364a001f33de07892905c7d3b768 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2149637 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Cr-Commit-Position: refs/heads/master@{#761038}
-
Deepti Gandluri authored
Extending flag expiration milestones for WebAssembly features that are still in use by a year. Status of features gated by flags: * code caching - Enabled by default, okay to expire. * baseline/tiering - Ongoing finch trial * lazy compilation - Lazy compilation is still experimental * threads - Enabled by default in chrome, waiting on other browsers for complete implementations, so still useful for testing * simd - Still experimental, used for prototyping and gathering performance data. Change-Id: I51ae98b3dd784b1d619cebf15f81252c697f62a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158037Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Commit-Queue: Deepti Gandluri <gdeepti@chromium.org> Cr-Commit-Position: refs/heads/master@{#761037}
-
Xing Liu authored
CacheStrategy enum is defined in cached_image_metadata.proto, this should not be used beyond ImageMetadataStoreLevelDB. This CL adds a cpp enum that maps to CacheStrategy protobuf enum. Bug: 1067049,1058534 Change-Id: If13ac706e3c1f0a8cd2376ce1d7e5d26c5b571c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158064Reviewed-by:
Filip Gorski <fgorski@chromium.org> Reviewed-by:
Brandon Wylie <wylieb@chromium.org> Commit-Queue: Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#761036}
-
Dave Tapuska authored
The header file is included in various spots in blink and pulls in more than it should. Change-Id: Icabd4a00d7a19daf2c78cec032ff9742b7d6f43d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2156606Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#761035}
-
Anders Hartvoll Ruud authored
CSS declarations that are !important have higher priority in the cascade than animation effects. Unfortunately the information about which declarations were and weren't important is lost once the StyleCascade disappears. Specifically, it's not stored on the ComputedStyle. This causes a problem (once again) for the base computed style optimization, since we can't naively add animation effects on top of the base anymore. We might be overwriting something in the base that was important. The previous attempt at fixing this (flag on ElementAnimations) doesn't work properly. For example, it fails to detect the case where an animation initially doesn't conflict with important declarations, but then suddenly does via setKeyframes. To solve this, this CL stores a bitset containing information about important declarations alongside the base ComputedStyle on ElementAnimations. When we're considering whether the base can be used or not, we then check if there's any animation matching the set of important declarations. Persisting that many bits is slightly uncomfortable, but the only viable alternative I see is disabling the optimization when *any* important declaration exists in the base, which is probably a worse option. Sidenote: Initially I tried to always use the base, even when there were conflicts with important declarations. The bitset of important declarations is effectively a set of animations to be skipped, so we should still be able to use the base if we just don't apply the properties present in the set. However, it unfortunately didn't work due to visited/unvisited colors being animated together (crbug.com/1062217). Bug: 552085 Change-Id: I39e2879af8a858ce1bd97eaa2ceb6e222591df79 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2152449 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Cr-Commit-Position: refs/heads/master@{#761034}
-
Katie D authored
UX spec changed after discussion with PM. Also fixes bug causing the bubble to end up in the wrong place when the window shrinks extremely small in height and grows again, by keeping the ratios from being calculated when the bubble is not visible. Bug: 1055150 Change-Id: I6f344e22a44ce57615994508897a79b69c1bae8e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2157985 Commit-Queue: Katie Dektar <katie@chromium.org> Reviewed-by:
Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#761033}
-
Steven Valdez authored
https://boringssl.googlesource.com/boringssl/+log/367d64f84c3c1d01381c18c5a239b85eef47633c..78987bb7bb4764ca3a8b08b0a6f7bd14b53c3e4f Bug: none Change-Id: I223ef4fc5e902700b7a046f4a2558a153523a05e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2158969 Auto-Submit: Steven Valdez <svaldez@chromium.org> Reviewed-by:
David Benjamin <davidben@chromium.org> Commit-Queue: David Benjamin <davidben@chromium.org> Cr-Commit-Position: refs/heads/master@{#761032}
-
dpapad authored
Change Grit's default behavior to gzip compress all such files, unless compress="false" is explicitly specified. In other words, compress="gzip" is now the default behavior, and same as not specifying a |compress| attribute. out/<out_folder>/resources.pak sizes before/after (with optimize_webui=true) Linux: 7.1MB -> 5.9MB, -4.9% CrOS: 21.0MB -> 18.0MB, -14.3% Bug: 1068407 Change-Id: I3fa63a4db6087b2f3502cbb8b76a6ca3b576e7fd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1612333 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Rebekah Potter <rbpotter@chromium.org> Cr-Commit-Position: refs/heads/master@{#761031}
-
Piotr Pawliczek authored
This is a part of implementation of class Uri. This CL contains implementation of URI parser along with normalization and validation. The file with unit tests was also included. Other CLs: - https://crrev.com/c/2103143 - https://crrev.com/c/2118426 BUG=chromium:821497 TEST=on my workstation Change-Id: Ieb9f3c105d842d4cb2a8f2678d34130e3b94b374 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2123640 Commit-Queue: Piotr Pawliczek <pawliczek@chromium.org> Reviewed-by:
Sean Kau <skau@chromium.org> Cr-Commit-Position: refs/heads/master@{#761030}
-