- 04 Jun, 2020 40 commits
-
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/c48caaae49d0..4aca9066d548 2020-06-04 mtklein@google.com move #include out of header If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I4556396ec77d989e9267cda0786594ba1df2164f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229918Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774964}
-
chromium-autoroll authored
This CL may cause a small binary size increase, roughly proportional to how long it's been since our last AFDO profile roll. For larger increases (around or exceeding 100KB), please file a bug against gbiv@chromium.org. Additional context: https://crbug.com/805539 Please note that, despite rolling to chrome/android, this profile is used for both Linux and Android. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/afdo-chromium-autoroll Please CC gbiv@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: gbiv@chromium.org Change-Id: If3cec92aae534d6b09b67c77e28faa4c748f9596 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229980Reviewed-by:
-
Adam Rice authored
The following histograms will expire after M85: SafeBrowsing.WebSocket.Elapsed.Blocked SafeBrowsing.WebSocket.Elapsed.Abandoned SafeBrowsing.WebSocket.Elapsed.Safe Remove them. Also remove dead code from WebSocketSBHandshakeThrottle that was only used for metrics collection. Closed: 1089804 Change-Id: Ia49057fbd9d1890f1a2aba7241275383a47f3c76 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226478Reviewed-by:
Varun Khaneja <vakh@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Commit-Queue: Adam Rice <ricea@chromium.org> Cr-Commit-Position: refs/heads/master@{#774962}
-
Dominic Mazzoni authored
Chromium now exports tagged (accessible) PDF files. This design doc explains the details - in a nutshell, when printing to PDF we also generate an accessibility tree, and then use the information from the accessibility tree to add the relevant semantic information to the PDF. https://docs.google.com/document/d/e/2PACX-1vQWAFQw-r5yluBUueyrQLtxMGnJEeq3iTt1FWAtqbm39g2UgcliTWdOFRjMQ4FSbudTh60oIgt2TN3d/pub In order to make this more efficient, this change introduces a new accessibility mode for PDF exporting. This allows us to request only the needed attributes from PDF files, rather than every possible accessibility attribute needed. The accessibility attributes are consumed in printing/common/metafile_utils.cc; you can see that currently we just need the role, name, list attributes, and table attributes, plus the DOM Node ID of each node, which is how we correlate nodes in the accessibility tree with drawing commands in the PDF. Bug: 607777 Change-Id: I900f8ff1b4ccf5e958a80e770fc4d805da101e87 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220253 Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Alice Boxhall <aboxhall@chromium.org> Cr-Commit-Position: refs/heads/master@{#774961}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1591170216-be28c2b4718a2f482f298b7a886d3f3e5fe30114.profdata to chrome-win32-master-1591214254-e18b6c29801bc822569148c5ef87c3e9d9cb875d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC jeffyoon@google.com,liaoyuke@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: chrome/try:win-chrome Tbr: jeffyoon@google.com,liaoyuke@google.com Change-Id: I25a6ac0cbe08ed866d0440ce6e568579ab942587 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229268Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/447cd3e6230f..21544ba0beb5 2020-06-03 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision e728aee5..8c883b89 (774589:774827) 2020-06-03 mbonadei@webrtc.org Include correct ABSL_DECLARE_FLAG header. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I496fa8523e3273c320829e1a07e3e822fc686629 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229235Reviewed-by:
-
Johann authored
Replace usage with a call directly to the constructor. Change-Id: I3ab02580039b45d042fe5698481e172542dffeb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226109 Commit-Queue: Johann Koenig <johannkoenig@google.com> Reviewed-by:
Kouhei Ueno <kouhei@chromium.org> Reviewed-by:
Brandon Jones <bajones@chromium.org> Cr-Commit-Position: refs/heads/master@{#774958}
-
chromium-autoroll authored
https://dawn.googlesource.com/dawn.git/+log/0395ca9b6683..62b08f845fb9 2020-06-03 enga@chromium.org Test that vertex attributes can overlap If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/dawn-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:dawn-linux-x64-deps-rel;luci.chromium.try:dawn-mac-x64-deps-rel;luci.chromium.try:dawn-win10-x64-deps-rel;luci.chromium.try:dawn-win10-x86-deps-rel Bug: None Tbr: cwallez@google.com Change-Id: I73e94dffcd3e9147e8d18d7fef0c3096417532d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229277Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I88309576619ef3c43af822e79fe16ba2cdc8a7ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229801Reviewed-by:
-
chrome-release-bot authored
# This is an automated release commit. # Do not revert without consulting chrome-pmo@google.com. NOAUTOREVERT=true TBR=lakpamarthy@chromium.org Change-Id: I844405c3fb1482311831b13dd04f8c15ea5ad776 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229958Reviewed-by:
Chrome Release Bot (LUCI) <chrome-official-brancher@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774955}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/5e0e3b5576a5..10fb08669daa If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC mxcai@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: mxcai@google.com Change-Id: If21692d37d8854eb855342d4c29fd5a4aa65c406 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229230Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#774954}
-
Jinsuk Kim authored
This CL replaces TabModelSelectorTabModelObserver with ActivityTabTabObserver for keeping the current tab up to date. Bug: 966272 Change-Id: I817bdd27cc09b1848574f833820c4d219b0a8b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2215762 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#774953}
-
Francois Doray authored
The Blink Scheduler limits wake ups from throttleable TaskQueues to 1 per second as soon as the page becomes hidden and non-audible. This CL adds a feature to additionally limit the wake up rate to 1 per minute after 5 minutes in background (both values are configurable). Local experiments show that this improves battery life when multiple background tabs are open (see doc linked on the bug). Potential future improvements: - Allow N unthrottled wake ups after a page is backgrounded. Increment the budget of unthrottled wake ups when a page communicates with the user by updating its title/favicon, playing a sound or displaying a notification. This could improve support of Calendar or Reminder apps. - Wait until network is idle before intensively throttling wake ups. The intention is not to throttle pages that are loading. The 5 minutes grace period may already opt-out most loading pages. Bug: 1075553 Change-Id: Id46052276bec3384390b002cc5fd2f501e89670a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2171976 Commit-Queue: François Doray <fdoray@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#774952}
-
Stephen McGruer authored
The h2 server turns itself on by default in wptserve, but we don't support it in blinkpy yet. To avoid quietly grabbing port 9000, pass --no-h2 to wpt for now. Bug: 1090491 Change-Id: Ie326b86dd1305d1173740c85afc8eecded17e277 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229582 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Cr-Commit-Position: refs/heads/master@{#774951}
-
Maggie Cai authored
[Sheriff] Disable flaky test external/wpt/html/semantics/forms/constraints/form-validation-reportValidity.html. This test is flaky in multiple builders. Here is a link to the flaky portal: https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVydQsSBUZsYWtlImpjaHJvbWl1bUBibGlua193ZWJfdGVzdHNAZXh0ZXJuYWwvd3B0L2h0bWwvc2VtYW50aWNzL2Zvcm1zL2NvbnN0cmFpbnRzL2Zvcm0tdmFsaWRhdGlvbi1yZXBvcnRWYWxpZGl0eS5odG1sDA. And it show up in the portal for https://ci.chromium.org/p/chromium/builders/ci/Mac10.13%20Tests%20%28dbg%29/18707. TBR=tkent@chromium.org Bug: 1041973 Change-Id: I2f1e66c40a04baad9db740f81c56febba791ce08 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228304Reviewed-by:
Maggie Cai <mxcai@chromium.org> Commit-Queue: Maggie Cai <mxcai@chromium.org> Cr-Commit-Position: refs/heads/master@{#774950}
-
Daniel Cheng authored
Bug: 1091083 Change-Id: Iffe64da78d65205e5fd6d5edf2283d3c62d16f8d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229779 Commit-Queue: Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Cr-Commit-Position: refs/heads/master@{#774949}
-
Liquan (Max) Gu authored
Before: We had PaymentRequestOptionalTotal flag in runtime-enabled flag, base-feature in components/, base-feature in content/. After: We don't have PaymentRequestOptionalTotal anymore. The original PaymentRequestOptionalTotal flag callers call the DigitalGood flag instead. Change: * Remove unnecessary OptionalTotal flag. Since the CL[1] introduced the PaymentRequestOptionalTotal flag in unnecessary places, this CL removes those unnecessary occurrences. * Merge the PaymentRequestOptionalTotal flag to DigitalGoods flag [1] https://chromium-review.googlesource.com/c/chromium/src/+/2150974 Bug: 1066531 Change-Id: I67ac986442f805bbac156e45cb3353edf658c245 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222909Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#774948}
-
Kenichi Ishibashi authored
This CL replaces ServiceWorkerStorage::GetNewRegistrationId() call with the corresponding mojo method as a preparation for the Storage Service migration. This CL increases the android binary sizes by ~30kb. Most of the increase (~29kb) comes from mojo generated code and there isn't much we can do to reduce them. Introducing the mojo interface is necessary for migrating ServiceWorkerStroage to the storage service. See the design doc [1] for the motivation of the migration and plans. [1] https://docs.google.com/document/d/1hO0WEuoEOgEBlf5nDE3fDjuQY2bV_d5hLtk25iBo0LM/edit?usp=sharing Bug: 1055677 Binary-Size: Size increase is unavoidable (see above) Change-Id: I33e1e72b1da94ae02dfbe2a929895fc36e216e66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2217935 Commit-Queue: Kenichi Ishibashi <bashi@chromium.org> Reviewed-by:
Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774947}
-
Chong Gu authored
Filter tests that are flaky/failing/crashing. Adds ~7 minutes of bot time and run time per build. Bug: 757053 Change-Id: I992a061a2f9cf03bc0026bff4a2a838e1ec84d83 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2228594 Commit-Queue: Chong Gu <chonggu@google.com> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#774946}
-
Chris Hall authored
Mark AXNodeObject::IsDefault as final. Written collaboratively with Aboxhall and Meredithl. Change-Id: I201b2579fde618ab2858442f0ab8da7b88dc68f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227724Reviewed-by:
Meredith Lane <meredithl@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: I45ade222d613b9180ae5ee96b752d744d24aae94 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229667Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/1220c3995354..447cd3e6230f 2020-06-03 mbonadei@webrtc.org Roll chromium_revision 0cd53b97..e728aee5 (770251:774589) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: Idd4011fecd50d9919b95169ca2368e146a3a165a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229273Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/84620d395a4d..e65444f91de0 2020-06-03 brucedawson@chromium.org Fix Python3 bugs in package_from_installed.py If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: agable@chromium.org Change-Id: I8a45c163fbf8f4332257cc93647b122d95868d33 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229274Reviewed-by:
-
Anupam Snigdha authored
While updating the text input state, the VK visibility request was being set unconditionally even if the VK policy was not defined. Added checks to ensure that the VK visibility request is only set when the ExecutionContext is valid and the last request set it to value other than none. Bug: 1088364 Change-Id: Ibb62f906de4df42881028af6791b84b53b34d3c6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2224652Reviewed-by:
Kent Tamura <tkent@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Anupam Snigdha <snianu@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774941}
-
Austin Eng authored
Backend validation layers like Vulkan Validation Layers or Metal or D3D12's debug validation are not always safe to use with ASAN. We already have coverage using the validation layers on non-ASAN bots, so remove it from the Dawn ASAN bots. Bug: dawn:376 Change-Id: I24587a880a15658d91c643fbf40844e04d6abfe4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2219106Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Commit-Queue: Austin Eng <enga@chromium.org> Cr-Commit-Position: refs/heads/master@{#774940}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: Ib782483745e7915a9d3457af9d5ba961e1b89296 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229276Reviewed-by:
-
Evan Stade authored
Move some common boilerplate to WebLayerNotificationBuilder to streamline callsites. Bug: none Change-Id: I4b58778601967c98f801cf32428842c2a11dd912 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2220662Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Evan Stade <estade@chromium.org> Cr-Commit-Position: refs/heads/master@{#774938}
-
Daniel Cheng authored
https://crrev.com/c/2223973 attempted to fix this check to handle UTF-8 encoded files. However, it appears that Python2's open() will sometimes return a bytestring for a file containing UTF-8 encoded text. encode() will then assume the bytestring is encoded using the default 'ascii' encoding, which then explodes upon seeing any byte with a high byte set (e.g. any character that's not representable in 7-bit ASCII). All mojom files in Chrome should be encoded as UTF-8. Since Python 2.7, io.open() has identical functionality to Python 3's open(), so by using that and specifying the encoding argument, the UTF-8 assumption can be explicitly encoded. This makes it safe to unconditionally call encode() to generate a bytestring to pass into the Mojo parser. Bonus: this CL adds some additional gymanstics for exceptions to make it easier to find the parse failure by using six.reraise(). Note: the original issue discussed in the CL description was fixed in a different way by https://crrev.com/c/2225327, which uses codecs.open(). However, Python 3's open() is an alias for io.open(), which has somewhat different behavior from codecs.open(). Change-Id: I86be3c5bc97c78078fe212162eb88e519180c3b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226093Reviewed-by:
Ken Rockot <rockot@google.com> Reviewed-by:
Fergal Daly <fergal@chromium.org> Commit-Queue: Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#774937}
-
Toni Barzic authored
Has shelf layout manager notify the status area widget that the locale has changed, which then forwards the notification to tray items, and unified tray items so they can update any cached strings (e.g. string used for item tooltips). This added pure virtual HandleLocaleChange() method to TrayItemView and TrayBackgroundView to make sure that tray items added in future implement this. BUG=1077147, 1076318, 1076310, 1076302, 1076301 Change-Id: I09ae5b891a383a89eb748cd27f86aab8c461f3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2222949Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Commit-Queue: Toni Baržić <tbarzic@chromium.org> Cr-Commit-Position: refs/heads/master@{#774936}
-
Chris Hamilton authored
This adds dashed links w/ arrows to the graph, indicating opener/openee embedder/embeddee relationships. It also makes pinned nodes visually distinct by changing their stroke color. BUG=1085129 Change-Id: I0bd75a90c83a735b7d56ff2905d7d3d7b7be6e84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227369 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Will Harris <wfh@chromium.org> Reviewed-by:
Joe Mason <joenotcharles@chromium.org> Cr-Commit-Position: refs/heads/master@{#774935}
-
Chris McDonald authored
Use the vendored copy of the `six` library to make this code work across Python versions. Bug: 942720 Change-Id: I4bdb1032ed8e89e733b929eb13ada54efeb3b019 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229335 Commit-Queue: Chris McDonald <cjmcdonald@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@chromium.org> Reviewed-by:
Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#774934}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f80a78602e37..c48caaae49d0 2020-06-03 jlavrova@google.com Fixing crash when some fonts are unresolved 2020-06-03 michaelludwig@google.com Add clipShader with perspective GM 2020-06-03 michaelludwig@google.com Divide by w for sample matrices 2020-06-03 herb@google.com remove SubRun from addGlyphToAtlas 2020-06-03 mtklein@google.com apply SkOpts_skx approach to SkOpts_hsw If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC tdenniston@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: tdenniston@google.com Change-Id: I2ee3f9079367dc9b4685506f4c5b3f8591726969 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229226Reviewed-by:
-
Brian Sheedy authored
Temporarily disables the GPU watchdog on GPU Telemetry tests on CrOS. It is suspected that the watchdog is causing general test flakiness on CrOS, so it is being disabled for ~1 day to see if there's any noticeable impact on flakiness. Bug: 1090071 Change-Id: I13936e94798bcd71e024bf761246ed330ec5444c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229436 Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kenneth Russell <kbr@chromium.org> Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#774932}
-
Mustafa Emre Acer authored
Pasting on a page with a delayed warning is risky as it can leak credentials (e.g. passwords in the clipboard). This CL immediately shows the interstitial when it detects a paste on the current page. Bug: 1089722 Change-Id: Ia20f0bd6d9fd197ab1dad3e13344ba9e8f876ef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2225462 Commit-Queue: Mustafa Emre Acer <meacer@chromium.org> Reviewed-by:
-
Jia authored
This cl adds a penalty factor to SequenceMatcher so that we can penalize lots of short matching blocks. This cl also update search parameters. Bug: 1081584,1090181,1090154,1090148 Change-Id: Idd35ddd7cfbcdb3928e4b966f2ec757d0b75296c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2227721 Commit-Queue: Jia Meng <jiameng@chromium.org> Reviewed-by:
Thanh Nguyen <thanhdng@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#774930}
-
Bruce Dawson authored
The results of some PDF to EMF tests change slightly when building with the Windows 10.0.19041.0 SDK. The changes are all in the sixth digit after the decimal place (all changing a 3 to a 2 oddly) and are therefore near the limits of float precision and are assumed to not be important. This change adds new expected-result files and uses them when building with the new SDK. See crrev.com/c/2225224 for the proof-of-concept that this fixes some of the SDK issues. Bug: 1089996 Change-Id: Ic35bb6d01138cf96de0639c04627a8a9bc325b01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229643Reviewed-by:
-
Lorne Mitchell authored
dwpa: Modified PendingAppInstallTask to use a constructor provided InstallManager to support it as a test fixture. Previously PendingAppInstallTask::ContinueWebAppInstall fetched the InstallManager via the WebAppProvider via the profile. This change passes the InstallManager via the constructor and avoids this lookup. auto* provider = WebAppProviderBase::GetProviderBase(profile_); provider->install_manager().InstallWebAppWithParams( There will be a follow up CL where the system_web_app_manager_unittest.cc tests are refactored. This change to the pending_app_install_task is needed for the refactor. Bug: 1082880 Change-Id: I038f0005325c77742d15ef3d5e1673903fdf7490 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229013Reviewed-by:
Alexey Baskakov <loyso@chromium.org> Commit-Queue: Lorne Mitchell <lomitch@microsoft.com> Cr-Commit-Position: refs/heads/master@{#774928}
-
Zhenyao Mo authored
This is for GLImageMemory's optimization path. BUG=1087047 TEST=manual R=kbr@chromium.org,khushalsagar@chromium.org Change-Id: I82d3ceeac36644f95e3a52b2a943c4ecaeb651d7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226926Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Reviewed-by:
-
Nate Chapin authored
Bug: 1090561 Test: html/semantics/scripting-1/the-template-element/template-element/template-content-in-inactive-document-crash.html Test: html/semantics/scripting-1/the-template-element/template-element/template-content-move-to-inactive-document-crash.html Change-Id: Idfdc343b177fcd81b208d98b0f66799abee5e4d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2229368 Commit-Queue: Nate Chapin <japhet@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Nate Chapin <japhet@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#774926}
-
Rachel Wong authored
These are some small modifications to allow for a new privacy notice to be added cleanly. Bug: 1079169 Change-Id: I60d4a8c7754f2573055e16990ae524876378eb0a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2226101Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Tao Wu <wutao@chromium.org> Commit-Queue: Rachel Wong <wrong@chromium.org> Cr-Commit-Position: refs/heads/master@{#774925}
-
