- 25 Aug, 2020 40 commits
-
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/41db2fb64914..ff77947e7ecc 2020-08-25 aninditaghosh@google.com tp: Bind httpd to IPv6 address. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:163312367,chromium:163312727,chromium:164038530 Tbr: perfetto-bugs@google.com Change-Id: Idc8161357d2dfa582f8646334cf9c1af99acee66 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375710Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801492}
-
Sky Malice authored
Previously FirstRunAppRestrictionInfo had a static instance that callers used. Because it could be long lived, it meant that it also listened for changes to the device. This API for changes exposed our problems, because it would crash when trying to stop listening for changes if it never started listening. The reason for the incorrect listening is that the FirstRunActivity was destroying/stopping listening. But it was possible for two separate ChromeIntentDispatcher/FirstRunActivity pairs to be calling into it. And so the first FirstRunActivity would shutdown before the second was done starting up. This had the potential to cause subsequent problems if we just guarded against the crash. So instead of having a long lived static instance, we now have a temporary that ChromeIntentDispatcher starts, and then FirstRunActivity takes strong ownership over. This fixes the fundamental problem of the two FirstRunActivities destroying the FirstRunAppRestrictionInfo that the other activity is using. However, it comes to a slight performance hit when there are two FirstRunActivities present. Because this is an edge case, having safe code seems more important than performance. Since FirstRunAppRestrictionInfo is currently not long lived, it doesn't really warrant actually listening for changes on the device. Removed the listening code for simplicity. Bug: 1119548 Change-Id: I2dea7b20222c2d433e5db0410bb96607298db5e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371642Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Wenyu Fu <wenyufu@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#801491}
-
chromium-autoroll authored
Roll ChromeOS Airmont AFDO profile from 86-4183.74-1598264968-benchmark-86.0.4240.3-r1 to 86-4183.74-1598264968-benchmark-86.0.4240.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-airmont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: I3e542fedc7b837d636f2d5921b010c9ac1f312e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375712Reviewed-by:
-
Jazz Xu authored
This CL adds MediaNotificationProvider and MediaNotificationProviderObserver interface serve as a connection between ash and browser. Which will be used to send MediaNotificationListViews and media session info from browser to ash. Bug: 1111420 Change-Id: I276ff5d10642450ab392096c0a6db7c00a1c1c41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315092Reviewed-by:
Tommy Steimel <steimel@chromium.org> Reviewed-by:
Tim Song <tengs@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Jazz Xu <jazzhsu@chromium.org> Cr-Commit-Position: refs/heads/master@{#801489}
-
Dylan Cutler authored
Bug: 973801 Change-Id: I1d19acc974abf0fdad068296339d719c51b6b129 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368466 Commit-Queue: Dylan Cutler <dylancutler@google.com> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Asanka Herath <asanka@chromium.org> Cr-Commit-Position: refs/heads/master@{#801488}
-
Leonid Baraz authored
The bug assigned incorrect first seq number when StorageQueue consisted of multifile files. Also, fixed incorrect setting of StorageQueue options in the test, and added a new test that democased the failure. Bug: b:165851833 Change-Id: I6bfcb96eada2b8a47e2a10ca711ba414e8de61d1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373426Reviewed-by:
Zach Trudo <zatrudo@google.com> Commit-Queue: Zach Trudo <zatrudo@google.com> Auto-Submit: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#801487}
-
Christian Biesinger authored
The -17 test started failing because this does not support the automatic minimum size yet. R=ikilpatrick@chromium.org Bug: 1083010 Change-Id: I8dbbf26021529faef9a16f85322914dcab9cafcb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369420 Auto-Submit: Christian Biesinger <cbiesinger@chromium.org> Commit-Queue: Ian Kilpatrick <ikilpatrick@chromium.org> Reviewed-by:
Ian Kilpatrick <ikilpatrick@chromium.org> Cr-Commit-Position: refs/heads/master@{#801486}
-
chromium-autoroll authored
Roll ChromeOS Silvermont AFDO profile from 86-4183.74-1598267562-benchmark-86.0.4240.3-r1 to 86-4183.74-1598267562-benchmark-86.0.4240.6-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-afdo-silvermont-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: c-compiler-chrome@google.com Change-Id: Ide2b8f85be51ee2fc3796d255085cc88148e943c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375714Reviewed-by:
-
Mohamed Amir Yosef authored
Change-Id: Ifc007754b08fad94f9e433311d7f84bae571e6b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374450Reviewed-by:
John Wu <jzw@chromium.org> Reviewed-by:
Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Cr-Commit-Position: refs/heads/master@{#801484}
-
Stephen Nusko authored
ASYNC events are deprecated and unsupported in the new perfetto UI. This migration ensures they continue to show up properly and are supported in the new UI. Change-Id: If74d889209021f68f23615dc36b1962951ef0ca2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375333Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
Etienne Bergeron <etienneb@chromium.org> Commit-Queue: Stephen Nusko <nuskos@chromium.org> Commit-Queue: Etienne Bergeron <etienneb@chromium.org> Auto-Submit: Stephen Nusko <nuskos@chromium.org> Cr-Commit-Position: refs/heads/master@{#801483}
-
Charlie Hu authored
Change-Id: Ic4e644e9cb27572eb67d49ab182e4897ea8fee77 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363294 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Dmitry Gozman <dgozman@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#801482}
-
Xiaocheng Hu authored
[Sheriff] Disable LayerTreeHostTestAbortedCommitDoesntStallSynchronousCompositor.RunMultiThread_DelegatingRenderer Bug: 1121690 Change-Id: I7abee836e9c64300938cb991e0b73caf3f9f5461 NoTry: True Tbr: wangxianzhu@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375893Reviewed-by:
Xiaocheng Hu <xiaochengh@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#801481}
-
Aleks Totic authored
Read correct CSS axis when cells are orthogonal. Also, couple of cleanup one-liners to lighten the big patch. Bug: 958381 Change-Id: Ifece05e61f4ed42c6e1965bda1a58034f224d6f0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373272 Commit-Queue: Aleks Totic <atotic@chromium.org> Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Reviewed-by:
-
Nick Burris authored
In crrev.com/c/2254058, AndroidPaymentAppFinder was changed to mark app store payment apps as preferred payment apps. The patch made the assumption that the payment app was valid, which is not necessarily the case, e.g. if the TWA has an invalid app store payment app identifier. This patch checks for the app rather than asserting. Verified fix with the test TWA from the bug. Bug: 1120346 Change-Id: Ibd3f5bcd8f562d46583b1e580a3fc997d848c58f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2369255Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Commit-Queue: Nick Burris <nburris@chromium.org> Cr-Commit-Position: refs/heads/master@{#801479}
-
Anders Hartvoll Ruud authored
Currently we are creating a new ScrollTimeline for every frame, even for is_animation_style_change==true, in which case we don't even look at the 'timeline' variable. This CL moves the timeline computation to the branch handling new animations, such that we don't waste time by creating timelines that are never used. Bug: 1074052 Change-Id: If9327fa9dbc97666aae3377cc8b22deb95382932 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374448 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#801478}
-
Alex Ilin authored
Standard context menu options aren't available in profile picker web contents. For example, "View page source" and "Inspect" don't work at all in the system profile. This change also helps fix the bug when the profile picker window closes after dismissing the context menu (I don't know what's the cause of this though). Bug: 1121543, 1121541 Change-Id: Iad91145481c8b5d8184f0bf600cea5a8a39f158c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374451Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#801477}
-
Koji Ishii authored
|emphasis_mark_height| could be zero if `font-size` is zero, but the DCHECK did not include the case. Bug: 1105882 Change-Id: Ia5665778ecb2d396d156c6b6e2e8a2f69151889e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374918 Auto-Submit: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Garrett Beaty authored
Macs all have SSDs, so generating ssd:0 for builderless mac builders forces the definition to also specify ssd=None. Change-Id: I61b09dab79e9ec37867c6d24c39982f360083a5d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2368322Reviewed-by:
Stephen Martinis <martiniss@chromium.org> Commit-Queue: Garrett Beaty <gbeaty@chromium.org> Cr-Commit-Position: refs/heads/master@{#801475}
-
Alex Chau authored
- Moved check for active profile into InvalidateSurfaceState, so send/receive surface can still be registered without profile being active - OnNearbyProcessStopped will InvalidateSurfaceState to potentially restart the flow if profile is still active Bug: 1120087 Change-Id: I40cc43949a46808d2c090c1681d34e0450f62fd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375289 Commit-Queue: Alex Chau <alexchau@chromium.org> Reviewed-by:
Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801474}
-
Nohemi Fernandez authored
The spinner causes EarlGrey to crash following 'infinite' page wait. Bug: 1116650 Change-Id: I20c808dfe77115ba10ba2da5ea06d60688bf76da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375173 Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Auto-Submit: Nohemi Fernandez <fernandex@chromium.org> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#801473}
-
Thomas Lukaszewicz authored
Currently NativeViewHost applies a masking path to the NativeView's layer to achieve the rounded corners effect. Tbis CL updates the API to use gfx::RoundedCornersF and uses the rounded corners layer fast path for Aura platforms. Bug: None Change-Id: I038d7b01f315e930cd2577d1c6b4f5dc7f6ca5c7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2371309Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Thomas Lukaszewicz <tluk@chromium.org> Cr-Commit-Position: refs/heads/master@{#801472}
-
Xiaocheng Hu authored
Bug: 964333 Change-Id: I4388432ab6651ef64fa9fcd6b23e687069e6979c NoTry: True Tbr: apotapchuk@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375934Reviewed-by:
-
Peter Boström authored
This tears down DialogModel by through model_.reset() to simulate dialog closing being synchronous. This gives simpler lifetimes for client code as a synchronous delete is more predictable than an asynchronous task from GetWidget()->Close() on its own which is asynchronous. Note that from an implementation perspective the Widget teardown is not synchronous, but this should not be a concern of DialogModel client code. Bug: 1106422 Change-Id: Ib35ec2389e78459ae98a4f901a35858a7fe97189 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372929Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Lei Zhang authored
In https://crrev.com/651373, the package_exists() implementation changed but the comment did not reflect this change. Change-Id: Ic13e7a3cef28a980ebd167af1bab31006bbf5b59 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375928Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#801469}
-
Muyao Xu authored
MediaRouterViewsUI is not dependent on ui/views/view.h and can be moved to c/b/u/ directory. Also renamed the class to MediaRouterUI. Bug: 1116045 Change-Id: I222f5b194b7e707602feb53221ba9e6ec8b35a8f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354414 Commit-Queue: Muyao Xu <muyaoxu@google.com> Reviewed-by:
-
RJ Ascani authored
The FuchsiaCdmManager needs a FilePath to write CDM user data to. The Fuchsia ContextProvider receives the persistent directory via the CreateContextParams::cdm_data_directory field. This CL takes the cdm_data_directory and mounts it to /cdm_data. This path is provided to the FuchsiaCdmManager, which does not use it yet. Bug: 991723, b/162078899 Change-Id: I8c6ba6236deb936f743fb70a7f22779e0d3802c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330811 Commit-Queue: RJ Ascani <rjascani@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#801467}
-
Vladimir Levin authored
This patch removes ScheduleAnimation calls from lock/unlock. These are not required because we invalidate paint anyway so the lifecycle will already happen. Either that or we are already in the lifecycle when we determine that we need to lock. R=chrishtr@chromium.org, szager@chromium.org Change-Id: I1284b435882e2365f75b1b8baaf79fab8713ba99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375069Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Reviewed-by:
Stefan Zager <szager@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#801466}
-
Weilun Shi authored
Fix a typo in PRESUBMIT.py and sort th |HISTOGRAMS_XMLS_RELATIVE| because different OSes have different file system which introduces non-deterministic into the output of _FindHistogramsXmlFiles() . Bug: 1116807 Change-Id: I8ff36de29464d388f012864155028a77fdb44e6b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372775Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#801465}
-
Koji Ishii authored
This test once timed out if LayoutNG and VizDisplayCompositor were enabled. This seems to pass on the current bot. This patch tries to reenable. Bug: 959261 Change-Id: I818fcc015f9e6254fa7f8c17588d6406efeabe67 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354375Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#801464}
-
chromium-internal-autoroll authored
Release_Notes:http://go/help_app-x20/relnotes/Nightly/help_app_nightly_202008250800_RC00.html https://chrome-infra-packages.appspot.com/p/chromeos_internal/apps/help_app/app/+/q7fJGoUZfsUaMt-ae3SViUsR1NdBaXcLVuaNOAI_8CMC If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/help-app-chromium-autoroll Please CC help-app@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: help-app@grotations.appspotmail.com Change-Id: I81f2aca91d47a911af36225de7e3ec04b10ae617 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375446Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#801463}
-
Alexander Cooper authored
Now that the OpenXR runtime has been shipped for a while, and WMR has been updated to interface with OpenXR in a frictionless manner, we would like to unify OpenXR as the single runtime that supports WebXR. Given that WMR support has shipped, rather than delete the runtime immediately, we will first disable it, and see if any issues arise. However, given that almost all WebXR sessions on desktop go through OpenXR, we don't expect any issues. Bug:1121624 Change-Id: I2276f8a5a5954e09276a44b2cfcaf8ad10747100 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373393Reviewed-by:
Brandon Jones <bajones@chromium.org> Reviewed-by:
Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#801462}
-
Victor Vianna authored
Fix style consistency in the file. Change-Id: Ib43e942e8acc3a551c9f224a791ef641b55b794d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2375425Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Commit-Queue: Victor Vianna <victorvianna@google.com> Cr-Commit-Position: refs/heads/master@{#801461}
-
Ana SollanoKim authored
A fieldset-specific regression was introduced by the following change https://chromium-review.googlesource.com/c/chromium/src/+/2263353. This change fixes the bug crbug.com/1097012, addressing now all the TODOs that were added as a result of this issue. Because the padding of the fieldset's content is applied to the anonymous fieldset content box rather than the fieldset itself, we don't want to directly subtract the block-end padding from the fieldset in the finish fragmentation function. For this reason, we're only passing the border so that when subtracting to get the final block size, we're not mistakenly eliminating the padding as well. The minimum border box block size was not being calculated in every case due to legends not fragmenting, thus resulting in missing padding and border for some fragments. Additional conditions were added to allow that calculation when needed. Bug: 1097012 Change-Id: I8e9fd55ae11a14ce83e035a591ab0ec6a7f34261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2373382 Commit-Queue: Ana Sollano Kim <ansollan@microsoft.com> Reviewed-by:
Alison Maher <almaher@microsoft.com> Cr-Commit-Position: refs/heads/master@{#801460}
-
Kyungsun Lee authored
The code in //components/payments has a lot of raw pointers that rely on careful memory management. It would be better to use base::WeakPtr to avoid mistakes. This CL is a part of those changes, which replaces the raw pointer of PaymentRequestState::Delegate with the base::WeakPtr. BUG=1086284 Change-Id: Ieeef4f5be886d78fce7f3f28cbb902691f1aa341 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2364380Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Commit-Queue: Rouslan Solomakhin <rouslan@chromium.org> Cr-Commit-Position: refs/heads/master@{#801459}
-
John Delaney authored
What: Move base::PathExists() check for database file to the storage task runner. Because ConversionStorageSql is created on the UI thread, this call blocks startup execution. How: Defer initialization of |db_status| to LazyInit() Fixes the startup regression introduced on https://crrev.com/c/2360471 Bug: 1121307 Change-Id: I3842320f507695643a306cac709aba605b1b276e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2372596 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#801458}
-
Yuki Shiino authored
Supports property installation of IDL operations with enabling V8 Fast API mechanism. This is a preparation of https://crrev.com/c/2315680 . Bug: 1052746 Change-Id: I0f1a4ac0e12f32f2db32f161b3fe65198052a7cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361939 Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#801457}
-
Yu-Hsuan Hsu authored
Add --use-cras flag when it is running on ChromeOS. BUG=b:151905045 Change-Id: I336a928b512fb1489a82c90a7fd1b776107ef0a8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374487 Commit-Queue: Yu-Hsuan Hsu <yuhsuan@chromium.org> Reviewed-by:
Hidehiko Abe <hidehiko@chromium.org> Cr-Commit-Position: refs/heads/master@{#801456}
-
Antonio Gomes authored
This is a follow up of https://crrev.com/c/2360325, that moved the respective files from content/renderer to Blink. Since this class is used in chromecast/, it is not expected that it will be moved out of the Blink API layer any soon. TBR=spang@chromium.org BUG=787252 R=guidou@chromium.org, haraken@chromium.org Change-Id: I5fe091066e03a0e3d147601196bf3a4da7ef056f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363708 Commit-Queue: Antonio Gomes (GMT-4) <tonikitoo@igalia.com> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
-
Gayane Petrosyan authored
When right-clicking on media element, selection is "\n" and associated doc is null. Thats why creating a range with null document in TextFragmentSelectorGenerator results in referenced crash. Fix the issue by creating the range in TextFragmentSelectorGenerator only when data.selected_text was assigned. Bug: 1119309 Change-Id: Ib8a035d6779a3c8636d0ec6e5cf9167a2a9bdaf1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362873 Commit-Queue: Gayane Petrosyan <gayane@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Gayane Petrosyan <gayane@chromium.org> Cr-Commit-Position: refs/heads/master@{#801454}
-
Sammie Quon authored
Test: compositor_unittests LayerWithDelegateTest.Cloning Change-Id: I13496c5e339db87ad2b78f868cf135e53c1f1aed Fixed: 1121302 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2374025Reviewed-by:
Mitsuru Oshima <oshima@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Commit-Queue: Sammie Quon <sammiequon@chromium.org> Cr-Commit-Position: refs/heads/master@{#801453}
-
