- 22 Jan, 2021 40 commits
-
-
Cammie Smith Barnes authored
This CL is part of the Code Health Rotation, and converts base::Bind, base::Callback, and base::Closure to Once/Repeating as the code context dictates. It also replaces 'typedef' with 'using' in several places adjacent to other changes. Bug: 1007635 Change-Id: I90dfca648b536d677cadf74694992fb0d0923d47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630369 Commit-Queue: Cammie Smith Barnes <cammie@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Cr-Commit-Position: refs/heads/master@{#846258}
-
Ryan Heise authored
Bug: chromium:1163679 Change-Id: I7df0737b2c7ab66af29429f6ec8d47cc1b08a45d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644378Reviewed-by:
John Chen <johnchen@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Commit-Queue: Ryan Heise <heiserya@google.com> Cr-Commit-Position: refs/heads/master@{#846257}
-
chrome://appsdpapad authored
Removing not just any dead CSS code, but specifically CSS code that relies on flattenhtml=true. This is part of the effort to remove flattenhtml usages and auto-generate a grd file for chrome://apps. Specifically the elements styled in the dead code (.close-button) were - Added at https://codereview.chromium.org/7124002 and https://codereview.chromium.org/7342017 - Removed athttps://codereview.chromium.org/1129903008 and https://codereview.chromium.org/1753783004/ (~5 years ago). Bug: 1152343,1169733 Change-Id: If05ffdec4d95bee6c9b146dc4a7ac86d2040f135 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643558Reviewed-by:
Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#846256}
-
Mikel Astiz authored
The fake server leverages the recently used authenticator API, syncTrustedVaultKeys, that allows the server to provide sync encryption keys during authentication. This server-side logic triggers only if the client expressed the desire to receive sync trusted vault keys, achieved via newly-introduced URL parameters. Change-Id: I1538d83fd9716fbdc7989d299911368ba346e39b Bug: 1081651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2587171Reviewed-by:
David Roger <droger@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Commit-Queue: Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#846255}
-
Mike Jackson authored
Per UX review, the only planned place to expose Run on OS Login is via the context menu option on a web app listed in chrome://apps list. This change cleans up a code comment indicating it might be surfaced elsewhere in the UI. Bug: 1110407 Change-Id: I43c5987d18ba42081b88eea723a776d556ea839c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633878Reviewed-by:
Chase Phillips <cmp@chromium.org> Commit-Queue: Mike Jackson <mjackson@microsoft.com> Cr-Commit-Position: refs/heads/master@{#846254}
-
Hui Yingst authored
The in-page coordinates from an XYZ named destination sometimes can be out of the range of the PDF's page width and height. This CL preprocesses such out-of-range x and y coordinates before converting them from in-page coordinates to in-screen coordinates. Bug: 1157061 Change-Id: I3279890459188e3856c75478caebefa6bafaa655 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633191 Commit-Queue: Hui Yingst <nigi@chromium.org> Reviewed-by:
dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#846253}
-
Clemens Arbesser authored
The initial url can and often is a redirect to the deeplink, rather than the deeplink itself. That can lead the client to believe that we are triggering on the wrong domain. Bug: b/178082640 Change-Id: Ife02a1acbb17d52042b016501a1eb9abdd01b3f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642787Reviewed-by:
Mathias Carlen <mcarlen@chromium.org> Reviewed-by:
Marian Fechete <marianfe@google.com> Commit-Queue: Clemens Arbesser <arbesser@google.com> Cr-Commit-Position: refs/heads/master@{#846252}
-
Kyle Milka authored
Create base for area selection dialog. Currently just display an empty dialog with the title and two bottom buttons with logic/classes added to control the dialog. Bug: 1153969 Change-Id: I489dc95d198037e57262938bf9f94fc6041dbbff Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2630825Reviewed-by:
Matthew Jones <mdjones@chromium.org> Reviewed-by:
Tanya Gupta <tgupta@chromium.org> Commit-Queue: Kyle Milka <kmilka@chromium.org> Cr-Commit-Position: refs/heads/master@{#846251}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1611316382-261a271ac3191d9a6f726d2f754b45ee0d0f178e.profdata to chrome-win32-master-1611327254-197533b8b85e35cc3db30df56ae54c1d061aca59.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: I40b29a3c3ccd5db365180e300ba481462ce8d2d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645108Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846250}
-
Liviu Tinta authored
When we run web tests with --enable-thread-compositing we have a compositor thread available. The code in web_page_popup_impl.cc assumes all web tests are run single-threaded. In single-threaded web tests, the owner frame tree runs the composite step for the popup. If --enable-thread-compositing is used allow the popup to run the composite step. virtual/scroll-unification/fast/forms/suggestion-picker, virtual/scroll-unification/fast/time Bug: 1144434 TEST: virtual/scroll-unification/fast/forms/select-popup, Change-Id: I969f825fd6fc331f1e1ed682b98b3e18caeb4f5c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2636296 Commit-Queue: Liviu Tinta <liviutinta@chromium.org> Reviewed-by:David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#846249}
-
Avi Drissman authored
If no architectures are specified in the distribution pkg, the installer on M1 Macs will assume the package requires Rosetta and will show a dialog asking to install it. Showing such a dialog prevents the package from being installed unattended or at the login screen. Therefore, include architecture information in the distribution xml. For reference: https://scriptingosx.com/2020/12/platform-support-in-macos-installer-packages-pkg/ Fixed: 1169145 Change-Id: I63e26ede4ec4d583ca090121e91c3c4a5d7ebe04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643167 Commit-Queue: Avi Drissman <avi@chromium.org> Auto-Submit: Avi Drissman <avi@chromium.org> Reviewed-by:
Robert Sesek <rsesek@chromium.org> Cr-Commit-Position: refs/heads/master@{#846248}
-
Nate Fischer authored
This extends two histograms (and changes ownership) and marks two others as obsolete (removing the relevant code). Fixed: 1160837 Test: run_webview_instrumentation_test_apk -f "*Variations*" Change-Id: I97267f2b2c81bebfb5cd8b572f0b0cdb1ecb3d84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639168Reviewed-by:
Shimi Zhang <ctzsm@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#846247}
-
Elly Fong-Jones authored
I missed one part of the test in r846127. Bug: 1101339 Change-Id: I2e0cdc56c31800577baecf2e10cb233ab7311099 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645205Reviewed-by:
Mike Wittman <wittman@chromium.org> Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#846246}
-
rajendrant authored
This CL records the ineligibility for Blink disabling images for subresource redirect. Bug: 1167025 Change-Id: I615fba6989b9fa2bb2d7391e45bd89348992c731 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633097 Commit-Queue: rajendrant <rajendrant@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Auto-Submit: rajendrant <rajendrant@chromium.org> Cr-Commit-Position: refs/heads/master@{#846245}
-
Daniel Hosseinian authored
The PDF Viewer has a password dialog that is prompted to the user before the document loads. However, PDF browser tests run only after the document loads. Alter the EnsurePDFHasLoaded() helper method to also return when the PDF prompts the password dialog. To do so, a 'passwordPrompted' message is sent to the PDF Viewer embedder. Bug: 1167036 Change-Id: I17ae5daa4e6ce51ad1bc402c7d352beadae43256 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639293 Auto-Submit: Daniel Hosseinian <dhoss@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Reviewed-by:
Tom Sepez <tsepez@chromium.org> Commit-Queue: Daniel Hosseinian <dhoss@chromium.org> Cr-Commit-Position: refs/heads/master@{#846244}
-
Salvador Guerrero authored
This CL modifies the trace events logged in components/content_settings to used the new API with typed arguments. Change-Id: I20f64bb9cefaef739651f12fbaa1f6340ae9c25d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2627938Reviewed-by:
Balazs Engedy <engedy@chromium.org> Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: Salvador Guerrero <salg@google.com> Cr-Commit-Position: refs/heads/master@{#846243}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/361ccce1243f..5397151e88ff 2021-01-22 ehmaldonado@google.com Add whitespace.txt If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: None Tbr: ehmaldonado@google.com,sokcevic@google.com,ajp@google.com,apolito@google.com Change-Id: I24d72e9ec0dd7b6a76db324f693372504b5e68cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643345Reviewed-by:
-
Eric Seckler authored
Follow-up to crrev.com/c/2644798. The symbol also needs to be exported and defined in a .cc. Bug: 1168791 Change-Id: I0c7308bfe24846381d3dcad00e8d76f337909634 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645005Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#846241}
-
Curt Clemens authored
The following strings are updated: * Contact visibility page "Hidden" description * Onboarding page subtitle * Discovery page help text Fixed: 1168268, 1168262, 1168271 Change-Id: I3efb9d454b539ffdb869bc58138f514d0d26ccdf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643463Reviewed-by:
James Vecore <vecore@google.com> Commit-Queue: Curt Clemens <cclem@google.com> Cr-Commit-Position: refs/heads/master@{#846240}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/28c13893f937..1dbdce5fbbcb 2021-01-22 jacktfranklin@chromium.org Improves render performance of DataGrid If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1169021 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ibcf36678974bae6541e0d0549f88ffa53714d2e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645054Reviewed-by:
-
Shimi Zhang authored
Android framework (TextView) uses SuggestionSpan.SUGGESTION_MAX_SIZE, we should match the behavior in WebView and Chrome. See https://cs.android.com/android/platform/superproject/+/master:frameworks/base/core/java/android/widget/SpellChecker.java;drc=401e3d4c842ce86569de4477138137dc07a6aa6f;l=318 Bug: b/177876412 Change-Id: I0583668645c953629b793b901e1b467058df2535 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644318Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#846238}
-
Katie Dektar authored
As requested by PgM and TLM. AX-Relnotes: N/A Bug: 1121204, 1160728 Change-Id: I47c20f62c2ea236d37f2a2537d659fc200069eb9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638007Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Reviewed-by:
-
Dave Tapuska authored
Move ZoomToFindInPageRect and get rid of the WebRect usage. BUG=738465 Change-Id: I50802f600b80d28694eac1538e22cc001021f6a1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641120 Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Cr-Commit-Position: refs/heads/master@{#846236}
-
Guohui Deng authored
Bug: internal b/166313191 Test: None Change-Id: I2d9c60c33a9076f73140a2b6181820ec2382c3b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643401Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Guohui Deng <guohuideng@chromium.org> Cr-Commit-Position: refs/heads/master@{#846235}
-
Yusuke Sato authored
This CL depends on https://chromium-review.googlesource.com/c/chromiumos/platform2/+/2611416 BUG=chromium:1163122 TEST=tast run arc.Boot[.vm] Change-Id: I84a2f6c3a818877abba54cce15106a670386b1e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2613917 Commit-Queue: Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Yury Khmel <khmel@chromium.org> Cr-Commit-Position: refs/heads/master@{#846234}
-
Monica Basta authored
The tooltip is only useful when the profile name or the gaia name is long enough to be truncated. This CL also fixes the flickering of the profile card container and profile card cursor at the bottom of the card due to the gaia name tooltip. Fixed: 1169169 Change-Id: I106cde6aff8e26b895af6293e73776f45732ea6f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2642371Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Commit-Queue: Monica Basta <msalama@chromium.org> Cr-Commit-Position: refs/heads/master@{#846233}
-
Xiaoqian Dai authored
Rename |restore_focus_window_| to |active_window_before_overview_| to better match the code. The active window might not be the same window as the focused window, but by activating the right window, the focus will be restored properly as well. Pure renaming. No functional change. Bug: None Change-Id: I67250ce1fd5a48cf817ec04ef4f59de0ab83c38d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644348Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Commit-Queue: Xiaoqian Dai <xdai@chromium.org> Cr-Commit-Position: refs/heads/master@{#846232}
-
Oriol Brufau authored
r834202 changed MutableCSSPropertyValueSet::SetProperty so that, when changing the value of a property that belongs to a logical property group, which is followed by a property in the same logical property group but opposite mapping logic, the changed property is moved to the end, to ensure it takes precedence. However, this regressed the CSSPropertyUpdateValue perf test. This patch adds a may_have_logical_properties_ flag. When false, it means the MutableCSSPropertyValueSet has no logical property, so we can skip the extra work added in r834202. Bug: 1156321 Change-Id: I4ab6d92cf51126bcab16ffa9635bf91c98d6f738 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2640097Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Commit-Queue: Oriol Brufau <obrufau@igalia.com> Cr-Commit-Position: refs/heads/master@{#846231}
-
Wei Li authored
A type converter for unique_ptr type should be able to accept a getter which returns the raw pointer type. This CL adds such support. Also it adds such a property in ToggleImageButton class as an example. Bug: 1168309 Change-Id: I49488d475cd70a7441f4f7e5918929c8e5b35638 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2639655Reviewed-by:
Peter Kasting <pkasting@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Wei Li <weili@chromium.org> Cr-Commit-Position: refs/heads/master@{#846230}
-
Henrique Nakashima authored
This reverts commit b6f59baa. Reason for revert: https://ci.chromium.org/p/chrome/builders/ci/lorenz-graph-dbg: No such file or directory: 'dirmd' Original change's description: > [Android] Read DIR_METADATA in getowners.py > > The getowners.py script periodically reads OWNERS files and git history > and generates per-module data to be surfaced in go/clank- > > OWNERS files do not contain Monorail component, Team and OS information > anymore, DIR_METADATA files have replaced them and broken the script > since then. > > Bug: 1135347 > Change-Id: Ib88e9d576d94ad5484b6a3dbbfff156639275dea > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2634833 > Reviewed-by: Peter Wen <wnwen@chromium.org> > Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> > Cr-Commit-Position: refs/heads/master@{#845754} TBR=wnwen@chromium.org,hnakashima@chromium.org,chromium-scoped@luci-project-accounts.iam.gserviceaccount.com Change-Id: I5c1afaa0f5846f22db9e59fbc42438cca9aae68d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1135347 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644528Reviewed-by:
Henrique Nakashima <hnakashima@chromium.org> Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Cr-Commit-Position: refs/heads/master@{#846229}
-
Egor Pasko authored
Seems that Cronet may be still supporting ICS, but these removed parts should not be needed to Cronet. Bug: 1041930 Change-Id: I3ae0cd53ab410401d6318d9f2ac8f6ba6145f25f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2633054 Commit-Queue: Egor Pasko <pasko@chromium.org> Reviewed-by:
Tommy Nyquist <nyquist@chromium.org> Cr-Commit-Position: refs/heads/master@{#846228}
-
Min Qin authored
Finch config change: cl/352943943 This CL also cleans up some testing configs, leaving only the one that are most likely to be launched. Change-Id: I9da17f9838b9d666cdd2f6f8993c3a189cc5ca38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2641812Reviewed-by:
Weilun Shi <sweilun@chromium.org> Commit-Queue: Min Qin <qinmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#846227}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9c81656e14af..bf47f1bdf381 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC nsatragno@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: nsatragno@google.com Change-Id: I8d5e7526089cd7c5e512c1bc41ee3d554f1aaf91 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2645107Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#846226}
-
Scott Violet authored
This reverts commit 495dcf2f. Reason for revert: see https://bugs.chromium.org/p/chromium/issues/detail?id=1169201 . Original change's description: > Android: cleanup of transition types > > This removes adding the qualifier PageTransition.FROM_API for > TabLaunchTypes of FROM_LINK and FROM_RESTORE. I believe this was > unintentional, and doesn't make sense to use FROM_API with. > > This also removes FROM_API for intents that came from chrome and > launched chrome. Again, seems like we shouldn't use FROM_API for > this scenario either. > > I came across this while doing the other patches. AFAIK nothing > depends upon this, just seems worth cleaning up. > > BUG=none > TEST=none > > Change-Id: Id89fbc0e70fb52a662ac33a55d269460677ee152 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2511853 > Commit-Queue: Scott Violet <sky@chromium.org> > Reviewed-by: Ted Choc <tedchoc@chromium.org> > Reviewed-by: Michael Thiessen <mthiesse@chromium.org> > Cr-Commit-Position: refs/heads/master@{#823388} TBR=sky@chromium.org,mthiesse@chromium.org,tedchoc@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1169201 Change-Id: Idff0c0063f22b7290c37be33062d34eeb6572199 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644148Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#846225}
-
dpapad authored
Previously it was implemented as an iron-icon-button + paper-ripple inside a <a> element, which was problematic (infinite ripples showing when holding down the enter key). By leveraging cr-icon-button the bug above is fixed. As a side effect the focus indicator changes from an outline to a ripple, which will change back once cr-icon-button itself will transition from ripples to outlines for focus (soon). Fixed: 1167155 Change-Id: Ic899c251b3c56bf7b73fcde8682afa73b9918730 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644461 Commit-Queue: John Lee <johntlee@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Reviewed-by:
John Lee <johntlee@chromium.org> Cr-Commit-Position: refs/heads/master@{#846224}
-
Trevor Perrier authored
This CL adds metrics for new user actions on the LanguageSettings page. The actions that are added are: - Chrome Language - Target Language It also adds the following PageImpressions for the LanguageSettings: - Chrome Language - Advanced Language Settings - Target Language Additionally, the "Click on the 'Add Language' button" value is no longer recorded on Android since it does not modify language preferences and the same metric is in PageImpressions. Bug: 1127531 Change-Id: I92fc0e50cab7683c21387eb263a031e1777dfdf2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2638077Reviewed-by:
Josh Simmons <jds@google.com> Reviewed-by:
Megan Jablonski <megjablon@chromium.org> Commit-Queue: Trevor Perrier <perrier@chromium.org> Cr-Commit-Position: refs/heads/master@{#846223}
-
David Black authored
Previously was 24%. Spec calls for 30%. Bug: 1169320 Change-Id: I793520a07de8fb706e7d5a73ceff0d20e05ebcd5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643360Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Commit-Queue: David Black <dmblack@google.com> Cr-Commit-Position: refs/heads/master@{#846222}
-
Nektarios Paisios authored
Made AXNode::IsDescendantOf work the same across BrowserAccessibility, AXPlatformNodeBase and AXNode An inconsistency in the behavior of this method that I found while merging BrowserAccessibilityPosition and AXNodePosition. AX-Relnotes: n/a. R=dmazzoni@chromium.org, aleventhal@chromium.org Change-Id: I34ce5d10bc67a7b78438e94a4a9c4b6c21fd5bc9 Bug: 1049261 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644620Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Nektarios Paisios <nektar@chromium.org> Auto-Submit: Nektarios Paisios <nektar@chromium.org> Cr-Commit-Position: refs/heads/master@{#846221}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/5b2a5204087d..57144c8685d3 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-linux-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: Iee8dd2bd50bbcf52f52e64307d29c4960bf32d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2644822Reviewed-by:
-
Pete Williamson authored
Bug: 1160725 Change-Id: I5f90794fbeadc3799c40b87388f46e7ba8221c53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2643701Reviewed-by:
Carlos Knippschild <carlosk@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Commit-Queue: Peter Williamson <petewil@chromium.org> Cr-Commit-Position: refs/heads/master@{#846219}
-
