- 14 Aug, 2020 40 commits
-
-
Tommy Li authored
Originally, we added an on-clobber entrypoint to ZeroSuggest guarded by a feature flag which applied to all page classifications. On further thought, it seems best to make this feature flag apply to the Contextual Web (OTHER) page classification only, as different page classifications may have different UI entrypoints to ZeroSuggest. Bug: 1106096 Change-Id: I376e0b22d1b23d202e729d7a133920d94d9708e4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357209Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Commit-Queue: Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#798330}
-
Robert Ogden authored
This client warms up a renderer when a cross-origin navigation is likely. This is the first CL and just makes the classes, boilerplate, and some other common checks. Reference https://chromium-review.googlesource.com/c/chromium/src/+/2350145 for what the whole impl will look like. Bug: 1115259 Change-Id: I54996eaa7ed0edd5a8521dd4fffcbb4a3c2ecd04 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350238Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#798329}
-
Ryan Keane authored
This CL adds 4 new timing metrics to independently track the timing for each cast streaming type. Bug: b/162771649 Change-Id: Iee98037885921a5a315572574d0d790ee461c11c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2337417 Commit-Queue: Ryan Keane <rwkeane@google.com> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Takumi Fujimoto <takumif@chromium.org> Cr-Commit-Position: refs/heads/master@{#798328}
-
Steven Bennetts authored
BUG=1103272 Change-Id: I9e07c2e8b1457d41a5934b60f9eaf5273e67e6da Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2319341 Commit-Queue: Steven Bennetts <stevenjb@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#798327}
-
Lei Zhang authored
In LoadingPredictorPrefetchBrowserTestWithBlockedLocalRequest, the PrepareForPageLoadWithPredictionForPrefetch test case is flaky. Bug: 1116599 Change-Id: I74e232f5628e3d412fa3239c8aca68435e27404b Tbr: falken@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357931Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798326}
-
Sebastien Lalancette authored
These histograms have been recently added to the codebase, and are now being added to histograms.xml to allow us to see them in UMA. These histograms are ultimately being logged inside: activity_service_histograms.mm Bug: 1093302 Change-Id: Ifa77dac2f9585b2efca70822c7c6ff05b239bbb5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352912Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sebastien Lalancette <seblalancette@chromium.org> Cr-Commit-Position: refs/heads/master@{#798325}
-
Philip Jägenstedt authored
Bug: 1116105 Change-Id: I94ee08f6ca2d53523c5a9482a779f6c45f43a15c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2352740 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#798324}
-
Orin Jaworski authored
This CL adds a single language data set to serve as a minimal example of how to cover all aspects including JSON data, header, unit tests, etc. Bug: 893183 Change-Id: Iee33b87dbb331946652c64dbf9c1714c1c8879f5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347972Reviewed-by:
Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Commit-Queue: Orin Jaworski <orinj@chromium.org> Auto-Submit: Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#798323}
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-aemu-chromium-autoroll Please CC chonggu@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: chonggu@google.com Change-Id: Icf1145cf9360e8db97a08663e58bfa7a59599bfa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357416Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798322}
-
Krishna Govind authored
TBR=benmason@chromium.org Change-Id: Ic44c1d6a64e3321eefdb666d746701f659d81acf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357950Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Krishna Govind <govind@chromium.org> Cr-Commit-Position: refs/heads/master@{#798321}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/b5bfc190..dca46604 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,vahl@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iaba69bb289303d233231f2a5c012aa940033499f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357309Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798320}
-
Tibor Goldschwendt authored
This is now the preferred enum constant format. Change-Id: Ia6435efd9b3a2d35dac4624b1337628b9fa2c3ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357949 Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> Commit-Queue: Alex Gough <ajgo@chromium.org> Auto-Submit: Tibor Goldschwendt <tiborg@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Cr-Commit-Position: refs/heads/master@{#798319}
-
Joel Hockey authored
Bug: 1113207 Change-Id: Ifab4a2be4c22765ed0a6ab54eaba58228636d201 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355353Reviewed-by:
Steven Bennetts <stevenjb@chromium.org> Commit-Queue: Joel Hockey <joelhockey@chromium.org> Cr-Commit-Position: refs/heads/master@{#798318}
-
Daniel Classon authored
Add deep linking to the internet page, internet subpage, internet detail page, and internet known networks page. Adds several element getters to shared cr-components. Adds a method to Deep Linking Behavior to show deep link by element rather than by setting ID. Bug: 1084154 Change-Id: I8d26e1aa351b5a00df196c1710d8c337d6892cdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2330008 Commit-Queue: Daniel Classon <dclasson@google.com> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Reviewed-by:
Regan Hsu <hsuregan@chromium.org> Cr-Commit-Position: refs/heads/master@{#798317}
-
John Z Wu authored
This will allow ios/web_view to provide password suggestions that match the site's requirements. Bug: 1022906 Change-Id: Ic7f36a926797df6803f3584f4d55050e4085c636 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343674 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#798316}
-
Lei Zhang authored
PaymentRequestShowPromiseTest.UnsupportedPaymentMethod is flaky. Bug: 1116607 Change-Id: I0dc2d92a09e3bf3ed94bfe69b34a949fac36cbbf Tbr: rouslan@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357753Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798315}
-
William Lin authored
Previously, the documentation for the scopes parameter was lacking and the callback parameter name did not fully reflect its purpose. This CL renames the parameter to be more descriptive and adds additional documentation. Bug: 1100535 Change-Id: I6001d36a7701c6484f318fb6e983f1ef933da14f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354525Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: William Lin <williamlin@google.com> Cr-Commit-Position: refs/heads/master@{#798314}
-
Thiemo Nagel authored
Add histogram definition for Network.Shill.WiFi.HiddenSSIDNetworkCount. BUG=b:163168922 Change-Id: I9d4bfed4e7ca69b50276cad2ff473d6452372579 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2351969 Auto-Submit: Thiemo Nagel <tnagel@chromium.org> Commit-Queue: Mark Pearson <mpearson@chromium.org> Reviewed-by:
Mark Pearson <mpearson@chromium.org> Cr-Commit-Position: refs/heads/master@{#798313}
-
Klaus Weidner authored
For same-process iframes, propagate the Document-level IsXrOverlay flag, and use the correct element as the overlay layer. This moves the document->SetIsXrOverlay setters from xr_system to fullscreen to ensure it gets applied consistently. There are multiple documents that need updating when iframes are being used. (Handling out-of-process iframes needs additional logic that's being added in a followup CL.) Bug: 1101193 Change-Id: Icf80e65e1b927888c6140acbc998ed90d469b5e1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2283823 Commit-Queue: Klaus Weidner <klausw@chromium.org> Reviewed-by:
Philip Jägenstedt <foolip@chromium.org> Reviewed-by:
Alexander Cooper <alcooper@chromium.org> Cr-Commit-Position: refs/heads/master@{#798312}
-
Charlie Hu authored
Passing a non-boolean type Item to a boolean type feature in DocumentPolicyParser will cause DCHECK failure in structured header implementation. This CL fixes this issue. Change-Id: I6db4a4bee4181631b2ee209895176e44faa9d23d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357512 Commit-Queue: Charlie Hu <chenleihu@google.com> Reviewed-by:
Ian Clelland <iclelland@chromium.org> Cr-Commit-Position: refs/heads/master@{#798311}
-
Lei Zhang authored
The testAddressIconIsNotVisibleWhenAddressStoreEmpty test case is flaky. Bug: 1116043 Change-Id: Ibe1603dc8b11ff28558991fbc14193151df5895b Tbr: javierrobles@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358030Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798310}
-
Gavin Williams authored
This change adds support for the new Print Preview destination SAVE_TO_DRIVE_CROS in PDFPrinterHandler. When the user chooses Save to Drive, PDFPrinterHandler opens the file picker defaulted to the user's Drive directory. Bug: 1112416 Change-Id: I0f00b95c0ca48d9c50f64052cc099791d9c07b12 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2340516Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Commit-Queue: Gavin Williams <gavinwill@chromium.org> Cr-Commit-Position: refs/heads/master@{#798309}
-
Brian Osman authored
Bug: skia:10613 Change-Id: I41d5955848a2f0023052531147868cec92f3edd1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356973 Commit-Queue: Brian Osman <brianosman@google.com> Commit-Queue: Brian Salomon <bsalomon@google.com> Auto-Submit: Brian Osman <brianosman@google.com> Reviewed-by:
Brian Salomon <bsalomon@google.com> Cr-Commit-Position: refs/heads/master@{#798308}
-
James Cook authored
Fix a bug where an existing user could auto-update to M85, get randomized into the SplitSettingsSync field trial, but end up with OS sync disabled. This results in apps, OS preferences, Wi-Fi configs and wallpaper not syncing. The root cause is that when we migrate their per-data-type sync prefs (e.g. apps -> OS apps, preferences -> OS preferences) we were not enabling the global OS sync feature pref. That pref has a "safe" default value of false, so OS sync was never enabled. This does not affect new users, because they see the OOBE sync consent dialog, which enables OS sync if the user opts in. This CL also fixes migration of the OS wallpaper sync pref, which should be set if the user was previously syncing both apps and themes. Some of the regression came from this CL, though migration wasn't quite right before either: https://chromium-review.googlesource.com/c/chromium/src/+/2197489 We noticed this in M85 because that's the first milestone that contains the SplitSettingsSync trial. Bug: 1116046 Test: added to unit_tests Change-Id: Ie40fc2b4bdc194a16b7b756c82f1e2bc258c60ae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354724 Commit-Queue: James Cook <jamescook@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#798307}
-
siashah authored
This change is no-op as we are always creating the autofill suggestion setting the itemTag to an empty string which'd result in the itemTag text view's visibility to be set to GONE. In a follow-up CL, we'll add the itemTag parameter to the AutofillPopupBridge and populate the autofill suggestion with it. This will be used to display the offer text in the autofill dropdown. Bug: 1112095 Change-Id: Idbbc08565a4911d76264f3fc33e688228601e5b7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350147Reviewed-by:
Bo <boliu@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Jared Saul <jsaul@google.com> Commit-Queue: Siddharth Shah <siashah@chromium.org> Cr-Commit-Position: refs/heads/master@{#798306}
-
Abigail Klein authored
that voiceover does not use them. Bug: 1049320 Change-Id: Ic7059a1c1f2a9800afca5a711994a5e485163564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357629Reviewed-by:
Aaron Leventhal <aleventhal@chromium.org> Commit-Queue: Abigail Klein <abigailbklein@google.com> Cr-Commit-Position: refs/heads/master@{#798305}
-
Kai Ninomiya authored
Sets the sorting order of the tests to --order=natural, so this will always run first (instead of being randomized). Bug: 953991 Change-Id: If0dad58a192c7ef2c99bd3c273f1f19fe69b7575 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357255Reviewed-by:
Kenneth Russell <kbr@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#798304}
-
Rakib M. Hasan authored
The CL also changes the indent size of variants.pyl from 4 spaces to 2 spaces. This is so that it's format will match test_suites.pyl's format. Bug: 1041619 Change-Id: Ibe24a42462910f8e85cef42c8e144e102cfb3869 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2347322Reviewed-by:
Erik Staab <estaab@chromium.org> Commit-Queue: Rakib Hasan <rmhasan@google.com> Cr-Commit-Position: refs/heads/master@{#798303}
-
David Van Cleve authored
This change expands the network-stack logic implementing the Trust Tokens request signing operation to accommodate taking multiple Trust Tokens issuers and providing one signature per issuer over the request's canonical signing data. The Sec-Signed-Redemption-Record header becomes a Structured Headers list where each element's value is an issuer and its associated parameters (basically, a dictionary associated with the list element) is a single key-value pair { "redemption-record": <SRR> }. The Sec-Signature header remains a Structured Headers dictionary and gets the new logical structure { "sign-request-data": <sign-request-data value>, "signatures": [ (issuer1, { "sig": <signature> "public-key": <key> }), ... (issuerN, { "sig": <signature> "public-key": <key> }) ] } where the "signatures" value is a Structured Headers "parameterized member" with an "inner" list whose elements are issuers and each of which has "parameters" (essentially a dictionary) storing the corresponding signature and public key. This seems to be how one implements a nested dictionary with Structured Headers. More background: https://docs.google.com/document/d/1L7OPuLt9CE5VhT_bGGwp3xej3mehGF-mS1ZZOVX8yp4/edit# Test: Expand unit tests for multiple issuers, including error handling. Bug: 1105230 Change-Id: I559d65c94e3b815897018d1ebee36b1e038a3e41 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315641 Commit-Queue: David Van Cleve <davidvc@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#798302}
-
Lei Zhang authored
The test is flaky on Linux. Bug: 1114038 Change-Id: I107dc2c2d8d78f10e03eae2c517766225eb1b575 Tbr: rajendrant@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357455Reviewed-by:
Lei Zhang <thestig@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#798301}
-
Tommy Martino authored
This creates an end-to-end connection from the navigation stack into the new third-party JS lib which will handle the highlighting/scrolling in the page. Change-Id: I95d2a0e89387708d573bfab4617fa5ff34f516c8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354605 Commit-Queue: Tommy Martino <tmartino@chromium.org> Reviewed-by:
Eugene But <eugenebut@chromium.org> Cr-Commit-Position: refs/heads/master@{#798300}
-
Hesen Zhang authored
Bug: 1115755 Change-Id: I77d48a7d14e11e5a84dd4305011adbcaf4359873 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354808 Commit-Queue: Hesen Zhang <hesen@chromium.org> Reviewed-by:
Shakti Sahu <shaktisahu@chromium.org> Cr-Commit-Position: refs/heads/master@{#798299}
-
Henrique Nakashima authored
Two new classes IncognitoNotificationPresenceController and IncognitoProfileDestroyer now bind the TabModelSelector to the .incognito package, controlling respectively the incognito notification and the incognito Profile destruction. Since TabModelSelectorBase creates the TabModels only after native load, it acts as a relay for the events. It is changed to recognize that there are two TabModels, one normal and one incognito, so it can observe the incognito one. Splitting IncognitoTabModel into interface and impl keeps tests from having to depend on IncognitoTabModelImpl. Bug: 1109013 Change-Id: I697f8422777ec42b44ddf19af8abb82702e136a2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2343790 Commit-Queue: Henrique Nakashima <hnakashima@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Mei Liang <meiliang@chromium.org> Reviewed-by:
David Trainor <dtrainor@chromium.org> Cr-Commit-Position: refs/heads/master@{#798298}
-
Weilun Shi authored
Change-Id: I67a0f21df7e3becd2e76e4971d040e9c1c4138ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354725 Commit-Queue: Weilun Shi <sweilun@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Cr-Commit-Position: refs/heads/master@{#798297}
-
adamta authored
Increase offset to fit ~2 cards before triggering infinite feed. Compute initial NTP scroll height in layout to only trigger infinite feed if the feed has loaded. Bug: 1085419 Change-Id: I9fccd5f135382d5574ccb6a7ce562339455c7564 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355294 Commit-Queue: Adam Trudeau-Arcaro <adamta@google.com> Reviewed-by:
Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#798296}
-
Sophie Chang authored
This is only logged if we have a navigation to tie the event to and if there is actually a tuning version associated with the allowed optimization. Privacy doc: https://docs.google.com/document/d/1XnnJrIt6Uy81_H8FBclTRS5AI7XeZcHzZNshO-DMtrU/edit Bug: 1113287 Change-Id: If6570b62cce07b285d1129921b4e56838d0c3503 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2350799 Commit-Queue: Sophie Chang <sophiechang@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Michael Crouse <mcrouse@chromium.org> Cr-Commit-Position: refs/heads/master@{#798295}
-
W. James MacLean authored
The fourth (and final) CL in implementing origin-/site-keying of SiteInstances. https://crbug.com/1085275/#c2 lists the sequence of CLs and what each will accomplish. This CL adds the keying bit to SiteInfo, and updates MakeTie() and ComputeSiteInfo() to use it. It removes the prior hack in GetSiteForURL regarding isolated base origins, and adds/updates tests that involve isolated base origins. This CL also changes the order in which we check isolated origins, so that opt-in isolation requests take precedence over command-line isolation. Bug: 1067389, 1085275 Change-Id: I3f91fe94a1a61a7ef272d83232a6ff4e6e3bff3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2269516 Commit-Queue: James MacLean <wjmaclean@chromium.org> Reviewed-by:
Aaron Colwell <acolwell@chromium.org> Reviewed-by:
Alex Moshchuk <alexmos@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#798294}
-
Michael Checo authored
Screenshots: Before: • http://shortn/_z0AhPafkbB After: • http://shortn/_GmWk2Ou5Gb BUG=1066273 TEST=manual inspection Change-Id: Ic1a47ff8f02b3c30f4800040c6f176ae41d79915 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356670Reviewed-by:
Zentaro Kavanagh <zentaro@chromium.org> Reviewed-by:
Jimmy Gong <jimmyxgong@chromium.org> Commit-Queue: Michael Checo <michaelcheco@google.com> Cr-Commit-Position: refs/heads/master@{#798293}
-
Elly Fong-Jones authored
To create the dimming visual effect when showing a sheet in Big Sur, AppKit installs a new child window of the window with the sheet, which breaks NativeWidgetMacTest.WindowModalSheet. Bug: 1114245 Change-Id: Ib7185441e1c52e0990caa1c92f5f773431d66775 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2357633 Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Leonard Grey <lgrey@chromium.org> Cr-Commit-Position: refs/heads/master@{#798292}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/4c3752c7f677..a3fcf2574157 2020-08-14 gijosh@google.com Add windows commandline to heapprofd api. 2020-08-14 fmayer@google.com Merge "Use libunwindstack warnings." 2020-08-14 lalitm@google.com Merge "Fix view-based annotation tracks in the UI." If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:linux-perfetto-rel Bug: chromium:160400319 Tbr: perfetto-bugs@google.com Change-Id: Ie06ebb744780cdd643af9cf9b23a94d269a471ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356566Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#798291}
-