- 02 Apr, 2020 40 commits
-
-
Yuki Shiino authored
HTMLOptionElement's NamedConstructor's arguments should have default values of "" (empty string) instead of IDL null. (It's not allowed to initialize non-nullable DOMString with IDL null.) Bug: 839389 Change-Id: Ifab7058697b98be497c7e794ee173165dcaf10cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134027Reviewed-by:
Hitoshi Yoshida <peria@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#755869}
-
dpapad authored
#cr_define_end is a special comment leveraged by polymer_modulizer() and js_modulizer() BUILD.gn rules, when auto-converting files to JS modules. Bug: 1045266 Change-Id: Ia1be68bf63753be9fd38c3066246d34f58afc3b3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133234Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Commit-Queue: dpapad <dpapad@chromium.org> Auto-Submit: dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#755868}
-
Behnood Momenzadeh authored
This CL triggers a lookalike safety tip if enabled by a feature parameter. The set of TLDs searched for is also configurable via feature parameter. This code is trivially changeable to trigger the Lookalike interstitial instead of a Safety Tip. A Safety Tip was chosen since we already have experiment infrastructure (i.e. feature flags) and we're not yet sure about the false positive rate of the heuristic. This CL also slightly also changes the target embedding logic. Target embedding is now no longer detected if the eTLDs overlap, such as in google.co and google.co.uk. This reduces false positives. TBR: cthomp@chromium.org Change-Id: I3b9a97d613b90b10ee85426c0ee27aab9adcf1e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2119374 Commit-Queue: Joe DeBlasio <jdeblasio@chromium.org> Reviewed-by:
Joe DeBlasio <jdeblasio@chromium.org> Cr-Commit-Position: refs/heads/master@{#755867}
-
Peter Kasting authored
This test tried to use a service whose factory is null in test mode. It would work if run standalone because the factory was _also_ not properly registered on startup, so the testing factory would never be set to null. However, if run in a batch with other browser tests, a previous test's access to the factory would register it; the next browser startup would null its testing factory; and then this test would crash. This fixes both problems: registers the factory, and sets a non-null testing factory. Bug: none Change-Id: I877cb9b7c58e82de17888b52d7d6ddc34f5bec27 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133626Reviewed-by:
David Bertoni <dbertoni@chromium.org> Reviewed-by:
Varun Khaneja <vakh@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#755866}
-
Wenyu Fu authored
Bug: 1052060 Change-Id: Idc3dc5220a822234222dc77f583ba119558ccce4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2095771 Commit-Queue: Wenyu Fu <wenyufu@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#755865}
-
Arthur Wang authored
R=jbudorick@chromiums.org Bug: 1065848 Change-Id: I9fada9d16a5a5cb468777160fab9662a05c76016 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133150Reviewed-by:
Daniel Rubery <drubery@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Arthur Wang <wuwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755864}
-
Antonio Gomes authored
BUG=1063749 R=jfernandez@chromium.org Change-Id: Ide065e86f3a9950ba0ff7f8ce177ee37f41b6af3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133910 Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Cr-Commit-Position: refs/heads/master@{#755863}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/c980dbf22c82..7b793647316c git log c980dbf22c82..7b793647316c --date=short --first-parent --format='%ad %ae %s' 2020-04-02 surma@chromium.org Fix size calculations in ExpandableTextPropertyValue Created with: gclient setdep -r src/third_party/devtools-frontend/src@7b793647316c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1024721 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I8f322feb682f3b47cbc5b2edbb8c21c64f371bfc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134350Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755862}
-
chrome://omniboxTommy C. Li authored
This records the group ID and header text of suggestions in the additional_info field of AutocompleteMatch. That way, we can show this extended metadata in chrome://omnibox in a lightweight way (without adding a whole new column or something). This will be useful for Moe and I (and others) to debug the header text feature as we are developing it. I really like the extensible additional_info dictionary by the way. Bug: 1052519, 1052522 Change-Id: I1409b6e6fd775149f6ca9c67e793f49c031c7251 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132958 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Cr-Commit-Position: refs/heads/master@{#755861}
-
Koji Ishii authored
|LayoutText| and |LayoutInline| has functions to check whether they produced inline fragments or not in slightly different ways. Also we have |DCHECK| to do it for |LayoutBox|. This patch adds |HasInlineFragments()|, unifying these code. This is also used when associating |NGFragmentItem| with |LayoutObject| in <crrev.com/c/2117558>. This patch has no behavior changes. Bug: 982194 Change-Id: Ie2bee2531189b7707773aab388ca51d5d112c030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133535 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
Yoshifumi Inoue <yosin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755860}
-
Andrew Xu authored
This CL records the smoothness for shelf icon animations which are usually triggered by adding/removing a shelf icon. In detail, there are three kinds of icon animations: (1) Move icons (2) Fade in an icon (3) Fade out an icon. This CL should be landed after https://crbug.com/1051490 is fixed. Bug: 1049702 Change-Id: I8c47ba3a3111a2bc8a7361ddcc12420d45308cef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105675 Commit-Queue: Andrew Xu <andrewxu@chromium.org> Reviewed-by:
Sammie Quon <sammiequon@chromium.org> Reviewed-by:
Brian White <bcwhite@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Andrew Xu <andrewxu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755859}
-
Rushan Suleymanov authored
This change initiates bookmark reuploading for pre-existing bookmarks which are stored locally. A new field is introduced to BookmarksMetadata to determine if local bookmarks were reuploaded. To prevent the case when the bookmark specifics is committed without favicon the entity is marked as unsynced after it was committed. In this case the entity will be committed again when the favicon is loaded. Bug: 1061411 Change-Id: I4a26a2babceb99a0f6532d2357884c75aff9fc05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127032 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#755858}
-
Abhijeet Kandalkar authored
After clicking the toggle button to enable/disable the extension, the icon of the next extension is getting selected. This issue is a regression from[1]. [1] https://crrev.com/c/1567561 Bug: 1060114 Change-Id: I14c4f713e6819267724baec6d9cbdcba7de74f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133986Reviewed-by:
-
Guido Urdaneta authored
The use case to be supported is efficiently running Streams of RTCEncodedVideoFrame in a Worker. In this case, RTCEncodedVideoFrame are serialized to the Worker. Serialization is supported only in the same process as a shallow copy where the underlying webrtc frame is shared among the original and the deserialized object. See https://github.com/alvestrand/webrtc-media-streams/issues/5 Bug: 1052765 Change-Id: I1e2d9bcd2e24ef6aa6a7688f34283a81e6d23172 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2083297 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Jeremy Roman <jbroman@chromium.org> Reviewed-by:
Harald Alvestrand <hta@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Cr-Commit-Position: refs/heads/master@{#755856}
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/cb58662302c8..0774188da4bb git log cb58662302c8..0774188da4bb --date=short --first-parent --format='%ad %ae %s' 2020-04-02 sugoi@google.com Fix ImageView size computation Created with: gclient setdep -r src/third_party/swiftshader@0774188da4bb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: swiftshader-team+autoroll@google.com Change-Id: I3841763048a804d2ba9f6787a00b453d946b6d5a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134348Reviewed-by:
-
Tomasz Wiszkowski authored
This change enables on-device history ZPS suggestions for users who are not signed in to Chrome on Android. Bug: 956837 Change-Id: I689960538b1087eac9355ba0b20da7310f5e3daa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132864 Commit-Queue: Ender <ender@google.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#755854}
-
Dominik Röttsches authored
Support parsing and serialisation of the new from-font keyword in text-underline-position. Introduce a RuntimeEnabledFeatures flag UnderlineOffsetThickness for guarding new underline features. Intent to prototype: https://groups.google.com/a/chromium.org/g/blink-dev/c/D6S8JRPYtDA Bug: 1067242 Change-Id: Id118e538af20276929fe92d235ce1920c0f6234a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120715 Commit-Queue: Dominik Röttsches <drott@chromium.org> Reviewed-by:
Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#755853}
-
Ben Mason authored
TBR=govind@chromium.org Change-Id: Ic424c696f824bc2e4e34d32baf36e0f0a4f64d46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132691Reviewed-by:
Ben Mason <benmason@chromium.org> Reviewed-by:
Krishna Govind <govind@chromium.org> Commit-Queue: Ben Mason <benmason@chromium.org> Cr-Commit-Position: refs/heads/master@{#755852}
-
Friedrich Horschig authored
This CL removes the spinner located at the top of the passwords popup. Instead, each button that can trigger it, will show the spinner to its left. See the linked bug for a screenshot and a brief screencast. Bug: 1066470 Change-Id: I17c625e194842c55d2b313da85dcfb7712d23625 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129709 Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Reviewed-by:
Maxim Kolosovskiy <kolos@chromium.org> Reviewed-by:
Vasilii Sukhanov <vasilii@chromium.org> Cr-Commit-Position: refs/heads/master@{#755851}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/9db428f4f78e..cd454025b331 git log 9db428f4f78e..cd454025b331 --date=short --first-parent --format='%ad %ae %s' 2020-04-02 pkasting@chromium.org Revert "Reland "git-cl: Execute clang-format-diff.py using vpython."" Created with: gclient setdep -r src/third_party/depot_tools@cd454025b331 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1066187 Tbr: agable@chromium.org Change-Id: I84b6620405b662aff0f1d730b22c855ad4bc699b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134349Reviewed-by:
-
Chris Palmer authored
Not sure how that eluded scrutiny for so long :] TBR: awhalley Bug: None Change-Id: I66c65daa67cae3dc64a268a566b17b4a2450da21 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133418Reviewed-by:
Chris Palmer <palmer@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#755849}
-
Liquan (Max) Gu authored
In AndroidPaymentAppFinder#findAndroidPaymentApps, this CL adds a support for it to know whether it is running in a TWA that is installed from AppStore. Bug: 1064740 Change-Id: I4e21787294f1e7a2e471f80b452ebdd0a9ab77e8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2128831 Commit-Queue: Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
Rouslan Solomakhin <rouslan@chromium.org> Reviewed-by:
Peter Conn <peconn@chromium.org> Auto-Submit: Liquan (Max) Gu <maxlg@chromium.org> Cr-Commit-Position: refs/heads/master@{#755848}
-
DongJun Kim authored
This patch is step 3 in [1] and we adds a new RequestDestination field in the structs / params where only RequestContextType is used. If we are finish current step then RequestContextType field will be deprecated. [1] https://docs.google.com/document/d/1kXXnH_27aJYGqjwbXLW6Bs9fW2xFhvZs8gJcXb4xnhQ/edit Bug: 889751 Signed-off-by:
DongJun Kim <djmix.kim@samsung.com> Change-Id: I7930af1123af4f4c5a810428ab5921182156e899 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129455Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#755847}
-
Clark DuVall authored
This matches what we do with various other classes like Profile to allow the client to mock for tests. Bug: 1054160 Change-Id: I9dc34dbf5309ea071aeeb1d0fd2081a171c82085 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133877 Commit-Queue: Clark DuVall <cduvall@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Auto-Submit: Clark DuVall <cduvall@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#755846}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/792d24ae70ef..b6fff1b9fabd Created with: gclient setdep -r src-internal@b6fff1b9fabd If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: jbudorick@google.com Change-Id: Ib34175c564aeefeaac08e84f46ab1a5f4ba13870 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134347Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755845}
-
behdad authored
OnFinishImplFrame call might happen when the corresponding frame is in a stage rather than BeginImpl or BeginMain. This change checks for the other reporters as well. Bug: chromium:1067245 Change-Id: I9b30c78ed5d43397f94ec627c2f7bd099a92f522 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133868Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Auto-Submit: Behdad Bakhshinategh <behdadb@chromium.org> Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Cr-Commit-Position: refs/heads/master@{#755844}
-
David Jean authored
Bug: 1045454 Change-Id: I99904af6881daa31cf6bb401f7ea29116cfe5bef Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132406 Commit-Queue: David Jean <djean@chromium.org> Reviewed-by:
Javier Ernesto Flores Robles <javierrobles@chromium.org> Cr-Commit-Position: refs/heads/master@{#755843}
-
Yue Zhang authored
Since TabGridPanelToolbarCoordinator only handles layout inflation and PropertyModel creation, this CL removes this class and moves related logic back to TabGridDialogCoordinator. Bug: 1067080 Change-Id: I188d3de5a8d1baf064ddd22f857a110b815ba4e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133077Reviewed-by:
-
chromium-autoroll authored
If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/fuchsia-sdk-chromium-autoroll Please CC cr-fuchsia+bot@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:fuchsia-arm64-cast;luci.chromium.try:fuchsia-x64-cast Tbr: cr-fuchsia+bot@chromium.org Change-Id: I14dbec1680af528f3f7ca40bf88f01059c927fd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134351Reviewed-by:
-
Rushan Suleymanov authored
When the client receives BookmarkSpecifics with a legacy title field only it will fill in new field and commit changed data to the server again in future. Reupload of updated specifics may be done after receiving of initial merge data or after browser restart. Bug: 1061411 Change-Id: Id7efe057208dc5482b4fdd6773ac561ef79d9640 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2105335 Commit-Queue: Rushan Suleymanov <rushans@google.com> Reviewed-by:
-
Aaron Leventhal authored
Add a DCHECK that will be triggered only on address sanitizer builds, but importantly, will trigger on clusterfuzz builds. The hope is that we clusterfuzz will file bugs on us with test pages that will reproduce the problem. If this technique works, we can look at adding it in other helpful places, such as for some of the DCHECKs in ax_selection. Bug: None Change-Id: I643ec0fb6c40f4063d437f62384211483bb50868 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133027 Commit-Queue: Aaron Leventhal <aleventhal@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#755839}
-
Ben Mason authored
Updated the iOS UI test. This reverts commit 9033a96c. Original change's description: > Revert "Update TOS" > > This reverts commit f88c2f7c. > > Reason for revert: Widespread ios bot failures. auto-rollers are blocked. > > Original change's description: > > Update TOS > > > > Bring chrome://terms in line with > > https://www.google.com/chrome/terms/ > > > > Bug: 1060545 > > Change-Id: I823aa5bdf51c55488777ebb18406b79f9887e6b9 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120046 > > Reviewed-by: Mike Pinkerton <pinkerton@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Reviewed-by: Ben Mason <benmason@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755585} > > TBR=pinkerton@chromium.org,tedchoc@chromium.org,benmason@chromium.org > > Change-Id: Ibb4b4c39eff4b9a4276a4e3d64e5ae8552b47452 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1060545, 1067086 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132554 > Reviewed-by: Trent Apted <tapted@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755690} TBR=tapted@chromium.org,pinkerton@chromium.org,tedchoc@chromium.org,benmason@chromium.org Change-Id: I27b47f7f79a00e9f5e3275e7e3de285c1234cc87 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1060545, 1067086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133873 Commit-Queue: Ben Mason <benmason@chromium.org> Reviewed-by:
Mike Pinkerton <pinkerton@chromium.org> Cr-Commit-Position: refs/heads/master@{#755838}
-
Eric Seckler authored
A couple of refactorings that aim to make startup tracing setup and timeout more robust: 1) Move startup tracing timeout from TraceEventDataSource into PerfettoProducer, so that it also affects other data sources. 2) Support aborting startup tracing in TracingSamplerProfiler. 3) Resolve the startup tracing target buffer reservation on abort in TraceEventDataSource. 4) Plumb the timeout through PerfettoTracedProcess to ensure no other concurrent tracing session is active (e.g. system tracing). 5) Move setup of TraceLog from trace_startup.cc into TraceEventDataSource. Bug: 1006753 Change-Id: Ic6afb4ccc71fa960eb4db86d39450bc7c4c39992 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130353 Commit-Queue: Eric Seckler <eseckler@chromium.org> Reviewed-by:
Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#755837}
-
Nina Satragno authored
When a relying party sends an empty pubKeyCredParams, default to a list containing ES256 and RS256 instead of returning an error. See https://w3c.github.io/webauthn/#sctn-createCredential step 8. This also touches up WPTs exercising this behaviour. Fixed: 1064689 Change-Id: I599fd57f9eccea5aa26144e10e41009980fda79c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132644 Auto-Submit: Nina Satragno <nsatragno@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Commit-Queue: Nina Satragno <nsatragno@chromium.org> Cr-Commit-Position: refs/heads/master@{#755836}
-
Devlin Cronin authored
The "action" key is restricted to trunk, so we need to override the current channel for these tests. Tbr: lazyboy@chromium.org (trivial test fix) Bug: 1067187, 893373 Change-Id: Iabb96a414e532a457007ca3cd453838cf3ea73aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133874Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755835}
-
Nohemi Fernandez authored
This CL clarifies the intent of the sign-out options by making two UI tweaks suggested by our UI designer: 1. Ensure that popover is anchored to the button requesting it. 2. Ensure that long text wraps instead of cutting off. Bug: 1043949 Change-Id: I8483b51634ba21516b58314a11cfeb29757f8ed5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134367Reviewed-by:
Sylvain Defresne <sdefresne@chromium.org> Commit-Queue: Nohemi Fernandez <fernandex@chromium.org> Cr-Commit-Position: refs/heads/master@{#755834}
-
Mohamed Amir Yosef authored
This is to avoid dependency cycle when including it in PasswordForm Bug: 1032992 Change-Id: Ia60052bd8caef4f5488f8d2fcd18c6b95e9e1cb1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133968Reviewed-by:
Dominic Battré <battre@chromium.org> Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium e7fb30eb. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 8fa00285 "[webauthn] Fix resident key credentials.get() WPT" edb8adb1 "Implement and ship RTCRtpSendParameters.degradationPreference" 2fb88bb8 "Use integer coordinates for Actions.pointerMove." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: drott@chromium.org: external/wpt/css/css-text-decor rego@igalia.com: external/wpt/css/css-ui xlai@chromium.org, jinho.bang@samsung.com, hs1217.lee@samsung.com: external/wpt/css/geometry NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: I09329bd6e43f30cc73b6cf2dd7e46d91ff169d4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133906Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755832}
-
Maksim Sisov authored
This CL configures the testers to run viz_unittests Bug: 1029240 Change-Id: Ia46bf071050f61398bedf09f864a89852bc374d6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2124261Reviewed-by:
-
John Budorick authored
Bug: 1060280 Change-Id: I058840f16302b473b206ac9b074107baaf29f412 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133232Reviewed-by:
John Chen <johnchen@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#755830}
-
