- 18 Sep, 2019 40 commits
-
-
Michael van Ouwerkerk authored
Bug: 991520 Change-Id: Ibc8f641bff2dde0d675be237a2f3aa6fced81c98 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808839Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Michael van Ouwerkerk <mvanouwerkerk@chromium.org> Cr-Commit-Position: refs/heads/master@{#697526}
-
nancy authored
For Crostini, Extension, built-in apps, the AppService is used to valid the app id. For ARC apps, ArcAppListPrefs is used, as ARC apps have some very special cases, e.g. PlayStore. ARC tests also assume synchronous behaviour, and will need more refactoring so the AppService can be used. Related unit tests has been fixed. Extension apps in test cases use OnExtensionLoaded to add extension apps, so set the extension name so that we can use AppService to dump the apps name. BUG=1002351 Change-Id: Ia7f589de82ca226eb05dd1706ab95229699d6fdb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803015 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Dominick Ng <dominickn@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#697525}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/37cb2b2a47f0..fd1414608ba1 git log 37cb2b2a47f0..fd1414608ba1 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 csmartdalton@google.com Reorder msaa and mipmap resolves to happen all at once 2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/angle2 d32dae1bb37c..a7003d5fc306 (11 commits) 2019-09-18 skia-recreate-skps@skia-swarming-bots.iam.gserviceaccount.com Update Go deps Created with: gclient setdep -r src/third_party/skia@fd1414608ba1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:None Change-Id: I926bded2ba35894422ba429b94e321440ed56c24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809982Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697524}
-
Arthur Hemery authored
We were trying to run webkit layout tests on android, but that is not actually a thing. Also added chrome_junit_tests and content_junit_tests to the bot. Bug: 976218 Change-Id: If507c3d8d92506a784bcea79980bc5ec58dc72e5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803434 Commit-Queue: Arthur Hemery <ahemery@chromium.org> Reviewed-by:
Andrew Grieve <agrieve@chromium.org> Reviewed-by:
John Budorick <jbudorick@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#697523}
-
Sylvain Defresne authored
Some base testing classes want to register multiple profiles and already have a TestingProfile::Builder::TestingFactories, so add a method to avoid having all the caller inline the implementation. Bug: none Change-Id: I6bc0fd8bf7954395d8f11016703b4c4807cfbb69 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808858 Auto-Submit: Sylvain Defresne <sdefresne@chromium.org> Reviewed-by:
David Roger <droger@chromium.org> Commit-Queue: Sylvain Defresne <sdefresne@chromium.org> Cr-Commit-Position: refs/heads/master@{#697522}
-
Fergus Dall authored
Also improve usage of base::RunLoop in several tests Bug: 1003775 Change-Id: Id826b9761b0fe98967688b58f4c77ad794b04eb2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1803934Reviewed-by:
Joel Hockey <joelhockey@chromium.org> Commit-Queue: Fergus Dall <sidereal@google.com> Auto-Submit: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697521}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/a7003d5fc306..d5521094f779 git log a7003d5fc306..d5521094f779 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 angle-autoroll@skia-public.iam.gserviceaccount.com Roll ./third_party/spirv-tools/src 99793fa67d78..36c1c0e22fab (1 commits) Created with: gclient setdep -r src/third_party/angle@d5521094f779 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@chromium.org Bug: chromium:None Change-Id: I208d523513aecbacfd4327fb8acdc464631b3d05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809983Reviewed-by:
-
Hitoshi Yoshida authored
Now we don't use keywords "creator" nor "legacycaller". This CL drops these legacy keywords and reconstruct the parsing patterns. This change does not change output ASTs, as a result. The new pattern ignores OperationNameKeyword to allow "includes" as an operation's name, because the case is cought by the leading "_" rule. cf. https://github.com/heycam/webidl/issues/767 Bug: 839389 Change-Id: Idccb1853a82d629504464f0dad5fbe82702c083d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809134Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Yuki Shiino <yukishiino@chromium.org> Reviewed-by:
Kenichi Ishibashi <bashi@chromium.org> Commit-Queue: Hitoshi Yoshida <peria@chromium.org> Cr-Commit-Position: refs/heads/master@{#697519}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/84da790b..16144e1a Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Iee83758aa006691e617e571a459dc2318d473bd9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807163Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697518}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/a467e264db50..83d2cae04c5f git log a467e264db50..83d2cae04c5f --date=short --no-merges --format='%ad %ae %s' 2019-09-18 dburger@chromium.org Remove EOL nyan_big, nyan_blaze from legacy CQ. 2019-09-18 lamontjones@chromium.org lib: minor cleanup in image_lib and caller. Created with: gclient setdep -r src/third_party/chromite@83d2cae04c5f If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia794217e1a176998f6461b2b6310b36fb71e90b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810010Reviewed-by:
-
Keishi Hattori authored
Implements SetPreemptedForCooperativeScheduling which stops all task queues associated with the FrameSchedulerImpl including the unpausable ones. Bug: 804661 Change-Id: Icd7288d85c6411c3e379908d14ed9c6eb7203ed8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1742264 Commit-Queue: Keishi Hattori <keishi@chromium.org> Reviewed-by:
Alexander Timin <altimin@chromium.org> Reviewed-by:
-
Noel Gordon authored
Viewing PDF files in a renderer (via chrome PDFium) is controlled by a system pref PluginsAlwaysOpenPdfExternally, which is read once-only at FileApp startup. Dynamic pref changes are ignored (see bug). Remove loadTimeData setters for PDF and SWF file viewing actions: file private_api_strings.cc ShouldBeOpenedWithPlugin calls begone, and same for the file_task.js loadTimeData code in FilesApp. Instead, call ShouldBeOpenedWithPlugin in file_tasks.cc. When the list of file tasks is requested by FilesApp, this new code enables/disables FilesApp PDF/SWF viewing actions ... dynamically based on prefs. Add an integration test: tests that QuickView does not show a PDF when the system PluginsAlwaysOpenPdfExternally pref is enabled. Test: browser_tests --gtest_filter="*QuickViewPdfPreviewsDisabled* Bug: 999103 Change-Id: I455fdbd794247a0a57105a2abd6ed929c752a8bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1808943 Commit-Queue: Noel Gordon <noel@chromium.org> Reviewed-by:
Sam McNally <sammc@chromium.org> Cr-Commit-Position: refs/heads/master@{#697515}
-
Anastasiia Nikolaienko authored
ARC uprev http://ag/9399668 Change-Id: I6479b9977dcb6a3c2d6448714bf8aed23725aad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807320Reviewed-by:
Kush Sinha <sinhak@chromium.org> Reviewed-by:
Mattias Nissler <mnissler@chromium.org> Commit-Queue: Anastasiia Nikolaienko <anastasiian@chromium.org> Cr-Commit-Position: refs/heads/master@{#697514}
-
Darren Shen authored
Currently we queue composition operations as "pending" if we are currently handling a PK event. However, the pending composition is not cleared after we handle the pending composition, so IMF thinks that there's still some pending composition to be run in the next operation. Bug: 1004149 Change-Id: Ibe7d6d49cd2d532f2a3300d63df15cd54eda98e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806154Reviewed-by:
Shu Chen <shuchen@chromium.org> Commit-Queue: Darren Shen <shend@chromium.org> Cr-Commit-Position: refs/heads/master@{#697513}
-
Alex Clarke authored
We'd like to prioritize loading and compositing tasks till FCP and this appears to expose a problem with the test. The timing of the script on line 6 with respect to the second promise test is a bit fragile. If the iframe script runs before the promise then document.querySelector('iframe') returns null and the test fails. This timing issue seems unrelated to the test itself, so I propose splitting the test into two as the simplest fix. Bug: 971191 Change-Id: I65384093ac8f4616d64fc21ee692d145be1655a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807323Reviewed-by:Kent Tamura <tkent@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#697512}
-
Yi Su authored
Currently we assume that if a NavigationContext can be found when "decidePolicyForNavigationAction" is invoked, the navigation should be either user-initiated or JS back-forward. However this can be wrong if the web page uses JS to load the same URL during the navigation. The root cause here is that we are matching URL to find the NavigationContext for WKNavigationAction, which is not reliable. Bug: 1000309,1003467 Change-Id: I7163474df5ffde9cf784ef348f48e652ca878df3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807832Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Yi Su <mrsuyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#697511}
-
Jan Scheffler authored
This patch adds the emacsy shortcuts to the editor again. Bug: chromium:983874 Change-Id: I8423fad0b0fde6ac83487189092edc8f9c66c095 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1806737Reviewed-by:
Yang Guo <yangguo@chromium.org> Commit-Queue: Jan Scheffler <janscheffler@chromium.org> Cr-Commit-Position: refs/heads/master@{#697510}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/b4e53c4a9938..cbc960899a68 git log b4e53c4a9938..cbc960899a68 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 abennetts@google.com Minimal markdown conversion of Pinpoint Errors doc (https://docs.google.com/document/d/1cuhfQ1peSpz2ts3OMC-O4ALoblamYBaCWWOES8bP8ms/view#) Created with: gclient setdep -r src/third_party/catapult@cbc960899a68 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=skyostil@google.com Bug: None Change-Id: I32ea130e1c00c8abba9e9d1d87aa781bb6e193ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809853Reviewed-by:
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/dca254aeeec6..199cfeb385a2 Created with: gclient setdep -r src-internal@199cfeb385a2 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome TBR=jbudorick@google.com Bug: chromium:None Change-Id: I3cd8d82fa7aec1ab88cd69551982384d185dd26a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810179Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#697508}
-
Jan Scheffler authored
This patch adds the navigationId to LCP events to allow reporting of LCP for every navigation. Bug: chromium:1001010 Change-Id: If813f679d75c45bbb16a270576f5c9be0f47c772 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790445 Commit-Queue: Jan Scheffler <janscheffler@google.com> Reviewed-by:
Alexei Filippov <alph@chromium.org> Reviewed-by:
Steve Kobes <skobes@chromium.org> Reviewed-by:
Liquan (Max) Gu <maxlg@chromium.org> Reviewed-by:
-
Jan Scheffler authored
This fixes the color popover when the contrast details are show and also has a color picker for the background. Bug: chromium:959012 Change-Id: Iddbd397b9417a331397c3e07fd3690ea5e306710 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789225Reviewed-by:
-
Gauthier Ambard authored
This CL removes the default VoiceOver action which is reading the title of the item then the content of the badge. Now the accessibility label is the title and a new property, |additionalAccessibilityLabel|, if it is set. Bug: 985764 Change-Id: Ic2c1f0a590f020de0dae1a37cc01f081663c2e45 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789397Reviewed-by:
Justin Cohen <justincohen@chromium.org> Reviewed-by:
Olivier Robin <olivierrobin@chromium.org> Commit-Queue: Gauthier Ambard <gambard@chromium.org> Cr-Commit-Position: refs/heads/master@{#697505}
-
Fergus Dall authored
TBR=cmumford@google.com TBR=kinuko@chromium.org Bug: 1005084 Change-Id: I1d22b527d7d5bdaa3f4e7c0b8726258ac43f30db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810442Reviewed-by:
Fergus Dall <sidereal@google.com> Commit-Queue: Fergus Dall <sidereal@google.com> Cr-Commit-Position: refs/heads/master@{#697504}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/a37ea9246e1e..37cb2b2a47f0 git log a37ea9246e1e..37cb2b2a47f0 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll ../src c6edebc2..b1c1d284 (382 commits) 2019-09-18 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader 30847688f059..61a2765940a7 (7 commits) 2019-09-18 herb@google.com Revert "SkZip - synchronized indexing of several pointers" Created with: gclient setdep -r src/third_party/skia@37cb2b2a47f0 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: chromium:None,chromium:None Change-Id: Ie5408a899495ee583d742a659b2fbb2139ce7f99 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810457Reviewed-by:
-
Fergus Dall authored
TBR=sky@chromium.org Bug: 1005095 Change-Id: I9ab1fe467bc0c8d927f7ba4154674c0a3ca5fcb4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810498Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromiumos/chromite.git/+log/da39c6d82324..a467e264db50 git log da39c6d82324..a467e264db50 --date=short --no-merges --format='%ad %ae %s' 2019-09-18 vapier@chromium.org image_lib: add fsync when updating filesystem superblocks 2019-09-18 vapier@chromium.org image_lib/osutils: improve debug output for image mounting Created with: gclient setdep -r src/third_party/chromite@a467e264db50 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/chromite-chromium-autoroll Please CC chrome-os-gardeners@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:chromeos-kevin-rel TBR=chrome-os-gardeners@google.com Bug: None Change-Id: Ia2c39da1ce13f72b7b3b39632bbd1841cf781706 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810178Reviewed-by:
-
Julie Jeongeun Kim authored
This CL converts MultiroomManagerPtr to new Mojo types. It uses Remote and Receiver instead of MultiroomManagerPtr and Binding. Bug: 955171 Change-Id: I6615aff8b7ca9c58748bbd08ee08f38b57b4c202 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804947Reviewed-by:
Oksana Zhuravlova <oksamyt@chromium.org> Reviewed-by:
Kenneth MacKay <kmackay@chromium.org> Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Commit-Queue: Julie Kim <jkim@igalia.com> Cr-Commit-Position: refs/heads/master@{#697500}
-
Miyoung Shin authored
This CL converts HidConnection{Ptr, Request} in device, services, content, blink and extensions to the new Mojo type, and uses pending_remote<HidConnection> in hid.mojom of blink and hid.mojom of services. Bug: 955171, 978694 Change-Id: I786590ab78d08ebf3b989dea1185e53b0442c568 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1804944 Commit-Queue: Miyoung Shin <myid.shin@igalia.com> Reviewed-by:Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#697499}
-
Hirokazu Honda authored
VaapiVEA creates VASurface from DmaBuf backed VideoFrame through VaapiPictureFactory. There is no reason to create VASurface with VaapiPicture. This CL retires VaapiPicture in VaapiVEA. Bug: 1001413 Test: tast run video.EncodeAccel* Change-Id: Ib0905ee097bde21aeab37081c43641c48fe83b24 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786707 Commit-Queue: Hirokazu Honda <hiroh@chromium.org> Reviewed-by:
Andres Calderon Jaramillo <andrescj@chromium.org> Reviewed-by:
Miguel Casas <mcasas@chromium.org> Cr-Commit-Position: refs/heads/master@{#697498}
-
John Abd-El-Malek authored
This will be added to FYI bots in a followup cl. Change-Id: I8ca2e3ce61e628cf6e342a8ab4fc604975c0d225 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809897 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#697497}
-
chromium-autoroll authored
Roll ChromeOS orderfile from 78-3877.0-1568022778-benchmark-78.0.3902.0-r1 to 79-3903.0-1568628088-benchmark-78.0.3902.0-r1 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/cros-orderfile-chromium Please CC c-compiler-chrome@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_EXTRA_TRYBOTS= TBR=c-compiler-chrome@google.com Change-Id: Ic39e133c13d6180aac724f2f7487a70c9c804786 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810180Reviewed-by:
-
Hitoshi Yoshida authored
Web IDL does not allow to have null as a constant value. https://heycam.github.io/webidl/#index-prod-ConstValue This CL drops the keyword from parser, and does not change actual behaviors of Chrome. Bug: 839389 Change-Id: Ia22c901fc71517ce74a8859a1fd74994c6c65e53 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809118Reviewed-by:
-
Richard Knoll authored
This will hide the settings button for native notifications if they should not have one. This is specific to the feature that displays the notification and is already working for non-native notifications. Additionally, the settings button will now show for extension native notifications, a previous CL (923877) only added it for non-native ones. Bug: 999979,810622 Change-Id: I26d94e275dab76d1748afdfefae78aba77977473 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1801759Reviewed-by:
Peter Beverloo <peter@chromium.org> Commit-Queue: Richard Knoll <knollr@chromium.org> Cr-Commit-Position: refs/heads/master@{#697494}
-
Alan Cutter authored
Test background installation flag over install_params presence when deciding to open Play store installation for PWAs on Chrome OS This CL updates the logic for checking whether a PWA installation should go via the Play store to branch on the "background installation" bool instead of whether we have install_params_ set. This is in preparation for adding background updating as a new install entry point which breaks the existing expectations. Bug: 926083 Change-Id: I5d0f987fa04bc9dcc02452cc5c1ea5515b6b59ed Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788781Reviewed-by:
-
Alexei Filippov authored
The class is quite big containing a string and a flat_map. We're observing its copy constructor being called quite extensively at places where it would otherwise be using move. BUG=1003042 Change-Id: I011b267427f8c9790047a5b7adf9c2cd3dd27399 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807702Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Commit-Queue: Alexei Filippov <alph@chromium.org> Cr-Commit-Position: refs/heads/master@{#697492}
-
Fergus Dall authored
TBR=khmel@chromium.org TBR=malaykeshav@chromium.org Bug: 1005069 Change-Id: I4a9bfbfc683587714eeb960c8d2e58f739932b1c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810171Reviewed-by:
-
sczs authored
There was a retain cycle per bug 1004690. The ContainerCoordinator had a strong pointer to the Mediator, which in turn had a strong pointer to infobar_container_ios, which had a strong pointer to its consumer (ContainerCoordinator). This would only happen on non Messages, since on the legacy implementation the consumer is the ContainerViewController. Still I think both consumers should be weakly retained since the mediator(infobar_container_ios) don't really own these objects. Bug: 1004690 Change-Id: Ic5d30b444177e216ffe2f8cdce9b0cf7d012383c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809744Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#697490}
-
Hitoshi Yoshida authored
Reorders IDL parser's patterns to follow Web IDL grammar[1] as much as possible. This CL is to reduce diffs of follow-up CLs, and does not change any behaviors. [1] https://heycam.github.io/webidl/#idl-grammar Bug: 650150, 839389 Change-Id: I8885016db13f9b9af2fed18eb3e6ccf99c6365b9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1807652Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/f3c4a829c64f..a37ea9246e1e git log f3c4a829c64f..a37ea9246e1e --date=short --no-merges --format='%ad %ae %s' 2019-09-18 csmartdalton@google.com Use a "decal" domain for filterMaskGPU Created with: gclient setdep -r src/third_party/skia@a37ea9246e1e If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC brianosman@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=brianosman@google.com Bug: None Change-Id: I63d45595957388d31658ae5d2c87e3d4dcb9f148 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1810357Reviewed-by:
-
Eric Willigers authored
WebDisplayMode was being passes by const reference. It is now passed by value, as usual for enums. Change-Id: I12f192cdd92251a606cec66071445cb875eac0dd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1809133 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Commit-Queue: Kentaro Hara <haraken@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
-
