- 02 Apr, 2020 40 commits
-
-
John Abd-El-Malek authored
Bug: 1025603 Change-Id: Ie2ef10c03b9ffea77436c0932727d1545fcf895f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132540Reviewed-by:
Scott Violet <sky@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: John Abd-El-Malek <jam@chromium.org> Cr-Commit-Position: refs/heads/master@{#755922}
-
danakj authored
This moves helper code that the browser uses over to the browser/ directory and removes the DEPS rules that were left to support this violation. R=avi@chromium.org Bug: 866140 Change-Id: Ib49c7e5e6f64f34db87a73ef5368384ee73e1c19 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133876Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: danakj <danakj@chromium.org> Cr-Commit-Position: refs/heads/master@{#755921}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/586f781bd78b..96e14888195d git log 586f781bd78b..96e14888195d --date=short --first-parent --format='%ad %ae %s' 2020-04-02 lalitm@google.com Merge "tp: fix returning utid of freed thread in rss stat event" Created with: gclient setdep -r src/third_party/perfetto@96e14888195d If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: None Tbr: perfetto-bugs@google.com Change-Id: I4f7e3ad75b1468de8a242f61d6f25994a96a4904 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134357Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755920}
-
Guido Urdaneta authored
Drive-by: update video tests to return correct promise and improve style. Bug: 1052765 Change-Id: Id1c31b577f0431b2073f0ae486926283aca41759 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132200 Commit-Queue: Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Marina Ciocea <marinaciocea@chromium.org> Cr-Commit-Position: refs/heads/master@{#755919}
-
Anatoliy Potapchuk authored
This reverts commit 26f39e78. Reason for revert: it has passed Original change's description: > CL to verify that presubmit does not know anythyng about includes > > This CL tests whether we have existing presubmit check to remove > includes that are not needed > > Change-Id: I821b3cefdc82c8bddf8be20a711af5b121822d82 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1879922 > Reviewed-by: Anatoliy Potapchuk <apotapchuk@chromium.org> > Reviewed-by: Oleg Davydov <burunduk@chromium.org> > Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755881} TBR=apotapchuk@chromium.org,burunduk@chromium.org Change-Id: I763613a4d48113c515cae121af544ccc1cb95bdd No-Presubmit: true No-Tree-Checks: true No-Try: true Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133931Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Commit-Queue: Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#755918}
-
Dave Tapuska authored
The tests were not initializing the font correctly nor were they waiting for it to load. This should fix those issues, however the 2d.text.measure.width.space test still fails because of how collapsing whitespace works. Not sure if this a bug in the test or implementation. BUG=1066953 Change-Id: I2f0b81da891e6c701b1c9aa7d8d871615ab0ca28 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132674Reviewed-by:
Fernando Serboncini <fserb@chromium.org> Reviewed-by:
Robert Ma <robertma@chromium.org> Commit-Queue: Dave Tapuska <dtapuska@chromium.org> Cr-Commit-Position: refs/heads/master@{#755917}
-
Evan Stade authored
TBR=kinuko@chromium.org Bug: 1058600 Change-Id: I7eb62790b096cacde13fd0392caa71a7bfc35a7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2131358Reviewed-by:
Evan Stade <estade@chromium.org> Reviewed-by:
Robbie McElrath <rmcelrath@chromium.org> Reviewed-by:
Natalie Chouinard <chouinard@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#755916}
-
Jonathan Ross authored
This reverts commit 55ee8df4. Reason for revert: This test is flaking at 10% rate. It is dealing with a race condition inside the GPU frame submission code path. We are disabling it until someone has the time to sort out the root cause. Original change's description: > Revert "Disable WebBluetoothTest.WebBluetoothAfterCrash" > > This reverts commit cc673fd0. > > Reason for revert: Unable to reproduce test flakiness. > > Original change's description: > > Disable WebBluetoothTest.WebBluetoothAfterCrash > > > > See details in: > > https://analysis.chromium.org/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVySQsSBUZsYWtlIj5jaHJvbWl1bUBicm93c2VyX3Rlc3RzQFdlYkJsdWV0b290aFRlc3QuV2ViQmx1ZXRvb3RoQWZ0ZXJDcmFzaAw > > > > TBR=reillyg@chromium.org > > > > Bug: 1022321 > > Change-Id: I01fcb892eea350bc60a05fc8f5b1aab9088cffc1 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1904191 > > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > > Commit-Queue: Hongchan Choi <hongchan@chromium.org> > > Auto-Submit: Hongchan Choi <hongchan@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#713544} > > Bug: 1022321 > Change-Id: I8bc50f7c4328cf4da82e6e4230a4a9b1fe1365cd > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2121347 > Reviewed-by: Hongchan Choi <hongchan@chromium.org> > Commit-Queue: Reilly Grant <reillyg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#753452} TBR=reillyg@chromium.org,hongchan@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 1022321 Change-Id: Ic835ad85cb0b30a3cb2778aa237f926f92ffeb81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134574Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Jonathan Ross <jonross@chromium.org> Cr-Commit-Position: refs/heads/master@{#755915}
-
Nate Fischer authored
This re-enables a flaky test which has been disabled the last few years. It seems OK locally, so let's see if it flakes on the bots. Bug: 653307 Test: run_webview_instrumentation_test_apk --num_retries=0 Test: --break-on-failure --repeat=1000 Test: -f MediaAccessPermissionRequestTest.* Change-Id: I5aa806a2087c031ef674278f8c50f2ff4c6eb1f6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134575 Commit-Queue: Nate Fischer <ntfschr@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755914}
-
Lambros Lambrou authored
WebRTC recommends not setting the min-bitrate. This setting makes sense only in the simulcast/SVC case, where higher streams would be disabled if there's not enough bitrate for them. Bug: 1067091 Change-Id: Ief47cd36cb00a8f9f576e78f64d111e831bb83a7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133409Reviewed-by:
Jamie Walch <jamiewalch@chromium.org> Commit-Queue: Lambros Lambrou <lambroslambrou@chromium.org> Cr-Commit-Position: refs/heads/master@{#755913}
-
sauski authored
This CL further brings into alignment with design specifications the style of newly introduced collapsible radio toggles on the Security & Cookies pages. A new "data" icon is also introduced representing a vertical bar chart. Bug: 1061947 Change-Id: I9cf8c3662227ec33da5227118acab750da0110d4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129706Reviewed-by:
dpapad <dpapad@chromium.org> Commit-Queue: Theodore Olsauskas-Warren <sauski@google.com> Cr-Commit-Position: refs/heads/master@{#755912}
-
Vladimir Levin authored
This patch removes all unlocking from the activation signal code path. This is in line with the proposed spec: auto unlocks only on selection, focus, and visibility. Hidden-matchable issues an event but does not unlock. R=chrishtr@chromium.org Change-Id: Id47e1edcf4a2042e286ce50943f5c5b4a6b5fc4a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134571Reviewed-by:
Chris Harrelson <chrishtr@chromium.org> Commit-Queue: vmpstr <vmpstr@chromium.org> Cr-Commit-Position: refs/heads/master@{#755911}
-
gogerald authored
This CL also disables Tab to GTS animation for single start surface, since it looks bad and does not work for single tab tab switcher. Screen records: https://drive.google.com/a/google.com/file/d/1iqIPfeI3GFyfNtz4rHijhlpH4TTbQE_j/view?usp=sharing TODO: remove 'group tabs' from the menu when showing single tab view. Binary-Size: Size increase is expected. Bug: 1065902 Change-Id: I244275e809fefbe4e9106f852fe383201ac1e123 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2125455 Commit-Queue: Ganggui Tang <gogerald@chromium.org> Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755910}
-
Tobias Sargeant authored
Test: manual; compile weblayer provider with is_chrome_branded=true Bug: 1025612 Change-Id: Ia56a1fc07cf896129d1bdd1845c8e647e66bfc17 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134293Reviewed-by:
-
Robert Ogden authored
Adds a test for the proxy returning an auth challenge. Manually tested that a proxied auth challenge from the origin also shows no dialog, but adding a test for that is blocked on crbug/1042829. Bug: 1023485 Change-Id: I73ac536c7afb80300915734ef239a2cd0c7f7f25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134607Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Commit-Queue: Robert Ogden <robertogden@chromium.org> Cr-Commit-Position: refs/heads/master@{#755908}
-
David Dorwin authored
Bug: 1067101 Change-Id: I17e0d681a593c9e207a67b6c1b7f3aab32bbcd2d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133388Reviewed-by:
Kevin Marshall <kmarshall@chromium.org> Commit-Queue: Kevin Marshall <kmarshall@chromium.org> Cr-Commit-Position: refs/heads/master@{#755907}
-
Peter Wen authored
Curtesy of cushon@: There are javac flags that tell it to stop at a particular compilation phase: -XDshould-stop.ifNoError=FLOW should allow Error Prone to run but stop the compilation before code is generated. 4 seconds faster for chrome_java errorprone. (55s -> 51s). 5.2s faster for Base Java Signature Change (153.6s -> 148.4s). Saves 192.9s elapsed time for Base Java Signature Change. 4552.2s -> 4359.3s Bug: 906803 Change-Id: I0708cafea2f95ba50df7697d753ea3e930d1330c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134192Reviewed-by:Andrew Grieve <agrieve@chromium.org> Commit-Queue: Andrew Grieve <agrieve@chromium.org> Auto-Submit: Peter Wen <wnwen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755906}
-
John Budorick authored
This reverts commit 4297d4c9. Reason for revert: widespread failures in DownloadManagerTestCase.testDownloadWhileBrowsing see e.g. https://ci.chromium.org/p/chromium/builders/ci/ios-simulator/53545 Log includes: Exception Reason: containsText is false: Failed waiting for web state containing Google Chrome Terms of Service Original change's description: > Reland "Update TOS" > > Updated the iOS UI test. > > This reverts commit 9033a96c. > > Original change's description: > > Revert "Update TOS" > > > > This reverts commit f88c2f7c. > > > > Reason for revert: Widespread ios bot failures. auto-rollers are blocked. > > > > Original change's description: > > > Update TOS > > > > > > Bring chrome://terms in line with > > > https://www.google.com/chrome/terms/ > > > > > > Bug: 1060545 > > > Change-Id: I823aa5bdf51c55488777ebb18406b79f9887e6b9 > > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2120046 > > > Reviewed-by: Mike Pinkerton <pinkerton@chromium.org> > > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > > Reviewed-by: Ben Mason <benmason@chromium.org> > > > Cr-Commit-Position: refs/heads/master@{#755585} > > > > TBR=pinkerton@chromium.org,tedchoc@chromium.org,benmason@chromium.org > > > > Change-Id: Ibb4b4c39eff4b9a4276a4e3d64e5ae8552b47452 > > No-Presubmit: true > > No-Tree-Checks: true > > No-Try: true > > Bug: 1060545, 1067086 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2132554 > > Reviewed-by: Trent Apted <tapted@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#755690} > > TBR=tapted@chromium.org,pinkerton@chromium.org,tedchoc@chromium.org,benmason@chromium.org > > Change-Id: I27b47f7f79a00e9f5e3275e7e3de285c1234cc87 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 1060545, 1067086 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133873 > Commit-Queue: Ben Mason <benmason@chromium.org> > Reviewed-by: Ben Mason <benmason@chromium.org> > Reviewed-by: Mike Pinkerton <pinkerton@chromium.org> > Cr-Commit-Position: refs/heads/master@{#755838} TBR=tapted@chromium.org,pinkerton@chromium.org,tedchoc@chromium.org,benmason@chromium.org Change-Id: I7f762b91f96cf0956579c35285245d9485ba34ee No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 1060545, 1067086 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134766Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#755905}
-
Wez authored
Add the ICU timezone data configuration path to the namespace of all sandboxed processes, so that all Chromium processes run with a consistent set of timezone data. Bug: fuchsia:45462, 1067309 Change-Id: Id78f30ce9e07326a8037d6222210dcab60385e15 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2130214 Commit-Queue: Wez <wez@chromium.org> Reviewed-by:
David Dorwin <ddorwin@chromium.org> Reviewed-by:
Sergey Ulanov <sergeyu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755904}
-
Yulun Wu authored
The gestures being tracked are: Back Gesture Home to Overview Gesture In App Shelf to Home Gesture The metrics being tracked are: Time between showing nudge and user performing gesture How the nudge is being dismissed (kOther, kPerformedGesture, kTap, kSwitchToClamshell, kExitToHomeScreen, kTimeout) Bug: 1055694 Change-Id: Ia7756d4cd4d0f9fff1184807f1b83acae4bf5f43 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2086074Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Reviewed-by:
Xiaoqian Dai <xdai@chromium.org> Commit-Queue: Yulun Wu <yulunwu@chromium.org> Cr-Commit-Position: refs/heads/master@{#755903}
-
Antonio Gomes authored
In the early days, this test was written to accommodate the case where CSS Grid was under development, and possible to be toggled on/off at runtime. Now that CSS is Grid in stable for years, we can simplify the test's JS code, and rewrite most of the page in pure HTML. BUG=1063749 R=jfernandez@igalia.com Change-Id: I558ba15bddd252c2f5fefb236cf630f3d08533f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133918Reviewed-by:
Javier Fernandez <jfernandez@igalia.com> Commit-Queue: Antonio Gomes <tonikitoo@igalia.com> Cr-Commit-Position: refs/heads/master@{#755902}
-
Khushal authored
If an ImageBitmap is created using an image element, it should always wrap the decoded data. Currently this is done conditionally based on whether alpha conversion is required. R=fserb@chromium.org Bug: 1063679 Change-Id: I670a72eeb9d95cc6c0596aa1642bb7293372a8bf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133051 Auto-Submit: Khushal <khushalsagar@chromium.org> Commit-Queue: Fernando Serboncini <fserb@chromium.org> Reviewed-by:
-
John Z Wu authored
If a new card was entered with an already expired date, we may prompt the user to fix it up before uploading. Bug: 1066690 Change-Id: Iff960a26a512dc66e6f356190e0524b63cba362c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133552 Commit-Queue: John Wu <jzw@chromium.org> Reviewed-by:
Hiroshi Ichikawa <ichikawa@chromium.org> Cr-Commit-Position: refs/heads/master@{#755900}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/75a2ee30c3ec..a053f340a44c git log 75a2ee30c3ec..a053f340a44c --date=short --first-parent --format='%ad %ae %s' 2020-04-02 thakis@chromium.org Vulkan: Use shader stage specific barrier Created with: gclient setdep -r src/third_party/angle@a053f340a44c If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: cwallez@google.com Change-Id: I3d84b649f8181f8b3961c48b6322e5cb8335c878 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134355Reviewed-by:
-
Peter Kasting authored
Switching from BrowserWithTestWindowTest to ChromeViewsTestBase lets us use utilities like set_native_widget_type() and CreateTestWidget(). This also removes some unnecessary code and makes more use of CreateBookmarkModelAndBookmarkBarView(). Bug: none Change-Id: I655ea33a5d213d2e5d1a54528b00105bb24e48c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2081334Reviewed-by:
-
Chromium WPT Sync authored
Using wpt-import in Chromium d2bc86c2. With Chromium commits locally applied on WPT: d0ad7cf8 "UpgradeInsecureRequest: Add WPTs for static-import in dedicated/shared workers" 2688e49a "De-flake two lazyload WPT tests." 8fa00285 "[webauthn] Fix resident key credentials.get() WPT" edb8adb1 "Implement and ship RTCRtpSendParameters.degradationPreference" 2fb88bb8 "Use integer coordinates for Actions.pointerMove." b60ed2ad "[Trusted Types] Add test cases for svg:script." Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md Directory owners for changes in this CL: hbos@chromium.org, hta@chromium.org: external/wpt/webrtc NOAUTOREVERT=true TBR=lpz No-Export: true Change-Id: Idfaaa4103c8aa98293e904302160493f0d065c7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133916Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#755897}
-
Ben Joyce authored
We've been using a manually modified build.gn file because of the androidx migration. If you just run fetch_all.py, it should generally do nothing. When updating a library, users have to manually patch in the differences to not override the manual changes. These are changes that are not part of the manual modifications that haven't been incorporated into the build.gn It looks like the manual modifications may be in for longer than we'd like as weblayer/public can't update and a few third_party code won't migrate soon, so will look into making the local modifications not need a manual patch. Additionally, build.gradle was downloading espresso 3.2, but the DEPS is pointing to 3.1, so sync up those numbers. Change-Id: I3cbad618e9db2a46d06624287510963756c0d622 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133266Reviewed-by:
-
Zhongyi Shi authored
This change is to verify that integer value of quic flag is handled correctly. Bug: 1005610 Change-Id: I8cdbf1e365ed4cb3afa3e892b09ef3000fd9d06f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133226Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Zhongyi Shi <zhongyi@chromium.org> Cr-Commit-Position: refs/heads/master@{#755895}
-
Daniele Castagna authored
crrev.com/c/2103721 added a flag to toggle the optimization. The flag was disable by default so that it can be merged back (hopefully without any conflict) to 81. This patch reenables the feature on ToT by default. Bug: 1061708 Test: viz_unittests without scopedfeature Change-Id: Ibabc573a42c0750552982d02d3471798f59eb0f1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2103722 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Gil Dekel <gildekel@chromium.org> Reviewed-by:
Sasha McIntosh <sashamcintosh@chromium.org> Cr-Commit-Position: refs/heads/master@{#755894}
-
Stephen McGruer authored
On Chromium CI, this occasionally dips above 6s and times out. Looks like its just a bit slow, not hanging entirely, so giving it more time to finish seems ok. Bug: 1033652 Change-Id: I1ea1ee51b19500aa99bbb318a8124abfce7abef3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2115517 Commit-Queue: Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
-
Jonathan Backer authored
Skia added a new API to surface VK_ERROR_DEVICE_LOST to us. SharedContextState::MakeCurrent is called regularly before different clients (e.g. SkiaRenderer and OOP-R) access Skia. This should be frequent enough. Bug: 1066140 Change-Id: If03e72ca493b3d76b11bdee612f95f01cfaff5cc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134486 Commit-Queue: Jonathan Backer <backer@chromium.org> Commit-Queue: Peng Huang <penghuang@chromium.org> Auto-Submit: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755892}
-
Robert Ogden authored
Most of the metrics are coming from the TabHelper's Metrics struct, but the prefetch usage enum comes from the interceptor, by way of the TabHelper. prefetch_usage is read on commit since that value is set between navigation start and commit and does not change afterwards. prefetch_metrics is trickier. It may update numerous times while a user is sitting on a Google SRP page and won't stop getting written to until the following commit (or tab destruction). Since PLM's OnComplete is called after the following commit (not helpful) or at tab destruction (helpful), the PLM observer can't read prefetch_metrics during OnComplete because the metrics would be wrong whenever another navigation happened in the same tab. The implemented solution to this timing mess is to make the prefetch metrics struct into a RefCounted class. Then the PLM Observer will get an additional ref (only by being a friend) and hang on to it until all needed metrics have been recorded, which happens after the tab helper has moved on to the next page. Triggering the PLM Observer to get a ref to the metrics class is done with a PLM Event. This is done for two reasons, 1) because we can't rely on the order in which |DidFinishNavigation| is called for WCO's and 2) because using a PostTask off of OnCommit was still too early in my testing. Furthermore, using a PLM event allows the observer to only take the metrics ref when it will actually be used. This is done by only sending the event when an eligible navigation prediction is made and is being acted on. Bug: 1064726 Change-Id: I5de582650e2d29f7d62f2871cd1b7db5a72144fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129231Reviewed-by:
Ryan Sturm <ryansturm@chromium.org> Reviewed-by:
-
Jose Lopes authored
This closure is run as part of a factory method, therefore it can be run repeatedly: * https://source.chromium.org/chromium/chromium/src/+/master:media/base/mock_filters.cc;drc=d9b91db0b32bcaed524db17b05f614c7e86326bc;l=232 This is part of the base::Callback migration. Context: http://doc/1J4N3V5UmzZL9BZGNrn95E4xJu4cz3ynbg21zXR-J_qA#heading=h.uxpxu8vg4k4r Bug: 1007805 Change-Id: Ied0c7ed6476c29577bf02821a54c71fdf361dd8a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2111096 Commit-Queue: Jose Lopes <jabolopes@google.com> Auto-Submit: Jose Lopes <jabolopes@google.com> Reviewed-by:
Xiaohan Wang <xhwang@chromium.org> Cr-Commit-Position: refs/heads/master@{#755890}
-
behdad authored
If reporter in in Commit stage, the OnFinishImplFrame should flag the reporter, so that in case of submit the Impl portion of reporter would be ready for submission. Bug: chromium:1067245 Change-Id: I05b9888e37d74b4b9346965153616e9b29e0b078 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133875 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
Sadrul Chowdhury <sadrul@chromium.org> Cr-Commit-Position: refs/heads/master@{#755889}
-
behdad authored
All latency which is reported without specifying the interaction should also be reported under MissedDeadline category TBR=schenney@chromium.org Bug: none Change-Id: I81c6b40c5d4579cbfdee32809c4c465fe94a2d39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133878 Commit-Queue: Behdad Bakhshinategh <behdadb@chromium.org> Reviewed-by:
-
Wenbin Zhang authored
Add another argument to separate tester workflow and processor workflow. Bug: chromium:1045256 Change-Id: Ib9971ea5f194d1dc6bf8663e4a0c69e5911e027c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133374 Commit-Queue: Wenbin Zhang <wenbinzhang@google.com> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#755887}
-
Lukasz Anforowicz authored
The only test (BrowserAction*Test.BrowserActionPopup) that used to rely on ExtensionActionTestHelper::GetPopupSize was disabled for a long time. In the meantime, GetPopupSize stopped working (e.g. it would crash with a null dereference when not being able to find a native widget associated with the popup). This CL re-enables the test (the focus-related flakiness should be fixed by r754788) and makes the test use content::WebContents::GetContainerBounds instead of ExtensionActionTestHelper::GetPopupSize. After this CL, the GetPopupSize helper test method is no longer needed and can be removed. Additionally, the CL removes one additional cause of test flakiness by making sure that the resizing of the popup has actually propagated all the way to the content::WebContents::GetContainerBounds by 1) waiting until layout happens (by having the test go through requestAnimationFrame) and 2) by waiting until the layout results have gone through compositing (by having the test wait for MainThreadFrameObserver). Bug: 1021172 Change-Id: I84cdd6934d621dfed9ec783fbd0e21d172387fee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2129211 Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Reviewed-by:
Karan Bhatia <karandeepb@chromium.org> Reviewed-by:
Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#755886}
-
Lily Chen authored
Bug: 1066615 Change-Id: I661d23b59caa5d7d6e1a42b4c78575115048151f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2133080Reviewed-by:
David Benjamin <davidben@chromium.org> Reviewed-by:
Luke Halliwell (slow) <halliwell@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#755885}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/c6b2f34f358b..55c991cc81ae git log c6b2f34f358b..55c991cc81ae --date=short --first-parent --format='%ad %ae %s' 2020-04-02 marinaciocea@webrtc.org [InsertableStreams] Save the transformer to be set on Reconfigure. 2020-04-02 ilnik@webrtc.org Calculate video padding for vp9 in the same way as for vp8 2020-04-02 sakal@webrtc.org Delete legacy MediaCodec HW codec integration. 2020-04-02 titovartem@google.com Extract test peer creation into separate file Created with: gclient setdep -r src/third_party/webrtc@55c991cc81ae If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1052765 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I657effd393041139590d6737c7aebae11fb48c0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2134353Reviewed-by:
-
Renato Silva authored
- Enable marketing opt-in screen for clamshell mode. Previously disabled. - Change command line switch to feature. - Enable the marketing screen by default - Update the styles on the marketing opt-in screen. - Prepare the screen to be attached to the new ChromebookEmail component that will be added. - Fix broken tests. Fixed: 1023370 Change-Id: Iaa4f7b595452afafd5d501ca28991b06ea204b1e Bug: 1023370 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2127926 Commit-Queue: Renato Silva <rrsilva@google.com> Reviewed-by:
Denis Kuznetsov [CET] <antrim@chromium.org> Reviewed-by:
Roman Sorokin [CET] <rsorokin@chromium.org> Cr-Commit-Position: refs/heads/master@{#755883}
-
