GitLab

This helps people figure out how to file bugs for stuff in that
directory.

Change-Id: I88cde6f209fcbd710a011b57df390a558bfdfca6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795495Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Dirk Pranke <dpranke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695288}

Removes code that was used to scaled the app list main view on small
screens (when apps grid did not fit into the available space).

CL:1759856 changed approach to update the item sizes inside the apps
grid instead. The following is thus no longer necessary:
*   AppsContainerView::GetMinimumSize() override
    -   was used to calculate whether and what scale to use (the usage
        has been removed; not used during container layout
*   ContentsView::GetAppListMainViewScale()
    -   the scale transform on the main view does not get set any
        longer, so the scale should always be 1

Change-Id: I2bcafd63b7e34c2c40167d365cfbe83b192f71e6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789467Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Commit-Queue: Toni Baržić <tbarzic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695287}

Previously we were using a private API to force the user to do
a full Google signin after gellerization.  Instead, we now use
UserManager::SaveForceOnlineSignin, which is the public API for
this purpose.

Also reverts changes to signin_metrics enum from http://crrev.com/c/1786857

Bug: 1000948
Change-Id: I287bc86b1d719f11d0da0c6bb6ef09fcfd355987
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789827Reviewed-by: David Roger <droger@chromium.org>
Reviewed-by: Michael Giuffrida <michaelpg@chromium.org>
Reviewed-by: Kush Sinha <sinhak@chromium.org>
Commit-Queue: Danan S <danan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695286}

Adds expires_after attribute for 146 histograms that do not show
any access in the past 120 days.

Change-Id: I1c7e0fbe985dfd2c813f93d677e2d4fe2f58f038
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796263
Commit-Queue: Brian White <bcwhite@google.com>
Commit-Queue: Brian White <bcwhite@chromium.org>
Reviewed-by: Brian White <bcwhite@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695285}

This CL adds debug markers methods (pushDebugGroup, popDebugGroup, and
insertDebugMarker) to GPUCommandEncoder.

Bug: 877147
Change-Id: I19d13e2f2c61ab58bb0cb9b266e9ef69b285bbb8
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1732078Reviewed-by: Corentin Wallez <cwallez@chromium.org>
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Cr-Commit-Position: refs/heads/master@{#695284}

Using wpt-import in Chromium d249d6d6.
With Chromium commits locally applied on WPT:
999a3129 "[LayoutNG] Fix line breaking behavior after out-of-flow objects"
b48cdedb "Add feature-detectable API for Scroll To Text"
cf88186a "[LayoutNG] Fix `vertical-align: top` and `bottom`"


Note to sheriffs: This CL imports external tests and adds
expectations for those tests; if this CL is large and causes
a few new failures, please fix the failures by adding new
lines to TestExpectations rather than reverting. See:
https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md

Directory owners for changes in this CL:
foolip@chromium.org, lpz@chromium.org, robertma@chromium.org:
  external/wpt/tools

NOAUTOREVERT=true
TBR=lpz

No-Export: true
Change-Id: Ie045406195eebd26cb6e97002cf47493095beb25
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795666Reviewed-by: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695283}

Change-Id: I5ba202a48eea74c9cde518e062d1669b71638238
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796542
Commit-Queue: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Juan Antonio Navarro Pérez <perezju@chromium.org>
Auto-Submit: Sami Kyöstilä <skyostil@chromium.org>
Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695282}

https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/c9800e5adb7a..66d325b6e26e


Created with:
  gclient setdep -r src-internal@66d325b6e26e

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll
Please CC jbudorick@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chrome.try:linux-chromeos-chrome
TBR=jbudorick@google.com

Bug: chromium:None
Change-Id: Ibc25eb9e52def586c531172b9a4229e7d90d8a6a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796628Reviewed-by: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695281}

Use the PRETTY_NAME variable from /etc/os-release (or
/usr/lib/os-release) to get the "pretty operating system name in a format
suitable for presentation to the user" as the standard says.

This could allow us to drop a requirement on lsb_release binary on
Linux. The os-release is presented on most new distribution like Fedora,
RHEL 7, CentOS 7, Ubuntu 12.04+, Debian Wheezy+.

More information could be found on
https://www.freedesktop.org/software/systemd/man/os-release.html.

Bug: 420439
Change-Id: If4fc3cd3d22507e47b32d6184ac6ef4ae4b4ff3f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1156504
Commit-Queue: Tomáš Popela <tomas.popela@gmail.com>
Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Thomas Anderson <thomasanderson@chromium.org>
Auto-Submit: Tomáš Popela <tomas.popela@gmail.com>
Cr-Commit-Position: refs/heads/master@{#695280}

All active apps have been moved into the hotseat. The hotseat is
dismissable in tablet mode, this means users should have more space.
The usefulness of this feature will be more apparent after in-app shelf
is landed.

Hotseat Properties:
 - In tablet mode can be either Shown (old behavior),
   Hidden(off screen), or Extended (floating above the shelf).
 - In clamshell mode, the hotseat is always Shown.
 - The hotseat hides when the background is interacted with.
 - The hotseat is draggable.

Other changes to facilitate the hotseat, included in this patch:
 - Instead of maintaining target home launcher position, maintain
   the animation state. This simplifies some of our old logic.

Future changes:
 - Hotseat should have a background.
 - Hotseat should gracefully handle keyboard nav/screen reader.

Bug: 973482
Change-Id: I018cecda768e13a453475a6aef0adc5d9da0ac44
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787399
Commit-Queue: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Alex Newcomer <newcomer@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Manu Cornet <manucornet@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695279}

Thanks thakis@ :)

CC=thakis@chromium.org
R=agable@chromium.org

Bug: None
Change-Id: Ida6a7bcf5f59178d39546eb9f1c0d2c6810366cd
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796202Reviewed-by: Aaron Gable <agable@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695278}

The initial/unset value for background-position is 0% 0%, so any
interpolation from/to that involves a calc with a percentage in it.  By
the calc spec, calcs with percentages in them are not resolved when
getting the computed value - even if the percentage is 0%.

The test shouldn't pass in Chrome after this CL, but does anyway as it
resolves the expected values to not include percentages either!

See https://bugzilla.mozilla.org/show_bug.cgi?id=1574913 for where we
discovered the test was wrong.

Bug: 1002430
Change-Id: Ibacb8f9e1745f13cd2fe92894ac0f8e67e3228fa
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795842Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Commit-Queue: Stephen McGruer <smcgruer@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695277}

It is unlikely that a url needs to match multiple allowlists.
Change the startAllowlistLookup signature to only support a single
threat type.

Bug: 999344
Change-Id: I717a94ee11e50a66bb87fd7af71754b82cf2dc1a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793811Reviewed-by: David Trainor <dtrainor@chromium.org>
Reviewed-by: Varun Khaneja <vakh@chromium.org>
Reviewed-by: Nate Fischer <ntfschr@chromium.org>
Commit-Queue: Xinghui Lu <xinghuilu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695276}

Previous CLs have added NetworkIsolationKey support to broken-
alternative-services-related HttpServerProperties methods,
but they were still being passed empty NetworkIsolationKeys
by consumers. This CL makes consumers pass in the correct NIK,
and adds tests for all callsites.

Bug: 969890
Change-Id: I5b3d7947bfe91f7fcc6a19bcf30c399dd8f49d8a
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782666Reviewed-by: Zhongyi Shi <zhongyi@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695275}

This is by no means extensive and more patches will follow to do dark
styling of forms when used color-scheme is dark.

Since color-scheme is behind a flag, this should not cause any
behavioral changes.

Bug: 939811
Change-Id: I75d825c8641c6ed8d20b43b5261d3aee90daad68
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795582Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695274}

Change-Id: If1188ff1379ad743f85f8cdbb0e30b3943cbe38f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796742
Commit-Queue: Eric Roman <eroman@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Auto-Submit: Eric Roman <eroman@chromium.org>
Reviewed-by: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695273}

This is required to promote our finch study to Beta and Stable (once
stable finishes releasing that is). We don't expect any noticeable
performance impact.

Bug: 980536
Change-Id: I7913529a00b12c2213c42d2785f5feaf3107372e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793092
Auto-Submit: Stephen Nusko <nuskos@chromium.org>
Commit-Queue: Jesse Doherty <jwd@chromium.org>
Reviewed-by: Jesse Doherty <jwd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695272}

https://skia.googlesource.com/skia.git/+log/2ab2ac03d8ee..f57b7cb8f0bc

git log 2ab2ac03d8ee..f57b7cb8f0bc --date=short --no-merges --format='%ad %ae %s'
2019-09-10 recipe-mega-autoroller@chops-service-accounts.iam.gserviceaccount.com Roll recipe dependencies (trivial).

Created with:
  gclient setdep -r src/third_party/skia@f57b7cb8f0bc

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/skia-autoroll
Please CC mtklein@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=mtklein@google.com

Bug: None
Change-Id: I63d7a0786a5d4972a470f42c4655135b097fb25c
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795986Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695271}

This change was generated by
//base/android/jni_generator/jni_refactorer.py.

TBR: tedchoc@chromium.org
Bug: 929661
Change-Id: I5a093f1f51876de014a2337e5ce711907109a502
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782676
Commit-Queue: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Andrew Grieve <agrieve@chromium.org>
Auto-Submit: Eric Stevenson <estevenson@chromium.org>
Reviewed-by: Andrew Grieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695270}

https://webrtc.googlesource.com/src.git/+log/29ab487ea7c1..de5f63910e24

git log 29ab487ea7c1..de5f63910e24 --date=short --no-merges --format='%ad %ae %s'
2019-09-10 srte@webrtc.org Removes decoder thread fallback from VideoReceiveStream.

Created with:
  gclient setdep -r src/third_party/webrtc@de5f63910e24

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/webrtc-chromium-autoroll
Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

TBR=webrtc-chromium-sheriffs-robots@google.com

Bug: None
Change-Id: I0a6e401141ca2df371713a06229438d7c7454776
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795988Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695269}

Per the updated comps, the color picker should use a sans-serif font.
Making that change in color_picker.css, and also updating baselines for
pixel tests.

Bug: 1001576
Change-Id: Iaa2a65ba574ad6f3e46aea82a009301273582723
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792790Reviewed-by: Kent Tamura <tkent@chromium.org>
Reviewed-by: Mason Freed <masonfreed@chromium.org>
Commit-Queue: Sanket Joshi <sajos@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#695268}

This CL adds the logic to enumerate over FPDF_LINKs and populate link
annotations' data with its underlying text range in |links_| vector in
PDFiumPage. A test is added to validate that the link annotations are
correctly populated for a page.

Bug: 981448
Change-Id: I6569e939c4a2309cc598f5062dec0e396ca818b9
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1736886Reviewed-by: Lei Zhang <thestig@chromium.org>
Reviewed-by: Kevin Babbitt <kbabbitt@microsoft.com>
Commit-Queue: Mansi Awasthi <maawas@microsoft.com>
Cr-Commit-Position: refs/heads/master@{#695267}

This CL follows up on a comment [1], where instead of forcing clients
to make the context current and then call either CreateSharedImage or
UpdateSharedImage, it is suggested to have public methods bundling those
operations in SharedImageStub.  This CL does just that, making the
current OnCreateGMBSharedImage and OnUpdateSharedImage use the newly
introduced ones.

[1] https://chromium-review.googlesource.com/c/chromium/src/+/1772642/30/media/gpu/linux/mailbox_video_frame_converter.cc#361

Bug: 998279
Change-Id: If39d94b04d2851e6ed8e248e9af96908dfa27e8e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794274Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Miguel Casas <mcasas@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695266}

We are trying to prioritize loading and composting tasks until FCP
and when enabled this test fails. Upon investigation it turned out
the test script was starting before the link tag resources had loaded.

Starting the test in a window.onload handler fixes the issue.

Bug: 971191
Change-Id: I9d4f99a5cac86970606dd6c9b4ab2416ccaac2ad
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1782814Reviewed-by: Sami Kyöstilä <skyostil@chromium.org>
Commit-Queue: Alex Clarke <alexclarke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695265}

* Added OnMouseEnter to PlatformWindow{Delegate}
* Updated DRM/X11 impl to call it when the mouse location enters it.

and chrome for chromeos on linux desktop.

Bug: 990589
Test: X11WindowOzoneTest.MouseEnterAndDelete, manually tested on device
Change-Id: I452c34ef0019f10d20d1096ef608cf84dd3a73db
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1761772
Commit-Queue: Mitsuru Oshima <oshima@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Michael Spang <spang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695264}

This function is unused.

Bug: None
Change-Id: Ic0c39655a6ea8087dbfbf2150e4d1478163b06e5
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795756Reviewed-by: kylechar <kylechar@chromium.org>
Commit-Queue: Yi Gu <yigu@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695263}

Move the status sync to prevent timing issues.

Bug: None
Test: Manual Test
Change-Id: I2e2847c07a4125d830a423ab9e5c4e454f891de3
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1788176
Commit-Queue: Yue Li <updowndota@chromium.org>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695262}

Details are in the new, improved documentation. But MoveWebContentsAt()
will now never leave a group in a non-contiguous state.

Also, did some fixup in the unit tests to support testing of the new
functionality.

Bug: 915956
Change-Id: Ibd83249ebbaeb74e50f6805dc626c26c0291f86e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793544Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Commit-Queue: Dana Fried <dfried@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695261}

This reverts commit 797ebfdc.

Reason for revert: Fixed minor build issue causing initial revert.

Original change's description:
> Revert "Cleanup Android video targets"
>
> This reverts commit 9c44fedd.
>
> Reason for revert: broke https://ci.chromium.org/p/chromium/builders/ci/android-jumbo-rel/13515
>
> Original change's description:
> > Cleanup Android video targets
> >
> > Fixes WebView component build issues.
> >
> > Previous CLs introduced a number of new targets including
> > texture_owner_android and shared_image_video. These were causing build
> > problems due to duplicate file compilation which led to DCHECKs.
> >
> > Moved most of these files into gpu/command_buffer/service:gles2, as
> > they all depended on this target (so no new transitive deps), and it's
> > probably a good place for them for now and simplifies dependency
> > management.
> >
> > Bug: 996285
> > Change-Id: Ic5a9cced7e67500cfd5fff8809d4ee5e17bbab8b
> > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1787165
> > Reviewed-by: Frank Liberato <liberato@chromium.org>
> > Reviewed-by: Nasko Oskov <nasko@chromium.org>
> > Reviewed-by: vikas soni <vikassoni@chromium.org>
> > Auto-Submit: Eric Karl <ericrk@chromium.org>
> > Commit-Queue: Eric Karl <ericrk@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#695006}
>
> TBR=kinuko@chromium.org,nasko@chromium.org,liberato@chromium.org,ericrk@chromium.org,vikassoni@chromium.org
>
> Change-Id: Ib51ec09046ecfa51543836755b6b830d76fbce94
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 996285
> Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793931
> Reviewed-by: Tao Bai <michaelbai@chromium.org>
> Commit-Queue: Tao Bai <michaelbai@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#695062}

TBR=michaelbai@chromium.org,kinuko@chromium.org,nasko@chromium.org,liberato@chromium.org,ericrk@chromium.org,vikassoni@chromium.org

Change-Id: I35661eb7691dbbacb063e308513daca68efcff75
Bug: 996285
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796110Reviewed-by: vikas soni <vikassoni@chromium.org>
Reviewed-by: Tao Bai <michaelbai@chromium.org>
Reviewed-by: Frank Liberato <liberato@chromium.org>
Reviewed-by: Eric Karl <ericrk@chromium.org>
Commit-Queue: Eric Karl <ericrk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695260}

In ShelfLayoutManagerTest::ShelfUpdatedWhenStatusAreaChangesSize,
it assumes that the shelf view fills the display space. It will be
incorrect under new specs. In ShelfLayoutManagerTest::RtlPlacement,
the test fails to reset the RTL setting. This CL fixes these two tests.

Bug: 1002576
Change-Id: I9dc2a82f5dab18c33e6947e21112af5aa4913f0e
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1796118
Commit-Queue: Andrew Xu <andrewxu@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695259}

We can't use base in the public API, so this makes a copy of ObserverList.

BUG=none
TEST=none

Change-Id: Ia346c8a5c11204c9ee8e77a2a0c2ca861f25543f
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793782Reviewed-by: John Abd-El-Malek <jam@chromium.org>
Commit-Queue: Scott Violet <sky@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695258}

This CL adds a highlight to the GMC toolbar button when the in-product
help is shown.

Bug: 991585
Change-Id: I6911ba92d323e859bfb95e7d43173ef53a669d71
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1790044Reviewed-by: Collin Baker <collinbaker@chromium.org>
Commit-Queue: Tommy Steimel <steimel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695257}

The purpose of this cl is to prevent the tests from crashing
on all platforms when running in a batch.

The Task Runner outlives the PooledTaskRunnerDelegate,
which it holds a reference too.
This causes failure in batch test run.

Bug: 1002573
Change-Id: I5fca10116e7b40a2b70bf867d55165b8b5825708
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1794303Reviewed-by: Derek Schuff <dschuff@chromium.org>
Commit-Queue: Ilia Samsonov <isamsonov@google.com>
Cr-Commit-Position: refs/heads/master@{#695256}

This CL removes some leftovers of the old parser.

Bug: 949519
Change-Id: I8f94cc9367752da83a20906b238f68eb5ea0a784
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1789539
Commit-Queue: Vadym Doroshenko <dvadym@chromium.org>
Reviewed-by: Vasilii Sukhanov <vasilii@chromium.org>
Reviewed-by: Robert Kaplow <rkaplow@chromium.org>
Auto-Submit: Vadym Doroshenko <dvadym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695255}

The current value is 15ms. We may need to modify this behavior during
experimentation if we find that this threshold is insufficient to give
the user time to digest the event. Early feedback suggests that may be
the case.

Bug: b:140765359
Change-Id: I81586347b374342ef836980a69d86e820b1a0886
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1793750
Commit-Queue: David Black <dmblack@google.com>
Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695254}

If the HARDWARE_VIDEO_DECODER_ONLY Context flag is set, then only
the video codecs which are decodable in hardware are reported as
playable.

* Adds "enable_software_video_decoder" GN flag for Cast Runner.
* Defines new command line switch --disable-software-video-decoders
  for propagating the flag across ContextProvider/Browser and
  Browser/Renderer process boundaries.
* Bypasses software codec factory registration if the switch is set.
* Uses hardcoded temporary logic for defining which codecs are hardware
  accelerated; will be replaced with a check against the Fuchsia
  media codec service later.
* Adds new browser tests to verify the effect of
  --disable-software-video-decoders.

Bug: 1000858
Change-Id: I780bd38eacf7537bfb1ceb52db2bad5a4ed8a879
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1786079
Commit-Queue: Kevin Marshall <kmarshall@chromium.org>
Reviewed-by: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Auto-Submit: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695253}

Reduce the default Run() timeout set by TaskEnvironment from
TestTimeouts::action_max_timeout() to action_timeout(). This typically
reduces the timeout from 30s (45s in Debug) down to 10s.

Sheriffs! This may result in:
- Failures on slow builds, which are not on CQ. Please consider adding
  an #ifdef to restore those builds to action_max_timeout(), rather
  than simply reverting.
- Flakiness in tests which are too close to the new timeout. Please
  consider whether such tests should really be taking so long, and
  whether they can be fixed-forward with a ScopedRunTimeoutForTest
  rather than reverting (see ThroughputAnalyzerTest in this CL).

Bug: 922098
Change-Id: Icd75af79f6d9d3555c91b33ea2566fe7c56cd2f7
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1548382
Commit-Queue: Wez <wez@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Reviewed-by: Maks Orlovich <morlovich@chromium.org>
Auto-Submit: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695252}

https://chromium.googlesource.com/catapult.git/+log/884c81e1703f..1f562b7ad68c

git log 884c81e1703f..1f562b7ad68c --date=short --no-merges --format='%ad %ae %s'
2019-09-10 perezju@chromium.org [Telemetry] Rename story_runner.Run to StorySetRun

Created with:
  gclient setdep -r src/third_party/catapult@1f562b7ad68c

If this roll has caused a breakage, revert this CL and stop the roller
using the controls here:
https://autoroll.skia.org/r/catapult-autoroll
Please CC zhanliang@google.com on the revert to ensure that a human
is aware of the problem.

To report a problem with the AutoRoller itself, please file a bug:
https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=zhanliang@google.com

Bug: chromium:866458
Change-Id: I5de6f69bea96d124e27ea1e1968894e353bf70e0
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1795985Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#695251}

Bug: 992033
Change-Id: I5d79658062e574b7c910af03b0ec0c838c169f05
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1774659
Auto-Submit: Piotr Bialecki <bialpio@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Reviewed-by: Klaus Weidner <klausw@chromium.org>
Commit-Queue: Piotr Bialecki <bialpio@chromium.org>
Cr-Commit-Position: refs/heads/master@{#695250}

Previously the close button in the proactive suggestions view was 16dip
as the view bounds matched the icon bounds.  Now, the icon is still
16dip but the view bounds are increased to 32dip which is also the
standard size across Assistant for buttons.

Bug: b:140669269
Change-Id: I89e8fb9e2027553cec8fb6a8d605ce10ec4cdd67
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1792979Reviewed-by: Xiaohui Chen <xiaohuic@chromium.org>
Reviewed-by: Tao Wu <wutao@chromium.org>
Commit-Queue: David Black <dmblack@google.com>
Cr-Commit-Position: refs/heads/master@{#695249}