- 07 Dec, 2020 40 commits
-
-
Victor Vianna authored
There's been a spike of flakes on this bot following 2020-12-03, let's disable the test. https://findit-for-me.appspot.com/p/chromium/flake-portal/flakes/occurrences?key=ag9zfmZpbmRpdC1mb3ItbWVyVgsSBUZsYWtlIktjaHJvbWl1bUBzeW5jX2ludGVncmF0aW9uX3Rlc3RzQFR3b0NsaWVudFdlYkFwcHNCTU9TeW5jVGVzdC5Vbmluc3RhbGxTeW5jZWQM Bug: 1108172 Change-Id: I3c142419ee690165bde93c9d84fe94a4225a18f7 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577358 Commit-Queue: Jan Krcal <jkrcal@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Cr-Commit-Position: refs/heads/master@{#834184}
-
Robbie Gibson authored
The new ThumbStripMediator handles observing the regular/incognito WebStateLists to add the ViewRevealingVerticalPanHandler as a scrollViewProxy observer. This allows it to get scroll delegate callbacks from the active webstate. This CL also slightly fixes the BVC thumb strip hide/reveal behavior to correctly change the scroll view's content insets as well as the content offset. Bug: 1094335 Change-Id: I006a3e72a06b1e327ce0984cf84bc69c2e95fe7a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2563556Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Chris Lu <thegreenfrog@chromium.org> Commit-Queue: Robbie Gibson <rkgibson@google.com> Cr-Commit-Position: refs/heads/master@{#834183}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/71bbb3b22e98..cf023b3a8cd1 2020-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll SwiftShader from bae138de13ac to 7c84426d2abe (8 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: Ie8cf67c182edc94b1da57edd08c35b1f1229bc26 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577418Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834182}
-
Jérémie Boulic authored
Command: ui/file_manager/base/tools/modules.sh [1] [2] [1] build directory (e.g. out/Release) [2] path of JS file to convert (relative to chromium/src) What does the script do: 1. Update BUILD.gn to enable conversion of JS file. 2. Add exports. 3. Run closure compiler. 4. Parse closure compiler output to retrieve unknown types/variables/functions. 6. Parse these dependencies to find relevant exported types/variables/functions. 7. When found, update BUILD.gn and JS file. Made sure that: The script doesn't add any irrelevant import/export. No duplicate lines are added. Steps 3 to 7 are ran until the closure compiler output 'X error(s), Y warning(s), Z% typed' doesn't change. The closure compiler is ran at least 3 times (except if no imports are found), sometimes more. Bug: 1133186 Change-Id: I1528c8187bc1476d6add1bcb14a0d4fd1b64a4fe Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2550328 Commit-Queue: Jeremie Boulic <jboulic@chromium.org> Reviewed-by:
Luciano Pacheco <lucmult@chromium.org> Cr-Commit-Position: refs/heads/master@{#834181}
-
chromium-autoroll authored
Roll Chrome Win32 PGO profile from chrome-win32-master-1607252866-d41b621d05e6450c8f7df54cb40144efff641518.profdata to chrome-win32-master-1607320769-266f8d6f8ffba3874a821f44f98b77515c76c883.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-win32-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:win-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: If1be95461ed0505f640019f76b5ab274eaea4121 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575504Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834180}
-
Alice Wang authored
This CL cleans up redundant IdentityServicesProvider. Bug: 1152718 Change-Id: Ie056721b377f1a8de747333eafbae7fcaf9daa3b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574844Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Commit-Queue: Alice Wang <aliceywang@chromium.org> Cr-Commit-Position: refs/heads/master@{#834179}
-
Leo Lai authored
BUG=b:172748724 TEST=build ok. Change-Id: I5a882b830c0920d4f721515aacb34464499fba50 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569327Reviewed-by:
Maksim Ivanov <emaxx@chromium.org> Commit-Queue: Leo Lai <cylai@google.com> Cr-Commit-Position: refs/heads/master@{#834178}
-
Jana Grill authored
Adjust the domain placeholder names, descriptions and screenshots in IDS_SETTINGS_UPDATE_REQUIRED_EOL_BANNER_ONE_WEEK and IDS_SETTINGS_UPDATE_REQUIRED_EOL_BANNER_DAYS to prepare them for FlexOrgs and make it easier for the translators to understand the usage of the texts. Additionally replace calls to BrowserPolicyConnectorChromeOS::GetEnterpriseDisplayDomain with calls to BrowserPolicyConnectorChromeOS::GetEnterpriseDomainManager. Bug: b:172683940, b:172683948 Test: Manual Change-Id: I1102446a9d065638a8dd008a751340f6abb6060c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2571878Reviewed-by:
Brian Malcolm <bmalcolm@chromium.org> Reviewed-by:
James Cook <jamescook@chromium.org> Commit-Queue: Jana Grill <janagrill@chromium.org> Cr-Commit-Position: refs/heads/master@{#834177}
-
chrome://predictorsdpapad authored
Bug: None Change-Id: Idf627b30a15a069a44c4d6faf6a63316d6ec38b5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574394 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834176}
-
Rainhard Findling authored
Add two string templates with placeholders that allow for concatenating two other string, without the concatenation leading to incorrect translations. The string tuples are: * |IDS_CONCAT_TWO_STRINGS_WITH_COMMA|: "<string1>, <string2>" * |IDS_CONCAT_TWO_STRINGS_WITH_PERIODS|:"<string1>. <string2>." This CL also extends PluralStringProxy to in one step fetch two plural strings and concatenate them into one string, using the templates above. It also fixes one already existing instance of crbug/1060625 in chrome/browser/ui/webui/settings/safety_check_handler.cc by migrating it to the corresponding string tuple. Translation screenshots: IDS_CONCAT_TWO_STRINGS_WITH_COMMA https://storage.cloud.google.com/chromium-translation-screenshots/6139bb64c11e0f921e8d5951367952b62ecb3fcc IDS_CONCAT_TWO_STRINGS_WITH_PERIODS https://storage.cloud.google.com/chromium-translation-screenshots/f39b3eea7e82b711a29c50f7cc12567bae2a80c3 Bug: 1154630 Change-Id: Ie2cb8383448ecc35933a470b28e56ed0fcc12771 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566821 Commit-Queue: Rainhard Findling <rainhard@chromium.org> Reviewed-by:
Esmael Elmoslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#834175}
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/d90e578fb431..f3b959c00071 2020-12-07 kjlubick@google.com [canvaskit] Respect Exif metadata for animated images. 2020-12-07 kjlubick@google.com [canvaskit] Remove 2d point arrays from API. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/skia-autoroll Please CC jmbetancourt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-blink-rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Cq-Do-Not-Cancel-Tryjobs: true Bug: None Tbr: jmbetancourt@google.com Change-Id: I171f00431365ab42318c88bdf81db637372de65c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576425Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834174}
-
Ramin Halavati authored
ToolbarViewWithExtensionsToolbarMenuTest did not correctly disable Ephemeral Guest profiles when they were enabled by default. This issue is fixed. Bug: 1125474 Change-Id: I4f277c3477d76cf3fee51bcd80c283b2929e2ea5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2573104Reviewed-by:
Bret Sepulveda <bsep@chromium.org> Commit-Queue: Ramin Halavati <rhalavati@chromium.org> Cr-Commit-Position: refs/heads/master@{#834173}
-
Bartek Nowierski authored
De/RecommitSystemPages() have similar properties under POSIX and Fuchsia, since both use over-commit, but the API implementations differ in their optimizations. Update the Fuchsia implementations with the same optimizations as provided for POSIX. Bug: 766882 Change-Id: I34b98db27ed85543e53b3231ec118d0a2409b454 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2558122 Commit-Queue: Bartek Nowierski <bartekn@chromium.org> Reviewed-by:
Chris Palmer <palmer@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Auto-Submit: Bartek Nowierski <bartekn@chromium.org> Cr-Commit-Position: refs/heads/master@{#834172}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/dead315abbf8..b36ad7e1d111 2020-12-07 jacktfranklin@chromium.org [Interaction tests] fix running in out/Release 2020-12-07 sigurds@chromium.org Update readme in front_end/Images 2020-12-07 wolfi@chromium.org [Issues] Add UMA for opening the Issues Tab via the command menu 2020-12-07 yiorsi@gmail.com Add "Copy file name" context menu to Workspace If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1126031,chromium:1153281,chromium:1155120 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: I9c52f61c6075efc7d1a13372d65d891884f7273c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575509Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834171}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/731e67da3620..682b3e2b91af If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC grt@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: grt@google.com Change-Id: Ifc9ca19658c01ad31e86105980766b2d31a3b0af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575634Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834170}
-
Kent Tamura authored
OOF descendants of a fieldset should not be contained by the fieldset because they should be scrolled together with the fieldset contents. This CL makes an anonymous fieldset content box an OOF container by adding |filter: brightness(100%)| or |position: relative| if the fieldset can contain OOF objects. We need to add a special handling for OOF descendants of a LEGEND to FindAncestorByPredicate() because such OOF descendants are contained by fieldsets in NG fragment trees. Without this change, we had some CHECK failures. Bug: 1153042 Change-Id: I993922cfd373a9e0558bc50edb009680f0f1244a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2569140Reviewed-by:
Morten Stenshorne <mstensho@chromium.org> Commit-Queue: Kent Tamura <tkent@chromium.org> Cr-Commit-Position: refs/heads/master@{#834169}
-
Tim van der Lippe authored
R=sigurds@chromium.org Bug: 1144171 Change-Id: I88304a0cc6eba84973c2a7ff7c0d93410eb68760 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575021 Auto-Submit: Tim van der Lippe <tvanderlippe@chromium.org> Commit-Queue: Sigurd Schneider <sigurds@chromium.org> Reviewed-by:
Sigurd Schneider <sigurds@chromium.org> Cr-Commit-Position: refs/heads/master@{#834168}
-
Nate Fischer authored
Android: inline deprecated BuildInfo methods (/base/android/java/src/org/chromium/base/process_launcher) No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /base/android/java/src/org/chromium/base/process_launcher. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=rmcilroy@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: I74be1508173db531826fb0b8cfdc953642740989 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575373 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Ross McIlroy <rmcilroy@chromium.org> Commit-Queue: Ross McIlroy <rmcilroy@chromium.org> Cr-Commit-Position: refs/heads/master@{#834167}
-
Rune Lillesveen authored
I2S: https://groups.google.com/a/chromium.org/g/blink-dev/c/yN2lrq67a1c/m/YJIsFVdoAAAJ Bug: 1136817 Change-Id: Id1818f2e06356b272f24f83a87cdf107414d45f2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574843Reviewed-by:
Anders Hartvoll Ruud <andruud@chromium.org> Commit-Queue: Rune Lillesveen <futhark@chromium.org> Cr-Commit-Position: refs/heads/master@{#834166}
-
rbpotter authored
Removing in favor of the more limited preprocess_if_expr. Change-Id: I2f7d237a6697489e6d45f72968e0d662f40d8bdc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574929 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#834165}
-
David Jean authored
Bug: 1156054 Change-Id: Ic22973c56bce2b7f79770e788a31ea90f7629a39 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576238 Auto-Submit: David Jean <djean@chromium.org> Commit-Queue: Stepan Khapugin <stkhapugin@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834164}
-
Jan Wilken Dörrie authored
This change replaces network::IsUrlPotentiallyTrustworthy with network::IsOriginPotentiallyTrustworthy in the Touch To Fill controller. The small difference between those two APIs is irrelevant for Touch To Fill, and the latter matches the semantics of TouchToFillView::IsOriginSecure better. Bug: 1012717, 1153336 Change-Id: I06553ac01aeae540426e6df30631e03db0ccfe60 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574743 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Commit-Queue: Friedrich [CET] <fhorschig@chromium.org> Auto-Submit: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Friedrich [CET] <fhorschig@chromium.org> Cr-Commit-Position: refs/heads/master@{#834163}
-
Nate Fischer authored
No change to logic. This inlines BuildInfo.isAtLeast{Q,R} and BuildInfo.targetsAtLeast{Q,R} (and their C++ equivalents) in /components/browser_ui/photo_picker/android. The methods themselves will be removed in a follow-up CL once all call sites have been removed. This CL was uploaded by git cl split. R=finnur@chromium.org Bug: 1106920 Test: autoninja -C out/Default monochrome_public_apk Change-Id: Ib3278a63d0a27967cb873aa265b504bc5dd7107d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575382 Auto-Submit: Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Finnur Thorarinsson <finnur@chromium.org> Cr-Commit-Position: refs/heads/master@{#834162}
-
Ben Wagner authored
The new page set needs extra Chrome flags; pipe those through the superclass constructors. The sample that's the source for the new page set has multiple JS files; change update_webrtc_cases to concatenate all JS files to create the target JS file. Also, fix the URL for the video file (reusing the video file for trivial_full_screen). `./tools/perf/run_benchmark run webrtc --browser=canary` passes locally on Mac and runs the new stories. `./tools/perf/run_benchmark run webrtc --browser=system` also passes, correctly skipping the stories since they use features that are new in M89. Change-Id: I732b3c967469c7b83b940faf2f9486d909430ee3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2566935 Commit-Queue: Ben Wagner aka dogben <benjaminwagner@google.com> Reviewed-by:
Mirko Bonadei <mbonadei@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#834161}
-
chromium-autoroll authored
https://chromium.googlesource.com/devtools/devtools-frontend.git/+log/3a803457d17d..dead315abbf8 2020-12-07 bmeurer@chromium.org Add webassemblymemory subtype. If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/devtools-frontend-chromium Please CC devtools-waterfall-sheriff-onduty@grotations.appspotmail.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Bug: chromium:1155566 Tbr: devtools-waterfall-sheriff-onduty@grotations.appspotmail.com Change-Id: Ie0680b39f825ca1488286b6f75866f2637b1026f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576106Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834160}
-
Alex Rudenko authored
This CL adds page-level scroll events to be sent to the inspector overlay agent so that the agent can disable persistent overlays during scrolling. Since the scrolling happens in the compositor and the overlay is painted on the main thread, there is a visible lag in the overlay rendering during scroll. This CL is a workaround for this issue. Video: https://i.imgur.com/krVFVPG.mp4 Bug: 1147362 Change-Id: Ifd9f735c0fe15a745f49f1fb440889e78e4a599e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2562846Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Stephen McGruer <smcgruer@chromium.org> Reviewed-by:
Khushal <khushalsagar@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
David Bokan <bokan@chromium.org> Reviewed-by:
Mathias Bynens <mathias@chromium.org> Commit-Queue: Alex Rudenko <alexrudenko@chromium.org> Cr-Commit-Position: refs/heads/master@{#834159}
-
Internal Frameworks Autoroller authored
TBR=bling-team@google.com Change-Id: I94b4066627951e9caf9edb86182c1f962f671029 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576424Reviewed-by:
Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: Internal Frameworks Autoroller <bling-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834158}
-
Francois Beaufort authored
Camera PTZ feature has shipped in M87. This CL removes the MediaCapturePanTilt blink feature and cleans up related code. There should be no behaviour change. Change-Id: Ie6222ec7275cbfb3f80deb5af8506307b89362c0 Bug: 934063 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2533774Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: François Beaufort <beaufort.francois@gmail.com> Cr-Commit-Position: refs/heads/master@{#834157}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/251ba5cb119f..71bbb3b22e98 2020-12-07 angle-autoroll@skia-public.iam.gserviceaccount.com Roll Chromium from 6991410b to bbe26af2 (235 revisions) If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC geofflang@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win-asan;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:linux-swangle-try-x64;luci.chromium.try:win-swangle-try-x86 Bug: None Tbr: geofflang@google.com Change-Id: I7dfaa7520504d1bbe829003601c44e92e12e4126 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576999Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834156}
-
Vidhan authored
Change-Id: I0aac983134a08eb79e4874d44f62f7c605597ed3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574738Reviewed-by:
Jan Krcal <jkrcal@chromium.org> Commit-Queue: Vidhan Jain <vidhanj@google.com> Cr-Commit-Position: refs/heads/master@{#834155}
-
Kent Tamura authored
This CL makes layout of disclosure-* equivalent to the default layout of ::-webkit-details-marker. * DisclosureSymbolSize() Make the symbol size same as 0.66em. * ListMarker::WidthOfSymbol() 1px gaps are not necessary. * ListMarker::InlineMarginsForInside() No margin for inline-start. 0.4em margin for inline-end. * ListMarker::RelativeSymbolMarkerRect() No margin for inline-start. Align the marker bottom and the baseline * ListMarkerPainter::PaintSymbol() should take a non-pixel-snapped rectangle. It matches to the current behavior of LayoutDetailsMarker and DetailsMarkerPainter. This CL will reduce the number of rebaseline files significantly when SummaryListItem flag is enabled. Bug: 590014 Change-Id: I600ab534a05c08bca482a4316270b9e9b9a3c651 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577077 Commit-Queue: Kent Tamura <tkent@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#834154}
-
Thomas Guilbert authored
This CL converts uses of base::Callback to their proper {Once|Repeating} equivalents in the chrome/browser/sync_file_system. Specifically, LocalFileSyncService, LocalFileSyncContext and RootDeleteHelper are updated. Bug: 1152272 Change-Id: I7955714c5b000d77dab4a21e463161f1038f0e44 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575047 Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Kinuko Yasuda <kinuko@chromium.org> Reviewed-by:
Kinuko Yasuda <kinuko@chromium.org> Cr-Commit-Position: refs/heads/master@{#834153}
-
Greg Thompson authored
BUG=1156046 TBR=estark@chromium.org Change-Id: I953a93aae7964aa17d1f460dc79da1a8bfd5e6b4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2577217Reviewed-by:
Greg Thompson <grt@chromium.org> Commit-Queue: Greg Thompson <grt@chromium.org> Cr-Commit-Position: refs/heads/master@{#834152}
-
Eric Willigers authored
Web apps on Chrome OS may use the Web Share API to send title, text and/or url, even when files are not also being shared at the same time. Support for sharing title/text/url in combination with files is already implemented: https://chromium-review.googlesource.com/c/chromium/src/+/2569329 Bug: 1127670 Change-Id: Iae5d51f0012d7134309af80ba377ecd60f311efd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576296 Commit-Queue: Eric Willigers <ericwilligers@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Auto-Submit: Eric Willigers <ericwilligers@chromium.org> Cr-Commit-Position: refs/heads/master@{#834151}
-
chrome://predictorsdpapad authored
Specifically: - Replacing calls to CallJavascriptFunctioUnsafe with ResolveJavascriptCallback - Add JS type checking. Bug: None Change-Id: I8df90a3b394d191418e9e4155f38e9a30c328650 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574389 Commit-Queue: dpapad <dpapad@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#834150}
-
Kent Tamura authored
This CL merged details-remove-summary-*.html into a single reference test. This CL has no behavior changes. Change-Id: Ie8e3489de79e855fb8763938737d2bd1486d27c1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2574650 Commit-Queue: Koji Ishii <kojii@chromium.org> Auto-Submit: Kent Tamura <tkent@chromium.org> Reviewed-by:
Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#834149}
-
Chromium WPT Sync authored
Using wpt-import in Chromium 61484e7c. With Chromium commits locally applied on WPT: 3efc6b23 "Add WPT where start() throws an exception for type: 'bytes'" Note to sheriffs: This CL imports external tests and adds expectations for those tests; if this CL is large and causes a few new failures, please fix the failures by adding new lines to TestExpectations rather than reverting. See: https://chromium.googlesource.com/chromium/src/+/master/docs/testing/web_platform_tests.md NOAUTOREVERT=true TBR=lpz@google.com No-Export: true Cq-Include-Trybots: luci.chromium.try:linux-wpt-identity-fyi-rel,linux-wpt-input-fyi-rel Change-Id: I1dd51104213f72ad8ef64a42c90c24373f445aeb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576724Reviewed-by:
WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: WPT Autoroller <wpt-autoroller@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834148}
-
Nidhi Jaju authored
This CL adds 2 UseCounters for the following scenarios: 1. ReadableStream is constructed with {type: "bytes"} 2. Call to getReader() with {mode: "byob"} This will help understand how much the ReadableByteStreams API is being used among the developer community. Bug: 614302 Change-Id: I3897e26696050db7c522681ef0e9f2e289e13df5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575788Reviewed-by:
Adam Rice <ricea@chromium.org> Commit-Queue: Nidhi Jaju <nidhijaju@google.com> Cr-Commit-Position: refs/heads/master@{#834147}
-
CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-betty-pi-arc-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-eve-chrome CQ_INCLUDE_TRYBOTS=luci.chrome.try:chromeos-kevin-chrome TBR=chrome-os-gardeners@google.com Change-Id: Iceabdd1bb219d8e573fd278db098826b13989d01 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2575946Reviewed-by:
ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Commit-Queue: ChromeOS bot <3su6n15k.default@developer.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834146}
-
chromium-autoroll authored
Roll Chrome Linux PGO profile from chrome-linux-master-1607296838-726b11db44d1999a156b631ebee4ad43068bfed6.profdata to chrome-linux-master-1607320769-89cdddd8995ad3be12a676e570aae350fc15988d.profdata If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/pgo-linux-chromium Please CC pgo-profile-sheriffs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chrome Tbr: pgo-profile-sheriffs@google.com Change-Id: Ic7b0edd23878349308c9179b7f2079ee91782667 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2576423Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#834145}
-