- 31 Jul, 2019 40 commits
-
-
Ben Pastene authored
Bug: 989314 Change-Id: Idbef0fd0d7fcfb3058b45b8738da41a467b15aa9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728317Reviewed-by:
John Budorick <jbudorick@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#682817}
-
John Budorick authored
Bug: 936114 Change-Id: I3c98fea06875c33dc78a8ab3c82008840d241cba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721840 Commit-Queue: John Budorick <jbudorick@chromium.org> Reviewed-by:
Aaron Gable <agable@chromium.org> Auto-Submit: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#682816}
-
Matt Menke authored
Also make PreconnectManager::StartPreconnectUrl()'s NetworkIsolationKey mandatory, as all callers are now passing one in. Bug: 966896 Change-Id: Id10c410225c5d8248569443381856a3c12d452aa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1721513 Commit-Queue: Matt Menke <mmenke@chromium.org> Reviewed-by:
Tarun Bansal <tbansal@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682815}
-
Justin Cohen authored
Because synchronization has to be disabled for this portion of the test, add a half second delay to allow the new iOS13 confirmation dialog to be fully visible. Bug: 989615 Change-Id: Ia5322dfc5c67ae4609922b6d883434fc2843a27f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727652Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Justin Cohen <justincohen@chromium.org> Auto-Submit: Justin Cohen <justincohen@chromium.org> Cr-Commit-Position: refs/heads/master@{#682814}
-
Lily Chen authored
This adds methods to net::cookie_util to check whether "SameSite by default cookies" and "Cookies without SameSite must be Secure" are enabled. This replaces direct checks of the FeatureList and allows future changes to the criteria for enabling those features. Bug: 954551, 953306 Change-Id: If2b7f92b464797b77bf01c80f5eb5511a45ef641 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726796Reviewed-by:
Maks Orlovich <morlovich@chromium.org> Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#682813}
-
Victor Hugo Vianna Silva authored
We move the platform specific logic to be injected on construction of LargeIconServiceImpl in the factories. Change-Id: Ied1bc8d640d38d2a5ceca6dd91358f910decd6ba Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1715690 Commit-Queue: Kristi Park <kristipark@chromium.org> Auto-Submit: Victor Vianna <victorvianna@google.com> Reviewed-by:
Kristi Park <kristipark@chromium.org> Reviewed-by:
Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Wei-Yin Chen (陳威尹) <wychen@chromium.org> Reviewed-by:
Rohit Rao <rohitrao@chromium.org> Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Nicolas Zea <zea@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#682812}
-
Raymond Toy authored
There are some unexpected results for WebAudio.AudioContextOptions.sampleRate[1] so let's extend the expiration date another 6 mo. [1] Most common value for windows is 22500 Hz, which is a very strange sample rate. (A typo of 22050?) Bug: 988810 Change-Id: I410e1e485dea81612f927ec490b04956d36d8825 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726396Reviewed-by:
Mark Pearson <mpearson@chromium.org> Commit-Queue: Raymond Toy <rtoy@chromium.org> Cr-Commit-Position: refs/heads/master@{#682811}
-
Tim Song authored
With system priority, the screenshot notification never auto dismisses and remains forever. BUG=987928 Change-Id: Ib83a156444970233b6d95654749dbd1cc9c4013e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726764Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#682810}
-
Yue Zhang authored
* Add xml files regarding the animated drawable for the IPH. * Introduce a TabGridIphItemView as the entrance for IPH. * Add logic in TabListRecyclerView to add a footer to accommodate the IPH entrance. This is a workaround before https://crrev.com/c/1650522. Bug: 987043 Change-Id: Ibed6f42c291ebef37277431b910b6ff9aca3da47 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1716138 Commit-Queue: Yue Zhang <yuezhanggg@chromium.org> Reviewed-by:
-
Daniel Vogelheim authored
This code was introduced in crrev.com/c/917610 and made use of the (then-new) Trusted Types API. It turns out, that code doesn't actually work if you enable TT (because it passes a plain string to a "trusted" API). Instead, we should just call a lower-level built-in that doesn't do the Trusted Type check. Change-Id: Ic60700240293908e9cec1a398e1fce3775bb1e9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729591Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Daniel Vogelheim <vogelheim@chromium.org> Cr-Commit-Position: refs/heads/master@{#682808}
-
Owen Min authored
ContextProviderImplTest.CleansUpContextJobs is only ran on Fuchsia, hence there is no need to add the condition. Bug: 989085 Change-Id: Iee8fe325681b3a38374ab52a1ff29f794a2569f6 TBR: wez@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729471Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682807}
-
Tim Song authored
The new text is more consistent with the tooltips on other toggle buttons in the tray bubble. Screenshot: https://screenshot.googleplex.com/6jNM1r6V8rf.png BUG=986238 Change-Id: Iecbcb6fbee569ab170f82119e879fe9c79c19f55 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727513Reviewed-by:
Tetsui Ohkubo <tetsui@chromium.org> Commit-Queue: Tim Song <tengs@chromium.org> Cr-Commit-Position: refs/heads/master@{#682806}
-
Min Qin authored
These UMAs are no longer needed BUG=969975, 969976 Change-Id: I905c32c3d86f727886224577d541a1da3f2f0e75 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1706802 Commit-Queue: Min Qin <qinmin@chromium.org> Reviewed-by:
Jesse Doherty <jwd@chromium.org> Reviewed-by:
Xing Liu <xingliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#682805}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=zea@chromium.org Bug: 968047 Change-Id: I605a98e8a1cb3e54f5ef90bee4692278cee9dba2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729152 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by: -
Xiang Ji authored
Change-Id: I1ad39a83c27a6535cd18c846f6bee8d40f45ab52 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1705634 Commit-Queue: Xiang Ji <jxiang@google.com> Reviewed-by:
Julian Pastarmov <pastarmovj@chromium.org> Cr-Commit-Position: refs/heads/master@{#682803}
-
Will Harris authored
BUG=None Change-Id: Idee0f736ea2e37ccdaee3440b778f23d045c4d9e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729056Reviewed-by:
James Forshaw <forshaw@chromium.org> Commit-Queue: James Forshaw <forshaw@chromium.org> Cr-Commit-Position: refs/heads/master@{#682802}
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/c0758331ea12..364640e2491e git log c0758331ea12..364640e2491e --date=short --no-merges --format='%ad %ae %s' 2019-07-31 ehmaldonado@chromium.org depot_tools: Remove unused files. Created with: gclient setdep -r src/third_party/depot_tools@364640e2491e The AutoRoll server is located here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=agable@chromium.org Bug: chromium:984182 Change-Id: I15310167131ef2bec3995027e2131110f28138dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729200Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682801}
-
Robert Ogden authored
The prober work isn't done yet, so bump these another milestone Bug: 988706 Change-Id: Ie28c406c79650a359f85e8958b414bf8e300defd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728432 Auto-Submit: Robert Ogden <robertogden@chromium.org> Reviewed-by:
-
Nico Weber authored
No behavior change. Bug: 961769 Change-Id: I79f6337367065c0c902f3d5a6fcaf9adabf86b81 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724703 Auto-Submit: Nico Weber <thakis@chromium.org> Reviewed-by:
-
Shimi Zhang authored
This is a followup of http://crrev/c/1685837. See more at https://docs.google.com/document/d/1Jwfbzbe8ozaoilhqj5mAPYbYGpgZCen_XAAAdwmyP1E/edit Bug: 955171 Change-Id: Ie98a786dbb61aa3feb7a5b7170a27f88c243c4b2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1723020Reviewed-by:
David Bokan <bokan@chromium.org> Commit-Queue: Shimi Zhang <ctzsm@chromium.org> Cr-Commit-Position: refs/heads/master@{#682798}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=msramek@chromium.org Bug: 968047 Change-Id: Ie259b2ae8a26418d8eb0b2bdc7299c143b2cf0e9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729154 Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Martin Šrámek <msramek@chromium.org> Commit-Queue: Martin Šrámek <msramek@chromium.org> Cr-Commit-Position: refs/heads/master@{#682797}
-
Ian McKellar authored
This removes usages of the old API that will become build failures when deprecation warnings are turned on. See: https://fuchsia-review.googlesource.com/c/fuchsia/+/304389 Change-Id: Ie5db014401d79787101b2b4b6e7585fd7a23b1ce Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727375 Commit-Queue: Ian McKellar <ianloic@chromium.org> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#682796}
-
Lucas Furukawa Gadani authored
Bug: 984550 Change-Id: Ic966c764e7fb52a9fb8d2ea44d9777bd8c1e4011 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1725096Reviewed-by:
Avi Drissman <avi@chromium.org> Reviewed-by:
Scott Graham <scottmg@chromium.org> Reviewed-by:
Nasko Oskov <nasko@chromium.org> Commit-Queue: Lucas Gadani <lfg@chromium.org> Cr-Commit-Position: refs/heads/master@{#682795}
-
Leonard Grey authored
(This was reverted because network sampling was hanging. This change opts us out of network sampling, which makes what we record slightly less accurate. The alternative approach is to gather energy impact asynchronously, which means we would need to lag behind one sample interval and requires lots of bookkeeping). Original description: This is a synthetic estimate displayed to users in Activity Monitor, the battery menu, and top. More info at https://blog.mozilla.org/nnethercote/2015/08/26/what-does-the-os-x-activity-monitors-energy-impact-actually-measure/ TBR=oysteine@chromium.org Bug: 969105 Change-Id: I8af6b03f9714aa2e6d6302726b0392fa287fab5b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1718791 Commit-Queue: Leonard Grey <lgrey@chromium.org> Reviewed-by:
Mark Mentovai <mark@chromium.org> Reviewed-by:
Ilya Sherman <isherman@chromium.org> Cr-Commit-Position: refs/heads/master@{#682794}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/88aae3b05111..471a922d82ca git log 88aae3b05111..471a922d82ca --date=short --no-merges --format='%ad %ae %s' 2019-07-31 rnasri@google.com Rename file containing speed index utility functions Created with: gclient setdep -r src/third_party/catapult@471a922d82ca The AutoRoll server is located here: https://autoroll.skia.org/r/catapult-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=sadrul@google.com Bug: chromium:982025 Change-Id: I7326abfa707e9dcba356c042eeda4b3fb6381bd2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728314Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/34ebecc19c6b..3e493c48d2da git log 34ebecc19c6b..3e493c48d2da --date=short --no-merges --format='%ad %ae %s' 2019-07-31 lujc@google.com Vulkan: Optimize memory allocation offset rounding Created with: gclient setdep -r src/third_party/angle@3e493c48d2da The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel TBR=geofflang@google.com Bug: None Change-Id: Ie43f5bfbad43a4532de66b97d3c8d903328cad46 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728315Reviewed-by:
-
Alberto Herrera authored
Use the existing PeripheralBatteryNotifier to show low battery notifications of connected device::BluetoothDevice objects. This CL adds functionality to trigger for GATT connections that support the Battery Service. Also added DeviceBatteryChanged() to device::BluetoothAdapter::Observer so device::BluetoothDevice can notify about battery level changes and PeripheralBatteryNotifier gets notified about those changes. Also modified BluetoothDevice to make the battery percentage property OS_CHROMEOS-only. Design doc at go/cros-bt-battery. Bug: 785758 Change-Id: I325e6bf47032fe5fc2a7471d2a1be9850fd89030 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1703341 Commit-Queue: Alberto Herrera <ahrfgb@google.com> Reviewed-by:
James Cook <jamescook@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
Ryan Hansberry <hansberry@chromium.org> Reviewed-by:
Kyle Horimoto <khorimoto@chromium.org> Cr-Commit-Position: refs/heads/master@{#682791}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/da479f0f..f99c5871 Please follow these instructions for assigning/CC'ing issues: https://v8.dev/docs/triage-issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux-blink-rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:linux_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:mac_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:win_optional_gpu_tests_rel CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: I780029053456bc56208d9de89c711651d6cd64b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729569Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#682790}
-
Sami Kyostila authored
*** Note: There is no behavior change from this patch. *** The PostTask APIs will shortly be changed to require all tasks to explicitly specify their thread affinity, i.e., whether the task should run on the thread pool or a specific named thread such as a BrowserThread. This patch updates all call sites with thread affinity annotation. We also remove the "WithTraits" suffix to make the call sites more readable. Before: // Thread pool task. base::PostTaskWithTraits(FROM_HERE, {...}, ...); // UI thread task. base::PostTaskWithTraits(FROM_HERE, {BrowserThread::UI, ...}, ...); After: // Thread pool task. base::PostTask(FROM_HERE, {base::ThreadPool(), ...}, ...); // UI thread task. base::PostTask(FROM_HERE, {BrowserThread::UI, ...}, ...); This patch was semi-automatically prepared with these steps: 1. Patch in https://chromium-review.googlesource.com/c/chromium/src/+/1635827 to make thread affinity a build-time requirement. 2. Run an initial pass with a clang rewriter: https://chromium-review.googlesource.com/c/chromium/src/+/1635623 3. ninja -C out/Debug | grep 'requested here' | cut -d: -f1-3 | sort | \ uniq > errors.txt 4. while read line; do f=$(echo $line | cut -d: -f 1) r=$(echo $line | cut -d: -f 2) c=$(echo $line | cut -d: -f 3) sed -i "${r}s/./&base::ThreadPool(),/$c" $f done < errors.txt 5. GOTO 3 until build succeeds. 6. Remove the "WithTraits" suffix from task API call sites: $ tools/git/mffr.py -i <(cat <<EOF [ ["PostTaskWithTraits", "PostTask"], ["PostDelayedTaskWithTraits", "PostDelayedTask"], ["PostTaskWithTraitsAndReply", "PostTaskAndReply"], ["CreateTaskRunnerWithTraits", "CreateTaskRunner"], ["CreateSequencedTaskRunnerWithTraits", "CreateSequencedTaskRunner"], ["CreateUpdateableSequencedTaskRunnerWithTraits", "CreateUpdateableSequencedTaskRunner"], ["CreateSingleThreadTaskRunnerWithTraits", "CreateSingleThreadTaskRunner"], ["CreateCOMSTATaskRunnerWithTraits", "CreateCOMSTATaskRunner"] ] EOF ) This CL was uploaded by git cl split. R=fdoray@chromium.org Bug: 968047 Change-Id: I3451c35ce8c86d97fadac722781c92142be0d905 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728586 Commit-Queue: Sami Kyöstilä <skyostil@chromium.org> Reviewed-by:Gabriel Charette <gab@chromium.org> Auto-Submit: Sami Kyöstilä <skyostil@chromium.org> Cr-Commit-Position: refs/heads/master@{#682789}
-
Sergio Villar Senin authored
It's using doubles to represent seconds in StartPageScaleAnimation(). Switched to base::TimeDelta to represent durations. This change in the interface forced the updates of specific implementations as RenderWidget::StartPageScaleAnimation or WebViewImpl::StartPageScaleAnimation. This also had the nice side effect of forcing some other changes in other interfaces that had to be replaced as well, see WebView::SmoothScroll(). Bug: 988343 Change-Id: I9510d059e6612c99a5c8de865e59186a5ff9ac20 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1724750 Commit-Queue: Sergio Villar <svillar@igalia.com> Reviewed-by:
Jonathan Ross <jonross@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Tobias Sargeant <tobiasjs@chromium.org> Cr-Commit-Position: refs/heads/master@{#682788}
-
Wei-Yin Chen (陳威尹) authored
Bug: 964406 Change-Id: I90568c78ebd510cd540074daf0a3adeb2c089da6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726833 Auto-Submit: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Commit-Queue: Robert Kaplow <rkaplow@chromium.org> Reviewed-by:
Robert Kaplow <rkaplow@chromium.org> Cr-Commit-Position: refs/heads/master@{#682787}
-
Vasiliy Telezhnikov authored
Bug: 987278 Change-Id: I59c71cecba1d0e14d1977230148db0bde477a1b8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728431 Commit-Queue: Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#682786}
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/97e015fa8e5a..d0b67c2a70b3 git log 97e015fa8e5a..d0b67c2a70b3 --date=short --no-merges --format='%ad %ae %s' 2019-07-31 chromium-webrtc-autoroll@webrtc-ci.iam.gserviceaccount.com Roll chromium_revision 1443fbac..6ba1e902 (682581:682701) 2019-07-31 hta@webrtc.org Make ID of datachannel stats not depend on dc.id Created with: gclient setdep -r src/third_party/webrtc@d0b67c2a70b3 The AutoRoll server is located here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. TBR=webrtc-chromium-sheriffs-robots@google.com Bug: chromium:None Change-Id: I0815a7953f37d36f4a91061daa9665c8114baf4c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729199Reviewed-by:
-
John Budorick authored
This allows //build/android/test_runner.py to run an AVD on which it can run tests. Change-Id: I653a9e2e351ced1914c471e83aab3f6c0dc8d508 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1699274Reviewed-by:
Yun Liu <yliuyliu@google.com> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#682784}
-
John Abd-El-Malek authored
Bug: 934009 Change-Id: I8672f3c6c091b287c90c8d9dfcd1ff4881770c2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1728409 Commit-Queue: John Abd-El-Malek <jam@chromium.org> Commit-Queue: Clark DuVall <cduvall@chromium.org> Auto-Submit: John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Cr-Commit-Position: refs/heads/master@{#682783}
-
Robert Liao authored
//chrome/browser/ui/views/hats/OWNERS points to //chrome/browser/ui/hats/OWNERS BUG=979530 Change-Id: Iada4ec0c50bedd28ab148de93384522b03cc4300 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726662 Auto-Submit: Robert Liao <robliao@chromium.org> Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Robert Liao <robliao@chromium.org> Cr-Commit-Position: refs/heads/master@{#682782}
-
Arthur Hemery authored
This CL removes most of the references to PlzNavigate in the comments of chrome/. Some problematic cases where further expertise is needed are left out, but this covers more than 90% of the references. Change-Id: Ibc3876e07bf9bf8eef0838757ae1db4a77d38eec Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729161Reviewed-by:
-
David Bokan authored
This helps specifically with <select> drop downs as they listen for the mouse events rather than click. Likely to help in a few other cases as well. Bug: 988925 Change-Id: Ia3ae3c447caff6bc0d47303cda4dcd74ee5d1555 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1726668Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#682780}
-
Owen Min authored
Disable CredentialProviderSigninDialogWinIntegrationDesktopVerificationTest .DialogFailsToLoadOnIncorrectDesktop because it's flaky. Bug: 987508 Change-Id: Ibd3da5b371edd7d7bb7add7d3d71da607229a7a1 Tbr: tienmai@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1729510Reviewed-by:
Sky Malice <skym@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682779}
-
Eugene But authored
Replaced code which waits for PassKit UI presentation for EG2. EG1 still relies on checking for presented UIViewController, while EG2 can use XCUITest API to test that "Toy Town Membership" element (pkpass title) is displayed. Bug: 987646 Change-Id: I7295aa58538100957eb438ea5d5972ec9628a5c9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1727732 Commit-Queue: Eugene But <eugenebut@chromium.org> Reviewed-by:
Stepan Khapugin <stkhapugin@chromium.org> Cr-Commit-Position: refs/heads/master@{#682778}
-
