- 30 Oct, 2018 40 commits
-
-
Mohamed Heikal authored
Resource names are being stripped from the apk. Output the R.txt files to the apks directory for archiving during official builds. Bug: 894208 Change-Id: Iba0499fb2ac6dccc22a8997b546955733d4e5e23 Reviewed-on: https://chromium-review.googlesource.com/c/1305813Reviewed-by:
agrieve <agrieve@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#603938}
-
Daniele Castagna authored
The original CL crrev.com/c/1300235 got reverted since we were not initializing the new added member EffectNode::backdrop_filter_quality. This CL initializes it and additionally fixes EffectNode::operator==. Origianl CL description: Computing background blur at full resolution as a backdrop filter turned out not to be cheap. This patch adds a backdrop_filter_quality float to cc::Layer that can be used to reduce the size of the offscreen canvas used to compute the blur. Currently this float is not exposed on the web and can be used only from Chrome UI. TBR=enne@chromium.org, ccameron@chromium.org, rsesek@chromium.org, oshima@chromium.org Bug: 897369 Change-Id: Ibf7594b7a97d8e752890c691ed14dff12266013d Reviewed-on: https://chromium-review.googlesource.com/c/1307591 Commit-Queue: Daniele Castagna <dcastagna@chromium.org> Reviewed-by:
Daniele Castagna <dcastagna@chromium.org> Cr-Commit-Position: refs/heads/master@{#603937}
-
Becky Zhou authored
Bug: 900030 Change-Id: I361f4c7f61fcf86521815cc8ef4129edecbdc442 Reviewed-on: https://chromium-review.googlesource.com/c/1307839Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Becky Zhou <huayinz@chromium.org> Cr-Commit-Position: refs/heads/master@{#603936}
-
v8-ci-autoroll-builder authored
Summary of changes available at: https://chromium.googlesource.com/v8/v8/+log/6aa2ff97..600998aa Please follow these instructions for assigning/CC'ing issues: https://github.com/v8/v8/wiki/Triaging%20issues Please close rolling in case of a roll revert: https://v8-roll.appspot.com/ This only works with a Google account. CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;luci.chromium.try:android_optional_gpu_tests_rel TBR=hablich@chromium.org,v8-waterfall-sheriff@grotations.appspotmail.com Change-Id: Idca869549bbe54f7201f8197c7e83658aeff9838 Reviewed-on: https://chromium-review.googlesource.com/c/1307835Reviewed-by:
v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Commit-Queue: v8-ci-autoroll-builder <v8-ci-autoroll-builder@chops-service-accounts.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603935}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/3420dcb0cff1..7cba6be85a14 git log 3420dcb0cff1..7cba6be85a14 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 ynovikov@chromium.org Revert "Vulkan: Roll VK deps forward" Created with: gclient setdep -r src/third_party/angle@7cba6be85a14 The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:845519 TBR=ynovikov@chromium.org Change-Id: I8968557636a6c70cf7cda4ecc30d3f1df8ae7a37 Reviewed-on: https://chromium-review.googlesource.com/c/1307814Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603934}
-
Charlie Harrison authored
This saves space in the indexed ruleset if: 1. Multiple rules share a pattern 2. Patterns are shared with domain specifiers In practice this doesn't shave off that much space but will be more impactful with different ruleset formats (like Disconnect, for instance). Bug: None Change-Id: I34d221ce52eb9aabaa1e57978860de62142b81d4 Reviewed-on: https://chromium-review.googlesource.com/c/1307586Reviewed-by:
Josh Karlin <jkarlin@chromium.org> Commit-Queue: Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#603933}
-
manuk authored
- OmniboxInputs to displatch events with details containing display and query inputs when they change - OutputController to handle those events, cache display and query inputs, and invoke OmniboxOutputs.refresh - OmniboxOutputs.refresh to manage updating the HTML from inputs Bug: 891303 Change-Id: Ice63b04f4eafea5d98e8dddd1f16b17618f2652e Reviewed-on: https://chromium-review.googlesource.com/c/1299534 Commit-Queue: manuk hovanesian <manukh@chromium.org> Reviewed-by:
Tommy Li <tommycli@chromium.org> Cr-Commit-Position: refs/heads/master@{#603932}
-
Oystein Eftevaag authored
This reverts commit f36de8b1. Perf regressions addressed by: https://chromium-review.googlesource.com/c/chromium/src/+/1263354 https://android-review.googlesource.com/c/platform/external/perfetto/+/799400 Original change's description: > Revert "Reland "Enable Perfetto by default for all telemetry tests"" > > This reverts commit 0f374eff. > > Reason for revert: http://crbug.com/886918 > > Original change's description: > > Reland "Enable Perfetto by default for all telemetry tests" > > > > This is a reland of 32c8ebbe > > > > Relanding after https://chromium-review.googlesource.com/c/chromium/src/+/1225306 > > > > Original change's description: > > > Enable Perfetto by default for all telemetry tests > > > > > > This will use Perfetto instead of TraceLog for all > > > trace-based Telemetry tests running on Mac/Windows/Android. > > > > > > R=nednguyen@google.com > > > > > > Bug: 839084 > > > Cq-Include-Trybots: master.tryserver.chromium.perf:obbs_fyi > > > Change-Id: I570060cd7f53ea0310f67370b4abec132c8a1a01 > > > Reviewed-on: https://chromium-review.googlesource.com/1176119 > > > Commit-Queue: oysteine <oysteine@chromium.org> > > > Reviewed-by: Sami Kyöstilä <skyostil@chromium.org> > > > Reviewed-by: Ned Nguyen <nednguyen@google.com> > > > Cr-Commit-Position: refs/heads/master@{#585368} > > > > TBR=nednguyen@google.com > > > > Change-Id: I31b69483281f9fb34c5083888b8f45f00ca95e6e > > Reviewed-on: https://chromium-review.googlesource.com/1208955 > > Reviewed-by: oysteine <oysteine@chromium.org> > > Reviewed-by: Annie Sullivan <sullivan@chromium.org> > > Commit-Queue: oysteine <oysteine@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#592127} > > TBR=sullivan@chromium.org,oysteine@chromium.org,nednguyen@google.com > > Change-Id: I7e3984b90f8f53d1dface9459ea07d7383e7c6d1 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Reviewed-on: https://chromium-review.googlesource.com/1233717 > Reviewed-by: Egor Pasko <pasko@chromium.org> > Commit-Queue: Egor Pasko <pasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#592400} TBR=pasko@chromium.org,sullivan@chromium.org,oysteine@chromium.org,nednguyen@google.com # Not skipping CQ checks because original CL landed > 1 day ago. Change-Id: Ic2b034d7d40ee65d14dab9ecfac914b744cd057d Reviewed-on: https://chromium-review.googlesource.com/c/1307793Reviewed-by:
Eric Seckler <eseckler@chromium.org> Reviewed-by:
oysteine <oysteine@chromium.org> Commit-Queue: oysteine <oysteine@chromium.org> Cr-Commit-Position: refs/heads/master@{#603931}
-
Tommy Steimel authored
This CL adds event handling to allow users to click anywhere on a video to toggle play or pause. Pausing happens immediately, while playing happens after waiting for the double-tap delay. If we pause and then the double-tap happens, we resume playback. Bug: 895636 Change-Id: Idf161767900b3dc03501f8034f0c589c4e5d5800 Reviewed-on: https://chromium-review.googlesource.com/c/1286870Reviewed-by:
Mounir Lamouri <mlamouri@chromium.org> Commit-Queue: Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#603930}
-
kylechar authored
The flag was added for experimenting with power usage and doesn't appear used anymore. It's also broken with OOP-D enabled. Bug: 899300 Change-Id: Id255ce74d252f15346affb34417b883b37fe5987 Reviewed-on: https://chromium-review.googlesource.com/c/1305244Reviewed-by:
danakj <danakj@chromium.org> Commit-Queue: kylechar <kylechar@chromium.org> Cr-Commit-Position: refs/heads/master@{#603929}
-
Owen Min authored
Disable SpellingMenuObserverTest.NoSpellingServiceWhenOffTheRecord SpellingMenuObserverTest.SuggestionsForceTopSeparator Bug: 899935 Change-Id: Ib5f1089e3be0e9c89805debc064435c0a70a7c17 Tbr: lazyboy@chromium.org Reviewed-on: https://chromium-review.googlesource.com/c/1307894Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603928}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a3993dd6c128..15a8883b4d7d Created with: gclient setdep -r src-internal@15a8883b4d7d The AutoRoll server is located here: https://autoroll-internal.skia.org/r/src-internal-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:790153,chromium:790158,chromium:790159,chromium:790163 TBR=mmoss@chromium.org Change-Id: I4823352c12685ad95a19a6221992053e5eb75f72 Reviewed-on: https://chromium-review.googlesource.com/c/1307813Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#603927}
-
Theresa authored
Adds histogram for the suggestions global position and cluster position when a contextual suggestion is clicked. BUG=899354 Change-Id: Iaf8c136ced97c15a28c5eeafaea71b9f4ed18e1c Reviewed-on: https://chromium-review.googlesource.com/c/1302872Reviewed-by:
Ilya Sherman <isherman@chromium.org> Reviewed-by:
Becky Zhou <huayinz@chromium.org> Commit-Queue: Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#603926}
-
Lukasz Anforowicz authored
Change-Id: I6a2e8b08eb2e8045c6e73fef4398524cc6de6211 Reviewed-on: https://chromium-review.googlesource.com/c/1305196Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org> Cr-Commit-Position: refs/heads/master@{#603925}
-
Sky Malice authored
Bug: 899330 Change-Id: I652572fc0799ba0b649eada69b5d335f6b77e6cd Reviewed-on: https://chromium-review.googlesource.com/c/1289697Reviewed-by:
Steven Holte <holte@chromium.org> Commit-Queue: Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#603924}
-
Lei Zhang authored
- Use more range-based for-loops. - Use more nullptrs. - No else after return. Change-Id: I3291628fe4ebf9f8e9be536ecc46738785d068cf Reviewed-on: https://chromium-review.googlesource.com/c/1306411Reviewed-by:
Finnur Thorarinsson <finnur@chromium.org> Commit-Queue: Lei Zhang <thestig@chromium.org> Cr-Commit-Position: refs/heads/master@{#603923}
-
Ria Jiang authored
gpu_tests.depth_capture_integration_test.DepthCaptureIntegrationTest.DepthCapture_depthStreamToRGBAFloatTexture and gpu_tests.depth_capture_integration_test.DepthCaptureIntegrationTest.DepthCapture_depthStreamToRGBAUint8Texture are flaky on win10. They are already marked as flaky on android, linux and highsierra. TBR=kbr@chromium.org Bug: 737410 Change-Id: I6efac3a17ad1192408b08a4f0294db14b9de31ce Reviewed-on: https://chromium-review.googlesource.com/c/1307554Reviewed-by:
Ria Jiang <riajiang@chromium.org> Commit-Queue: Ria Jiang <riajiang@chromium.org> Cr-Commit-Position: refs/heads/master@{#603922}
-
Jonathan Backer authored
crrev.com/c/1284435 introduced a bug where if we flushed due to deadline but had potentially evictable resources for the future, we would not ScheduleEvictExpiredResourcesIn Also added a micro-optimization where if we evict all resources OnMemoryPressure, we also flush to reclaim it immediately. Added unittests to cover flushing logic. Dependency injected fake clock to make test robust. Bug: 899002 Change-Id: I50ca934170ebe76e7f48326e53e60df14c32c078 Reviewed-on: https://chromium-review.googlesource.com/c/1299601 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Antoine Labour <piman@chromium.org> Cr-Commit-Position: refs/heads/master@{#603921}
-
Nate Fischer authored
No change to production logic. This adds tests for AwContentsStatics.setCheckClearTextPermitted(). This changes AwContentsStaticsTest to not start the browser process by default, because the cleartext tests need to call setCheckClearTextPermitted() before AwURLRequestContextGetter is initialized. This modifies testClearClientCertPreferences() only to restore the previous behavior of that test. R=torne@chromium.org Bug: 899012 Test: run_webview_instrumentation_test_apk --gtest_filter=AwContentsStaticsTest#* Change-Id: I2142ac56370edc4912ec5344ec3ddac86d214b2d Reviewed-on: https://chromium-review.googlesource.com/c/1299148Reviewed-by:
Paul Jensen <pauljensen@chromium.org> Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Nate Fischer <ntfschr@chromium.org> Cr-Commit-Position: refs/heads/master@{#603920}
-
Ioana Pandele authored
TBR=sahel@chromium.org Bug: 899222 Change-Id: I10f5ecb0fe5d2408ba9c4f96257aafccf1bf3ce7 Reviewed-on: https://chromium-review.googlesource.com/c/1307441Reviewed-by:
Ioana Pandele <ioanap@chromium.org> Commit-Queue: Ioana Pandele <ioanap@chromium.org> Cr-Commit-Position: refs/heads/master@{#603919}
-
Koji Ishii authored
Following recent failures are from r603783 (CL:1304180) that changed the base expectations. fast/forms/access-key.html fast/forms/focus-selection-input.html fast/forms/focus-selection-textarea.html Taken from build 11225> TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I57acf3fbd593886dc197e6b57c5f70d545b91be9 Reviewed-on: https://chromium-review.googlesource.com/c/1307953Reviewed-by:
Koji Ishii <kojii@chromium.org> Commit-Queue: Koji Ishii <kojii@chromium.org> Cr-Commit-Position: refs/heads/master@{#603918}
-
Becca Hughes authored
C++ bindings have a kMinValue and kMaxValue in mojo enums. This adds the same to the Java bindings. BUG=899802 Change-Id: Ic3dd6ca5b665c6ed6adbd5ffcc80e93573dc51c6 Reviewed-on: https://chromium-review.googlesource.com/c/1305193Reviewed-by:
Ken Rockot <rockot@google.com> Commit-Queue: Becca Hughes <beccahughes@chromium.org> Cr-Commit-Position: refs/heads/master@{#603917}
-
Olivier Robin authored
Per HTML specification https://html.spec.whatwg.org/multipage/form-control-infrastructure.html#form-submission-algorithm step 6 the event event is only triggered if the form is not submitted using the submit() method (-> submitted by an inside element). This means that some form submissions are missed by autofill and we miss some profile save and some metrics. Hook HTMLFormElement.submit so we can trigger the form submission handler in that case. Bug: 857436 Change-Id: I53a831412b62197ef96d1f08d5943ff861815edf Reviewed-on: https://chromium-review.googlesource.com/c/1298210Reviewed-by:
Eugene But <eugenebut@chromium.org> Reviewed-by:
Moe Ahmadi <mahmadi@chromium.org> Commit-Queue: Olivier Robin <olivierrobin@chromium.org> Cr-Commit-Position: refs/heads/master@{#603916}
-
David Bokan authored
PendingOffsetToScroll was previously used to store where the layout box was being scrolled to. There was a pre-RLS fixup to this value but it's no longer set to anything other than its initial value so this CL removes the entire value. Bug: 823365,741830 Change-Id: I4d4090b629ad614bf691ea6360240fea7d43982d Reviewed-on: https://chromium-review.googlesource.com/c/1305818Reviewed-by:
Sandra Sun <sunyunjia@chromium.org> Commit-Queue: David Bokan <bokan@chromium.org> Cr-Commit-Position: refs/heads/master@{#603915}
-
Koji Ishii authored
Following bot results are included. 11147 11195 11202 11211 11215 11217 11221 11224 11225 28 lines were removed and 2 lines were deflaked by consecutive results since 11135. TBR=eae@chromium.org, mstensho@chromium.org NOTRY=true Bug: 591099 Change-Id: I673ac19ec57bfdf5bd14ec6f220b7d3dff8f7818 Reviewed-on: https://chromium-review.googlesource.com/c/1304040 Commit-Queue: Koji Ishii <kojii@chromium.org> Reviewed-by:
-
Scott Violet authored
This updates the call to event injection so that it does not go through rewriters. BUG=876043 TEST=covered by tests Change-Id: Ib4f0190fa26ed66c6004fdde7c66134b4b49bdcd Reviewed-on: https://chromium-review.googlesource.com/c/1306693Reviewed-by:
David Tseng <dtseng@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#603913}
-
Charlie Harrison authored
URL rules have two vectors of domains: domains to exclude matching on, and domains to include matching on (i.e. only match on those domains). Many URL rules share vectors, so we can compress the data by only writing domain vectors once, and referencing existing vectors when we hit a duplicate. This should slow down indexing, but cut down on memory and disk usage. No meaningful behavior should change. Extensions code is not modified, so their ruleset version is not incremented, which would trigger an unnecessary re-indexing. Bug: 899790 Change-Id: Ic5763f8e65185441c1df9774961b9e004f777f31 Reviewed-on: https://chromium-review.googlesource.com/c/1305497 Commit-Queue: Charlie Harrison <csharrison@chromium.org> Reviewed-by:
-
Andrew Grieve authored
Change-Id: Ic07f2fbdd112b96cd8960e0282eaafdddf52b4db Reviewed-on: https://chromium-review.googlesource.com/c/1306789Reviewed-by:
Mohamed Heikal <mheikal@chromium.org> Commit-Queue: Mohamed Heikal <mheikal@chromium.org> Cr-Commit-Position: refs/heads/master@{#603911}
-
Geoff Lang authored
Offset the scissor and viewports based on the current surface's draw offset. This is needed for small direct composition surfaces. BUG=898001 Change-Id: I9869a5513ff728f77c70b35aba8757c969b53adc Reviewed-on: https://chromium-review.googlesource.com/c/1301955 Commit-Queue: Geoff Lang <geofflang@chromium.org> Reviewed-by:
Zhenyao Mo <zmo@chromium.org> Reviewed-by:
Sunny Sachanandani <sunnyps@chromium.org> Cr-Commit-Position: refs/heads/master@{#603910}
-
Vaclav Brozek authored
The PasswordToSave function inside NewPasswordFormManager is used to extract the password to be saved from a filled password form. This can either be the form's new-password or current-password (the latter only if there is no new-password). Currently, the PasswordToSave function returns the current-password if, in particular, the new-password field has an empty name. This breaks for sites which choose to assign no name to the new-password field. Therefore this CL changes that behaviour to only check for field values and ignore their names. Note: The old parser created dummy "anonymous*" names for unnamed fields, so while the old PasswordFormManager::PasswordToSave function has the same property as the new one, it was not an issue there. Bug: 899687 Change-Id: I31a67533f470ba62b7a3a835d1dd3d9e9ce5bab4 Reviewed-on: https://chromium-review.googlesource.com/c/1307438Reviewed-by:
Vadym Doroshenko <dvadym@chromium.org> Commit-Queue: Vaclav Brozek <vabr@chromium.org> Cr-Commit-Position: refs/heads/master@{#603909}
-
chrome://histogramsAlexei Svitkine authored
Bug: 899870 Change-Id: I3be5d81e2b8dc1bdb14c1dc19a0d4efbd34015fb Reviewed-on: https://chromium-review.googlesource.com/c/1305823Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Alexei Svitkine <asvitkine@chromium.org> Cr-Commit-Position: refs/heads/master@{#603908}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/2966c3c1332b..dfe69cae695e git log 2966c3c1332b..dfe69cae695e --date=short --no-merges --format='%ad %ae %s' 2018-10-30 lalitm@google.com trace_processor: add support for python synthesised e2e tests 2018-10-30 lalitm@google.com Merge "trace_processor: fix bug with span join" Created with: gclient setdep -r src/third_party/perfetto@dfe69cae695e The AutoRoll server is located here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:117596113 TBR=perfetto-bugs@google.com Change-Id: I3a5f4645df147b1c073de0cb2031eaa18759eda8 Reviewed-on: https://chromium-review.googlesource.com/c/1306771Reviewed-by:
-
Alex Clarke authored
Add benchmarks for UI and IO message loops. TBR=altimin@chromium.org Bug: 897751 Change-Id: I617f329afae84107df3c10c9262139946a6037b9 Reviewed-on: https://chromium-review.googlesource.com/c/1307507Reviewed-by:
Alex Clarke <alexclarke@chromium.org> Commit-Queue: Alex Clarke <alexclarke@chromium.org> Cr-Commit-Position: refs/heads/master@{#603906}
-
Tibor Goldschwendt authored
This is a reland of 0a8ce562 with a fix for x86 crashes (see crbug/899732 for more details). Original change's description: > Reland "[vr] On-demand install VR dynamic feature module" > > This is a reland of 0275d360 with a fix > for x86 builders, which have VR disabled. > > Original change's description: > > [vr] On-demand install VR dynamic feature module > > > > With this CL we initate the module install once the user enters VR on a > > WebXR/VR page. In more detail this CL > > > > - Introduces native VrModuleDelegate used to request VR module from > > native, > > > > - Refactors GvrDevice to request the VR module as part of its > > initialization flow, > > > > - Adds native side of the VrModuleProvider for Java-native > > communication. > > > > Bug: 862689 > > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > > Change-Id: I960d2bdd4d2c64a19fa6069e457d44f77ab0e73b > > Reviewed-on: https://chromium-review.googlesource.com/c/1241458 > > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > > Reviewed-by: Ted Choc <tedchoc@chromium.org> > > Reviewed-by: Bill Orr <billorr@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#602922} > > TBR=tedchoc@chromium.org,billorr@chromium.org > > Bug: 862689 > Change-Id: I7a0f383534b622e0e4acb5acb2a1c28e547d0970 > Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel > Reviewed-on: https://chromium-review.googlesource.com/c/1301568 > Reviewed-by: Tibor Goldschwendt <tiborg@chromium.org> > Commit-Queue: Tibor Goldschwendt <tiborg@chromium.org> > Cr-Commit-Position: refs/heads/master@{#603100} TBR=tedchoc@chromium.org,billorr@chromium.org Bug: 862689,899732 Change-Id: I944f97d82d04f3dc64f44a3379551f09ca1326f3 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Reviewed-on: https://chromium-review.googlesource.com/c/1305816Reviewed-by:
-
Vaclav Brozek authored
The FormData -> PasswordForm parser has a special "saving" mode, in which it optimizes for saving filled-in forms. This means that the parser ignores fields with empty values, because from those nothing can be saved. That has been true for using structural heuristics. But when the form contained autocomplete attributes or there were server hints for it, the parser would trust those even if they hinted at fields with empty values. There seems to be no reason to try to save empty-valued fields, under any circumstances, so this CL filters fields with empty values out before the parser does any kind of analysis. Bug: 899687 Change-Id: Ia5e2ff885c9f15917765c5cb70ab5501ecc40118 Reviewed-on: https://chromium-review.googlesource.com/c/1307401Reviewed-by:
-
Vaclav Brozek authored
The unittest for the FormData -> PasswordForm parser takes a description of a form and of the parsing result, synthesises the form, parses it and compares to the expected result. To keep the descriptions short, many unimportant things are generated, such as unique values of fields. Then, when a test fails, the error messages refer to the generated values, saying things like: "expected the current password to be html_304 but it is actually html_511". This makes little sense when one cannot see the form synthesised from the description. So this CL adds logging to describe the form when test failures are encoutered. Bug: 899687 Change-Id: Ic0ffdc348a490c8f1fcb3e2f193ac10a348f2494 Reviewed-on: https://chromium-review.googlesource.com/c/1307398Reviewed-by:
-
chromium-autoroll authored
https://skia.googlesource.com/skia.git/+log/5785405afa1b..52a715455181 git log 5785405afa1b..52a715455181 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader e83048e2bbfa..70942e2e8566 (1 commits) 2018-10-30 mtklein@chromium.org replace SkNVRefCnt with SkRefCnt 2018-10-30 mtklein@google.com use from/to_srgb only when known to be in [0,1] 2018-10-30 skia-autoroll@skia-public.iam.gserviceaccount.com Roll third_party/externals/swiftshader d0a4800e1487..e83048e2bbfa (1 commits) 2018-10-30 reed@google.com declare SkFont SK_API Created with: gclient setdep -r src/third_party/skia@52a715455181 The AutoRoll server is located here: https://autoroll.skia.org/r/skia-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux-chromeos-compile-dbg;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel TBR=herb@chromium.org Change-Id: I8868620d874da56190edbd02728bffae79845895 Reviewed-on: https://chromium-review.googlesource.com/c/1307553Reviewed-by:
-
Vaclav Brozek authored
The structure used to record expectations in the unittest for FormData -> PasswordForm parser allows to specify the "role" of a field -- whether that field should end up marked as the username or one of the passwords. It currently allows marking a field with a role specific for the "filling" or the "saving" mode of the parser. But it does not allow one field to have different roles in different modes. This has not been an issue, but will be in the coming CLs, where some fields will be "current password" in one mode and "new password" in the other. Therefore, this CL adds separate roles in the expectation struct to capture potentially different roles in different modes. The CL keeps the original role data member, overriding the two specialised new ones, to keep this change and the tests themselves less verbose. As a side effect, the role-describing enum is now shrinked to about a third of its original size (due to the previous need to have explicit values saying "role X for filling", "role X for saving", "role X for both"). Bug: 899687 Change-Id: Ia8c3bf433a0fc1b003b6b38a11e43ddaffb3387e Reviewed-on: https://chromium-review.googlesource.com/c/1307493Reviewed-by:
-
Aiden Benner authored
'Proxy' native methods are declared in an @JniStaticNatives interface without a native qualifier and indicate that the JNI annotation processor should generate code to link between the equivalent native method as if it were declare statically. Under the hood the annotation processor generates the actual native method declaration in another another class (org.chromium.base.natives.GEN_JNI) but generates wrapper code so it can be called through the declaring class. This CL adds support to the python header generator to generate header files and registration header files for native methods declared in an @JniStaticNatives annotated interface which uses the JNI annotation processor. Change-Id: I7a1c10f67d6b7c7dad3423634bdb995e76e751a4 Bug: 898261 Reviewed-on: https://chromium-review.googlesource.com/c/1297184 Commit-Queue: Aiden Benner <abenner@google.com> Reviewed-by:
Eric Stevenson <estevenson@chromium.org> Cr-Commit-Position: refs/heads/master@{#603900}
-
Xiaocheng Hu authored
This patch changes tests in the following directories to use Element.innerText for text dump: fast/encoding fast/events Most of this patch is mechanical rebaseline, except that some LayoutNG-specific baselines become redundant and are removed Bug: 887148 Change-Id: I057efbdbaa17a03c3f87cfec30e293a5ddd9a57f Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Reviewed-on: https://chromium-review.googlesource.com/c/1297488Reviewed-by:
Kent Tamura <tkent@chromium.org> Commit-Queue: Xiaocheng Hu <xiaochengh@chromium.org> Cr-Commit-Position: refs/heads/master@{#603899}
-
