- 26 Nov, 2019 40 commits
-
-
Matthew Mourgos authored
This change ensures that ShelfItems have the same ordering in both the ShelfView's |view_model_| and the ShelfView's child views. This is done to keep the child views in correct traversal order for ChromeVox. This change also ensures that views that are removed from the |view_model_| are also removed as child views from ShelfView. This is done in ShelfItemRemoved() by initializing a unique_ptr to the removed view. Once the unique_ptr goes out of scope the removed view is deleted and removed as a child view. Bug: 1024085 Change-Id: I4b4d6c3a855b41fc315a1d76f39c56ca0db380d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925783Reviewed-by:
Manu Cornet <manucornet@chromium.org> Commit-Queue: Matthew Mourgos <mmourgos@chromium.org> Cr-Commit-Position: refs/heads/master@{#718959}
-
John Lee authored
Bug: 1028253 Change-Id: Ia92c155d22f7f1d7e0692b7baea50d84146a70a5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935127 Commit-Queue: John Lee <johntlee@chromium.org> Reviewed-by:
Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#718958}
-
Matt Menke authored
This is needed to separate out host resolutions made from different sites. Also make PreconnectManager pass in the correct NetworkIsolationKey. The two other consumers of the API currently pass in empty NetworkIsolationKeys, and will be fixed in followup CLs. Bug: 1021661 TBR: hashimoto@chromium.org, raymes@chromium.org, jam@chromium.org Change-Id: I49d6d147f25dacce9d02112b2d0bfbe75a8a9b0b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1925136Reviewed-by:
John Abd-El-Malek <jam@chromium.org> Reviewed-by:
Oliver Chang <ochang@chromium.org> Reviewed-by:
Eric Roman <eroman@chromium.org> Reviewed-by:
Alex Ilin <alexilin@chromium.org> Commit-Queue: Matt Menke <mmenke@chromium.org> Cr-Commit-Position: refs/heads/master@{#718957}
-
Bo Liu authored
Fling has moved to browser side. Remove webview's hooks into root layer fling on the renderer side since they are obsolete. Change-Id: I81489a2458b6808ee516a4f76ca79df58e44f38e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1933448Reviewed-by:
Vasiliy Telezhnikov <vasilyt@chromium.org> Reviewed-by:
Dave Tapuska <dtapuska@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Commit-Queue: Bo <boliu@chromium.org> Cr-Commit-Position: refs/heads/master@{#718956}
-
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/004dbc282e4c..d0dd9068ec64 git log 004dbc282e4c..d0dd9068ec64 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 primiano@google.com Fix build and address nits from aosp/1172102 Created with: gclient setdep -r src/third_party/perfetto@d0dd9068ec64 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-chromium-autoroll Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:132880619 Tbr: perfetto-bugs@google.com Change-Id: Ia4d2d21e0984983baf9ba44a88269994b055d35b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935437Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718955}
-
Ayu Ishii authored
This change allows developers to use the SMS Receiver API with the Abort Controller to cancel once the API is called. This will help developers with flows for retrying and sending a new code and they want to abort the previous call they made to the API. If the InfoBar is up during abort, it will leave the InfoBar open while returning an AbortError to the website. If another request is made while the InfoBar for 1st request is still open (after abort), upon clicking 'Verify' the SMS retrieved for the 1st request will return to the 2nd request. Original CL: https://crrev.com/c/1866914 Revert CL: https://crrev.com/c/1930275 Failure ticket: https://crbug.com/1027386 Failure locally reproducible with following test command: python testing/scripts/run_isolated_script_test.py third_party/blink/tools/run_web_tests.py -t LinuxTest third_party/blink/web_tests/external/wpt/sms/interceptor.https.html --isolated-script-test-output=output.json --isolated-script-test-perf-output=perftest-output.json --additional-expectations third_party/blink/web_tests/LeakExpectations --enable-leak-detection Bug: 976401 Change-Id: I9b1208a6cf9c05185fa734809ab275235238cf4d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1929864Reviewed-by:
Reilly Grant <reillyg@chromium.org> Reviewed-by:
-
Luciano Pacheco authored
Remove duplicated types from |VolumeManagerCommon| namespace, instead change code to use type and enums directly from IDL and its externs. Mock the enums to unittest because chrome.fileManagerPrivate isn't available in the unittest running environment. Add |hasCellularNetworkAccess| where required by closure because the previous type deifinition in |VolumeManagerCommon| didn't have this attribute, defaulting to |false| which is semantically the same as |undefined|. Reasons: 1. Remove type/enum duplication. 2. Avoids comparing enums to strings which is weaker. Bug: 931971 Fix: 931971 Change-Id: I436717e2d1541ff51581a83be6f120ccba5f13db Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934128 Commit-Queue: Luciano Pacheco <lucmult@chromium.org> Auto-Submit: Luciano Pacheco <lucmult@chromium.org> Reviewed-by:
Alex Danilo <adanilo@chromium.org> Cr-Commit-Position: refs/heads/master@{#718953}
-
chromium-autoroll authored
https://chromium.googlesource.com/angle/angle.git/+log/8dfc2b05d987..4b53273c1292 git log 8dfc2b05d987..4b53273c1292 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 courtneygo@google.com Vulkan: Fix validation issue with swiftshader 2019-11-25 flibitijibibo@gmail.com Implement BaseVertex draw calls for Vulkan, OpenGL, NULL contexts. Created with: gclient setdep -r src/third_party/angle@4b53273c1292 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/angle-chromium-autoroll Please CC cwallez@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: None Tbr: cwallez@google.com Change-Id: I7556c6207eb87ede82e65f9fb3b109e03dc8213c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935435Reviewed-by:
-
chromium-autoroll authored
https://webrtc.googlesource.com/src.git/+log/6620506591b7..13ea34f30537 git log 6620506591b7..13ea34f30537 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 steveanton@webrtc.org Revert "Add IvfVideoFrameGenerator" 2019-11-25 elrello@microsoft.com Address failing wpt test cases for the rollback feature Created with: gclient setdep -r src/third_party/webrtc@13ea34f30537 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/webrtc-chromium-autoroll Please CC webrtc-chromium-sheriffs-robots@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1025557,chromium:1025542 Tbr: webrtc-chromium-sheriffs-robots@google.com Change-Id: I8c25c235083e26df7cc59d4746006311e4c3658e Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935436Reviewed-by:
-
Matt Mueller authored
These names are more descriptive and also free up the name TestNetLog for use in a future CL. Bug: 177538 Change-Id: I46a0680a690e7868bb4c325cbe27c161c2e95b7d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1912783Reviewed-by:
Brandon Tolsch <btolsch@chromium.org> Reviewed-by:
Gauthier Ambard <gambard@chromium.org> Reviewed-by:
Clark DuVall <cduvall@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/5504dc6427fb..83aafc979fa6 git log 5504dc6427fb..83aafc979fa6 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 ehmaldonado@chromium.org depot_tools: Make gsutil compatible with python3. Created with: gclient setdep -r src/third_party/depot_tools@83aafc979fa6 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/depot-tools-chromium-autoroll Please CC agable@chromium.org on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Bug: chromium:1026371 Tbr: agable@chromium.org Change-Id: Icd8ef91db7e7a3860156b7e25d00ee6597dc0efa Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935017Reviewed-by:
-
Matt Mueller authored
Forgot to document the new params added in https://chromium.googlesource.com/chromium/src/+/c13f3d7bb95c1717de7abd4282db8c7e0ffac7e7 Change-Id: I939c9ed126b063ad93f34f3ba8c1d8817fdb1059 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1930255Reviewed-by:
-
Johannes Henkel authored
PS: I admit that I've already introduced some usages cowboy-style, using the --bypass-hooks flag. I didn't remember which script to edit. Andrey's PR reminded me - thank you! Change-Id: Ie4b645fc80c2d3b28898a91a1c557bcc3d683d56 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935442Reviewed-by:
-
Alex Newcomer authored
When the hotseat is enabled, animate the shelf and hotseat at the same speed as the minimize/maximize animation. Bug: 1028387 Change-Id: I5fae2038258b3353776bd283950509ec53d26e2a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935492Reviewed-by:
Alex Newcomer <newcomer@chromium.org> Reviewed-by:
-
Johannes Henkel authored
Feels the most efficient way to accomplish this is to make data() and size() return appropriate values when impl_ isn't set. Bug: 1026646 Change-Id: I8f9f1cb6621173ced066065f4ec6b64b5a609322 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935430Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#718945}
-
Matt Falkenhagen authored
Bug: 1007763 Change-Id: I9c934d13eb233f42734098d0343bb18f5b53099d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928390Reviewed-by:
Miguel Casas <mcasas@chromium.org> Commit-Queue: Matt Falkenhagen <falken@chromium.org> Cr-Commit-Position: refs/heads/master@{#718944}
-
Demetrios Papadopoulos authored
Most of these have been fixed automatically with ESLint's --fix flag. This is in preparation of turning on presubmit checks for no-var and prefer-const for components/. Bug: 792774,720034 Change-Id: Idd8773f1d3dca7bc17f23a8ea5cac635f63546fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918694 Commit-Queue: Demetrios Papadopoulos <dpapad@chromium.org> Auto-Submit: Demetrios Papadopoulos <dpapad@chromium.org> Reviewed-by:
Colin Blundell <blundell@chromium.org> Cr-Commit-Position: refs/heads/master@{#718943}
-
Jarryd authored
Change the QuotaSettings tests to better cover the incognito quota experiment, as described by pwnall@ in https://crrev.com/c/1895074/4/ Bug: 1017120 Change-Id: Idd55ca10f1215908a80e98bdedce48d137100244 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1913172Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Jarryd Goodman <jarrydg@chromium.org> Cr-Commit-Position: refs/heads/master@{#718942}
-
Collin Baker authored
This suppresses the default context menu and shows a custom one similar to that shown when right clicking on the native window frame. Fixed: 997887 Change-Id: Ia9cc3b394b42e245b1bee783e313d94917f5c50c Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931596Reviewed-by:
John Lee <johntlee@chromium.org> Commit-Queue: Collin Baker <collinbaker@chromium.org> Cr-Commit-Position: refs/heads/master@{#718941}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/9f65850fd60b..069565ced288 Created with: gclient setdep -r src-internal@069565ced288 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC jbudorick@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: chromium:None,chromium:None,chromium:1004848,chromium:b/143469908,chromium:b/143118392,chromium:b/131785528,chromium:b/139309841,chromium:950146,chromium:1027573,chromium:951275 Tbr: jbudorick@google.com Change-Id: I2e3fd62fe32ad2158193e8abbd08402d74fd95dc Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935015Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#718940}
-
Donn Denman authored
Disables a few Omnibox tests on all versions of Android beyond KitKat because they are flaky. This is a correction to https://crrev.com/c/1931856 which got the sense of the disabling for > KitKat backwards. BUG=1027549 TBR=twellington@chromium.org Change-Id: I91be9e20633fbc418e2cb0bfd1d3101d95b6f8e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932170 Commit-Queue: Donn Denman <donnd@chromium.org> Auto-Submit: Donn Denman <donnd@chromium.org> Reviewed-by:
Chris Mumford <cmumford@google.com> Cr-Commit-Position: refs/heads/master@{#718939}
-
Caleb Rouleau authored
This reverts commit 76dc2efe. Reason for revert: https://chromium-review.googlesource.com/c/catapult/+/1896356 landed, so relanding this is fine. NOw this will have no impact on anything unless you pass in the --run-abridged-story-set flag. Original change's description: > Revert "[Telemetry] Provide abridged story sets for rendering and system health." > > This reverts commit 9867b18b. > > Reason for revert: This causes unexpected behavior per Ross's comment on https://chromium-review.googlesource.com/c/catapult/+/1874453 . I will reland this once I fix Telemetry. > > Original change's description: > > [Telemetry] Provide abridged story sets for rendering and system health. > > > > Note that this will have no impact on what is currently running > > on the waterfall because all benchmarks are labeled as > > abridged: False right now. > > > > This change is now possible because: > > > > 1. Pinpoint was taught to use the --run-full-story-set flag by > > https://chromium-review.googlesource.com/c/catapult/+/1874451 > > > > 2. benchmark_smoke_unittest.py was fixed: > > https://chromium-review.googlesource.com/c/chromium/src/+/1874821 > > > > Note that system_health_smoke_test.py is fixed as part of this > > change. > > I tested this fix by running > > /run_tests benchmarks.system_health_smoke_test.SystemHealthBenchmarkSmokeTest.system_health.memory_desktop/load:game > > and seeing that the stories, a mix of health_check stories > > and stories without the health_check tag were all run. > > > > Bug: 965158 > > Change-Id: I42ca28543155536da62d9b02d9bf31d8eb311ac3 > > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1687783 > > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > > Reviewed-by: Sadrul Chowdhury <sadrul@chromium.org> > > Reviewed-by: Juan Antonio Navarro Pérez <perezju@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#711017} > > TBR=sadrul@chromium.org,perezju@chromium.org,crouleau@chromium.org > > Change-Id: I9e7ae496ef48ed00bcf2a8d67df42c577d3162d3 > No-Presubmit: true > No-Tree-Checks: true > No-Try: true > Bug: 965158 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1893738 > Reviewed-by: Caleb Rouleau <crouleau@chromium.org> > Commit-Queue: Caleb Rouleau <crouleau@chromium.org> > Cr-Commit-Position: refs/heads/master@{#711311} TBR=sadrul@chromium.org,perezju@chromium.org,crouleau@chromium.org # Not skipping CQ checks because original CL landed > 1 day ago. Bug: 965158 Change-Id: I6420ec079c4738913bc701a6490fcd6b47b4aa3d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1932895Reviewed-by:
Caleb Rouleau <crouleau@chromium.org> Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#718938}
-
Ayu Ishii authored
Bug: 1007712 Change-Id: I3e158c9860adf07c56c3eccd18d56819162af8e2 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935171Reviewed-by:
Alexander Alekseev <alemate@chromium.org> Commit-Queue: Ayu Ishii <ayui@chromium.org> Cr-Commit-Position: refs/heads/master@{#718937}
-
Thanh Nguyen authored
This CL adds a penalty for matches that are far from the beginning of a token. It also decrease the score of Levenshtein distance. Bug: 990684 Change-Id: Ie6e2a6fd818ce8e64a435a76412115ce1904badf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1928592Reviewed-by:
Jenny Zhang <jennyz@chromium.org> Reviewed-by:
Jia Meng <jiameng@chromium.org> Commit-Queue: Thanh Nguyen <thanhdng@chromium.org> Cr-Commit-Position: refs/heads/master@{#718936}
-
Jenny Zhang authored
Bug: 916422 Change-Id: I668519db2facd9048b87eaa4b129ef32a159e513 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931654Reviewed-by:
-
Devlin Cronin authored
Bug: None Change-Id: I2a849c1fa711f6c603cdb2a4b146b75a09fba04a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1841612 Commit-Queue: Devlin <rdevlin.cronin@chromium.org> Reviewed-by:
David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#718934}
-
Jinsong Fan authored
No change to logical. Bug: 1020939 Change-Id: Ic0d98e8f6a2626da9a82007a7410d0f85918b3d8 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934131Reviewed-by:
Philip Rogers <pdr@chromium.org> Commit-Queue: Jinsong Fan <fanjinsong@sogou-inc.com> Cr-Commit-Position: refs/heads/master@{#718933}
-
rbpotter authored
When autogenerating Polymer 3 JS files, add <!--_html_template_start_--> to the beginning of the template and <!--_html_template_end_--> to the end. This will be used to identify HTML start and end locations for performing i18n replacements in a followup CL. Adding the tags allows the replacement code to search for only one set of markers, instead of needing to handle multiple syntaxes. Bug: 1023841 Change-Id: Ie70638095f5a0bf631028052ab5f2165ccc41ade Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935038Reviewed-by:
-
Brandon Wylie authored
Bug: 1020774 Change-Id: I48b32fdfbcf4dc2a20ba047ee3f93783f4fa2a38 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1918047 Commit-Queue: Brandon Wylie <wylieb@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Cr-Commit-Position: refs/heads/master@{#718931}
-
Wei-Yin Chen (陳威尹) authored
Decrease the number of iterations in StartSurfaceLayoutTest and StartSurfaceLayoutPerfTest to make them run faster on bots. Bug: None Change-Id: Ib0d10c913ca0fb7f5a8d06e200f8f5b96d510def Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935427Reviewed-by:
Yusuf Ozuysal <yusufo@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Commit-Queue: Wei-Yin Chen (陳威尹) <wychen@chromium.org> Cr-Commit-Position: refs/heads/master@{#718930}
-
Owen Min authored
Disable the test due to multiple platforms flakiness. Bug: 1028357 Tbr: rdevlin.cronin@chromium.org Change-Id: Id1bab60748b0a3a8de1fb2a352754a3584427a05 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935169Reviewed-by:
Owen Min <zmin@chromium.org> Commit-Queue: Owen Min <zmin@chromium.org> Cr-Commit-Position: refs/heads/master@{#718929}
-
David Bertoni authored
This change uses code that is compatible with both Service Worker-based extensions and background/event page-based extensions to implement the browserAction.setIcon() JavaScript code. Bug: 1015136 Change-Id: I1bc55cd5da2cc106e8d74dba172122d2bf943d31 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1921640Reviewed-by:
Devlin <rdevlin.cronin@chromium.org> Commit-Queue: David Bertoni <dbertoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#718928}
-
nancy authored
BUG=1016159 Change-Id: I17381ed839025b621600b8cd2395e95c8d035f72 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1919533 Commit-Queue: Nancy Wang <nancylingwang@chromium.org> Reviewed-by:
Xiyuan Xia <xiyuan@chromium.org> Cr-Commit-Position: refs/heads/master@{#718927}
-
Collin Baker authored
Bug: 989131 Change-Id: I532dc7bf6bc2539a40ee8be480d77fbf276d85a0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931225 Commit-Queue: Collin Baker <collinbaker@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
-
Ted Choc authored
With the past deflake attempt, it ensured the menu was present except when in the overview mode. This made tests that enter/exit the overview mode (e.g. tab switcher) prone to continued flakes. This removes the broad menu ID checks with explicit checks on the browsing mode toolbar button, which is the same logic the TabModalPresenter uses internally. Now, the tests should not have any dependencies on the toolbar visibility based on browser controls offsetting logic. BUG=1026908 Change-Id: I420d6700148abf57098ab3f88d0187cef2133bd4 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934773 Commit-Queue: Theresa <twellington@chromium.org> Reviewed-by:
-
chromium-autoroll authored
https://swiftshader.googlesource.com/SwiftShader.git/+log/e7ce4e53915d..f2637d0dd7eb git log e7ce4e53915d..f2637d0dd7eb --date=short --first-parent --format='%ad %ae %s' 2019-11-25 jonahr@google.com Present should return OUT_OF_DATE if the window size outdated Created with: gclient setdep -r src/third_party/swiftshader@f2637d0dd7eb If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/swiftshader-chromium-autoroll Please CC swiftshader-team+autoroll@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_chromium_msan_rel_ng;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:140 Tbr: swiftshader-team+autoroll@google.com Change-Id: Ic810b370da68f82f9e277b167ca711fd3ff23677 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935148Reviewed-by:
-
Sara Kato authored
Mouse events should not be forwarded to ChromeVox,if called from ARC++. This is what leads to "jumpy" and unexpected focus behaviour, as described in the bug. This CL checks if an arc window is active, and does this by adding an activation observer to wm_helper. TEST=manual (follow repro steps in bug, and observed expected behaviour) BUG=b:141597151 Change-Id: I3d1da3801c1b826164e73a97fd639523b21202ea Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1905038 Commit-Queue: Sara Kato <sarakato@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Sara Kato <sarakato@chromium.org> Cr-Commit-Position: refs/heads/master@{#718923}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/0e927af80636..bee6bf4cd336 git log 0e927af80636..bee6bf4cd336 --date=short --first-parent --format='%ad %ae %s' 2019-11-25 abennetts@google.com Revert "Add origin-trial tokens to pinpoint's index.html for prod and local dev (localhost:8080)." Created with: gclient setdep -r src/third_party/catapult@bee6bf4cd336 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC skyostil@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1026356 Tbr: skyostil@google.com Change-Id: Ied53ffe3c8a22ec45e88df040c2d9455c4f0094d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1935149Reviewed-by:
-
Caleb Rouleau authored
Make the unittests exercise this by adding args.multiple_dimension_script_verbose = True which makes verbose be true everywhere so that we can make sure the print statements work. Also add in some additional print statements to clarify what is happening. Also fix a couple easy formatting issues. Bug: 984504, 956637 Change-Id: Ib4dc4236e57f47f0c92eba84db5ae4d9cc969309 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1934526 Commit-Queue: Caleb Rouleau <crouleau@chromium.org> Reviewed-by:John Chen <johnchen@chromium.org> Auto-Submit: Caleb Rouleau <crouleau@chromium.org> Cr-Commit-Position: refs/heads/master@{#718921}
-
Benjamin Beaudry authored
In AXPlatformNodeTextRangeProviderWin, nodes with role kInlineTextBox should never be exposed to UIA. This CL introduces a simple fix. In GetEnclosingElement(), if the enclosing node is an inline text box, we simply return its parent. I also updated a unit test for this case. Bug: 928948 Change-Id: I31a31566461c3091bed36ebad626c4f51afc55a3 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1931753 Commit-Queue: Benjamin Beaudry <benjamin.beaudry@microsoft.com> Reviewed-by:
Kurt Catti-Schmidt <kschmi@microsoft.com> Cr-Commit-Position: refs/heads/master@{#718920}
-
