- 18 Aug, 2020 40 commits
-
-
Ben Pastene authored
This increases verbosity by a single level. Practically, that just means boards' SDKs that take a while to fetch will be printed. For example, it will print statements like: WARNING: It took 3m48.535s to fetch the SDK for amd64-generic. Consider removing it from your .gclient file if you no longer need to build for it. Bug: 1034063 Change-Id: I7407bb503f4145e5de6d0e6d39b596a50ea46009 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363314Reviewed-by:
Achuith Bhandarkar <achuith@chromium.org> Reviewed-by:
Dirk Pranke <dpranke@google.com> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ben Pastene <bpastene@chromium.org> Cr-Commit-Position: refs/heads/master@{#799280}
-
Sahel Sharify authored
This cl adds an enum-based metric for payment request checkout flow. Each bucket in the flow corresponds to one step during the checkout process and each payment request may be counted in multiple buckets one for each completed step. Motivation: This metric will be subscribed for Chirp alerts to catch ressions/improvements on the number of transactions using Web Payments APIs. The reason for adding this metric is that both PaymentRequest.Events and PaymentRequest.TimeToCheckout.* metrics are numerical metrics. This means that adding Chirp alerts for these metrics will only track changes in different percentiles of sample values rather than changes in sample counts. Bug: 1091471 Change-Id: I7f43df9cc373b0662a7d269de4d577e677005180 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353149Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Danyao Wang <danyao@chromium.org> Commit-Queue: Sahel Sharify <sahel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799279}
-
chromium-internal-autoroll authored
https://chrome-internal.googlesource.com/chrome/src-internal.git/+log/a651373fa953..5012a13f63ac If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://skia-autoroll.corp.goog/r/src-internal-chromium-autoroll Please CC tommycli@google.com,csharp@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chrome.try:linux-chromeos-chrome Bug: None Tbr: tommycli@google.com,csharp@google.com Change-Id: I5f3288e7afd032cb4813769cb3bd22d89242c1a6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363313Reviewed-by:
chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Reviewed-by:
Tommy Li <tommycli@chromium.org> Commit-Queue: chromium-internal-autoroll <chromium-internal-autoroll@skia-corp.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799278}
-
Chris Sharp authored
This is a reland of dc5bcc30 BYPASS_POLICY_COMPATIBILITY_CHECK=Min and max values already specified, they just were missing from the schema TBR=pmarko@chromium.org Original change's description: > Update schema for PolicyRefreshRate and MaxInvalidationFetchDelay > > Include the min and max values already specified in the policy > descriptions and in the code handling the policies. > > The limits for the PolicyRefreshRate policy are specified in > components/policy/core/common/cloud/cloud_policy_refresh_scheduler.cc. > > The limits for the MaxInvalidationFetchDelay policy are specified in > chrome/browser/policy/cloud/cloud_policy_invalidator.cc. > > BYPASS_POLICY_COMPATIBILITY_CHECK=Min and max values already specified, > they just were missing from the schema > > Change-Id: Ia1b3904dd1f377d5bc1ee7c2742f3eaeb3f34969 > Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349211 > Commit-Queue: Chris Sharp <csharp@chromium.org> > Reviewed-by: Pavol Marko <pmarko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#797407} Change-Id: I8260c5e00aabac51e92bd51f057b4648f913767a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354458Reviewed-by:
Chris Sharp <csharp@chromium.org> Commit-Queue: Chris Sharp <csharp@chromium.org> Cr-Commit-Position: refs/heads/master@{#799277}
-
Sky Malice authored
TBR: fhorschig@chromium.org Bug: 1095672 Change-Id: Ibfda160b64e49aa1d1fbbe1b747827382587290b Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363084 Commit-Queue: Sky Malice <skym@chromium.org> Reviewed-by:
Sky Malice <skym@chromium.org> Cr-Commit-Position: refs/heads/master@{#799276}
-
Leonid Baraz authored
Bug: b:153649905 Change-Id: I3eaca93d0ae7b0d0cd5c502e8536977fb66ca979 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363351Reviewed-by:
Adam Langley <agl@chromium.org> Commit-Queue: Leonid Baraz <lbaraz@chromium.org> Cr-Commit-Position: refs/heads/master@{#799275}
-
Johann authored
The comment said "In the first two cases [main frame and child frame], the RenderFrame is not the root" and "For child frames, the root is RenderFrame". It should have said "In the first two cases the Render*Widget* is not the root" Change-Id: I65e25da21326feb90b8a7b33d1f6da089aff0845 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359322Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Ken Buchanan <kenrb@chromium.org> Reviewed-by:
Erik Chen <erikchen@chromium.org> Commit-Queue: Ken Buchanan <kenrb@chromium.org> Auto-Submit: Johann Koenig <johannkoenig@google.com> Cr-Commit-Position: refs/heads/master@{#799274}
-
chrome://historychrome-native://historyPeter Kotwicz authored
This CL removes the special favicon for chrome://history to match chrome-native://history. This pattern matches the behaviour of chrome://bookmarks which also uses a native page. BUG=1104811 TEST=HistoryTest.* Change-Id: I152bd7cf75570de914013560845e64ea47b18e18 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2335650 Commit-Queue: Peter Kotwicz <pkotwicz@chromium.org> Reviewed-by:
Ted Choc <tedchoc@chromium.org> Reviewed-by:
dpapad <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#799273}
-
Patrick Monette authored
With this CL, the ServiceWorkerContextAdapter drops duplicate OnControlleeAdded or OnControlleeRemoved notifications from the ServiceWorkerContextObserver interface. Bug: 993029, 1015692 Change-Id: I482a7d9db93cf6f8abd6475f7b0256f0f53857cf Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2354528Reviewed-by:
Chris Hamilton <chrisha@chromium.org> Commit-Queue: Patrick Monette <pmonette@chromium.org> Cr-Commit-Position: refs/heads/master@{#799272}
-
Chris Cunningham authored
Updates Audio/Video Decoder to reject invalid codecs passed to configure(). A TypeError should be thrown. Additionally, if the config is valid but unsupported, throw a NotSupportedError. Adds wpt test to verify the behavior for validity. Support behavior is difficult to wpt test (varies by build/platform) - tested manually. Bug: 1113824 Change-Id: I647c476fa32e684d57816222e1787aeb8f723c25 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360312Reviewed-by:
Thomas Guilbert <tguilbert@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Chrome Cunningham <chcunningham@chromium.org> Cr-Commit-Position: refs/heads/master@{#799271}
-
RJ Ascani authored
The ContextParams.cdm_data_directory is provided by the client for the storage of CDM user data. This CL populates this field for CastRunner with persistent-isolated-cache. This is temporary to prevent breakage. Bug: 1051225, b/162078899 Change-Id: Idd291e318ccaf256194ae207018c77c8cfedd574 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2315001 Commit-Queue: RJ Ascani <rjascani@google.com> Reviewed-by:
Wez <wez@chromium.org> Cr-Commit-Position: refs/heads/master@{#799270}
-
Jonathan Backer authored
Currently we can't create a new device without restarting the GPU process. Change-Id: I79ae5cb44aace17e5f6123a14fcf9d01588948fb Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363253 Commit-Queue: Jonathan Backer <backer@chromium.org> Reviewed-by:
Peng Huang <penghuang@chromium.org> Cr-Commit-Position: refs/heads/master@{#799269}
-
David Bienvenu authored
Bug: 1107492 Change-Id: I7d6dc6d866e2d90f81ced9403b3c52d2ee3d54ad Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2349688 Commit-Queue: David Bienvenu <davidbienvenu@chromium.org> Reviewed-by:
Alan Cutter <alancutter@chromium.org> Cr-Commit-Position: refs/heads/master@{#799268}
-
Tommy Li authored
This CL enables the passing oft=2 (rather than oft=1) for on-clobber ZeroSuggest. oft is a GET parameter for Suggest requests, which means: oft=0 normal prefix suggestions oft=1 on-focus oft=2 on-clobber We recently created the new oft=2 value, but haven't used it yet. This is the CL that starts using it. This is going to temporarily break it, since the server is not yet set up to handle this yet. We will fix the server next. Bug: 1106096 Change-Id: I2796dcc9cdb553765876f4341414d15b5e648ad1 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363488 Commit-Queue: Tommy Li <tommycli@chromium.org> Reviewed-by:
manuk hovanesian <manukh@chromium.org> Cr-Commit-Position: refs/heads/master@{#799267}
-
Anton Paymyshev authored
SkBitmap used as a source for icon bitmaps generation may have color components premultiplied by alpha value. In that case utilizing SkBitmap pixels as is makes them appear darker in resulting icon where no premultiplication is expected. With this CL premultiplied alpha pixels are converted to pixels where colors components are independent from alpha channel if required. Bug: 1090720 Change-Id: Idfc34fe66fbd6d4ed1a44332c59b0f9bd6d9fc84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2345144Reviewed-by:
Scott Violet <sky@chromium.org> Commit-Queue: Scott Violet <sky@chromium.org> Cr-Commit-Position: refs/heads/master@{#799266}
-
Jan Wilken Dörrie authored
In order to make BasicStringPiece API compatible with C++17's std::basic_string_view this change removes the starts_with() API and updates call sites to use base::StartsWith instead. In order to keep this callsites concise, base::StartsWith's case_sensitivity parameter now defaults to CompareCase::SENSITIVE. TBR=dcheng Bug: 1049498 Change-Id: Ie621c6d08283d2ffd1055c5753ade5451f5c0b1d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358745 Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Cr-Commit-Position: refs/heads/master@{#799265}
-
Michael Thiessen authored
native_java_unittests are going away, so these tests need to be migrated to javatests. Bug: 1103344 Change-Id: I49a99d1cc1e3170d4af01af8e1a75e9b09249fc5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2353391 Commit-Queue: Michael Thiessen <mthiesse@chromium.org> Reviewed-by:
Yaron Friedman <yfriedman@chromium.org> Cr-Commit-Position: refs/heads/master@{#799264}
-
Weilun Shi authored
Currently, we only reset the client id in the local pref when toggling UMA enable state. We should also reset all low entropy sources as well to be more consistent. When a user (re)enables UMA, we immediately generate a new client id, and start including it in UMA reports. However, we don't have to generate a new low entropy source immediately, because we can't change the trial assignments for the current session and we will set `client_id_was_used_for_trial_assignment` to false on these records so they can be excluded from most analysis. Instead, the low entropy sources are removed from local state, which will cause new ones to be generated and used in the next session. Bug: 1053529 Change-Id: Ie1437e5799fea8f854e9a1bbcfbefee7652c9847 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2355396 Commit-Queue: Weilun Shi <sweilun@chromium.org> Reviewed-by:
Steven Holte <holte@chromium.org> Reviewed-by:
Alexei Svitkine <asvitkine@chromium.org> Auto-Submit: Weilun Shi <sweilun@chromium.org> Cr-Commit-Position: refs/heads/master@{#799263}
-
Fred Mello authored
The clank team is trying to review the ownership of all `/android` directories and add/update OWNERS as part of an effort to normalize code health metrics across different data sources. https://docs.google.com/document/d/17QautLenV9WAiFN240ZE0SBK2nHCpwu_cgcvV95-lvE Bug: 1112872 Change-Id: I3861be0e6d1488b3173169bf776e463e35c32edd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2356444 Commit-Queue: Fred Mello <fredmello@chromium.org> Auto-Submit: Fred Mello <fredmello@chromium.org> Reviewed-by:
Theresa <twellington@chromium.org> Reviewed-by:
Donn Denman <donnd@chromium.org> Cr-Commit-Position: refs/heads/master@{#799262}
-
Thomas Guilbert authored
This CL adds tests which verify that VideoFrames are properly serialized when posted as messages, and that they can be cloned and destructoyed. Change-Id: I4aedcde443a8f8f0b1884a106cebd013a4d482d5 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358349Reviewed-by:
Chrome Cunningham <chcunningham@chromium.org> Commit-Queue: Chrome Cunningham <chcunningham@chromium.org> Auto-Submit: Thomas Guilbert <tguilbert@chromium.org> Cr-Commit-Position: refs/heads/master@{#799261}
-
Rakina Zata Amni authored
This was previously used as a condition instead of a DCHECK because of crbug.com/1107269. Bug: 1107269 Change-Id: I16c814fb60b40bb508c8fa43fa91f41b27feb5af Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359970 Auto-Submit: Rakina Zata Amni <rakina@chromium.org> Commit-Queue: Charlie Reis <creis@chromium.org> Reviewed-by:
Charlie Reis <creis@chromium.org> Cr-Commit-Position: refs/heads/master@{#799260}
-
Maksim Sisov authored
The effort to have a single Linux config that can either use ozone/x11/wayland or non-ozone/x11 path revealed one problem with the "remoting" component. Basically, what we are doing is that we make use_x11 == use_ozone == is_linux. That means that we have 1) just one Linux config 2) user can switch to OzonePlatform by passing --enable-features=UseOzonePlatform. However, the condition to enable remoting is based on old assumption that is_linux == use_x11 && use_ozone != use_x11. Given that, the remoting targets are disabled and linux-rel bot starts to complain. Thus, as an initial remoting support on Ozone/Linux, make these targets compiled for is_linux regardless if it has ozone set or not. Further investigation and verification of the feature is required to close the bug. Bug: 1112776 Change-Id: I7d8c523c96d5f430b8f9891a4568894bd523f3d0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362667Reviewed-by:
Thomas Anderson <thomasanderson@chromium.org> Commit-Queue: Maksim Sisov (GMT+3) <msisov@igalia.com> Cr-Commit-Position: refs/heads/master@{#799259}
-
Mason Freed authored
This test already had a bug, in progress. TBR=schenney@chromium.org Bug: 1115661 Change-Id: Ic6205cc36b34f04c043e2bd6bd215fdcc60fde0f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363354Reviewed-by:
Mason Freed <masonfreed@chromium.org> Commit-Queue: Mason Freed <masonfreed@chromium.org> Cr-Commit-Position: refs/heads/master@{#799258}
-
chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/c2cee61d1ff6..abfdfbb66838 2020-08-18 bsheedy@chromium.org [Telemetry] Add Android emulator support If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/catapult-autoroll Please CC rmhasan@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:chromeos-kevin-rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Bug: chromium:1084352 Tbr: rmhasan@google.com Change-Id: Ie45bec0f5dd544834559709e8d5ed69d2ded6c4f Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363312Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799257}
-
Dan Harrington authored
Added asserts for xsurface APIs that need to be called on the UI thread. For processViewAction(), I'm using postTask because the caller does not call on the UI thread. We can fix this on the other side of xsurface once it has a postTask API. Bug: 1117586 Change-Id: I16f298353f7a8f3999215f3aa2e667e7fa282398 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363352Reviewed-by:
Cathy Li <chili@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#799256}
-
Daniel Rubery authored
The SafeBrowsingNetworkContext is being profile-keyed, and this CL changes the PingManager to use the new per-profile NetworkContexts. Bug: 1049833 Change-Id: I70c068ad5a0a5b7008550c44ae61c2410c40b2ac Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358054Reviewed-by:
Xinghui Lu <xinghuilu@chromium.org> Reviewed-by:
Nate Fischer <ntfschr@chromium.org> Reviewed-by:
Tim Volodine <timvolodine@chromium.org> Reviewed-by:
Min Qin <qinmin@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#799255}
-
Anqing Zhao authored
To fulfill the requirement of accessibility settings page (secondary window in the Web Kiosk session), the fullscreen mechanism was replaced from using ash::WindowPinType::kTrustedPinned to SHOW_STATE_FULLSCREEN. See: https://chromium-review.googlesource.com/c/chromium/src/+/2170227. But this change introduced the visible shelf which should always be hidden. In this CL, one new conditional is added to forcedly hidden it based on the new mechanism. Bug: 1102359 Change-Id: I30c6b2f71089e924c6b8751c943cce1c4ce994b0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359131 Commit-Queue: Anqing Zhao <anqing@chromium.org> Reviewed-by:
Toni Baržić <tbarzic@chromium.org> Reviewed-by:
Anatoliy Potapchuk <apotapchuk@chromium.org> Cr-Commit-Position: refs/heads/master@{#799254}
-
Dan Harrington authored
See bug for detailed problem. This change adds a new signal sent to the feed component, informing that the feed is shown. This happens the first time feed content is seen, even if a card is hardly shown. Bug: 1117265 Change-Id: Ic0eb7fbb67a16b7f06554bc1ae48efa34662d106 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360600Reviewed-by:
Ian Wells <iwells@chromium.org> Commit-Queue: Dan H <harringtond@chromium.org> Cr-Commit-Position: refs/heads/master@{#799253}
-
Alan Ding authored
https://chromium.googlesource.com/chromiumos/platform2/system_api.git/+log/63c9de2bf41a..bbd71acf57db $ git log 63c9de2bf..bbd71acf5 --date=short --no-merges --format='%ad %ae %s' 2020-08-06 stevenjb shill: add kErrorDisconnect for dropped wifi connections 2020-08-14 alanding system_api: Add "ignore_dev_conf" field to StartArcVmRequest 2020-07-06 cujomalainey system_api: remove mic position constant Created with: roll-dep src/third_party/cros_system_api Bug: b:159953121 Change-Id: I030dcd3e029893a4da8cffdb9dbead635cd155bd Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2361285Reviewed-by:
Yusuke Sato <yusukes@chromium.org> Reviewed-by:
Aga Wronska <agawronska@chromium.org> Commit-Queue: Alan Ding <alanding@chromium.org> Cr-Commit-Position: refs/heads/master@{#799252}
-
Lily Chen authored
This change makes RestrictedCookieManager report a bad Mojo message and close the pipe when the URL setting a CanonicalCookie does not match the domain attribute of the cookie. The histogram Net.RestrictedCookieManager.SetCanonicalCookieDomainMatch was previously added to measure the frequency of mismatch. It was determined that mismatches occur very rarely, so it seems safe to enforce that the domains must match. This histogram is removed, since it has served its purpose. Bug: 996786, 1109832 Change-Id: I4456a2eb9d3449c89933a903ce3c038816f7018d Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360316Reviewed-by:
Maksim Orlovich <morlovich@chromium.org> Reviewed-by:
David Schinazi <dschinazi@chromium.org> Commit-Queue: Lily Chen <chlily@chromium.org> Cr-Commit-Position: refs/heads/master@{#799251}
-
Olivier Yiptong authored
Enables Origin Trial for the Font Access API. Bug: 535764 Change-Id: I257a329c3bcb52696c043eebe2d809542733f6e6 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359470Reviewed-by:
Kentaro Hara <haraken@chromium.org> Reviewed-by:
Stephen Chenney <schenney@chromium.org> Reviewed-by:
Joshua Bell <jsbell@chromium.org> Commit-Queue: Olivier Yiptong <oyiptong@chromium.org> Cr-Commit-Position: refs/heads/master@{#799250}
-
Justin Donnelly authored
Currently it's possible to run all the Pedals code but not actually show the Pedals if the button row Feature is not enabled. This change makes the dependence of Pedals on button row explicit. Bug: 893183 Change-Id: Ib30cec31fa21e8dac138aa0341ace6bc8ea124ee Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2362993 Commit-Queue: Orin Jaworski <orinj@chromium.org> Reviewed-by:
Orin Jaworski <orinj@chromium.org> Cr-Commit-Position: refs/heads/master@{#799249}
-
Anders Hartvoll Ruud authored
This CL adds support for expanding animation-timeline from the animation shorthand. As of [1], we support multiple shorthand expansions based on runtime flags, so there is no web-facing change to the animation shorthand (or anything else) unless the CSSScrollTimeline runtime flag is turned on. According to [2], we are supposed to omit the value from the shorthand serialization if doing so doesn't change the meaning of the overall value of the shorthand (i.e. if it's 'auto'). Unfortunately we generally don't adhere this guideline for the existing longhands, and are therefore not equipped to handle this as gracefully as I would like. For now I am checking for 'auto' "manually". Long term we might want to generalize this "skip-if-initial" mechanism somehow, since it has come up before [3], and will definitely come up again. Note that: - Animation::CSSValueFromComputedStyleInternal is the code responsible for the serialization used when calling getComputedStyle(elm).animation, and: - StylePropertySerializer::GetLayeredShorthandValue is the code responsible for the serialization used when calling (e.g.) elm.style.animation. The fact that we have two completely separate code paths for this is ... suboptimal, but that's a different story. [1] https://crrev.com/c/2250242 [2] https://drafts.csswg.org/cssom/#serializing-css-values [3] http://crrev.com/c/2241677 Bug: 1074052 Change-Id: I6f5266ca202276e78536a845835242181b8cd40a Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358837 Commit-Queue: Anders Hartvoll Ruud <andruud@chromium.org> Reviewed-by:
Kevin Ellis <kevers@chromium.org> Cr-Commit-Position: refs/heads/master@{#799248}
-
Noah Rose Ledesma authored
This change allows the MediaNotificationContianerImplView to dynamically respond to size changes of the audio device selector. This will be helpful in redesign of that UI in which the size of the view will vary. To facilitate communication between the device picker and the container a new delegate class was created. Because the container should support varying sizes, its observer class was modified to eliminate the notion of expanded vs unexpanded. Instead observers will be notified of a size change and should query the container for its new size. Bug: 1116694 Change-Id: Id832b77a4617645a6c48672670c22ccda88eab82 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2358890 Commit-Queue: Noah Rose Ledesma <noahrose@google.com> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
Tommy Steimel <steimel@chromium.org> Cr-Commit-Position: refs/heads/master@{#799247}
-
Brian Sheedy authored
Adds data dependencies to chrome_telemetry_test_without_chrome that are necessary to run Telemetry tests in an Android emulator. Bug: 1084352 Change-Id: I7ebdbf6ebee81b9cf67c1d2618d227540ff2c576 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360483 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Commit-Queue: John Chen <johnchen@chromium.org> Auto-Submit: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
John Chen <johnchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#799246}
-
Ankit Kumar 🌪️ authored
Updated all direct instances of pp::Point to gfx::Point/gfx::Vector2d based on context. pp::Point is used to represent both a point as well as a 2D-vector. gfx provides two separate classes for point and 2D-vectors. Switching to them based on the context. The CL only migrates pp::Point without changing PDFEngine interface layer. In pepper model, we have used pp::Point to denote a point as well as a 2D vector. Based on the usage of the pp::Point migrate it to gfx::Point or gfx::Vector2d. A position is represented by gfx::Point while an offset is represented by gfx::Vector2d. Bug: 1101101 Change-Id: I7e6e4eba3ad141ac76b6590fe10286cd6b38aaae Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2327770Reviewed-by:
Lei Zhang <thestig@chromium.org> Reviewed-by:
K. Moon <kmoon@chromium.org> Commit-Queue: Ankit Kumar
🌪 ️ <ankk@microsoft.com> Cr-Commit-Position: refs/heads/master@{#799245} -
chromium-autoroll authored
https://android.googlesource.com/platform/external/perfetto.git/+log/1756465158d3..b6a272ffee65 If this roll has caused a breakage, revert this CL and stop the roller using the controls here: https://autoroll.skia.org/r/perfetto-trace-processor-win-chromium Please CC perfetto-bugs@google.com on the revert to ensure that a human is aware of the problem. To report a problem with the AutoRoller itself, please file a bug: https://bugs.chromium.org/p/skia/issues/entry?template=Autoroller+Bug Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+doc/master/autoroll/README.md Tbr: perfetto-bugs@google.com Change-Id: If32a74b7c2bb70a7bc3486357ab6edfa3e1a06c0 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2363187Reviewed-by:
chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#799244}
-
Brian Sheedy authored
Adds the configurations for the upcoming GPU arm64 Mac CI builder + its manual trybot mirror. Submitted with no-try due to crbug.com/1117624 blocking submission. No-Try: True Bug: 1105648 Change-Id: Ie2e6edb623469f470da99389e07d51089d177a84 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360555 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Garrett Beaty <gbeaty@chromium.org> Reviewed-by:
Yuly Novikov <ynovikov@chromium.org> Cr-Commit-Position: refs/heads/master@{#799243}
-
Nicolás Peña Moreno authored
This CL adds some optimization to do an early return when we know that the PaintTimingDetectors are not going to do any work. This is the case when the documentElement is visible and there is some opacity:0 (as those paints are going to be ignored), as well as when the documentElement is invisible and there is an opacity:0 depth higher than 1. Bug: 1113723, 1113411, 1113067 Change-Id: If7a5a0224a89aa1da659b177da0d45d8dca30d57 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2360480Reviewed-by:
Xianzhu Wang <wangxianzhu@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#799242}
-
Naomi Musgrave authored
chrome/services/sharing/* - Introduced InitiateBandwidthUpgrade to request a higher-bandwidth connection for a particular endpoint chrome/browser/nearby_sharing/nearby_connections_manager* - Browser side usage of InitiateBandwidthUpgrade. NearbyConnectionsManager uses InitiateBandwidthUpgrade to request a higher connection data rate. This is triggered by the NearbySharingService receiving an incoming payload. Bug: 1076008 Change-Id: Iea1d38c4298aade06556b23baa6761cf51bb1da9 Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/2359140Reviewed-by:
Alex Chau <alexchau@chromium.org> Reviewed-by:
Alex Gough <ajgo@chromium.org> Commit-Queue: Naomi Musgrave <nmusgrave@chromium.org> Cr-Commit-Position: refs/heads/master@{#799241}
-