GitLab

Bug: 850902
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I8b55358e69fdf297cbd3079c20f8a3fe6585355d
Reviewed-on: https://chromium-review.googlesource.com/1099768Reviewed-by: Xiaoqian Dai <xdai@chromium.org>
Commit-Queue: Wenzhao (Colin) Zang <wzang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567138}

Clients can send an image over mojo once and then reference it by its
unique token. Apply this to the browser frame theme image.

Bug: 836992
Change-Id: I91bbb060eead928780dc3d4d78dda9e5ba1b96d3
Reviewed-on: https://chromium-review.googlesource.com/1088235
Commit-Queue: Evan Stade <estade@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Tom Sepez <tsepez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567137}

Change-Id: Ifbfd63387c1060f664530ce54963303ff3146fd0
Reviewed-on: https://chromium-review.googlesource.com/1100109Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567136}

Three new services:
 - mesh_provisioning
 - mesh_proxy
 - reconnection_configuration

Eighteen new characteristics:
 - exact_time_100
 - secondary_time_zone
 - time_broadcast
 - battery_power_state
 - battery_level_state
 - temperature_celsius
 - temperature_fahrenheit
 - position_2d
 - position_3d
 - removable
 - service_required
 - scientific_temperature_celsius
 - string
 - network_availability
 - digital_output
 - analog_output
 - pulse_oximetry_control_point
 - date_utc

Bug: 517115
Change-Id: I036374fa5d750c072af238f1e35bff4eef43e1ac
Reviewed-on: https://chromium-review.googlesource.com/1100126Reviewed-by: Giovanni Ortuño Urquidi <ortuno@chromium.org>
Commit-Queue: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567135}

Crashes show a task coming from
-[NSWindow _endWindowBlockingModalSession:returnCode:] (before 10.13) or
NSWindowEndWindowModalSession() (10.13 and later). This attempts to access
the |modalDelegate| argument given to -[NSApp beginSheet:...], which is
not retained, and can be destroyed in some lifetimes.

The task is likely the one posted via an asynchronous Close() on a sheet,
attempting to close the sheet using [NSApp endSheet:]. If a parent window
of a sheet then triggers a more abrupt close, the sheet gets closed via
-[NSWindow close] as well. Normally, the delegate would be retained to
also end the sheet (to unblock the sheet machinery on the parent). However,
this only happens if the sheetParent is non-nil. It appears that under
some racy teardown paths the sheet's sheetParent can be nil at this point.

To fix, pass the NSWindow itself as |modalDelegate| to permit WeakPtr-like
semantics on the ViewsNSWindowDelegate. This allows some confusing
lifetimes in ViewsNSWindowDelegate to be tightened up, as well as cleanly
handle the mixed close codepaths that we have to cater for.

Bug: 851376
Change-Id: I1954dc76f7cff5dc3f54f879aaad51fec12b623f
Reviewed-on: https://chromium-review.googlesource.com/1096593
Commit-Queue: Trent Apted <tapted@chromium.org>
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567134}

In the current layout engine, PreviousBreakOpportunity is used
only when mid-word break (break-all or break-word), but it is
much more heavily used in LayoutNG.

LazyLineBreakIterator is designed for forward only.
PreviousBreakOpportunity is implemented by repeatedly calling
NextBreakablePosition, but since NextBreakablePosition look
for the next break opportunity until the end of the string,
when a very long word without break opportunity is given,
PreviousBreakOpportunity is O(n!).

This patch changes it to O(n) by limiting the end position
NextBreakablePosition can look for.

blink/perf_tests/layout/word-break-break-word.html consumes
78% of the total time in LayoutNG. The average run is:
  Current engine:    469ms
  LayoutNG:       26,644ms
  This patch:      2,250ms

It's still 4-5 times slower, more improvements will be in
following patches.

Bug: 636993
Cq-Include-Trybots: master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: I814e2c45c8030aa682c7f5e3a3b785b3c0733c84
Reviewed-on: https://chromium-review.googlesource.com/1095894
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Emil A Eklund <eae@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567133}

- Hides the toolbar border for Edit Folder and Edit Bookmark.
- Removes the Done Button on the Folder Picker.
- Adds separators to BookmarksHomeTableView.
- Removes white background from FolderPicker.

Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I26e58dcdb1c65761cf10c7a6956778b02df0b16a
Reviewed-on: https://chromium-review.googlesource.com/1098516
Commit-Queue: Sergio Collazos <sczs@chromium.org>
Reviewed-by: edchin <edchin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567132}

This reverts commit aceb7d67.

Reason for revert: Even though the heuristic seems off we tuned parameters around it that will trigger GCs. 

Bug: 852413

Original change's description:
> [oilpan] Fix for EsimateLiveSize
> 
> Take current value for base size, similarly to what is used for
> PartitionAlloc. This makes sure that an esimate is computed at the time
> of calling the method.
> 
> Bug: chromium:840789
> Change-Id: Iab7e63f5395cbc74226cd786d420c6145fdb7dd9
> Reviewed-on: https://chromium-review.googlesource.com/1094822
> Reviewed-by: Kentaro Hara <haraken@chromium.org>
> Reviewed-by: Keishi Hattori <keishi@chromium.org>
> Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#565967}

TBR=haraken@chromium.org,keishi@chromium.org,hpayer@chromium.org,mlippautz@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: chromium:840789
Change-Id: I323527b2f6d4703773ca11f980a4233cb8554f7a
Reviewed-on: https://chromium-review.googlesource.com/1100435Reviewed-by: Michael Lippautz <mlippautz@chromium.org>
Reviewed-by: Kentaro Hara <haraken@chromium.org>
Commit-Queue: Michael Lippautz <mlippautz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567131}

Following bot results are included.
6722 6729 6730 6732 6741 6764 6779 6783 6793 6806 6827 6828

2 lines were removed and 2 lines were deflaked by consecutive
results since 6722.

TBR=eae@chromium.org, mstensho@chromium.org
NOTRY=true

Bug: 591099
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;master.tryserver.chromium.linux:linux_layout_tests_layout_ng
Change-Id: Ibc93f3b5e44a2c1c48ae7355b73dc87aa493f2e9
Reviewed-on: https://chromium-review.googlesource.com/1097239
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567130}

This CL also fixes a bug where selecting a connected network in an error
screen during login would continue instead of opening the configuration
UI (e.g. to set a proxy).

For dead code removal from device_local_account_browsertest.cc:

Bug: 689198
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I91250b264c2f42e40ab647aaef364154eb367413
TBR: pmarko@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1083672
Commit-Queue: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567129}

This CL intends to fix a memory leak happening with a focused input form.
This seems to be happening because spellchecker holds a cold_mode_requester_, which holds an input element.
Spellchecker is reused (kept alive) by a local frame, so whatever spellchecker has references to will leak over navigation.
Other references were cleared in Deactivate() but the element was not.

BUG=852216

Change-Id: I96a872bad6348d7e1d6a160d2aa88d2fe9ba77cd
Reviewed-on: https://chromium-review.googlesource.com/1096926
Commit-Queue: Yuzu Saijo <yuzus@chromium.org>
Reviewed-by: Xiaocheng Hu <xiaochengh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567128}

Chrome's "firstrun" Java code downloads the seed and stores it in
SharedPreferences (see VariationsSeedBridge.setVariationsFirstRunSeed),
from which native later reads it. WebView loads the seed in Java (on
every run, not just the first run), and re-used the firstrun code to
pass the seed to native. However, SharedPreferences is slow--storing the
seed takes 4 milliseconds on marlin. Create AwVariationsSeedBridge which
keeps the seed in memory. Retrieve the seed via JNI. This avoids any
file I/O. The JNI takes ~.1 milliseconds on the same device.

Reuse VariationsSeedStore's "firstrun" seed import mechanism to verify
the seed, report the result via UMA, and store the seed in the
PrefService. This means that in WebView's case, the histogram
Variations.FirstRunResult will be recorded every time the seed is
loaded, not just on the first run.

BUG=846898

Change-Id: Ib1f33f45923f1f5b273663643569841b05648a7d
Reviewed-on: https://chromium-review.googlesource.com/1081305
Commit-Queue: Paul Miller <paulmiller@chromium.org>
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567127}

To remove indirect layers around Modulator.

Bug: 842553
Change-Id: Ib4d2d6a3e348723cb9a9bd980b616ea4517dab3b
Reviewed-on: https://chromium-review.googlesource.com/1080007Reviewed-by: Kouhei Ueno <kouhei@chromium.org>
Reviewed-by: Hiroki Nakagawa <nhiroki@chromium.org>
Commit-Queue: Hiroshige Hayashizaki <hiroshige@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567126}

https://skia.googlesource.com/skia.git/+log/fdcfb8b7c23f..657edbede4e3


git log fdcfb8b7c23f..657edbede4e3 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 bungeman@google.com Remove SkBool8 (again).
2018-06-13 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 3e313805e5a2..4cc753e01054 (8 commits)
2018-06-13 bungeman@google.com Adjust FreeType matrix based on what came back.
2018-06-13 csmartdalton@google.com ccpr: Initialize the atlas size more intelligently
2018-06-13 fmalita@chromium.org Handle missing json resource gracefully in 3dgm
2018-06-13 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-13 benjaminwagner@google.com Update Win version in Skolo.
2018-06-13 bungeman@google.com Remove SkString fwd decl from SkTypes.h.
2018-06-13 robertphillips@google.com Revert "Add --gpuThreads support to skpbench.py"
2018-06-13 recipe-roller@chromium.org Roll recipe dependencies (trivial).
2018-06-13 mtklein@google.com Revert "simplify SkTFitsIn, try 2"
2018-06-13 mtklein@google.com Revert "use std::enable_if instead of assert()"
2018-06-13 robertphillips@google.com Add --gpuThreads support to skpbench.py
2018-06-13 robertphillips@google.com Pull non-substantive changes out of omnibus CL
2018-06-13 egdaniel@google.com Remove unused code that was used for late mip allocations.
2018-06-13 egdaniel@google.com Fix ImageTest to check if gpu mip maps are supported.
2018-06-13 caryclark@skia.org minor fixes to SkRRect
2018-06-13 khushalsagar@chromium.org fonts: Ignore re-initialization of fallback glyphs from the server.
2018-06-13 mtklein@chromium.org use std::enable_if instead of assert()
2018-06-13 mtklein@chromium.org Does everyone support __has_include() now?
2018-06-13 bungeman@google.com Remove SkMulDiv.
2018-06-13 bungeman@google.com Always FreeType autohint when requested.
2018-06-13 timliang@google.com consolidated writing fields logic and added more builtins for skslc msl backend
2018-06-13 egdaniel@google.com Allow caller to specify if the want mip maps in makeTextureImage call.
2018-06-13 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 7ce4a15115cb..3e313805e5a2 (2 commits)
2018-06-13 mtklein@chromium.org simplify SkTFitsIn, try 2
2018-06-13 robertphillips@google.com Fix IsFunctionallyExact


Created with:
  gclient setdep -r src/third_party/skia@657edbede4e3

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:829622,chromium:834837,chromium:849034
TBR=csmartdalton@chromium.org

Change-Id: If651c755d8ea6b2cf1bb3c8f84e8709e80f352a4
Reviewed-on: https://chromium-review.googlesource.com/1100316Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567125}

When using OOP raster, the renderer must send the requisite glyphs for
rasterization with the paint commands that need them. If the glyph can't
be found, the GPU will fallback to using the closest match available in
the cache. Ideally, this should never happen and indicates an error in
the analysis code in the renderer for identifying these glyphs.

Add an UMA to record the number of such instances and in the extreme
case where no fallback can be found and we skip drawing this glyph, do a
DumpWithoutCrashing.

R=piman@chromium.org

Bug: 829622
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ibcdaf408009a085d11374a6e7ef2897ff8e61fc8
Reviewed-on: https://chromium-review.googlesource.com/1096543
Commit-Queue: Khushal <khushalsagar@chromium.org>
Reviewed-by: Gayane Petrosyan <gayane@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567124}

Renamed chrome_file_manager.js to
chrome_file_manager_private_test_impl.js to make it clearer that the file
is for testing.

Added test.Event to be used for all fmp events.


Bug: 813477
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I7804480dd27f113005346a049242948c01666f08
Reviewed-on: https://chromium-review.googlesource.com/1100135Reviewed-by: Alexey Baskakov <loyso@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567123}

This reverts commit 82a1baac.

Reason for revert: Compile error when building all targets locally. Reverting the patch locally fixes it. The error message was:

-------------------------------------------
[316/344] ACTION //ui/file_manager/file_manager/background/js:media_import_handler_compile(//build/toolchain/linux:clang_x64)
FAILED: gen/ui/file_manager/file_manager/background/js/media_import_handler_compile.js 
python ../../third_party/closure_compiler/js_binary.py --compiler ../../third_party/closure_compiler/compiler/compiler.jar --output gen/ui/file_manager/file_manager/background/js/media_import_handler_compile.js --deps gen/ui/file_manager/file_manager/background/js/media_import_handler.js_library --sources --flags extra_annotation_name=attribute extra_annotation_name=demo extra_annotation_name=element extra_annotation_name=group extra_annotation_name=hero extra_annotation_name=homepage extra_annotation_name=status extra_annotation_name=submodule compilation_level=SIMPLE_OPTIMIZATIONS jscomp_error=accessControls jscomp_error=ambiguousFunctionDecl jscomp_error=checkTypes jscomp_error=checkVars jscomp_error=constantProperty jscomp_error=deprecated jscomp_error=externsValidation jscomp_error=globalThis jscomp_error=invalidCasts jscomp_error=missingProperties jscomp_error=missingReturn jscomp_error=nonStandardJsDocs jscomp_error=suspiciousCode jscomp_error=undefinedNames jscomp_error=undefinedVars jscomp_error=unknownDefines jscomp_error=uselessCode jscomp_error=visibility language_in=ECMASCRIPT_2017 language_out=ECMASCRIPT5_STRICT chrome_pass polymer_pass jscomp_off=duplicate --externs ../../third_party/closure_compiler/externs/chrome.js ../../third_party/closure_compiler/externs/polymer-1.0.js
../../ui/file_manager/file_manager/common/js/metrics.js:58: ERROR - variable analytics is undeclared
    metrics.analytics_ = analytics.getService('Files app', chromeVersion[1]);
                         ^^^^^^^^^

../../ui/file_manager/file_manager/common/js/metrics.js:79: ERROR - variable goog is undeclared
  var deferred = new goog.async.Deferred();
                     ^^^^

2 error(s), 0 warning(s)
------------------------------------------------------


Original change's description:
> Centralize externs_list BUILD.gn declarations
> 
> The externs_list is used by the Closure compiler, to type check imported
> terms like 'chrome.fileManagerPrivate.foo', and to ensure that when
> minimizing JS code from 'foo.bar.baz()' to 'a.b.c()', well known names
> like 'chrome' aren't minimized.
> 
> However, the files_manager app does not ship Closure-compiled code in
> production. It ships uncompiled code - the .js files as written by the
> programmer. Instead, the externs_list is used indirectly by the
> js_type_check("closure_compile") rules as a lint-style check.
> 
> Prior to this CL, maintaining the externs_list was therefore ad hoc and
> indirect. For example, the hand-written and hand-maintained BUILD.gn
> files would contain rules like:
> 
> js_library("foo") {
>   deps = [
>     "../../common/js:elephant",
>     "../../common/js:giraffe",
>   ]
>   externs_list = [
>     "../../../externs/apple.js",
>     "../../../externs/banana.js",
>   ]
> }
> 
> where foo.js might not refer to externs/apple.js any longer, and it
> might actually depend on externs/pear.js that is only coincidentally
> satisfied because common/js/giraffe.js happens to list externs/pear.js
> on its externs_list. This might be true at any particular point in time,
> but as new code is added, and as existing code is refactored, the
> externs_list entries become stale.
> 
> After this CL, each js_type_check("closure_compile") target has an
> associated js_library("closure_compile_externs") BUILD.gn target. This
> gives exactly one place to list all the external dependencies of every
> Closure compilation target.
> 
> Future commits may re-organize the very fine grained (only 1 .js file
> per js_library BUILD.gn target) js_library targets into larger units,
> and in doing so, push duplicated externs_list entries from the leaves of
> the BUILD.gn dependency tree towards the root. This could arguably help
> us move towards shipping Closure compiled JS instead of hand-written JS.
> But the first step is to get a handle on the dependencies (i.e.
> externs_list entries) in the first place.
> 
> Test: "ninja ui/file_manager:closure_compile" runs without error
> Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
> Change-Id: I1a3b029b5223db12abd38077d56914ad9d28a396
> Reviewed-on: https://chromium-review.googlesource.com/1092399
> Reviewed-by: calamity <calamity@chromium.org>
> Reviewed-by: Sasha Morrissey <sashab@chromium.org>
> Commit-Queue: Nigel Tao <nigeltao@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567072}

TBR=calamity@chromium.org,sashab@chromium.org,nigeltao@chromium.org

Change-Id: Ifd6b7f91e942e9f560a9c2f0ed4f73c087cee60c
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Reviewed-on: https://chromium-review.googlesource.com/1100555Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: Darren Shen <shend@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567122}

This implementation is a port of tether::BleServiceDataHelperImpl, but
correctly uses its provided DevicePair arguments, and uses a
RemoteDeviceCache for device storage.

This CL also fixes a small bug in tether::BleServiceDataHelperImpl that
caused it to attempt to identify *all* known Tether hosts, instead of the
requested hosts.

Bug: 824568, 752273
Change-Id: Ib8ab47dfcb2889392b6ec5f519aed706ffc513d9
Reviewed-on: https://chromium-review.googlesource.com/1098146
Commit-Queue: Ryan Hansberry <hansberry@chromium.org>
Reviewed-by: Kyle Horimoto <khorimoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567121}

TBR=johnchen@chromium.org

Bug: 852616
Change-Id: I8046cc162d1cb39d9809bd2bcd3a09b3a29212b8
Reviewed-on: https://chromium-review.googlesource.com/1100125Reviewed-by: Carlos Knippschild <carlosk@chromium.org>
Reviewed-by: John Chen <johnchen@chromium.org>
Commit-Queue: Carlos Knippschild <carlosk@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567120}

TBR=ellyjones@chromium.org

Bug: 767397
Change-Id: I88764b5dad273ec9dbea975cc6e97ce799ce6fe1
Reviewed-on: https://chromium-review.googlesource.com/1100296Reviewed-by: John Budorick <jbudorick@chromium.org>
Commit-Queue: John Budorick <jbudorick@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567119}

Upstream re-attempt at https://github.com/web-platform-tests/wpt/pull/9854.
Adds more untested IDL deps.

Change-Id: Icf7bda0f264ec66f4980e0742485eb406e334c19
Reviewed-on: https://chromium-review.googlesource.com/1089862
Commit-Queue: Luke Bj <lukebjerring@chromium.org>
Reviewed-by: Reilly Grant <reillyg@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567118}

Bug: 837577
Cq-Include-Trybots: master.tryserver.chromium.linux:closure_compilation
Change-Id: I709b737af4e8b77de40be4f2798681ffa45532b4
Reviewed-on: https://chromium-review.googlesource.com/1097948Reviewed-by: Alexander Alekseev <alemate@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Commit-Queue: Xiaoyin Hu <xiaoyinh@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567117}

This CL updates Chromium Closure Compilation docs to use GN-based
compilation.

Bug: 632206
Change-Id: Ie3aef4b7f81744e04051489731acf4e7aa80da15
Reviewed-on: https://chromium-review.googlesource.com/1098749Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org>
Commit-Queue: calamity <calamity@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567116}

Add Media.CodecImage.SurfaceTextureGLOwner.WaitTimeForFrame and
Media.CodecImage.ImageReaderGLOwner.WaitTimeForFrame to histograms.xml.
These were added in the source code by CL 561988 but was not added
to histograms.xml.

Bug: 849218
Change-Id: I417e19816398aad194e534379e4cbe3dca3e4383
Reviewed-on: https://chromium-review.googlesource.com/1093540Reviewed-by: Brian White <bcwhite@chromium.org>
Commit-Queue: vikas soni <vikassoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567115}

Bug: 773383
Change-Id: Ibf4bb5fe5881248489d01bf52fc6100f31c9266c
Reviewed-on: https://chromium-review.googlesource.com/1099681
Commit-Queue: Sébastien Marchand <sebmarchand@chromium.org>
Reviewed-by: Chris Hamilton <chrisha@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567114}

This is the view that is shown when there are no devices found.
For the first three seconds, it will show a throbber. After that, it
will show a help icon that links to a help center article.

Whenever the dialog receives a model update containing sinks, the "no
devices" view is replaced with the sink list view.

Video:
https://drive.google.com/open?id=18zr2x3B30HsRc0j9hYry8_dZWXAlW5e_

Bug: 846164
Change-Id: I203197b5300c604a062deb303c18d5c98631c761
Reviewed-on: https://chromium-review.googlesource.com/1089580
Commit-Queue: Takumi Fujimoto <takumif@chromium.org>
Reviewed-by: Bret Sepulveda <bsep@chromium.org>
Reviewed-by: mark a. foltz <mfoltz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567113}

This incremental change adds the pref dependency and starts to register
feed preferences.

Bug: 831648
Change-Id: Ifb5ed97ac1de87a6319539839f9c57be46fb89b1
Reviewed-on: https://chromium-review.googlesource.com/1093982Reviewed-by: Filip Gorski <fgorski@chromium.org>
Reviewed-by: Gabriel Charette <gab@chromium.org>
Commit-Queue: Sky Malice <skym@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567112}

Don't delete feedback reports files on disk on the
report destruction. This leads to losing pending reports
on sign out or reboot. Instead explicitly delete the files
once successfully uploaded, or when a no-retry failure occurs.

BUG=851687
TEST=Added new test.

Change-Id: I64caf16f63ea73c1888d8b097543e9eacabc1d9e
Reviewed-on: https://chromium-review.googlesource.com/1099758
Commit-Queue: Ahmed Fakhry <afakhry@chromium.org>
Reviewed-by: Rahul Chaturvedi <rkc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567111}

In the new dialog proposal, expiration date is aligned on the right for
LTR language, and on the left for RTL languages.

Bug: 852094
Change-Id: I255ad02c270bca3fc7f2fa548d54a4ec889d278b
Reviewed-on: https://chromium-review.googlesource.com/1097938
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567110}

Bug: 852118
Change-Id: I8069787fda1a3e26086e16fe3839cbc30e3c5f7c
Reviewed-on: https://chromium-review.googlesource.com/1094488
Commit-Queue: Pedro Amaral <amaralp@chromium.org>
Reviewed-by: Matthew Jones <mdjones@chromium.org>
Reviewed-by: Ted Choc <tedchoc@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567109}

This adds DefaultView.VisibleRows metrics to UnifiedSystemTray. It was
previously implemented in old SystemTray.

PatchSet 1: Moving SystemTrayItem::UmaType to SystemTrayItemUmaType
PatchSet 2: Implement the metrics in UnifiedSystemTray

TEST=manual
BUG=842079

Change-Id: Ied65e288147c59b6df0a8312a86e30a35fa4b953
Reviewed-on: https://chromium-review.googlesource.com/1094821
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567108}

Fuchsia packages were not generated with is_chromecast=true. The problem
with library loading has been fixed, so there is no reason not to
generate packages anymore.

TBR=dpranke@chromium.org

Bug: 810069
Change-Id: I5ab66414bab4c6e9eab8c5dd12360656ba5e7d44
Reviewed-on: https://chromium-review.googlesource.com/1099995
Commit-Queue: Sergey Ulanov <sergeyu@chromium.org>
Reviewed-by: Dirk Pranke <dpranke@chromium.org>
Reviewed-by: Kevin Marshall <kmarshall@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567107}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/31d539486159..41ff7a035785


git log 31d539486159..41ff7a035785 --date=short --no-merges --format='%ad %ae %s'
2018-06-13 recipe-roller@chromium.org Roll recipe dependencies (trivial).


Created with:
  gclient setdep -r src/third_party/depot_tools@41ff7a035785

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.


TBR=agable@chromium.org

Change-Id: I0fadd83cdcff0d1551d3e6a76967c83d67626280
Reviewed-on: https://chromium-review.googlesource.com/1100118Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#567106}

Update navigator.requestMediaKeySystemAccess() to support querying for
encryption scheme support. This is based on
https://github.com/WICG/encrypted-media-encryption-scheme/blob/master/explainer.md.

BUG=657957
TEST=new layout and browser tests pass

Change-Id: I5ba39861bab673a61dd65c12fe82d6ba3bd63ddb
Reviewed-on: https://chromium-review.googlesource.com/959459Reviewed-by: Kentaro Hara <haraken@chromium.org>
Reviewed-by: Nate Chapin <japhet@chromium.org>
Reviewed-by: Xiaohan Wang <xhwang@chromium.org>
Commit-Queue: John Rummell <jrummell@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567105}

Method injects a binding object to the target's main frame that
allows communication with browser target.

R=pfeldman, dgozman

Change-Id: Ic36a058c2cba41fccb9419318676a4fdc04a8454
Reviewed-on: https://chromium-review.googlesource.com/1066289
Commit-Queue: Andrey Lushnikov <lushnikov@chromium.org>
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567104}

In order to update counter-reset correctly, MoveNonResetSiblingsToChildOf
is called, so the non-reset sibling will become the child of this reset
CounterNode. If this reset node is nested inside another CounterNode,
the sibling's nested layer won't be correct. So we should skip calling
MoveNonResetSiblingsToChildOf() in the nested case.

Bug: 849107
Change-Id: I8c59e18785dfec18c4bc2053e9c01041c23e4183
Reviewed-on: https://chromium-review.googlesource.com/1098867Reviewed-by: Koji Ishii <kojii@chromium.org>
Reviewed-by: Darren Shen <shend@chromium.org>
Commit-Queue: cathie chen <cathiechen@tencent.com>
Cr-Commit-Position: refs/heads/master@{#567103}

The file size is very useful for the user and it's in the UI design.

This CL adds the pipeline to show the file size in download location
dialog.

Bug: 846222
Change-Id: I972955571a6dd8b781c784167a4aee697b98d486
Reviewed-on: https://chromium-review.googlesource.com/1097713
Commit-Queue: Xing Liu <xingliu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567102}

This CL changes the back button of a detailed view to have custom shape
following the UX spec.

To do this, this CL splits CustomShapeButton from CollapseButton, and
derives CollapseButton and BackButton from CustomShapeButton.

Screenshot: http://screen/Lkuj2DJCYHP
UX spec: http://shortn/_N5oGsw6QZ0

TEST=manual
BUG=850396

Change-Id: I08554db7e78e710e96dd670917d612dbadee5ccb
Reviewed-on: https://chromium-review.googlesource.com/1096813Reviewed-by: Yoshiki Iguchi <yoshiki@chromium.org>
Commit-Queue: Tetsui Ohkubo <tetsui@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567101}

Related CL https://chromium-review.googlesource.com/c/chromium/src/+/1065964
see testing/buildbot/filters/mash.ash_unittests.filter

Bug: None
Change-Id: Ia2f278b23ff20ed6084a9482e2e47c6206489be0
Reviewed-on: https://chromium-review.googlesource.com/1098415
Commit-Queue: Sara Kato <sarakato@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567100}

This CL is desirable today, to avoid the memory leaks associated with
queueing of IPCs that are sent to RenderProcessHosts that are
constructed, but not yet initialized - such RenderProcessHosts
accumulate IPC messages and flush them only after renderer process is
actually launched at a later point / after a call to RPH::Init.
This aspect of the CL is very similar to r562797 which landed earlier.

This CL is desirable for the future - a tentative long-term plan for
https://crbug.com/813045 is to avoid creating an IPC channel before
RPH::Init is called.  This means that in the long-term
RPH::GetChildIdentity will crash (dereferencing a nullptr
|RenderProcessHostImpl::child_connection_|) if called on an
uninitialized RPH.  This CL ensures that this crash won't happen in
ClientSideDetectionService::SendModelToProcess and
SpellcheckService::OnCustomDictionaryChanged by ensuring that these
methods only work with already initialized RPHs.

The changes under //chrome/browser/spellchecker and
//chrome/browser/safe_browsing skip uninitialized RPHs for 2 specific
IPCs/subsystems.  The changes under //content/browser/renderer_host
prevent future IPCs/subsystems from using uninitialized RPHs, by
adding a DCHECK to RenderProcessHostImpl::GetChildIdentity.
The new DCHECK necessitates setting |is_initialized_ = true| much
earlier in RenderProcessHostImpl::Init (because
ChromeContentBrowserClient::RenderProcessWillLaunch needs to call
RPH::GetChildIdentity).

Bug: 813045
Change-Id: I4783de85cb7c199ab360f8361acd54c63287e1df
Reviewed-on: https://chromium-review.googlesource.com/1095433Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Reviewed-by: Jialiu Lin <jialiul@chromium.org>
Reviewed-by: Rachel Blum <groby@chromium.org>
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Cr-Commit-Position: refs/heads/master@{#567099}