- 02 Aug, 2018 40 commits
-
-
Dan Sinclair authored
This will pull in the SPIRV-Tools fuzzers. TBR=piman@chromium.org Change-Id: I16112846d862dbeb385cd2d22fe639376d63629f Reviewed-on: https://chromium-review.googlesource.com/1161090Reviewed-by:
dsinclair <dsinclair@chromium.org> Commit-Queue: dsinclair <dsinclair@chromium.org> Cr-Commit-Position: refs/heads/master@{#580305}
-
Dan Elphick authored
Use v8::Value::SameValue instead which does not require a Context and works just as well (if not faster) when both arguments are v8::Strings. Change-Id: I41f4e2b78f94671b4408c45b97c0e7b22ba554fb Reviewed-on: https://chromium-review.googlesource.com/1150524Reviewed-by:
Jochen Eisinger <jochen@chromium.org> Commit-Queue: Dan Elphick <delphick@chromium.org> Cr-Commit-Position: refs/heads/master@{#580304}
-
Cathy Li authored
Bug: 867488 Change-Id: Ibb67a81cfef555e93128ae395fe6a9f0081a45ed Reviewed-on: https://chromium-review.googlesource.com/1157183 Commit-Queue: Cathy Li <chili@chromium.org> Reviewed-by:
Dmitry Titov <dimich@chromium.org> Reviewed-by:
Justin DeWitt <dewittj@chromium.org> Cr-Commit-Position: refs/heads/master@{#580303}
-
Christopher Cameron authored
Consider the sequence: 1. We query the number of displays using CGGetActiveDisplayList and get |display_count| as 0. 2. We allocate a vector |displays| with that size, so it's nullptr. 3. We populate that vector with a call to CGGetActiveDisplayList, but, because |displays| is nullptr, that populates |display_count| with the number of displays on the system. 4. BUT, it so-happens that between steps 1 and 3, we added an active display, so |display_count| is now non-zero. 5. We now index into |displays|, which is empty, and blow up. Early-out if our initial |display_count| is zero to avoid this situation. Bug: 870320, 869570 Change-Id: Ibeec67ce430faccb6e350af3fb335f1770e7b072 Reviewed-on: https://chromium-review.googlesource.com/1160769 Commit-Queue: ccameron <ccameron@chromium.org> Reviewed-by:
Kenneth Russell <kbr@chromium.org> Reviewed-by:
ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#580302}
-
Jared Saul authored
Bug: 868566 Change-Id: Icf41453cc6b4528463e32338d30eef0c037ce6b4 Reviewed-on: https://chromium-review.googlesource.com/1159738 Commit-Queue: Jared Saul <jsaul@google.com> Reviewed-by:
Sebastien Seguin-Gagnon <sebsg@chromium.org> Cr-Commit-Position: refs/heads/master@{#580301}
-
Matthew Jones authored
This patch re-adds some of the code that was removed during Chrome Home cleanup to correctly position the overflow menu when anchored to the bottom of the screen (removal patch fround here: https://chromium-review.googlesource.com/c/chromium/src/+/934978). Bug: 866265 Change-Id: I4e4341b138cd9315f9a7fae8cbf47487923a0086 Reviewed-on: https://chromium-review.googlesource.com/1161174Reviewed-by:
Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#580300}
-
Danyao Wang authored
This is to ensure that BrowserViewController's |updateToolbar| never mistakes the pending back/forward navigation item for the last committed item and prematurely hides adaptive toolbar. Bug: 842151 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I22e8358c1127878a983a657ad1373ed98303d6f7 Reviewed-on: https://chromium-review.googlesource.com/1157915Reviewed-by:
Eugene But <eugenebut@chromium.org> Commit-Queue: Danyao Wang <danyao@chromium.org> Cr-Commit-Position: refs/heads/master@{#580299}
-
Hector Carmona authored
Bug: 832938 Change-Id: I4d3c11c20bcd0ee529d64907d277f25c5fae873e Reviewed-on: https://chromium-review.googlesource.com/1159691Reviewed-by:
-
Chris Palmer authored
A last-ditch sanity check in case of memory corruption. Bug: 680657 Change-Id: I79934eceb4fcb6ce64422cee5004f057d40a6cab Reviewed-on: https://chromium-review.googlesource.com/1134523Reviewed-by:
Kentaro Hara <haraken@chromium.org> Commit-Queue: Chris Palmer <palmer@chromium.org> Cr-Commit-Position: refs/heads/master@{#580297}
-
Mohamed Amir Yosef authored
This CL add the logic to merge the local model with the remote model upon first enable sync. Bug: 516866 Change-Id: I8c53c5167b1bc3305f9339a9a0e2a8ffb1702ffb Reviewed-on: https://chromium-review.googlesource.com/1150523 Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> Reviewed-by:
Mikel Astiz <mastiz@chromium.org> Cr-Commit-Position: refs/heads/master@{#580296}
-
Gang Wu authored
Implement logging API skeleton Bug:831638 Change-Id: I3b4d1f520fe0073bb81bbebc77765c3c76409cbd Reviewed-on: https://chromium-review.googlesource.com/1160591Reviewed-by:
-
Daniel Rubery authored
We shouldn't cache a verdict if the URL is not valid for reputation computation. As a particularly bad case, about:blank can be safe in some cases, and phishing in others. Change-Id: I9ece3084f6a732003783e7db6db49345c73bfd59 Bug: 865625 Reviewed-on: https://chromium-review.googlesource.com/1161086Reviewed-by:
Jialiu Lin <jialiul@chromium.org> Commit-Queue: Daniel Rubery <drubery@chromium.org> Cr-Commit-Position: refs/heads/master@{#580294}
-
mrefaat authored
- Make PreloadController conform to CRWWebStatePolicyDecider protocol. - Add the preloadController as a policy decider directly after the webstate is created (in StartPrerender) and make sure it's removed when the webstate is not in the prerender state anymore. - Use ShouldAllowRequest of CRWWebStatePolicyDecider to block the navigation, if the request url can be handled by either ITunesUrlHandlerTabHelper, or AppLauncherTabHelper. - Update CRWWebController, so it doesn't use isAppLaunchingAllowedForWebState to cancel prerender navigation. - Remove isAppLaunchingAllowedForWebState WebState delegate method and all its usages. Bug: 674991, 850760 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I96721de983f74834b0d5a6d8977849e995523e98 Reviewed-on: https://chromium-review.googlesource.com/1157692Reviewed-by:
-
Sam Maier authored
We don't need to use AsyncTask here since we don't use any onPreExecute or onPostExecute. Webview cannot have a UI thread set during CookieManager startup, so having AsyncTask post to the UI thread when it runs onPostExecute is not going to work. Bug: 542151 Change-Id: I289722205588c86bcc9fbde6206447223426e5d8 Reviewed-on: https://chromium-review.googlesource.com/1161043Reviewed-by:
Richard Coles <torne@chromium.org> Commit-Queue: Sam Maier <smaier@chromium.org> Cr-Commit-Position: refs/heads/master@{#580292}
-
Nicolas Pena authored
Bug: 673775 Change-Id: Id385dfce82e2a31da523a0dd41c656ce0c648c6f Reviewed-on: https://chromium-review.googlesource.com/1157262Reviewed-by:
Annie Sullivan <sullivan@chromium.org> Commit-Queue: Nicolás Peña Moreno <npm@chromium.org> Cr-Commit-Position: refs/heads/master@{#580291}
-
nacl-chromium-autoroll authored
https://chromium.googlesource.com/native_client/src/native_client.git/+log/fa95e2a7489d..0a6e2d0dcbc5 git log fa95e2a7489d..0a6e2d0dcbc5 --date=short --no-merges --format='%ad %ae %s' 2018-08-02 hinoka@google.com Whitespace change to kick off luci jobs Created with: gclient setdep -r src/native_client@0a6e2d0dcbc5 The AutoRoll server is located here: https://nacl-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. BUG=chromium:868204 TBR=mseaborn@chromium.org Change-Id: I6407dfe743c2a9080085b3ce8c723a23cc1fe2ad Reviewed-on: https://chromium-review.googlesource.com/1160792Reviewed-by:
nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: nacl-chromium-autoroll <nacl-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580290}
-
bsheedy authored
Adds VrBrowserControllerInputTest#testDragRefresh, which tests that clicking and dragging the webpage down while at the top of the page triggers a refresh. A similar test that tests scroll refreshing will be added once the functionality is fixed and doesn't require swipes at inhuman speeds to perform. Bug: 861949 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:linux_vr;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I5cd56e8289b137fb78c0ad8731022373928f6132 Reviewed-on: https://chromium-review.googlesource.com/1153830 Commit-Queue: Brian Sheedy <bsheedy@chromium.org> Reviewed-by:
Michael Thiessen <mthiesse@chromium.org> Cr-Commit-Position: refs/heads/master@{#580289}
-
Johannes Henkel authored
There's just one field for the enabled bit so this one's trivial; I made an InnerEnable to avoid having multiple fields. For reference the PR that introduced the new InspectorSessionState / InspectorAgentState / Fields was https://chromium-review.googlesource.com/c/chromium/src/+/1149201. We're migrating things from state_ to this new mechanism, which allows incremental updates to flow back to the browser process. Change-Id: I57b45ccb2595fc9167390361715cc9d795941699 Reviewed-on: https://chromium-review.googlesource.com/1159730Reviewed-by:
Andrey Kosyakov <caseq@chromium.org> Reviewed-by:
Marijn Kruisselbrink <mek@chromium.org> Commit-Queue: Johannes Henkel <johannes@chromium.org> Cr-Commit-Position: refs/heads/master@{#580288}
-
Elad Alon authored
Compress remote-bound WebRTC event logs while writing them to disk. * Logs for which the file size budget did not allow covering the entire call, can now get more coverage. * Short calls, for which we could log the entire call anyhow, benefit from a lower cost in bandwidth when the log is uploaded. Compression takes place incrementally over the duration of the call, avoiding a spike in resource utilization. The file-size limit is very strictly abided by. Before compression takes place, an estimation is made over whether the compressed string will fit in the file without exceeding the budget. If not, the file is terminated (as it would for the uncompressed version). In the unlikely case that the estimation is mistaken, and we've compressed to the point that writing to the file would make it exceed its allotted maximum size, the file is dicarded. (It is infeasible to write a compression footer at that point.) Bug: 775415 Change-Id: Iab6b91815c4e9e855ced16668dbfd65ed64ad9f0 Reviewed-on: https://chromium-review.googlesource.com/1142147 Commit-Queue: Elad Alon <eladalon@chromium.org> Reviewed-by:
Guido Urdaneta <guidou@chromium.org> Cr-Commit-Position: refs/heads/master@{#580287}
-
Chris Hamilton authored
This samples metrics regularly, which will provide a better understanding of time spent in each state, and reasons preventing state transitions. BUG= Change-Id: I5677a64615931e52234a439a4e2565c8b4fc363a Reviewed-on: https://chromium-review.googlesource.com/1153135 Commit-Queue: Chris Hamilton <chrisha@chromium.org> Reviewed-by:
Sébastien Marchand <sebmarchand@chromium.org> Cr-Commit-Position: refs/heads/master@{#580286}
-
Peter Collingbourne authored
It looks like we always need to call SetUpBundleOverrides no matter what the process type is, so we can just call it from ChromeMain. This will save us from needing to call this function from browser-specific code in a later change. While here, also remove a dead declaration. Bug: 855193 Change-Id: I449d92ef9c7d80d066d4cfefb3015014bd407cc1 Reviewed-on: https://chromium-review.googlesource.com/1159335Reviewed-by:
Robert Sesek <rsesek@chromium.org> Reviewed-by:
Avi Drissman <avi@chromium.org> Commit-Queue: Avi Drissman <avi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580285}
-
Scott Violet authored
It's assumed clients are running their own gesture recognizers, so there is no need to forward gesture events. It's possible this code is unnecessary. I say that as in theory ServerWindow stops-propagation on touchs, which should mean gestures aren't recognized, but there may be some other code paths I'm not aware of, so I'm adding early outs, and a DCHECK. And I'm also adding an explicit test. BUG=867035 TEST=covered by test Change-Id: I13d78133b87d07164bf3265788fd0298832d6a2c Reviewed-on: https://chromium-review.googlesource.com/1161058 Commit-Queue: Scott Violet <sky@chromium.org> Reviewed-by:
Michael Wasserman <msw@chromium.org> Cr-Commit-Position: refs/heads/master@{#580284}
-
Travis Skare authored
Bug: 869513 Change-Id: Idd1db8f01eb27cb5b5cfdc063ee23b0dc09feb15 Reviewed-on: https://chromium-review.googlesource.com/1157167 Commit-Queue: Travis Skare <skare@chromium.org> Reviewed-by:
Justin Donnelly <jdonnelly@chromium.org> Cr-Commit-Position: refs/heads/master@{#580283}
-
Chase Phillips authored
This is the next step in removing IO thread hopping from the renderer-side non-Blink IDB code. Bug: 717812 Change-Id: I4f0bfc8d98ad7bd9d041954f74215f75271702f9 Reviewed-on: https://chromium-review.googlesource.com/1155794Reviewed-by:
Chris Mumford <cmumford@chromium.org> Reviewed-by:
Reilly Grant <reillyg@chromium.org> Commit-Queue: Chase Phillips <cmp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580282}
-
Sandra Sun authored
The previous code doesn't check nullptrs thoroughly, causing clusterfuzz pages to crash. This patch adds the checks for those cases to make sure they don't crash. Bug: 863338 Change-Id: Ibed005057fa376cb65200ad51e6dbb16bafa2c6a Reviewed-on: https://chromium-review.googlesource.com/1142457 Commit-Queue: Sandra Sun <sunyunjia@chromium.org> Reviewed-by:
Robert Flack <flackr@chromium.org> Reviewed-by:
Majid Valipour <majidvp@chromium.org> Cr-Commit-Position: refs/heads/master@{#580281}
-
John Delaney authored
Take the PageLoadMetricsWaiter and separate it from the PageLoadMetricsBrowserTest so it can be used for specific observer tests. Rename to PageLoadMetricsTestWaiter to reflect is is only intended for testing purposes. Change-Id: Id506c194ab658eba2b5364f201db140023baae72 Reviewed-on: https://chromium-review.googlesource.com/1158973 Commit-Queue: John Delaney <johnidel@chromium.org> Reviewed-by:
Charlie Harrison <csharrison@chromium.org> Cr-Commit-Position: refs/heads/master@{#580280}
-
Jan Wilken Doerrie authored
This change implements subscribing to Gatt Notifications for WinRT and enables corresponding tests. Bug: 821766 Change-Id: I805d17d25dc8749cdd34c926a86046cb207ec5c7 Reviewed-on: https://chromium-review.googlesource.com/1156686Reviewed-by:
Giovanni Ortuño Urquidi <ortuno@chromium.org> Commit-Queue: Jan Wilken Dörrie <jdoerrie@chromium.org> Cr-Commit-Position: refs/heads/master@{#580279}
-
Yiming Zhou authored
This change refactors the captured sites automation framework code out of autofill_captured_sites_interactive_uitest. By completing this refactor, other Chrome teams can leverage the captures sites automation framework to test their team's features on real-world sites. Also included in this change are a few minor fixes: 1. Fixed the captured sites autofill test to work with EventWaiters. 2. Modified a few test recipe files to address test breaks caused by removing the client name parameter from autofill server queries. Bug: 866152 Change-Id: Iee47cee8bd038ce0920caf6d63440c90c94b6285 Reviewed-on: https://chromium-review.googlesource.com/1147512 Commit-Queue: Yiming Zhou <uwyiming@google.com> Reviewed-by:
-
kristipark authored
New notifications for Top Sites or Suggestions would overwrite the current custom links, regardless if custom links was initialized or not. This would replace the tiles in the frontend with the new set of Top Sites/Suggestions and break custom link functionality. Bug: 856394 Change-Id: Id60459722448f626c1c21e2424cbfbe55df5b6c6 Reviewed-on: https://chromium-review.googlesource.com/1159325 Commit-Queue: Kristi Park <kristipark@chromium.org> Reviewed-by:
Marc Treib <treib@chromium.org> Cr-Commit-Position: refs/heads/master@{#580277}
-
Jun Choi authored
Bug: 870193 Change-Id: Ie7131514e1cf45f958dca11df8a142ea92440cad Reviewed-on: https://chromium-review.googlesource.com/1159992Reviewed-by:
Kim Paulhamus <kpaulhamus@chromium.org> Commit-Queue: Jun Choi <hongjunchoi@chromium.org> Cr-Commit-Position: refs/heads/master@{#580276}
-
Johannes Henkel authored
There's just one field for the enabled bit so this one's trivial (with an InnerEnable() function). For reference the PR that introduced the new InspectorSessionState / InspectorAgentState / Fields was https://chromium-review.googlesource.com/c/chromium/src/+/1149201. We're migrating things from state_ to this new mechanism, which allows incremental updates to flow back to the browser process. Change-Id: I25b61b207354dee8eeeb9718dd5bbf205f769eea Reviewed-on: https://chromium-review.googlesource.com/1159737Reviewed-by:
Victor Costan <pwnall@chromium.org> Commit-Queue: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#580275}
-
Donn Denman authored
Updates the sending of the Resolve request to no longer include cookies, and to only include the URL when the Unified Conset helper's anonymous data collection is enabled. BUG=865104, 825428 Change-Id: Id33afbcca55ddafcade925d5e717ce1167701ae2 Reviewed-on: https://chromium-review.googlesource.com/1155839 Commit-Queue: Donn Denman <donnd@chromium.org> Reviewed-by:
Mihai Sardarescu <msarda@chromium.org> Cr-Commit-Position: refs/heads/master@{#580274}
-
David Tseng authored
TBR=dcheng@chromium.org Bug: 842872 Test: touch explore to within the VK; verify that if you wait for the window message to read, you get a hint thereafter. Cq-Include-Trybots: luci.chromium.try:closure_compilation Change-Id: I136837ee7f20145aa09815f84d107613671eba1a Reviewed-on: https://chromium-review.googlesource.com/1108923 Commit-Queue: David Tseng <dtseng@chromium.org> Reviewed-by:
David Tseng <dtseng@chromium.org> Reviewed-by:
Daniel Cheng <dcheng@chromium.org> Reviewed-by:
Yuichiro Hanada <yhanada@chromium.org> Reviewed-by:
Dominic Mazzoni <dmazzoni@chromium.org> Cr-Commit-Position: refs/heads/master@{#580273}
-
catapult-chromium-autoroll authored
https://chromium.googlesource.com/catapult.git/+log/7110f0868455..eae13a4b34cc git log 7110f0868455..eae13a4b34cc --date=short --no-merges --format='%ad %ae %s' 2018-08-02 wangge@google.com Add Test Runner to Long Term Health Tool Created with: gclient setdep -r src/third_party/catapult@eae13a4b34cc The AutoRoll server is located here: https://catapult-roll.skia.org Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG=chromium:863390 TBR=sullivan@chromium.org Change-Id: I27c7cae3d66f22240391425e227dbf14553609af Reviewed-on: https://chromium-review.googlesource.com/1160787Reviewed-by:
catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#580272}
-
Joshua Bell authored
The option would seemingly allow the creation of HttpOnly cookies, which is not permitted with the document.cookie API and we don't want to introduce that capability here. This didn't work anyway as the API would fail the cookie creation as coming from a non-HTTP source and reject the script call, so just remove the option. Spec issue: https://github.com/WICG/cookie-store/issues/41 Spec PR: https://github.com/WICG/cookie-store/pull/87 Bug: 729800 Change-Id: Id1115db5fbb432a3dd7647b565c5e7e8f45d4e14 Reviewed-on: https://chromium-review.googlesource.com/1160927 Commit-Queue: Victor Costan <pwnall@chromium.org> Reviewed-by:
-
Marc Treib authored
This allows ProfileSyncService to start up in "standalone transport" mode even if the user has disabled Sync-the-feature. In particular, the disable reasons USER_CHOICE and PLATFORM_OVERRIDE and the FirstSetupComplete state don't prevent Sync-the-transport from starting up. Still missing: - GetState should now be renamed to GetTransportState. - UI code hasn't been updated, so UI might show wrong state. - New integration tests. Bug: 856179 Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I59d3a4b548b279ec6cb5ca563747859dd9533618 Reviewed-on: https://chromium-review.googlesource.com/1148392Reviewed-by:
Sergio Collazos <sczs@chromium.org> Reviewed-by:
Elly Fong-Jones <ellyjones@chromium.org> Reviewed-by:
-
Mike Dougherty authored
This boolean needs to be reset in order to prevent an extra |Cancel| hit for the ContextMenu.DelayedElementDetails metric. Bug: None Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet Change-Id: I271a8d4ca58b854b92c1b09d8a8346f0f00d65a4 Reviewed-on: https://chromium-review.googlesource.com/1159600Reviewed-by:
-
Bence Béky authored
Use OnceCallback instead of Callback (which is an alias for RepeatedCallback) in AddressSorter, take it by value instead of const ref in Sort() method. While this does not directly involve changing a CompletionCallback into a Callback, it still belongs to that bug, because this is blocking changing TestCompletionCallback::callback() return type (at Bind() in AddressSorterTest.Sort). Bug: 807724 Change-Id: Ib5b366143657e1a7bbb14be3583825831ecc0001 Reviewed-on: https://chromium-review.googlesource.com/1160385Reviewed-by:
Ryan Hamilton <rch@chromium.org> Commit-Queue: Bence Béky <bnc@chromium.org> Cr-Commit-Position: refs/heads/master@{#580268}
-
Tim Volodine authored
Add activity to measure Tracing API related timings. In particular it allows to measure time for loading a given URL with or without tracing enabled. It also provides the overall tracing time, i.e. time it takes from starting tracing until completion when all traces are written to disk. Example usage: $ adb shell am start -n org.chromium.webview_shell/.WebViewTracingActivity -a VIEW -d \ http://www.google.com --ez enableTracing true BUG=797312 Change-Id: Iac5e871952d356762f351527b6aafdb4faf07255 Reviewed-on: https://chromium-review.googlesource.com/1153249 Commit-Queue: Tim Volodine <timvolodine@chromium.org> Reviewed-by:
-
Stefan Zager authored
Most of the functionality in these files interacts closely with layout and paint, so it makes sense to put them in core/ to eliminate needless indirection. Since there are no remaining sub-classes of ScrollableArea outside of core/ this is mostly a mechanical refactoring. The PlatformChromeClient class is removed here, as it is now obsolete. Previously, the only subclasses were ChromeClient (in core/page/) and a unit testing stub in platform/scroll/scrollbar_test_suite.h. Since scrollbar_test_suite.h has moved into core/scroll/, it can use EmptyChromeClient (from core/loader/), just as other unit tests in core/ do. BUG=823365 R=skobes@chromium.org,chrishtr@chromium.org Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng;luci.chromium.try:linux_layout_tests_slimming_paint_v2;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I08567764310b0190de45e40789d83ce80b600dd0 Reviewed-on: https://chromium-review.googlesource.com/1136888Reviewed-by:
Steve Kobes <skobes@chromium.org> Cr-Commit-Position: refs/heads/master@{#580266}
-
