GitLab

Bug: 850996
Change-Id: I20e1fa1e03c8c55d41f5a5a4e77f3c5059500b86
Reviewed-on: https://chromium-review.googlesource.com/1107306Reviewed-by: Filip Gorski <fgorski@chromium.org>
Commit-Queue: Becky Zhou <huayinz@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568874}

Bug: 849433
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: Ief1cca17a562786a6d838b9bdf27778918232dff
Reviewed-on: https://chromium-review.googlesource.com/1104969Reviewed-by: Kurt Horimoto <kkhorimoto@chromium.org>
Commit-Queue: Moe Ahmadi <mahmadi@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568873}

This fixes a bug where the window cannot be dragged from the space between tabs
and new tab button once the strip goes into overflow.

BUG=none
TEST=none

Change-Id: I2b4d244c8dc306fffe07fc8676c8eaffc19ec5d2
Reviewed-on: https://chromium-review.googlesource.com/1107381Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568872}

WebUI doesn't allow remote network connections anymore for security reasons.

Bug: 854410
Change-Id: I448b24e87659e1f4f0aa6955d9a0cda4bfe8c8ac
Reviewed-on: https://chromium-review.googlesource.com/1107202Reviewed-by: Katie Dektar <katie@chromium.org>
Commit-Queue: Dominic Mazzoni <dmazzoni@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568871}

The comment said "make sure none of the tabs are more than 90 apart", but the
code didn't do that.  Plus the functionality was obscured by the use of a helper
function that duplicated the "90" from the caller (but, as noted, only in the
comment), and didn't use all its args.

BUG=none
TEST=none

Change-Id: I979d7313286ac16234afad66de19350c136c156d
Reviewed-on: https://chromium-review.googlesource.com/1107385Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568870}

Especially in refresh, 400 feels too slow.  In testing, 200 seemed much better.

BUG=none
TEST=none

Change-Id: Ib7a8519fac9baadbd6853d6b5810644e4e2b7433
Reviewed-on: https://chromium-review.googlesource.com/1107383Reviewed-by: Allen Bauer <kylixrd@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568869}

Some members were being created on UI thread and used on IO thread which is
definitely not recommended.

Bug: 843205
Change-Id: Id1d6f0e66e8e11347e4ba4ef1a60d0559952d28d
Reviewed-on: https://chromium-review.googlesource.com/1108137
Commit-Queue: Mathieu Perreault <mathp@chromium.org>
Reviewed-by: Marc Treib <treib@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568868}

Remove shadow DOM support from waitForElement used in UI tests.
Reverts part of crosreview.com/1090517

Bug: 852324
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: If64176b0a9eee107afde06a2adb6bc076fb87e24
Reviewed-on: https://chromium-review.googlesource.com/1098910
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Reviewed-by: Luciano Pacheco <lucmult@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568867}

This conditional was apparently an attempt at an optimization, but it doesn't
appear in the case of painting tabs before the active tab, only ones after.
AFAICT in testing it makes no visual difference, and it makes the code harder to
understand.

BUG=none
TEST=none

Change-Id: If57e860df045fba45529e618530a3a2c4fe0d7df
Reviewed-on: https://chromium-review.googlesource.com/1107382Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568866}

Change-Id: Ib57fa2a98d6270721df67ff890b7961d09e209b9
Reviewed-on: https://chromium-review.googlesource.com/1107386Reviewed-by: Mike Wittman <wittman@chromium.org>
Commit-Queue: Xi Cheng <chengx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568865}

https://webrtc.googlesource.com/src.git/+log/056a68da896d..de212ca0391c


git log 056a68da896d..de212ca0391c --date=short --no-merges --format='%ad %ae %s'
2018-06-20 mbonadei@webrtc.org Removing some MSVC warning suppression flags.
2018-06-20 mbonadei@webrtc.org Add mbonadei@ to build configs OWNERS.
2018-06-20 mbonadei@webrtc.org Adding mbonadei@ to build_files WATCHLIST.
2018-06-20 sakal@webrtc.org Fix a bug where TestAudioDeviceModule crashes if destroyed uninitialized.
2018-06-20 kthelgason@webrtc.org Revert "Remove deprecated mac capture code."
2018-06-20 buildbot@webrtc.org Roll chromium_revision 20579735..e1ef7d4b (568689:568794)
2018-06-20 yvesg@webrtc.org Let git-hyper-blame ignore format commit.


Created with:
  gclient setdep -r src/third_party/webrtc@de212ca0391c

The AutoRoll server is located here: https://webrtc-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.mac:mac_chromium_archive_rel_ng

BUG=chromium:None,chromium:None,chromium:None
TBR=webrtc-chromium-sheriffs-robots@google.com

Change-Id: I8569aeb7d47e8f8e5ad9767b9edb44016264e63e
Reviewed-on: https://chromium-review.googlesource.com/1107940
Commit-Queue: Guido Urdaneta <guidou@chromium.org>
Commit-Queue: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Reviewed-by: webrtc-chromium-autoroll <webrtc-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568864}

https://android.googlesource.com/platform/external/perfetto.git/+log/b73eba800574..d40463e208e0


git log b73eba800574..d40463e208e0 --date=short --no-merges --format='%ad %ae %s'
2018-06-20 treehugger-gerrit@google.com Merge "perfetto-ui: Refactor bundle build rule"
2018-06-20 hjd@google.com Merge "traced_probes: Fix clock bug"
2018-06-20 hjd@google.com perfetto-ui: Refactor bundle build rule
2018-06-20 hjd@google.com traced_probes: Fix clock bug
2018-06-20 hjd@google.com Merge "perfetto-ui: Refactor sorcery build rule"
2018-06-19 hjd@google.com perfetto-ui: Refactor sorcery build rule


Created with:
  gclient setdep -r src/third_party/perfetto@d40463e208e0

The AutoRoll server is located here: https://perfetto-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:110356412
TBR=perfetto-bugs@google.com

Change-Id: I2c3980ca6c464b33452c432694bb603377e880be
Reviewed-on: https://chromium-review.googlesource.com/1107939
Reviewed-by: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: <perfetto-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568863}

This reverts commit e959c2d7.

Fixed by adding EXPORT macro on the new struct.

Original change's description:
> Revert "Add InitParams for views::AuraInit"
>
> This reverts commit dfd53f11.
>
> Reason for revert: GPU FYI Windows bots compile failure
> crbug.com/854442
>
> Compile error:
> [40824/45748] LINK task_viewer.service.exe task_viewer.service.exe.pdb
> FAILED: task_viewer.service.exe task_viewer.service.exe.pdb
> C:/b/swarming/w/ir/cache/vpython/80ee9f/Scripts/python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False ../../third_party/llvm-build/Release+Asserts/bin/lld-link.exe /nologo /OUT:./task_viewer.service.exe /PDB:./task_viewer.service.exe.pdb @./task_viewer.service.exe.rsp
> C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??0InitParams@AuraInit@views@@QEAA@XZ
> >>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ)
> C:\b\swarming\w\ir\cache\builder\src\third_party\llvm-build\Release+Asserts\bin\lld-link.exe: error: undefined symbol: ??1InitParams@AuraInit@views@@QEAA@XZ
> >>> referenced by obj/mash/task_viewer/lib/task_viewer.obj:(?OnStart@TaskViewer@task_viewer@mash@@EEAAXXZ)
>
> Original change's description:
> > Add InitParams for views::AuraInit
> >
> > It's up to 7 parameters and I'm about to add an 8th.
> >
> > Bug: 851578
> > Test: existing tests
> > Change-Id: I5dbfb98c90861a334ef9046cec4d69fb756879a1
> > Reviewed-on: https://chromium-review.googlesource.com/1106431
> > Reviewed-by: Scott Violet <sky@chromium.org>
> > Commit-Queue: James Cook <jamescook@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#568594}
>
> TBR=jamescook@chromium.org,sky@chromium.org
>
> Change-Id: Iea7d59178394a95cbc6f419cd7079d00d66a8ac6
> No-Presubmit: true
> No-Tree-Checks: true
> No-Try: true
> Bug: 851578, 854442
> Reviewed-on: https://chromium-review.googlesource.com/1107139
> Reviewed-by: weiliangc <weiliangc@chromium.org>
> Commit-Queue: weiliangc <weiliangc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568678}

TBR=jamescook@chromium.org,sky@chromium.org,weiliangc@chromium.org

Change-Id: Id0a3e75d0e02c87165375ecc345553041ecc4252
Bug: 851578, 854442
Reviewed-on: https://chromium-review.googlesource.com/1107997Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568862}

There is a desire to add more kinds of hang timeouts - in addition to
having an input-event-ack-timeout we also want to have
navigation-commit-timeout and possibly other timeouts.  This means that
HungRendererDialogView::Accept (handling "Wait" button in the "hung
renderer dialog") shouldn't be hardcoded to always call
RenderWidgetH::RestartHangMonitorTimeoutIfNecessary, but should instead
call a generic callback that will vary depending on the original source
of the dialog.  This CL enables future CLs (e.g.
https://crrev.com/c/1089797) that need to provide different ways of
restarting the hang timeout.

This CL refactors RWH::RestartHangMonitorTimeoutIfNecessary into a generic
base::RepeatingClosure passed as an argument of
WebContentsDelegate::RendererUnresponsive method.

I've tested this CL manually (on Linux) by:
1. Navigating 1st tab to https://peteblois.github.io/tmp/iframe_scrolling2/
2. Opening a second tab, navigating it to
   https://peteblois.github.io/tmp/iframe_kill/
   and switching back to the 1st tab.
3. Interacting with the OOPIF (for example double-clicking to select
   some of the words) and waiting 30 seconds for the hung renderer
   dialog to appear.
4. Clicking "Wait" button in the dialog
5. Verifying that the dialog reappears after 30 seconds

Bug: 848821
Change-Id: I2d133483832ca3d640a74c9f23fc9677f478721d
Reviewed-on: https://chromium-review.googlesource.com/1096362
Commit-Queue: Łukasz Anforowicz <lukasza@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Lucas Gadani <lfg@chromium.org>
Reviewed-by: Bo <boliu@chromium.org>
Reviewed-by: Alex Moshchuk <alexmos@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568861}

This allows the user to enable/disable the Translate popup, either in
chrome://flags, or by using the `--disable-features=TranslateUI`
command-line flag.

Bug: 770776
Change-Id: I66af0ce5de568bafb45e0e501cb4f481ac6d6fb3
Reviewed-on: https://chromium-review.googlesource.com/1105311
Commit-Queue: Nicolas Ouellet-Payeur <nicolaso@chromium.org>
Reviewed-by: Michael Martis <martis@chromium.org>
Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568860}

WindowTreeFactory owns any WindowTrees that were created by way of
ui::mojom::WindowTreeFactory. So, WindowTreeFactory needs to be deleted before
the DCHECK that there are no more WindowTrees.

BUG=854336
TEST=covered by test

Change-Id: Idba2928244721579e694b434415b95cbbdf4b360
Reviewed-on: https://chromium-review.googlesource.com/1107136
Commit-Queue: Scott Violet <sky@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568859}

Since dom_keycode_converter is a static_library(), having it be a public
dependency of a component() doesn't make sense - consumers of the
events_base target can import the headers, but they refer to symbols
that the component's dynamic library doesn't export.

Change-Id: I859764fb50324fed1d22bc0ee8335d057c73771d
Reviewed-on: https://chromium-review.googlesource.com/1107310Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Wez <wez@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568858}

Bug: 852324
Cq-Include-Trybots: luci.chromium.try:closure_compilation
Change-Id: I534f67d93048d4e2e87db2fb3098513511a509ac
Reviewed-on: https://chromium-review.googlesource.com/1098912Reviewed-by: Naoki Fukino <fukino@chromium.org>
Reviewed-by: Noel Gordon <noel@chromium.org>
Commit-Queue: Joel Hockey <joelhockey@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568857}

https://skia.googlesource.com/skia.git/+log/4359d529121f..53418da8c647


git log 4359d529121f..53418da8c647 --date=short --no-merges --format='%ad %ae %s'
2018-06-20 mtklein@chromium.org exclude _none_imagefilters.cpp in Google3
2018-06-20 rmistry@google.com Fix license file in compute/skc/main.c
2018-06-20 rmistry@google.com [Bookmaker] Point to new fiddlecli location
2018-06-20 robertphillips@google.com Fix degenerate case handling in fill_in_2D_gaussian_kernel
2018-06-20 borenet@google.com Update skia swarming task template to git 2.17.1
2018-06-20 angle-skia-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com Roll third_party/externals/angle2 4004ae0e033a..a914f7ff310d (1 commits)


Created with:
  gclient setdep -r src/third_party/skia@53418da8c647

The AutoRoll server is located here: https://autoroll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel;luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG=chromium:849016,chromium:847597
TBR=kjlubick@chromium.org

Change-Id: I25d536203c78f4d829ab7a0bda506415688d9e87
Reviewed-on: https://chromium-review.googlesource.com/1107937Reviewed-by: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: skia-chromium-autoroll <skia-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568856}

Move most code controlling the search provider logo, fake search box,
bookmarks/downloads shortcuts, and most likely tiles from NewTabPageView
to NewTabPageLayout.

These views are all children of NewTabPageLayout, so organizationally it
makes more sense for NewTabPageLayout to own and control them. This is
a step toward making NewTabPageLayout re-usable for the FeedNewTabPage.

There will be additional work to finish cleaning up
and refactoring NewTabPageView and NewTabPageLayout to bring them closer
to the new MVC architecture.

BUG=827334

Change-Id: Ia08a0f9636ee7919fea2582c7b15fb9a57ed28bf
Reviewed-on: https://chromium-review.googlesource.com/1103388Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Reviewed-by: Becky Zhou <huayinz@chromium.org>
Commit-Queue: Theresa <twellington@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568855}

https://chromium.googlesource.com/chromium/tools/depot_tools.git/+log/1cabdc464313..49083eaa9300


git log 1cabdc464313..49083eaa9300 --date=short --no-merges --format='%ad %ae %s'
2018-06-20 vapier@chromium.org pylint: update to 1.4.5


Created with:
  gclient setdep -r src/third_party/depot_tools@49083eaa9300

The AutoRoll server is located here: https://depot-tools-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:None
TBR=agable@chromium.org

Change-Id: I25691eba67aba0610b1fbf02545bc3b4cba06881
Reviewed-on: https://chromium-review.googlesource.com/1108017Reviewed-by: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: depot-tools-chromium-autoroll <depot-tools-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568854}

IsAccountConsistencyMirrorEnabled is deprecated, because Mirror can now be enabled
on a per-profile bases.
This CL replaces the calls by the new API (AccountConsistencyModeManager) and
cleans up unnecessary calls.

TBR=sky

Bug: 777774
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I19e9ecc779b90911f6e4e63a11850417c9eddbdf
Reviewed-on: https://chromium-review.googlesource.com/1104682
Commit-Queue: David Roger <droger@chromium.org>
Reviewed-by: Mihai Sardarescu <msarda@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568853}

This CL changes the toolbar so when the location bar is focused in
iPhone landscape, the cancel button is shown, as it is done in
portrait.

Bug: 847847
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I351d166e52d80975579bf6c74fd44230543b4ce1
Reviewed-on: https://chromium-review.googlesource.com/1107634
Commit-Queue: Gauthier Ambard <gambard@chromium.org>
Reviewed-by: Olivier Robin <olivierrobin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568852}

PaintTiming.NavigationToFirstPaint is one of key loading metrics, and we'd add
it before starting ServceWorkerServicification (a.k.a NetS13nServiceWorker)
experiement.

Bug: 852698
Change-Id: I2d7b7ad9ef3df94d428e1fbcbc1148de27e45c6a
Reviewed-on: https://chromium-review.googlesource.com/1107418Reviewed-by: Matt Falkenhagen <falken@chromium.org>
Reviewed-by: Kinuko Yasuda <kinuko@chromium.org>
Reviewed-by: Ilya Sherman <isherman@chromium.org>
Commit-Queue: Matt Falkenhagen <falken@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568851}

This CL adds a list attribute 'BlacklistedHexSSIDs' to ONC's global
configuration. This attribute can be used to block connections to
certain WiFi SSIDs. Current connections to blacklisted networks are
disconnected, once the policy is applied.
This policy is only enforced in Chrome. However, by disabling
auto-connect for all blacklisted networks, we can prevent Shill from
re-connecting to those networks while searching for the best network to
connect.

DesignDoc: http://go/cros-blacklist-ssids

Bug: 837205
Change-Id: I1d80929a00dd042db7aef877d663febc3f170d05
Reviewed-on: https://chromium-review.googlesource.com/1091053
Commit-Queue: Alexander Hendrich <hendrich@chromium.org>
Reviewed-by: Cait Phillips <caitkp@chromium.org>
Reviewed-by: Steven Bennetts <stevenjb@chromium.org>
Reviewed-by: Maksim Ivanov <emaxx@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568850}

https://pdfium.googlesource.com/pdfium.git/+log/e005dc33c31a..b6e0117285a9


git log e005dc33c31a..b6e0117285a9 --date=short --no-merges --format='%ad %ae %s'
2018-06-20 rharrison@chromium.org Add in a size guard to JPX fuzzer


Created with:
  gclient setdep -r src/third_party/pdfium@b6e0117285a9

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG=chromium:834561
TBR=dsinclair@chromium.org

Change-Id: I4ac1250c2e205994b6594b5a06bb34e6bd07e7fc
Reviewed-on: https://chromium-review.googlesource.com/1107938Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568849}

Bug: 848388, 850745

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: I6bacef1ca791ff7e00769258f3bce99ef4954b59
Reviewed-on: https://chromium-review.googlesource.com/1106614Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Reviewed-by: Chris Blume <cblume@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568848}

Accidentally left in a line of the old setup in
https://chromium-review.googlesource.com/1089661. It's harmless, but
not needed any more.

Bug: 837354
Change-Id: Ic7a01e407d8666b2eede34d65a7186f212d1fddb
Reviewed-on: https://chromium-review.googlesource.com/1106008Reviewed-by: Asanka Herath <asanka@chromium.org>
Commit-Queue: Matt Menke <mmenke@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568847}

This reverts commit d201cbeb.

Reason for revert: FindIt identified this CL as the culprit for several failures: crbug.com/854600

Original change's description:
> Run some file manager browsertests with DriveFS enabled.
> 
> Bug: 848126
> Change-Id: Ifd3cf1996fdb33f5d0d93f5c5cf721abd5440d29
> Reviewed-on: https://chromium-review.googlesource.com/1102279
> Reviewed-by: Noel Gordon <noel@chromium.org>
> Commit-Queue: Sam McNally <sammc@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#568339}

TBR=noel@chromium.org,sammc@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 848126
Change-Id: Ifc9b0a77c76ba647bd5a85102b286fd5b2d1073f
Reviewed-on: https://chromium-review.googlesource.com/1107998Reviewed-by: anthonyvd <anthonyvd@chromium.org>
Commit-Queue: anthonyvd <anthonyvd@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568846}

This reverts commit dbbd9b76.

Reason for revert: contrast ratio for links is below 4.5:1 threshold

Original change's description:
> [Views] Adjust secondary info and link style colors for MD2
>
> Source: https://docs.google.com/presentation/d/1EO7TOpIMJ7QHjaTVw9St-q6naKwtXX2TwzMirG5EsKY/edit#slide=id.g399d5e0d81_22_0
>
> Bug: 852094
> Change-Id: I0bbfc28d214bed310fdb4a23cd804442d5751590
> Reviewed-on: https://chromium-review.googlesource.com/1099560
> Reviewed-by: Michael Wasserman <msw@chromium.org>
> Reviewed-by: Evan Stade <estade@chromium.org>
> Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#567152}

TBR=msw@chromium.org,estade@chromium.org,ftirelo@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 852094, 853637
Change-Id: I169e1f39d120c714e37c0534115d692a499c591f
Reviewed-on: https://chromium-review.googlesource.com/1106457
Commit-Queue: Fabio Tirelo <ftirelo@chromium.org>
Reviewed-by: Fabio Tirelo <ftirelo@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568845}

Rename to AppLauncherAbuseDetector because the PolicyDecider is going to be
used for the webstate policydecider in the AppLauncherTabHelper

Bug: 850760
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I0b39ca366d1e34a9b6db8217a89a1d5b68405ecb
Reviewed-on: https://chromium-review.googlesource.com/1107038Reviewed-by: Eugene But <eugenebut@chromium.org>
Commit-Queue: Mohammad Refaat <mrefaat@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568844}

Disabling EarlGrey tests from SigninInteractionControllerTestCase:
 + testSignInSwitchAccountsAndKeepDataSeparate
 + testSignInSwitchAccountsAndImportData
 + testSignInSwitchManagedAccount

Those tests seem to trigger an issue in the sync code when doing enable
disable enable too fast.

Bug: 854446
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I76d10d272297e91650dbe91ef7acee500eac6c75
Reviewed-on: https://chromium-review.googlesource.com/1107881Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Jérôme Lebel <jlebel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568843}

https://crrev.com/c008bf657dbc01fadc4ff1ea3df21f9cf237569a added support
for IPv6 patterns with URLPattern and activeTab, so we can now enable
the tests for captureVisibleTab using IPv6 URLs.

Bug: 839857
Change-Id: I29eec17b176c54a312cfdf5dc7d11c50b7b245f9
Reviewed-on: https://chromium-review.googlesource.com/1107243Reviewed-by: Karan Bhatia <karandeepb@chromium.org>
Commit-Queue: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568842}

Implement SkiaRenderer::CopyDrawnRenderPass() by posting a task to GPU main
thread to copy output from offscreen SkSurface for render passes or the
framebuffer SkSurface for the frame.

This CL also enable all existing pixel tests with SkaRenderer + SkDDL code path.


Bug: 824382
Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel
Change-Id: I707d555c2973eb81294b29b813d4538ab671a3c0
Reviewed-on: https://chromium-review.googlesource.com/1089451Reviewed-by: Ken Rockot <rockot@chromium.org>
Reviewed-by: Antoine Labour <piman@chromium.org>
Reviewed-by: danakj <danakj@chromium.org>
Reviewed-by: Robert Kroeger <rjkroege@chromium.org>
Commit-Queue: Peng Huang <penghuang@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568841}

Add convenience link for sheriffs to easily access size bugs.

Bug: None
Change-Id: I04e9ad3041c49cdfa0e0d0e78ca1f5cd0e7cab66
Reviewed-on: https://chromium-review.googlesource.com/1107848Reviewed-by: Eric Stevenson <estevenson@chromium.org>
Commit-Queue: Peter Wen <wnwen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568840}

...as it's currently failing on the Linux MSan bot.

Bug: 854599
Change-Id: I36a19408db4bb37ed667ac67f62e05fbf404eb60
TBR: hajimehoshi@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1107923Reviewed-by: Martin Šrámek <msramek@chromium.org>
Commit-Queue: Martin Šrámek <msramek@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568839}

https://chromium.googlesource.com/angle/angle.git/+log/a914f7ff310d..66c2f4afe3c2


git log a914f7ff310d..66c2f4afe3c2 --date=short --no-merges --format='%ad %ae %s'
2018-06-20 lucferron@chromium.org Vulkan: Add test and fix clear on RGB8 with color masks


Created with:
  gclient setdep -r src/third_party/angle@66c2f4afe3c2

The AutoRoll server is located here: https://angle-chromium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
TBR=cwallez@chromium.org

Change-Id: I954361c5a4d73f55d6f9fce7f2706fe5c2f3305e
Reviewed-on: https://chromium-review.googlesource.com/1107817Reviewed-by: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: angle-chromium-autoroll <angle-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#568838}

TBR=eugenebut@chromium.org

Bug: 854615
Cq-Include-Trybots: luci.chromium.try:ios-simulator-full-configs;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I7cc280c03203696c0fa00081b15736d6245d4ba5
Reviewed-on: https://chromium-review.googlesource.com/1107880Reviewed-by: Justin Cohen <justincohen@chromium.org>
Commit-Queue: Justin Cohen <justincohen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568837}

When building chrome on windows, tool-wrapper for linking is called 794 times.
And I found that calling python wrapper is relatively slow than calling link via ninja.

This CL replaces python wrapper to ninja wrapper to remove such overhead when we use lld.

I compared time of wrapper invocation using following powershell script.

for ($i = 0; $i -lt 100; $i++) {
    # ninja -t msvc -e environment.x64 -- C:/src/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe -c ' '
    # python.exe ../../build/toolchain/win/tool_wrapper.py link-wrapper environment.x64 False C:/src/depot_tools/win_tools-2_7_6_bin/python/bin/python.exe -c ' ' # code for FlushFileBuffers is commented out.
}

* ninja wrapper, 7.451s for 100 invocation
* python wrapper, 17.803s for 100 invocation
Using ninja as env wrapper is more than 2 times faster.

Bug: 787903
Change-Id: I6531b59a6c43085782b0138a264ecfc9a6f65833
Reviewed-on: https://chromium-review.googlesource.com/1107678
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568836}

This patch rebaselines 1px differences in the baseline
positioning when the 'vertical-aling' property is used.

Legacy computes the baseline position in multiple steps,
while NG computes in single function. This difference
causes slight rounding differences.

TBR=atoti@chromium.org
NOTRY=true

Bug: 636993
Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng
Change-Id: Ia2adec046f2ac13dfb4d479e8ffa56cb4a3bd040
Reviewed-on: https://chromium-review.googlesource.com/1107860
Commit-Queue: Koji Ishii <kojii@chromium.org>
Reviewed-by: Koji Ishii <kojii@chromium.org>
Cr-Commit-Position: refs/heads/master@{#568835}